Re: CFV: New OpenJFX Committer: Jayathirth D V

2024-11-08 Thread Nir Lisker
Vote: YES On Fri, Nov 8, 2024 at 3:48 PM Kevin Rushforth wrote: > Vote: YES > > -- Kevin > > On 11/8/2024 5:46 AM, Kevin Rushforth wrote: > > I hereby nominate Jayathirth D V [1] to OpenJFX Committer. > >

Re: [Kgdb-bugreport] [PATCH v4 0/3] Replace the use of simple_strtol/ul functions with kstrto

2024-11-08 Thread Nir Lichtman
On Fri, Nov 08, 2024 at 08:38:35AM +, Daniel Thompson wrote: > > On Mon, 28 Oct 2024 19:17:00 +0000, Nir Lichtman wrote: > > The simple_str* family of functions perform no error checking in > > scenarios where the input value overflows the intended output variable. > &g

Re: [PATCH v4 0/3] Replace the use of simple_strtol/ul functions with kstrto

2024-11-08 Thread Nir Lichtman
On Fri, Nov 08, 2024 at 08:38:35AM +, Daniel Thompson wrote: > > On Mon, 28 Oct 2024 19:17:00 +0000, Nir Lichtman wrote: > > The simple_str* family of functions perform no error checking in > > scenarios where the input value overflows the intended output variable. > &g

Re: Proposal: JavaFX Incubator Modules

2024-11-06 Thread Nir Lisker
Being able to add an API without the guarantee for backwards compatibility (temporarily) is obviously alleviating to the developers and will ensure a better end result. My only concern is the amount of usability this can get. Incubating modules usually offer a substantial amount of code. In the JDK

Re: JEP: JavaFX controls in the title bar

2024-11-05 Thread Nir Lisker
By the way, I came across this project: https://github.com/xdsswar/nfx-lib?tab=readme-ov-file. It's only for Windows, but allows manipulation of the title bar. Might be good to compare with in terms of functionality. On Mon, Oct 28, 2024 at 8:27 PM Andy Goryachev wrote: > Dear Michael: > > > > C

[Acme] Re: Timeslot at dublin for acme-rats-00

2024-11-05 Thread Yoav Nir
Thanks. I’ve accepted the slides in the system, and updated the agenda. > On 5 Nov 2024, at 10:11, Liuchunchi(Peter) wrote: > > Thank you! I attached it in the email, and also proposed the slides in the > system. > > See you Wednesday :-) > P > From: Yoav Nir >

Re: CFV: New OpenJFX Reviewer: Michael Strauß

2024-11-05 Thread Nir Lisker
Vote: YES On Tue, Nov 5, 2024 at 5:02 PM Kevin Rushforth wrote: > Vote: YES > > > On 11/5/2024 7:01 AM, Kevin Rushforth wrote: > > I hereby nominate Michael Strauß [1] to OpenJFX Reviewer. >

[Acme] Re: More detailed checking interval in ARI

2024-11-04 Thread Yoav Nir
Thanks for that. If I’m reading this correctly, this is all clarification, not bits-on-the-wire changes. Changes like that can be added after WGLC if they don’t raise objections. I see that you are not registered for the IETF meeting, so it probably doesn’t make sense to discuss it at the ACM

[Acme] Re: Timeslot at dublin for acme-rats-00

2024-11-04 Thread Yoav Nir
Sure. We’ll add it to the agenda. Just please send slides tomorrow (Tuesday) > On 3 Nov 2024, at 17:42, Liuchunchi(Peter) > wrote: > > Hi chairs, > > Just saw the posted 121 acme agenda, can’t help but notice that we have a 1.5 > hour session but only a 1 hour agenda. Can I make use of t

[Acme] Publication has been requested for draft-ietf-acme-ari-06

2024-11-04 Thread Yoav Nir via Datatracker
Yoav Nir has requested publication of draft-ietf-acme-ari-06 as Proposed Standard on behalf of the ACME working group. Please verify the document's state at https://datatracker.ietf.org/doc/draft-ietf-acme-ari/ ___ Acme mailing list -- acme@iet

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v6]

2024-10-29 Thread Nir Lisker
On Tue, 29 Oct 2024 21:47:53 GMT, John Hendrikx wrote: > > > Also something that just occurred to me, but perhaps I'm late to the > > > party; with the current API being on `Node` you could call > > > `requestFocusTraversal` on basically any `Node`, even one that is > > > currently not focused

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v6]

2024-10-29 Thread Nir Lisker
On Tue, 29 Oct 2024 21:31:59 GMT, John Hendrikx wrote: > Also something that just occurred to me, but perhaps I'm late to the party; > with the current API being on `Node` you could call `requestFocusTraversal` > on basically any `Node`, even one that is currently not focused. I'm not sure > i

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v4]

2024-10-29 Thread Nir Lisker
On Tue, 29 Oct 2024 16:00:43 GMT, Kevin Rushforth wrote: >> Sure: >> >> >> String s = switch(val) { >> case 1 -> >> "one"; >> case 2 -> >> "two"; >> default -> >> "unknown"; >> }; > > That isn't an example of "everything on one line". That's effectively the > "switch case :, on

[Bug 2084104] Re: UEFI GRUB2 enforces NX even with a non-NX shim

2024-10-29 Thread And NIr
The fix using the oracular-proposed packages worked for me too! I'm using a Thinkpad E570, dual boot with Windows 10. Thanks a lot for for your work on this! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/b

[Acme] Re-confirming draft-ietf-acme-dtnnodeid-15

2024-10-28 Thread Yoav Nir
Hi, folks. The subject draft was approved in the ACME group back in 2021. Since then it has been waiting on a dependency from the DTN group. This is finally resolved, and our (former) AD asked us to re-confirm consensus before proceeding it. If you have any objectsions to having this draft pr

[Acme] Re: WGLC for draft-ietf-acme-ari

2024-10-28 Thread Yoav Nir
Hi, Again. On 7 Oct 2024, at 20:56, Yoav Nir wrote: > Hi, all > > This begins a working group last call for the ARI draft [1] > > If you haven’t done so recently, please read the latest (-05) version of the > draft, and send comments to the list. > > Due to th

[Kgdb-bugreport] [PATCH v4 3/3] kdb: Remove fallback interpretation of arbitrary numbers as hex

2024-10-28 Thread Nir Lichtman
Remove logic that enables a fallback of interpreting numbers supplied in KDB CLI to be interpreted as hex without explicit "0x" prefix as this can be confusing for the end users. Suggested-by: Douglas Anderson Reviewed-by: Douglas Anderson Signed-off-by: Nir Lichtman --- kernel

[PATCH v4 3/3] kdb: Remove fallback interpretation of arbitrary numbers as hex

2024-10-28 Thread Nir Lichtman
Remove logic that enables a fallback of interpreting numbers supplied in KDB CLI to be interpreted as hex without explicit "0x" prefix as this can be confusing for the end users. Suggested-by: Douglas Anderson Reviewed-by: Douglas Anderson Signed-off-by: Nir Lichtman --- kernel

[PATCH v4 2/3] trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdump

2024-10-28 Thread Nir Lichtman
Hiramatsu (Google) [nir: style fixes] Signed-off-by: Nir Lichtman --- kernel/trace/trace_kdb.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/kernel/trace/trace_kdb.c b/kernel/trace/trace_kdb.c index 59857a1ee44c..1e72d20b3c2f 100644 --- a/kernel/trace/trace_k

[Kgdb-bugreport] [PATCH v4 2/3] trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdump

2024-10-28 Thread Nir Lichtman
Hiramatsu (Google) [nir: style fixes] Signed-off-by: Nir Lichtman --- kernel/trace/trace_kdb.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/kernel/trace/trace_kdb.c b/kernel/trace/trace_kdb.c index 59857a1ee44c..1e72d20b3c2f 100644 --- a/kernel/trace/trace_k

[Kgdb-bugreport] [PATCH v4 1/3] kdb: Replace the use of simple_strto with safer kstrto in kdb_main

2024-10-28 Thread Nir Lichtman
ourse, results in cleaner, yet still easy to understand code. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Signed-off-by: Yuran Pereira [nir: addressed review comments by fixing styling, invalid conversion and a

[PATCH v4 1/3] kdb: Replace the use of simple_strto with safer kstrto in kdb_main

2024-10-28 Thread Nir Lichtman
ourse, results in cleaner, yet still easy to understand code. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Signed-off-by: Yuran Pereira [nir: addressed review comments by fixing styling, invalid conversion and a

[PATCH v4 0/3] Replace the use of simple_strtol/ul functions with kstrto

2024-10-28 Thread Nir Lichtman
er kstrto* alternatives. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Yuran Pereira (2): kdb: Replace the use of simple_strto with safer kstrto in kdb_main trace: kdb: Replace simple_strtoul with kstrtoul in kdb_

[Kgdb-bugreport] [PATCH v4 0/3] Replace the use of simple_strtol/ul functions with kstrto

2024-10-28 Thread Nir Lichtman
er kstrto* alternatives. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Yuran Pereira (2): kdb: Replace the use of simple_strto with safer kstrto in kdb_main trace: kdb: Replace simple_strtoul with kstrtoul in kdb_

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v4]

2024-10-28 Thread Nir Lisker
On Mon, 28 Oct 2024 16:13:37 GMT, Andy Goryachev wrote: >> Public focus traversal API for use in custom controls >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md >> >> This work is loosely based on the patch >> https://cr.openjdk.org/~jgiles/

[Kgdb-bugreport] [PATCH v3 2/3] trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdump

2024-10-28 Thread Nir Lichtman
Hiramatsu (Google) [nir: style fixes] Signed-off-by: Nir Lichtman --- kernel/trace/trace_kdb.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/kernel/trace/trace_kdb.c b/kernel/trace/trace_kdb.c index 59857a1ee44c..eadda6e05526 100644 --- a/kernel/trace/trace_k

Re: [Kgdb-bugreport] [PATCH v2] KDB: Fix incorrect treatment of numbers in the CLI

2024-10-28 Thread Nir Lichtman
On Mon, Oct 21, 2024 at 10:14:15AM -0700, Doug Anderson wrote: > Hi, > > On Sat, Oct 19, 2024 at 1:42 PM Nir Lichtman wrote: > > > > Problem: In many cases, KDB treats invalid commands as numbers and > > instead of printing a usage error, goes ahead and just p

[Kgdb-bugreport] [PATCH v2 1/2] kdb: Replace the use of simple_strto with safer kstrto in kdb_main

2024-10-28 Thread Nir Lichtman
in cleaner, yet still easy to understand code. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Signed-off-by: Yuran Pereira Signed-off-by: Nir Lichtman --- kernel/debug/kdb/kdb_main.c | 69 +--

[Kgdb-bugreport] [PATCH v2 2/2] trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdump

2024-10-28 Thread Nir Lichtman
ses of the simple_strtoul with the safer alternatives kstrtoint and kstrtol. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Signed-off-by: Yuran Pereira Signed-off-by: Nir Lichtman --- kernel/trace/trace_

[Kgdb-bugreport] [PATCH v2 0/2] Replace the use of simple_strtol/ul functions with kstrto

2024-10-28 Thread Nir Lichtman
er kstrto* alternatives. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Yuran Pereira (2): kdb: Replace the use of simple_strto with safer kstrto in kdb_main trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdum

[Kgdb-bugreport] [PATCH v3 0/2] Replace the use of simple_strtol/ul functions with kstrto

2024-10-28 Thread Nir Lichtman
er kstrto* alternatives. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Yuran Pereira (2): kdb: Replace the use of simple_strto with safer kstrto in kdb_main trace: kdb: Replace simple_strtoul with kstrtoul in kdb_

[Kgdb-bugreport] [PATCH v3 3/3] kdb: Remove fallback interpretation of arbitrary numbers as hex

2024-10-28 Thread Nir Lichtman
Remove logic that enables a fallback of interpreting numbers supplied in KDB CLI to be interpreted as hex without explicit "0x" prefix as this can be confusing for the end users. Suggested-by: Douglas Anderson Signed-off-by: Nir Lichtman --- kernel/debug/kdb/kdb_m

[Kgdb-bugreport] [PATCH v2] KDB: Fix incorrect treatment of numbers in the CLI

2024-10-28 Thread Nir Lichtman
Solution: Transition to using kstrtoul instead of simple_strtoul. This function is more strict with what it treats as a number and thus solves the issue. (also better practice as stated in the definition of simple_strtoul). v2: Removed redundant if condition I put in v1 Signed-off-by: Nir Lichtman --- ke

[Kgdb-bugreport] [PATCH] KDB: Fix incorrect treatment of numbers in the CLI

2024-10-28 Thread Nir Lichtman
on: Before assuming that the input from the user is a number, check that it contains only characters that represent numbers. Also, along the way, transition to using kstrtoul instead of simple_strtoul (better practice as stated in the definition of the function) Signed-off-by: Nir Lichtman --- ke

[Kgdb-bugreport] [PATCH v3 1/3] kdb: Replace the use of simple_strto with safer kstrto in kdb_main

2024-10-28 Thread Nir Lichtman
ourse, results in cleaner, yet still easy to understand code. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Signed-off-by: Yuran Pereira [nir: addressed review comments by fixing styling, invalid conversion and a

[PATCH v3 3/3] kdb: Remove fallback interpretation of arbitrary numbers as hex

2024-10-26 Thread Nir Lichtman
Remove logic that enables a fallback of interpreting numbers supplied in KDB CLI to be interpreted as hex without explicit "0x" prefix as this can be confusing for the end users. Suggested-by: Douglas Anderson Signed-off-by: Nir Lichtman --- kernel/debug/kdb/kdb_m

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v3]

2024-10-26 Thread Nir Lisker
On Fri, 25 Oct 2024 16:22:01 GMT, Andy Goryachev wrote: >> Public focus traversal API for use in custom controls >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md >> >> This work is loosely based on the patch >> https://cr.openjdk.org/~jgiles/

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v2]

2024-10-26 Thread Nir Lisker
On Fri, 25 Oct 2024 17:40:36 GMT, John Hendrikx wrote: >> Of these, I like `requestFocusTraversal` best. Another alternative: >> `requestMoveFocus`. > > Plain `requestFocus` can also work as it can be overloaded with the direction > parameter. I like the overloaded `requestFocus` idea as well.

[PATCH v3 2/3] trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdump

2024-10-26 Thread Nir Lichtman
Hiramatsu (Google) [nir: style fixes] Signed-off-by: Nir Lichtman --- kernel/trace/trace_kdb.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/kernel/trace/trace_kdb.c b/kernel/trace/trace_kdb.c index 59857a1ee44c..eadda6e05526 100644 --- a/kernel/trace/trace_k

[PATCH v3 1/3] kdb: Replace the use of simple_strto with safer kstrto in kdb_main

2024-10-26 Thread Nir Lichtman
ourse, results in cleaner, yet still easy to understand code. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Signed-off-by: Yuran Pereira [nir: addressed review comments by fixing styling, invalid conversion and a

[PATCH v3 0/2] Replace the use of simple_strtol/ul functions with kstrto

2024-10-26 Thread Nir Lichtman
er kstrto* alternatives. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Yuran Pereira (2): kdb: Replace the use of simple_strto with safer kstrto in kdb_main trace: kdb: Replace simple_strtoul with kstrtoul in kdb_

Re: Proposal: Focus Traversal API

2024-10-23 Thread Nir Lisker
> > My only problem with a more assertive “moveFocus” is that it implies a > success True, but the JDK already uses it everywhere. Mutation methods on collections are all named as definitive actions even if they don't succeed. In general, setters might also fail (usually in the case of NPE), but

Re: RFR: 8313424: JavaFX controls in the title bar [v3]

2024-10-22 Thread Nir Lisker
On Sun, 20 Oct 2024 01:23:01 GMT, Michael Strauß wrote: >> This PR is a new take on a highly requested feature: JavaFX controls in the >> header bar (see also #594 for an earlier iteration). >> >> This is a feature with many possible ways to skin the cat, and it has taken >> quite a bit of eff

[PATCH v2 2/2] trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdump

2024-10-21 Thread Nir Lichtman
ses of the simple_strtoul with the safer alternatives kstrtoint and kstrtol. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Signed-off-by: Yuran Pereira Signed-off-by: Nir Lichtman --- kernel/trace/trace_

[PATCH v2 1/2] kdb: Replace the use of simple_strto with safer kstrto in kdb_main

2024-10-21 Thread Nir Lichtman
in cleaner, yet still easy to understand code. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Signed-off-by: Yuran Pereira Signed-off-by: Nir Lichtman --- kernel/debug/kdb/kdb_main.c | 69 +--

[PATCH v2 0/2] Replace the use of simple_strtol/ul functions with kstrto

2024-10-21 Thread Nir Lichtman
er kstrto* alternatives. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull Yuran Pereira (2): kdb: Replace the use of simple_strto with safer kstrto in kdb_main trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdum

Re: [Feature Proposal]: TriangleMesh - Vertex Color Support

2024-10-18 Thread Nir Lisker
getVertexIndexSize() to > TriangleMesh as well, since there would be no way to get this information > anymore. > > Should I continue with this approach, or should we discuss further? > > On Wed, Oct 16, 2024 at 1:57 AM Nir Lisker wrote: > >> I've got no objections

Re: [External] : Re: JavaFX Direct3D 12 rendering pipeline for Windows

2024-10-17 Thread Nir Lisker
works and because it works with C and not completely with C++. As for what to move to the Java side, there could be a performance tradeoff between an increased number of native calls and the ability of the JIT to optimize them. There are tricks there that we could use. There will be quite a bit to

Re: RFR: 8301761: The sorting of the SortedList can become invalid [v4]

2024-10-16 Thread Nir Lisker
On Mon, 7 Oct 2024 16:25:22 GMT, Loay Ghreeb wrote: >> Fix an issue in `SortedList` where the sorting became incorrect when adding >> new items that are equal to existing items according to the comparator. The >> `SortedList` should consider the insertion index of these items to maintain >> th

Re: [Feature Proposal]: TriangleMesh - Vertex Color Support

2024-10-16 Thread Nir Lisker
is likely to > change (which would be the benefit of a method), and it avoids clutter for > a simple operation. > > I'm happy with this approach, shall I go ahead and make those changes? > > On Wed, Oct 9, 2024, 2:24 PM Nir Lisker wrote: > >> The code snippet return

Re: RFR: 8306707: Support pluggable image loading via javax.imageio

2024-10-15 Thread Nir Lisker
On Mon, 7 Oct 2024 15:13:17 GMT, Michael Strauß wrote: > This PR is an improved version of #1093. > > JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image > loaders. It has been a long-standing request to support more image formats, > most notably (but not limited to) SVG. Ho

Re: JavaFX Direct3D 12 rendering pipeline for Windows

2024-10-15 Thread Nir Lisker
This is exciting news! I looked at the code quickly. Here are my thoughts. My biggest remark is that JNI is still being used, which is being more and more restricted. Recently, Kevin announced that we will be FFM-ready, surely by the time this pipeline is released. I would like to see (and can he

Re: JavaFX Direct3D 12 rendering pipeline for Windows

2024-10-15 Thread Nir Lisker
D3D9 is 20 years old (even if it's still getting updated) and graphic cards aren't optimized for it. Computer Graphics is an area where the coupling of hardware and software is much stronger than what Java developers are used to with its abstractions over hardware, and modern graphics hardware assu

Re: [Feature Proposal]: TriangleMesh - Vertex Color Support

2024-10-09 Thread Nir Lisker
oices > (as you've noticed with normals), but it is one of the paths I can see > working. > > > On Mon, Sep 30, 2024, 2:58 AM Nir Lisker wrote: > >> I would first try to figure out if the code in the snippet I gave is >> actually correct. If it is, then the vertex

Re: RFR: 8090456: Focus Management [v8]

2024-10-09 Thread Nir Lisker
On Wed, 2 Oct 2024 17:33:15 GMT, Andy Goryachev wrote: >> Public APIs for focus traversal and the focus traversal policy: >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md >> >> This work is loosely based on the patch >> https://cr.openjdk.org/~j

Re: RFR: 8090456: Focus Management [v8]

2024-10-09 Thread Nir Lisker
On Tue, 8 Oct 2024 14:44:37 GMT, Andy Goryachev wrote: > FocusTraversal accepts null nodes, making the code more resilient In what way is it more resilient? `traverse` does nothing if the node is `null`, which means that passing `null` is a bug more often than not. `null` nodes can't be displa

Re: RFR: 8339603: Seal the class hierarchy of Node, Camera, LightBase, Shape, Shape3D [v3]

2024-10-07 Thread Nir Lisker
On Tue, 8 Oct 2024 04:25:53 GMT, Michael Strauß wrote: > > If this goes forward, please seal `Material` as well. > > If we seal `Material`, we should probably also seal `Paint`. What do you > think? I don't see why they are related, but if `Paint` can't be subclassed then I don't see a reason

Re: RFR: 8090456: Focus Management [v8]

2024-10-07 Thread Nir Lisker
On Wed, 2 Oct 2024 17:33:15 GMT, Andy Goryachev wrote: >> Public APIs for focus traversal and the focus traversal policy: >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md >> >> This work is loosely based on the patch >> https://cr.openjdk.org/~j

Re: RFR: 8339603: Seal the class hierarchy of Node, Camera, LightBase, Shape, Shape3D [v3]

2024-10-07 Thread Nir Lisker
On Mon, 7 Oct 2024 15:32:16 GMT, Michael Strauß wrote: >> None of these classes can be extended by user code, and any attempt to do so >> will fail at runtime with an exception. For this reason, we can seal the >> class hierarchy and remove the run-time checks to turn this into a >> compile-ti

Re: RFR: 8341372: BackgroundPosition, BorderImage, BorderStroke, CornerRadii should be final [v2]

2024-10-07 Thread Nir Lisker
On Wed, 2 Oct 2024 17:53:15 GMT, Michael Strauß wrote: >> Backgrounds and borders are comprised of immutable and final types. The >> following types are marked with the `final` modifier: >> >> * Background >> * BackgroundFill >> * BackgroundImage >> * BackgroundSize >> * Border >> * BorderWidth

[Acme] WGLC for draft-ietf-acme-ari

2024-10-07 Thread Yoav Nir
Hi, all This begins a working group last call for the ARI draft [1] If you haven’t done so recently, please read the latest (-05) version of the draft, and send comments to the list. Due to the Jewish holidays and my upcoming vacation, this WGLC will last for three weeks, ending on Monday, Oct

Re: Proposal: Bump minimum JDK for JavaFX 24 to JDK 22

2024-10-02 Thread Nir Lisker
take precedence or if FFM is too important to wait with. - Nir [1] https://mail.openjdk.org/pipermail/openjfx-dev/2023-December/044081.html On Wed, Oct 2, 2024 at 5:45 PM Kevin Rushforth wrote: > All, > > Even though we build JavaFX 24 binaries with JDK 22 (and soon will build > wit

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v43]

2024-09-30 Thread Nir Lisker
On Fri, 27 Sep 2024 22:22:27 GMT, Michael Strauß wrote: >> This PR completes the CSS Transitions story (see #870) by adding >> interpolation support for backgrounds and borders, making them targetable by >> transitions. >> >> `Background` and `Border` objects are deeply immutable, but not >>

Re: [Feature Proposal]: TriangleMesh - Vertex Color Support

2024-09-30 Thread Nir Lisker
components that are mandatory (at the very least, points should be supplied). On Mon, Sep 30, 2024 at 3:12 AM Knee Snap wrote: > These are some great points! > > Nir mentioned a builder-style pattern for TriangleMesh, but I struggle to > think of how this could work well, as one crit

Re: [Feature Proposal]: TriangleMesh - Vertex Color Support

2024-09-23 Thread Nir Lisker
Having gone through some sources, I found the additional properties that can be added as per-vertex data: * Additional texture coordinates (mentioned by Michael). These can be used for detailed textures. * Bone indices and weights. These are for GPU skinning. Interestingly, the D3D vertex shader co

Re: [Feature Proposal]: TriangleMesh - Vertex Color Support

2024-09-18 Thread Nir Lisker
precated in MacOS. It's a large investment. I've laid out foundations in #1281 for common missing texture features like sampling/filtering, wrapping, and mipmaps. It also needs to be done carefully, though #1281 is all internal so it can afford some misses. There are other common missing feature

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v36]

2024-09-14 Thread Nir Lisker
On Sat, 14 Sep 2024 07:38:38 GMT, Michael Strauß wrote: >> Then maybe mention that paired elements are interpolated? >> By "this specs is for the list itself" I meant that pairwise interpolation >> is only relevant for the list itself and not for an element in the list >> (unless it's a list it

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v38]

2024-09-14 Thread Nir Lisker
On Sat, 14 Sep 2024 07:43:41 GMT, Michael Strauß wrote: >> This PR completes the CSS Transitions story (see #870) by adding >> interpolation support for backgrounds and borders, making them targetable by >> transitions. >> >> `Background` and `Border` objects are deeply immutable, but not >>

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v36]

2024-09-14 Thread Nir Lisker
On Sat, 14 Sep 2024 06:49:33 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/animation/Interpolatable.java >> line 54: >> >>> 52: * Two lists are combined by pairwise interpolation. If >>> the start list has fewer elements than >>> 53: *

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v36]

2024-09-14 Thread Nir Lisker
On Sat, 14 Sep 2024 06:58:04 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java >> line 292: >> >>> 290: private Background(List fills, >>> List images, int ignored) { >>> 291: Objects.requireNonNull(fills, "fills cannot be null"

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v36]

2024-09-13 Thread Nir Lisker
On Sun, 8 Sep 2024 20:55:53 GMT, Michael Strauß wrote: >> This PR completes the CSS Transitions story (see #870) by adding >> interpolation support for backgrounds and borders, making them targetable by >> transitions. >> >> `Background` and `Border` objects are deeply immutable, but not >> i

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v36]

2024-09-12 Thread Nir Lisker
On Sun, 8 Sep 2024 20:55:53 GMT, Michael Strauß wrote: >> This PR completes the CSS Transitions story (see #870) by adding >> interpolation support for backgrounds and borders, making them targetable by >> transitions. >> >> `Background` and `Border` objects are deeply immutable, but not >> i

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v36]

2024-09-12 Thread Nir Lisker
On Sun, 8 Sep 2024 20:55:53 GMT, Michael Strauß wrote: >> This PR completes the CSS Transitions story (see #870) by adding >> interpolation support for backgrounds and borders, making them targetable by >> transitions. >> >> `Background` and `Border` objects are deeply immutable, but not >> i

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v3]

2024-09-12 Thread Nir Lisker
On Thu, 12 Sep 2024 13:19:26 GMT, Michael Strauß wrote: >> Is this code required to be so highly performant that you need to check for >> `RandomAccess`? Under normal circumstances, I would just stream the list and >> filter for `null`s. > > This can run tens of thousands of times per second, w

Re: [Feature Proposal]: TriangleMesh - Vertex Color Support

2024-09-12 Thread Nir Lisker
Did I miss them? On Thu, Sep 12, 2024 at 3:59 PM Nir Lisker wrote: > Do you mind taking a look, and maybe helping answer some of my questions? >> I'm just not getting any replies, so I'm somewhat confused. >> > > I'll try to take a closer look during the weekend. T

Re: [Feature Proposal]: TriangleMesh - Vertex Color Support

2024-09-12 Thread Nir Lisker
es and render states to the same class. See https://github.com/openjdk/jfx/pull/1281#discussion_r1412368579. You can see all the threads in the mailing list archive: http://mail.openjdk.java.net/pipermail/openjfx-dev/. On Tue, Sep 10, 2024 at 4:22 AM Knee Snap wrote: > @Nir Lisker Do you mind

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v3]

2024-09-12 Thread Nir Lisker
On Sat, 3 Aug 2024 00:14:04 GMT, Michael Strauß wrote: >> modules/javafx.base/src/main/java/com/sun/javafx/UnmodifiableArrayList.java >> line 81: >> >>> 79: >>> 80: @SuppressWarnings("unchecked") >>> 81: T[] newValues = (T[])new Object[list.size()]; >> >> With many `null`s thi

Re: RFR: 8339603: Seal the class hierarchy of Node, Camera, LightBase, Shape, Shape3D

2024-09-06 Thread Nir Lisker
On Thu, 5 Sep 2024 12:01:23 GMT, Michael Strauß wrote: > None of these classes can be extended by user code, and any attempt to do so > will fail at runtime with an exception. For this reason, we can seal the > class hierarchy and remove the run-time checks to turn this into a > compile-time e

Re: RFR: 8339603: Seal the class hierarchy of Node, Camera, LightBase, Shape, Shape3D

2024-09-06 Thread Nir Lisker
On Thu, 5 Sep 2024 12:01:23 GMT, Michael Strauß wrote: > None of these classes can be extended by user code, and any attempt to do so > will fail at runtime with an exception. For this reason, we can seal the > class hierarchy and remove the run-time checks to turn this into a > compile-time e

Re: RFR: 8339603: Seal the class hierarchy of Node, Camera, LightBase, Shape, Shape3D

2024-09-06 Thread Nir Lisker
On Thu, 5 Sep 2024 12:01:23 GMT, Michael Strauß wrote: > None of these classes can be extended by user code, and any attempt to do so > will fail at runtime with an exception. For this reason, we can seal the > class hierarchy and remove the run-time checks to turn this into a > compile-time e

Re: RFR: 8339247: Create release notes for JavaFX 23 [v2]

2024-09-04 Thread Nir Lisker
On Wed, 4 Sep 2024 14:38:00 GMT, Kevin Rushforth wrote: >> This PR adds the release notes for the JavaFX 23 release. This will first go >> into `master`, and then be backported to the `jfx23` branch so it will be >> available in that branch when JavaFX 23 is published (and from there also >> s

Re: RFR: 8339247: Create release notes for JavaFX 23

2024-09-04 Thread Nir Lisker
On Wed, 4 Sep 2024 11:42:47 GMT, Kevin Rushforth wrote: > Should I split the "Enhancements" section into two groups as shown in the PR > Description, or leave it as a single group? @abhinayagarwal Do you write the highlights page https://openjfx.io/highlights/22/? Will the same split be done t

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v29]

2024-09-03 Thread Nir Lisker
On Tue, 3 Sep 2024 17:09:51 GMT, Michael Strauß wrote: >> This PR completes the CSS Transitions story (see #870) by adding >> interpolation support for backgrounds and borders, making them targetable by >> transitions. >> >> `Background` and `Border` objects are deeply immutable, but not >> i

Re: Failing to build JavaFX

2024-08-30 Thread Nir Lisker
nfo. Did you set up Visual Studio? It's required for WINDOWS_NATIVE_COMPILE_ENVIRONMENT. - Nir On Fri, Aug 30, 2024 at 8:23 AM Knee Snap wrote: > Upon trying to run "./gradlew -PFULL_TEST=true -PUSE_ROBOT=true > -PCOMPILE_WEBKIT=true -PCOMPILE_MEDIA=true all test", I am e

Re: RFR: 8339247: Create release notes for JavaFX 23

2024-08-30 Thread Nir Lisker
On Fri, 30 Aug 2024 12:47:38 GMT, Kevin Rushforth wrote: > This PR adds the release notes for the JavaFX 23 release. This will first go > into `master`, and then be backported to the `jfx23` branch so it will be > available in that branch when JavaFX 23 is published (and from there also > sync

Re: [Feature Proposal] Vertex Colors on TriangleMesh

2024-08-20 Thread Nir Lisker
vailable for it large, I don't foresee problems off the top of my head. Implementing this will require simultaneous implementations for D3D9 and OpenGL. Metal is still in the works, so I'm not sure about that one. It will need the approval of Kevin or Johan. - Nir On Tue, Aug 20,

Re: RFR: 8336632: Update Gradle to 8.9

2024-08-20 Thread Nir Lisker
On Tue, 20 Aug 2024 02:59:00 GMT, Ambarish Rapte wrote: > Gradle 8.8 released on May 31, 2024, supports JDK 22. > On Jul 11, 2024, gradle 8.9 was released too, so we can update to the latest > gradle 8.9 > > This gradle update is required in order to update the boot jdk to 22.0.2. > The change

Re: RFR: 8332895: Support interpolation for backgrounds and borders [v25]

2024-08-17 Thread Nir Lisker
On Fri, 9 Aug 2024 22:32:46 GMT, Michael Strauß wrote: >> This PR completes the CSS Transitions story (see #870) by adding >> interpolation support for backgrounds and borders, making them targetable by >> transitions. >> >> `Background` and `Border` objects are deeply immutable, but not >> i

Re: [External] : Re: RichTextArea: API Review

2024-08-14 Thread Nir Lisker
Yes, that clarifies a lot, thanks! I'll have a look at the API and functionality of the demos. On Wed, Aug 14, 2024 at 9:09 PM Andy Goryachev wrote: > Dear Nir, everyone: > > > > Thank you for asking these good questions! > > > > > > 1. If these are provide

Re: RichTextArea: API Review

2024-08-14 Thread Nir Lisker
lone. > - RichTextFX depends on several long-unmaintained libraries, namely > ReactFX. There is nothing that can be done from the OpenJFX side, as it > would require rewriting RichTextFX from scratch. > > I don't think anyone expects OpenJFX to provide something as complex as

Re: RichTextArea: API Review

2024-08-14 Thread Nir Lisker
ith the proposed new building blocks (no need to actually rewrite the code). If not, it could hint to an incompatibility or a limit of the proposal that makes it less appealing. Thanks, Nir On Fri, Aug 2, 2024 at 10:41 PM Andy Goryachev wrote: > Dear fellow developers: > > > &g

Re: RFR: 8289174: JavaFX build fails on Windows when VS150COMNTOOLS is not set [v4]

2024-08-14 Thread Nir Lisker
On Wed, 14 Aug 2024 02:21:30 GMT, Kevin Rushforth wrote: >> 1. Added logic to look in the standard locations for Visual Studio 2022, >> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in >> the following locations: >> >> C:("Program Files"|"Program Files (x86)")\Micros

Re: RFR: 8289174: JavaFX build fails on Windows when VS150COMNTOOLS is not set [v3]

2024-08-13 Thread Nir Lisker
On Mon, 12 Aug 2024 21:31:49 GMT, Kevin Rushforth wrote: >> 1. Added logic to look in the standard locations for Visual Studio 2022, >> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in >> the following locations: >> >> C:("Program Files"|"Program Files (x86)")\Micros

Re: RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v7]

2024-08-13 Thread Nir Lisker
On Wed, 7 Aug 2024 22:47:28 GMT, Andy Goryachev wrote: > oops, yes, you did, my mistake. the master progressed since then, got me > confused. > > I got a bunch of errors again after switching: > > ``` > Description ResourceTypePathLocation > Cannot infer type arguments for Pa

Re: RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v7]

2024-08-13 Thread Nir Lisker
On Wed, 7 Aug 2024 02:13:12 GMT, John Hendrikx wrote: >> Moves `SimpleSelector` and `CompoundSelector` to internal packages. >> >> This can be done with only a minor API break, as `SimpleSelector` and >> `CompoundSelector` were public before. However, these classes could not be >> constructed

Re: RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v7]

2024-08-13 Thread Nir Lisker
On Wed, 7 Aug 2024 02:13:12 GMT, John Hendrikx wrote: >> Moves `SimpleSelector` and `CompoundSelector` to internal packages. >> >> This can be done with only a minor API break, as `SimpleSelector` and >> `CompoundSelector` were public before. However, these classes could not be >> constructed

Re: RFR: 8289174: JavaFX build fails on Windows when VS150COMNTOOLS is not set [v2]

2024-08-12 Thread Nir Lisker
On Mon, 12 Aug 2024 15:37:10 GMT, Kevin Rushforth wrote: >> 1. Added logic to look in the standard locations for Visual Studio 2022, >> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in >> the following locations: >> >> C:("Program Files"|"Program Files (x86)")\Micros

Re: RFR: 8301761: The sorting of the SortedList can become invalid [v2]

2024-08-12 Thread Nir Lisker
On Sat, 10 Aug 2024 11:53:00 GMT, John Hendrikx wrote: >>> This is not the case. The sorting is still correct. Claiming that the >>> sorting is invalid because a newly added item was not placed in a specific >>> location relative to other equal items is a bit of misrepresentation. >>> >>> So,

Re: How to stop QEMU punching holes in backing store

2024-08-08 Thread Nir Soffer
On Sat, Jun 29, 2024 at 12:19 AM Nir Soffer wrote: > > On Wed, Jun 19, 2024 at 2:18 PM Nir Soffer wrote: > > On 19 Jun 2024, at 8:54, Justin wrote: > > > >I've run strace and I see calls to fallocate with these flags: > >FALLOC_FL_KEEP_SIZE|FALLOC_

Re: [PATCH v2] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

2024-07-27 Thread Nir Soffer
t;input_format", > +metavar="input_format", > +default="raw", > +help="format of the input file (default: raw)", > +) > +parser.add_argument( > +"-c", > +dest="cluster_size", > +metavar="cluster_size", > +help=f"qcow2 cluster size (default: {QCOW2_DEFAULT_CLUSTER_SIZE})", > +default=QCOW2_DEFAULT_CLUSTER_SIZE, > +type=int, > +choices=[1 << x for x in range(9, 22)], > +) > +parser.add_argument( > +"-r", > +dest="refcount_bits", > +metavar="refcount_bits", > +help=f"width of the reference count entries (default: > {QCOW2_DEFAULT_REFCOUNT_BITS})", > +default=QCOW2_DEFAULT_REFCOUNT_BITS, > +type=int, > +choices=[1 << x for x in range(7)], > +) > +parser.add_argument( > +"-v", > +dest="qcow2_version", > +metavar="qcow2_version", > +help=f"qcow2 version (default: {QCOW2_DEFAULT_VERSION})", > +default=QCOW2_DEFAULT_VERSION, > +type=int, > +choices=[2, 3], > +) > +args = parser.parse_args() args is global, is this intended? > + > +if not os.path.isfile(args.input_file): > +sys.exit(f"[Error] {args.input_file} does not exist or is not a > regular file.") > + > +if args.refcount_bits != 16 and args.qcow2_version != 3: > +sys.exit(f"[Error] refcount_bits={args.refcount_bits} is only > supported with qcow2_version=3.") > + > +if sys.stdout.isatty(): > +sys.exit("[Error] Refusing to write to a tty. Try redirecting > stdout.") > + > +with get_input_as_raw_file(args.input_file, args.input_format) as > raw_file: raw_file is global, is this intended? > +create_qcow2_file( The name does not reflect what the function does - this does not create a qcow2 file, but write a qcow2 content to stdout. Maybe write_qcow2_content()? > +raw_file, > +args.cluster_size, > +args.refcount_bits, > +args.qcow2_version, > +) > -- > 2.39.2 > > Nir

  1   2   3   4   5   6   7   8   9   10   >