Github user squito commented on the issue:
https://github.com/apache/spark/pull/21729
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r203472192
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -659,6 +659,11 @@ private[spark] class BlockManager(
* Get block
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21698
jumping in the middle on this discussion -- everybody has raised some great
points.
1) My first takeaway from this is just how hard it can be to reason about
this, because spark's exact
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r203455379
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -160,11 +160,29 @@ case class
SparkListenerBlockUpdated
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21131#discussion_r203415036
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -764,6 +769,19 @@ private[spark] class TaskSetManager
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r203381863
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala ---
@@ -166,6 +170,34 @@ private[spark] class ChunkedByteBuffer(var chunks
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r20324
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBufferFileRegion.scala
---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r203245221
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala ---
@@ -166,6 +170,34 @@ private[spark] class ChunkedByteBuffer(var chunks
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r203244832
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala ---
@@ -166,6 +170,34 @@ private[spark] class ChunkedByteBuffer(var chunks
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21593#discussion_r203157915
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java
---
@@ -137,30 +137,15 @@ protected void deallocate
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21131
The DAGSCheudler is notified about successfully completed tasks, whether or
not the `tsm.successful` is already true:
https://github.com/apache/spark/blob/master/core/src/main/scala/org
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21639
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21656
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r203100978
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -160,11 +160,29 @@ case class
SparkListenerBlockUpdated
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r203097734
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala ---
@@ -166,6 +170,34 @@ private[spark] class ChunkedByteBuffer(var chunks
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21131
>>Fetch failure lead to multiple tasksets which are active for a given
stage.
>How can this happen? the TaskSetManager will mark itself as zombie when it
receives a fetch failed.
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21440
@mridulm @jerryshao maybe you would be interested in reviewing this as well?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21656
> Ideally I think for speculation we want to look at the task time for all
stage attempts. But that is probably a bigger change then this
yeah I agree, on both points. One thing wh
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21221
sorry this week has been really busy, and I'm on vacation next week, so a
little more delay before I get further on this. (though anybody else is
welcome to review and merge this, I feel pretty
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21656#discussion_r200759539
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -772,6 +772,12 @@ private[spark] class TaskSetManager(
private
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21656
Thanks for finding this and suggesting a fix @cxzl25. But, I'm not sure it
makes sense to use this duration. its not how long the task actually took to
complete. I think it might make more sense
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21656
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21440
@tgravescs @felixcheung @zsxwing maybe one of you could take a look? I got
a lgtm from marcelo but he's out for a few weeks, would prefer to get another
approval, plus I'll need review on https
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21639
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21653#discussion_r199550367
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -1371,4 +1371,64 @@ class TaskSetManagerSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21653#discussion_r199550557
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -1371,4 +1371,64 @@ class TaskSetManagerSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21653#discussion_r199549772
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -1371,4 +1371,64 @@ class TaskSetManagerSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21474#discussion_r198891670
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -429,7 +429,11 @@ package object config {
"external sh
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r198655159
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBufferFileRegion.scala
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21440#discussion_r198651582
--- Diff:
core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala ---
@@ -166,6 +170,38 @@ private[spark] class ChunkedByteBuffer(var chunks
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r198611581
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -169,6 +181,28 @@ private[spark] class EventLoggingListener
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r198628058
--- Diff: project/MimaExcludes.scala ---
@@ -89,7 +89,13 @@ object MimaExcludes {
ProblemFilters.exclude[InheritedNewAbstractMethodProblem
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r198618559
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -669,6 +686,29 @@ private[spark] class AppStatusListener
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r198625661
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
---
@@ -251,6 +261,217 @@ class EventLoggingListenerSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r198624068
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -98,14 +101,53 @@ class ExecutorSummary private[spark](
val
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r198610162
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricGetter.scala
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r198624819
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -98,14 +102,48 @@ class ExecutorSummary private[spark](
val
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r198613341
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -264,6 +282,11 @@ private[spark] trait SparkListenerInterface
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r198609741
--- Diff: core/src/main/scala/org/apache/spark/Heartbeater.scala ---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r198624800
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -98,14 +102,48 @@ class ExecutorSummary private[spark](
val
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r198611872
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/PeakExecutorMetrics.scala ---
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r198609800
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1922,6 +1928,12 @@ class SparkContext(config: SparkConf) extends
Logging
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21440
@vanzin @JoshRosen this is also ready in the sequence of 2GB limit related
changes.
(I'll update https://github.com/apache/spark/pull/21451 now that the first
change has gone
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r198236456
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -207,9 +400,67 @@ private void assertErrorsContain
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20640
fyi I just merged SPARK-16330, which is currently very yarn specific, but I
think you could easily refactor that code to reuse a lot for mesos too
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21068
merged to master. Thanks @attilapiros !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20640#discussion_r196997885
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
---
@@ -648,14 +645,8
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21593#discussion_r196933769
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java
---
@@ -137,30 +137,15 @@ protected void deallocate
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21527#discussion_r196804445
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/MapStatusSuite.scala ---
@@ -188,4 +188,37 @@ class MapStatusSuite extends SparkFunSuite
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21527#discussion_r196810539
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/MapStatusSuite.scala ---
@@ -188,4 +188,37 @@ class MapStatusSuite extends SparkFunSuite
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21593#discussion_r196637144
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/MessageWithHeader.java
---
@@ -137,30 +137,15 @@ protected void deallocate
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21593
Jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r196558660
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -130,6 +200,59 @@ public void onFailure(Throwable e
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21558#discussion_r196277478
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -110,7 +108,7 @@ object
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r196186937
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
---
@@ -0,0 +1,187
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21068
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r19695
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -169,6 +182,31 @@ private[spark] class EventLoggingListener
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195955081
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -169,6 +182,31 @@ private[spark] class EventLoggingListener
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195796301
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195795803
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java
---
@@ -130,6 +200,60 @@ public void onFailure(Throwable e
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195788253
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -216,34 +192,99 @@ public long sendRpc(ByteBuffer
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195773177
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
---
@@ -251,6 +261,222 @@ class EventLoggingListenerSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195773554
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
---
@@ -251,6 +261,222 @@ class EventLoggingListenerSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195772234
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
---
@@ -251,6 +261,222 @@ class EventLoggingListenerSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195773700
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
---
@@ -251,6 +261,222 @@ class EventLoggingListenerSuite extends
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195770816
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/PeakExecutorMetrics.scala ---
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195770446
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -169,6 +182,31 @@ private[spark] class EventLoggingListener
Github user squito commented on the issue:
https://github.com/apache/spark/pull/20640
> @squito reading the code here:
https://github.com/apache/spark/pull/21068/files
is there an option to update the info about blacklisted node when there is
a mesos task failure.
It is a
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195751572
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -98,14 +101,53 @@ class ExecutorSummary private[spark](
val
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21068
lgtm
will leave open for a couple of days to let @tgravescs take a look
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21068
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r195566345
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
---
@@ -151,9 +149,9 @@ private[spark
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r195467887
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
---
@@ -0,0 +1,189
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r195469104
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
---
@@ -0,0 +1,189
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195464933
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/RpcHandler.java
---
@@ -38,15 +38,28 @@
*
* This method
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r195464525
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -220,30 +196,91 @@ public long sendRpc(ByteBuffer
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21221
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21221
Jenkins, test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195297024
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -98,14 +101,53 @@ class ExecutorSummary private[spark](
val
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195289142
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -93,6 +96,9 @@ private[spark] class EventLoggingListener
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195289072
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1751,7 +1753,7 @@ class DAGScheduler
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195289751
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -169,6 +182,31 @@ private[spark] class EventLoggingListener
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195290564
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -234,8 +272,18 @@ private[spark] class EventLoggingListener
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195291809
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -304,6 +305,11 @@ class SparkContext(config: SparkConf) extends Logging
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195291213
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -98,14 +101,53 @@ class ExecutorSummary private[spark](
val
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195290278
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -169,6 +182,31 @@ private[spark] class EventLoggingListener
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r195290854
--- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
@@ -98,14 +101,53 @@ class ExecutorSummary private[spark](
val
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21558
IMO your change is the right fix, not just a workaround. I don't think its
a scheduler bug (though its definitely unclear). I'll move that discussion to
the jira.
An alternative would
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21527
I'm totally onboard with exposing it, though I'd say undocumented unless we
have some concrete advice on how to set it. I was just explaining my
experience so far and why I haven't bothered
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21475
merged to master. Thanks @redsanket !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21068
Tom and I had a chance to discuss this in person, and after some back and
forth I think we decided that maybe its best to remove the limit but have the
application fail if the entire cluster
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21527
I tell users 2001 partitions all the time. I haven't bothered trying to
make it configurable in the past because I dunno what else you'd set this value
to -- normally I think it would be better
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21518
lgtm assuming tests pass
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21475
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21518#discussion_r194483889
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/UnsafeRowSerializerSuite.scala
---
@@ -45,6 +44,14 @@ class ClosableByteArrayInputStream
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21221
well, I think you should change the way PeakExecutorMetrics gets converted
to json, so that it uses a name from the relevant `MetricGetter`. You should
be able to customize the way it gets
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r192797087
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/RpcHandler.java
---
@@ -38,15 +38,28 @@
*
* This method
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21451#discussion_r192796600
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/RpcHandler.java
---
@@ -38,15 +38,24 @@
*
* This method
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r192795662
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/RpcHandler.java
---
@@ -38,15 +38,24 @@
*
* This method
Github user squito commented on the issue:
https://github.com/apache/spark/pull/21475
what about "... when they are blacklisted for the entire application, as
controlled by spark.blacklist.applic
401 - 500 of 3521 matches
Mail list logo
