[clang] [Clang] [Sema] Don't crash on unexpanded pack in invalid block literal (PR #110762)

2024-10-11 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/110762 >From 9c073cc3145bf6961b565516aea0e8d0c3fca0d7 Mon Sep 17 00:00:00 2001 From: Sirraide Date: Thu, 10 Oct 2024 13:08:20 +0200 Subject: [PATCH 1/5] Undo previous changes, keeping the release note and tests ---

[clang] [llvm] [CUDA] Add support for CUDA-12.6 and sm_100 (PR #112028)

2024-10-11 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B updated https://github.com/llvm/llvm-project/pull/112028 >From 5dac14aab180fd965d996b47cf983b8c462fe703 Mon Sep 17 00:00:00 2001 From: Sergey Kozub Date: Tue, 2 Jul 2024 02:44:56 -0700 Subject: [PATCH] [CUDA] Add support for CUDA-12.6 and sm_100 --- clang/docs/Relea

[clang] Make PCH's respect any VFS specified. (PR #106577)

2024-10-11 Thread Ben Langmuir via cfe-commits
benlangmuir wrote: @sheredom I think I'm missing something. What's the actual failure? Setting `-working-directory` causes `FileManager` to prepend to paths the configured directory, so the VFS lookups would then be absolute paths not relative. I see the driver checks if the path in `-working

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/112025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/112025 >From a014a06d5b06bb8c94b4d86636fb57f342e184db Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 11 Oct 2024 12:21:49 -0500 Subject: [PATCH 1/3] [Clang] Add a flag to include GPU startup files Summary: The

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
@@ -648,6 +648,15 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, Args.MakeArgString("-plugin-opt=-mattr=" + llvm::join(Features, ","))); } + if (Args.hasArg(options::OPT_gpustartfiles)) { jhuber6 wrote: Done. https://gi

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/112025 >From a014a06d5b06bb8c94b4d86636fb57f342e184db Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 11 Oct 2024 12:21:49 -0500 Subject: [PATCH 1/2] [Clang] Add a flag to include GPU startup files Summary: The

[clang] [Clang] [Sema] Don't crash on unexpanded pack in invalid block literal (PR #110762)

2024-10-11 Thread John McCall via cfe-commits
https://github.com/rjmccall approved this pull request. Nice, this looks really clean. Thanks for taking this on! https://github.com/llvm/llvm-project/pull/110762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-11 Thread Oleksandr T. via cfe-commits
@@ -1422,8 +1422,14 @@ static bool IsOverloadOrOverrideImpl(Sema &SemaRef, FunctionDecl *New, // the implicit object parameter are of the same type. auto NormalizeQualifiers = [&](const CXXMethodDecl *M, Qualifiers Q) { -if (M->isExplicitObjectMemberFunction()) +i

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-11 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110435 >From c52634882631a71fad956a70179b480abf13006a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 29 Sep 2024 22:01:38 +0300 Subject: [PATCH 1/4] [Clang] fix overload resolution for object parameters with

[clang] [llvm] [CUDA] Add support for CUDA-12.6 and sm_100 (PR #112028)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-nvptx Author: Artem Belevich (Artem-B) Changes This is a copy of #97402, which is now ready to land. --- Patch is 25.62 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/112028.diff 9 Files Affected:

[clang] [llvm] [CUDA] Add support for CUDA-12.6 and sm_100 (PR #112028)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Artem Belevich (Artem-B) Changes This is a copy of #97402, which is now ready to land. --- Patch is 25.62 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/112028.diff 9 Files Affected:

[clang] [llvm] [CUDA] Add support for CUDA-12.6 and sm_100 (PR #112028)

2024-10-11 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B created https://github.com/llvm/llvm-project/pull/112028 This is a copy of #97402, which is now ready to land. >From 8f2122e6ff890320d66e6d9f3cc5327b897c25e9 Mon Sep 17 00:00:00 2001 From: Sergey Kozub Date: Tue, 2 Jul 2024 02:44:56 -0700 Subject: [PATCH] [CUDA] Add

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Matt Arsenault via cfe-commits
@@ -648,6 +648,15 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, Args.MakeArgString("-plugin-opt=-mattr=" + llvm::join(Features, ","))); } + if (Args.hasArg(options::OPT_gpustartfiles)) { arsenm wrote: Default value woul

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
@@ -648,6 +648,15 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, Args.MakeArgString("-plugin-opt=-mattr=" + llvm::join(Features, ","))); } + if (Args.hasArg(options::OPT_gpustartfiles)) { jhuber6 wrote: What I meant, but

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Matt Arsenault via cfe-commits
@@ -648,6 +648,15 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, Args.MakeArgString("-plugin-opt=-mattr=" + llvm::join(Features, ","))); } + if (Args.hasArg(options::OPT_gpustartfiles)) { arsenm wrote: can we make that h

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
@@ -648,6 +648,15 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, Args.MakeArgString("-plugin-opt=-mattr=" + llvm::join(Features, ","))); } + if (Args.hasArg(options::OPT_gpustartfiles)) { jhuber6 wrote: Unfortunately not

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Matt Arsenault via cfe-commits
@@ -648,6 +648,15 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, Args.MakeArgString("-plugin-opt=-mattr=" + llvm::join(Features, ","))); } + if (Args.hasArg(options::OPT_gpustartfiles)) { arsenm wrote: Is there prior art

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-11 Thread via cfe-commits
@@ -1422,8 +1422,14 @@ static bool IsOverloadOrOverrideImpl(Sema &SemaRef, FunctionDecl *New, // the implicit object parameter are of the same type. auto NormalizeQualifiers = [&](const CXXMethodDecl *M, Qualifiers Q) { -if (M->isExplicitObjectMemberFunction()) +i

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-11 Thread via cfe-commits
@@ -1422,8 +1422,14 @@ static bool IsOverloadOrOverrideImpl(Sema &SemaRef, FunctionDecl *New, // the implicit object parameter are of the same type. auto NormalizeQualifiers = [&](const CXXMethodDecl *M, Qualifiers Q) { -if (M->isExplicitObjectMemberFunction()) +i

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: The C library for GPUs provides the ability to target regular C/C++ programs by providing the C library and a file containing kernels that call the `main` function. This is mostly used for unit tests,

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-11 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/112025 Summary: The C library for GPUs provides the ability to target regular C/C++ programs by providing the C library and a file containing kernels that call the `main` function. This is mostly used for unit tests, th

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Daniel Chen via cfe-commits
DanielCChen wrote: > > > `test_demangle` should definitely **not** be updated when renaming > > > functions. > > > > > > Could you please explain a bit more since this is new to me? Thanks in > > advance! > > The use of LLVM symbols in this file is incidental -- it's just a data set of > ma

[clang] Add isTrivial() and isTriviallyCopyable() AST matchers (PR #90634)

2024-10-11 Thread via cfe-commits
higher-performance wrote: @AaronBallman that makes sense, thanks! For `isTrivial`, I do see it is used in two places, but they're not fully compatible (one operates on `QualType`, and neither works on methods): - https://github.com/llvm/llvm-project/blob/ebe77cc320a1bcc8e2cec44f4f388fb43b7201

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Nikita Popov via cfe-commits
nikic wrote: > > `test_demangle` should definitely **not** be updated when renaming > > functions. > > Could you please explain a bit more since this is new to me? Thanks in > advance! The use of LLVM symbols in this file is incidental -- it's just a data set of mangled C++ symbol names. The

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Daniel Chen via cfe-commits
DanielCChen wrote: > `test_demangle` should definitely **not** be updated when renaming functions. Could you please explain a bit more since this is new to me? Thanks in advance! https://github.com/llvm/llvm-project/pull/111752 ___ cfe-commits mailing

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang Author: Dmitry Polukhin (dmpolukhin) Changes Summary: Fix crash from reproducer provided in https://github.com/llvm/llvm-project/pull/109167#issuecomment-2405289565 Test Plan: TBD (need to further reduce the rep

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-10-11 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin ready_for_review https://github.com/llvm/llvm-project/pull/111992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-10-11 Thread Dmitry Polukhin via cfe-commits
@@ -10057,15 +10057,18 @@ void ASTReader::finishPendingActions() { // For a function defined inline within a class template, force the // canonical definition to be the one inside the canonical definition of // the template. This ensures that we instantiate fr

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `bolt-aarch64-ubuntu-clang` running on `bolt-worker-aarch64` while building `clang,compiler-rt` at step 6 "test-build-clang-bolt-stage2-clang-bolt". Full details are available at: https://lab.llvm.org/buildbot/#/builders/128/b

[clang] [llvm] [RISCV] Add support for inline asm constraint vd (PR #111653)

2024-10-11 Thread Craig Topper via cfe-commits
@@ -102,7 +102,7 @@ bool RISCVTargetInfo::validateAsmConstraint( return true; case 'v': // A vector register. -if (Name[1] == 'r' || Name[1] == 'm') { +if (Name[1] == 'r' || Name[1] == 'd' || Name[1] == 'm') { topperc wrote: This needs to be

[clang] [llvm] [RISCV] Add support for inline asm constraint vd (PR #111653)

2024-10-11 Thread Craig Topper via cfe-commits
https://github.com/topperc requested changes to this pull request. https://github.com/llvm/llvm-project/pull/111653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add isTrivial() and isTriviallyCopyable() AST matchers (PR #90634)

2024-10-11 Thread via cfe-commits
@@ -5444,6 +5444,43 @@ AST_MATCHER(FunctionDecl, isDefaulted) { return Node.isDefaulted(); } +/// Matches trivial methods and types. higher-performance wrote: Ah I see, yeah. I don't think we want to support that since the other matchers don't do that eith

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-10-11 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/111992 >From 0d02e79ced894769cfbea45a121670e933e2c886 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Fri, 11 Oct 2024 05:35:18 -0700 Subject: [PATCH 1/2] [C++20][Modules] Load function body from the module tha

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Rahul Joshi via cfe-commits
jurahul wrote: Makes sense, thanks. On Fri, Oct 11, 2024 at 9:49 AM Nikita Popov ***@***.***> wrote: > test_demangle should definitely *not* be updated when renaming functions. > > — > Reply to this email directly, view it on GitHub >

[clang] [clang] LazyOffsetPtr: Use native pointer width (PR #111995)

2024-10-11 Thread A. Wilcox via cfe-commits
awilfox wrote: I feel like the messages being highlighted in the CI formatter need work anyway. I was hoping the community would have a suggestion on better wording. However, I will be glad to reformat those lines in that manner if this wording should stay. https://github.com/llvm/llvm-proj

[clang] [clang][CGOpenMPRuntime] Avoid Type::getPointerTo() (NFC) (PR #112017)

2024-10-11 Thread Nikita Popov via cfe-commits
@@ -1713,25 +1713,15 @@ llvm::Function *CGOpenMPRuntime::emitThreadPrivateVarDefinition( if (!Ctor && !Dtor) return nullptr; -llvm::Type *CopyCtorTyArgs[] = {CGM.VoidPtrTy, CGM.VoidPtrTy}; -auto *CopyCtorTy = llvm::FunctionType::get(CGM.VoidPtrTy, CopyCtorTy

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-11 Thread Thomas Fransham via cfe-commits
@@ -0,0 +1,67 @@ +//===-- clang/Support/Compiler.h - Compiler abstraction support -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Sean Perry via cfe-commits
https://github.com/perry-ca approved this pull request. This works on z/OS. Thanks for fixing it. https://github.com/llvm/llvm-project/pull/111975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] Make PCH's respect any VFS specified. (PR #106577)

2024-10-11 Thread Neil Henning via cfe-commits
sheredom wrote: > > We tried setting -working-directory=Z:/working, but the VFS requires that > > this is a real path. > > What error are you seeing if it's not? Is it trying to set it too early > before the VFS is created or something? The VFS doesn't actually override the set current workin

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-11 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110435 >From c52634882631a71fad956a70179b480abf13006a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 29 Sep 2024 22:01:38 +0300 Subject: [PATCH 1/3] [Clang] fix overload resolution for object parameters with

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Nikita Popov via cfe-commits
nikic wrote: `test_demangle` should definitely **not** be updated when renaming functions. https://github.com/llvm/llvm-project/pull/111752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] Make PCH's respect any VFS specified. (PR #106577)

2024-10-11 Thread Ben Langmuir via cfe-commits
benlangmuir wrote: > We tried setting -working-directory=Z:/working, but the VFS requires that > this is a real path. What error are you seeing if it's not? Is it trying to set it too early before the VFS is created or something? https://github.com/llvm/llvm-project/pull/106577 __

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Matt Arsenault via cfe-commits
arsenm wrote: Window bot passed, which was the important bit. Linux failed on a different test entirely https://github.com/llvm/llvm-project/pull/111975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [Fuchsia][cmake][NFC] Indent nested loops in Fuchsia-stage2.cmake (PR #112020)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Paul Kirth (ilovepi) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/112020.diff 1 Files Affected: - (modified) clang/cmake/caches/Fuchsia-stage2.cmake (+36-36) ``diff diff --git a/clang/cmake/caches/Fuchsia

[clang] [Fuchsia][cmake][NFC] Indent nested loops in Fuchsia-stage2.cmake (PR #112020)

2024-10-11 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/112020 None >From 07141c444024adaf80dc6fe3cc5378de6d641883 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Fri, 11 Oct 2024 16:36:37 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-11 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,67 @@ +//===-- clang/Support/Compiler.h - Compiler abstraction support -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Matt Arsenault via cfe-commits
arsenm wrote: > @arsenm what are you actually trying to fix and what do you expect this to do? Fix not running tests except on linux. We should have maximum host test coverage, and this test has no reason to depend on the host. All it needs is the explicit target instead of relying on the defa

[clang] [clang][analyzer] Improve test and documentation in cstring NotNullTerminated checker (PR #112019)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balázs Kéri (balazske) Changes CStringChecker has a sub-checker alpha.unix.cstring.NotNullTerminated which checks for invalid objects passed to string functions. The checker and its name are not exact and more functions

[clang] [clang][analyzer] Improve test and documentation in cstring NotNullTerminated checker (PR #112019)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balázs Kéri (balazske) Changes CStringChecker has a sub-checker alpha.unix.cstring.NotNullTerminated which checks for invalid objects passed to string functions. The checker and its name are not exact and more functions could be checked,

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Alex Voicu via cfe-commits
AlexVlx wrote: @arsenm what are you actually trying to fix and what do you expect this to do? https://github.com/llvm/llvm-project/pull/111975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [clang][analyzer] Improve test and documentation in cstring NotNullTerminated checker (PR #112019)

2024-10-11 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/112019 CStringChecker has a sub-checker alpha.unix.cstring.NotNullTerminated which checks for invalid objects passed to string functions. The checker and its name are not exact and more functions could be checked, th

[clang] [clang] Fix segmentation fault caused by stack overflow on deeply nested expressions (PR #111701)

2024-10-11 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/111701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix segmentation fault caused by stack overflow on deeply nested expressions (PR #111701)

2024-10-11 Thread Ilya Biryukov via cfe-commits
@@ -0,0 +1,1013 @@ +// RUN: %clang_cc1 %s -emit-llvm -o - -Wstack-exhausted -verify + +class AClass { +public: + AClass() {} + AClass &foo() { return *this; } +}; + +void test_bar() { + AClass a; + // expected-warning@* {{stack nearly exhausted; compilation time may suffer, a

[clang] [clang] Fix segmentation fault caused by stack overflow on deeply nested expressions (PR #111701)

2024-10-11 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/111701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix segmentation fault caused by stack overflow on deeply nested expressions (PR #111701)

2024-10-11 Thread Ilya Biryukov via cfe-commits
@@ -0,0 +1,1013 @@ +// RUN: %clang_cc1 %s -emit-llvm -o - -Wstack-exhausted -verify + +class AClass { +public: + AClass() {} + AClass &foo() { return *this; } +}; + +void test_bar() { + AClass a; + // expected-warning@* {{stack nearly exhausted; compilation time may suffer, a

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Daniel Chen via cfe-commits
DanielCChen wrote: I see. I don't have strong preference although it would be nice to use some function that exists. https://github.com/llvm/llvm-project/pull/111752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-10-11 Thread Matt Arsenault via cfe-commits
arsenm wrote: > > The LangRef doesn't need to know why it's undesirable. It's like the n field > > `n` field? The following? > Yes. It's an optimization hint https://github.com/llvm/llvm-project/pull/108786 ___ cfe-commits mailing list cfe-commits@

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Matt Arsenault via cfe-commits
@@ -1,21 +1,17 @@ -// REQUIRES: x86-registered-target -// REQUIRES: amdgpu-registered-target -// REQUIRES: system-linux arsenm wrote: This is a pile of workarounds, there's no reason any of these tests should be host dependent https://github.com/llvm/llvm-proj

[clang] [clang][CGOpenMPRuntime] Avoid Type::getPointerTo() (NFC) (PR #112017)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Youngsuk Kim (JOE1994) Changes `llvm::Type::getPointerTo()` is to be deprecated & removed soon. --- Full diff: https://github.com/llvm/llvm-project/pull/112017.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CGOpenMPRuntim

[clang] [clang][CGOpenMPRuntime] Avoid Type::getPointerTo() (NFC) (PR #112017)

2024-10-11 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 created https://github.com/llvm/llvm-project/pull/112017 `llvm::Type::getPointerTo()` is to be deprecated & removed soon. >From 542112f283387db666c54422c714e901bb898c84 Mon Sep 17 00:00:00 2001 From: Youngsuk Kim Date: Fri, 11 Oct 2024 10:06:57 -0500 Subject: [PATCH]

[clang] clang: Fix hipstdpar test relying on default target (PR #111975)

2024-10-11 Thread Shilei Tian via cfe-commits
@@ -1,21 +1,17 @@ -// REQUIRES: x86-registered-target -// REQUIRES: amdgpu-registered-target -// REQUIRES: system-linux shiltian wrote: I'm not sure if the removal of `system-linux` would cause issue. https://github.com/llvm/llvm-project/pull/111975

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-10-11 Thread Shilei Tian via cfe-commits
shiltian wrote: > The LangRef doesn't need to know why it's undesirable. It's like the n field `n` field? The following? ``` n::... This specifies a set of native integer widths for the target CPU in bits. For example, it might contain n32 for 32-bit PowerPC, n32:64 for PowerPC 64, or n8:16:3

[clang] [Modules] Add -cc1 -flate-module-map-file to load module maps after PCMs (PR #88893)

2024-10-11 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: The comments on this thread bugged me, so I managed to find a way to achieve the same effect without adding any new flags. #112015 should give the deduplication that I want to get here without introducing any new flags, through a tweak to the mechanism of non-affecting sou

[clang] [Modules] Add -cc1 -flate-module-map-file to load module maps after PCMs (PR #88893)

2024-10-11 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov closed https://github.com/llvm/llvm-project/pull/88893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Rahul Joshi via cfe-commits
jurahul wrote: Yes I purposely did not change it as it just seems to test mangling and using this function as an example. I can change it if it makes sense. On Fri, Oct 11, 2024 at 9:10 AM Daniel Chen ***@***.***> wrote: > @jurahul > It seems this PR is missing a te

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-11 Thread Louis Dionne via cfe-commits
ldionne wrote: If other folks get here because of an error like `multiple rules generate lib/SOMETHING.a`, this is the issue (from https://github.com/llvm/llvm-project/pull/80007#issuecomment-2402188675): > > The fix for this is: > > ``` > # On embedded platforms that don't support shared li

[clang] [ASTWriter] Detect more non-affecting FileIDs to reduce source location duplication (PR #112015)

2024-10-11 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: This is a change that should remove the need for a hack from #88893, reaching the same effect while keeping the command-line interface as it is today. https://github.com/llvm/llvm-project/pull/112015 ___ cfe-commits mailing list

[clang] [ASTWriter] Detect more non-affecting FileIDs to reduce source location duplication (PR #112015)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ilya Biryukov (ilya-biryukov) Changes Currently, any FileID that references a module map file that was required for a compilation is considered as affecting. This misses an important opportunity to reduce the source location space taken b

[clang] [ASTWriter] Detect more non-affecting FileIDs to reduce source location duplication (PR #112015)

2024-10-11 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov created https://github.com/llvm/llvm-project/pull/112015 Currently, any FileID that references a module map file that was required for a compilation is considered as affecting. This misses an important opportunity to reduce the source location space taken by th

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread Daniel Chen via cfe-commits
DanielCChen wrote: @jurahul It seems this PR is missing a test file `libcxxabi/test/test_demangle.pass.cpp`. It has a line of ``` {"_ZN4llvm9Intrinsic14getDeclarationEPNS_6ModuleENS0_2IDEPPKNS_4TypeEj", "llvm::Intrinsic::getDeclaration(llvm::Module*, llvm::Intrinsic::ID, llvm::Type const**,

[clang] 5b25c31 - [OpenACC] Implement loop 'gang' clause. (#112006)

2024-10-11 Thread via cfe-commits
Author: Erich Keane Date: 2024-10-11T09:05:19-07:00 New Revision: 5b25c31351ad1b10a3819411379b3258869c1e1b URL: https://github.com/llvm/llvm-project/commit/5b25c31351ad1b10a3819411379b3258869c1e1b DIFF: https://github.com/llvm/llvm-project/commit/5b25c31351ad1b10a3819411379b3258869c1e1b.diff L

[clang] [OpenACC] Implement loop 'gang' clause. (PR #112006)

2024-10-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/112006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/3] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang-tools-extra] [clangd] Simplify code with *Map::operator[] (NFC) (PR #111939)

2024-10-11 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/111939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 3f156ef - [clangd] Simplify code with *Map::operator[] (NFC) (#111939)

2024-10-11 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-10-11T09:00:39-07:00 New Revision: 3f156ef4cc333bcf9389addd1e0054b654501d7e URL: https://github.com/llvm/llvm-project/commit/3f156ef4cc333bcf9389addd1e0054b654501d7e DIFF: https://github.com/llvm/llvm-project/commit/3f156ef4cc333bcf9389addd1e0054b654501d7e.diff L

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/3] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
abhina-sree wrote: @cor3ntin, I've added support for #embed handling now, I've added a z/OS only testcase clang/test/Preprocessor/embed_zos.c which is a copy of clang/test/Preprocessor/embed_art.c except it changes the file tag to be non-ascii which is now working with the latest commit. http

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/3] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-10-11 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos updated https://github.com/llvm/llvm-project/pull/109855 >From 085965b324efde41168c5d51db3a368578d3458f Mon Sep 17 00:00:00 2001 From: Doug Wyatt Date: Mon, 23 Sep 2024 14:44:32 -0700 Subject: [PATCH 1/5] Add clang/docs/FunctionEffectAnalysis.rst. --- clang/docs/F

[clang] [clang] Fix segmentation fault caused by stack overflow on deeply nested expressions (PR #111701)

2024-10-11 Thread Reid Kleckner via cfe-commits
@@ -0,0 +1,1013 @@ +// RUN: %clang_cc1 %s -emit-llvm -o - -Wstack-exhausted -verify + +class AClass { +public: + AClass() {} + AClass &foo() { return *this; } +}; + +void test_bar() { + AClass a; + // expected-warning@* {{stack nearly exhausted; compilation time may suffer, a

[clang] [clang-tools-extra] [clang-tidy] bugprone-implicit-widening ignores unsigned consts (PR #101073)

2024-10-11 Thread Chris Warner via cfe-commits
cwarner-8702 wrote: Thanks @AaronBallman! > I don't think we want constant expression evaluation to fail based on an > input parameter. It will already fail if the inputs as signed and expression overflows, so this seems like a case that all callers will have to deal with anyway. > I think a

[clang] [CLANG]Add Scalable vectors for mfloat8_t (PR #101644)

2024-10-11 Thread Paul Walker via cfe-commits
@@ -4419,6 +4419,13 @@ QualType ASTContext::getScalableVectorType(QualType EltTy, unsigned NumElts, EltTySize == ElBits && NumElts == (NumEls * NF) && NumFields == 1) { \ return SingletonId; \ } +#define

[clang] [CLANG]Add Scalable vectors for mfloat8_t (PR #101644)

2024-10-11 Thread Paul Walker via cfe-commits
@@ -69,7 +69,7 @@ #ifndef SVE_VECTOR_TYPE_BFLOAT #define SVE_VECTOR_TYPE_BFLOAT(Name, MangledName, Id, SingletonId, NumEls, ElBits, NF) \ - SVE_VECTOR_TYPE_DETAILS(Name, MangledName, Id, SingletonId, NumEls, ElBits, NF, false, false, true) + SVE_VECTOR_TYPE_DETAILS(Name, M

[clang] [CLANG]Add Scalable vectors for mfloat8_t (PR #101644)

2024-10-11 Thread via cfe-commits
CarolineConcatto wrote: Hi @paulwalker-arm, I believe I addressed all the comments in the code. I updated almost all of them to have a test for the SVMfloat8_t. The ones that are not updated are the ones that test FIXED SVE types. The mangling needs scalar type support, BuiltinType::MFloat8,

[clang] [HIP] fix host min/max in header (PR #82956)

2024-10-11 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: yet another usage of mixed signed/unsigned min https://github.com/ROCm/hipBLASLt/issues/1227 https://github.com/llvm/llvm-project/pull/82956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [CLANG]Add Scalable vectors for mfloat8_t (PR #101644)

2024-10-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 159d694c05500a656775f4cbd6931dae9aab290a 111faea1619953a76a1acda070c61559c00678ca --e

[clang] [CLANG]Add Scalable vectors for mfloat8_t (PR #101644)

2024-10-11 Thread via cfe-commits
https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/101644 >From 7134302c7e1054021af36a207dbfd0c40c9e8c51 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Fri, 2 Aug 2024 08:47:18 + Subject: [PATCH 1/2] [CLANG]Add Scalable vectors for mfloat8_t This

[clang] fix access checking about function overloading (PR #107768)

2024-10-11 Thread Zhikai Zeng via cfe-commits
Backl1ght wrote: Sorry for the late response, I will continue to look into this issue this sunday. https://github.com/llvm/llvm-project/pull/107768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [llvm] [AArch64] Introduce new armv9.6 features (PR #111677)

2024-10-11 Thread via cfe-commits
https://github.com/Lukacma updated https://github.com/llvm/llvm-project/pull/111677 >From efabe14befb5c35ae35826d79af0b64756cb3e9b Mon Sep 17 00:00:00 2001 From: Marian Lukac Date: Wed, 9 Oct 2024 10:52:42 + Subject: [PATCH 1/3] [AArch64] Introduce new armv9.6 features --- .../print-suppo

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `bolt-x86_64-ubuntu-nfc` running on `bolt-worker` while building `clang,llvm,mlir,polly` at step 8 "test-build-bolt-check-bolt". Full details are available at: https://lab.llvm.org/buildbot/#/builders/92/builds/7899 Here is

[clang] [flang] [libc] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [mlir] [clang][frontend] Add support for attribute plugins for statement attributes (PR #110334)

2024-10-11 Thread Aaron Ballman via cfe-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Renato Golin Message-ID: In-Reply-To: https://github.com/AaronBallman approved this pull request. LGTM, though we should probably add a release note to clang/docs/ReleaseNotes.rst so users know that the plugin system got a bit more functionality.

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-11 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110435 >From c52634882631a71fad956a70179b480abf13006a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 29 Sep 2024 22:01:38 +0300 Subject: [PATCH 1/3] [Clang] fix overload resolution for object parameters with

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-11 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From ee6336fdca188ddf980fcd83d037c05cd7fd84f9 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `clang,llvm,mlir,polly` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/10003 Here is the re

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-10-11 Thread Tarun Prabhu via cfe-commits
@@ -0,0 +1,24 @@ +// The -time option prints timing information for the various subcommands in a +// format similar to that used by gcc. When compiling and linking, this will +// include the time to call clang-${LLVM_VERSION_MAJOR} and the linker. Since +// the name of the linker

[clang] [flang] [clang][flang] Support -time in both clang and flang (PR #109165)

2024-10-11 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu updated https://github.com/llvm/llvm-project/pull/109165 >From 6ff1fcb6dcd55b1d77dacc8b6d117176033038c0 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu Date: Wed, 18 Sep 2024 09:49:26 -0600 Subject: [PATCH 1/5] [clang][flang] Support -time in both clang and flang The

[clang] [OpenACC] Implement loop 'gang' clause. (PR #112006)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Erich Keane (erichkeane) Changes The 'gang' clause is used to specify parallel execution of loops, thus has some complicated rules depending on the 'loop's associated compute construct. This patch implements all of those. --- P

[clang] [OpenACC] Implement loop 'gang' clause. (PR #112006)

2024-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes The 'gang' clause is used to specify parallel execution of loops, thus has some complicated rules depending on the 'loop's associated compute construct. This patch implements all of those. --- Patch is

[clang] [OpenACC] Implement loop 'gang' clause. (PR #112006)

2024-10-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/112006 The 'gang' clause is used to specify parallel execution of loops, thus has some complicated rules depending on the 'loop's associated compute construct. This patch implements all of those. >From 8d6dd131cc

<    1   2   3   4   5   6   7   8   9   10   >