@@ -388,12 +388,27 @@ static const IntrinsicData IntrinsicsWithoutChain[] = {
X86_INTRINSIC_DATA(avx_vpermilvar_ps, INTR_TYPE_2OP, X86ISD::VPERMILPV, 0),
X86_INTRINSIC_DATA(avx_vpermilvar_ps_256, INTR_TYPE_2OP, X86ISD::VPERMILPV,
0),
+
@@ -0,0 +1,188 @@
+/*===--- avx10_2minmaxintrin.h - AVX10_2MINMAX intrinsics
+ *-===
+ *
+ * Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+ * See https://llvm.org/LICENSE.txt for license information.
+ *
@@ -0,0 +1,188 @@
+/*===--- avx10_2minmaxintrin.h - AVX10_2MINMAX intrinsics
+ *-===
FreddyLeaf wrote:
[adfe6cd](https://github.com/llvm/llvm-project/pull/101598/commits/adfe6cd518f7f75e8dbbdfcdc6ddadae1a27fc4a)
@@ -0,0 +1,648 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -verify-machineinstrs -mtriple=x86_64-unknown-unknown
--show-mc-encoding -mattr=+avx10.2-512 | FileCheck %s --check-prefixes=X64
+; RUN: llc < %s
@@ -0,0 +1,244 @@
+// RUN: %clang_cc1 %s -flax-vector-conversions=none -ffreestanding
-triple=x86_64 -target-feature +avx10.2-512 \
+// RUN: -emit-llvm -o - -Wno-invalid-feature-combination -Wall -Werror |
FileCheck %s
+// RUN: %clang_cc1 %s -flax-vector-conversions=none
@@ -0,0 +1,210 @@
+// RUN: %clang_cc1 %s -flax-vector-conversions=none -ffreestanding
-triple=x86_64 -target-feature +avx10.2-512 \
+// RUN: -emit-llvm -o - -Wno-invalid-feature-combination -Wall -Werror |
FileCheck %s
+// RUN: %clang_cc1 %s -flax-vector-conversions=none
@@ -0,0 +1,219 @@
+/*===--- avx10_2_512minmaxintrin.h - AVX10_2_512MINMAX intrinsics
+ *-===
+ *
+ * Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+ * See https://llvm.org/LICENSE.txt for license information.
+ *
@@ -2022,6 +2022,22 @@ TARGET_BUILTIN(__builtin_ia32_vsm4key4256,
"V8UiV8UiV8Ui", "nV:256:", "sm4")
TARGET_BUILTIN(__builtin_ia32_vsm4rnds4128, "V4UiV4UiV4Ui", "nV:128:", "sm4")
TARGET_BUILTIN(__builtin_ia32_vsm4rnds4256, "V8UiV8UiV8Ui", "nV:256:", "sm4")
+// AVX10-MINMAX
@@ -0,0 +1,219 @@
+/*===--- avx10_2_512minmaxintrin.h - AVX10_2_512MINMAX intrinsics
+ *-===
+ *
+ * Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+ * See https://llvm.org/LICENSE.txt for license information.
+ *
@@ -0,0 +1,219 @@
+/*===--- avx10_2_512minmaxintrin.h - AVX10_2_512MINMAX intrinsics
+ *-===
FreddyLeaf wrote:
[adfe6cd](https://github.com/llvm/llvm-project/pull/101598/commits/adfe6cd518f7f75e8dbbdfcdc6ddadae1a27fc4a)
@@ -2022,6 +2022,22 @@ TARGET_BUILTIN(__builtin_ia32_vsm4key4256,
"V8UiV8UiV8Ui", "nV:256:", "sm4")
TARGET_BUILTIN(__builtin_ia32_vsm4rnds4128, "V4UiV4UiV4Ui", "nV:128:", "sm4")
TARGET_BUILTIN(__builtin_ia32_vsm4rnds4256, "V8UiV8UiV8Ui", "nV:256:", "sm4")
+// AVX10-MINMAX
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/101858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/101782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Matheus Izvekov
Date: 2024-08-04T22:11:11-03:00
New Revision: 748371183ae769bfb485f1e7466a864bf1db93d5
URL:
https://github.com/llvm/llvm-project/commit/748371183ae769bfb485f1e7466a864bf1db93d5
DIFF:
mizvekov wrote:
Since this is relanding of patch that has been previously reviewed, with no
notable changes except rebase and canonicalization when indexing the
satisfaction cache, I am going to go ahead and merge.
https://github.com/llvm/llvm-project/pull/101782
https://github.com/petrhosek closed
https://github.com/llvm/llvm-project/pull/101910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Petr Hosek
Date: 2024-08-04T16:35:56-07:00
New Revision: 22c06aa5e94e30fb1333ecaf46ce33c65d148634
URL:
https://github.com/llvm/llvm-project/commit/22c06aa5e94e30fb1333ecaf46ce33c65d148634
DIFF:
https://github.com/llvm/llvm-project/commit/22c06aa5e94e30fb1333ecaf46ce33c65d148634.diff
https://github.com/PiJoules approved this pull request.
https://github.com/llvm/llvm-project/pull/101910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Petr Hosek (petrhosek)
Changes
We use armv8m.main-none-eabi now, not armv8m.main-unknown-eabi.
---
Full diff: https://github.com/llvm/llvm-project/pull/101910.diff
1 Files Affected:
- (modified) clang/cmake/caches/Fuchsia-stage2.cmake
https://github.com/petrhosek created
https://github.com/llvm/llvm-project/pull/101910
We use armv8m.main-none-eabi now, not armv8m.main-unknown-eabi.
>From e039c097f997cb95f2f3725c4efa6420c8ed48c0 Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Sun, 4 Aug 2024 16:30:35 -0700
Subject: [PATCH]
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/101782
>From 6a172a93121fdbeb0e58b33ec3140f150ecb524a Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Sun, 23 Oct 2022 11:37:20 +0200
Subject: [PATCH] [clang] Reland: Instantiate concepts with sugared template
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/101594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/101782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Matheus Izvekov
Date: 2024-08-04T19:47:02-03:00
New Revision: 8a26c6d9d4ca18b9906f3ec13d52fc0b2952a5f7
URL:
https://github.com/llvm/llvm-project/commit/8a26c6d9d4ca18b9906f3ec13d52fc0b2952a5f7
DIFF:
duk-37 wrote:
This is a simple and nice change. Improving the developer experience and having
things "just work" is always good.
https://github.com/llvm/llvm-project/pull/100759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/101594
>From fd9bdcc17821be3d22e0787759cbdd6b077dbd90 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Thu, 1 Aug 2024 19:18:52 -0300
Subject: [PATCH] [clang] remove unneeded template deduction canonicalizations
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/101594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Matheus Izvekov
Date: 2024-08-04T19:00:54-03:00
New Revision: 9e9d98aaf503171e2cb229e89966ec1c0adf3804
URL:
https://github.com/llvm/llvm-project/commit/9e9d98aaf503171e2cb229e89966ec1c0adf3804
DIFF:
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/101745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
VolatileAcorn wrote:
Sorry, I incorrectly assumed that I needed to create a new option if I was
changing an option from a bool to an enum.
I can change this back to have the same name and add the true / false cases to
the enumeration parsing function.
@@ -0,0 +1,29 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -pedantic-errors %s
+
+namespace c {
+ extern "C" void main(); // expected-error {{invalid linkage specification
'extern "C"'}}
+}
+extern "C" {
+ int main(); // expected-error {{invalid linkage specification 'extern
@@ -990,6 +990,9 @@ def warn_main_redefined : Warning<"variable named 'main'
with external linkage "
"has undefined behavior">, InGroup;
def ext_main_used : Extension<
"referring to 'main' within an expression is a Clang extension">,
InGroup;
+def
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Oleksandr T. (a-tarasyuk)
Changes
Fixes #101512
---
Full diff: https://github.com/llvm/llvm-project/pull/101853.diff
8 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (+2)
- (modified) clang/include/clang/AST/DeclBase.h (+2)
https://github.com/a-tarasyuk ready_for_review
https://github.com/llvm/llvm-project/pull/101853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday commented:
Why change the name?
https://github.com/llvm/llvm-project/pull/101882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/101745
>From 56c022ef412d311a82a34ae2add05457e53d31ec Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Fri, 2 Aug 2024 16:53:11 -0300
Subject: [PATCH] [clang] concepts: perform parameter mapping subsitution in
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/101853
>From 3f8050482f54138c8a836e67e45131d5e9ccf5cc Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Sun, 4 Aug 2024 00:45:49 +0300
Subject: [PATCH] [Clang] strengthen checks for 'main' function to meet
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/99732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -13004,13 +13004,34 @@ StmtResult
SemaOpenMP::ActOnOpenMPTargetUpdateDirective(
Clauses, AStmt);
}
+// This checks whether num_teams clause only has one expression.
+static bool checkNumTeamsClauseSingleExpr(SemaBase ,
@@ -11357,8 +11358,13 @@ void
OMPClauseReader::VisitOMPAllocateClause(OMPAllocateClause *C) {
void OMPClauseReader::VisitOMPNumTeamsClause(OMPNumTeamsClause *C) {
VisitOMPClauseWithPreInit(C);
- C->setNumTeams(Record.readSubExpr());
https://github.com/VolatileAcorn updated
https://github.com/llvm/llvm-project/pull/101882
>From 923a4ef21edf87c004d8940202331f204e8a8d83 Mon Sep 17 00:00:00 2001
From: Tom Pottage
Date: Fri, 2 Aug 2024 20:26:47 +0100
Subject: [PATCH] [clang-format] Add PackParameters option to replace
https://github.com/jyu2-git created
https://github.com/llvm/llvm-project/pull/101903
None
>From 1a1cb6b459688a7e0a7f22c2b4a32dbe8cae77cc Mon Sep 17 00:00:00 2001
From: Jennifer Yu
Date: Fri, 2 Aug 2024 17:41:24 -0700
Subject: [PATCH 1/2] Test faild with amd.
Add unspport.
This is relate
nico wrote:
Looks like this breaks building on Android:
https://ci.chromium.org/ui/p/chromium/builders/try/android-arm64-rel/680348/overview
https://github.com/llvm/llvm-project/pull/99335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
The current interpreter emits the diagnostic and continues, so do the same.
---
Full diff: https://github.com/llvm/llvm-project/pull/101900.diff
4 Files Affected:
- (modified)
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/101900
The current interpreter emits the diagnostic and continues, so do the same.
>From c10fedb826c41c2f640814428d996b8bfd3f2867 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Sun, 4 Aug 2024
@@ -411,7 +393,8 @@ bool ContinuationIndenter::mustBreak(const LineState
) {
// sets BreakBeforeParameter to avoid bin packing and this creates a
// completely unnecessary line break after a template type that isn't
// line-wrapped.
-
@@ -1174,6 +1192,18 @@ template <> struct MappingTraits {
Style.PackConstructorInitializers = FormatStyle::PCIS_CurrentLine;
}
+// If BinPackParameters was specified but PackParameters was not,
initialize
+// the latter from the former for backwards
@@ -456,6 +455,21 @@ TEST(ConfigParseTest, ParsesConfiguration) {
"AllowAllConstructorInitializersOnNextLine: false",
PackConstructorInitializers, FormatStyle::PCIS_CurrentLine);
+ Style.PackParameters = FormatStyle::PPS_BinPack;
+
@@ -1174,6 +1192,18 @@ template <> struct MappingTraits {
Style.PackConstructorInitializers = FormatStyle::PCIS_CurrentLine;
}
+// If BinPackParameters was specified but PackParameters was not,
initialize
+// the latter from the former for backwards
@@ -5458,6 +5458,14 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine
,
return true;
}
+ // Ignores the first parameter as this will be handled separately by
+ // BreakFunctionDefinitionParameters or AlignAfterOpenBracket.
+ if
@@ -1918,11 +1901,12 @@ void
ContinuationIndenter::moveStatePastScopeOpener(LineState ,
// for backwards compatibility.
bool ObjCBinPackProtocolList =
(Style.ObjCBinPackProtocolList == FormatStyle::BPS_Auto &&
- Style.BinPackParameters) ||
+
@@ -1918,11 +1901,12 @@ void
ContinuationIndenter::moveStatePastScopeOpener(LineState ,
// for backwards compatibility.
bool ObjCBinPackProtocolList =
(Style.ObjCBinPackProtocolList == FormatStyle::BPS_Auto &&
- Style.BinPackParameters) ||
+
@@ -258,6 +259,13 @@ static void getARMMultilibFlags(const Driver ,
}
}
+static void getRISCVMultilibFlags(const Driver , const llvm::Triple ,
+ const llvm::opt::ArgList ,
+ Multilib::flags_list ) {
+
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clang-modules
@llvm/pr-subscribers-clang-format
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/101898.diff
17 Files Affected:
- (modified)
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/101898.diff
17 Files Affected:
- (modified) clang/include/clang/AST/ASTConcept.h (+2-3)
- (modified)
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/101898
None
>From 55a8255278f68b66aa532d2923f7dc3ada28a340 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Sun, 4 Aug 2024 10:19:51 -0700
Subject: [PATCH] [clang] Construct SmallVector with ArrayRef (NFC)
@@ -11639,6 +11639,7 @@ def warn_omp_unterminated_declare_target : Warning<
InGroup;
def err_ompx_bare_no_grid : Error<
"'ompx_bare' clauses requires explicit grid size via 'num_teams' and
'thread_limit' clauses">;
+def err_omp_multi_expr_not_allowed: Error<"only one
@@ -13004,13 +13004,34 @@ StmtResult
SemaOpenMP::ActOnOpenMPTargetUpdateDirective(
Clauses, AStmt);
}
+// This checks whether num_teams clause only has one expression.
+static bool checkNumTeamsClauseSingleExpr(SemaBase ,
https://github.com/jdoerfert commented:
I think this is almost ready. Only missing thing is the >3 argument check and
test.
https://github.com/llvm/llvm-project/pull/99732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/jdoerfert edited
https://github.com/llvm/llvm-project/pull/99732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11357,8 +11358,13 @@ void
OMPClauseReader::VisitOMPAllocateClause(OMPAllocateClause *C) {
void OMPClauseReader::VisitOMPNumTeamsClause(OMPNumTeamsClause *C) {
VisitOMPClauseWithPreInit(C);
- C->setNumTeams(Record.readSubExpr());
tbaederr wrote:
I have post-review powers for changes in `Interp/`.
https://github.com/llvm/llvm-project/pull/101845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/phoebewang closed
https://github.com/llvm/llvm-project/pull/101825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
/pull-request llvm/llvm-project#101888
https://github.com/llvm/llvm-project/pull/99335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
john-brawn-arm wrote:
/cherry-pick b32aac4358c1f6639de7c453656cd74fbab75d71
https://github.com/llvm/llvm-project/pull/99335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mizvekov wrote:
I think this is simple enough that we could backport.
https://github.com/llvm/llvm-project/pull/101745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
john-brawn-arm wrote:
> This seems to add a new feature, is it really relevant for a backport?
This is the last piece of work to enable GCS in the LLVM toolchain (clang and
lld support went in a while ago), and I was hoping to get everything in to LLVM
19. It would be rather annoying to have
https://github.com/john-brawn-arm closed
https://github.com/llvm/llvm-project/pull/99335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: John Brawn
Date: 2024-08-04T13:27:12+01:00
New Revision: b32aac4358c1f6639de7c453656cd74fbab75d71
URL:
https://github.com/llvm/llvm-project/commit/b32aac4358c1f6639de7c453656cd74fbab75d71
DIFF:
https://github.com/llvm/llvm-project/commit/b32aac4358c1f6639de7c453656cd74fbab75d71.diff
https://github.com/john-brawn-arm updated
https://github.com/llvm/llvm-project/pull/99335
>From e0f71863bd2f797c9208bdfc559bb69ade5a653a Mon Sep 17 00:00:00 2001
From: John Brawn
Date: Wed, 17 Jul 2024 15:18:46 +0100
Subject: [PATCH 1/4] [libunwind] Add GCS support for AArch64
AArch64 GCS
john-brawn-arm wrote:
> LGTM. Sorry for the delay.
>
> Q: Is there a way to play with the GCS feature in a VM? Do you have setup
> instructions?
https://git.yoctoproject.org/meta-arm/log/?h=testing/gcs is a demonstration
embedded linux that support GCS, including an emulator capable of
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (VolatileAcorn)
Changes
Deprecated the BinPackParameters boolean option in favor or PackParameters enum
option in order to provide a BreakAlways setting.
Related issues that have requested this feature
#51833
#23796
#53190
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/VolatileAcorn created
https://github.com/llvm/llvm-project/pull/101882
Deprecated the BinPackParameters boolean option in favor or PackParameters enum
option in order to provide a BreakAlways setting.
Related issues that have requested this feature
#51833
#23796
#53190
@@ -7842,6 +7853,61 @@ VPValue *VPRecipeBuilder::createEdgeMask(BasicBlock
*Src, BasicBlock *Dst) {
VPValue *SrcMask = getBlockInMask(Src);
+ if (auto *SI = dyn_cast(Src->getTerminator())) {
+assert(!OrigLoop->isLoopExiting(Src) &&
+ all_of(successors(Src),
@@ -7842,6 +7853,61 @@ VPValue *VPRecipeBuilder::createEdgeMask(BasicBlock
*Src, BasicBlock *Dst) {
VPValue *SrcMask = getBlockInMask(Src);
+ if (auto *SI = dyn_cast(Src->getTerminator())) {
+assert(!OrigLoop->isLoopExiting(Src) &&
+ all_of(successors(Src),
@@ -7842,6 +7853,61 @@ VPValue *VPRecipeBuilder::createEdgeMask(BasicBlock
*Src, BasicBlock *Dst) {
VPValue *SrcMask = getBlockInMask(Src);
+ if (auto *SI = dyn_cast(Src->getTerminator())) {
+assert(!OrigLoop->isLoopExiting(Src) &&
+ all_of(successors(Src),
@@ -7842,6 +7853,61 @@ VPValue *VPRecipeBuilder::createEdgeMask(BasicBlock
*Src, BasicBlock *Dst) {
VPValue *SrcMask = getBlockInMask(Src);
+ if (auto *SI = dyn_cast(Src->getTerminator())) {
+assert(!OrigLoop->isLoopExiting(Src) &&
+ all_of(successors(Src),
@@ -7842,6 +7853,61 @@ VPValue *VPRecipeBuilder::createEdgeMask(BasicBlock
*Src, BasicBlock *Dst) {
VPValue *SrcMask = getBlockInMask(Src);
+ if (auto *SI = dyn_cast(Src->getTerminator())) {
+assert(!OrigLoop->isLoopExiting(Src) &&
+ all_of(successors(Src),
@@ -86,6 +86,9 @@ C++23 Feature Support
C++2c Feature Support
^
+- Add ``__builtin_is_implicit_lifetime`` intrinsic, which supports
Endilll wrote:
See #98310
https://github.com/llvm/llvm-project/pull/101807
https://github.com/Endilll commented:
`Sema.h` changes LGTM
https://github.com/llvm/llvm-project/pull/101857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
> The intent is for this to be backported to 19 (therefore no changelog)
Yes, this is very important to backport.
https://github.com/llvm/llvm-project/pull/101879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Endilll commented:
LGTM
https://github.com/llvm/llvm-project/pull/101879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -86,6 +86,9 @@ C++23 Feature Support
C++2c Feature Support
^
+- Add ``__builtin_is_implicit_lifetime`` intrinsic, which supports
cor3ntin wrote:
CF https://github.com/llvm/llvm-project/issues/98310#issuecomment-2248326726
@@ -5637,6 +5638,27 @@ static bool EvaluateUnaryTypeTrait(Sema , TypeTrait
UTT,
return false;
case UTT_IsTriviallyEqualityComparable:
return isTriviallyEqualityComparableType(Self, T, KeyLoc);
+ case UTT_IsImplicitLifetime: {
+DiagnoseVLAInCXXTypeTrait(Self,
@@ -86,6 +86,9 @@ C++23 Feature Support
C++2c Feature Support
^
+- Add ``__builtin_is_implicit_lifetime`` intrinsic, which supports
MitalAshok wrote:
Why is this called `__builtin_is_implicit_lifetime` instead of
`__is_implicit_lifetime`
@@ -5637,6 +5638,27 @@ static bool EvaluateUnaryTypeTrait(Sema , TypeTrait
UTT,
return false;
case UTT_IsTriviallyEqualityComparable:
return isTriviallyEqualityComparableType(Self, T, KeyLoc);
+ case UTT_IsImplicitLifetime: {
+DiagnoseVLAInCXXTypeTrait(Self,
@@ -5637,6 +5638,27 @@ static bool EvaluateUnaryTypeTrait(Sema , TypeTrait
UTT,
return false;
case UTT_IsTriviallyEqualityComparable:
return isTriviallyEqualityComparableType(Self, T, KeyLoc);
+ case UTT_IsImplicitLifetime: {
+DiagnoseVLAInCXXTypeTrait(Self,
https://github.com/cor3ntin approved this pull request.
LGTM, thanks!
Do we want to backport to clang 19? that seems reasonable
https://github.com/llvm/llvm-project/pull/101745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
cor3ntin wrote:
The intent is for this to be backported to 19 (therefore no changelog)
https://github.com/llvm/llvm-project/pull/101879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
If a fold expanded constraint would expand packs of different size, it is not a
valid pack expansion and it is not satisfied. This should not produce an error.
Fixes #99430
---
Full diff:
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/101879
If a fold expanded constraint would expand packs of different size, it is not a
valid pack expansion and it is not satisfied. This should not produce an error.
Fixes #99430
>From
@@ -0,0 +1,29 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -pedantic-errors %s
+
+namespace c {
+ extern "C" void main(); // expected-error {{invalid linkage specification
'extern "C"'}}
+}
+extern "C" {
+ int main(); // expected-error {{invalid linkage specification 'extern
@@ -990,6 +990,9 @@ def warn_main_redefined : Warning<"variable named 'main'
with external linkage "
"has undefined behavior">, InGroup;
def ext_main_used : Extension<
"referring to 'main' within an expression is a Clang extension">,
InGroup;
+def
https://github.com/cor3ntin commented:
Generally looks good but can you add tests for non aggregate with non elligible
constructors and destructors ?
(ie a class template with `requires false` on various destructor/constructor?)
(or better yet a class template that takes a bool NTTP aso you can
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/101871
>From 6dd98b5c255580909a9f38baa1bbdc257e5d60d2 Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Sun, 4 Aug 2024 09:09:19 +0100
Subject: [PATCH] [Clang][CodeGen] Add `[[clang::asm_dialect]]` attribute
---
tru wrote:
This seems to add a new feature, is it really relevant for a backport?
https://github.com/llvm/llvm-project/pull/99335
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1442,8 +1442,49 @@ Decl
*TemplateDeclInstantiator::VisitFriendDecl(FriendDecl *D) {
if (D->isUnsupportedFriend()) {
InstTy = Ty;
} else {
- InstTy = SemaRef.SubstType(Ty, TemplateArgs,
- D->getLocation(),
https://github.com/cor3ntin commented:
Looks generally good from a cursory review.
I think we want to add tests for modules / in the test/PCH directory.
We probably want that as an extension indeed, no reason not to
We probably want a separate PR to add the pack indexing macro. I did not add
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/101448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
401 - 500 of 457674 matches
Mail list logo
