[Lldb-commits] [lldb] [lldb][test][win][x86_64] Fix XFAIL and XPASS on LLDB API tests (PR #100477)

@@ -12,6 +12,7 @@ class MultipleSlidesTestCase(TestBase): NO_DEBUG_INFO_TESTCASE = True +@expectedFailureAll(oslist=["windows"], archs=["x86_64"]) dzhidzhoev wrote: Could you provide a failure log for this? It passes on our CI (Windows native

[Lldb-commits] [lldb] 6a1a393 - [LLDB] Remove decorator from XPASSes x86/Windows (#100628)

Author: Vladislav Dzhidzhoev Date: 2024-07-26T14:28:11+02:00 New Revision: 6a1a393997fb5f7bdb01943ed48dc72d48861824 URL: https://github.com/llvm/llvm-project/commit/6a1a393997fb5f7bdb01943ed48dc72d48861824 DIFF:

[Lldb-commits] [lldb] [LLDB] Remove decorator from XPASSes x86/Windows (PR #100628)

https://github.com/dzhidzhoev closed https://github.com/llvm/llvm-project/pull/100628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][win][x86_64] XFAIL already failing Shell tests (PR #100476)

@@ -1,3 +1,4 @@ +# XFAIL: target=x86_64-{{.*}}-windows{{.*}} # Make sure lldb can handle filenames with single quotes in them. # RUN: %clang_host %p/Inputs/hello.c -g -o "%t-'pat" dzhidzhoev wrote: The same as for TestConvenienceVariables.test: ``` PASS:

[Lldb-commits] [lldb] [lldb][test][win][x86_64] XFAIL already failing Shell tests (PR #100476)

@@ -1,3 +1,5 @@ +# XFAIL: target=x86_64-{{.*}}-windows{{.*}} dzhidzhoev wrote: We have it green as well ``` PASS: lldb-shell :: SymbolFile/DWARF/x86/dead-code-filtering.yaml (389 of 543) Exit Code: 0 Command Output (stdout): -- # RUN: at

[Lldb-commits] [lldb] [lldb][test][win][x86_64] XFAIL already failing Shell tests (PR #100476)

@@ -1,3 +1,4 @@ +# XFAIL: target=x86_64-{{.*}}-windows{{.*}} dzhidzhoev wrote: ``` PASS: lldb-shell :: Settings/TestEchoCommands.test (315 of 543) Exit Code: 0 Command Output (stdout): -- # RUN: at line 1 c:\build-lldb-native\bin\lldb.exe

[Lldb-commits] [lldb] [lldb][test][win][x86_64] XFAIL already failing Shell tests (PR #100476)

@@ -1,5 +1,7 @@ // clang-format off +// XFAIL: target=x86_64-{{.*}}-windows{{.*}} dzhidzhoev wrote: As far as I understand, NativePDB tests only run for Windows host+Windows target, contrary to the tests from the PDB folder which we managed to run on Linux

[Lldb-commits] [lldb] [lldb][test][win][x86_64] XFAIL already failing Shell tests (PR #100476)

@@ -1,3 +1,4 @@ +# XFAIL: target=x86_64-{{.*}}-windows{{.*}} dzhidzhoev wrote: Interestingly, this test is green on our Windows native CI. It uses cmd.exe. Here's the log: ``` PASS: lldb-shell :: Driver/TestConvenienceVariables.test (88 of

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

rocallahan wrote: > The two are different when it comes to the ABI Yeah OK. I've fixed that. https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

https://github.com/rocallahan updated https://github.com/llvm/llvm-project/pull/99736 >From e9a44b4cfd2e3423fbf5ac75124530cc2bb8afed Mon Sep 17 00:00:00 2001 From: Robert O'Callahan Date: Fri, 19 Jul 2024 22:46:42 +1200 Subject: [PATCH] [lldb] Implement basic support for reverse-continue This

[Lldb-commits] [lldb] [lldb] Refactor TypeQuery::ContextMatches (PR #99305)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/99305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor TypeQuery::ContextMatches (PR #99305)

@@ -153,19 +127,89 @@ void TypeQuery::SetLanguages(LanguageSet languages) { bool TypeQuery::ContextMatches( llvm::ArrayRef context_chain) const { - if (GetExactMatch() || context_chain.size() == m_context.size()) -return ::contextMatches(context_chain, m_context); -

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

labath wrote: > One thing that's not entirely clear to me from the discussion so far: > apparently the public API rules allow adding an overload of > `SBProcess::Continue()` with a direction parameter. Do they allow just adding > a direction parameter to the existing overload _with a default

[Lldb-commits] [lldb] [lldb] Refactor TypeQuery::ContextMatches (PR #99305)

@@ -153,19 +127,89 @@ void TypeQuery::SetLanguages(LanguageSet languages) { bool TypeQuery::ContextMatches( llvm::ArrayRef context_chain) const { - if (GetExactMatch() || context_chain.size() == m_context.size()) -return ::contextMatches(context_chain, m_context); -

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

rocallahan wrote: One thing that's not entirely clear to me from the discussion so far: apparently the public API rules allow adding an overload of `SBProcess::Continue()` with a direction parameter. Do they allow just adding a direction parameter to the existing overload *with a default

[Lldb-commits] [lldb] [lldb] Multithreading lldb-server works on Windows now; fixed gdb port mapping (PR #100670)

labath wrote: One way I can imagine this happening is if the FileSystem instance was local to a `GDBRemoteCommunicationServerPlatform` instance -- rather than the thread it happens to be (mostly) running on. This will require more changes to, basically, plumb the filesystem instance to every

[Lldb-commits] [lldb] [lldb][test][win][x86_64] Fix XFAIL and XPASS on LLDB API tests (PR #100477)

https://github.com/labath commented: This looks much better, and it looks like @dzhidzhoev is just about to remove some of the same XFAILS as well (in #100628). I suggest you two collaborate on the remaining ones. https://github.com/llvm/llvm-project/pull/100477

[Lldb-commits] [lldb] [lldb] Multithreading lldb-server works on Windows now; fixed gdb port mapping (PR #100670)

@@ -324,6 +324,18 @@ Status PipePosix::ReadWithTimeout(void *buf, size_t size, bytes_read += result; if (bytes_read == size || result == 0) break; + +// This is the workaround for the following bug in Linux multithreading +// select()

[Lldb-commits] [lldb] [lldb] Multithreading lldb-server works on Windows now; fixed gdb port mapping (PR #100670)

https://github.com/labath requested changes to this pull request. I wanted to change this code to use threads for a long time, but the idea of using a per-thread virtual file system absolutely terrifies me. That only works is all of the accesses go through the file system (no direct syscalls)

[Lldb-commits] [lldb] [lldb] Multithreading lldb-server works on Windows now; fixed gdb port mapping (PR #100670)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/100670 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Create VLAs of explicitly 0-size as ConstantArrayType (PR #100710)

@@ -0,0 +1,80 @@ +// RUN: %clangxx_host -gdwarf -std=c++11 -o %t %s +// RUN: %lldb %t \ +// RUN: -o run \ +// RUN: -o "frame var --show-types f" \ +// RUN: -o "frame var vla0" \ +// RUN: -o "frame var fla0" \ +// RUN: -o "frame var fla1" \ +// RUN: -o "frame var

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Create VLAs of explicitly 0-size as ConstantArrayType (PR #100710)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/100710 >From 9136653363bb7fc58e0b7f55a714d36d4613fe24 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 26 Jul 2024 01:19:02 +0100 Subject: [PATCH 1/3] [lldb][TypeSystemClang][NFC] Clean up

[Lldb-commits] [lldb] [lldb] Optimized lldb-server memory usage (PR #100666)

https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/100666 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Optimized lldb-server memory usage (PR #100666)

@@ -1145,8 +1145,8 @@ Status GDBRemoteCommunication::StartDebugserverProcess( if (socket_pipe.CanWrite()) socket_pipe.CloseWriteFileDescriptor(); if (socket_pipe.CanRead()) { -char port_cstr[PATH_MAX] = {0}; -port_cstr[0] = '\0'; +//

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/99336 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

@@ -0,0 +1,58 @@ +//===--- DirectToIndirectFCR.h - RISC-V specific pass -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Improved lldb-server stability for remote launching (PR #100659)

labath wrote: > If that's not what's happening right now, then we ought to fix it. Or at least, understand why is that impossible. https://github.com/llvm/llvm-project/pull/100659 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [LLDB] Add an assert to verify sign_bit_pos is within the valid range (NFC) (PR #95678)

https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/95678 >From ef5b9cefb408ca3a721c95d8f6702abba77a602b Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Sun, 16 Jun 2024 00:21:51 +0530 Subject: [PATCH 1/4] [LLDB] Add an assert to verify sign_bit_pos is within the

[Lldb-commits] [lldb] [LLDB] Add an assert to verify sign_bit_pos is within the valid range (NFC) (PR #95678)

@@ -746,27 +746,18 @@ Status Scalar::SetValueFromData(const DataExtractor , bool Scalar::SignExtend(uint32_t sign_bit_pos) { const uint32_t max_bit_pos = GetByteSize() * 8; - if (sign_bit_pos < max_bit_pos) { -switch (m_type) { -case Scalar::e_void: -case

[Lldb-commits] [lldb] [lldb] Tolerate multiple compile units with the same DWO ID (PR #100577)

@@ -170,7 +170,7 @@ class DWARFUnit : public UserID { /// both cases correctly and avoids crashes. DWARFCompileUnit *GetSkeletonUnit(); - void SetSkeletonUnit(DWARFUnit *skeleton_unit); + bool LinkToSkeletonUnit(DWARFUnit _unit); labath wrote: It just

[Lldb-commits] [lldb] [lldb][test][win][x86_64] Fix XFAIL and XPASS on LLDB API tests (PR #100477)

@@ -52,6 +52,7 @@ def test_negative_indexing(self): self.build() self.validate_negative_indexing() +@expectedFailureAll(oslist=["windows"], archs=["x86_64"]) DavidSpickett wrote: I recently updated this for Windows on Arm

[Lldb-commits] [lldb] [lldb] Tolerate multiple compile units with the same DWO ID (PR #100577)

@@ -718,13 +720,11 @@ DWARFCompileUnit *DWARFUnit::GetSkeletonUnit() { return llvm::dyn_cast_or_null(m_skeleton_unit); } -void DWARFUnit::SetSkeletonUnit(DWARFUnit *skeleton_unit) { - // If someone is re-setting the skeleton compile unit backlink, make sure - // it is

[Lldb-commits] [lldb] [lldb][test][win][x86_64] Fix XFAIL and XPASS on LLDB API tests (PR #100477)

DavidSpickett wrote: > I'd show a full test log but for whatever reason, it's not being verbose > despite being asked to, working on that. I've fixed this, you can get a full test list by downloading the log file e.g.

[Lldb-commits] [lldb] [lldb] IRMemoryMap zero address mapping fix (PR #99045)

dlav-sc wrote: > I put up a PR that avoids a memory region starting at address 0, and also > clarifies the documentation of the qMemoryRegionInfo packet to state that > permissions: are required for all memory regions that are accessible by the > inferior process. A memory region with no

[Lldb-commits] [lldb] [lldb] Remove python helper getCompilerBinary() (PR #100660)

DavidSpickett wrote: And the CI failure is one of our old friends: ``` Timed Out Tests (1): lldb-api :: functionalities/fork/concurrent_vfork/TestConcurrentVFork.py ``` That you can safely ignore. https://github.com/llvm/llvm-project/pull/100660 ___

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

@@ -456,21 +492,15 @@ ifeq (1, $(USE_SYSTEM_STDLIB)) endif CXXFLAGS += -nostdlib++ -nostdinc++ -cxx-isystem $(SDKROOT)/usr/include/c++/v1 LDFLAGS += -L$(SDKROOT)/usr/lib -Wl,-rpath,$(SDKROOT)/usr/lib -lc++ +else +ifneq (,$(findstring

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

@@ -267,7 +274,9 @@ endif CFLAGS += $(CFLAGS_EXTRAS) CXXFLAGS += -std=c++11 $(CFLAGS) $(ARCH_CXXFLAGS) LD = $(CC) -LDFLAGS ?= $(CFLAGS) +# Copy common options to the linker flags (dwarf, arch. & etc). +# Note: we get some 'garbage' options for linker here (such as -I,

[Lldb-commits] [lldb] [lldb] Remove python helper getCompilerBinary() (PR #100660)

DavidSpickett wrote: Seems fine to me, but there is a use of it in `lldb/packages/Python/lldbsuite/test/lldbtest.py` that should also be removed. https://github.com/llvm/llvm-project/pull/100660 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Remove python helper getCompilerBinary() (PR #100660)

@@ -266,16 +266,11 @@ def getCompiler(): return module.getCompiler() -def getCompilerBinary(): -"""Returns the compiler binary the test suite is running with.""" -return getCompiler().split()[0] - - def getCompilerVersion(): """Returns a string that

[Lldb-commits] [lldb] [lldb] Remove python helper getCompilerBinary() (PR #100660)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/100660 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Remove decorator from XPASSes x86/Windows (PR #100628)

https://github.com/DavidSpickett approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/100628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Optimized lldb-server memory usage (PR #100666)

@@ -1145,7 +1145,8 @@ Status GDBRemoteCommunication::StartDebugserverProcess( if (socket_pipe.CanWrite()) socket_pipe.CloseWriteFileDescriptor(); if (socket_pipe.CanRead()) { -char port_cstr[PATH_MAX] = {0}; +// The port number may be

[Lldb-commits] [lldb] [lldb] Optimized lldb-server memory usage (PR #100666)

https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/100666 >From 0e451f16b91bab2bc2cd1375eb02e4fe71998790 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Fri, 26 Jul 2024 02:40:49 +0400 Subject: [PATCH 1/2] [lldb] Optimized lldb-server memory usage MAX_PATH is

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Create VLAs of explicitly 0-size as ConstantArrayType (PR #100710)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/100710 Depends on https://github.com/llvm/llvm-project/pull/100674 Currently, we treat VLAs declared as `int[]` and `int[0]` identically. I.e., we create them as `IncompleteArrayType`s. However, the `DW_AT_count`

[Lldb-commits] [lldb] [lldb-dap] Updated README.md for newly added attach properties. (PR #99926)

https://github.com/santhoshe447 updated https://github.com/llvm/llvm-project/pull/99926 >From 960351c9abf51f42d92604ac6297aa5b76ddfba5 Mon Sep 17 00:00:00 2001 From: Santhosh Kumar Ellendula Date: Fri, 17 Nov 2023 15:09:10 +0530 Subject: [PATCH 01/20] [lldb][test] Add the ability to extract

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t byte_size) { return llvm::APFloatBase::Bogus(); } +std::optional +TypeSystemClang::GetObjCBitSize(QualType qual_type, +ExecutionContextScope *exe_scope) { +

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/100674 >From 0f982058ed0e8a28c4e4b440f480584fa06e80d5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 26 Jul 2024 01:19:02 +0100 Subject: [PATCH 1/4] [lldb][TypeSystemClang][NFC] Clean up

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t byte_size) { return llvm::APFloatBase::Bogus(); } +std::optional +TypeSystemClang::GetObjCBitSize(QualType qual_type, +ExecutionContextScope *exe_scope) { +

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/100674 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t byte_size) { return llvm::APFloatBase::Bogus(); } +std::optional +TypeSystemClang::GetObjCBitSize(QualType qual_type, +ExecutionContextScope *exe_scope) { +

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

@@ -4725,67 +4725,69 @@ TypeSystemClang::GetFloatTypeSemantics(size_t byte_size) { return llvm::APFloatBase::Bogus(); } +std::optional +TypeSystemClang::GetObjCBitSize(QualType qual_type, +ExecutionContextScope *exe_scope) { +

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

https://github.com/JDevlieghere requested changes to this pull request. https://github.com/llvm/llvm-project/pull/100674 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/100443 >From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 23 Jul 2024 16:50:57 -0700 Subject: [PATCH 01/10] Implemplement a thread list that is currently unused for

[Lldb-commits] [lldb] [lldb] Optimized lldb-server memory usage (PR #100666)

jasonmolenda wrote: Hm, I was worried that we might get the filepath of a unix socket in some use case, but we llvm::to_integer(port_cstr) shortly later, so that can't be the case. https://github.com/llvm/llvm-project/pull/100666 ___ lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

rocallahan wrote: > First off, for systems that do past motion and forward motion, there are > things you really can't do effectively in the past, like set variable values > and have that make any difference. So we probably will need to know whether > we're executing in the immutable past or

[Lldb-commits] [lldb] [lldb] Optimized lldb-server memory usage (PR #100666)

@@ -1145,7 +1145,8 @@ Status GDBRemoteCommunication::StartDebugserverProcess( if (socket_pipe.CanWrite()) socket_pipe.CloseWriteFileDescriptor(); if (socket_pipe.CanRead()) { -char port_cstr[PATH_MAX] = {0}; +// The port number may be

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/100674 >From 0f982058ed0e8a28c4e4b440f480584fa06e80d5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 26 Jul 2024 01:19:02 +0100 Subject: [PATCH 1/3] [lldb][TypeSystemClang][NFC] Clean up

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/100674 >From 0f982058ed0e8a28c4e4b440f480584fa06e80d5 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 26 Jul 2024 01:19:02 +0100 Subject: [PATCH 1/2] [lldb][TypeSystemClang][NFC] Clean up

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch performs following NFC changes to TypeSystemClang::GetBitSize: * Factor out the Objective-C logic into a helper function. * Introduce a new case for `FunctionProto`. I don't see a good reason for

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

jimingham wrote: > On Jul 25, 2024, at 3:34 PM, Greg Clayton ***@***.***> wrote: > > > @clayborg commented on this pull request. > > In lldb/include/lldb/API/SBProcess.h > : > > > - lldb::SBError Continue(); > +

[Lldb-commits] [lldb] [lldb][TypeSystemClang][NFC] Clean up TypeSystemClang::GetBitSize (PR #100674)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/100674 This patch performs following NFC changes to TypeSystemClang::GetBitSize: * Factor out the Objective-C logic into a helper function. * Introduce a new case for `FunctionProto`. I don't see a good reason for

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

jimingham wrote: > On Jul 25, 2024, at 4:58 PM, rocallahan ***@***.***> wrote: > > > Most of the execution control logic should just know "forward" and > "backwards", but then whether those are implemented by using the reverse > debugging machinery or by allowing the program to run for

[Lldb-commits] [lldb] [lldb] Revert scripting template list patches (PR #100673)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes Reverts https://github.com/llvm/llvm-project/pull/97273 since it broke the windows bot: https://lab.llvm.org/buildbot/#/builders/141/builds/1025/steps/4/logs/stdio --- Patch is 49.74 KiB,

[Lldb-commits] [lldb] [lldb] Revert scripting template list patches (PR #100673)

https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/100673 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e8504cb - [lldb] Revert scripting template list patches (#100673)

Author: Med Ismail Bennani Date: 2024-07-25T17:11:36-07:00 New Revision: e8504cb0c933b75d0e31a627d3bd4c0e37e042e1 URL: https://github.com/llvm/llvm-project/commit/e8504cb0c933b75d0e31a627d3bd4c0e37e042e1 DIFF:

[Lldb-commits] [lldb] [lldb] Revert scripting template list patches (PR #100673)

https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/100673 Reverts https://github.com/llvm/llvm-project/pull/97273 since it broke the windows bot: https://lab.llvm.org/buildbot/#/builders/141/builds/1025/steps/4/logs/stdio >From

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

rocallahan wrote: > Most of the execution control logic should just know "forward" and > "backwards", but then whether those are implemented by using the reverse > debugging machinery or by allowing the program to run for realz will be know > deeper in the execution control machinery - most

[Lldb-commits] [lldb] [lldb] Multithreading lldb-server works on Windows now; fixed gdb port mapping (PR #100670)

https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/100670 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/100443 >From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 23 Jul 2024 16:50:57 -0700 Subject: [PATCH 1/9] Implemplement a thread list that is currently unused for

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

@@ -46,8 +48,79 @@ SaveCoreOptions::GetOutputFile() const { return m_file; } +Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) { + Status error; + if (!process_sp) { +ClearProcessSpecificData(); +m_process_sp = std::nullopt; +return error; + } +

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

@@ -46,8 +48,79 @@ SaveCoreOptions::GetOutputFile() const { return m_file; } +Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) { + Status error; + if (!process_sp) { +ClearProcessSpecificData(); +m_process_sp = std::nullopt; +return error; + } +

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

@@ -46,8 +48,79 @@ SaveCoreOptions::GetOutputFile() const { return m_file; } +Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) { + Status error; + if (!process_sp) { +ClearProcessSpecificData(); +m_process_sp = std::nullopt; +return error; + } +

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

Jlalond wrote: > Stepping back a bit, do we gain anything in `SaveCoreOptions` by having > `m_process_sp` be optional? Is there a distinction between an empty ProcessSP > and no ProcessSP object? No, this was mostly a mistake on my part. I wanted to describe process as optional but required

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

@@ -75,6 +77,18 @@ lldb::SaveCoreStyle SBSaveCoreOptions::GetStyle() const { return m_opaque_up->GetStyle(); } +SBError SBSaveCoreOptions::SetProcess(lldb::SBProcess process) { + return m_opaque_up->SetProcess(process.GetSP()); +} + +SBError

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/100443 >From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 23 Jul 2024 16:50:57 -0700 Subject: [PATCH 1/8] Implemplement a thread list that is currently unused for

[Lldb-commits] [lldb] 0d4f948 - [lldb/Plugins] Fix build failure on windows following 2914a4b88837

Author: Med Ismail Bennani Date: 2024-07-25T16:19:34-07:00 New Revision: 0d4f9484bcd51d1ed07723c7b762e0f33d9f448f URL: https://github.com/llvm/llvm-project/commit/0d4f9484bcd51d1ed07723c7b762e0f33d9f448f DIFF:

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/99336 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

dlav-sc wrote: > A quick look at the RISCV ISA and it says that the JAL instruction is pc > relative and can jump +/- 1MB. JALR gets the upper 20 bits from a general > purpose register and it includes 12 low bits in its instruction encoding. I > know almost nothing about rv32, but is this

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

@@ -46,8 +46,59 @@ SaveCoreOptions::GetOutputFile() const { return m_file; } +void SaveCoreOptions::AddThread(lldb::tid_t tid) { + if (m_threads_to_save.count(tid) == 0) +m_threads_to_save.emplace(tid); +} + +bool SaveCoreOptions::RemoveThread(lldb::tid_t tid) { + if

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/100443 >From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 23 Jul 2024 16:50:57 -0700 Subject: [PATCH 1/7] Implemplement a thread list that is currently unused for

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/100443 >From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 23 Jul 2024 16:50:57 -0700 Subject: [PATCH 1/7] Implemplement a thread list that is currently unused for

[Lldb-commits] [lldb] [lldb] Multithreading lldb-server works on Windows now; fixed gdb port mapping (PR #100670)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Removed fork(). Used threads and the common thread-safe port map for all platform connections. Updated lldb::FileSystem to use llvm::vfs::createPhysicalFileSystem() with an own virtual working directory

[Lldb-commits] [lldb] [lldb] Multithreading lldb-server works on Windows now; fixed gdb port mapping (PR #100670)

https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/100670 Removed fork(). Used threads and the common thread-safe port map for all platform connections. Updated lldb::FileSystem to use llvm::vfs::createPhysicalFileSystem() with an own virtual working directory per

[Lldb-commits] [lldb] [lldb][test][win][x86_64] Fix XFAIL and XPASS on LLDB API tests (PR #100477)

https://github.com/kendalharland edited https://github.com/llvm/llvm-project/pull/100477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][win][x86_64] FIx XFAIL and XPASS on LLDB API tests (PR #100477)

https://github.com/kendalharland edited https://github.com/llvm/llvm-project/pull/100477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][win][x86_64] Remove XFAIL from XPASS'ing API tests (PR #100477)

https://github.com/kendalharland edited https://github.com/llvm/llvm-project/pull/100477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][win][x86_64] Remove XFAIL from XPASS'ing API tests (PR #100477)

@@ -52,6 +52,7 @@ def test_negative_indexing(self): self.build() self.validate_negative_indexing() +@expectedFailureAll(oslist=["windows"], archs=["x86_64"]) kendalharland wrote: I am still seeing this test fail with: ```

[Lldb-commits] [lldb] [lldb][test][win][x86_64] Remove XFAIL from XPASS'ing API tests (PR #100477)

https://github.com/kendalharland edited https://github.com/llvm/llvm-project/pull/100477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

medismailben wrote: > The reland broke the Fuchsia Windows build with a similar error to the LLVM > Windows bots, but I wasn't able to cleanly revert this commit without > detailed knowledge of the contents. Could you revert this (preferentially) or > fix forward? > >

[Lldb-commits] [lldb] [lldb][test][win][x86_64] XFAIL already failing API tests (PR #100477)

kendalharland wrote: Thanks for the assistance @labath and @DavidSpickett. After fixing my cmake configuration I'm actually seeing a few tests unexpectedly pass with different options: CMAKE_C_COMPILER clang-cl.exe CMAKE_CXX_COMPILER clang-cl.exe CMAKE_BUILD_TYPE Release

[Lldb-commits] [lldb] [lldb][test][win][x86_64] XFAIL already failing API tests (PR #100477)

https://github.com/kendalharland updated https://github.com/llvm/llvm-project/pull/100477 >From ac737efe9cb7d9fa690a6dfaa8ba7c6e006913c1 Mon Sep 17 00:00:00 2001 From: kendal Date: Thu, 25 Jul 2024 15:52:47 -0700 Subject: [PATCH] [lldb][test][win][x86_64] XFAIL already failing API tests These

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/99336 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improved lldb-server stability for remote launching (PR #100659)

@@ -201,7 +201,7 @@ struct ForkLaunchInfo { execve(info.argv[0], const_cast(info.argv), info.envp); #if defined(__linux__) - if (errno == ETXTBSY) { + for (int i = 0; i < 50; ++i) { slydiman wrote: I think it is redundant. Currently lldb-server contains

[Lldb-commits] [lldb] [lldb][test][win][x86_64] XFAIL already failing API tests (PR #100477)

https://github.com/kendalharland updated https://github.com/llvm/llvm-project/pull/100477 >From 5a32aac6f71c24bc111a1139b69a7568203dae69 Mon Sep 17 00:00:00 2001 From: kendal Date: Thu, 25 Jul 2024 15:26:38 -0700 Subject: [PATCH] [lldb][test][win][x86_64] Remove XFAIL from passing API tests

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

@@ -0,0 +1,194 @@ +//===--- DirectToIndirectFCR.cpp - RISC-V specific pass ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Improved lldb-server stability for remote launching (PR #100659)

https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/100659 >From 21fd03faa1224d44bd132a0b53d66d896210a044 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Fri, 26 Jul 2024 01:48:35 +0400 Subject: [PATCH] [lldb] Improved lldb-server stability for remote launching

[Lldb-commits] [lldb] [lldb] Optimized lldb-server memory usage (PR #100666)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes MAX_PATH is definitely larger than 6 bytes we are expecting for this message, and could be rather large depending on the target OS (4K for some Linux OSs). Since the buffer gets allocated on the stack we

[Lldb-commits] [lldb] [lldb] Optimized lldb-server memory usage (PR #100666)

https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/100666 MAX_PATH is definitely larger than 6 bytes we are expecting for this message, and could be rather large depending on the target OS (4K for some Linux OSs). Since the buffer gets allocated on the stack we

[Lldb-commits] [lldb] [lldb] Tolerate multiple compile units with the same DWO ID (PR #100577)

@@ -718,13 +720,11 @@ DWARFCompileUnit *DWARFUnit::GetSkeletonUnit() { return llvm::dyn_cast_or_null(m_skeleton_unit); } -void DWARFUnit::SetSkeletonUnit(DWARFUnit *skeleton_unit) { - // If someone is re-setting the skeleton compile unit backlink, make sure - // it is

[Lldb-commits] [lldb] [lldb] Tolerate multiple compile units with the same DWO ID (PR #100577)

@@ -170,7 +170,7 @@ class DWARFUnit : public UserID { /// both cases correctly and avoids crashes. DWARFCompileUnit *GetSkeletonUnit(); - void SetSkeletonUnit(DWARFUnit *skeleton_unit); + bool LinkToSkeletonUnit(DWARFUnit _unit); clayborg wrote: Is

<    2   3   4   5   6   7   8   9   10   11   >