@@ -106,12 +106,19 @@ SymbolVendorELF::CreateInstance(const lldb::ModuleSP
_sp,
FileSpec dsym_fspec =
PluginManager::LocateExecutableSymbolFile(module_spec, search_paths);
if (!dsym_fspec || IsDwpSymbolFile(module_sp, dsym_fspec)) {
-// If we have a stripped
https://github.com/clayborg commented:
Anytime we change this code it makes me nervous. The unit tests are quite
simple and not sure how they match up against real world lookups, but as far as
I can tell this looks ok.
https://github.com/llvm/llvm-project/pull/99305
https://github.com/luporl closed https://github.com/llvm/llvm-project/pull/99357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Leandro Lupori
Date: 2024-07-17T14:49:22-03:00
New Revision: 93d38d7f08864397f1e751c8cecde5ea302ecced
URL:
https://github.com/llvm/llvm-project/commit/93d38d7f08864397f1e751c8cecde5ea302ecced
DIFF:
luporl wrote:
Merging to fix https://lab.llvm.org/buildbot/#/builders/141/builds/853, which
has been broken for over 36 hours.
https://github.com/llvm/llvm-project/pull/99357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kevin Frei (kevinfrei)
Changes
@walter-erquinigo found the the [PR with testing and a fix for
DebugInfoD](https://github.com/llvm/llvm-project/pull/98344) caused an issue
when working with stripped binaries.
The issue is that when you're
https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/99362
@walter-erquinigo found the the [PR with testing and a fix for
DebugInfoD](https://github.com/llvm/llvm-project/pull/98344) caused an issue
when working with stripped binaries.
The issue is that when you're
luporl wrote:
Test added in #98330.
https://github.com/llvm/llvm-project/pull/99357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Leandro Lupori (luporl)
Changes
libcxx-simulators/unique_ptr/main.cpp uses __builtin_printf, that
maps to printf on Windows. Include stdio.h to avoid linker errors
on Windows.
See https://lab.llvm.org/buildbot/#/builders/141/builds/853
https://github.com/luporl created
https://github.com/llvm/llvm-project/pull/99357
libcxx-simulators/unique_ptr/main.cpp uses __builtin_printf, that
maps to printf on Windows. Include stdio.h to avoid linker errors
on Windows.
See https://lab.llvm.org/buildbot/#/builders/141/builds/853
>From
@@ -0,0 +1,45 @@
+//===-- CoreDumpOptions.cpp -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/98845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-07-17T10:05:55-07:00
New Revision: 86ef699060394c82dcda7e86ff70d8cabeabcc2a
URL:
https://github.com/llvm/llvm-project/commit/86ef699060394c82dcda7e86ff70d8cabeabcc2a
DIFF:
https://github.com/llvm/llvm-project/commit/86ef699060394c82dcda7e86ff70d8cabeabcc2a.diff
@@ -1271,13 +1271,13 @@ class CommandObjectProcessSaveCore : public
CommandObjectParsed {
switch (short_option) {
case 'p':
-m_requested_plugin_name = option_arg.str();
+m_core_dump_options.SetCoreDumpPluginName(option_arg.data());
@@ -1222,7 +1223,19 @@ lldb::SBError SBProcess::SaveCore(const char *file_name)
{
lldb::SBError SBProcess::SaveCore(const char *file_name,
const char *flavor,
SaveCoreStyle core_style) {
-
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/8] [lldb] progressive progress reporting for darwin
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
ac4b6b662630cd4d3bf6929f2b39ea203c0054a1...3ad75f024eec22f2dfd0ae7cc911f6d70202932d
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (dlav-sc)
Changes
To make function calls inside lldb expressions ABI support, JIT engine support
are required. This patch augments corresponding functionality to RISCV ABI and
implements RISCV relocation resolver in JIT, which allows
https://github.com/dlav-sc created
https://github.com/llvm/llvm-project/pull/99336
To make function calls inside lldb expressions ABI support, JIT engine support
are required. This patch augments corresponding functionality to RISCV ABI and
implements RISCV relocation resolver in JIT, which
https://github.com/luporl closed https://github.com/llvm/llvm-project/pull/99323
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Leandro Lupori
Date: 2024-07-17T11:45:49-03:00
New Revision: ec9d62fe84fe314370a256306c083a9e7079b80b
URL:
https://github.com/llvm/llvm-project/commit/ec9d62fe84fe314370a256306c083a9e7079b80b
DIFF:
https://github.com/DavidSpickett approved this pull request.
Disabling this for now is fine with me.
```
# shell parser error on RUN: at line 1:
c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe
--target=specify-a-target-or-use-a-_host-substitution
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Leandro Lupori (luporl)
Changes
verbose_trap.test, added in #80368, fails on some Windows bots.
See https://lab.llvm.org/buildbot/#/builders/141/builds/808.
---
Full diff: https://github.com/llvm/llvm-project/pull/99323.diff
1 Files
https://github.com/luporl created
https://github.com/llvm/llvm-project/pull/99323
verbose_trap.test, added in #80368, fails on some Windows bots.
See https://lab.llvm.org/buildbot/#/builders/141/builds/808.
>From f57dd945e6c2e4d4b3d5a97b2ed05418d91902ac Mon Sep 17 00:00:00 2001
From: Leandro
@@ -56,15 +57,12 @@ LLDB_BASE_DIR := $(THIS_FILE_DIR)/../../../../../
# inherited all the way down to the process spawned for make.
#--
ifeq "$(HOST_OS)" ""
- HOST_OS := $(shell uname -s)
-endif
-
-ifneq
@@ -296,11 +313,13 @@ endif
CFLAGS += $(CFLAGS_EXTRAS)
CXXFLAGS += -std=c++11 $(CFLAGS) $(ARCH_CXXFLAGS)
LD = $(CC)
-LDFLAGS ?= $(CFLAGS)
+# Copy common options to the linker flags (dwarf, arch. & etc).
+#Note: we get some 'garbage' options for linker here (such as -I,
https://github.com/labath commented:
It may be better to split this into smaller patches, given the fragility of
this code. (Basically, one patch for each of your bullet points).
Also, can you elaborate on this part?
> Paths are turned into POSIX-style since some tests and Unix utilities use
@@ -432,18 +468,18 @@ ifeq (1,$(USE_LIBCPP))
ifneq "$(LIBCPP_INCLUDE_TARGET_DIR)" ""
CXXFLAGS += -cxx-isystem
$(LIBCPP_INCLUDE_TARGET_DIR)
endif
- LDFLAGS += -L$(LIBCPP_LIBRARY_DIR)
@@ -296,11 +313,13 @@ endif
CFLAGS += $(CFLAGS_EXTRAS)
CXXFLAGS += -std=c++11 $(CFLAGS) $(ARCH_CXXFLAGS)
LD = $(CC)
-LDFLAGS ?= $(CFLAGS)
+# Copy common options to the linker flags (dwarf, arch. & etc).
+#Note: we get some 'garbage' options for linker here (such as -I,
@@ -80,9 +78,21 @@ endif
# Also reset BUILDDIR value because "pwd" returns cygwin or msys path
# which needs to be converted to windows path.
#--
-ifeq "$(OS)" "Windows_NT"
- SHELL =
@@ -418,11 +437,28 @@ ifeq (1, $(USE_SYSTEM_STDLIB))
endif
endif
+# No C++ library has been specifieed. Use libstdc++ by default.
+ifeq (,$(filter 1, $(USE_LIBSTDCPP) $(USE_LIBCPP) $(USE_SYSTEM_STDLIB)))
+ # If no explicit request was made, but we have paths to a
@@ -263,9 +280,9 @@ CFLAGS += $(NO_LIMIT_DEBUG_INFO_FLAGS) $(ARCH_CFLAGS)
# Use this one if you want to build one part of the result without debug
information:
ifeq "$(OS)" "Darwin"
- CFLAGS_NO_DEBUG = -O0 $(ARCHFLAG) $(ARCH) $(FRAMEWORK_INCLUDES)
$(ARCH_CFLAGS)
@@ -456,21 +492,15 @@ ifeq (1, $(USE_SYSTEM_STDLIB))
endif
CXXFLAGS += -nostdlib++ -nostdinc++ -cxx-isystem
$(SDKROOT)/usr/include/c++/v1
LDFLAGS += -L$(SDKROOT)/usr/lib -Wl,-rpath,$(SDKROOT)/usr/lib -lc++
+else
+ifneq (,$(findstring
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> So, this patch fixes that issue, right?
Yes I think so, give me some time to test it myself.
https://github.com/llvm/llvm-project/pull/98833
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
slydiman wrote:
> Agreed, so silent UB would just be making things worse.
So, this patch fixes that issue, right?
> Perhaps I am spelling the port option differently, or you mean a lldb-server
> gdbserver launched by a platform ignores the port.
It seems it depends on the system.
Note I'm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This is a preparatory step for teaching the function about anonymous
namespaces. It started out as a way to remove the assumption that the pattern
and target contexts must be of the same length -- that's will
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/99305
This is a preparatory step for teaching the function about anonymous
namespaces. It started out as a way to remove the assumption that the pattern
and target contexts must be of the same length -- that's will
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/97273
>From d812b8067d622b84af2ee62b837b87cb4479a477 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 17 Jul 2024 02:21:21 -0700
Subject: [PATCH] [lldb/Commands] Add `scripting template list` command
github-actions[bot] wrote:
@dlav-sc Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/99043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: dlav-sc
Date: 2024-07-17T09:36:19+01:00
New Revision: a751f653b40f2021f091a2f1ebcc2d91bc4cc89d
URL:
https://github.com/llvm/llvm-project/commit/a751f653b40f2021f091a2f1ebcc2d91bc4cc89d
DIFF:
https://github.com/llvm/llvm-project/commit/a751f653b40f2021f091a2f1ebcc2d91bc4cc89d.diff
LOG:
@@ -34,6 +34,8 @@ def check_first_register_readable(test_case):
test_case.expect("register read r0", substrs=["r0 = 0x"])
elif arch in ["powerpc64le"]:
test_case.expect("register read r0", substrs=["r0 = 0x"])
+elif arch in ["rv64gc"]:
@@ -34,6 +34,8 @@ def check_first_register_readable(test_case):
test_case.expect("register read r0", substrs=["r0 = 0x"])
elif arch in ["powerpc64le"]:
test_case.expect("register read r0", substrs=["r0 = 0x"])
+elif arch in ["rv64gc"]:
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/98845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/7] [lldb] progressive progress reporting for darwin
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
These changes aim to support cross-compilation build on Windows host for Linux
target for API tests execution. They're not final: changes will follow for
refactoring and adjustments to make all
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/99266
These changes aim to support cross-compilation build on Windows host for Linux
target for API tests execution. They're not final: changes will follow for
refactoring and adjustments to make all tests pass.
dlav-sc wrote:
> Agreed, this fix is correct, thanks for the PR. The register numbering in the
> UnwindPlan can be any eRegisterKind, but it does need to be self consistent,
> and this was not. Do you have permissions to merge this PR? I can do that for
> you if not.
Thanks for the review. I
@@ -633,171 +613,142 @@ StopInfoSP
StopInfoMachException::CreateStopReasonWithMachException(
}
break;
+ // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code]
+ //
+ // Instruction step:
+ // [6, 1, 0]
+ // Intel KDP [6, 3, ??]
+ // armv7 [6, 0x102, ]
@@ -633,171 +613,142 @@ StopInfoSP
StopInfoMachException::CreateStopReasonWithMachException(
}
break;
+ // [exc_type, exc_code, exc_sub_code, exc_sub_sub_code]
+ //
+ // Instruction step:
+ // [6, 1, 0]
+ // Intel KDP [6, 3, ??]
+ // armv7 [6, 0x102, ]
@@ -34,6 +34,8 @@ def check_first_register_readable(test_case):
test_case.expect("register read r0", substrs=["r0 = 0x"])
elif arch in ["powerpc64le"]:
test_case.expect("register read r0", substrs=["r0 = 0x"])
+elif arch in ["rv64gc"]:
@@ -2545,6 +2546,11 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec
_spec,
ModuleSP module_sp(new Module(file_spec, ArchSpec()));
if (module_sp) {
Status error;
+std::unique_ptr progress_up;
+if (!GetCoreFile())
jasonmolenda wrote:
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/98403
>From 4752adac6b8d39512bbfb46726205ceb2301d1c2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 9 Jul 2024 13:30:46 -0700
Subject: [PATCH 1/4] Create CoreDumpOption class, and SB equivalent
---
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/98845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/98845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2545,6 +2546,11 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec
_spec,
ModuleSP module_sp(new Module(file_spec, ArchSpec()));
if (module_sp) {
Status error;
+std::unique_ptr progress_up;
+if (!GetCoreFile())
clayborg wrote:
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/6] [lldb] progressive progress reporting for darwin
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff efde640cdfede834fa79e0eea69f82fb769d6beb
e3c60eea579d3948156ec5d16f0f429700e8112b
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/5] [lldb] progressive progress reporting for darwin
@@ -2545,6 +2546,11 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec
_spec,
ModuleSP module_sp(new Module(file_spec, ArchSpec()));
if (module_sp) {
Status error;
+std::unique_ptr progress_up;
+if (!GetCoreFile())
jasonmolenda wrote:
@@ -195,20 +196,40 @@ ModuleSP DynamicLoader::LoadBinaryWithUUIDAndAddress(
Target = process->GetTarget();
Status error;
+ StreamString prog_str;
+ if (!name.empty()) {
+prog_str << name.str() << " ";
+ }
+ if (uuid.IsValid())
+prog_str << uuid.GetAsString();
@@ -2545,6 +2546,11 @@ ModuleSP Process::ReadModuleFromMemory(const FileSpec
_spec,
ModuleSP module_sp(new Module(file_spec, ArchSpec()));
if (module_sp) {
Status error;
+std::unique_ptr progress_up;
+if (!GetCoreFile())
clayborg wrote:
Might
jasonmolenda wrote:
I don't think this change is correct, or I don't understand what it is trying
to do.
When we're connected to a stub that can allocate memory in the target, none of
this code is executed. So lldb-server/debugserver will not hit this.
We send `qMemoryRegionInfo` packets to
https://github.com/jasonmolenda approved this pull request.
Agreed, this fix is correct, thanks for the PR. The register numbering in the
UnwindPlan can be any eRegisterKind, but it does need to be self consistent,
and this was not. Do you have permissions to merge this PR? I can do that
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/98845
>From cead9ae6de627ee64fb58a829fa3485f526a0afc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Sun, 14 Jul 2024 16:59:51 -0700
Subject: [PATCH 1/4] [lldb] progressive progress reporting for darwin
@@ -191,9 +191,7 @@ class PluginManager {
GetObjectFileCreateMemoryCallbackForPluginName(llvm::StringRef name);
static Status SaveCore(const lldb::ProcessSP _sp,
- const FileSpec ,
- lldb::SaveCoreStyle _style,
-
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/98361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Zequan Wu
Date: 2024-07-16T16:22:31-04:00
New Revision: b7b77b0fe878d5620b042818cf527267521e51f5
URL:
https://github.com/llvm/llvm-project/commit/b7b77b0fe878d5620b042818cf527267521e51f5
DIFF:
https://github.com/llvm/llvm-project/commit/b7b77b0fe878d5620b042818cf527267521e51f5.diff
ZequanWu wrote:
This buildkite seems got stuck somehow, no logging at all:
https://buildkite.com/llvm-project/github-pull-requests/builds/81790#0190bca9-bde7-4fad-8478-9dffd4f669f7.
Will merge without waiting for it to finish.
https://github.com/llvm/llvm-project/pull/98361
https://github.com/clayborg commented:
LGTM
https://github.com/llvm/llvm-project/pull/99043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/99043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -643,9 +644,9 @@ bool
ABISysV_riscv::CreateFunctionEntryUnwindPlan(UnwindPlan _plan) {
unwind_plan.Clear();
unwind_plan.SetRegisterKind(eRegisterKindDWARF);
clayborg wrote:
Since we specify here that we are using DWARF registers, then the change below
@@ -1659,128 +1709,56 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext ,
default_accessibility = eAccessPrivate;
}
- if (attrs.byte_size && *attrs.byte_size == 0 && attrs.name &&
- !decl_die.HasChildren() && cu_language == eLanguageTypeObjC) {
-
@@ -1595,49 +1627,67 @@ DWARFASTParserClang::GetCPlusPlusQualifiedName(const
DWARFDIE ) {
if (qualified_name.empty())
qualified_name.append("::");
- qualified_name.append(name);
+ qualified_name.append(unique_typename.GetCString());
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/98361
>From 37b6878b9125c314c75053f7d5b0ba520111e9a3 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Tue, 9 Jul 2024 15:28:19 -0700
Subject: [PATCH 1/5] Reapply [lldb][DWARF] Delay struct/class/union definition
DIE
slydiman wrote:
The best solution is simply to remove all code related to gdb port mapping,
because it does not work at all. Try to run `netstat` and you will be surprised.
1. lldb-server in gdbserver mode completely ignores the port from the url
`tcp://[hostname]:port`. It binds to port 0
walter-erquinigo wrote:
@kevinfrei , I'm glad I can be of help to you! Let me know if you want me to
try out your next iteration of this PR on my device.
https://github.com/llvm/llvm-project/pull/98344
___
lldb-commits mailing list
kevinfrei wrote:
> @kevinfrei , I'm so sorry to tell you that I have reverted this patch. The
> revert commit is
> [27b2f4f](https://github.com/llvm/llvm-project/commit/27b2f4f861b8aeeabc4eb1a97649062de8fa3992)
> and I left some notes there, which I also copy here:
>
> The patch #98344
slydiman wrote:
> Did you consider making `AllowPort(0)` do nothing?
GetNextAvailablePort() returns 0 in case of the empty map. LaunchGDBServer()
does not update the map with the pid if the port is 0. So 0 is a special value
which means `any`. Adding 0 to a map causes an unexpected behavior.
@@ -34,6 +34,8 @@ def check_first_register_readable(test_case):
test_case.expect("register read r0", substrs=["r0 = 0x"])
elif arch in ["powerpc64le"]:
test_case.expect("register read r0", substrs=["r0 = 0x"])
+elif arch in ["rv64gc"]:
@@ -34,6 +34,8 @@ def check_first_register_readable(test_case):
test_case.expect("register read r0", substrs=["r0 = 0x"])
elif arch in ["powerpc64le"]:
test_case.expect("register read r0", substrs=["r0 = 0x"])
+elif arch in ["rv64gc"]:
DavidSpickett wrote:
The other ABI plugins use the dwarf indexes and I guess that has to be the case
because the unwind plan's type is dwarf. Adding @jasonmolenda just in case
there's anything more to it.
https://github.com/llvm/llvm-project/pull/99043
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/99043
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Is this something specific to risc-v or simply uncovered by testing against a
certain risc-v target? Just wondering why we haven't had to do this before now.
https://github.com/llvm/llvm-project/pull/99045
___
lldb-commits
https://github.com/labath commented:
I'm wondering if there's a more fundamental fix to be made here. Like perhaps
treating treating any allocatable SHT_NOBITS section as ZeroFill.
Basically to add `case SHT_NOBITS: if (H.sh_flags & SHF_ALLOC) return
eSectionTypeZeroFill;` to `GetSectionType`
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/98690
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vladislav Dzhidzhoev
Date: 2024-07-16T15:21:06+02:00
New Revision: 139df36d89bd731b5180be3cac2b58d4b2082368
URL:
https://github.com/llvm/llvm-project/commit/139df36d89bd731b5180be3cac2b58d4b2082368
DIFF:
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/99012
>From 242f78b67d6d6ef125b72c9c797fb2686cce280d Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 10 Jul 2024 15:37:45 +0100
Subject: [PATCH 1/3] [WIP][lldb][test] Add a new __compressed_pair layout to
Author: David Spickett
Date: 2024-07-16T13:08:04+01:00
New Revision: d4a89af5a8c52191797bed5ff7ff40a85435d3a0
URL:
https://github.com/llvm/llvm-project/commit/d4a89af5a8c52191797bed5ff7ff40a85435d3a0
DIFF:
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/99012
>From 242f78b67d6d6ef125b72c9c797fb2686cce280d Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 10 Jul 2024 15:37:45 +0100
Subject: [PATCH 1/2] [WIP][lldb][test] Add a new __compressed_pair layout to
@@ -1659,128 +1709,56 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext ,
default_accessibility = eAccessPrivate;
}
- if (attrs.byte_size && *attrs.byte_size == 0 && attrs.name &&
- !decl_die.HasChildren() && cu_language == eLanguageTypeObjC) {
-
@@ -1595,49 +1627,67 @@ DWARFASTParserClang::GetCPlusPlusQualifiedName(const
DWARFDIE ) {
if (qualified_name.empty())
qualified_name.append("::");
- qualified_name.append(name);
+ qualified_name.append(unique_typename.GetCString());
https://github.com/Michael137 approved this pull request.
I like where we ended up with this. LGTM (with two minor nits)
https://github.com/llvm/llvm-project/pull/98361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/98361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1301 - 1400 of 92360 matches
Mail list logo
