https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/114896
>From 38c7625fc7899f91190711818c144f27a39423c0 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Mon, 4 Nov 2024 15:56:26 -0800
Subject: [PATCH 1/2] Fix a thinko in the CallSite handling code:
I have to check f
@@ -9,21 +9,28 @@
#ifndef LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
#define LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
-#include "llvm/Support/JSON.h"
#include
+#include "llvm/Support/JSON.h"
+
+#include "DAPForward.h"
+
namespace lldb_dap {
struct BreakpointBase {
+ // Associat
@@ -12,15 +12,19 @@
namespace lldb_dap {
-SourceBreakpoint::SourceBreakpoint(const llvm::json::Object &obj)
-: Breakpoint(obj), logMessage(std::string(GetString(obj, "logMessage"))),
+SourceBreakpoint::SourceBreakpoint(DAP *dap, const llvm::json::Object &obj)
+: Break
https://github.com/vogelsgesang commented:
partial review
https://github.com/llvm/llvm-project/pull/114881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -9,21 +9,28 @@
#ifndef LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
#define LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
-#include "llvm/Support/JSON.h"
#include
+#include "llvm/Support/JSON.h"
+
+#include "DAPForward.h"
+
namespace lldb_dap {
struct BreakpointBase {
+ // Associat
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/114881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-11-04T13:32:22-08:00
New Revision: a57296ad411a75c1376458f6b09cb75128c6e785
URL:
https://github.com/llvm/llvm-project/commit/a57296ad411a75c1376458f6b09cb75128c6e785
DIFF:
https://github.com/llvm/llvm-project/commit/a57296ad411a75c1376458f6b09cb75128c6e785.d
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From c683d86ea988e76500ed12d1ac102fc1cc091823 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints
This c
Author: Jonas Devlieghere
Date: 2024-11-04T11:55:09-08:00
New Revision: 8f8e2b732635f03dc646a3c98db0b58a051745b8
URL:
https://github.com/llvm/llvm-project/commit/8f8e2b732635f03dc646a3c98db0b58a051745b8
DIFF:
https://github.com/llvm/llvm-project/commit/8f8e2b732635f03dc646a3c98db0b58a051745b8.d
@@ -0,0 +1,32 @@
+"""
+Test that disabling breakpoints and viewing them in a list uses the correct
ANSI color settings when colors are enabled and disabled.
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test impo
@@ -0,0 +1,32 @@
+"""
+Test that disabling breakpoints and viewing them in a list uses the correct
ANSI color settings when colors are enabled and disabled.
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test impo
slackito wrote:
Thanks for the quick response, Jim!
https://github.com/llvm/llvm-project/pull/114158
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
There were two issues here, one very minor, and then one that mattered... This
was a little thinko, I forgot that we build into the same SymbolContextList
over all the CU iterations, so I needed to check "did I add to the SC list" not
"is there anything in the SC list" to see
jimingham wrote:
Give me a bit to look at this. The intention of this patch was just to add
more locations, it shouldn't be reducing the number of breakpoints. There's
likely some simple goof here.
Jim
> On Nov 4, 2024, at 2:44 AM, Pavel Labath ***@***.***> wrote:
>
>
> So it sounds like
labath wrote:
Thanks for your understanding. Here's a revert PR
(https://github.com/llvm/llvm-project/pull/114831). I'll submit it after the CI
runs. Would you like to create an RFC thread to continue this discussion?
https://github.com/llvm/llvm-project/pull/113596
___
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This reverts commit 25909b811a7ddc983d042b15cb54ec271a673d63 due to unresolved
questions about the behavior of "frame var" and ValueObject in the presence of
references (see the original patch for discussion).
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/114831
This reverts commit 25909b811a7ddc983d042b15cb54ec271a673d63 due to unresolved
questions about the behavior of "frame var" and ValueObject in the presence of
references (see the original patch for discussion).
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/114807
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/114807
>From 12672234d81cc12625d8832fed4937221d37546e Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 4 Nov 2024 14:41:19 +
Subject: [PATCH 1/2] [lldb] Recommend Python 3.8 as the minimum Python vers
@@ -64,3 +64,10 @@ else()
Python3_EXECUTABLE
LLDB_ENABLE_SWIG)
endif()
+
+set(LLDB_RECOMMENDED_PYTHON "3.8")
+if(Python3_LIBRARIES AND Python3_INCLUDE_DIRS AND Python3_EXECUTABLE AND
LLDB_ENABLE_SWIG
-
@@ -64,3 +64,10 @@ else()
Python3_EXECUTABLE
LLDB_ENABLE_SWIG)
endif()
+
+set(LLDB_RECOMMENDED_PYTHON "3.8")
+if(Python3_LIBRARIES AND Python3_INCLUDE_DIRS AND Python3_EXECUTABLE AND
LLDB_ENABLE_SWIG
-
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
See
https://discourse.llvm.org/t/rfc-lets-document-and-enforce-a-minimum-python-version-for-lldb/82731
for discussions.
This matches LLVM's requirement to run tests. For LLDB 20 there will be a CMake
https://github.com/DavidSpickett ready_for_review
https://github.com/llvm/llvm-project/pull/114807
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/114807
See
https://discourse.llvm.org/t/rfc-lets-document-and-enforce-a-minimum-python-version-for-lldb/82731
for discussions.
This matches LLVM's requirement to run tests. For LLDB 20 there will be a CMake
wa
AaronBallman wrote:
> @AaronBallman you said this has happened before, but I don't see this in
> history. Can you link to the commit to which you're referring?
>
> I only see one other commit
> ([9783f28](https://github.com/llvm/llvm-project/commit/9783f28cbb155e4a8d49c12e1c60ce14dcfaf0c7))
>
@@ -362,6 +369,18 @@ void ManualDWARFIndex::IndexUnitImpl(DWARFUnit &unit,
set.namespaces.Insert(ConstString(name), ref);
break;
+case DW_TAG_member: {
+ // In DWARF 4 and earlier `static const` members of a struct, a class or
a
+ // union have an
Author: Michael Buch
Date: 2024-11-04T11:23:11Z
New Revision: eee8718e26b4ce8972abefc35d2beae96521075f
URL:
https://github.com/llvm/llvm-project/commit/eee8718e26b4ce8972abefc35d2beae96521075f
DIFF:
https://github.com/llvm/llvm-project/commit/eee8718e26b4ce8972abefc35d2beae96521075f.diff
LOG:
labath wrote:
So it sounds like the problem is that lldb no longer looks for all compile
units with the given name when setting a breakpoint. Changing that doesn't seem
like it was the intention of this patch. Jim, is there an easy fix for this or
should we revert the patch for now?
https://g
@@ -910,6 +911,183 @@ void request_attach(const llvm::json::Object &request) {
}
}
+// "BreakpointLocationsRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+// "description": "The `breakpointLocations` request returns all poss
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/113787
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -910,6 +911,183 @@ void request_attach(const llvm::json::Object &request) {
}
}
+// "BreakpointLocationsRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+// "description": "The `breakpointLocations` request returns all poss
https://github.com/DavidSpickett commented:
We only have one request for this feature, but the logic of it is clear and GDB
as an equivalent in `set cwd`:
https://sourceware.org/gdb/current/onlinedocs/gdb.html/Working-Directory.html
So this looks good to me once the docs are updated.
https://
@@ -201,6 +201,12 @@ let Definition = "target" in {
def DebugUtilityExpression: Property<"debug-utility-expression", "Boolean">,
DefaultFalse,
Desc<"Enable debugging of LLDB-internal utility expressions.">;
+ def LaunchWorkingDir: Property<"launch-working-dir", "Stri
@@ -691,7 +691,10 @@ let Command = "process launch" in {
def process_launch_plugin : Option<"plugin", "P">, Arg<"Plugin">,
Desc<"Name of the process plugin you want to use.">;
def process_launch_working_dir : Option<"working-dir", "w">,
Arg<"DirectoryName">,
-Desc<
@@ -201,6 +201,12 @@ let Definition = "target" in {
def DebugUtilityExpression: Property<"debug-utility-expression", "Boolean">,
DefaultFalse,
Desc<"Enable debugging of LLDB-internal utility expressions.">;
+ def LaunchWorkingDir: Property<"launch-working-dir", "Stri
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/113521
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
LGTM
https://github.com/llvm/llvm-project/pull/113508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -910,6 +911,183 @@ void request_attach(const llvm::json::Object &request) {
}
}
+// "BreakpointLocationsRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+// "description": "The `breakpointLocations` request returns all poss
https://github.com/kuilpd edited
https://github.com/llvm/llvm-project/pull/111859
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kuilpd edited
https://github.com/llvm/llvm-project/pull/111859
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/111859
>From 4c394ec162b58b3cde3af924a5e9be1de8250a07 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Tue, 30 Jul 2024 17:02:10 +0500
Subject: [PATCH 1/5] [lldb] Lookup static const members in FindGlobalVariables
Stat
labath wrote:
> Or just change the function we're calling from `at` to something that doesn't
> pull in the symbol from the dylib? That should still provide us with coverage
> of calling functions from the `std` module
That might work too (depending on how good we/clang are at not importing th
@@ -0,0 +1,32 @@
+"""
+Test that disabling breakpoints and viewing them in a list uses the correct
ANSI color settings when colors are enabled and disabled.
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test impo
@@ -0,0 +1,32 @@
+"""
+Test that disabling breakpoints and viewing them in a list uses the correct
ANSI color settings when colors are enabled and disabled.
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test impo
@@ -77,6 +78,15 @@ void SBStream::Printf(const char *format, ...) {
va_end(args);
}
+bool SBStream::HasColor() {
+ return m_opaque_up->AsRawOstream().colors_enabled();
+}
+
+void SBStream::FormatAnsiTerminalCodes(llvm::StringRef format) {
+ if (HasColor())
+Printf("%s"
@@ -362,6 +369,23 @@ void ManualDWARFIndex::IndexUnitImpl(DWARFUnit &unit,
set.namespaces.Insert(ConstString(name), ref);
break;
+case DW_TAG_member: {
+ // In DWARF 4 and earlier `static const` members of a struct, a class or
a
+ // union have an
@@ -362,6 +369,23 @@ void ManualDWARFIndex::IndexUnitImpl(DWARFUnit &unit,
set.namespaces.Insert(ConstString(name), ref);
break;
+case DW_TAG_member: {
+ // In DWARF 4 and earlier `static const` members of a struct, a class or
a
+ // union have an
@@ -3490,7 +3490,7 @@ VariableSP SymbolFileDWARF::ParseVariableDIE(const
SymbolContext &sc,
ModuleSP module = GetObjectFile()->GetModule();
if (tag != DW_TAG_variable && tag != DW_TAG_constant &&
- (tag != DW_TAG_formal_parameter || !sc.function))
+ tag != DW_TA
@@ -362,6 +369,23 @@ void ManualDWARFIndex::IndexUnitImpl(DWARFUnit &unit,
set.namespaces.Insert(ConstString(name), ref);
break;
+case DW_TAG_member: {
+ // In DWARF 4 and earlier `static const` members of a struct, a class or
a
+ // union have an
JDevlieghere wrote:
Seems like this might be causing GreenDragon to time out. Reverted to see if
that resolves the issue. I also had to revert #114507 as it depends on this.
https://github.com/llvm/llvm-project/pull/114576
___
lldb-commits mailing li
Author: Jonas Devlieghere
Date: 2024-11-03T12:34:47-08:00
New Revision: 4c8cc5a63b636c05f35cd8dab2c9e10686f40ea6
URL:
https://github.com/llvm/llvm-project/commit/4c8cc5a63b636c05f35cd8dab2c9e10686f40ea6
DIFF:
https://github.com/llvm/llvm-project/commit/4c8cc5a63b636c05f35cd8dab2c9e10686f40ea6.d
Author: Jonas Devlieghere
Date: 2024-11-03T12:34:52-08:00
New Revision: 74b56c7eb807e2ba54bd7a2bcfda5d0bceff1c0c
URL:
https://github.com/llvm/llvm-project/commit/74b56c7eb807e2ba54bd7a2bcfda5d0bceff1c0c
DIFF:
https://github.com/llvm/llvm-project/commit/74b56c7eb807e2ba54bd7a2bcfda5d0bceff1c0c.d
Author: Jonas Devlieghere
Date: 2024-11-02T09:38:10-07:00
New Revision: b360dfd5031e76c97257ef1b3e90385bf297e8ab
URL:
https://github.com/llvm/llvm-project/commit/b360dfd5031e76c97257ef1b3e90385bf297e8ab
DIFF:
https://github.com/llvm/llvm-project/commit/b360dfd5031e76c97257ef1b3e90385bf297e8ab.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114507
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vgvassilev wrote:
> The lldb change looks good (you can submit that in its own patch without a
> review), but you'll probably want to find a different reviewer for the
> codeview part (I have no idea who's responsible for that these days).
Thank you, maybe @adrian-prantl will know?
https://gi
@@ -1608,9 +1612,48 @@ void Target::SetExecutableModule(ModuleSP &executable_sp,
if (image_module_sp) {
added_modules.AppendIfNeeded(image_module_sp, false);
ObjectFile *objfile = image_module_sp->GetObjectFile();
- if (objfile)
-
Author: Jonas Devlieghere
Date: 2024-11-02T08:52:32-07:00
New Revision: 79178ca689a8259d19d93320a6299e3d31383ac4
URL:
https://github.com/llvm/llvm-project/commit/79178ca689a8259d19d93320a6299e3d31383ac4
DIFF:
https://github.com/llvm/llvm-project/commit/79178ca689a8259d19d93320a6299e3d31383ac4.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114610
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1608,9 +1612,28 @@ void Target::SetExecutableModule(ModuleSP &executable_sp,
if (image_module_sp) {
added_modules.AppendIfNeeded(image_module_sp, false);
ObjectFile *objfile = image_module_sp->GetObjectFile();
- if (objfile)
+ i
@@ -1608,9 +1612,28 @@ void Target::SetExecutableModule(ModuleSP &executable_sp,
if (image_module_sp) {
added_modules.AppendIfNeeded(image_module_sp, false);
ObjectFile *objfile = image_module_sp->GetObjectFile();
- if (objfile)
+ i
@@ -395,7 +394,44 @@ bool ThreadPlanStepRange::SetNextBranchBreakpoint() {
m_next_branch_bp_sp->GetID(), bp_site_id,
run_to_address.GetLoadAddress(&m_process.GetTarget()));
}
-
+// The "next branch breakpoint might land on
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/114628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/114333
>From c9a4d24f222a70c7c108deebb6c25222893d7159 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Wed, 24 Jan 2024 12:42:45 -0800
Subject: [PATCH 1/2] [lldb] Load embedded type summary section (#7859) (#8040)
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 80b9f07436617d650bdab7035394705f643d1b19
042ac07ed67a5465aaf5c2dc8c4396adf5da2948 --e
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
80b9f07436617d650bdab7035394705f643d1b19...042ac07ed67a5465aaf5c2dc8c4396adf5da2948
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
When you set a "next branch breakpoint" and run to it while stepping, you have
to claim the stop at that breakpoint to be the top of the inlined call stack,
or you will seem to "step in" and then plans might try to
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/114628
When you set a "next branch breakpoint" and run to it while stepping, you have
to claim the stop at that breakpoint to be the top of the inlined call stack,
or you will seem to "step in" and then plans might
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/114507
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114507
>From 9a269fa83cea529f704c9eba339eac9987032155 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 31 Oct 2024 21:42:38 -0700
Subject: [PATCH 1/3] [lldb] Create dependent modules in parallel
MIME-Ve
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/114576
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-11-01T16:38:14-07:00
New Revision: c8209943faeead43c6932c5ddcc69c9e9d1e4262
URL:
https://github.com/llvm/llvm-project/commit/c8209943faeead43c6932c5ddcc69c9e9d1e4262
DIFF:
https://github.com/llvm/llvm-project/commit/c8209943faeead43c6932c5ddcc69c9e9d1e4262.d
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/114576
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -48,7 +48,10 @@ PathMappingList::PathMappingList(const PathMappingList &rhs)
const PathMappingList &PathMappingList::operator=(const PathMappingList &rhs) {
if (this != &rhs) {
-std::scoped_lock
locks(m_mutex, rhs.m_mutex);
+std::scoped_lock pairs_locks(m_pairs_m
@@ -1608,9 +1612,48 @@ void Target::SetExecutableModule(ModuleSP &executable_sp,
if (image_module_sp) {
added_modules.AppendIfNeeded(image_module_sp, false);
ObjectFile *objfile = image_module_sp->GetObjectFile();
- if (objfile)
-
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114576
>From 9ebfdc84c46a795d35b4dd157573b97a57b232ce Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 1 Nov 2024 09:58:28 -0700
Subject: [PATCH 1/2] [lldb] Improve locking in PathMappingLists (NFC)
In
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/114610
>From ef1aaf94b52726c77e5569c84c09ecdd73811abd Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 1 Nov 2024 15:02:59 -0700
Subject: [PATCH] [lldb] Highlight "note:" in CommandReturnObject
We have
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/114608
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
// Add a hint if object description was requested, but no description
// function was implemented.
auto maybe_add_hint = [&](llvm::StringRef output) {
+static bool note_shown = false;
+
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
// Add a hint if object description was requested, but no description
// function was implemented.
auto maybe_add_hint = [&](llvm::StringRef output) {
+static bool note_shown = false;
+
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/114608
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
// Add a hint if object description was requested, but no description
// function was implemented.
auto maybe_add_hint = [&](llvm::StringRef output) {
+static bool note_shown = false;
+
https://github.com/adrian-prantl commented:
@kastiglione Is there a way to turn this into a test? Apparently this works:
```
(lldb) p ;
(lldb)
```
https://github.com/llvm/llvm-project/pull/114478
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
// Add a hint if object description was requested, but no description
// function was implemented.
auto maybe_add_hint = [&](llvm::StringRef output) {
+static bool note_shown = false;
+
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
// Add a hint if object description was requested, but no description
// function was implemented.
auto maybe_add_hint = [&](llvm::StringRef output) {
+static bool note_shown = false;
+
https://github.com/adrian-prantl approved this pull request.
I was going to say this is not the right way to do this, but I suppose there
isn't really a better mechanism available, since this isn't an error. Otherwise
you'd be better off joining a diagnostic error with the note so the UI layer
https://github.com/kastiglione approved this pull request.
https://github.com/llvm/llvm-project/pull/114610
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/114610
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -27,6 +27,12 @@ static llvm::raw_ostream &warning(Stream &strm) {
<< "warning: ";
}
+static llvm::raw_ostream ¬e(Stream &strm) {
augusto2112 wrote:
Since `note` is a function should it be capitalized to follow the LLDB style?
https://github.com/l
@@ -27,6 +27,12 @@ static llvm::raw_ostream &warning(Stream &strm) {
<< "warning: ";
}
+static llvm::raw_ostream ¬e(Stream &strm) {
augusto2112 wrote:
Actually `error` and `warning` are not capitalized, I guess we can either keep
all three lower cas
@@ -110,6 +110,11 @@ class CommandReturnObject {
void AppendMessageWithFormat(const char *format, ...)
__attribute__((format(printf, 2, 3)));
+ void AppendNote(llvm::StringRef in_string);
+
+ void AppendNoteWithFormat(const char *format, ...)
+ __attribute__((fo
slackito wrote:
Repro was pretty straightforward from the description above.
common.cc:
```c++
#include
#define XSTR(x) STR(x)
#define STR(x) #x
namespace NAMESPACE {
void DoSomeStuff() {
printf("%s::DoSomeStuff()\n", XSTR(NAMESPACE));
}
} // end NAMESPACE
```
main.cc:
```c++
namespace
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
// Add a hint if object description was requested, but no description
// function was implemented.
auto maybe_add_hint = [&](llvm::StringRef output) {
+static bool note_shown = false;
+
@@ -48,7 +48,10 @@ PathMappingList::PathMappingList(const PathMappingList &rhs)
const PathMappingList &PathMappingList::operator=(const PathMappingList &rhs) {
if (this != &rhs) {
-std::scoped_lock
locks(m_mutex, rhs.m_mutex);
+std::scoped_lock pairs_locks(m_pairs_m
https://github.com/bulbazord commented:
It took me some time to read this and think about the implications, but I think
this is generally okay. I left 1 comment about the order of lock acquisition
for `operator=`.
The only way I can see this going wrong is if a callback can mutate the list in
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/114576
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
We have helpers to emit warnings and errors. Do the same thing for notes to
they stand out more.
---
Full diff: https://github.com/llvm/llvm-project/pull/114610.diff
3 Files Affected:
- (modified
JDevlieghere wrote:
Motivated by #114608
https://github.com/llvm/llvm-project/pull/114610
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/114610
We have helpers to emit warnings and errors. Do the same thing for notes to
they stand out more.
>From 155396aa89fd418268cfcf8d054849c67bf1207e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri,
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/113521
>From 819380f93381eff8200c7eb9c55372f9a840c379 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 24 Oct 2024 00:17:48 -0400
Subject: [PATCH] [LLDB] Add a target.launch-working-dir setting
Inte
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/114608
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
701 - 800 of 38634 matches
Mail list logo
