[jira] [Resolved] (SLING-12164) Metadata Extraction Broken
[ https://issues.apache.org/jira/browse/SLING-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12164. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/6eb6abb410baebe1fd9e1efecde6c03d3fea1554 > Metadata Extraction Broken > -- > > Key: SLING-12164 > URL: https://issues.apache.org/jira/browse/SLING-12164 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 1.1.8 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.1.10 > > > SLING-12120 introduced a regression where the metadata extraction broke due > to both the tika-parsers and tika-bundle being present in the feature model. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12164) Metadata Extraction Broken
Dan Klco created SLING-12164: Summary: Metadata Extraction Broken Key: SLING-12164 URL: https://issues.apache.org/jira/browse/SLING-12164 Project: Sling Issue Type: Bug Components: App CMS Affects Versions: App CMS 1.1.8 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 1.1.10 SLING-12120 introduced a regression where the metadata extraction broke due to both the tika-parsers and tika-bundle being present in the feature model. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12155) Regression: Maintenance Config Missing
[ https://issues.apache.org/jira/browse/SLING-12155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12155. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/27c3dc1a47ee53bf6bec3506539fc70ab4b8ff76 > Regression: Maintenance Config Missing > -- > > Key: SLING-12155 > URL: https://issues.apache.org/jira/browse/SLING-12155 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 1.1.8 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: App CMS 1.1.10 > > > SLING-12120 introduced a regression where the maintenance configuration is no > longer provided with the Sling CMS features. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12155) Regression: Maintenance Config Missing
Dan Klco created SLING-12155: Summary: Regression: Maintenance Config Missing Key: SLING-12155 URL: https://issues.apache.org/jira/browse/SLING-12155 Project: Sling Issue Type: Bug Components: App CMS Affects Versions: App CMS 1.1.8 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 1.1.10 SLING-12120 introduced a regression where the maintenance configuration is no longer provided with the Sling CMS features. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12156) Regression: Composite Features Missing oak-segment-tar
[ https://issues.apache.org/jira/browse/SLING-12156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786393#comment-17786393 ] Dan Klco commented on SLING-12156: -- Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/eec5aa93de0b3ebd6ef018d9a3f8bbebf9233c5e > Regression: Composite Features Missing oak-segment-tar > -- > > Key: SLING-12156 > URL: https://issues.apache.org/jira/browse/SLING-12156 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 1.1.8 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: App CMS 1.1.10 > > > SLING-12120 introduced a regression where the composite-runtime and > composite-seed features no longer include oak-segment-tar -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12156) Regression: Composite Features Missing oak-segment-tar
[ https://issues.apache.org/jira/browse/SLING-12156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12156. -- Resolution: Fixed > Regression: Composite Features Missing oak-segment-tar > -- > > Key: SLING-12156 > URL: https://issues.apache.org/jira/browse/SLING-12156 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 1.1.8 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: App CMS 1.1.10 > > > SLING-12120 introduced a regression where the composite-runtime and > composite-seed features no longer include oak-segment-tar -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12156) Regression: Composite Features Missing oak-segment-tar
Dan Klco created SLING-12156: Summary: Regression: Composite Features Missing oak-segment-tar Key: SLING-12156 URL: https://issues.apache.org/jira/browse/SLING-12156 Project: Sling Issue Type: Bug Components: App CMS Affects Versions: App CMS 1.1.8 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 1.1.10 SLING-12120 introduced a regression where the composite-runtime and composite-seed features no longer include oak-segment-tar -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12138) Node Browser page keeps popping up login window
[ https://issues.apache.org/jira/browse/SLING-12138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12138. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/81f795a8ee42a2e55a3dff283391c208ea986597 > Node Browser page keeps popping up login window > --- > > Key: SLING-12138 > URL: https://issues.apache.org/jira/browse/SLING-12138 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 1.1.8 >Reporter: James Raynor >Assignee: Dan Klco >Priority: Minor > Attachments: 2023-11-10--15-15-59.jpg > > > When I open the Nobe Browser page, there is a login popup, and I can't stop > it from popping up. > You can only click cancel to skip it. > [http://localhost:8080/bin/browser.html] > This was normal in previous versions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12138) Node Browser page keeps popping up login window
[ https://issues.apache.org/jira/browse/SLING-12138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-12138: Assignee: Dan Klco > Node Browser page keeps popping up login window > --- > > Key: SLING-12138 > URL: https://issues.apache.org/jira/browse/SLING-12138 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 1.1.8 >Reporter: James Raynor >Assignee: Dan Klco >Priority: Minor > Attachments: 2023-11-10--15-15-59.jpg > > > When I open the Nobe Browser page, there is a login popup, and I can't stop > it from popping up. > You can only click cancel to skip it. > [http://localhost:8080/bin/browser.html] > This was normal in previous versions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12154) 404 on Composum Nodes Health Check
[ https://issues.apache.org/jira/browse/SLING-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12154. -- Resolution: Fixed > 404 on Composum Nodes Health Check > -- > > Key: SLING-12154 > URL: https://issues.apache.org/jira/browse/SLING-12154 > Project: Sling > Issue Type: Bug > Components: Starter >Affects Versions: Starter 12 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Starter 13 > > Attachments: image-2023-11-15-00-05-08-595.png > > > Composum Nodes in the Sling Starter logs a 404 response and is unable to load > the System Health due to the Composum Generic Request Proxy not being > configured: > !image-2023-11-15-00-05-08-595.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12154) 404 on Composum Nodes Health Check
[ https://issues.apache.org/jira/browse/SLING-12154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786171#comment-17786171 ] Dan Klco commented on SLING-12154: -- Pull request with a fix: https://github.com/apache/sling-org-apache-sling-starter/pull/275 > 404 on Composum Nodes Health Check > -- > > Key: SLING-12154 > URL: https://issues.apache.org/jira/browse/SLING-12154 > Project: Sling > Issue Type: Bug > Components: Starter >Affects Versions: Starter 12 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Starter 13 > > Attachments: image-2023-11-15-00-05-08-595.png > > > Composum Nodes in the Sling Starter logs a 404 response and is unable to load > the System Health due to the Composum Generic Request Proxy not being > configured: > !image-2023-11-15-00-05-08-595.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12154) 404 on Composum Nodes Health Check
Dan Klco created SLING-12154: Summary: 404 on Composum Nodes Health Check Key: SLING-12154 URL: https://issues.apache.org/jira/browse/SLING-12154 Project: Sling Issue Type: Bug Components: Starter Affects Versions: Starter 12 Reporter: Dan Klco Assignee: Dan Klco Fix For: Starter 13 Attachments: image-2023-11-15-00-05-08-595.png Composum Nodes in the Sling Starter logs a 404 response and is unable to load the System Health due to the Composum Generic Request Proxy not being configured: !image-2023-11-15-00-05-08-595.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12148) Committer CLI Fails to Parse CI Status
[
https://issues.apache.org/jira/browse/SLING-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco resolved SLING-12148.
--
Assignee: Dan Klco
Resolution: Fixed
> Committer CLI Fails to Parse CI Status
> --
>
> Key: SLING-12148
> URL: https://issues.apache.org/jira/browse/SLING-12148
> Project: Sling
> Issue Type: Bug
> Components: CI
>Affects Versions: Committer CLI 1.0.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
>
> The committer CLI has been failing to verify releases with:
> {{java.lang.NullPointerException: Cannot invoke
> "com.google.gson.JsonElement.getAsString()" because the return value of
> "com.google.gson.JsonObject.get(String)" is null
> at
> org.apache.sling.cli.impl.ci.CIStatusValidator.isValid(CIStatusValidator.java:145)
> at
> org.apache.sling.cli.impl.release.VerifyReleasesCommand.call(VerifyReleasesCommand.java:123)
> at
> org.apache.sling.cli.impl.release.VerifyReleasesCommand.call(VerifyReleasesCommand.java:42)
> at picocli.CommandLine.executeUserObject(CommandLine.java:1701)
> at picocli.CommandLine.access$900(CommandLine.java:146)
> at picocli.CommandLine$RunLast.handle(CommandLine.java:2059)
> at picocli.CommandLine$RunLast.handle(CommandLine.java:2026)
> at
> picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:1893)
> at picocli.CommandLine.execute(CommandLine.java:1822)
> at
> org.apache.sling.cli.impl.CommandProcessor.runCommand(CommandProcessor.java:110)
> at
> org.apache.sling.cli.impl.ExecutionTrigger.lambda$activate$0(ExecutionTrigger.java:33)
> at java.base/java.lang.Thread.run(Unknown Source)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12148) Committer CLI Fails to Parse CI Status
[
https://issues.apache.org/jira/browse/SLING-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785535#comment-17785535
]
Dan Klco commented on SLING-12148:
--
Looks like the issue is due to a .git suffix when it extracts GitHub urls from
the poms:
https://github.com/apache/sling-org-apache-sling-committer-cli/pull/26
> Committer CLI Fails to Parse CI Status
> --
>
> Key: SLING-12148
> URL: https://issues.apache.org/jira/browse/SLING-12148
> Project: Sling
> Issue Type: Bug
> Components: CI
>Affects Versions: Committer CLI 1.0.0
>Reporter: Dan Klco
>Priority: Major
>
> The committer CLI has been failing to verify releases with:
> {{java.lang.NullPointerException: Cannot invoke
> "com.google.gson.JsonElement.getAsString()" because the return value of
> "com.google.gson.JsonObject.get(String)" is null
> at
> org.apache.sling.cli.impl.ci.CIStatusValidator.isValid(CIStatusValidator.java:145)
> at
> org.apache.sling.cli.impl.release.VerifyReleasesCommand.call(VerifyReleasesCommand.java:123)
> at
> org.apache.sling.cli.impl.release.VerifyReleasesCommand.call(VerifyReleasesCommand.java:42)
> at picocli.CommandLine.executeUserObject(CommandLine.java:1701)
> at picocli.CommandLine.access$900(CommandLine.java:146)
> at picocli.CommandLine$RunLast.handle(CommandLine.java:2059)
> at picocli.CommandLine$RunLast.handle(CommandLine.java:2026)
> at
> picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:1893)
> at picocli.CommandLine.execute(CommandLine.java:1822)
> at
> org.apache.sling.cli.impl.CommandProcessor.runCommand(CommandProcessor.java:110)
> at
> org.apache.sling.cli.impl.ExecutionTrigger.lambda$activate$0(ExecutionTrigger.java:33)
> at java.base/java.lang.Thread.run(Unknown Source)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12148) Committer CLI Fails to Parse CI Status
Dan Klco created SLING-12148:
Summary: Committer CLI Fails to Parse CI Status
Key: SLING-12148
URL: https://issues.apache.org/jira/browse/SLING-12148
Project: Sling
Issue Type: Bug
Components: CI
Affects Versions: Committer CLI 1.0.0
Reporter: Dan Klco
The committer CLI has been failing to verify releases with:
{{java.lang.NullPointerException: Cannot invoke
"com.google.gson.JsonElement.getAsString()" because the return value of
"com.google.gson.JsonObject.get(String)" is null
at
org.apache.sling.cli.impl.ci.CIStatusValidator.isValid(CIStatusValidator.java:145)
at
org.apache.sling.cli.impl.release.VerifyReleasesCommand.call(VerifyReleasesCommand.java:123)
at
org.apache.sling.cli.impl.release.VerifyReleasesCommand.call(VerifyReleasesCommand.java:42)
at picocli.CommandLine.executeUserObject(CommandLine.java:1701)
at picocli.CommandLine.access$900(CommandLine.java:146)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2059)
at picocli.CommandLine$RunLast.handle(CommandLine.java:2026)
at
picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:1893)
at picocli.CommandLine.execute(CommandLine.java:1822)
at
org.apache.sling.cli.impl.CommandProcessor.runCommand(CommandProcessor.java:110)
at
org.apache.sling.cli.impl.ExecutionTrigger.lambda$activate$0(ExecutionTrigger.java:33)
at java.base/java.lang.Thread.run(Unknown Source)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12012) CMS - Add Recent Drafts List
[ https://issues.apache.org/jira/browse/SLING-12012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-12012. > CMS - Add Recent Drafts List > > > Key: SLING-12012 > URL: https://issues.apache.org/jira/browse/SLING-12012 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Trivial > Fix For: App CMS 1.1.8 > > > It would be helpful to have a list of unpublished or "draft" pages make it > quicker and easier to find pages which are not yet published -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12119) Remove Dependency on Guava from CMS
[ https://issues.apache.org/jira/browse/SLING-12119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-12119. > Remove Dependency on Guava from CMS > --- > > Key: SLING-12119 > URL: https://issues.apache.org/jira/browse/SLING-12119 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.1.8 > > > Currently, the CMS app depends on Guava for tests and transitively via > thumbnails. This isn't ideal as Guava's major version changes are challenging > in OSGi and Oak is removing the dependency on Guava. > Therefore the app should be refactored to remove the dependency on Guava. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12120) Align Feature Structure with Starter
[ https://issues.apache.org/jira/browse/SLING-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-12120. > Align Feature Structure with Starter > > > Key: SLING-12120 > URL: https://issues.apache.org/jira/browse/SLING-12120 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.1.8 > > > There's a significant delta between the configuration of the CMS app and the > Sling Starter. Now that the Sling Starter is receiving regular updates, it'd > be beneficial to align the feature structure in the CMS App with the starter > to enable easy syncing of updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12011) CMS - Use LazyBindings
[ https://issues.apache.org/jira/browse/SLING-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-12011. > CMS - Use LazyBindings > -- > > Key: SLING-12011 > URL: https://issues.apache.org/jira/browse/SLING-12011 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: App CMS 1.1.8 > > Attachments: image-2023-08-26-09-40-00-139.png, > image-2023-08-26-09-42-52-390.png > > > While analyzing the Recent Requests for Sling CMS I noticed that it spends a > significant amount of time in the DefaultScriptBindingsValueProvider because > it's binding all of properties, even if they are not used. > !image-2023-08-26-09-40-00-139.png|thumbnail! > By using the LazyBindings and and the LazyBindings.Supplier we can avoid > binding unneeded properties. For a simple page like the attached one, this > reduces the request duration nearly in half. > !image-2023-08-26-09-42-52-390.png|thumbnail! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11810) CMS - Reference Component Escaping Issues
[ https://issues.apache.org/jira/browse/SLING-11810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11810. > CMS - Reference Component Escaping Issues > - > > Key: SLING-11810 > URL: https://issues.apache.org/jira/browse/SLING-11810 > Project: Sling > Issue Type: Improvement > Components: App CMS Reference >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: App CMS 1.1.8 > > > There's a few issues with the reference components following the XSS fixes: > - textfield - label name not set correctly > - column control - row classes not set -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11853) CMS - Editor Submit Buttons Sporadically Un-selectable in Mobile
[ https://issues.apache.org/jira/browse/SLING-11853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11853. > CMS - Editor Submit Buttons Sporadically Un-selectable in Mobile > > > Key: SLING-11853 > URL: https://issues.apache.org/jira/browse/SLING-11853 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: App CMS 1.1.8 > > > When editing components on a mobile breakpoint the buttons to submit the form > occasionally are positioned outside of the viewport and due to overflow: > hidden CSS rules are not visible and thus cannot be clicked to submit the > form. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12121) Repository Path Substitution Incorrect
[ https://issues.apache.org/jira/browse/SLING-12121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-12121. > Repository Path Substitution Incorrect > -- > > Key: SLING-12121 > URL: https://issues.apache.org/jira/browse/SLING-12121 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.1.8 > > > The features for the Oak repository configuration in the CMS app don't > declare the sling.home variable and thus aren't properly substituted at > runtime. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11808) Cannot run SlingCMS 1.1.2+ on Windows
[ https://issues.apache.org/jira/browse/SLING-11808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11808. > Cannot run SlingCMS 1.1.2+ on Windows > - > > Key: SLING-11808 > URL: https://issues.apache.org/jira/browse/SLING-11808 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 1.1.2 >Reporter: James Raynor >Priority: Major > Fix For: App CMS 1.1.8 > > Attachments: 2023-03-17--15-55-28.jpg > > > Hi, I haven't used SlingCMS for a long time. > I downloaded the latest version today and tried it out, but I can't run the > program. > It shows: > Artifact > jar:file:/C:/Test/SlingCMS/org.apache.sling.cms.feature-1.1.2.jar!/lib/slingcms.far > not found. > OS Windows 10, Java 8, SlingCMS 1.1.0 works fine, expect subsequent versions > to fix this problem. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12120) Align Feature Structure with Starter
[ https://issues.apache.org/jira/browse/SLING-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779541#comment-17779541 ] Dan Klco commented on SLING-12120: -- That's a really good question [~rombert]. For the moment, I was planning on syncing the directories manually. We could consider a "sling base" type feature aggregate which contains the common configurations and dependencies for a generic sling application. The problem is that with the [ASF release process|https://www.apache.org/legal/release-policy.html#release-approval], we'd either have to go through a full release vote for this _very_ frequently or accept that the base will only be updated when we decide to do a major Sling release. Another option would be to designate certain features / directories as "base" features which would make synchronizing these features easier or potentially even automated by just copying the relevant directories. > Align Feature Structure with Starter > > > Key: SLING-12120 > URL: https://issues.apache.org/jira/browse/SLING-12120 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.1.8 > > > There's a significant delta between the configuration of the CMS app and the > Sling Starter. Now that the Sling Starter is receiving regular updates, it'd > be beneficial to align the feature structure in the CMS App with the starter > to enable easy syncing of updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12119) Remove Dependency on Guava from CMS
[ https://issues.apache.org/jira/browse/SLING-12119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12119. -- Resolution: Fixed > Remove Dependency on Guava from CMS > --- > > Key: SLING-12119 > URL: https://issues.apache.org/jira/browse/SLING-12119 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.1.8 > > > Currently, the CMS app depends on Guava for tests and transitively via > thumbnails. This isn't ideal as Guava's major version changes are challenging > in OSGi and Oak is removing the dependency on Guava. > Therefore the app should be refactored to remove the dependency on Guava. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12120) Align Feature Structure with Starter
[ https://issues.apache.org/jira/browse/SLING-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12120. -- Resolution: Fixed Fixed in [https://github.com/apache/sling-org-apache-sling-app-cms/commit/923da0fe65368f3d2d0f0030bfe3ae0abb4e0e8e] > Align Feature Structure with Starter > > > Key: SLING-12120 > URL: https://issues.apache.org/jira/browse/SLING-12120 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.1.8 > > > There's a significant delta between the configuration of the CMS app and the > Sling Starter. Now that the Sling Starter is receiving regular updates, it'd > be beneficial to align the feature structure in the CMS App with the starter > to enable easy syncing of updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12121) Repository Path Substitution Incorrect
[ https://issues.apache.org/jira/browse/SLING-12121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12121. -- Resolution: Fixed Fixed in [https://github.com/apache/sling-org-apache-sling-app-cms/commit/ce011e569a703c13ba243726406a18c1ca009057] > Repository Path Substitution Incorrect > -- > > Key: SLING-12121 > URL: https://issues.apache.org/jira/browse/SLING-12121 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.1.8 > > > The features for the Oak repository configuration in the CMS app don't > declare the sling.home variable and thus aren't properly substituted at > runtime. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12121) Repository Path Substitution Incorrect
Dan Klco created SLING-12121: Summary: Repository Path Substitution Incorrect Key: SLING-12121 URL: https://issues.apache.org/jira/browse/SLING-12121 Project: Sling Issue Type: Bug Components: App CMS Affects Versions: App CMS 1.1.6 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 1.1.8 The features for the Oak repository configuration in the CMS app don't declare the sling.home variable and thus aren't properly substituted at runtime. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12120) Align Feature Structure with Starter
Dan Klco created SLING-12120: Summary: Align Feature Structure with Starter Key: SLING-12120 URL: https://issues.apache.org/jira/browse/SLING-12120 Project: Sling Issue Type: Improvement Components: App CMS Affects Versions: App CMS 1.1.6 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 1.1.8 There's a significant delta between the configuration of the CMS app and the Sling Starter. Now that the Sling Starter is receiving regular updates, it'd be beneficial to align the feature structure in the CMS App with the starter to enable easy syncing of updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12119) Remove Dependency on Guava from CMS
[ https://issues.apache.org/jira/browse/SLING-12119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779171#comment-17779171 ] Dan Klco commented on SLING-12119: -- Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/09101a0207d988a54af311e631b2b78be6166b10 > Remove Dependency on Guava from CMS > --- > > Key: SLING-12119 > URL: https://issues.apache.org/jira/browse/SLING-12119 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 1.1.8 > > > Currently, the CMS app depends on Guava for tests and transitively via > thumbnails. This isn't ideal as Guava's major version changes are challenging > in OSGi and Oak is removing the dependency on Guava. > Therefore the app should be refactored to remove the dependency on Guava. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12119) Remove Dependency on Guava from CMS
Dan Klco created SLING-12119: Summary: Remove Dependency on Guava from CMS Key: SLING-12119 URL: https://issues.apache.org/jira/browse/SLING-12119 Project: Sling Issue Type: Improvement Components: App CMS Affects Versions: App CMS 1.1.6 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 1.1.8 Currently, the CMS app depends on Guava for tests and transitively via thumbnails. This isn't ideal as Guava's major version changes are challenging in OSGi and Oak is removing the dependency on Guava. Therefore the app should be refactored to remove the dependency on Guava. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12117) startupandshutdown ServiceUnavailableFilter References Starter Content
[ https://issues.apache.org/jira/browse/SLING-12117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12117. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-starter/commit/d2db7995c355ec29fbb9a10b81151e00bc273b68 > startupandshutdown ServiceUnavailableFilter References Starter Content > -- > > Key: SLING-12117 > URL: https://issues.apache.org/jira/browse/SLING-12117 > Project: Sling > Issue Type: Bug > Components: Starter >Affects Versions: Starter 12 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Starter 13 > > > The configuration > _org.apache.felix.hc.core.impl.filter.ServiceUnavailableFilter~startupandshutdown_ > found in _src/main/features/healthcheck.json_ references the starter content > in it's _responseTestFor503_ property which will cause the model to fail to > build if the starter content is not included in the aggregated feature model. > > To keep the Starter Content-related features together, I suggest moving this > configuration to _src/main/features/app/starter.json_ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12111) Thumbnails: Upgrade Thumbnailator Dependency
[ https://issues.apache.org/jira/browse/SLING-12111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-12111. > Thumbnails: Upgrade Thumbnailator Dependency > > > Key: SLING-12111 > URL: https://issues.apache.org/jira/browse/SLING-12111 > Project: Sling > Issue Type: Improvement > Components: Thumbnails >Affects Versions: Thumbnails 1.0.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Thumbnails 1.0.2 > > > update to latest v0.4.20: > https://github.com/coobird/thumbnailator/releases/tag/0.4.20 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12110) Thumbnails: Upgrade to parent/bundle-parent 52
[ https://issues.apache.org/jira/browse/SLING-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-12110. > Thumbnails: Upgrade to parent/bundle-parent 52 > -- > > Key: SLING-12110 > URL: https://issues.apache.org/jira/browse/SLING-12110 > Project: Sling > Issue Type: Improvement > Components: Thumbnails >Affects Versions: Thumbnails 1.0.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Thumbnails 1.0.2 > > > update to latest parent/bundle-parent -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12109) Remove Dependency on Guava from Thumbnails
[ https://issues.apache.org/jira/browse/SLING-12109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-12109. > Remove Dependency on Guava from Thumbnails > -- > > Key: SLING-12109 > URL: https://issues.apache.org/jira/browse/SLING-12109 > Project: Sling > Issue Type: Improvement > Components: Thumbnails >Affects Versions: Thumbnails 1.0.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Thumbnails 1.0.2 > > > Currently, the Thumbnails library depends on Guava for mime type evaluation, > some utilities and caching. This isn't ideal as Guava's major version changes > are challenging in OSGi and Oak is removing their dependency on Guava. > Therefore the library should be refactored to remove the dependency on Guava. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12079) Update Commons Mime to Bundle Parent 52
[ https://issues.apache.org/jira/browse/SLING-12079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-12079. > Update Commons Mime to Bundle Parent 52 > --- > > Key: SLING-12079 > URL: https://issues.apache.org/jira/browse/SLING-12079 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons MIME 2.2.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Commons MIME 2.2.4 > > > Commons Mime currently uses Bundle Parent v35 which is not compatible with > Java 17. We should update it to the latest parent version to support Java 17 > builds. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11652) Update Core Mime Types
[ https://issues.apache.org/jira/browse/SLING-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11652. > Update Core Mime Types > -- > > Key: SLING-11652 > URL: https://issues.apache.org/jira/browse/SLING-11652 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons MIME 2.2.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Commons MIME 2.2.4 > > Time Spent: 20m > Remaining Estimate: 0h > > Commons MIME has a core mime types file derived from httpd v2.4.10 which was > released in 2014. > We should update to the latest mime types file from v2.4.54 which contains > ~300 additional mime types not contained in v2.4.10 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12117) startupandshutdown ServiceUnavailableFilter References Starter Content
Dan Klco created SLING-12117: Summary: startupandshutdown ServiceUnavailableFilter References Starter Content Key: SLING-12117 URL: https://issues.apache.org/jira/browse/SLING-12117 Project: Sling Issue Type: Bug Components: Starter Affects Versions: Starter 12 Reporter: Dan Klco Assignee: Dan Klco Fix For: Starter 13 The configuration _org.apache.felix.hc.core.impl.filter.ServiceUnavailableFilter~startupandshutdown_ found in _src/main/features/healthcheck.json_ references the starter content in it's _responseTestFor503_ property which will cause the model to fail to build if the starter content is not included in the aggregated feature model. To keep the Starter Content-related features together, I suggest moving this configuration to _src/main/features/app/starter.json_ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12110) Thumbnails: Upgrade to parent/bundle-parent 52
[ https://issues.apache.org/jira/browse/SLING-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-12110: Assignee: Dan Klco > Thumbnails: Upgrade to parent/bundle-parent 52 > -- > > Key: SLING-12110 > URL: https://issues.apache.org/jira/browse/SLING-12110 > Project: Sling > Issue Type: Improvement > Components: Thumbnails >Affects Versions: Thumbnails 1.0.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Thumbnails 1.0.2 > > > update to latest parent/bundle-parent -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12111) Thumbnails: Upgrade Thumbnailator Dependency
[ https://issues.apache.org/jira/browse/SLING-12111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12111. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-thumbnails/commit/22d039693e4c4662dc3841b28bf745b6d1a233ea > Thumbnails: Upgrade Thumbnailator Dependency > > > Key: SLING-12111 > URL: https://issues.apache.org/jira/browse/SLING-12111 > Project: Sling > Issue Type: Improvement > Components: Thumbnails >Affects Versions: Thumbnails 1.0.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Thumbnails 1.0.2 > > > update to latest v0.4.20: > https://github.com/coobird/thumbnailator/releases/tag/0.4.20 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12110) Thumbnails: Upgrade to parent/bundle-parent 52
[ https://issues.apache.org/jira/browse/SLING-12110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12110. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-thumbnails/commit/d2799581d1be0ea3ef52716db1d7fef0198d2a98 > Thumbnails: Upgrade to parent/bundle-parent 52 > -- > > Key: SLING-12110 > URL: https://issues.apache.org/jira/browse/SLING-12110 > Project: Sling > Issue Type: Improvement > Components: Thumbnails >Affects Versions: Thumbnails 1.0.0 >Reporter: Dan Klco >Priority: Minor > Fix For: Thumbnails 1.0.2 > > > update to latest parent/bundle-parent -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12109) Remove Dependency on Guava from Thumbnails
[ https://issues.apache.org/jira/browse/SLING-12109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12109. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-thumbnails/commit/d317b42d648344fce524675baaf8776f7a13881c > Remove Dependency on Guava from Thumbnails > -- > > Key: SLING-12109 > URL: https://issues.apache.org/jira/browse/SLING-12109 > Project: Sling > Issue Type: Improvement > Components: Thumbnails >Affects Versions: Thumbnails 1.0.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Thumbnails 1.0.2 > > > Currently, the Thumbnails library depends on Guava for mime type evaluation, > some utilities and caching. This isn't ideal as Guava's major version changes > are challenging in OSGi and Oak is removing their dependency on Guava. > Therefore the library should be refactored to remove the dependency on Guava. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12111) Thumbnails: Upgrade Thumbnailator Dependency
[ https://issues.apache.org/jira/browse/SLING-12111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-12111: Assignee: Dan Klco > Thumbnails: Upgrade Thumbnailator Dependency > > > Key: SLING-12111 > URL: https://issues.apache.org/jira/browse/SLING-12111 > Project: Sling > Issue Type: Improvement > Components: Thumbnails >Affects Versions: Thumbnails 1.0.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Thumbnails 1.0.2 > > > update to latest v0.4.20: > https://github.com/coobird/thumbnailator/releases/tag/0.4.20 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12111) Thumbnails: Upgrade Thumbnailator Dependency
[ https://issues.apache.org/jira/browse/SLING-12111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-12111: - Description: update to latest v0.4.20: https://github.com/coobird/thumbnailator/releases/tag/0.4.20 (was: update to latest parent/bundle-parent) > Thumbnails: Upgrade Thumbnailator Dependency > > > Key: SLING-12111 > URL: https://issues.apache.org/jira/browse/SLING-12111 > Project: Sling > Issue Type: Improvement > Components: Thumbnails >Affects Versions: Thumbnails 1.0.0 >Reporter: Dan Klco >Priority: Minor > Fix For: Thumbnails 1.0.2 > > > update to latest v0.4.20: > https://github.com/coobird/thumbnailator/releases/tag/0.4.20 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12111) Thumbnails: Upgrade Thumbnailator Dependency
Dan Klco created SLING-12111: Summary: Thumbnails: Upgrade Thumbnailator Dependency Key: SLING-12111 URL: https://issues.apache.org/jira/browse/SLING-12111 Project: Sling Issue Type: Improvement Components: Thumbnails Affects Versions: Thumbnails 1.0.0 Reporter: Dan Klco Fix For: Thumbnails 1.0.2 update to latest parent/bundle-parent -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12110) Thumbnails: Upgrade to parent/bundle-parent 52
Dan Klco created SLING-12110: Summary: Thumbnails: Upgrade to parent/bundle-parent 52 Key: SLING-12110 URL: https://issues.apache.org/jira/browse/SLING-12110 Project: Sling Issue Type: Improvement Components: Thumbnails Affects Versions: Thumbnails 1.0.0 Reporter: Dan Klco Fix For: Thumbnails 1.0.2 update to latest parent/bundle-parent -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12109) Remove Dependency on Guava from Thumbnails
Dan Klco created SLING-12109: Summary: Remove Dependency on Guava from Thumbnails Key: SLING-12109 URL: https://issues.apache.org/jira/browse/SLING-12109 Project: Sling Issue Type: Improvement Components: Thumbnails Affects Versions: Thumbnails 1.0.0 Reporter: Dan Klco Assignee: Dan Klco Fix For: Thumbnails 1.0.2 Currently, the Thumbnails library depends on Guava for mime type evaluation, some utilities and caching. This isn't ideal as Guava's major version changes are challenging in OSGi and Oak is removing their dependency on Guava. Therefore the library should be refactored to remove the dependency on Guava. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11651) Some EPS MimeTypes not Resolvable to Extension
[ https://issues.apache.org/jira/browse/SLING-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-11651: - Fix Version/s: (was: Commons MIME 2.2.4) > Some EPS MimeTypes not Resolvable to Extension > -- > > Key: SLING-11651 > URL: https://issues.apache.org/jira/browse/SLING-11651 > Project: Sling > Issue Type: Bug >Affects Versions: Commons MIME 2.2.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > > Certain systems (such as Adobe's Dynamic Media) produce EPS documents with > the mimetype: image/x-eps which is not in the Common MIME's list of supported > mime types: > [https://github.com/apache/sling-org-apache-sling-commons-mime/tree/master/src/main/resources/META-INF] > > Thus, when attempting to retrieve the extension for a resource with the mime > type image/x-eps, null is returned instead of the expected extension. > We should update Commons MIME to support all common mime type variants for > EPS files: > https://en.wikipedia.org/wiki/Encapsulated_PostScript -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11651) Some EPS MimeTypes not Resolvable to Extension
[ https://issues.apache.org/jira/browse/SLING-11651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11651. > Some EPS MimeTypes not Resolvable to Extension > -- > > Key: SLING-11651 > URL: https://issues.apache.org/jira/browse/SLING-11651 > Project: Sling > Issue Type: Bug >Affects Versions: Commons MIME 2.2.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Commons MIME 2.2.4 > > Time Spent: 3h 20m > Remaining Estimate: 0h > > Certain systems (such as Adobe's Dynamic Media) produce EPS documents with > the mimetype: image/x-eps which is not in the Common MIME's list of supported > mime types: > [https://github.com/apache/sling-org-apache-sling-commons-mime/tree/master/src/main/resources/META-INF] > > Thus, when attempting to retrieve the extension for a resource with the mime > type image/x-eps, null is returned instead of the expected extension. > We should update Commons MIME to support all common mime type variants for > EPS files: > https://en.wikipedia.org/wiki/Encapsulated_PostScript -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12079) Update Commons Mime to Bundle Parent 52
[ https://issues.apache.org/jira/browse/SLING-12079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12079. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-commons-mime/commit/27b42feedc5551fb533f0dd0f5a4b6f7e1ae38fe > Update Commons Mime to Bundle Parent 52 > --- > > Key: SLING-12079 > URL: https://issues.apache.org/jira/browse/SLING-12079 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons MIME 2.2.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Commons MIME 2.2.4 > > > Commons Mime currently uses Bundle Parent v35 which is not compatible with > Java 17. We should update it to the latest parent version to support Java 17 > builds. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11652) Update Core Mime Types
[ https://issues.apache.org/jira/browse/SLING-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-11652. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-commons-mime/commit/4c82c540376b0797796447f9adf773dbd525beeb > Update Core Mime Types > -- > > Key: SLING-11652 > URL: https://issues.apache.org/jira/browse/SLING-11652 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons MIME 2.2.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Commons MIME 2.2.4 > > Time Spent: 20m > Remaining Estimate: 0h > > Commons MIME has a core mime types file derived from httpd v2.4.10 which was > released in 2014. > We should update to the latest mime types file from v2.4.54 which contains > ~300 additional mime types not contained in v2.4.10 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12079) Update Commons Mime to Bundle Parent 52
Dan Klco created SLING-12079: Summary: Update Commons Mime to Bundle Parent 52 Key: SLING-12079 URL: https://issues.apache.org/jira/browse/SLING-12079 Project: Sling Issue Type: Improvement Components: Commons Affects Versions: Commons MIME 2.2.2 Reporter: Dan Klco Assignee: Dan Klco Fix For: Commons MIME 2.2.4 Commons Mime currently uses Bundle Parent v35 which is not compatible with Java 17. We should update it to the latest parent version to support Java 17 builds. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12050) Jenkins Tooling - Allow Specifying Build Timeout
Dan Klco created SLING-12050: Summary: Jenkins Tooling - Allow Specifying Build Timeout Key: SLING-12050 URL: https://issues.apache.org/jira/browse/SLING-12050 Project: Sling Issue Type: Improvement Components: Tooling Reporter: Dan Klco Assignee: Dan Klco The Jenkins Tooling sets the build timeout to 30 minutes: https://github.com/apache/sling-tooling-jenkins/blob/77cc9bce6d10c2f40323721f37b098990f666b90/vars/slingOsgiBundleBuild.groovy#L59 Generally, this works, however, the Windows build executors seem to be significantly slower than the Ubuntu executors which for the CMS app is causing build failures due to the Windows builds timing out. Increasing the timeout at the project level should resolve the issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12012) CMS - Add Recent Drafts List
[ https://issues.apache.org/jira/browse/SLING-12012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12012. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/3cf0bd3088bd936321f6cbeeff61fe9bd03012d1 > CMS - Add Recent Drafts List > > > Key: SLING-12012 > URL: https://issues.apache.org/jira/browse/SLING-12012 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Trivial > Fix For: App CMS 1.1.8 > > > It would be helpful to have a list of unpublished or "draft" pages make it > quicker and easier to find pages which are not yet published -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12012) CMS - Add Recent Drafts List
Dan Klco created SLING-12012: Summary: CMS - Add Recent Drafts List Key: SLING-12012 URL: https://issues.apache.org/jira/browse/SLING-12012 Project: Sling Issue Type: Improvement Components: App CMS Affects Versions: App CMS 1.1.6 Reporter: Dan Klco Fix For: App CMS 1.1.8 It would be helpful to have a list of unpublished or "draft" pages make it quicker and easier to find pages which are not yet published -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12012) CMS - Add Recent Drafts List
[ https://issues.apache.org/jira/browse/SLING-12012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-12012: Assignee: Dan Klco > CMS - Add Recent Drafts List > > > Key: SLING-12012 > URL: https://issues.apache.org/jira/browse/SLING-12012 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Trivial > Fix For: App CMS 1.1.8 > > > It would be helpful to have a list of unpublished or "draft" pages make it > quicker and easier to find pages which are not yet published -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12012) CMS - Add Recent Drafts List
[ https://issues.apache.org/jira/browse/SLING-12012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-12012: - Priority: Trivial (was: Major) > CMS - Add Recent Drafts List > > > Key: SLING-12012 > URL: https://issues.apache.org/jira/browse/SLING-12012 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Priority: Trivial > Fix For: App CMS 1.1.8 > > > It would be helpful to have a list of unpublished or "draft" pages make it > quicker and easier to find pages which are not yet published -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12011) CMS - Use LazyBindings
[ https://issues.apache.org/jira/browse/SLING-12011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-12011. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/c07f26ca731893375590de00219cde06fe742478 > CMS - Use LazyBindings > -- > > Key: SLING-12011 > URL: https://issues.apache.org/jira/browse/SLING-12011 > Project: Sling > Issue Type: Improvement > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: App CMS 1.1.8 > > Attachments: image-2023-08-26-09-40-00-139.png, > image-2023-08-26-09-42-52-390.png > > > While analyzing the Recent Requests for Sling CMS I noticed that it spends a > significant amount of time in the DefaultScriptBindingsValueProvider because > it's binding all of properties, even if they are not used. > !image-2023-08-26-09-40-00-139.png|thumbnail! > By using the LazyBindings and and the LazyBindings.Supplier we can avoid > binding unneeded properties. For a simple page like the attached one, this > reduces the request duration nearly in half. > !image-2023-08-26-09-42-52-390.png|thumbnail! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12011) CMS - Use LazyBindings
Dan Klco created SLING-12011: Summary: CMS - Use LazyBindings Key: SLING-12011 URL: https://issues.apache.org/jira/browse/SLING-12011 Project: Sling Issue Type: Improvement Components: App CMS Affects Versions: App CMS 1.1.6 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 1.1.8 Attachments: image-2023-08-26-09-40-00-139.png, image-2023-08-26-09-42-52-390.png While analyzing the Recent Requests for Sling CMS I noticed that it spends a significant amount of time in the DefaultScriptBindingsValueProvider because it's binding all of properties, even if they are not used. !image-2023-08-26-09-40-00-139.png|thumbnail! By using the LazyBindings and and the LazyBindings.Supplier we can avoid binding unneeded properties. For a simple page like the attached one, this reduces the request duration nearly in half. !image-2023-08-26-09-42-52-390.png|thumbnail! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11923) Sling Events does not Build on Java 17
[
https://issues.apache.org/jira/browse/SLING-11923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco updated SLING-11923:
-
Summary: Sling Events does not Build on Java 17 (was: Sling Events does
not work on Java 17)
> Sling Events does not Build on Java 17
> --
>
> Key: SLING-11923
> URL: https://issues.apache.org/jira/browse/SLING-11923
> Project: Sling
> Issue Type: Bug
> Components: Event
>Affects Versions: Event 4.3.12
>Reporter: Dan Klco
>Assignee: Rishabh Daim
>Priority: Major
>
> Attempting to build Sling Events with Java 17 fails with:
> {code:java}
> [main] INFO org.apache.jackrabbit.oak.plugins.index.IndexUpdate - Reindexing
> completed
> [ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1.935
> s <<< FAILURE! - in org.apache.sling.event.impl.jobs.queues.TestTopicHalting
> [ERROR]
> org.apache.sling.event.impl.jobs.queues.TestTopicHalting.testUnhalting Time
> elapsed: 1.506 s <<< ERROR!
> java.lang.NoClassDefFoundError: java/security/acl/Group
> at java.base/java.lang.ClassLoader.defineClass1(Native Method)
> at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
> at
> java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
>
> {code}
> This class is deprecated for removal in Java 11:
> https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/security/acl/Group.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11923) Sling Events does not work on Java 17
[
https://issues.apache.org/jira/browse/SLING-11923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739225#comment-17739225
]
Dan Klco commented on SLING-11923:
--
The IT's are also failing due to testing.paxexam incompatibility with Java 17.
> Sling Events does not work on Java 17
> -
>
> Key: SLING-11923
> URL: https://issues.apache.org/jira/browse/SLING-11923
> Project: Sling
> Issue Type: Bug
> Components: Event
>Affects Versions: Event 4.3.12
>Reporter: Dan Klco
>Priority: Major
>
> Attempting to build Sling Events with Java 17 fails with:
> {code:java}
> [main] INFO org.apache.jackrabbit.oak.plugins.index.IndexUpdate - Reindexing
> completed
> [ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1.935
> s <<< FAILURE! - in org.apache.sling.event.impl.jobs.queues.TestTopicHalting
> [ERROR]
> org.apache.sling.event.impl.jobs.queues.TestTopicHalting.testUnhalting Time
> elapsed: 1.506 s <<< ERROR!
> java.lang.NoClassDefFoundError: java/security/acl/Group
> at java.base/java.lang.ClassLoader.defineClass1(Native Method)
> at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
> at
> java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
>
> {code}
> This class is deprecated for removal in Java 11:
> https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/security/acl/Group.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-11923) Sling Events does not work on Java 17
[
https://issues.apache.org/jira/browse/SLING-11923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739202#comment-17739202
]
Dan Klco edited comment on SLING-11923 at 6/30/23 6:23 PM:
---
Ah, just found the same, thanks for the link [~kwin]! Running the build locally
w/ Java 17 and will open a fix PR shortly.
was (Author: dklco):
Ah, just found the same, thanks for the link [~kwin]!
> Sling Events does not work on Java 17
> -
>
> Key: SLING-11923
> URL: https://issues.apache.org/jira/browse/SLING-11923
> Project: Sling
> Issue Type: Bug
> Components: Event
>Affects Versions: Event 4.3.12
>Reporter: Dan Klco
>Priority: Major
>
> Attempting to build Sling Events with Java 17 fails with:
> {code:java}
> [main] INFO org.apache.jackrabbit.oak.plugins.index.IndexUpdate - Reindexing
> completed
> [ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1.935
> s <<< FAILURE! - in org.apache.sling.event.impl.jobs.queues.TestTopicHalting
> [ERROR]
> org.apache.sling.event.impl.jobs.queues.TestTopicHalting.testUnhalting Time
> elapsed: 1.506 s <<< ERROR!
> java.lang.NoClassDefFoundError: java/security/acl/Group
> at java.base/java.lang.ClassLoader.defineClass1(Native Method)
> at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
> at
> java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
>
> {code}
> This class is deprecated for removal in Java 11:
> https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/security/acl/Group.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11923) Sling Events does not work on Java 17
[
https://issues.apache.org/jira/browse/SLING-11923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739202#comment-17739202
]
Dan Klco commented on SLING-11923:
--
Ah, just found the same, thanks for the link [~kwin]!
> Sling Events does not work on Java 17
> -
>
> Key: SLING-11923
> URL: https://issues.apache.org/jira/browse/SLING-11923
> Project: Sling
> Issue Type: Bug
> Components: Event
>Affects Versions: Event 4.3.12
>Reporter: Dan Klco
>Priority: Major
>
> Attempting to build Sling Events with Java 17 fails with:
> {code:java}
> [main] INFO org.apache.jackrabbit.oak.plugins.index.IndexUpdate - Reindexing
> completed
> [ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1.935
> s <<< FAILURE! - in org.apache.sling.event.impl.jobs.queues.TestTopicHalting
> [ERROR]
> org.apache.sling.event.impl.jobs.queues.TestTopicHalting.testUnhalting Time
> elapsed: 1.506 s <<< ERROR!
> java.lang.NoClassDefFoundError: java/security/acl/Group
> at java.base/java.lang.ClassLoader.defineClass1(Native Method)
> at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
> at
> java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
>
> {code}
> This class is deprecated for removal in Java 11:
> https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/security/acl/Group.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11923) Sling Events does not work on Java 17
Dan Klco created SLING-11923:
Summary: Sling Events does not work on Java 17
Key: SLING-11923
URL: https://issues.apache.org/jira/browse/SLING-11923
Project: Sling
Issue Type: Bug
Components: Event
Affects Versions: Event 4.3.12
Reporter: Dan Klco
Attempting to build Sling Events with Java 17 fails with:
{code:java}
[main] INFO org.apache.jackrabbit.oak.plugins.index.IndexUpdate - Reindexing
completed
[ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1.935 s
<<< FAILURE! - in org.apache.sling.event.impl.jobs.queues.TestTopicHalting
[ERROR] org.apache.sling.event.impl.jobs.queues.TestTopicHalting.testUnhalting
Time elapsed: 1.506 s <<< ERROR!
java.lang.NoClassDefFoundError: java/security/acl/Group
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
at
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
at
java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862)
at
java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760)
at
java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681)
at
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
{code}
This class is deprecated for removal in Java 11:
https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/security/acl/Group.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-11871: - Fix Version/s: (was: Security 1.1.26) > Referrer Filter - Enable Bypass for Requests with Origin Header > --- > > Key: SLING-11871 > URL: https://issues.apache.org/jira/browse/SLING-11871 > Project: Sling > Issue Type: Improvement > Components: Sling Security >Affects Versions: Security 1.1.24 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > > The Referrer Filter in Apache Sling Security blocks requests without a > Referrer or a non-allow listed Referrer. Therefore Referrer filter will also > block external CORS requests which rather than using the Referrer, like > standard browser requests, use the Origin header. > We should therefore enable bypassing the ReferrerFilter for requests > containing an Origin header. These requests would need to be separately > validated by something else to ensure the Origin is valid. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-9061) Evaluate ORIGIN header in addition to Referer header in ReferrerFilter
[ https://issues.apache.org/jira/browse/SLING-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-9061. - Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-security/pull/9 > Evaluate ORIGIN header in addition to Referer header in ReferrerFilter > -- > > Key: SLING-9061 > URL: https://issues.apache.org/jira/browse/SLING-9061 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Security 1.1.16 >Reporter: Konrad Windszus >Priority: Major > Fix For: Security 1.1.26 > > > As discussed in > https://issues.apache.org/jira/browse/SLING-9043?focusedCommentId=17031442=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17031442 > the origin header should be used to implement some CSRF protection. See also > https://owasp.org/www-project-cheat-sheets/cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.html#verifying-origin-with-standard-headers, > https://seclab.stanford.edu/websec/csrf/csrf.pdf and > https://www.sjoerdlangkemper.nl/2019/02/27/prevent-csrf-with-the-origin-http-request-header/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-11871. -- Resolution: Duplicate > Referrer Filter - Enable Bypass for Requests with Origin Header > --- > > Key: SLING-11871 > URL: https://issues.apache.org/jira/browse/SLING-11871 > Project: Sling > Issue Type: Improvement > Components: Sling Security >Affects Versions: Security 1.1.24 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Security 1.1.26 > > > The Referrer Filter in Apache Sling Security blocks requests without a > Referrer or a non-allow listed Referrer. Therefore Referrer filter will also > block external CORS requests which rather than using the Referrer, like > standard browser requests, use the Origin header. > We should therefore enable bypassing the ReferrerFilter for requests > containing an Origin header. These requests would need to be separately > validated by something else to ensure the Origin is valid. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-9061) Evaluate ORIGIN header in addition to Referer header in ReferrerFilter
[ https://issues.apache.org/jira/browse/SLING-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-9061: Fix Version/s: Security 1.1.26 > Evaluate ORIGIN header in addition to Referer header in ReferrerFilter > -- > > Key: SLING-9061 > URL: https://issues.apache.org/jira/browse/SLING-9061 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Security 1.1.16 >Reporter: Konrad Windszus >Priority: Major > Fix For: Security 1.1.26 > > > As discussed in > https://issues.apache.org/jira/browse/SLING-9043?focusedCommentId=17031442=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17031442 > the origin header should be used to implement some CSRF protection. See also > https://owasp.org/www-project-cheat-sheets/cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.html#verifying-origin-with-standard-headers, > https://seclab.stanford.edu/websec/csrf/csrf.pdf and > https://www.sjoerdlangkemper.nl/2019/02/27/prevent-csrf-with-the-origin-http-request-header/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11871. Closing in favor of SLING-9061 > Referrer Filter - Enable Bypass for Requests with Origin Header > --- > > Key: SLING-11871 > URL: https://issues.apache.org/jira/browse/SLING-11871 > Project: Sling > Issue Type: Improvement > Components: Sling Security >Affects Versions: Security 1.1.24 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Security 1.1.26 > > > The Referrer Filter in Apache Sling Security blocks requests without a > Referrer or a non-allow listed Referrer. Therefore Referrer filter will also > block external CORS requests which rather than using the Referrer, like > standard browser requests, use the Origin header. > We should therefore enable bypassing the ReferrerFilter for requests > containing an Origin header. These requests would need to be separately > validated by something else to ensure the Origin is valid. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722287#comment-17722287 ] Dan Klco commented on SLING-11871: -- Correct [~cziegeler], this would only apply for modification requests. [~kwin] Good question. Reviewing the issue, I think SLING-9061 makes more sense than this change with an addition of a service factory for ReferrerFilter configuration amendments. The reason being conflicts between vendor provided base configurations and end-users need to customize the allowed hosts. Since this configuration is a singleton, it's not possible for an end user to customize this component without overriding the default configuration. Here's another PR with this: https://github.com/apache/sling-org-apache-sling-security/pull/9 > Referrer Filter - Enable Bypass for Requests with Origin Header > --- > > Key: SLING-11871 > URL: https://issues.apache.org/jira/browse/SLING-11871 > Project: Sling > Issue Type: Improvement > Components: Sling Security >Affects Versions: Security 1.1.24 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Security 1.1.26 > > > The Referrer Filter in Apache Sling Security blocks requests without a > Referrer or a non-allow listed Referrer. Therefore Referrer filter will also > block external CORS requests which rather than using the Referrer, like > standard browser requests, use the Origin header. > We should therefore enable bypassing the ReferrerFilter for requests > containing an Origin header. These requests would need to be separately > validated by something else to ensure the Origin is valid. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-9061) Evaluate ORIGIN header in addition to Referer header in ReferrerFilter
[ https://issues.apache.org/jira/browse/SLING-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722288#comment-17722288 ] Dan Klco commented on SLING-9061: - Potential PR https://github.com/apache/sling-org-apache-sling-security/pull/9 > Evaluate ORIGIN header in addition to Referer header in ReferrerFilter > -- > > Key: SLING-9061 > URL: https://issues.apache.org/jira/browse/SLING-9061 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Security 1.1.16 >Reporter: Konrad Windszus >Priority: Major > > As discussed in > https://issues.apache.org/jira/browse/SLING-9043?focusedCommentId=17031442=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17031442 > the origin header should be used to implement some CSRF protection. See also > https://owasp.org/www-project-cheat-sheets/cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.html#verifying-origin-with-standard-headers, > https://seclab.stanford.edu/websec/csrf/csrf.pdf and > https://www.sjoerdlangkemper.nl/2019/02/27/prevent-csrf-with-the-origin-http-request-header/ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721970#comment-17721970 ] Dan Klco commented on SLING-11871: -- PR: https://github.com/apache/sling-org-apache-sling-security/pull/8 > Referrer Filter - Enable Bypass for Requests with Origin Header > --- > > Key: SLING-11871 > URL: https://issues.apache.org/jira/browse/SLING-11871 > Project: Sling > Issue Type: Improvement > Components: Sling Security >Affects Versions: Security 1.1.24 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Security 1.1.26 > > > The Referrer Filter in Apache Sling Security blocks requests without a > Referrer or a non-allow listed Referrer. Therefore Referrer filter will also > block external CORS requests which rather than using the Referrer, like > standard browser requests, use the Origin header. > We should therefore enable bypassing the ReferrerFilter for requests > containing an Origin header. These requests would need to be separately > validated by something else to ensure the Origin is valid. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header
Dan Klco created SLING-11871: Summary: Referrer Filter - Enable Bypass for Requests with Origin Header Key: SLING-11871 URL: https://issues.apache.org/jira/browse/SLING-11871 Project: Sling Issue Type: Improvement Components: Sling Security Affects Versions: Security 1.1.24 Reporter: Dan Klco Assignee: Dan Klco Fix For: Security 1.1.26 The Referrer Filter in Apache Sling Security blocks requests without a Referrer or a non-allow listed Referrer. Therefore Referrer filter will also block external CORS requests which rather than using the Referrer, like standard browser requests, use the Origin header. We should therefore enable bypassing the ReferrerFilter for requests containing an Origin header. These requests would need to be separately validated by something else to ensure the Origin is valid. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11859) Avoid Duplicating API Version in Events BND
[ https://issues.apache.org/jira/browse/SLING-11859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11859. > Avoid Duplicating API Version in Events BND > --- > > Key: SLING-11859 > URL: https://issues.apache.org/jira/browse/SLING-11859 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Trivial > Fix For: Event 4.3.12 > > > Found by Stefan Seifert: > cosmetic: the bnd.bnd. in the event module contains an explicit reference to > sling.event.api-1.0.2, same as the pom.xml. it would be better to avoid the > redundancy and define the actual version only in the POM, otherwise it might > be forgotten to update in in both places in future updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11831) Allow setting job properties for custom job state
[ https://issues.apache.org/jira/browse/SLING-11831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11831. > Allow setting job properties for custom job state > - > > Key: SLING-11831 > URL: https://issues.apache.org/jira/browse/SLING-11831 > Project: Sling > Issue Type: Improvement > Components: Event >Affects Versions: Event 4.3.8 >Reporter: Andrew Khoury >Assignee: Dan Klco >Priority: Major > Fix For: Event 4.3.12, Event API 1.0.4 > > > The > [JobExecutionContext|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28] > currently allows updating Job progress info and the progress log but it > doesn't allow storing of custom properties. The reason we would want to > support custom properties is to allow storing resume information. > For example, let's say we have a job where we are moving multiple resources > around in a clustered environment with many sling instances pointing to the > same JCR repository (for example Oak MongoMK). If the instance that is > running the move job crashes in the middle of the job execution we would want > some information stored so the job can be resumed on another node. > To solve this issue, we can introduce a setProperty method to the > [JobExecutionContext.|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28] > This method would allow us to save some state information for use in case the > job is resumed on another node. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11316) Update sling.event.api to parent 47
[ https://issues.apache.org/jira/browse/SLING-11316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11316. > Update sling.event.api to parent 47 > --- > > Key: SLING-11316 > URL: https://issues.apache.org/jira/browse/SLING-11316 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Robert Munteanu >Priority: Major > Fix For: Event API 1.0.4 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11858) Fix Scope of org.jetbrains:annotations in Events / Events API
[ https://issues.apache.org/jira/browse/SLING-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11858. > Fix Scope of org.jetbrains:annotations in Events / Events API > - > > Key: SLING-11858 > URL: https://issues.apache.org/jira/browse/SLING-11858 > Project: Sling > Issue Type: Bug > Components: Event >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Event 4.3.12, Event API 1.0.4 > > > Found by Stefan Seifert: > on both modules org.jetbrains:annotations was added with compile scope - > should be provided. although not a problem for the bundle in OSGi runtime, it > should be fixed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11859) Avoid Duplicating API Version in Events BND
[ https://issues.apache.org/jira/browse/SLING-11859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-11859: - Description: Found by Stefan Seifert: cosmetic: the bnd.bnd. in the event module contains an explicit reference to sling.event.api-1.0.2, same as the pom.xml. it would be better to avoid the redundancy and define the actual version only in the POM, otherwise it might be forgotten to update in in both places in future updates. was: Found by Stefan Seifert: osmetic: the bnd.bnd. in the event module contains an explicit reference to sling.event.api-1.0.2, same as the pom.xml. it would be better to avoid the redundancy and define the actual version only in the POM, otherwise it might be forgotten to update in in both places in future updates. > Avoid Duplicating API Version in Events BND > --- > > Key: SLING-11859 > URL: https://issues.apache.org/jira/browse/SLING-11859 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Trivial > Fix For: Event 4.3.12 > > > Found by Stefan Seifert: > cosmetic: the bnd.bnd. in the event module contains an explicit reference to > sling.event.api-1.0.2, same as the pom.xml. it would be better to avoid the > redundancy and define the actual version only in the POM, otherwise it might > be forgotten to update in in both places in future updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11859) Avoid Duplicating API Version in Events BND
[ https://issues.apache.org/jira/browse/SLING-11859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720560#comment-17720560 ] Dan Klco commented on SLING-11859: -- fixed in https://github.com/apache/sling-org-apache-sling-event/commit/c0dd2cf5dd6f042c9c6d91c7237b1a05136e6e3c > Avoid Duplicating API Version in Events BND > --- > > Key: SLING-11859 > URL: https://issues.apache.org/jira/browse/SLING-11859 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Trivial > Fix For: Event 4.3.12 > > > Found by Stefan Seifert: > osmetic: the bnd.bnd. in the event module contains an explicit reference to > sling.event.api-1.0.2, same as the pom.xml. it would be better to avoid the > redundancy and define the actual version only in the POM, otherwise it might > be forgotten to update in in both places in future updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11858) Fix Scope of org.jetbrains:annotations in Events / Events API
[ https://issues.apache.org/jira/browse/SLING-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720557#comment-17720557 ] Dan Klco commented on SLING-11858: -- fixed in: https://github.com/apache/sling-org-apache-sling-event-api/commit/51eadd0a27327579c37039e4619d41cd61ac04fe https://github.com/apache/sling-org-apache-sling-event/commit/ccae75df9f3a6e5bb9f7d2926b5e46ed14bc368d > Fix Scope of org.jetbrains:annotations in Events / Events API > - > > Key: SLING-11858 > URL: https://issues.apache.org/jira/browse/SLING-11858 > Project: Sling > Issue Type: Bug > Components: Event >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Event 4.3.12, Event API 1.0.4 > > > Found by Stefan Seifert: > on both modules org.jetbrains:annotations was added with compile scope - > should be provided. although not a problem for the bundle in OSGi runtime, it > should be fixed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11859) Avoid Duplicating API Version in Events BND
[ https://issues.apache.org/jira/browse/SLING-11859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-11859. -- Resolution: Fixed > Avoid Duplicating API Version in Events BND > --- > > Key: SLING-11859 > URL: https://issues.apache.org/jira/browse/SLING-11859 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Trivial > Fix For: Event 4.3.12 > > > Found by Stefan Seifert: > osmetic: the bnd.bnd. in the event module contains an explicit reference to > sling.event.api-1.0.2, same as the pom.xml. it would be better to avoid the > redundancy and define the actual version only in the POM, otherwise it might > be forgotten to update in in both places in future updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11858) Fix Scope of org.jetbrains:annotations in Events / Events API
[ https://issues.apache.org/jira/browse/SLING-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-11858. -- Resolution: Fixed > Fix Scope of org.jetbrains:annotations in Events / Events API > - > > Key: SLING-11858 > URL: https://issues.apache.org/jira/browse/SLING-11858 > Project: Sling > Issue Type: Bug > Components: Event >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Event 4.3.12, Event API 1.0.4 > > > Found by Stefan Seifert: > on both modules org.jetbrains:annotations was added with compile scope - > should be provided. although not a problem for the bundle in OSGi runtime, it > should be fixed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11859) Avoid Duplicating API Version in Events BND
[ https://issues.apache.org/jira/browse/SLING-11859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-11859: - Fix Version/s: Event 4.3.12 > Avoid Duplicating API Version in Events BND > --- > > Key: SLING-11859 > URL: https://issues.apache.org/jira/browse/SLING-11859 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Trivial > Fix For: Event 4.3.12 > > > Found by Stefan Seifert: > osmetic: the bnd.bnd. in the event module contains an explicit reference to > sling.event.api-1.0.2, same as the pom.xml. it would be better to avoid the > redundancy and define the actual version only in the POM, otherwise it might > be forgotten to update in in both places in future updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11858) Fix Scope of org.jetbrains:annotations in Events / Events API
[ https://issues.apache.org/jira/browse/SLING-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-11858: - Fix Version/s: Event 4.3.12 Event API 1.0.4 > Fix Scope of org.jetbrains:annotations in Events / Events API > - > > Key: SLING-11858 > URL: https://issues.apache.org/jira/browse/SLING-11858 > Project: Sling > Issue Type: Bug > Components: Event >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Event 4.3.12, Event API 1.0.4 > > > Found by Stefan Seifert: > on both modules org.jetbrains:annotations was added with compile scope - > should be provided. although not a problem for the bundle in OSGi runtime, it > should be fixed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-9664: Fix Version/s: Event 4.3.14 (was: Event 4.3.12) > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Joerg Hoh >Priority: Major > Fix For: Event 4.3.14 > > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11422) Stop embedding the event.api package in the event bundle
[ https://issues.apache.org/jira/browse/SLING-11422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-11422: - Fix Version/s: Event 4.3.14 (was: Event 4.3.12) > Stop embedding the event.api package in the event bundle > > > Key: SLING-11422 > URL: https://issues.apache.org/jira/browse/SLING-11422 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Robert Munteanu >Priority: Major > Fix For: Event 4.3.14 > > > As discussed in SLING-9664, deploying the Sling Event and Event API bundles > separately would be more in line with how we deploy bundles and also fix the > Javadoc generation. > We should make this a minor version bump for the event bundle, to make it > clear that deployers need to adapt. Probably the baselining mechanism will > complain, but it's something we can ignore for the release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11316) Update sling.event.api to parent 47
[ https://issues.apache.org/jira/browse/SLING-11316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-11316: - Fix Version/s: Event API 1.0.4 (was: Event API 1.0.2) > Update sling.event.api to parent 47 > --- > > Key: SLING-11316 > URL: https://issues.apache.org/jira/browse/SLING-11316 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Robert Munteanu >Priority: Major > Fix For: Event API 1.0.4 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11831) Allow setting job properties for custom job state
[ https://issues.apache.org/jira/browse/SLING-11831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-11831: - Fix Version/s: Event 4.3.12 Event API 1.0.4 (was: Event 4.3.10) (was: Event API 1.0.2) > Allow setting job properties for custom job state > - > > Key: SLING-11831 > URL: https://issues.apache.org/jira/browse/SLING-11831 > Project: Sling > Issue Type: Improvement > Components: Event >Affects Versions: Event 4.3.8 >Reporter: Andrew Khoury >Assignee: Dan Klco >Priority: Major > Fix For: Event 4.3.12, Event API 1.0.4 > > > The > [JobExecutionContext|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28] > currently allows updating Job progress info and the progress log but it > doesn't allow storing of custom properties. The reason we would want to > support custom properties is to allow storing resume information. > For example, let's say we have a job where we are moving multiple resources > around in a clustered environment with many sling instances pointing to the > same JCR repository (for example Oak MongoMK). If the instance that is > running the move job crashes in the middle of the job execution we would want > some information stored so the job can be resumed on another node. > To solve this issue, we can introduce a setProperty method to the > [JobExecutionContext.|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28] > This method would allow us to save some state information for use in case the > job is resumed on another node. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11858) Fix Scope of org.jetbrains:annotations in Events / Events API
[ https://issues.apache.org/jira/browse/SLING-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-11858: Assignee: Dan Klco > Fix Scope of org.jetbrains:annotations in Events / Events API > - > > Key: SLING-11858 > URL: https://issues.apache.org/jira/browse/SLING-11858 > Project: Sling > Issue Type: Bug > Components: Event >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > > Found by Stefan Seifert: > on both modules org.jetbrains:annotations was added with compile scope - > should be provided. although not a problem for the bundle in OSGi runtime, it > should be fixed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11859) Avoid Duplicating API Version in Events BND
Dan Klco created SLING-11859: Summary: Avoid Duplicating API Version in Events BND Key: SLING-11859 URL: https://issues.apache.org/jira/browse/SLING-11859 Project: Sling Issue Type: Improvement Components: Event Reporter: Dan Klco Assignee: Dan Klco Found by Stefan Seifert: osmetic: the bnd.bnd. in the event module contains an explicit reference to sling.event.api-1.0.2, same as the pom.xml. it would be better to avoid the redundancy and define the actual version only in the POM, otherwise it might be forgotten to update in in both places in future updates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11858) Fix Scope of org.jetbrains:annotations in Events / Events API
Dan Klco created SLING-11858: Summary: Fix Scope of org.jetbrains:annotations in Events / Events API Key: SLING-11858 URL: https://issues.apache.org/jira/browse/SLING-11858 Project: Sling Issue Type: Bug Components: Event Reporter: Dan Klco Found by Stefan Seifert: on both modules org.jetbrains:annotations was added with compile scope - should be provided. although not a problem for the bundle in OSGi runtime, it should be fixed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11316) Update sling.event.api to parent 47
[ https://issues.apache.org/jira/browse/SLING-11316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-11316: - Fix Version/s: Event API 1.0.2 (was: Event API 1.1.0) > Update sling.event.api to parent 47 > --- > > Key: SLING-11316 > URL: https://issues.apache.org/jira/browse/SLING-11316 > Project: Sling > Issue Type: Sub-task >Reporter: Ashok Pelluru >Assignee: Robert Munteanu >Priority: Major > Fix For: Event API 1.0.2 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-9664: Fix Version/s: Event 4.3.12 (was: Event 4.3.10) > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Joerg Hoh >Priority: Major > Fix For: Event 4.3.12 > > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11831) Allow setting job properties for custom job state
[ https://issues.apache.org/jira/browse/SLING-11831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-11831. -- Resolution: Fixed > Allow setting job properties for custom job state > - > > Key: SLING-11831 > URL: https://issues.apache.org/jira/browse/SLING-11831 > Project: Sling > Issue Type: Improvement > Components: Event >Affects Versions: Event 4.3.8 >Reporter: Andrew Khoury >Assignee: Dan Klco >Priority: Major > Fix For: Event 4.3.10, Event API 1.0.2 > > > The > [JobExecutionContext|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28] > currently allows updating Job progress info and the progress log but it > doesn't allow storing of custom properties. The reason we would want to > support custom properties is to allow storing resume information. > For example, let's say we have a job where we are moving multiple resources > around in a clustered environment with many sling instances pointing to the > same JCR repository (for example Oak MongoMK). If the instance that is > running the move job crashes in the middle of the job execution we would want > some information stored so the job can be resumed on another node. > To solve this issue, we can introduce a setProperty method to the > [JobExecutionContext.|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28] > This method would allow us to save some state information for use in case the > job is resumed on another node. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11422) Stop embedding the event.api package in the event bundle
[ https://issues.apache.org/jira/browse/SLING-11422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-11422: - Fix Version/s: Event 4.3.12 (was: Event 4.3.10) > Stop embedding the event.api package in the event bundle > > > Key: SLING-11422 > URL: https://issues.apache.org/jira/browse/SLING-11422 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Robert Munteanu >Priority: Major > Fix For: Event 4.3.12 > > > As discussed in SLING-9664, deploying the Sling Event and Event API bundles > separately would be more in line with how we deploy bundles and also fix the > Javadoc generation. > We should make this a minor version bump for the event bundle, to make it > clear that deployers need to adapt. Probably the baselining mechanism will > complain, but it's something we can ignore for the release. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11831) Allow setting job properties for custom job state
[ https://issues.apache.org/jira/browse/SLING-11831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-11831: - Fix Version/s: Event 4.3.10 > Allow setting job properties for custom job state > - > > Key: SLING-11831 > URL: https://issues.apache.org/jira/browse/SLING-11831 > Project: Sling > Issue Type: Improvement > Components: Event >Affects Versions: Event 4.3.8 >Reporter: Andrew Khoury >Assignee: Dan Klco >Priority: Major > Fix For: Event 4.3.10, Event API 1.0.2 > > > The > [JobExecutionContext|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28] > currently allows updating Job progress info and the progress log but it > doesn't allow storing of custom properties. The reason we would want to > support custom properties is to allow storing resume information. > For example, let's say we have a job where we are moving multiple resources > around in a clustered environment with many sling instances pointing to the > same JCR repository (for example Oak MongoMK). If the instance that is > running the move job crashes in the middle of the job execution we would want > some information stored so the job can be resumed on another node. > To solve this issue, we can introduce a setProperty method to the > [JobExecutionContext.|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28] > This method would allow us to save some state information for use in case the > job is resumed on another node. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11831) Allow setting job properties for custom job state
[ https://issues.apache.org/jira/browse/SLING-11831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-11831: - Fix Version/s: Event API 1.0.2 > Allow setting job properties for custom job state > - > > Key: SLING-11831 > URL: https://issues.apache.org/jira/browse/SLING-11831 > Project: Sling > Issue Type: Improvement > Components: Event >Affects Versions: Event 4.3.8 >Reporter: Andrew Khoury >Assignee: Dan Klco >Priority: Major > Fix For: Event API 1.0.2 > > > The > [JobExecutionContext|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28] > currently allows updating Job progress info and the progress log but it > doesn't allow storing of custom properties. The reason we would want to > support custom properties is to allow storing resume information. > For example, let's say we have a job where we are moving multiple resources > around in a clustered environment with many sling instances pointing to the > same JCR repository (for example Oak MongoMK). If the instance that is > running the move job crashes in the middle of the job execution we would want > some information stored so the job can be resumed on another node. > To solve this issue, we can introduce a setProperty method to the > [JobExecutionContext.|https://github.com/apache/sling-org-apache-sling-event-api/blob/d151fdf0da58ed0dbf18002788f8965b0ebcef84/src/main/java/org/apache/sling/event/jobs/consumer/JobExecutionContext.java#L28] > This method would allow us to save some state information for use in case the > job is resumed on another node. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11853) CMS - Editor Submit Buttons Sporadically Un-selectable in Mobile
[ https://issues.apache.org/jira/browse/SLING-11853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-11853. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/bb95f97e1f5b1bef773e3dd44288071d4be9b6ec > CMS - Editor Submit Buttons Sporadically Un-selectable in Mobile > > > Key: SLING-11853 > URL: https://issues.apache.org/jira/browse/SLING-11853 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: App CMS 1.1.6 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: App CMS 1.1.8 > > > When editing components on a mobile breakpoint the buttons to submit the form > occasionally are positioned outside of the viewport and due to overflow: > hidden CSS rules are not visible and thus cannot be clicked to submit the > form. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11853) CMS - Editor Submit Buttons Sporadically Un-selectable in Mobile
Dan Klco created SLING-11853: Summary: CMS - Editor Submit Buttons Sporadically Un-selectable in Mobile Key: SLING-11853 URL: https://issues.apache.org/jira/browse/SLING-11853 Project: Sling Issue Type: Bug Components: App CMS Affects Versions: App CMS 1.1.6 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 1.1.8 When editing components on a mobile breakpoint the buttons to submit the form occasionally are positioned outside of the viewport and due to overflow: hidden CSS rules are not visible and thus cannot be clicked to submit the form. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11833) The double quotes in the page js are escaped and cannot run js
[ https://issues.apache.org/jira/browse/SLING-11833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-11833. Rewriter released and updated in CMS > The double quotes in the page js are escaped and cannot run js > -- > > Key: SLING-11833 > URL: https://issues.apache.org/jira/browse/SLING-11833 > Project: Sling > Issue Type: Bug > Components: App CMS >Affects Versions: Rewriter 1.3.0, App CMS 1.1.2 >Reporter: James Raynor >Assignee: Dan Klco >Priority: Major > Fix For: Rewriter 1.3.6, App CMS 1.1.8 > > Attachments: 2023-04-19--09-56-41.png > > > Edit the content on page: > [http://localhost:8080/bin/browser.html/apps/reference/components/pages/base/base.jsp] > then test it on page: > [http://localhost:8080/content/apache/sling-apache-org/index.html] > The test results are shown in the picture. > Double quotes within the page are escaped, but in previous versions (e.g. > 0.16.2) it was ok and there was no such problem. > __ > 2023-04-20 update: > "&&", "<", ">" also doesn't work anymore, e.g: > if (result.data != null && result.data != '' && result.exist == 'true') > if (result.data != null & amp;& amp; result.data != '' & amp;& amp; > result.exist == 'true') -- This message was sent by Atlassian Jira (v8.20.10#820010)
