; Patches merged.
>
> Thanks,
>
> Wayne
>
> On 1/29/2019 5:40 PM, John Beard wrote:
> > Hi,
> >
> > Following the QA patch set just merged, here are a couple more.
> >
> > 1) Add tests on SHAPE_POLY_SET::Distance and a few geometry helpers
> > for concise
-internal includes clearer.
(These tests do not concern, conflict with or affect the recent
SHAPE_POLY_SET Collision problems.)
Cheers,
John
From f2df038f45edc6c88ec0f506fe7d604002ea8701 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Mon, 28 Jan 2019 10:36:54 +
Subject: [PATCH 2/2] QA: Tidy
--Chris Hardwick
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHel
it right now if the class its testing is having work
done on it!
Cheers,
John
From b8494711bf7c8dd1ec41863d58486651117c1e8d Mon Sep 17 00:00:00 2001
From: John Beard
Date: Tue, 29 Jan 2019 17:38:31 +
Subject: [PATCH] QA: Fix faulty test of SHAPE_POLY_SET Collision
This test assumed points on a edge
ke the previous polygon test. Does it make
> sense to merge this unit the test failures are resolved?
>
> Cheers,
>
> Wayne
>
> On 1/25/2019 10:48 AM, John Beard wrote:
> > Hi,
> >
> > Here are a few more patches to finish up consolidating most of the
>
things now should be:
* pcb_test_window: what is this for and can it be fixed? Can it be
made into a sub-tool, or does it need its own executable for the
wxApp?
Cheers,
John
From 8efadbfef50cd441f624f0ef3db9e2915924209e Mon Sep 17 00:00:00 2001
From: John Beard
Date: Thu, 24 Jan 2019 11:33:22
m solution), but haven't started the second
bit, and there's a refactor and a good think needed. So, submitting
this to close out the 5.1.0 bug and at least prevent invalid outputs.
Cheers,
John
From 37ffeb90c01dbd1a9c81e92333f993527f7fe517 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Thu, 24 Jan 201
sys2 builder is
> using so that may have something to do with it. Either the gcc and/or
> boost versions are the likely culprit.
>
> In any event, your changes resolved the issue so I merged your patch set.
>
> Thanks,
>
> Wayne
>
> On 1/23/2019 12:48 PM, John Bear
D'oh, and I though I was being so clever with git send-email... Here
it is all in one piece.
Sorry!
John
On Wed, Jan 23, 2019 at 2:46 PM Seth Hillbrand wrote:
>
> Am 2019-01-23 08:46, schrieb John Beard:
> > In the past, the ZONE_CONTAINER::GetPosition() member
> > re
In the past, the ZONE_CONTAINER::GetPosition() member
returned a reference to a wxPoint, in accordance with the
BOARD_ITEM interface. This meant that ZONE_CONTAINER had
to reinterpret_cast a VECTOR2I (its internal position data) to wxPoint,
which was possible only due to fortunate memory layout.
On 19 January 2019 23:55:02 GMT, Tomasz Wlostowski
wrote:
>It's going to be a very useful tool. I wrote similar tests in the past
>for the P and connectivity (and GAL and some other things too), but
>they remain in my private branches because they're too low quality IMHO
>to be published, so
>
> I don't think there is any disadvantage to rolling the other tests into
> the qa test executable.
>
> Thanks,
>
> Wayne
>
> On 1/19/19 10:25 AM, John Beard wrote:
> > Hi Wayne,
> >
> > I'll rebase the patch. Would you like me to roll the other
>
lies cleanly. It looks useful so I
> don't see any reason not to merge it.
>
> Cheers,
>
> Wayne
>
> On 1/19/2019 9:30 AM, John Beard wrote:
> > Hi,
> >
> > A very gentle bump here. I'm thinking about a utility to assist in
> > debugging/benchmarking/testi
Hi,
A very gentle bump here. I'm thinking about a utility to assist in
debugging/benchmarking/testing/developing DRC routines (currently
working on some DRC unit testing, but the testing utils are easily
re-used into a small utility-style executable).
However, I am cognisant of the costs of
Hi Frank,
I've got a very rough outline of the cost of courtyard calculations.
The timings are for "n" modules in various proportions of rectangular
and rounded rectangles.
The modules are each a single courtyard outline (no other features).
All are 1mm square and the round radius is 0.25mm. All
image.
JP, could you check this works on whatever system threw the error for
you?
Cheers,
John
* Also, once min Boost is >=1.59, lots of other hackish macros to work
around missing functions become superfluous, which will be nice!
Notably, Ubuntu LTS 18.04 uses Boost 1.65.
From e0236b351690f6de0a
,
>
> Wayne
>
> On 12/19/2018 10:19 AM, John Beard wrote:
> > Sorry, I failed to rebase that over the newest changes. This should
> > apply better as a patch.
> >
> > Cheers,
> >
> > John
> > On Wed, Dec 19, 2018 at 3:15 PM John Beard wrote:
>
Wed, Jan 9, 2019 at 4:52 PM Wayne Stambaugh wrote:
>
> John,
>
> If I only apply patch 1, shouldn't the arc bounding box test fail? I
> just tried this and all of the tests passed.
>
> Wayne
>
> On 1/9/2019 11:14 AM, John Beard wrote:
> > Hi,
> >
>
ld be good to get a review to check I've done
it correctly! Specifically: have I missed an important case in the
tests?
Also includes a couple of handy geometry test predicates for vectors and boxes.
Cheers,
John
From 89bbe29e721a2059a69f7205449dd51c8e5a2257 Mon Sep 17 00:00:00 2001
From: John Beard
Hi Seth,
I'm not sure cxx_constexpr would be enough. This just checks the
"N2235" (2007) [1, p13] definition of constexpr is available. This
includes:
...constexpr specifier used in a non-static member function definition
declares that member function to be const...
This is the issue at hand -
ange the caused a conflict before
> I could get around to merging them.
>
> Thanks,
>
> Wayne
>
> On 1/8/2019 12:35 PM, John Beard wrote:
> > Hi Seth,
> >
> > Here are updated patches (only #3 is changed).
> >
> > I have still hardcoded the expecte
platforms, as it has been doing this
quietly since Feb 2018!
Cheers,
John
Ref: https://docs.wxwidgets.org/3.0/page_cppconst.html
From de2ea38e93b59e932a49d70e38eba05443b8b1aa Mon Sep 17 00:00:00 2001
From: John Beard
Date: Tue, 8 Jan 2019 17:50:06 +
Subject: [PATCH] __WXWINDOWS__ does not mean
Hillbrand wrote:
>
> Am 2019-01-08 11:46, schrieb John Beard:
> > Hi Seth,
> >
> > Good idea - I was just moving what the code currently did, but sounds
> > like a sensible fix. I'll amend patch 0003.
> >
> > Does it otherwise work on Windows?
>
>
Hi Seth,
Good idea - I was just moving what the code currently did, but sounds
like a sensible fix. I'll amend patch 0003.
Does it otherwise work on Windows?
Cheers,
John
On Tue, Jan 8, 2019 at 4:36 PM Seth Hillbrand wrote:
>
> Am 2019-01-08 09:16, schrieb John Beard:
> > Hi,
John
From cf87f505f6c5755e8db4cfe91b1455a04bd27d03 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Tue, 8 Jan 2019 11:57:39 +
Subject: [PATCH 3/3] Wildcards: unify handling of all files wildcards
Use the AddFileExtListToFilter() to also generate the
wildcard for "all files". This is becau
On Mon, Jan 7, 2019 at 2:47 PM jp charras wrote:
> This patch works.
Great!
> make test works and shows only 3 tests:
Looks like you don't have the python scripting on, so you are missing
the qa_python target. The pcbnew target (this one) is there.
> So it can be a cmake issue and/or a
>
> I just ran a 32 bit build on windows with commit 3f9230fa and I didn't
> have any build or test issues.
>
> Cheers,
>
> Wayne
>
> On 1/7/2019 8:00 AM, John Beard wrote:
> > Hi JP,
> >
> > Sorry, I thought that issue was just a side effect of conflicte
On Mon, Jan 7, 2019 at 11:42 AM jp charras wrote:
>
> Le 07/01/2019 à 12:33, John Beard a écrit :
> > Hi Seth,
> >
> > The revert commit (8f11a2133efd95526d1a3783dbaca76f732b8efb) also
> > killed the CMake add_subdirectory (because the original commit was
> > conflic
Hillbrand wrote:
>
> Am 2019-01-06 15:14, schrieb John Beard:
> > Hi,
> >
> > I'm not quite sure what happened here, but patch 0001 in the top email
> > hasn't been applied, but instead the RFC patch for the combined
> > utilities tool program has been applied
Hi,
I'm not quite sure what happened here, but patch 0001 in the top email hasn't
been applied, but instead the RFC patch for the combined utilities tool program
has been applied (now commit 502306) instead.
If nothing else, this is unlikely to work on older boosts with that missing
first
Hi,
Here is a really silly (since it's in legacy code) small patch for
some unused code I was alerted to by Clang. But might as well get it
off my patch stack!
Cheers,
John
From 3f7aaef50dc0cc51d995450c6c6a7c5fca85f8d1 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Fri, 4 Jan 2019 14:20:47
On Sat, Jan 5, 2019 at 4:23 PM Seth Hillbrand wrote:
> Patch 0002 does not apply cleanly to qa/CMakeLists.txt even after
> applying 0001
Hmm, that's odd: I can apply this with "git am 0002". I'm applying
on top of 69fc301bf. Where are you applying it to? Do you still have
the triangulation
00:00 2001
From: John Beard
Date: Thu, 20 Dec 2018 14:14:53 +
Subject: [PATCH 1/3] QA: Add some more Boost version guards
Some functions aren't defined on Boost < 1.59, which is
sadly inclusive of the Ubuntu LTSs.
Make some guards so you can still use these on the newer
Boosts with some us
e )
> > > +if( item && ii.galType == canvasType )
> > > item->Check( true );
> > > }
> > > }
> >
> > I think that this is the same as [1] that John is working on. Are you using
> > GTK3?
> >
> > [1]https://bugs.launchpad.net/kicad/+bug/1809997
&g
Sorry - forwarding to the list. That's what happens when I do emails too late!
-- Forwarded message -
From: Andrew Lutsenko
Date: Fri, Jan 4, 2019 at 12:50 AM
Subject: Re: [Kicad-developers] [RFC] Symbol library file format
To: John Beard
Sorry, link to github:
https
Note, this bug can only be triggered if you do have Lemon installed. Otherwise
the grammar.c file is just another file.
So make clean is safe unless you have lemon installed!
Cheers,
John
On 23 December 2018 21:32:50 GMT, John Beard wrote:
>Hi,
>
>It seems "make clean" m
I agree. The important thing is what is in the file. If nothing else, S-exp is
a concise way to express this concept during development. Exact format
representation in disk is, right now, bikeshedding.
When we get to that stage, all that is required is that the format is VCS
friendly and human
Hi Frank,
There is no trivial way to test this right now, but I could probably
whip up a quick test program in the next week or so. The DRC code is
poorly exposed for instrumentation, so it might be a little bit tricky
without a little refactor (or hack) first! I imagine a dummy set of
several
https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
From e2045e82720d145a23af0e9de538173d56cdb831 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Wed, 2 Jan 2019 01:05:32 +
Subject: [PATCH] Docs: Fix doxygen links
Doxygen is now at: http://w
Hi Frank,
D'oh, of course, they're right there! Sorry for overlooking that!
I doubt either of these would produce radically slower DRC time,
though you might *perhaps* notice it if *all* components got "fancy"
courtyards. Really, the only thing to do if concerned is benchmark it.
It's probably
Hi,
Disclaimer: I'm saying this all from a position of total ignorance on
the actual benchmarked cost of these computations (premature
optimisation and all that...), or even how the DRC does it.
I think most real components are easy: rects or circles. Generic
polygon collision tests are the
Hi,
There is also a description of how you would write a tool in the development
documentation:
http://docs.kicad-pcb.org/doxygen/md_Documentation_development_tool-framework.html
As Thomas said, there is no pluggable C++ interface for plugins. Part of the
reason for this is that C++ does not
his is deemed a good idea, then at least io_benckmark and the rest
of /tools could probably be swept up into this one. Plus any fuzz
testers of libcommon code.
Cheers,
John
From 321e15082b6b7a2bdcd901510ec8b54433cd6fc2 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Mon, 24 Dec 2018 14:16:20 +
p.launchpad.net/ListHelp
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net
On Wed, Dec 19, 2018 at 7:40 PM Seth Hillbrand wrote:
>
> Am 2018-12-19 10:19, schrieb John Beard:
> > Sorry, I failed to rebase that over the newest changes. This should
> > apply better as a patch.
>
> Hi John-
>
> Thanks for the really useful test harness. I'll ha
Sorry, I failed to rebase that over the newest changes. This should
apply better as a patch.
Cheers,
John
On Wed, Dec 19, 2018 at 3:15 PM John Beard wrote:
>
> Hi,
>
> I've added a few simple cases to the qa_common unit tests.
>
> I don't know if I will have covered case
___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
From af0b16e8fade7630582fa23ba3dbedca1d09c
physically can't
depend on it. This isn't true for an ifdef, which can merrily lop out code when
forgotten.
Cheers,
John
On 17 December 2018 19:10:45 GMT, John Beard wrote:
>Hi Wayne,
>
>Absolutely. That's one of the reasons to keep them in a separate file
>and make them read onl
ese features are no longer run
>time options. As long as it's kept up to date, I'm fine with merging
>it. Anyone else have any objections or concerns?
>
>Cheers,
>
>Wayne
>
>On 12/17/2018 12:47 PM, John Beard wrote:
>> Hi Wayne,
>>
>> Booleans are set as &quo
> C:\Users\wstambaugh\AppData\Roaming\kicad\kicad_advanced
> [1588] (KICAD_ADVANCED_CONFIG) AllowLegacyCanvasInGtk3: false
>
> I don't see the EnableSvgImport option and the AllowLegacyCanvasInGtk3
> option is being read as false when it's set to true in the
> kicad_advanced file. Am I doi
Whoops: the 16kB 0001 patch should not be there, that's a very old draft!
Sorry,
John
On Thu, Dec 13, 2018 at 12:57 PM John Beard wrote:
>
> Hi,
>
> This is a patch for run time options, which are a more flexible alternative
> to compiler flags. Advantages include:
>
legacy canvas on GTK3.
Again, this is done at run-time to avoid conditionally compiling code.
Cheers,
John
From 149eaafc2b9dc8fc453b73d8ffb76cc4206311fe Mon Sep 17 00:00:00 2001
From: John Beard
Date: Mon, 10 Dec 2018 10:56:28 +
Subject: [PATCH] Run-time config for advanced options
This can
Hi Wayne,
I can take a look at doing that. I'm on gtk3, so it's easy to check.
On that note, how many people are actually using gtk3 for actual designs? I
know I am, but I've been stuck with fallback for a while due to lagging, which
I think is likely fixed now with the event stuff, but I
to
become supported, it should be given UI and put into the existing
config files. Perhaps any set advanced config should be included in
the version info dump.ki
Cheers,
John
From a38059bc60daec5af906b85830b6ed6b74234ee6 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Tue, 4 Dec 2018 13:48:47 +00
No attachment went though, so here's a better video:
https://sendvid.com/lrzgrdmf
Cheers,
John
On Wed, Nov 28, 2018 at 4:36 PM John Beard wrote:
>
> Hi Wayne,
>
> It is not a replacement for the existing doxygen docs, which are
> unaffected by this patch.
>
> This pa
a big fan of using pip on a system that uses a
> package manager. Is doxytag2zealdb packages for any distros? I would
> like a better picture of what this brings to the table and the
> availability of any dependencies before I commit it.
>
> Cheers,
>
> Wayne
>
> On
this available as a CMake target makes it much more accessible
to other developers to maintain the grammar. Tests allow to ensure
behaviour is not changed when not expected.
Cheers,
John
From 7feb9a01589a71d0a26bff6f58e221988b7aae35 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Wed, 28 Nov 2018 13
d.xml
From 12e3406c080d96a3dd1195c7c402832eab390145 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Mon, 26 Nov 2018 21:14:21 +
Subject: [PATCH] Docs: add docset generation target
This is a CMake (non-ALL) target that will build a Zeal-compatible
docset from a version of the doxygen HTML.
To do this, doxytag2ze
invoke a re-link anyway!
Cheers,
John
From 5dc15d908b875e6dbe22a81a5d115d285f812e0e Mon Sep 17 00:00:00 2001
From: John Beard
Date: Mon, 26 Nov 2018 16:25:12 +
Subject: [PATCH] Document tracemask strings and add note in testing.md
Also make the examples in the testing.md docs self-consisten
Hi,
Having just found the trace_helpers header (which I totally missed
when making a list of the trace strings...), I have a couple of ideas.
First: is there milage to add the strings to the trace variable docs?
This means you can easily see what you should be writing in WXTRACE
without having
Hi Wayne, Seth,
Here is the patchset with:
* A default ctor param and get/setters
* Trace mask in the header. I somehow haven't noticed this file before, sorry!
Cheers,
John
On Sun, Nov 25, 2018 at 9:35 PM Wayne Stambaugh wrote:
>
> Hey John,
>
> On 11/23/2018 8:26 AM, John
is
> supposed to fire an action.
>
> Cheers,
> Orson
>
> On 11/21/18 11:15 AM, John Beard wrote:
> > Hi,
> >
> > A little technical query provoked by someone else's question, which I
> > was unable to answer.
> >
> > Say one wanted to add a global
;Am 2018-11-23 08:26, schrieb John Beard:
>> Hi,
>>
>> This is a patch to refactor the zooming of WX_VIEW_CONTROL. This is
>> related to lp:1786515 [1], but it's not a fix, it's just a refactor
>to
>> help debug the problem, and also tidy the code.
>
>Hi John-
glib stuff on GTK3 [2], but it should be harmless, and doing the
teardown keeps valgrind happier.
Cheers,
John
[1]: https://bugs.launchpad.net/kicad/+bug/1786515
[2]: http://trac.wxwidgets.org/ticket/18274
From 86529229172eab9af7cacbc0508d784cd058bccd Mon Sep 17 00:00:00 2001
From: John Beard
Hi,
A little technical query provoked by someone else's question, which I
was unable to answer.
Say one wanted to add a global mouse shortcut, for example, double
middle-click to do "zoom-to-fit" [1].
The current mouse events are handled on a contextual basis in the
event loops for each tool.
re the fp-info-cache files should be added to the
> > .gitignore file but Jeff would know for sure. I ignore them for my
> > projects without any issues.
> >
> >
> > On 11/12/2018 7:09 AM, John Beard wrote:
> >> Hi,
> >>
> >> Any time I open a demo projec
Hi,
Any time I open a demo project in the source tree, I get fp-info-cache
files in the source tree, which are not .gitignore'd. These clutter
the git working copy up a bit.
Should these files either be created and committed (and kept up to
date when the demos change), or added to the .gitignore
On Fri, Nov 9, 2018 at 1:40 PM Mário Luzeiro wrote:
>
> Thanks, it's clear as mud!
> I guess next time I will take as option to do a proper initialization element
> by element in a WYSIWYG fashion ;)
>
> ____
> From: John Beard
> Sent: 0
"C programmer" I
> was at the time..
> Is the "= {}" initialization available on all C++ versions?
>
> Mario Luzeiro
>
> ____
> From: Kicad-developers
> on behalf of
> John Beard
> Sent: 09 November 2018 12:20:01
> To:
From: John Beard
Date: Fri, 9 Nov 2018 11:58:38 +
Subject: [PATCH] Don't use memset to initialise aggregate of floats.
In C3D_RENDER_OGL_LEGACY::setupMaterial(), the struct
m_materials (which is made up of floats and glm::vec3f's)
is initialised with a memset to 0. This is unsafe, as
floating
55291844ba480c552201fac9b0 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Wed, 7 Nov 2018 13:55:20 +
Subject: [PATCH 1/2] QA: Make a separate unit test utils library, COLOR4D
tests
This includes:
* Linkage against the Boost unit test libs
* Configuration of the Boost libs
* A place f
Forwarding to the list (sorry!).
-- Forwarded message -
From: John Beard
Date: Thu, Nov 8, 2018 at 12:09 PM
Subject: Re: [Kicad-developers] [PATCH]/Question TITLE_BLOCK tests
To: Wayne Stambaugh
Hi Wayne,
Coming back to this now the fuzzing stuff seems to have settled
will need to be undone when
legacy_wx is removed).
Cheers,
John
From 04b3153d78614eb4617f3cf70b07ea1eae483a61 Mon Sep 17 00:00:00 2001
From: John Beard
Date: Wed, 7 Nov 2018 11:34:12 +
Subject: [PATCH 1/2] Include directories are implied by legacy_gal linkage
This avoids having to manually
t in C++14.
Cheers,
John
[1]: https://github.com/g-truc/glm/issues/832
On Tue, Nov 6, 2018 at 3:25 PM Wayne Stambaugh wrote:
>
> It also breaks msys2/mingw32/mingw64 builds. :(
>
> On 11/6/2018 9:19 AM, John Beard wrote:
> > Hi,
> >
> > Just a quick word of caution:
Hi,
Just a quick word of caution: I can can't get KiCad to build with glm
version 0.9.9.3, which was updated yesterday.
The responsible change in glm appears to be 68c7e7e50 [1], which deals
with constexprs in GCC. There are various errors in the 3d-viewer [2].
However, I am not sure if this is
Gah! Wrong patch! Try this.
On Mon, Nov 5, 2018 at 2:43 PM Steven A. Falco wrote:
>
> On 11/5/18 5:24 AM, John Beard wrote:
> > Hi,
> >
> > This appears to be because something in the build is setting the CMake
> > BUILD_SHARED_LIBS option to ON (the default is not
ke[2]: ***
> [tools/io_benchmark/CMakeFiles/io_benchmark.dir/build.make:99:
> tools/io_benchmark/io_benchmark] Error 1
> BUILDSTDERR: make[2]: ***
> [tools/io_benchmark/CMakeFiles/io_benchmark.dir/build.make:99:
> tools/io_benchmark/io_benchmark] Error 1
>
> Steve
Hi Wayne,
On Mon, Oct 29, 2018 at 6:16 PM Wayne Stambaugh wrote:
>
> Patches 2 and 3 are merged. I merge the fixed patch when you post it.
Freshly Jenkins'ed for your consideration.
Cheers,
John
From be91dac4227ee6cce6e3188b3b8aebabfaa5efda Mon Sep 17 00:00:00 2001
From: John Beard
go ahead and merge patches 2 and 3 since they are
>just
>documentation changes?
>
>Cheers,
>
>Wayne
>
>On 10/29/2018 10:38 AM, John Beard wrote:
>> Hi,
>>
>> Just a couple of tweaks to the io_benchmark, including a baseline
>> in-memory string-based stre
On Mon, Oct 29, 2018 at 3:33 PM Wayne Stambaugh wrote:
>
> The parser (at least the pcb parser I wrote) can be used a parse only
> tool. I cannot speak about the other file format parsers but hopefully
> the authors provided low level parse only functionality for testing
> purposes. If not, I'm
On Mon, Oct 29, 2018 at 2:44 PM Wayne Stambaugh wrote:
>
> The PLUGIN object is very much designed for handling files on a per
> plugin basis. The files could be on the local file system, Github, or a
> compressed archive but they are still files.
Hmm, then maybe I'm thinking on the wrong level
Hi,
Just a couple of tweaks to the io_benchmark, including a baseline
in-memory string-based streams, and some other dev-doc stuff that was
conflicting with the fuzzing docs.
Cheers,
John
From 68955bbcb90c5fc12e4f3a61b6d7df8a2541c64b Mon Sep 17 00:00:00 2001
From: John Beard
Date: Mon, 8 Oct
Hi,
I have a question about the PLUGIN interface. Currently, the board
loader looks like this:
BOARD* Load( const wxString& aFileName, BOARD* aAppendToMe, const
PROPERTIES* aProperties )
This means that it's quite difficult to use these methods in-process,
as you have to write out to file
On Wed, Oct 24, 2018 at 4:21 PM Wayne Stambaugh wrote:
>
> Does this mean that I do not have to merge 0001-CMake-tools-after-qa.patch?
Correct. That patch does *not* need to be merged. master currently
appears to build correctly.
> I'm wondering if it be more prudent to just move the
( polygon_triangulation )
# add_subdirectory( polygon_generator )
So whatever was previously broken there is no longer even built on any
platform, and thus doesn't break the build.
Cheers,
John
On Wed, Oct 24, 2018 at 12:48 PM John Beard wrote:
>
> Hi all,
>
> There's also (groan) an MSVC
: https://launchpad.net/~kicad-developers
>> More help : https://help.launchpad.net/ListHelp
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : http
Thanks, Wayne! Sorry for all the drama with it. Hopefully I can learn
from it for the libcommon tests.
Cheers,
John
On Mon, Oct 22, 2018 at 6:14 PM Wayne Stambaugh wrote:
>
> It's merged. Thanks John.
>
> On 10/22/2018 1:09 PM, John Beard wrote:
> > Hi Wayne,
> >
>
e a way to set this up in git where you can run clang-format on
> demand rather than using --no-verify to ignore the hook? I don't know
> if I want to force this on developers so it would be nice if it would
> only be run when requested.
>
> Cheers,
>
> Wayne
>
>
,
John
On Mon, Oct 22, 2018 at 5:45 PM Wayne Stambaugh wrote:
>
> Hey John,
>
> Finally! That was easy. I'm guessing this is ready to merge or is
> there anything else that needs to be done?
>
> Cheers,
>
> Wayne
>
> On 10/22/2018 12:19 PM, John Beard wrote:
> &g
its; std::ios_base::openmode = std::_Ios_Openmode]'
>open(const wchar_t* __s, ios_base::openmode __mode = ios_base::in)
>^~~~
>
> On 10/22/2018 4:57 AM, John Beard wrote:
> > Hi Wayne,
> >
> > Since I'm out of better ideas and can't replicate the link fa
,
John
On Fri, Oct 19, 2018 at 12:09 PM John Beard wrote:
>
> Hi Wayne,
>
> That's pretty odd, the incantations are practically the same.
>
> The only other difference between this and the other pcb-based
> programs is this line:
>
> add_dependencies( pnsrou
John
From 7221522aebba949446979437f55de1995e936c4b Mon Sep 17 00:00:00 2001
From: John Beard
Date: Fri, 19 Oct 2018 14:36:03 +0100
Subject: [PATCH] Add git format commit hook
This adds a pre-commit hook to warn of any style errors.
Also adds a 'hook-chain' script to simplify future hooks.
Add de
e_input.dir/build.make:163:
> qa/pcb_parse_input/qa_pcb_parse_input.exe] Error 1
> make[2]: Leaving directory '/home/wstambaugh/build32/kicad/trunk-release'
> make[1]: *** [CMakeFiles/Makefile2:3431:
> qa/pcb_parse_input/CMakeFiles/qa_pcb_parse_input.dir/all] Error 2
> make[1]: Le
Hi,
This is what I was getting at.
If outright disabling of the legacy canvas (with or without the cull
of associated code) is not desirable for 5.1, is it feasible to switch
the legacy_wx canvas to legacy_gal in pcbnew, so the options are then
"GAL canvas+legacy tools" and "GAL canvas+new
.
Cheers,
John
Cheers,
John
On 18 October 2018 19:44:33 BST, s...@hillbrand.org wrote:
>On 2018-10-18 06:22, John Beard wrote:
>> Hi Seth,
>>
>> I noticed in that commit some test data to tools/utf8_test.cpp.
>> However, the "Utf8AndWx" test case in q
Hi Wayne,
Sounds good! What's the plan for the WX legacy canvases? Pcbnew,
gerbview, cvpcb and pl_editor still use the WX canvas in legacy tool
mode (but also have GAL canvas+tool framework), whereas eeschema has a
GAL canvas and legacy tools.
I know we're not planning to remove the legacy tool
baugh
wrote:
> Hey John,
>
> Does this patch need to be merged? It looks a though it should be as it
> would be useful for testing the UTF8 object.
>
> Cheers,
>
> Wayne
>
> On 10/18/2018 6:22 AM, John Beard wrote:
> > Hi Seth,
> >
> > I n
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
From b4bebf1347fc94ebfe1ed258c6a9fe99bdf6651d
1]: *** Waiting for unfinished jobs
>[100%] Built target pcbnew_kiface
>make: *** [Makefile:141: all] Error 2
>
>
>On 10/16/2018 9:28 AM, John Beard wrote:
>> Hi Wayne,
>>
>> I think I might have fixed the ordering in the link libraries (at
>> least, it now
then, ctrl+',' is the best choice in my opinion because it
>adversely affect the fewest number of people.
>
>
>
>On 17/10/2018 11:00 AM, John Beard wrote:
>> Hi,
>>
>> I'd suggest perhaps Ctrl-Shift-P, which is used by Inkscape. P with
>> various modifiers is
101 - 200 of 465 matches
Mail list logo
