[PATCH 6/6] exa: fix a serious issue in exaChangeWindowAttributes (and some more related things)

2009-03-03 Thread Maarten Maathuis
- fbChangeWindowAttributes can create pixmaps (and access them) without use preparing access. - Also handle the destroyed pixmaps by finishing them first. - Switch to DEST indices again in exaCreatePixmapWithPrepare, because they are obviously being rendered to. - Also avoid calling FinishAccess

[PATCH 1/6] exa: simplify exaPixmapIsOffscreen

2009-03-02 Thread Maarten Maathuis
- This includes properly handling the framebuffer. --- exa/exa.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index 994a67a..f4fba57 100644 --- a/exa/exa.c +++ b/exa/exa.c @@ -73,8 +73,9 @@ unsigned long

[PATCH 2/6] exa: increase/rework safety checks in Prepare/FinishAccess.

2009-03-02 Thread Maarten Maathuis
--- exa/exa.c | 76 exa/exa.h |5 +++ exa/exa_priv.h |4 +++ 3 files changed, 69 insertions(+), 16 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index f4fba57..f935d38 100644 --- a/exa/exa.c +++ b/exa/exa.c @@ -450,15

[PATCH 5/6] exa: avoid a potential Prepare/FinishAccess inbalance.

2009-03-02 Thread Maarten Maathuis
--- exa/exa_unaccel.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/exa/exa_unaccel.c b/exa/exa_unaccel.c index d16ecf7..4279c87 100644 --- a/exa/exa_unaccel.c +++ b/exa/exa_unaccel.c @@ -405,7 +405,7 @@ ExaCheckComposite (CARD8 op, if

Re: [PATCH 2/6] exa: clean up some more code

2009-03-01 Thread Maarten Maathuis
The reason for this entire patchset was to make everything more strict. That's okay in principle, but note that e.g. we only wrap CreatePixmap (and allocate an ExaPixmapPriv) if the driver sets the EXA_OFFSCREEN_PIXMAPS flag... How that does that work anyway, acceleration without

Re: [PATCH 2/6] exa: clean up some more code

2009-03-01 Thread Maarten Maathuis
On Sun, Mar 1, 2009 at 12:18 PM, Maarten Maathuis madman2...@gmail.com wrote: lx_driver.c and gx_driver.c set the flag. The question now is, is the mode even useful? Maarten. Correction is !OFFSCREEN_PIXMAPS useful? Sorry for not replying to the list (again). Maarten

[PATCH 2/6] exa: clean up some more code

2009-03-01 Thread Maarten Maathuis
--- exa/exa.c | 53 +++-- exa/exa.h |5 + 2 files changed, 44 insertions(+), 14 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index f4fba57..95f101f 100644 --- a/exa/exa.c +++ b/exa/exa.c @@ -450,15 +450,28 @@

[PATCH 3/6] exa: same treatment for FinishAccess.

2009-03-01 Thread Maarten Maathuis
--- exa/exa.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index 95f101f..37b7f74 100644 --- a/exa/exa.c +++ b/exa/exa.c @@ -629,10 +629,14 @@ exaFinishAccess(DrawablePtr pDrawable, int index) PixmapPtr pPixmap =

Re: [PATCH 2/6] exa: clean up some more code

2009-03-01 Thread Maarten Maathuis
It seems that sometimes (around VT switch) something undesirable does happen (the FatalError is triggered), will have to do some more hunting to see where it's coming from. Maarten. ___ xorg-devel mailing list xorg-devel@lists.x.org

[PATCH 1/6] exa: simplify exaPixmapIsOffscreen

2009-02-28 Thread Maarten Maathuis
- This includes properly handling the framebuffer. --- exa/exa.c | 19 --- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index 994a67a..b0a26e9 100644 --- a/exa/exa.c +++ b/exa/exa.c @@ -424,6 +424,13 @@ exaModifyPixmapHeader(PixmapPtr

[PATCH 3/6] exa: same treatment for FinishAccess.

2009-02-28 Thread Maarten Maathuis
--- exa/exa.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index 17d75d2..7501b65 100644 --- a/exa/exa.c +++ b/exa/exa.c @@ -607,10 +607,11 @@ exaFinishAccess(DrawablePtr pDrawable, int index) PixmapPtr pPixmap =

[PATCH 4/6] exa: fix unwrapping of ModifyPixmapHeader upon CloseScreen.

2009-02-28 Thread Maarten Maathuis
- Cleanup wrapping too. --- exa/exa.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index 7501b65..81c874b 100644 --- a/exa/exa.c +++ b/exa/exa.c @@ -933,6 +933,8 @@ exaCloseScreen(int i, ScreenPtr pScreen) unwrap(pExaScr, pScreen,

[PATCH 5/6] exa: remove a few pExaPixmap checks and turn others in FatalErrors.

2009-02-28 Thread Maarten Maathuis
--- exa/exa_migration.c | 28 +--- 1 files changed, 9 insertions(+), 19 deletions(-) diff --git a/exa/exa_migration.c b/exa/exa_migration.c index 8b91150..e7c73f8 100644 --- a/exa/exa_migration.c +++ b/exa/exa_migration.c @@ -52,7 +52,10 @@ exaPixmapIsPinned (PixmapPtr

[PATCH 6/6] exa: avoid a potential Prepare/FinishAccess inbalance.

2009-02-28 Thread Maarten Maathuis
--- exa/exa_unaccel.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/exa/exa_unaccel.c b/exa/exa_unaccel.c index d16ecf7..4279c87 100644 --- a/exa/exa_unaccel.c +++ b/exa/exa_unaccel.c @@ -405,7 +405,7 @@ ExaCheckComposite (CARD8 op, if

Re: [Nouveau] [PATCH 2/2] exa: do PrepareAccess for classic too, since we do need to map the frontbuffer.

2009-02-27 Thread Maarten Maathuis
You're confusing issues, yours is a performance issue, not a correctness issue. Maarten. On Fri, Feb 27, 2009 at 11:07 AM, Hervé Cauwelier herve.cauwel...@free.fr wrote: Ben Skeggs a écrit : On Thu, 2009-02-26 at 21:55 +0100, Maarten Maathuis wrote: - I'm surprised we didn't get serious

Re: [PATCH] 64-bit issues in libx11

2009-02-21 Thread Maarten Maathuis
Committed as http://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=da6bbca07c796c69172a649405474f03bee66754 Please provide git patches in the future (it's easier for both sides). Maarten. On Fri, Feb 20, 2009 at 3:10 AM, Emilio Jesús Gallego Arias egall...@babel.ls.fi.upm.es wrote: It seems

Re: [PATCH] 64-bit issues in libx11

2009-02-20 Thread Maarten Maathuis
While we're on this subject, i have a question as well (same file, line 175). if(event) widen(event_sequence, event-full_sequence); What purpose does that serve? Maarten. ___ xorg mailing list xorg@lists.freedesktop.org

Re: openSUSE 11.1 and Intel graphics chip

2009-02-19 Thread Maarten Maathuis
Maybe try the http://lists.freedesktop.org/mailman/listinfo/intel-gfx list? Maarten. ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg

[PATCH] client: fix client_setborder

2009-02-19 Thread Maarten Maathuis
- Don't know why I didn't do this correctly in the first place :-| --- client.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/client.c b/client.c index e17951d..894e5ef 100644 --- a/client.c +++ b/client.c @@ -1261,15 +1261,15 @@ client_setborder(client_t *c, int

Re: [PATCH] exa: fix performance regression from 736b6fbd2c941b6276066cd1503523edebe7bf3d

2009-02-16 Thread Maarten Maathuis
+ * as valid is a natural defragmention of the region. I've fixed this typo locally. Maarten. ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 2/7] event: handle border size changes in configurerequest

2009-02-15 Thread Maarten Maathuis
--- event.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/event.c b/event.c index f4bfd63..cd26821 100644 --- a/event.c +++ b/event.c @@ -291,6 +291,9 @@ event_handle_configurerequest(void *data __attribute__ ((unused)), if(ev-value_mask

[PATCH 4/7] event: small code harmonisation.

2009-02-15 Thread Maarten Maathuis
--- event.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/event.c b/event.c index 2def556..944c241 100644 --- a/event.c +++ b/event.c @@ -427,12 +427,12 @@ event_handle_motionnotify(void *data __attribute__ ((unused)),

[PATCH 5/7] placement: allow centering on a parent.

2009-02-15 Thread Maarten Maathuis
- Typical usecase awful.placement.centered(c, c.transient_for). --- lib/awful/placement.lua.in | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/awful/placement.lua.in b/lib/awful/placement.lua.in index 7a6b7c2..debbe89 100644 --- a/lib/awful/placement.lua.in

[PATCH 6/7] screen: replace need_arrange with a reference counted mechanism.

2009-02-15 Thread Maarten Maathuis
- This is needed to properly process certain changes triggered by arrange, that need yet another arrange. --- client.h |6 +++--- layout.c | 10 -- screen.c |9 ++--- structs.h |4 ++-- tag.c |6 -- titlebar.c |3 ++- wibox.c|9 ++---

[PATCH 7/7] client: remove a few useless client_need_arrange().

2009-02-15 Thread Maarten Maathuis
--- client.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/client.c b/client.c index 612627b..eaa3171 100644 --- a/client.c +++ b/client.c @@ -800,7 +800,6 @@ client_setminimized(client_t *c, bool s) { if(c-isminimized != s) { -

Re: [PATCH] EXA: Try to prevent the valid regions from growing too many rects.

2009-02-14 Thread Maarten Maathuis
On Sat, Feb 14, 2009 at 2:28 PM, Michel Dänzer mic...@daenzer.net wrote: +/* Try to prevent source valid region from growing too many rects */ +if (REGION_NUM_RECTS(pValidSrc) 10) + REGION_SUBTRACT(pScreen, pValidSrc, pValidSrc, pValidDst); You're removing the valid dst region

Re: [PATCH] EXA: Try to prevent the valid regions from growing too many rects.

2009-02-14 Thread Maarten Maathuis
Maybe remove the smallest rects, but i think i get your point. It just seemed odd at first, now i see you're just using a convient area to remove. Maarten. ___ xorg-devel mailing list xorg-devel@lists.x.org http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 1/5] event: Actually modify ev-x and ev-y for banned clients.

2009-02-14 Thread Maarten Maathuis
--- event.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/event.c b/event.c index 57886c1..f4bfd63 100644 --- a/event.c +++ b/event.c @@ -295,8 +295,8 @@ event_handle_configurerequest(void *data __attribute__ ((unused)), { /* We'll be sending

[PATCH 3/5] event: block stacking related changes in configurerequest.

2009-02-14 Thread Maarten Maathuis
--- event.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/event.c b/event.c index cd26821..2def556 100644 --- a/event.c +++ b/event.c @@ -294,6 +294,10 @@ event_handle_configurerequest(void *data __attribute__ ((unused)), if (ev-value_mask

[PATCH 4/5] event: small code harmonisation.

2009-02-14 Thread Maarten Maathuis
--- event.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/event.c b/event.c index 2def556..944c241 100644 --- a/event.c +++ b/event.c @@ -427,12 +427,12 @@ event_handle_motionnotify(void *data __attribute__ ((unused)),

[PATCH 5/5] placement: allow centering on a parent.

2009-02-14 Thread Maarten Maathuis
- Typical usecase awful.placement.centered(c, c.transient_for). --- lib/awful/placement.lua.in | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/awful/placement.lua.in b/lib/awful/placement.lua.in index 7a6b7c2..debbe89 100644 --- a/lib/awful/placement.lua.in

Re: [Nouveau] [PATCH 3/3] nv50: support frontbuffer fallbacks

2009-02-13 Thread Maarten Maathuis
These patches are workarounds, and therefore will not be applied to git. I made them out of curiosity. Maarten. On Fri, Feb 13, 2009 at 10:19 AM, Hervé Cauwelier herve.cauwel...@free.fr wrote: Maarten Maathuis a écrit : [snip] I can't tell you about the technical quality of this patch

[Nouveau] [PATCH 1/3] exa: add nouveau_exa_pixmap_is_tiled

2009-02-12 Thread Maarten Maathuis
--- src/nouveau_exa.c | 19 +++ src/nv50_exa.c|6 +++--- src/nv50_xv.c |5 + src/nv_proto.h|1 + 4 files changed, 20 insertions(+), 11 deletions(-) diff --git a/src/nouveau_exa.c b/src/nouveau_exa.c index a947a31..3babfd7 100644 ---

[Nouveau] [PATCH 2/3] nv50: initial bits for shadowfb

2009-02-12 Thread Maarten Maathuis
(nv_crtc-crtc, x, y); } nv_crtc-crtc-ModeSet(nv_crtc-crtc, mode); diff --git a/src/nv50_shadow_damage.c b/src/nv50_shadow_damage.c new file mode 100644 index 000..9d1a8cb --- /dev/null +++ b/src/nv50_shadow_damage.c @@ -0,0 +1,164 @@ +/* + * Copyright 2009 Maarten Maathuis

[Nouveau] [PATCH 3/3] nv50: support frontbuffer fallbacks

2009-02-12 Thread Maarten Maathuis
--- src/nouveau_exa.c| 36 +++ src/nv50_shadow_damage.c | 108 ++ src/nv_proto.h |1 + 3 files changed, 145 insertions(+), 0 deletions(-) diff --git a/src/nouveau_exa.c b/src/nouveau_exa.c index c4cafb0..b6ae8ca

Re: [Nouveau] [PATCH 2/3] nv50: initial bits for shadowfb

2009-02-12 Thread Maarten Maathuis
On Fri, Feb 13, 2009 at 12:11 AM, Stephane Marchesin marche...@icps.u-strasbg.fr wrote: On Thu, Feb 12, 2009 at 23:56, Maarten Maathuis madman2...@gmail.com wrote: - Fallbacks on the frontbuffer still need to be handled. --- Why are you posting this again ? It's not really better than

Re: [PATCH 8/9] fb: move some code to mi

2009-02-11 Thread Maarten Maathuis
commit 734b23e5982e171031077a2d5d6b5dc2a12e1a70 should fix the problem. Maarten. ___ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg

Re: [Patch] client.c: remove UrgencyHint flag on focus

2009-02-11 Thread Maarten Maathuis
On Wed, Feb 11, 2009 at 3:36 PM, Gregor Best farha...@googlemail.com wrote: Hi people, the attached patch removes the UrgencyHint flag from a client if it gets focused. This is to comply with the EWMH specs which say it's the window managers job to care for removal of that hint. --

Re: [Patch] client.c: remove UrgencyHint flag on focus

2009-02-11 Thread Maarten Maathuis
property_update_wm_hints is not a set function, but a get function, my bad. You can probably leave out that call. Strange thing is that property_update_wm_hints() is only called upon manage, which suggests it doesn't even work atm for windows that enable this hint. But that should be fixed (if

Re: [Patch] client.c: remove UrgencyHint flag on focus

2009-02-11 Thread Maarten Maathuis
/* execute hook */ hooks_property(c, urgent); This needs to go into the function i think. Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [Patch] client.c: remove UrgencyHint flag on focus

2009-02-11 Thread Maarten Maathuis
Either way i think, as long as there is change. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [PATCH 8/9] fb: move some code to mi

2009-02-10 Thread Maarten Maathuis
I'll wait a bit to see what the preferred solution is, but i see three options atm. - A wrapper function in fbcopy.c - A define in fb.h, silently converting fbFoo into miFoo - User side fixes Maarten. ___ xorg mailing list xorg@lists.freedesktop.org

[PATCH 2/2] client: fix titlebar stacking

2009-02-10 Thread Maarten Maathuis
--- client.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/client.c b/client.c index 51bebd9..758bd09 100644 --- a/client.c +++ b/client.c @@ -314,7 +314,11 @@ client_stack_above(client_t *c, xcb_window_t previous) {

[PATCH 1/2] client: add above and below to capi + related fixes

2009-02-10 Thread Maarten Maathuis
--- client.c | 36 common/tokenize.gperf |2 ++ 2 files changed, 38 insertions(+), 0 deletions(-) diff --git a/client.c b/client.c index 92c64d5..51bebd9 100644 --- a/client.c +++ b/client.c @@ -792,6 +792,10 @@

[PATCH 1/2] client: fix titlebar stacking

2009-02-10 Thread Maarten Maathuis
--- client.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/client.c b/client.c index d14f290..7186f09 100644 --- a/client.c +++ b/client.c @@ -312,9 +312,8 @@ client_stack_above(client_t *c, xcb_window_t previous) node; node = node-prev)

Re: [PATCH] client: add above and below to capi + related fixes

2009-02-09 Thread Maarten Maathuis
On Mon, Feb 9, 2009 at 10:40 AM, Julien Danjou jul...@danjou.info wrote: At 1234133730 time_t, Maarten Maathuis wrote: Ack; I think we miss the EWMH function behind that? above, below and fullscreen are exposed in the emwh, and those functions call ewmh_client_update_hints(). I don't get what

[PATCH 1/5] client: implement client struts in the capi.

2009-02-08 Thread Maarten Maathuis
--- client.c | 71 +++- ewmh.c | 28 ++- ewmh.h |3 +- property.c |2 +- 4 files changed, 99 insertions(+), 5 deletions(-) diff --git a/client.c b/client.c index ba4b1cf..22cbbd2 100644 ---

[PATCH 2/5] mouse: allow utility, toolbar and dock windows to snap to the edge of the window

2009-02-08 Thread Maarten Maathuis
--- lib/awful/mouse.lua.in | 44 +--- 1 files changed, 41 insertions(+), 3 deletions(-) diff --git a/lib/awful/mouse.lua.in b/lib/awful/mouse.lua.in index aff565a..0c85b7d 100644 --- a/lib/awful/mouse.lua.in +++ b/lib/awful/mouse.lua.in @@ -64,17 +64,22

[PATCH 3/5] client: client_isvisible_exclude_banned() isn't needed anymore.

2009-02-08 Thread Maarten Maathuis
--- client.h | 20 layout.c |2 +- 2 files changed, 5 insertions(+), 17 deletions(-) diff --git a/client.h b/client.h index 58eb08f..77c4cf1 100644 --- a/client.h +++ b/client.h @@ -41,7 +41,7 @@ DO_RCNT(client_t, client, client_delete) #define client_need_arrange(c)

[PATCH 4/5] client: change border handling slightly + remove some old cruft

2009-02-08 Thread Maarten Maathuis
--- client.c | 15 ++- screen.c |8 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/client.c b/client.c index 22cbbd2..9fedca0 100644 --- a/client.c +++ b/client.c @@ -475,8 +475,9 @@ client_manage(xcb_window_t w, xcb_get_geometry_reply_t *wgeom, int

[PATCH 5/5] event: fix configurerequest

2009-02-08 Thread Maarten Maathuis
- We have to be careful with geometry around protocol code. --- client.c |9 +++-- client.h |2 +- event.c | 27 ++- 3 files changed, 18 insertions(+), 20 deletions(-) diff --git a/client.c b/client.c index 9fedca0..c6b804a 100644 --- a/client.c +++

Re: XCopyArea clip bug

2009-02-07 Thread Maarten Maathuis
I comitted a slightly different patch. I found out that all clipping possibilities are converted to regions in the end, so this should be enough. http://cgit.freedesktop.org/xorg/xserver/commit/?id=00226d0b589595cdd45c75e7e28237334a8883b1 You can put the patch on the wiki

[PATCH] titlebar: remove some old/unneeded code

2009-02-07 Thread Maarten Maathuis
- This fixes the resize upon titlebar removal issue. --- lib/awful/titlebar.lua.in | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/lib/awful/titlebar.lua.in b/lib/awful/titlebar.lua.in index 5e751c0..0c3b65f 100644 --- a/lib/awful/titlebar.lua.in +++

[PATCH 1/2] client: implement client struts in the capi.

2009-02-07 Thread Maarten Maathuis
--- client.c | 71 +++- ewmh.c | 28 ++- ewmh.h |3 +- property.c |2 +- 4 files changed, 99 insertions(+), 5 deletions(-) diff --git a/client.c b/client.c index ba4b1cf..22cbbd2 100644 ---

some notes about the patches

2009-02-07 Thread Maarten Maathuis
That 2nd patch title should have said, snap to the edge of the screen, not window. The kind of windows we're talking about is gimp's toolbar for example, which tends to be in the way normally, so now you can snap it to the edge of the screen and your tiled clients will adjust. Maarten. -- To

Re: Patch noise [Was: GIT Noise]

2009-02-06 Thread Maarten Maathuis
On Fri, Feb 6, 2009 at 1:21 PM, Igor Mozolevsky i...@hybrid-lab.co.uk wrote: 2009/2/6 Maarten Maathuis: If you were really seeing a duplicate of a git commit list, then you would see a whole different picture. For you patches may just be noise, but that's not the case for everyone. So ok

Re: Patch noise [Was: GIT Noise]

2009-02-06 Thread Maarten Maathuis
On Fri, Feb 6, 2009 at 4:21 PM, Igor Mozolevsky i...@hybrid-lab.co.uk wrote: 2009/2/6 Maarten Maathuis: It gives people time to check, review and/or complain about patches. Now that the xorg-devel list was made, it will obviously move there. I certainly check patches that catch my eye

[PATCH 9/9] exa: don't use fbCopyNtoN

2009-02-06 Thread Maarten Maathuis
--- exa/exa_accel.c | 76 ++-- exa/exa_priv.h| 25 + exa/exa_render.c | 17 +--- exa/exa_unaccel.c | 50 ++ 4 files changed, 149 insertions(+), 19 deletions(-) diff --git

Re: [Nouveau] DRM fills logs

2009-02-06 Thread Maarten Maathuis
Have you tried running the cards separately first? Multi card situations are pretty rare, so it's better to know if they work individually. Maarten. ___ Nouveau mailing list Nouveau@lists.freedesktop.org

Re: [Nouveau] DRM fills logs

2009-02-06 Thread Maarten Maathuis
On Fri, Feb 6, 2009 at 7:50 PM, Yan Seiner y...@seiner.com wrote: On Fri, February 6, 2009 10:49 am, Yan Seiner wrote: On Fri, February 6, 2009 7:13 am, Maarten Maathuis wrote: Have you tried running the cards separately first? Multi card situations are pretty rare, so it's better to know

[PATCH] titlebar: don't resize window when adding titlebar.

2009-02-06 Thread Maarten Maathuis
--- lib/awful/titlebar.lua.in | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/lib/awful/titlebar.lua.in b/lib/awful/titlebar.lua.in index c86d6bf..5e751c0 100644 --- a/lib/awful/titlebar.lua.in +++ b/lib/awful/titlebar.lua.in @@ -117,18 +117,8 @@ function add(c,

[PATCH 1/2] titlebar: don't resize window when adding titlebar.

2009-02-06 Thread Maarten Maathuis
--- lib/awful/titlebar.lua.in | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/lib/awful/titlebar.lua.in b/lib/awful/titlebar.lua.in index c86d6bf..5e751c0 100644 --- a/lib/awful/titlebar.lua.in +++ b/lib/awful/titlebar.lua.in @@ -117,18 +117,8 @@ function add(c,

[PATCH 2/2] client: update client geometry when adding and removing titlebars

2009-02-06 Thread Maarten Maathuis
- This fixes titlebars again. --- titlebar.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/titlebar.c b/titlebar.c index 7fa6e97..d5de3e4 100644 --- a/titlebar.c +++ b/titlebar.c @@ -181,6 +181,8 @@ titlebar_client_detach(client_t *c) /* If client has a

[PATCH 9/9] exa: don't use fbCopyNtoN

2009-02-05 Thread Maarten Maathuis
--- exa/exa_accel.c | 43 --- exa/exa_priv.h| 16 exa/exa_render.c | 17 + exa/exa_unaccel.c | 27 +++ 4 files changed, 84 insertions(+), 19 deletions(-) diff --git a/exa/exa_accel.c

[PATCH 8/9] fb: move some code to mi

2009-02-05 Thread Maarten Maathuis
--- exa/exa_accel.c |4 +- fb/fb.h | 37 -- fb/fbcopy.c | 331 +-- fb/fboverlay.c |2 +- fb/fboverlay.h |2 +- fb/fbwindow.c |2 +- mi/Makefile.am |1 + mi/mi.h | 42 +++ mi/micopy.c |

Re: XCopyArea clip bug

2009-02-05 Thread Maarten Maathuis
On Wed, Feb 4, 2009 at 10:56 PM, Alexander Larsson al...@redhat.com wrote: On Wed, 2009-02-04 at 14:46 +0100, Alexander Larsson wrote: On Wed, 2009-02-04 at 13:38 +0100, Alexander Larsson wrote: I found what I think is a bug in XCopyArea. If you copy a pixmap to a window and some of the

Re: about the exa patches

2009-02-05 Thread Maarten Maathuis
On Thu, Feb 5, 2009 at 7:13 PM, Michel Dänzer mic...@daenzer.net wrote: On Thu, 2009-02-05 at 17:17 +0100, Maarten Maathuis wrote: core glyphs before and after are within an error margin of 1%. Cool, thanks for verifying it. -- Earthling Michel Dänzer |http

[PATCH 9/9] exa: don't use fbCopyNtoN

2009-02-05 Thread Maarten Maathuis
--- exa/exa_accel.c | 77 ++-- exa/exa_priv.h| 25 + exa/exa_render.c | 17 +--- exa/exa_unaccel.c | 51 +++ 4 files changed, 151 insertions(+), 19 deletions(-) diff --git

Re: about the exa patches

2009-02-05 Thread Maarten Maathuis
On Thu, Feb 5, 2009 at 7:28 PM, Michel Dänzer mic...@daenzer.net wrote: On Thu, 2009-02-05 at 19:16 +0100, Maarten Maathuis wrote: On Thu, Feb 5, 2009 at 7:13 PM, Michel Dänzer mic...@daenzer.net wrote: On Thu, 2009-02-05 at 17:17 +0100, Maarten Maathuis wrote: core glyphs before and after

Re: [Nouveau] nouveau xorg.conf documentation

2009-02-05 Thread Maarten Maathuis
On Thu, Feb 5, 2009 at 1:26 PM, Dave Airlie airl...@gmail.com wrote: On Thu, Feb 5, 2009 at 1:16 AM, Maarten Maathuis madman2...@gmail.com wrote: On Wed, Feb 4, 2009 at 3:42 PM, Yan Seiner y...@seiner.com wrote: I'm trying to get started with nouveau. I have it compiled, I have it installed

[PATCH 9/9] exa: fix exaCopyArea and friends.

2009-02-04 Thread Maarten Maathuis
--- exa/Makefile.am |3 ++- exa/exa_accel.c | 44 ++-- exa/exa_priv.h |6 +- exa/exa_render.c| 14 -- exa/exa_unaccel.c | 15 +++ fb/fbcopy_helpers.c |6 +++--- fb/fbcopy_helpers.h | 12

Re: about the exa patches

2009-02-04 Thread Maarten Maathuis
On Wed, Feb 4, 2009 at 8:32 AM, Michel Dänzer mic...@daenzer.net wrote: On Wed, 2009-02-04 at 00:29 +0100, Maarten Maathuis wrote: I hope the changes are coming to an end. I still need to know if there are any external users of fbDoCopy that would care for a wrapper. I'm assuming

[PATCH 6/9] exa: wrap the remainder of exa_unaccel.c

2009-02-03 Thread Maarten Maathuis
--- exa/exa_unaccel.c | 30 +++--- 1 files changed, 27 insertions(+), 3 deletions(-) diff --git a/exa/exa_unaccel.c b/exa/exa_unaccel.c index d56f589..a521497 100644 --- a/exa/exa_unaccel.c +++ b/exa/exa_unaccel.c @@ -290,9 +290,14 @@ ExaCheckGetSpans (DrawablePtr

[PATCH 9/9] exa: fix exaCopyArea and friends.

2009-02-03 Thread Maarten Maathuis
--- exa/Makefile.am |3 ++- exa/exa_accel.c | 44 ++-- exa/exa_priv.h |6 +- exa/exa_render.c| 14 -- exa/exa_unaccel.c | 15 +++ fb/fbcopy_helpers.h |5 + 6 files changed, 69

[PATCH 1/9] exa: Remove one of the many calls directly into the fb layer.

2009-02-03 Thread Maarten Maathuis
--- exa/exa_accel.c | 32 ++-- 1 files changed, 6 insertions(+), 26 deletions(-) diff --git a/exa/exa_accel.c b/exa/exa_accel.c index f72a08a..b70222a 100644 --- a/exa/exa_accel.c +++ b/exa/exa_accel.c @@ -149,6 +149,7 @@ exaDoPutImage (DrawablePtr pDrawable, GCPtr

[PATCH 5/9] exa: use proper wrapping in exa.c

2009-02-03 Thread Maarten Maathuis
--- exa/exa.c | 141 ++--- 1 files changed, 70 insertions(+), 71 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index 42b664f..5faeee0 100644 --- a/exa/exa.c +++ b/exa/exa.c @@ -188,6 +188,7 @@ exaDestroyPixmap (PixmapPtr pPixmap) {

[PATCH 8/9] fb: split off a few functions into a seperate file and enhance them slightly.

2009-02-03 Thread Maarten Maathuis
- Compatibility wrappers, if deemed neccesary will come later. --- fb/Makefile.am |3 +- fb/fb.h | 37 +- fb/fb24_32.c|4 +- fb/fbcopy.c | 342 ++- fb/fbcopy_helpers.c | 367

Comments about exa patches i just sent

2009-02-03 Thread Maarten Maathuis
Per request by anholt and others, i have sent the patches as plain text. The only change from the last set is that i splitted out a few fb functions into a seperate file, enhanced them slightly and added a few defines to allow exa to use them. My attempts to split it out into mi, gave me very

[PATCH 4/9] exa: properly wrap GC functions

2009-02-03 Thread Maarten Maathuis
--- exa/exa.c | 219 exa/exa_priv.h| 33 - exa/exa_unaccel.c | 98 +--- 3 files changed, 234 insertions(+), 116 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index 496b898..42b664f 100644 ---

[PATCH 3/9] exa: add GC private

2009-02-03 Thread Maarten Maathuis
--- exa/exa.c | 11 +++ exa/exa_priv.h | 12 +++- 2 files changed, 22 insertions(+), 1 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index ba063bb..496b898 100644 --- a/exa/exa.c +++ b/exa/exa.c @@ -41,6 +41,8 @@ static int exaScreenPrivateKeyIndex; DevPrivateKey

about the exa patches

2009-02-03 Thread Maarten Maathuis
Found a potential bug in exaValidateGC, which should be fixed now. I hope the changes are coming to an end. I still need to know if there are any external users of fbDoCopy that would care for a wrapper. I'm assuming that functions that changed their return value from void to Bool pose no issue,

[PATCH 7/9] exa: create ExaCheckGetImage

2009-02-03 Thread Maarten Maathuis
--- exa/exa_accel.c |7 +-- exa/exa_priv.h|4 exa/exa_unaccel.c | 30 ++ 3 files changed, 35 insertions(+), 6 deletions(-) diff --git a/exa/exa_accel.c b/exa/exa_accel.c index 10e7914..02858f1 100644 --- a/exa/exa_accel.c +++ b/exa/exa_accel.c

[PATCH 4/9] exa: properly wrap GC functions

2009-02-03 Thread Maarten Maathuis
--- exa/exa.c | 233 + exa/exa_priv.h| 33 +++- exa/exa_unaccel.c | 98 --- 3 files changed, 248 insertions(+), 116 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index 496b898..58d1a7d 100644 ---

[PATCH 5/9] exa: use proper wrapping in exa.c

2009-02-03 Thread Maarten Maathuis
--- exa/exa.c | 141 ++--- 1 files changed, 70 insertions(+), 71 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index 58d1a7d..033b353 100644 --- a/exa/exa.c +++ b/exa/exa.c @@ -188,6 +188,7 @@ exaDestroyPixmap (PixmapPtr pPixmap) {

[PATCH 1/9] exa: Remove one of the many calls directly into the fb layer.

2009-02-03 Thread Maarten Maathuis
--- exa/exa_accel.c | 32 ++-- 1 files changed, 6 insertions(+), 26 deletions(-) diff --git a/exa/exa_accel.c b/exa/exa_accel.c index f72a08a..b70222a 100644 --- a/exa/exa_accel.c +++ b/exa/exa_accel.c @@ -149,6 +149,7 @@ exaDoPutImage (DrawablePtr pDrawable, GCPtr

[PATCH 2/9] exa: kill of exaImageGlyphBlt

2009-02-03 Thread Maarten Maathuis
- It serves no obvious purpose, yet it directly accesses many fb symbols. --- exa/exa_accel.c | 135 +-- 1 files changed, 1 insertions(+), 134 deletions(-) diff --git a/exa/exa_accel.c b/exa/exa_accel.c index b70222a..10e7914 100644 ---

[PATCH 7/9] exa: create ExaCheckGetImage

2009-02-03 Thread Maarten Maathuis
--- exa/exa_accel.c |7 +-- exa/exa_priv.h|4 exa/exa_unaccel.c | 30 ++ 3 files changed, 35 insertions(+), 6 deletions(-) diff --git a/exa/exa_accel.c b/exa/exa_accel.c index 10e7914..02858f1 100644 --- a/exa/exa_accel.c +++ b/exa/exa_accel.c

[PATCH 9/9] exa: fix exaCopyArea and friends.

2009-02-03 Thread Maarten Maathuis
--- exa/Makefile.am |3 ++- exa/exa_accel.c | 44 ++-- exa/exa_priv.h |6 +- exa/exa_render.c| 14 -- exa/exa_unaccel.c | 15 +++ fb/fbcopy_helpers.h |5 + 6 files changed, 69

[PATCH 2/9] exa: kill of exaImageGlyphBlt

2009-02-03 Thread Maarten Maathuis
- It serves no obvious purpose, yet it directly accesses many fb symbols. --- exa/exa_accel.c | 135 +-- 1 files changed, 1 insertions(+), 134 deletions(-) diff --git a/exa/exa_accel.c b/exa/exa_accel.c index b70222a..10e7914 100644 ---

[PATCH 8/9] fb: split off a few functions into a seperate file and enhance them slightly.

2009-02-03 Thread Maarten Maathuis
- Compatibility wrappers, if deemed neccesary will come later. --- fb/Makefile.am |3 +- fb/fb.h | 37 +- fb/fb24_32.c|4 +- fb/fbcopy.c | 342 ++- fb/fbcopy_helpers.c | 367

[PATCH 6/9] exa: wrap the remainder of exa_unaccel.c

2009-02-03 Thread Maarten Maathuis
--- exa/exa_unaccel.c | 30 +++--- 1 files changed, 27 insertions(+), 3 deletions(-) diff --git a/exa/exa_unaccel.c b/exa/exa_unaccel.c index d56f589..a521497 100644 --- a/exa/exa_unaccel.c +++ b/exa/exa_unaccel.c @@ -290,9 +290,14 @@ ExaCheckGetSpans (DrawablePtr

Re: [PATCHES] remove direct access to fb module from exa

2009-02-02 Thread Maarten Maathuis
On Mon, Feb 2, 2009 at 5:27 PM, Michel Dänzer mic...@daenzer.net wrote: On Mon, 2009-02-02 at 16:08 +0100, Maarten Maathuis wrote: The problem about mangling with fb symbols is that you need to do it at runtime, that would turn out to be very awkward, not to mention incorrect. For fallbacks

Re: Recent input changes

2009-02-02 Thread Maarten Maathuis
On Mon, Feb 2, 2009 at 1:52 AM, Ben Gamari bgam...@gmail.com wrote: On Sun, Jan 25, 2009 at 2:48 PM, Ben Gamari bgam...@gmail.com wrote: Strangely enough, before I login (in gdm) things seem to behave as they should. Directly after I login though (even before my own minimal ~/.Xmodmap has been

Re: [PATCH] A better way to deal with banned clients

2009-02-02 Thread Maarten Maathuis
Please ignore, better patches are underway. On Mon, Feb 2, 2009 at 12:22 PM, Maarten Maathuis madman2...@gmail.com wrote: jd: does this patchset work equally well for you? The idea is that jd's change also allows clients to leave their hidden area, which is ofcource bad. Maarten

Re: [PATCH] A better way to deal with banned clients

2009-02-02 Thread Maarten Maathuis
On Mon, Feb 2, 2009 at 8:07 PM, Maarten Maathuis madman2...@gmail.com wrote: Please ignore, better patches are underway. On Mon, Feb 2, 2009 at 12:22 PM, Maarten Maathuis madman2...@gmail.com wrote: jd: does this patchset work equally well for you? The idea is that jd's change also allows

[PATCH] A better way to deal with banned clients

2009-02-02 Thread Maarten Maathuis
jd: does this patchset work equally well for you? The idea is that jd's change also allows clients to leave their hidden area, which is ofcource bad. Maarten. 0001-Revert-event-do-not-store-resize-events-of-banned.patch Description: Binary data

Re: LibX11/xcb fails to initialize something

2009-01-31 Thread Maarten Maathuis
On Sat, Jan 31, 2009 at 7:37 PM, Brian Rogers br...@xyzw.org wrote: On Ubuntu Jaunty, Ekiga hangs during startup before it can open any windows. I traced the issue back to an uninitialized condition variable in libX11 xcb code. So to anyone with mysterious freezes, this may be the fix you need.

Re: general question: xorg Nvdriver

2009-01-28 Thread Maarten Maathuis
On Wed, Jan 28, 2009 at 11:21 PM, Stephane Marchesin marche...@icps.u-strasbg.fr wrote: 2009/1/28 Florian Lier f...@icram.de: Okay, new problem: I tried to insmod the nvdriver...this is the result: insmod: error inserting 'drm/linux-core/nv.ko': -1 Unknown symbol in module Any suggestions?

EXA, driver allocated pixmaps and fallbacks

2009-01-20 Thread Maarten Maathuis
Imagine having tiled pixmaps, that get copied on every map/unmap. EXA has certain optimisations to avoid migration ping-pong, ofcource that only applies to drivers using exa's built in memory manager. My impression is that an optional component, much like the migration logic in exa, should be

[Nouveau] a small patch for drm-ng

2009-01-18 Thread Maarten Maathuis
A small patch to make nv50 kms a bit more robust and avoid a nasty crash. Maarten. 0001-nv50-check-if-the-framebuffer-gem-object-is-non-NUL.patch Description: Binary data ___ Nouveau mailing list Nouveau@lists.freedesktop.org

<    2   3   4   5   6   7   8   9   >