[git:media_tree/master] media: atomisp: Remove unsused macros

2024-05-02 Thread Mauro Carvalho Chehab
Link: https://lore.kernel.org/r/20240326190903.1422069-1-andriy.shevche...@linux.intel.com Signed-off-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/bits.h | 4 +-- drivers/staging/media/atomisp/pci/defs.h

[git:media_tree/master] media: atomisp: Remove input_port_ID_t

2024-05-02 Thread Mauro Carvalho Chehab
Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/sh_css_mipi.c | 2 +- drivers/staging/media/atomisp/pci/system_global.h | 12 2 files changed, 1 insertion(+), 13 deletions(-) --- diff --git a/drivers/staging/media/atomisp/pci/sh_css_mipi.c b/drivers/staging/media/atomi

[git:media_tree/master] media: atomisp: Remove empty s_stream() op from CSI subdev

2024-05-02 Thread Mauro Carvalho Chehab
csi2_video_ops struct. While at it also remove the empty csi2_core_ops struct. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_csi2.c | 23 --- 1 file changed, 23 deletions(-) --- diff

[git:media_tree/master] media: atomisp: ov2722: Remove power on sensor from set_fmt() callback

2024-05-02 Thread Mauro Carvalho Chehab
before calling the set_fmt() callback, so this workaround is no longer necessary. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 12 drivers/staging/media/atomisp/i2c/ov2722.h

[git:media_tree/master] media: atomisp: Remove test pattern generator (TPG) support

2024-05-02 Thread Mauro Carvalho Chehab
de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/Makefile | 1 - .../media/atomisp/include/linux/atomisp_platform.h | 1 - drivers/staging/media/atomisp/pci/atomisp_cmd.c| 37 +++-- .../media/atomisp/pci/atomisp_compat_css20.c | 31

[git:media_tree/master] media: atomisp: Ensure CSI-receiver[x] -> ISP links correctly reflect current sensor

2024-05-02 Thread Mauro Carvalho Chehab
Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_cmd.c | 34 +++ drivers/staging/media/atomisp/pci/atomisp_cmd.h | 3 ++ drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 6 +++- driver

[git:media_tree/master] media: atomisp: Propagate v4l2_mbus_framefmt.field to CSI port sink pad

2024-05-02 Thread Mauro Carvalho Chehab
-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_csi2.c | 3 +++ 1 file changed, 3 insertions(+) --- diff --git a/drivers/staging/media/atomisp/pci/atomisp_csi2.c b/drivers/staging/media/atomisp/pci/atomisp_csi2.c index 89118438a3b6..e939a09a279b

[git:media_tree/master] media: atomisp: Drop the atomisp custom lm3554 flash driver

2024-05-02 Thread Mauro Carvalho Chehab
lm3554 driver could still be usable as a reference for how to use / driver the lm3554 for a future re-implementation using standardized APIs, but for that it can be retrieved from the git history. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab

[git:media_tree/master] media: i2c: ov4689: Fix typo in a comment

2024-05-02 Thread Mauro Carvalho Chehab
-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/ov4689.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c index c4d4afd38906..f826571f8f68 100644 --- a/drivers/media/i2c

[git:media_tree/master] media: atomisp: Propagate set_fmt on sensor results to CSI port

2024-05-02 Thread Mauro Carvalho Chehab
ned-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_cmd.c | 7 +++ drivers/staging/media/atomisp/pci/atomisp_internal.h | 1 + drivers/staging/media/atomisp/pci/atomisp_subdev.c | 17 +++-- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 1 +

[git:media_tree/master] media: i2c: ov4689: Clean up and annotate the register table

2024-05-02 Thread Mauro Carvalho Chehab
Carvalho Chehab drivers/media/i2c/ov4689.c | 205 ++--- 1 file changed, 119 insertions(+), 86 deletions(-) --- diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c index 403091651885..9890189bcbd5 100644 --- a/drivers/media/i2c/ov4689.c

[git:media_tree/master] media: atomisp: Remove struct atomisp_platform_data

2024-05-02 Thread Mauro Carvalho Chehab
-by: Mauro Carvalho Chehab .../media/atomisp/include/linux/atomisp_platform.h | 6 +--- .../media/atomisp/pci/atomisp_gmin_platform.c | 36 ++ .../staging/media/atomisp/pci/atomisp_internal.h | 1 - drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 16 ++ 4

[git:media_tree/master] media: atomisp: Simplify atomisp_s_input() input argument checking

2024-05-02 Thread Mauro Carvalho Chehab
s busy or not Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) --- diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/d

[git:media_tree/master] media: atomisp: Remove clearing of ISP crop / compose rectangles on file release

2024-05-02 Thread Mauro Carvalho Chehab
support the comment talks about has long been dropped from the driver. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_fops.c | 21 - 1 file changed, 21 deletions(-) --- diff --git

[git:media_tree/master] media: atomisp: Drop unused frame_status tracking

2024-05-02 Thread Mauro Carvalho Chehab
nko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/include/linux/atomisp.h | 15 --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 1 - drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 12 ++-- drivers/staging/me

[git:media_tree/master] media: atomisp: Drop atomisp_pipe_check() from atomisp_link_setup()

2024-05-02 Thread Mauro Carvalho Chehab
ink() pad-op is taken before calling the op, while in other scenarios the graph_mutex is taken after the isp->mutex. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_subdev.c | 8 +--- 1 file chan

[git:media_tree/master] media: atomisp: Turn on sensor power from atomisp_set_fmt()

2024-05-02 Thread Mauro Carvalho Chehab
e.g. a s_input ioctl atomisp_s_sensor_power() will skip calling the s_power() v4l2-subdev-op a second time. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_cmd.c | 11 +++ 1 file changed, 11 insertions(+) ---

[git:media_tree/master] media: i2c: ov4689: Remove i2c_client from ov4689 struct

2024-05-02 Thread Mauro Carvalho Chehab
to access its 'dev' member. This commit removes the 'client' field and directly stores a pointer to the 'struct device'. Signed-off-by: Mikhail Rudenko Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/ov4689.c | 36

[git:media_tree/master] media: atomisp: Add atomisp_s_sensor_power() helper

2024-05-02 Thread Mauro Carvalho Chehab
care of handling the special -ENOIOCTLCMD return for subdevs which don't implement s_power(). Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_cmd.c | 17 + drivers/staging/media/atomisp

[git:media_tree/master] media: atomisp: Replace open-coded i2c_find_device_by_fwnode()

2024-05-02 Thread Mauro Carvalho Chehab
of i2c_find_device_by_fwnode(). Replace it with a corresponding call. Link: https://lore.kernel.org/r/20240326202813.1425431-3-andriy.shevche...@linux.intel.com Signed-off-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci

[git:media_tree/master] media: atomisp: Call media_pipeline_alloc_start() in stream start

2024-05-02 Thread Mauro Carvalho Chehab
() to mark all involved subdevs as busy so that the links cannot be changed through the media-controller APIs while streaming. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 15

[git:media_tree/master] media: atomisp: Cleanup atomisp_isr_thread() spinlock handling

2024-05-02 Thread Mauro Carvalho Chehab
paths with spin_unlock_irqrestore() in there. While at it also remove the non helpful dev_dbg() message. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_cmd.c | 11 --- 1 file changed, 4 insertions

[git:media_tree/master] media: atomisp: Get rid of PCI device ID hack check

2024-05-02 Thread Mauro Carvalho Chehab
://lore.kernel.org/r/20240402204447.294280-1-andriy.shevche...@linux.intel.com Signed-off-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab .../staging/media/atomisp/pci/atomisp_internal.h | 3 +- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 40

[git:media_tree/master] media: atomisp: Remove gmin_platform VCM code.

2024-05-02 Thread Mauro Carvalho Chehab
7473c97dd8d0 ("media: atomisp: Remove custom VCM handling") remove the left-over dead VCM handling from the gmin platform code. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab .../atomisp/include/linux/atomisp_gmin_platform.h | 3 -- .../med

[git:media_tree/master] media: i2c: ov4689: CCI conversion

2024-05-02 Thread Mauro Carvalho Chehab
on driver-specific functions. Also, set analogue gain in a single 16-bit write instead of two 8-bit writes. [Sakari Ailus: Initialise sensor_gain as 0.] Signed-off-by: Mikhail Rudenko Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c

[git:media_tree/master] media: atomisp: Drop intel_v4l2_subdev_type

2024-05-02 Thread Mauro Carvalho Chehab
it. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +- .../staging/media/atomisp/i2c/atomisp-mt9m114.c| 2 +- drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 2 +- .../atomisp/include

[git:media_tree/master] media: i2c: ov4689: Sort register definitions by address

2024-05-02 Thread Mauro Carvalho Chehab
. Signed-off-by: Mikhail Rudenko Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/ov4689.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) --- diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c

[git:media_tree/master] media: atomisp: Remove setting of f->fmt.pix.priv from atomisp_set_fmt()

2024-05-02 Thread Mauro Carvalho Chehab
ned to userspace and userspace should not rely on / use the priv fields. Drop setting this. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_cmd.c | 2 -- 1 file changed, 2 deletions(-) --- diff --git a/driv

[git:media_tree/master] media: atomisp: Remove empty s_power() op from ISP subdev

2024-05-02 Thread Mauro Carvalho Chehab
Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_subdev.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) --- diff --git a/drivers/staging/media/atomisp/pci/atomisp_subdev.c b/drivers/staging/media/atomisp

[git:media_tree/master] media: atomisp: Put PMIC device after getting its I²C address

2024-05-02 Thread Mauro Carvalho Chehab
. Drop the reference to it. We do not expect device to disappear as it should be taken care by the OpRegion drivers. Link: https://lore.kernel.org/r/20240326202813.1425431-2-andriy.shevche...@linux.intel.com Signed-off-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho

[git:media_tree/master] media: atomisp: Add atomisp_select_input() helper

2024-05-02 Thread Mauro Carvalho Chehab
make atomisp_link_setup() turn the sensor back off when a link gets disabled. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_cmd.c| 19 +++ drivers/staging/media/atomisp/pci

[git:media_tree/master] media: staging: media: atomisp: Remove extra whitespace after opening parentheses

2024-05-02 Thread Mauro Carvalho Chehab
: * Removes spurious whitespace after the opening parentheses as per code style guidelines Link: https://lore.kernel.org/r/20240227163043.112162-2-bergh.jonat...@gmail.com Signed-off-by: Jonathan Bergh Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp

[git:media_tree/master] media: atomisp: Initialize sequence counters to 0 instead of -1

2024-05-02 Thread Mauro Carvalho Chehab
instead of -1. This fixes the following libcamera warning: Zero sequence expected for first frame (got 4294967295) Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[git:media_tree/master] media: atomisp: Replace V4L2_PIX_FMT_RGB32 with V4L2_PIX_FMT_RGBX32

2024-05-02 Thread Mauro Carvalho Chehab
with V4L2_PIX_FMT_RGBX32. Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_cmd.c | 4 ++-- drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) --- diff --git a/drivers/staging

[git:media_tree/master] media: staging: media: atomisp: Fix formatting issues and minor code issue

2024-05-02 Thread Mauro Carvalho Chehab
-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 7 +++ drivers/staging/media/atomisp/pci/atomisp_subdev.c| 7 --- 2 files changed, 7 insertions(+), 7 deletions(-) --- diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b

[git:media_tree/master] media: staging: media: atomisp: Ensure trailing statements are on a newline and remove spurious whitespaces

2024-05-02 Thread Mauro Carvalho Chehab
-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/sh_css_sp.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) --- diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c index 05b9c9ea0a21

[git:media_tree/master] media: staging: media: atomisp: Fixed "unsigned int *" rather than "unsigned *" declaration in variable declaration

2024-05-02 Thread Mauro Carvalho Chehab
-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/sh_css_sp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c index e0e1405dfc69..05b9c9e

[git:media_tree/master] media: atomisp: Disable broken V4L2_PIX_FMT_RGBX32 output support

2024-05-02 Thread Mauro Carvalho Chehab
. Selecting V4L2_PIX_FMT_RGBX32 output shows vertical columns with random data. For each 128 pixels in a row the last 28 (32?) or so pixels contain random data. Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 17 +++-- 1

[git:media_tree/master] media: staging: media: atomisp: Remove old commented code and fix multiple block comment style

2024-05-02 Thread Mauro Carvalho Chehab
-by: Jonathan Bergh Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/sh_css_sp.c | 88 +++ 1 file changed, 49 insertions(+), 39 deletions(-) --- diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging

[git:media_tree/master] media: atomisp: Drop second V4L2_PIX_FMT_UYVY atomisp_output_fmts[] entry

2024-05-02 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 6 -- 1 file changed, 6 deletions(-) --- diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c index fa6c9f0ea6eb..6009b7779f13 100644 ---

[git:media_tree/master] media: staging: media: atomisp: Remove unneeded return statement from void function

2024-05-02 Thread Mauro Carvalho Chehab
: * Removes an unnecessary 'return' statement from a void function implementation Link: https://lore.kernel.org/r/20240226194023.69070-6-bergh.jonat...@gmail.com Signed-off-by: Jonathan Bergh Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci

[git:media_tree/master] media: staging: media: atomisp: Fix various formatting issues and remove unneccesary braces

2024-05-02 Thread Mauro Carvalho Chehab
than Bergh Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp/pci/atomisp_cmd.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) --- diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/a

[git:media_tree/master] media: staging: media: atomisp: Remove unnecessary braces from single line conditional statements

2024-05-02 Thread Mauro Carvalho Chehab
things: * Tidies up code in several places where braces were used in conjunction with single line conditional statements Link: https://lore.kernel.org/r/20240226194023.69070-2-bergh.jonat...@gmail.com Signed-off-by: Jonathan Bergh Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho

[git:media_tree/master] media: staging: media: atomisp: Remove unnecessary parentheses from conditional statement

2024-05-02 Thread Mauro Carvalho Chehab
: * Removes additional, unnecessary parentheses from a conditional "if" statement Link: https://lore.kernel.org/r/20240226194023.69070-5-bergh.jonat...@gmail.com Signed-off-by: Jonathan Bergh Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/med

[git:media_tree/master] media: staging: media: atomisp: Fix various multiline block comment formatting instances

2024-05-02 Thread Mauro Carvalho Chehab
: * Reformats a number of multiline block comments to ensure * and */ align correctly Link: https://lore.kernel.org/r/20240227163043.112162-1-bergh.jonat...@gmail.com Signed-off-by: Jonathan Bergh Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/atomisp

[git:media_tree/master] media: i2c: ov4689: Use sub-device active state

2024-05-02 Thread Mauro Carvalho Chehab
to the active state and s_stream. Signed-off-by: Mikhail Rudenko Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/ov4689.c | 75 +++--- 1 file changed, 31 insertions(+), 44 deletions

[git:media_tree/master] media: i2c: ov4689: Refactor ov4689_set_ctrl

2024-05-02 Thread Mauro Carvalho Chehab
. This adjustment eliminates repetition within the function. Signed-off-by: Mikhail Rudenko Reviewed-by: Kieran Bingham Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/ov4689.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) --- diff --git a/drivers

[git:media_tree/master] media: i2c: ov4689: Remove max_fps field from struct ov4689_mode

2024-05-02 Thread Mauro Carvalho Chehab
remove it. Signed-off-by: Mikhail Rudenko Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/ov4689.c | 2 -- 1 file changed, 2 deletions(-) --- diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c index

[git:media_tree/master] media: i2c: ov4689: Implement vflip/hflip controls

2024-05-02 Thread Mauro Carvalho Chehab
Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/ov4689.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) --- diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c index 7792f6a5a059..02274ad34c30 100644

[git:media_tree/master] media: i2c: ov4689: Enable runtime PM before registering sub-device

2024-05-02 Thread Mauro Carvalho Chehab
-device is registered, enable runtime PM before doing so. Signed-off-by: Mikhail Rudenko Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/ov4689.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) --- diff --git

[git:media_tree/master] media: i2c: ov4689: Implement digital gain control

2024-05-02 Thread Mauro Carvalho Chehab
control in the driver. Default digital gain value is not modified by this patch. Signed-off-by: Mikhail Rudenko Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/ov4689.c | 16 ++-- 1 file changed, 14 insertions(+), 2

[git:media_tree/master] media: i2c: ov4689: Use runtime PM autosuspend

2024-05-02 Thread Mauro Carvalho Chehab
-reconfigure-restart cycles. Signed-off-by: Mikhail Rudenko Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/ov4689.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) --- diff --git a/drivers/media/i2c/ov4689.c

[git:media_tree/master] media: i2c: ov4689: Make horizontal blanking configurable

2024-05-02 Thread Mauro Carvalho Chehab
. Signed-off-by: Mikhail Rudenko Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/ov4689.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) --- diff --git a/drivers/media/i2c/ov4689.c b

[git:media_tree/master] media: i2c: ov4689: Move pixel array size out of struct ov4689_mode

2024-05-02 Thread Mauro Carvalho Chehab
to the ov4689_mode structure, since they are mode independent. Make them defines instead. Signed-off-by: Mikhail Rudenko Reviewed-by: Kieran Bingham Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/ov4689.c | 29 + 1 file changed, 13

[git:media_tree/master] media: i2c: ov4689: Set timing registers programmatically

2024-05-02 Thread Mauro Carvalho Chehab
of hardcoding them in the register table. This prepares the driver for implementation of configurable analogue crop and binning. No functional change intended. Signed-off-by: Mikhail Rudenko Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers

[git:media_tree/master] media: i2c: ov4689: Implement manual color balance controls

2024-05-02 Thread Mauro Carvalho Chehab
). Implement appropriate controls in the driver. Default gain values are not modified. Signed-off-by: Mikhail Rudenko Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/ov4689.c | 23 ++- 1 file changed, 22

[git:media_tree/master] media: v4l: Set sub-device's owner field to the caller's module

2024-05-02 Thread Mauro Carvalho Chehab
as an argument to the function. v4l2_device_register_subdev() becomes a macro passing THIS_MODULE to the __v4l2_device_register_subdev() function. Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/v4l2-core/v4l2-async.c | 2 +- drivers/media/v4l2-core/v4l2-device.c

[git:media_tree/master] media: i2c: imx219: Use dev_err_probe on probe

2024-05-02 Thread Mauro Carvalho Chehab
intended. Signed-off-by: Umang Jain Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/imx219.c | 77 +- 1 file changed, 35 insertions(+), 42 deletions(-) --- diff --git a/drivers/media/i2c/imx219.c b/drivers/media

[git:media_tree/master] media: v4l: async: Set owner for async sub-devices

2024-05-02 Thread Mauro Carvalho Chehab
() a macro and obtaining THIS_MODULE that way. Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/v4l2-core/v4l2-async.c | 8 ++-- include/media/v4l2-async.h | 4 +++- 2 files changed, 9 insertions(+), 3 deletions(-) --- diff --git a/drivers/media

[git:media_tree/master] media: m88ds3103: Fix lock led support

2024-05-02 Thread Mauro Carvalho Chehab
after tuning to a new frequency to make the lock output pin go high when a signal is found. This pin is normally connected to an indicator led. Link: https://lore.kernel.org/linux-media/20220116112238.74171-1-mi...@freedict.org Signed-off-by: Michael Bunk Signed-off-by: Mauro Carvalho Chehab

[git:media_tree/master] media: mediatek: vcodec: Replace dev_name in error string

2024-05-02 Thread Mauro Carvalho Chehab
. Print the function name instead. Signed-off-by: Fei Shao Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Sebastian Fricke Signed-off-by: Mauro Carvalho Chehab drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_util.c | 4 ++-- 1 file changed

[git:media_tree/master] media: dw2102: Fix minor issues

2024-05-02 Thread Mauro Carvalho Chehab
...@freedict.org Signed-off-by: Michael Bunk Signed-off-by: Mauro Carvalho Chehab drivers/media/usb/dvb-usb/dw2102.c | 89 -- 1 file changed, 48 insertions(+), 41 deletions(-) --- diff --git a/drivers/media/usb/dvb-usb/dw2102.c b/drivers/media/usb/dvb-usb/dw2102.c

[git:media_tree/master] media: mediatek: vcodec: Drop unnecessary variable

2024-05-02 Thread Mauro Carvalho Chehab
and retrieve a small amount of memory that is used for no real purpose. Signed-off-by: Fei Shao Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Sebastian Fricke Signed-off-by: Mauro Carvalho Chehab .../mediatek/vcodec/common/mtk_vcodec_util

[git:media_tree/master] media: dw2102: Dont't list TT Cinergy S2 R4 twice

2024-05-02 Thread Mauro Carvalho Chehab
le reports this usb alias twice. Remove one of them. Signed-off-by: Michael Bunk Signed-off-by: Mauro Carvalho Chehab drivers/media/usb/dvb-usb/dw2102.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- diff --git a/drivers/media/usb/dvb-usb/dw2102.c b/drivers/media/usb/dvb-us

[git:media_tree/master] media: dw2102: Don't translate i2c read into write

2024-05-02 Thread Mauro Carvalho Chehab
eedict.org Signed-off-by: Michael Bunk Signed-off-by: Mauro Carvalho Chehab drivers/media/usb/dvb-usb/dw2102.c | 120 ++--- 1 file changed, 73 insertions(+), 47 deletions(-) --- diff --git a/drivers/media/usb/dvb-usb/dw2102.c b/drivers/media/usb/dvb-usb/dw21

[git:media_tree/master] media: mediatek: vcodec: Update mtk_vcodec_mem_free() error messages

2024-05-02 Thread Mauro Carvalho Chehab
igned-off-by: Sebastian Fricke Signed-off-by: Mauro Carvalho Chehab drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_util.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- diff --git a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_util.c b/drivers/media/platform

[git:media_tree/master] media: mediatek: vcodec: Only free buffer VA that is not NULL

2024-05-02 Thread Mauro Carvalho Chehab
-off-by: Andrzej Pietrasiewicz Signed-off-by: Sebastian Fricke Signed-off-by: Mauro Carvalho Chehab .../vcodec/decoder/vdec/vdec_av1_req_lat_if.c | 22 +++--- .../mediatek/vcodec/encoder/venc/venc_h264_if.c| 5 +++-- 2 files changed, 18 insertions(+), 9 deletions

[git:media_tree/master] media: i2c: rdacm20: Fix indentation in comment

2024-05-02 Thread Mauro Carvalho Chehab
/linux-media/20220101173540.9090-1-laurent.pinchart+rene...@ideasonboard.com Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/rdacm20.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[git:media_tree/master] media: dw2102: fix coding style issues

2024-05-02 Thread Mauro Carvalho Chehab
This is an automatic generated email to let you know that the following patch were queued: Subject: media: dw2102: fix coding style issues Author: Mauro Carvalho Chehab Date:Mon Apr 29 09:27:51 2024 +0100 Use checkpatch --strict --in-place to cleanup most style issues. Then, do some

[git:media_tree/master] media: i2c: max9271: Add header include guards to max9271.h

2024-05-02 Thread Mauro Carvalho Chehab
with include guards. Link: https://lore.kernel.org/linux-media/20220102224803.27463-1-laurent.pinchart+rene...@ideasonboard.com Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/max9271.h | 5 + 1 file

[git:media_stage/master] media: bcm2835-unicam: Fix build with !PM

2024-05-02 Thread Mauro Carvalho Chehab
be used, of_match_ptr does not make sense here. It fixes this warning: drivers/media/platform/broadcom/bcm2835-unicam.c:2724:34: warning: ‘unicam_of_match’ defined but not used [-Wunused-const-variable=] Signed-off-by: Ricardo Ribalda Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab

[git:media_stage/master] media: bcm2835-unicam: Include v4l2-subdev.h

2024-05-02 Thread Mauro Carvalho Chehab
instead of relying on indirect includes. Closes: https://lore.kernel.org/oe-kbuild-all/202404302324.8atc84ke-...@intel.com/ Signed-off-by: Laurent Pinchart Reported-by: kernel test robot Reviewed-by: Ricardo Ribalda Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers

[git:media_stage/master] media: intel/ipu6: Switch to RUNTIME_PM_OPS() and SYSTEM_SLEEP_PM_OPS

2024-05-02 Thread Mauro Carvalho Chehab
: ‘ipu6_resume’ defined but not used [-Wunused-function] drivers/media/pci/intel/ipu6/ipu6.c:801:12: warning: ‘ipu6_suspend’ defined but not used [-Wunused-function] Signed-off-by: Ricardo Ribalda Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/pci/intel/ipu6

[git:media_stage/master] media: intel/ipu6: Fix direct dependency Kconfig error

2024-05-02 Thread Mauro Carvalho Chehab
y] && PCI [=y] && MEDIA_PCI_SUPPORT [=y] && (ACPI [=n] || COMPILE_TEST [=y]) && VIDEO_DEV [=y] && X86 [=y] && X86_64 [=y] && HAS_DMA [=y] Signed-off-by: Ricardo Ribalda Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab dr

[git:media_stage/master] media: intel/ipu6: Fix build with !ACPI

2024-05-02 Thread Mauro Carvalho Chehab
-function] Signed-off-by: Ricardo Ribalda Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab drivers/media/pci/intel/ipu-bridge.c | 66 +--- 1 file changed, 47 insertions(+), 19 deletions(-) --- diff --git a/drivers/media/pci/intel/ipu-bridge.c b

Re: [PATCH v15 00/16] Add audio support in v4l2 framework

2024-05-02 Thread Mauro Carvalho Chehab
Em Thu, 2 May 2024 09:59:56 +0100 Mauro Carvalho Chehab escreveu: > Em Thu, 02 May 2024 09:46:14 +0200 > Takashi Iwai escreveu: > > > On Wed, 01 May 2024 03:56:15 +0200, > > Mark Brown wrote: > > > > > > On Tue, Apr 30, 2024 at 05:27:52PM +0100, Maur

Re: [PATCH v15 00/16] Add audio support in v4l2 framework

2024-05-02 Thread Mauro Carvalho Chehab
Em Thu, 02 May 2024 09:46:14 +0200 Takashi Iwai escreveu: > On Wed, 01 May 2024 03:56:15 +0200, > Mark Brown wrote: > > > > On Tue, Apr 30, 2024 at 05:27:52PM +0100, Mauro Carvalho Chehab wrote: > > > Mark Brown escreveu: > > > > On Tue, Apr 30, 202

Re: [PATCH v15 00/16] Add audio support in v4l2 framework

2024-04-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Apr 2024 23:46:03 +0900 Mark Brown escreveu: > On Tue, Apr 30, 2024 at 10:21:12AM +0200, Sebastian Fricke wrote: > > > first of all thanks for all of this work and I am very sorry for only > > emerging this late into the series, I sadly didn't notice it earlier. > > It might be

Re: [PATCH v15 00/16] Add audio support in v4l2 framework

2024-04-30 Thread Mauro Carvalho Chehab
Em Tue, 30 Apr 2024 10:47:13 +0200 Hans Verkuil escreveu: > On 30/04/2024 10:21, Sebastian Fricke wrote: > > Hey Shengjiu, > > > > first of all thanks for all of this work and I am very sorry for only > > emerging this late into the series, I sadly didn't notice it earlier. > > > > I would

[git:media_stage/master] media: staging: max96712: fix copy-paste error

2024-04-30 Thread Mauro Carvalho Chehab
...@foobox.net Signed-off-by: Ihor Matushchak Signed-off-by: Mauro Carvalho Chehab drivers/staging/media/max96712/max96712.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c index

[git:media_stage/master] media: ipu3: Use MODULE_FIRMWARE to add firmware files metadata

2024-04-30 Thread Mauro Carvalho Chehab
the MODULE_FIRMWARE macro to show them in the module metadata [mchehab: add missing firmware file: IMGU_FW_NAME_IPU_20161208] Link: https://lore.kernel.org/linux-media/20230914135100.19911-1-victor.gonz...@anddroptable.net Signed-off-by: Víctor Gonzalo Signed-off-by: Mauro Carvalho Chehab drivers

[git:media_stage/master] media: cec: cec.h: 2.1 ms -> 2100 ms

2024-04-30 Thread Mauro Carvalho Chehab
tps://lore.kernel.org/linux-media/17cd1a67-3966-237c-2e0d-2d3ae618f...@xs4all.nl Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab include/media/cec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- diff --git a/include/media/cec.h b/include/media/cec.h index 10c9cf605

[git:media_stage/master] media: IR remote control for AVerMedia TD310

2024-04-29 Thread Mauro Carvalho Chehab
-media/2273969.FyfRTN5kjP@bootes Signed-off-by: Alex Volkov Signed-off-by: Mauro Carvalho Chehab drivers/media/usb/dvb-usb-v2/af9035.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) --- diff --git a/drivers/media/usb/dvb-usb-v2/af9035.c b/drivers/media/usb/dvb-usb-v2/af9035.c

[git:media_stage/master] media: atomisp-mt9m114: adjust macro parameter name

2024-04-29 Thread Mauro Carvalho Chehab
of container_of. Fortunately, the argument at all uses is actually sd. But change the macro parameter name anyway, for a little added safety. Link: https://lore.kernel.org/linux-media/20230315090904.20092-1-julia.law...@inria.fr Signed-off-by: Julia Lawall Signed-off-by: Mauro Carvalho Chehab

[git:media_stage/master] media: dw2102: fix a potential buffer overflow

2024-04-29 Thread Mauro Carvalho Chehab
This is an automatic generated email to let you know that the following patch were queued: Subject: media: dw2102: fix a potential buffer overflow Author: Mauro Carvalho Chehab Date:Mon Apr 29 15:15:05 2024 +0100 As pointed by smatch: drivers/media/usb/dvb-usb/dw2102.c:802

[git:tvtime/master] tvtime: support drivers that always select a pixfmt in S_FMT

2024-04-29 Thread Mauro Carvalho Chehab
-1f0c-25ceaf9fe...@xs4all.nl Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab src/videoinput.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) --- http://git.linuxtv.org/cgit.cgi/tvtime.git/commit/?id=b22f8e196d8640d28f22fe7e429c70f56804e3c4 diff --git a/src

[git:media_stage/master] media: dt-bindings: media: i2c: Rename ov8856.yaml

2024-04-29 Thread Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab .../devicetree/bindings/media/i2c/{ov8856.yaml => ovti,ov8856.yaml} | 2 +- MAINTAINERS | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- diff --git a/Documentation/devicetree/bindi

[git:media_stage/master] media: i2c: rdacm20: Fix indentation in comment

2024-04-29 Thread Mauro Carvalho Chehab
/linux-media/20220101173540.9090-1-laurent.pinchart+rene...@ideasonboard.com Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/rdacm20.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[git:media_stage/master] media: i2c: max9271: Add header include guards to max9271.h

2024-04-29 Thread Mauro Carvalho Chehab
with include guards. Link: https://lore.kernel.org/linux-media/20220102224803.27463-1-laurent.pinchart+rene...@ideasonboard.com Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Jacopo Mondi Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/max9271.h | 5 + 1 file

[git:media_stage/master] media: dw2102: Don't translate i2c read into write

2024-04-29 Thread Mauro Carvalho Chehab
eedict.org Signed-off-by: Michael Bunk Signed-off-by: Mauro Carvalho Chehab drivers/media/usb/dvb-usb/dw2102.c | 120 ++--- 1 file changed, 73 insertions(+), 47 deletions(-) --- diff --git a/drivers/media/usb/dvb-usb/dw2102.c b/drivers/media/usb/dvb-usb/dw21

[git:media_stage/master] media: m88ds3103: Fix lock led support

2024-04-29 Thread Mauro Carvalho Chehab
after tuning to a new frequency to make the lock output pin go high when a signal is found. This pin is normally connected to an indicator led. Link: https://lore.kernel.org/linux-media/20220116112238.74171-1-mi...@freedict.org Signed-off-by: Michael Bunk Signed-off-by: Mauro Carvalho Chehab

[git:media_stage/master] media: dw2102: Fix minor issues

2024-04-29 Thread Mauro Carvalho Chehab
...@freedict.org Signed-off-by: Michael Bunk Signed-off-by: Mauro Carvalho Chehab drivers/media/usb/dvb-usb/dw2102.c | 89 -- 1 file changed, 48 insertions(+), 41 deletions(-) --- diff --git a/drivers/media/usb/dvb-usb/dw2102.c b/drivers/media/usb/dvb-usb/dw2102.c

[git:media_stage/master] media: dw2102: fix coding style issues

2024-04-29 Thread Mauro Carvalho Chehab
This is an automatic generated email to let you know that the following patch were queued: Subject: media: dw2102: fix coding style issues Author: Mauro Carvalho Chehab Date:Mon Apr 29 09:27:51 2024 +0100 Use checkpatch --strict --in-place to cleanup most style issues. Then, do some

[git:media_stage/master] media: dw2102: Dont't list TT Cinergy S2 R4 twice

2024-04-29 Thread Mauro Carvalho Chehab
le reports this usb alias twice. Remove one of them. Signed-off-by: Michael Bunk Signed-off-by: Mauro Carvalho Chehab drivers/media/usb/dvb-usb/dw2102.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- diff --git a/drivers/media/usb/dvb-usb/dw2102.c b/drivers/media/usb/dvb-us

[git:media_stage/master] media: flexcop: unneeded ATOMIC

2024-04-29 Thread Mauro Carvalho Chehab
/20220517131109.28371-1-oneu...@suse.com Signed-off-by: Oliver Neukum Reviewed-by: Johan Hovold Signed-off-by: Mauro Carvalho Chehab drivers/media/usb/b2c2/flexcop-usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- diff --git a/drivers/media/usb/b2c2/flexcop-usb.c b/drivers/media/usb/b2c2

[git:media_stage/master] media: si2165: Remove redundant NULL check before release_firmware() call

2024-04-29 Thread Mauro Carvalho Chehab
checking before calling it is redundant. Link: https://lore.kernel.org/linux-media/20220606014433.290667-1-chi.ming...@zte.com.cn Reported-by: Zeal Robot Signed-off-by: Minghao Chi Acked-by: Matthias Schwarzott Signed-off-by: Mauro Carvalho Chehab drivers/media/dvb-frontends/si2165.c | 6

[git:media_stage/master] media: as102: avoid GFP_ATOMIC

2024-04-29 Thread Mauro Carvalho Chehab
/20220517111049.25611-1-oneu...@suse.com Signed-off-by: Oliver Neukum Signed-off-by: Mauro Carvalho Chehab drivers/media/usb/as102/as102_usb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- diff --git a/drivers/media/usb/as102/as102_usb_drv.c b/drivers/media/usb/as102/as102_usb_drv.c index

[git:media_stage/master] media: imx214: Fix the error handling in imx214_probe()

2024-04-29 Thread Mauro Carvalho Chehab
://lore.kernel.org/linux-media/20220510114852.1719018-1-zheyum...@gmail.com Signed-off-by: Zheyu Ma Signed-off-by: Mauro Carvalho Chehab drivers/media/i2c/imx214.c | 1 + 1 file changed, 1 insertion(+) --- diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index 10b6ad66d126

[git:media_stage/master] media: lgdt3306a: Add a check against null-pointer-def

2024-04-29 Thread Mauro Carvalho Chehab
[ 29.616339] i2c_device_probe+0x951/0xa90 Link: https://lore.kernel.org/linux-media/20220405095018.3993578-1-zheyum...@gmail.com Signed-off-by: Zheyu Ma Signed-off-by: Mauro Carvalho Chehab drivers/media/dvb-frontends/lgdt3306a.c | 5 + 1 file changed, 5 insertions(+) --- diff --git a/drivers

[git:media_stage/master] media: flexcop-usb: fix sanity check of bNumEndpoints

2024-04-29 Thread Mauro Carvalho Chehab
sanity checking of endpoint type") Signed-off-by: Dongliang Mu Signed-off-by: Mauro Carvalho Chehab drivers/media/usb/b2c2/flexcop-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- diff --git a/drivers/media/usb/b2c2/flexcop-usb.c b/drivers/media/usb/b2c2/flexcop-usb.

<    1   2   3   4   5   6   7   8   9   10   >