Re: About NETWORK CONFIGURATION in kickstart process
Hi, Thank you for your reply. (2014/05/30 22:59), Chris Lumens wrote: # Network information # network --hostname=localhost.localdomain #network --bootproto=static --device=lo --ip=127.0.0.1 --netmask==255.0.0.0 --nodefroute --nodns --hostname=localhost.lcoaldomain The network line in your kickstart file is commented out. Yes, my device doesn't have any network interface, so I had to comment out this line to proceed. It seems that it requires network configuration even if the device doesn't have any network interface, right? If no, I'd like to know how to skip network configuration window while kickstarting. Regards, -- NT ___ Kickstart-list mailing list Kickstart-list@redhat.com https://www.redhat.com/mailman/listinfo/kickstart-list
About NETWORK CONFIGURATION in kickstart process
Hi, I'm new to anaconda, but I have one question. I'm going to install Fedora 20 with DVD media and kickstart file to PC which has no network interfaces. Everything is going well except that kickstart process stops at the NETWORK CONFIGURATION window with the message We'll need network access to fetch information about your location and to make software updates available for you. Could you give me how to skip this NETWORK CONFIGURATION window? Regards, P.S. I attach using kickstart.cfg - #version=DEVEL # System authorization information auth --enableshadow --passalgo=sha512 # Use CDROM installation media cdrom # Run the Setup Agent on first boot firstboot --enable # Keyboard layouts keyboard --vckeymap=us --xlayouts='us' # System language # lang ja_JP.UTF-8 # Network information # network --hostname=localhost.localdomain #network --bootproto=static --device=lo --ip=127.0.0.1 --netmask==255.0.0.0 --nodefroute --nodns --hostname=localhost.lcoaldomain # Root password # snip # System timezone timezone --utc Asia/Tokyo # System bootloader configuration autopart --type=plain # Partition clearing information #clearpart --none --initlabel clearpart --all --drives=vda bootloader --location=mbr --boot-drive=vda ignoredisk --only-use=vda %packages @core %end -- NT -- users mailing list us...@lists.fedoraproject.org To unsubscribe or change subscription options: https://admin.fedoraproject.org/mailman/listinfo/users Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct Guidelines: http://fedoraproject.org/wiki/Mailing_list_guidelines Have a question? Ask away: http://ask.fedoraproject.org ___ Kickstart-list mailing list Kickstart-list@redhat.com https://www.redhat.com/mailman/listinfo/kickstart-list
About NETWORK CONFIGURATION in kickstart process
Hi, I'm new to anaconda, but I have one question. I'm going to install Fedora 20 with DVD media and kickstart file to PC which has no network interfaces. Everything is going well except that kickstart process stops at the NETWORK CONFIGURATION window with the message We'll need network access to fetch information about your location and to make software updates available for you. Could you give me how to skip this NETWORK CONFIGURATION window? Regards, P.S. I attach using kickstart.cfg - #version=DEVEL # System authorization information auth --enableshadow --passalgo=sha512 # Use CDROM installation media cdrom # Run the Setup Agent on first boot firstboot --enable # Keyboard layouts keyboard --vckeymap=us --xlayouts='us' # System language # lang ja_JP.UTF-8 # Network information # network --hostname=localhost.localdomain #network --bootproto=static --device=lo --ip=127.0.0.1 --netmask==255.0.0.0 --nodefroute --nodns --hostname=localhost.lcoaldomain # Root password rootpw --iscrypted $6$etxGu6z/bVEGULjV$PTypYz.NpPNmOLxgreym7PbdJHmE9evT7RRsfQY8JNsLNbXLmhT.Cmq9KjKD8c98SowkRN5MZjtEEshz03rCV1 # System timezone timezone --utc Asia/Tokyo # System bootloader configuration autopart --type=plain # Partition clearing information #clearpart --none --initlabel clearpart --all --drives=vda bootloader --location=mbr --boot-drive=vda ignoredisk --only-use=vda %packages @core %end -- NT -- users mailing list users@lists.fedoraproject.org To unsubscribe or change subscription options: https://admin.fedoraproject.org/mailman/listinfo/users Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct Guidelines: http://fedoraproject.org/wiki/Mailing_list_guidelines Have a question? Ask away: http://ask.fedoraproject.org
Re: About NETWORK CONFIGURATION in kickstart process
Hi, (2014/05/29 0:08), Tim wrote: Abandon that password, now. It may well be crypted, but people have cracked encrypted passwords before. Thanks for your advice. Regards, -- NT -- users mailing list users@lists.fedoraproject.org To unsubscribe or change subscription options: https://admin.fedoraproject.org/mailman/listinfo/users Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct Guidelines: http://fedoraproject.org/wiki/Mailing_list_guidelines Have a question? Ask away: http://ask.fedoraproject.org
[no subject]
-- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [camellia-oss:00952] Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization
Hi, Sun, 18 Nov 2007 20:30:16 -0800 [Subject: Re: [camellia-oss:00952] Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization] Denys Vlasenko [EMAIL PROTECTED] wrote... camellia6: unifies encrypt/decrypt routines for different key lengths. This reduces module size by ~25%, with tiny (less than 1%) speed impact. Also collapses encrypt/decrypt into more readable (visually shorter) form using macros. And here is camellia7: Move key XOR is end of F-function code part into camellia_setup_tail(), it is sufficiently similar between camellia_setup128 and camellia_setup256. This shaves off another ~1k: dec hex filename 2141453a6 2.6.23.1.camellia6.t/crypto/camellia.o 205185026 2.6.23.1.camellia7.t/crypto/camellia.o 163553fe3 2.6.23.1.camellia6.t64/crypto/camellia.o 158133dc5 2.6.23.1.camellia7.t64/crypto/camellia.o At the moment I cannot run test it, try to do it ASAP. Takamiya-san, can you review attached patch please? Sorry for late reply. I think you're testing now:-), and if speed impact is less than 1% as you say, I think it is acceptable. The smaller code size is, the easier to enable camellia in the embedded systems. Regards, Acked-by: Noriaki TAKAMIYA [EMAIL PROTECTED] -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [camellia-oss:00952] Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization
Hi, Tue, 13 Nov 2007 19:47:08 -0700 [Subject: Re: [camellia-oss:00952] Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization] Denys Vlasenko [EMAIL PROTECTED] wrote... On Tuesday 13 November 2007 18:41, David Miller wrote: From: Denys Vlasenko [EMAIL PROTECTED] Date: Tue, 13 Nov 2007 15:34:33 -0700 My preferred solution is to make loop unrolling conditional on CONFIG_CC_OPTIMIZE_FOR_SIZE - and this is what is done in my (first) patch (see attached). This part: The default build is going to be CONFIG_CC_OPTIMIZE_FOR_SIZE basically for everyone, this is what people get by default and this is what every distribution uses. Therefore %99. of folks will get the slowdown. So in my book this is not an acceptable way to deal with this problem. Loop unrolling here amounts to 25% code growth: textdata bss dec hex filename 21714 0 0 2171454d2 camellia5.o 15906 0 0 159063e22 camellia5_Os.o Saving 25% or code size and going 5% slower is perfectly acceptable tradeof for some users. NB: I'm not saying all, ut some significant part of users would like to be able to have this choice. IMHO, if you are going to use camellia on the embedded system, size of code will be important. On the other hand, I think typically the CPU performance is restricted on the embedded system, so the performance of code will be important... I'm not sure 5% slow down is important or not. It will depend on the system. Regards, -- Noriaki TAKAMYA - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization
Hi, Sorry for late reply Thu, 8 Nov 2007 21:30:20 +0800 頃、 [Subject: Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization] において、 Herbert Xu [EMAIL PROTECTED]さんが書きました On Wed, Nov 07, 2007 at 01:22:52PM +, Denys Vlasenko wrote: *I* am happy with 5% speed sacrifice. I'm afraid other people won't be. I'd like to hear the opinion of the author. Takamiya-san, what do you think about this change? For IPsec processing, I think performance is important. If this fix improves the performance, it is acceptable. But, there are many duplicate decralations between camellia.c and camellia_64.c... (e.g., CAMELLIA_MIN_KEY_SIZE and so on) Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [camellia-oss:00952] Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization
Hi, sorry, again. Tue, 13 Nov 2007 15:07:02 +0900 (JST) [Subject: [camellia-oss:00952] Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization] Noriaki TAKAMIYA [EMAIL PROTECTED] wrote... I'd like to hear the opinion of the author. Takamiya-san, what do you think about this change? For IPsec processing, I think performance is important. If this fix improves the performance, it is acceptable. I misunderstood the meaning. If this fix decreases the performance, I wouldn't prefer this patch(and the below is also one of the reason). But, there are many duplicate decralations between camellia.c and camellia_64.c... (e.g., CAMELLIA_MIN_KEY_SIZE and so on) Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization
Thu, 25 Oct 2007 12:48:29 +0100 [Subject: [PATCH 5/5] camellia: de-unrolling, 64bit-ization] Denys Vlasenko [EMAIL PROTECTED] wrote... On Thursday 25 October 2007 12:43, Denys Vlasenko wrote: Hi Hervert, Please review and maybe propagate upstream following patches. camellia5.diff Use alternative key setup implementation with mostly 64-bit ops if BITS_PER_LONG = 64. Both much smaller and much faster. Unify camellia_en/decrypt128/256 into camellia_do_en/decrypt. Code was similar, with just one additional if() we can use came code. If CONFIG_CC_OPTIMIZE_FOR_SIZE is defined, use loop in camellia_do_en/decrypt instead of unrolled code. ~5% encrypt/decrypt slowdown. Replace (x 0xff) with (u8)x, gcc is not smart enough to realize that it can do (x 0xff) this way (which is smaller at least on i386). Don't do (x 0xff) in a few places where x cannot be 255 anyway: t0 = il 16; v = camellia_sp0222[(t1 8) 0xff]; il16 is u32, (thus t1 8) is one byte! Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda Acked-by: Noriaki TAKAMIYA [EMAIL PROTECTED] -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/5] camellia: de-unrolling
Hi, Thu, 25 Oct 2007 12:47:16 +0100 [Subject: [PATCH 4/5] camellia: de-unrolling] Denys Vlasenko [EMAIL PROTECTED] wrote... On Thursday 25 October 2007 12:43, Denys Vlasenko wrote: Hi Hervert, Please review and maybe propagate upstream following patches. camellia4.diff Move huge unrolled pieces of code (3 screenfuls) at the end of 128/256 key setup routines into common camellia_setup_tail(), convert it to loop there. Loop is still unrolled six times, so performance hit is very small, code size win is big. Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda Acked-by: Noriaki TAKAMIYA [EMAIL PROTECTED] -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/5] camellia: cleanup
Thu, 25 Oct 2007 12:46:35 +0100 [Subject: [PATCH 3/5] camellia: cleanup] Denys Vlasenko [EMAIL PROTECTED] wrote... On Thursday 25 October 2007 12:43, Denys Vlasenko wrote: Hi Hervert, Please review and maybe propagate upstream following patches. camellia3.diff Optimize GETU32 to use 4-byte memcpy (modern gcc will convert such memcpy to single move instruction on i386). Original GETU32 did four byte fetches, and shifted/XORed those. Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] Acked-by: Noriaki TAKAMIYA [EMAIL PROTECTED] -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/5] camellia: cleanup
Hi, Thu, 25 Oct 2007 12:45:04 +0100 [Subject: [PATCH 1/5] camellia: cleanup] Denys Vlasenko [EMAIL PROTECTED] wrote... On Thursday 25 October 2007 12:43, Denys Vlasenko wrote: Hi Hervert, Please review and maybe propagate upstream following patches. camellia1.diff: Move code blocks around so that related pieces are closer together: e.g. CAMELLIA_ROUNDSM macro does not need to be separated from the rest of the code by huge array of constants. Remove unused macros (COPY4WORD, SWAP4WORD, XOR4WORD[2]) Drop SUBL(), SUBR() macros which only obscure things. Same for CAMELLIA_SP1110() macro and KEY_TABLE_TYPE typedef. Remove useless comments: /* encryption */ -- well it's obvious enough already! void camellia_encrypt128(...) Combine swap with copying at the beginning/end of encrypt/decrypt. Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] Acked-by: Noriaki TAKAMIYA [EMAIL PROTECTED] -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use
Hi, >> Mon, 15 Oct 2007 11:45:10 +0900 >> [Subject: Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use] >> Masahide NAKAMURA <[EMAIL PROTECTED]> wrote... > > On Sun, 14 Oct 2007 19:52:12 +0200 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > The Coverity checker spotted that we have already oops'ed if "dst" > > was NULL. > > > > Since "dst" being NULL doesn't seem to be possible at this point this > > patch removes the NULL check. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > Agreed. > > Acked-by: Masahide NAKAMURA <[EMAIL PROTECTED]> I also agreed. Acked-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]> -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use
Hi, Mon, 15 Oct 2007 11:45:10 +0900 [Subject: Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use] Masahide NAKAMURA [EMAIL PROTECTED] wrote... On Sun, 14 Oct 2007 19:52:12 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: The Coverity checker spotted that we have already oops'ed if dst was NULL. Since dst being NULL doesn't seem to be possible at this point this patch removes the NULL check. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Agreed. Acked-by: Masahide NAKAMURA [EMAIL PROTECTED] I also agreed. Acked-by: Noriaki TAKAMIYA [EMAIL PROTECTED] -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use
Hi, Mon, 15 Oct 2007 11:45:10 +0900 [Subject: Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use] Masahide NAKAMURA [EMAIL PROTECTED] wrote... On Sun, 14 Oct 2007 19:52:12 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: The Coverity checker spotted that we have already oops'ed if dst was NULL. Since dst being NULL doesn't seem to be possible at this point this patch removes the NULL check. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Agreed. Acked-by: Masahide NAKAMURA [EMAIL PROTECTED] I also agreed. Acked-by: Noriaki TAKAMIYA [EMAIL PROTECTED] -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: net-26.24 broken with XFRM off
Hi, >> Thu, 6 Sep 2007 10:13:26 +0200 >> [Subject: Re: net-26.24 broken with XFRM off] >> Eric Dumazet <[EMAIL PROTECTED]> wrote... > Hi Divy > > I believe this problem is known. > > Please check http://marc.info/?l=linux-netdev=118881627028135=2 I'm sorry not to check more precisely. As Eric said, this issue should be fixed by the patch attached in the following mail. Regards, >> Mon, 03 Sep 2007 19:43:51 +0900 >> [Subject: Re: [-mm patch] IPV6 must select XFRM] >> Masahide NAKAMURA <[EMAIL PROTECTED]> wrote... > Thank you for catching this. the issue is caused with patch > "[IPV6] XFRM: Fix connected socket to use transformation." > which I sent to netdev. > (a85d5450ddeb959bdf9e4603f9c06e9d79217cfa on net-2.6.24). > > I'd prefer to modify the original patch to use "ifdef CONFIG_XFRM" > than changing kernel config depends. Does it make sense? > > Please review the attached patch. > > -- > Masahide NAKAMURA -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: net-26.24 broken with XFRM off
Hi, Thu, 6 Sep 2007 10:13:26 +0200 [Subject: Re: net-26.24 broken with XFRM off] Eric Dumazet [EMAIL PROTECTED] wrote... Hi Divy I believe this problem is known. Please check http://marc.info/?l=linux-netdevm=118881627028135w=2 I'm sorry not to check more precisely. As Eric said, this issue should be fixed by the patch attached in the following mail. Regards, Mon, 03 Sep 2007 19:43:51 +0900 [Subject: Re: [-mm patch] IPV6 must select XFRM] Masahide NAKAMURA [EMAIL PROTECTED] wrote... Thank you for catching this. the issue is caused with patch [IPV6] XFRM: Fix connected socket to use transformation. which I sent to netdev. (a85d5450ddeb959bdf9e4603f9c06e9d79217cfa on net-2.6.24). I'd prefer to modify the original patch to use ifdef CONFIG_XFRM than changing kernel config depends. Does it make sense? Please review the attached patch. -- Masahide NAKAMURA -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: net-26.24 broken with XFRM off
Hi, Thu, 6 Sep 2007 10:13:26 +0200 [Subject: Re: net-26.24 broken with XFRM off] Eric Dumazet [EMAIL PROTECTED] wrote... Hi Divy I believe this problem is known. Please check http://marc.info/?l=linux-netdevm=118881627028135w=2 I'm sorry not to check more precisely. As Eric said, this issue should be fixed by the patch attached in the following mail. Regards, Mon, 03 Sep 2007 19:43:51 +0900 [Subject: Re: [-mm patch] IPV6 must select XFRM] Masahide NAKAMURA [EMAIL PROTECTED] wrote... Thank you for catching this. the issue is caused with patch [IPV6] XFRM: Fix connected socket to use transformation. which I sent to netdev. (a85d5450ddeb959bdf9e4603f9c06e9d79217cfa on net-2.6.24). I'd prefer to modify the original patch to use ifdef CONFIG_XFRM than changing kernel config depends. Does it make sense? Please review the attached patch. -- Masahide NAKAMURA -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [XFRM] Camellia: fixed to add compat name for Camellia.
Hi, Sorry for late reply. Wed, 16 May 2007 19:18:56 +1000 [Subject: Re: [PATCH] [XFRM] Camellia: fixed to add compat name for Camellia.] Herbert Xu [EMAIL PROTECTED] wrote... Actually this was deliberate. The compat name only exists so that existing users aren't broken. New users should always configure it with the full name, that is, cbc(camellia). Thank you for clarification. Is there a case where this is difficult? As you said, ipsec-tools(setkey) won't have such problem. I think of the user who uses iproute(ip). Now, 2.6.21 is going to be shipped in Fedora Core7. So the user of Camellia on the FC7 must use keyword cbc(camellia) with iproute. I know it is my miss, but I hope this fix mamkes the configuration to be more easy by using iproute. Regards, P.S. I don't know how many users use iproute to set IPsec:-). -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: (usagi-core 32652) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
>> Tue, 27 Mar 2007 15:51:39 -0700 >> [Subject: (usagi-core 32652) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] >> [USB] fixed to skip NULL entry in struct serial usb_serial_port.] >> Greg KH <[EMAIL PROTECTED]> wrote... > > I think so. But I wonder if usb_get_serial_port_data() should check > > the argument for the other drivers. > > I don't think it is really necessary, do you? I see. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [linux-usb-devel] (usagi-core 32652) Re: [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Tue, 27 Mar 2007 15:51:39 -0700 [Subject: (usagi-core 32652) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.] Greg KH [EMAIL PROTECTED] wrote... I think so. But I wonder if usb_get_serial_port_data() should check the argument for the other drivers. I don't think it is really necessary, do you? I see. -- Noriaki TAKAMIYA - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [PATCH net-2.6.22] [IPV6] FIB6RULE: Find source address during looking up route.
Hi, Wed, 28 Mar 2007 12:49:40 +0900 (JST) [Subject: Re: [PATCH net-2.6.22] [IPV6] FIB6RULE: Find source address during looking up route.] YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote... Out of curiosity, what sort of rules would have this flag set? The majority of lookups don't provide a valid source address. This new address search could become very expensive, because none of the results are cached. This flags is used for Mobile IPv6. Well, for non-connected sockets on hosts, yes, the process might not be light-weight. But, on routers, or once the socket is connected, source address should be always set. Even if you set the rule which has the condition regarding as the source address, this rule is not selected for the first packet because the source address is not chosen yet. This fix is required to do source address based routing using fib6_rules. #Even if the same routing with subtrees, the same problem is caused. Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: (usagi-core 32652) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Tue, 27 Mar 2007 15:51:39 -0700 [Subject: (usagi-core 32652) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.] Greg KH [EMAIL PROTECTED] wrote... I think so. But I wonder if usb_get_serial_port_data() should check the argument for the other drivers. I don't think it is really necessary, do you? I see. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32640) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, >> Sun, 25 Mar 2007 08:55:21 -0700 >> [Subject: (usagi-core 32640) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] >> [USB] fixed to skip NULL entry in struct serial usb_serial_port.] >> Greg KH <[EMAIL PROTECTED]> wrote... > > Yes, this problem was already fixed. > > Great, thanks for testing. So I guess both of these patches are no > longer necessary, right? I think so. But I wonder if usb_get_serial_port_data() should check the argument for the other drivers. Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [linux-usb-devel] (usagi-core 32640) Re: [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, Sun, 25 Mar 2007 08:55:21 -0700 [Subject: (usagi-core 32640) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.] Greg KH [EMAIL PROTECTED] wrote... Yes, this problem was already fixed. Great, thanks for testing. So I guess both of these patches are no longer necessary, right? I think so. But I wonder if usb_get_serial_port_data() should check the argument for the other drivers. Regards, -- Noriaki TAKAMIYA - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: (usagi-core 32640) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, Sun, 25 Mar 2007 08:55:21 -0700 [Subject: (usagi-core 32640) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.] Greg KH [EMAIL PROTECTED] wrote... Yes, this problem was already fixed. Great, thanks for testing. So I guess both of these patches are no longer necessary, right? I think so. But I wonder if usb_get_serial_port_data() should check the argument for the other drivers. Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32638) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, >> Sat, 24 Mar 2007 14:22:53 -0700 >> [Subject: (usagi-core 32638) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] >> [USB] fixed to skip NULL entry in struct serial usb_serial_port.] >> Greg KH <[EMAIL PROTECTED]> wrote... > This should already be fixed in the -git snapshots that have come out > after 2.6.21-rc4. Can you test them to verify this? Yes, this problem was already fixed. Thanks. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Hi,
While booting, this entry is set to NULL in destroy_serial(),
but serial->port is referred again in pl2303_shutdown() via
serial->type->shutdown.
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg("%s", __FUNCTION__);
for (i = 0; i < serial->num_ports; ++i) {
+ if (!serial->port[i])
+ continue;
priv = usb_get_serial_port_data(serial->port[i]);
if (priv) {
pl2303_buf_free(priv->buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Sorry for resending.
While booting, this entry is set to NULL in destroy_serial(),
but serial->port is referred again in pl2303_shutdown() via
serial->type->shutdown.
Signed-off-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]>
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg("%s", __FUNCTION__);
for (i = 0; i < serial->num_ports; ++i) {
+ if (!serial->port[i])
+ continue;
priv = usb_get_serial_port_data(serial->port[i]);
if (priv) {
pl2303_buf_free(priv->buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.
Hi,
This patch fixes to skip serial->port[i] if it is set NULL.
---
include/linux/usb/serial.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h
index 32acbae..85ed5ef 100644
--- a/include/linux/usb/serial.h
+++ b/include/linux/usb/serial.h
@@ -99,7 +99,10 @@ struct usb_serial_port {
/* get and set the port private data pointer helper functions */
static inline void *usb_get_serial_port_data (struct usb_serial_port *port)
{
- return dev_get_drvdata(>dev);
+ if (port)
+ return dev_get_drvdata(>dev);
+ else
+ return NULL;
}
static inline void usb_set_serial_port_data (struct usb_serial_port *port,
void *data)
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Sorry for resending
Hi,
While booting, this entry is set to NULL in destroy_serial(),
but serial->port is referred again in pl2303_shutdown() via
serial->type->shutdown.
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg("%s", __FUNCTION__);
for (i = 0; i < serial->num_ports; ++i) {
+ if (!serial->port[i])
+ continue;
priv = usb_get_serial_port_data(serial->port[i]);
if (priv) {
pl2303_buf_free(priv->buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, When I boot using linux-2.6.21-rc4 on ThinkPad T41 with pl2303 USB serial device plugged in, the kernel crashes. The reason is struct usb_serial_port is referenced without checking whether it is NULL or not. Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32634) [PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.
Sorry for resending.
Hi,
This patch fixes to skip serial->port[i] if it is set NULL.
Signed-off-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]>
---
include/linux/usb/serial.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h
index 32acbae..85ed5ef 100644
--- a/include/linux/usb/serial.h
+++ b/include/linux/usb/serial.h
@@ -99,7 +99,10 @@ struct usb_serial_port {
/* get and set the port private data pointer helper functions */
static inline void *usb_get_serial_port_data (struct usb_serial_port *port)
{
- return dev_get_drvdata(>dev);
+ if (port)
+ return dev_get_drvdata(>dev);
+ else
+ return NULL;
}
static inline void usb_set_serial_port_data (struct usb_serial_port *port,
void *data)
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, When I boot using linux-2.6.21-rc4 on ThinkPad T41 with pl2303 USB serial device plugged in, the kernel crashes. The reason is struct usb_serial_port is referenced without checking whether it is NULL or not. Regards, -- Noriaki TAKAMIYA - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
[linux-usb-devel] [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Hi,
While booting, this entry is set to NULL in destroy_serial(),
but serial-port is referred again in pl2303_shutdown() via
serial-type-shutdown.
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg(%s, __FUNCTION__);
for (i = 0; i serial-num_ports; ++i) {
+ if (!serial-port[i])
+ continue;
priv = usb_get_serial_port_data(serial-port[i]);
if (priv) {
pl2303_buf_free(priv-buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
[linux-usb-devel] [PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.
Hi,
This patch fixes to skip serial-port[i] if it is set NULL.
---
include/linux/usb/serial.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h
index 32acbae..85ed5ef 100644
--- a/include/linux/usb/serial.h
+++ b/include/linux/usb/serial.h
@@ -99,7 +99,10 @@ struct usb_serial_port {
/* get and set the port private data pointer helper functions */
static inline void *usb_get_serial_port_data (struct usb_serial_port *port)
{
- return dev_get_drvdata(port-dev);
+ if (port)
+ return dev_get_drvdata(port-dev);
+ else
+ return NULL;
}
static inline void usb_set_serial_port_data (struct usb_serial_port *port,
void *data)
--
1.4.4
--
Noriaki TAKAMIYA
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Sorry for resending.
While booting, this entry is set to NULL in destroy_serial(),
but serial-port is referred again in pl2303_shutdown() via
serial-type-shutdown.
Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED]
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg(%s, __FUNCTION__);
for (i = 0; i serial-num_ports; ++i) {
+ if (!serial-port[i])
+ continue;
priv = usb_get_serial_port_data(serial-port[i]);
if (priv) {
pl2303_buf_free(priv-buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] (usagi-core 32634) [PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.
Sorry for resending.
Hi,
This patch fixes to skip serial-port[i] if it is set NULL.
Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED]
---
include/linux/usb/serial.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h
index 32acbae..85ed5ef 100644
--- a/include/linux/usb/serial.h
+++ b/include/linux/usb/serial.h
@@ -99,7 +99,10 @@ struct usb_serial_port {
/* get and set the port private data pointer helper functions */
static inline void *usb_get_serial_port_data (struct usb_serial_port *port)
{
- return dev_get_drvdata(port-dev);
+ if (port)
+ return dev_get_drvdata(port-dev);
+ else
+ return NULL;
}
static inline void usb_set_serial_port_data (struct usb_serial_port *port,
void *data)
--
1.4.4
--
Noriaki TAKAMIYA
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Sorry for resending
Hi,
While booting, this entry is set to NULL in destroy_serial(),
but serial-port is referred again in pl2303_shutdown() via
serial-type-shutdown.
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg(%s, __FUNCTION__);
for (i = 0; i serial-num_ports; ++i) {
+ if (!serial-port[i])
+ continue;
priv = usb_get_serial_port_data(serial-port[i]);
if (priv) {
pl2303_buf_free(priv-buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV
___
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: [linux-usb-devel] (usagi-core 32638) Re: [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, Sat, 24 Mar 2007 14:22:53 -0700 [Subject: (usagi-core 32638) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.] Greg KH [EMAIL PROTECTED] wrote... This should already be fixed in the -git snapshots that have come out after 2.6.21-rc4. Can you test them to verify this? Yes, this problem was already fixed. Thanks. -- Noriaki TAKAMIYA - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
Re: (usagi-core 32634) [PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.
Sorry for resending.
Hi,
This patch fixes to skip serial-port[i] if it is set NULL.
Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED]
---
include/linux/usb/serial.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h
index 32acbae..85ed5ef 100644
--- a/include/linux/usb/serial.h
+++ b/include/linux/usb/serial.h
@@ -99,7 +99,10 @@ struct usb_serial_port {
/* get and set the port private data pointer helper functions */
static inline void *usb_get_serial_port_data (struct usb_serial_port *port)
{
- return dev_get_drvdata(port-dev);
+ if (port)
+ return dev_get_drvdata(port-dev);
+ else
+ return NULL;
}
static inline void usb_set_serial_port_data (struct usb_serial_port *port,
void *data)
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, When I boot using linux-2.6.21-rc4 on ThinkPad T41 with pl2303 USB serial device plugged in, the kernel crashes. The reason is struct usb_serial_port is referenced without checking whether it is NULL or not. Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Hi,
While booting, this entry is set to NULL in destroy_serial(),
but serial-port is referred again in pl2303_shutdown() via
serial-type-shutdown.
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg(%s, __FUNCTION__);
for (i = 0; i serial-num_ports; ++i) {
+ if (!serial-port[i])
+ continue;
priv = usb_get_serial_port_data(serial-port[i]);
if (priv) {
pl2303_buf_free(priv-buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Sorry for resending.
While booting, this entry is set to NULL in destroy_serial(),
but serial-port is referred again in pl2303_shutdown() via
serial-type-shutdown.
Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED]
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg(%s, __FUNCTION__);
for (i = 0; i serial-num_ports; ++i) {
+ if (!serial-port[i])
+ continue;
priv = usb_get_serial_port_data(serial-port[i]);
if (priv) {
pl2303_buf_free(priv-buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.
Hi,
This patch fixes to skip serial-port[i] if it is set NULL.
---
include/linux/usb/serial.h |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h
index 32acbae..85ed5ef 100644
--- a/include/linux/usb/serial.h
+++ b/include/linux/usb/serial.h
@@ -99,7 +99,10 @@ struct usb_serial_port {
/* get and set the port private data pointer helper functions */
static inline void *usb_get_serial_port_data (struct usb_serial_port *port)
{
- return dev_get_drvdata(port-dev);
+ if (port)
+ return dev_get_drvdata(port-dev);
+ else
+ return NULL;
}
static inline void usb_set_serial_port_data (struct usb_serial_port *port,
void *data)
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.
Sorry for resending
Hi,
While booting, this entry is set to NULL in destroy_serial(),
but serial-port is referred again in pl2303_shutdown() via
serial-type-shutdown.
---
drivers/usb/serial/pl2303.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 83dfae9..d631f8c 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -905,6 +905,8 @@ static void pl2303_shutdown(struct usb_s
dbg(%s, __FUNCTION__);
for (i = 0; i serial-num_ports; ++i) {
+ if (!serial-port[i])
+ continue;
priv = usb_get_serial_port_data(serial-port[i]);
if (priv) {
pl2303_buf_free(priv-buf);
--
1.4.4
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: (usagi-core 32638) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.
Hi, Sat, 24 Mar 2007 14:22:53 -0700 [Subject: (usagi-core 32638) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.] Greg KH [EMAIL PROTECTED] wrote... This should already be fixed in the -git snapshots that have come out after 2.6.21-rc4. Can you test them to verify this? Yes, this problem was already fixed. Thanks. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[IPROUTE][IP]: enabled to manipulate the flags of IFA_F_HOMEADDRESS or IFA_F_NODAD from ip.
Hi,
This patch enables ip command to add IFA_F_HOMEADDRESS and
IFA_F_NODAD flags while adding the IPv6 address.
Signed-off-by: Noriaki TAKAMIYA[EMAIL PROTECTED]
Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED]
---
ip/ipaddress.c | 23 ++-
1 files changed, 22 insertions(+), 1 deletions(-)
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index cae1fcd..98effa3 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -61,6 +61,7 @@ static void usage(void)
iplink_usage();
}
fprintf(stderr, Usage: ip addr {add|change|replace} IFADDR dev STRING
[ LIFETIME ]\n);
+ fprintf(stderr,
[ CONFFLAG-LIST]\n);
fprintf(stderr,ip addr del IFADDR dev STRING\n);
fprintf(stderr,ip addr {show|flush} [ dev STRING ] [ scope
SCOPE-ID ]\n);
fprintf(stderr, [ to PREFIX ] [ FLAG-LIST
] [ label PATTERN ]\n);
@@ -70,7 +71,9 @@ static void usage(void)
fprintf(stderr, SCOPE-ID := [ host | link | global | NUMBER ]\n);
fprintf(stderr, FLAG-LIST := [ FLAG-LIST ] FLAG\n);
fprintf(stderr, FLAG := [ permanent | dynamic | secondary | primary
|\n);
- fprintf(stderr,tentative | deprecated ]\n);
+ fprintf(stderr,tentative | deprecated | CONFFLAG-LIST
]\n);
+ fprintf(stderr, CONFFLAG-LIST := [ CONFFLAG-LIST ] CONFFLAG\n);
+ fprintf(stderr, CONFFLAG := [ home | nodad ]\n);
fprintf(stderr, LIFETIME := [ valid_lft LFT ] [ preferred_lft LFT
]\n);
fprintf(stderr, LFT := forever | SECONDS\n);
@@ -427,6 +430,14 @@ int print_addrinfo(const struct sockaddr
ifa-ifa_flags = ~IFA_F_DEPRECATED;
fprintf(fp, deprecated );
}
+ if (ifa-ifa_flagsIFA_F_HOMEADDRESS) {
+ ifa-ifa_flags = ~IFA_F_HOMEADDRESS;
+ fprintf(fp, home );
+ }
+ if (ifa-ifa_flagsIFA_F_NODAD) {
+ ifa-ifa_flags = ~IFA_F_NODAD;
+ fprintf(fp, nodad );
+ }
if (!(ifa-ifa_flagsIFA_F_PERMANENT)) {
fprintf(fp, dynamic );
} else
@@ -567,6 +578,12 @@ int ipaddr_list_or_flush(int argc, char
} else if (strcmp(*argv, deprecated) == 0) {
filter.flags |= IFA_F_DEPRECATED;
filter.flagmask |= IFA_F_DEPRECATED;
+ } else if (strcmp(*argv, home) == 0) {
+ filter.flags |= IFA_F_HOMEADDRESS;
+ filter.flagmask |= IFA_F_HOMEADDRESS;
+ } else if (strcmp(*argv, nodad) == 0) {
+ filter.flags |= IFA_F_NODAD;
+ filter.flagmask |= IFA_F_NODAD;
} else if (strcmp(*argv, label) == 0) {
NEXT_ARG();
filter.label = *argv;
@@ -844,6 +861,10 @@ int ipaddr_modify(int cmd, int flags, in
preferred_lftp = *argv;
if (set_lifetime(preferred_lft, *argv))
invarg(preferred_lft value, *argv);
+ } else if (strcmp(*argv, home) == 0) {
+ req.ifa.ifa_flags |= IFA_F_HOMEADDRESS;
+ } else if (strcmp(*argv, nodad) == 0) {
+ req.ifa.ifa_flags |= IFA_F_NODAD;
} else {
if (strcmp(*argv, local) == 0) {
NEXT_ARG();
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC][PATCH][IPSEC][2/3] IPv6 over IPv4 IPsec tunnel
Hi, More fix is needed for __xfrm6_bundle_create(). Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] Acked-by: Masahide NAKAMURA [EMAIL PROTECTED] -- fixed to set fl_tunnel.fl6_src correctly in xfrm6_bundle_create(). --- net/ipv6/xfrm6_policy.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index b1133f2..d8a585b 100644 --- a/net/ipv6/xfrm6_policy.c +++ b/net/ipv6/xfrm6_policy.c @@ -189,7 +189,7 @@ __xfrm6_bundle_create(struct xfrm_policy case AF_INET6: ipv6_addr_copy(fl_tunnel.fl6_dst, __xfrm6_bundle_addr_remote(xfrm[i], fl-fl6_dst)); - ipv6_addr_copy(fl_tunnel.fl6_src, __xfrm6_bundle_addr_remote(xfrm[i], fl-fl6_src)); + ipv6_addr_copy(fl_tunnel.fl6_src, __xfrm6_bundle_addr_local(xfrm[i], fl-fl6_src)); break; default: BUG_ON(1); -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [IPV6] fixed the size of the netlink message notified by inet6_rt_notify().
Hi, Wed, 17 Jan 2007 13:33:22 +0100 [Subject: Re: [PATCH] [IPV6] fixed the size of the netlink message notified by inet6_rt_notify().] Patrick McHardy [EMAIL PROTECTED] wrote... Somewhat related: I have this patch for 2.6.21 to get rid of the BUG_ON()s. I think the problem is the return value of inet6_rt_notify() is less than expected. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] [IPV6] fixed the size of the netlink message notified by inet6_rt_notify().
Hi, I think the return value of rt6_nlmsg_size() should includes the amount of RTA_METRICS. Regards, --- net/ipv6/route.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 8c3d568..5f0043c 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2017,6 +2017,7 @@ static inline size_t rt6_nlmsg_size(void + nla_total_size(4) /* RTA_IIF */ + nla_total_size(4) /* RTA_OIF */ + nla_total_size(4) /* RTA_PRIORITY */ + + RTAX_MAX * nla_total_size(4) /* RTA_METRICS */ + nla_total_size(sizeof(struct rta_cacheinfo)); } -- 1.4.4 -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [IPV6] fixed the size of the netlink message notified by inet6_rt_notify().
Hi, I'm sorry to re-send... I think the return value of rt6_nlmsg_size() should includes the amount of RTA_METRICS. Regards, Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] --- net/ipv6/route.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 8c3d568..5f0043c 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2017,6 +2017,7 @@ static inline size_t rt6_nlmsg_size(void + nla_total_size(4) /* RTA_IIF */ + nla_total_size(4) /* RTA_OIF */ + nla_total_size(4) /* RTA_PRIORITY */ + + RTAX_MAX * nla_total_size(4) /* RTA_METRICS */ + nla_total_size(sizeof(struct rta_cacheinfo)); } -- 1.4.4 -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.
Hi, Wed, 27 Dec 2006 13:57:23 +0900 [Subject: Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.] Masahide NAKAMURA [EMAIL PROTECTED] wrote Anyway, we have 4 options. 1. IPV6_CHECKSUM default for IPPROTO_MH == 4 omit checksumming in mip6_mh_filter() 2. IPV6_CHECKSUM default for IPPROTO_MH == -1 omit checksumming in mip6_mh_filter() 3. IPV6_CHECKSUM for IPPROTO_MH == 4 always perform checksumming in mip6_mh_filter() 4. IPV6_CHECKSUM default for IPPROTO_MH == -1 always perform checksumming in mip6_mh_filter() Current behavior is 4, but it is not appropriate. I guess 1 is the way to go. I would like to have 1, too. I think 1. is suitable. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/6] [CRYPTO] added the code of Camellia cipher algorithm.
Hi, Sun, 22 Oct 2006 15:09:54 +1000 [Subject: Re: [PATCH 2/6] [CRYPTO] added the code of Camellia cipher algorithm.] Herbert Xu [EMAIL PROTECTED] wrote... On Wed, Oct 18, 2006 at 07:16:47AM +, Noriaki TAKAMIYA wrote: +static int +camellia_set_key(struct crypto_tfm *tfm, const u8 *in_key, +unsigned int key_len, u32 *flags) Ugh, this doesn't compile with the current tree since the flags field no longer exists for set_key. I've fixed it up in my tree. The tree I referred might be little bit old... Thank you for your fix. Regards, -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/6] Changeset of Camellia cipher algorithm.
Hi, Sun, 22 Oct 2006 15:07:47 +1000 [Subject: Re: [PATCH 0/6] Changeset of Camellia cipher algorithm.] Herbert Xu [EMAIL PROTECTED] wrote On Wed, Oct 18, 2006 at 07:15:10AM +, Noriaki TAKAMIYA wrote: [PATCH 1/6] [CRYPTO] added Kconfig entry for Camellia. [PATCH 2/6] [CRYPTO] added the code of Camellia cipher algorithm. [PATCH 3/6] [CRYPTO] added the testing code of Camellia cipher algorithm. [PATCH 4/6] [IPSEC] added the definition of Camellia cipher algorithm. [PATCH 5/6] [IPSEC] added the entry of Camellia cipher algorithm to ealg_list[]. [PATCH 6/6] [CRYPTO] added the developer of Camellia cipher algorithm. I've applied all the patches to cryptodev-2.6. Thanks! Thank you! -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/6] Changeset of Camellia cipher algorithm.
Hi, This set of the patches enables to use of the Camellia cipher algorithm for the ESP encryption. Git tree is also available on camellia20061017 branch at: git://git.skbuff.net/gitroot/takamiya/camellia20061017 The following patches are available for the top of davem's net-2.6 and herbert's cryptodev-2.6 trees. Thank you. HEADLINES - [PATCH 1/6] [CRYPTO] added Kconfig entry for Camellia. [PATCH 2/6] [CRYPTO] added the code of Camellia cipher algorithm. [PATCH 3/6] [CRYPTO] added the testing code of Camellia cipher algorithm. [PATCH 4/6] [IPSEC] added the definition of Camellia cipher algorithm. [PATCH 5/6] [IPSEC] added the entry of Camellia cipher algorithm to ealg_list[]. [PATCH 6/6] [CRYPTO] added the developer of Camellia cipher algorithm. DIFFSTAT Documentation/crypto/api-intro.txt |5 crypto/Kconfig | 15 crypto/Makefile|1 crypto/camellia.c | 1802 - crypto/tcrypt.c| 43 crypto/tcrypt.h| 166 +++ include/linux/pfkeyv2.h|2 net/xfrm/xfrm_algo.c | 18 8 files changed, 2045 insertions(+), 7 deletions(-) CHANGESETS -- commit 80a5df8127311212e99bd64103771de19c5908dd Author: Noriaki TAKAMIYA [EMAIL PROTECTED] Date: Tue Oct 17 01:51:40 2006 +0900 [CRYPTO] added the developer of Camellia cipher algorithm. This patch adds the developer of Camellia cipher algorithm. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] commit 2253254f5a802c1cc8a5fc367fae911172f28846 Author: Noriaki TAKAMIYA [EMAIL PROTECTED] Date: Tue Oct 17 01:47:32 2006 +0900 [IPSEC] added the entry of Camellia cipher algorithm to ealg_list[]. This patch adds the entry of Camellia cipher algorithm to ealg_list[]. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] commit 1b6712cdb8fd31482d7e7da56e5f602357ec4aa4 Author: Noriaki TAKAMIYA [EMAIL PROTECTED] Date: Tue Oct 17 01:45:24 2006 +0900 [IPSEC] added the definition of Camellia cipher algorithm. This patch adds the definitions used by pfkeyv2 interface for Camellia cipher algorithm. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] commit e86050d8fbd04b1ace9c121ce90799c8210925be Author: Noriaki TAKAMIYA [EMAIL PROTECTED] Date: Tue Oct 17 01:43:14 2006 +0900 [CRYPTO] added the testing code of Camellia cipher algorithm. This patch adds the code of Camellia code for testing module. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] commit db41e54cb7081b4cd034378f17b8f8225586e2e2 Author: Noriaki TAKAMIYA [EMAIL PROTECTED] Date: Tue Oct 17 01:34:15 2006 +0900 [CRYPTO] added the code of Camellia cipher algorithm. This patch adds the main code of Camellia cipher algorithm. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] commit 01b0c3898fdf1cb4da8cdf5577e58328ecb11e4e Author: Noriaki TAKAMIYA [EMAIL PROTECTED] Date: Tue Oct 17 01:31:35 2006 +0900 [CRYPTO] added Kconfig entry for Camellia. This patch adds the Kconfig entry for Camellia. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/6] [IPSEC] added the definition of Camellia cipher algorithm.
This patch adds the definitions used by pfkeyv2 interface for Camellia cipher algorithm. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] --- include/linux/pfkeyv2.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) 1b6712cdb8fd31482d7e7da56e5f602357ec4aa4 diff --git a/include/linux/pfkeyv2.h b/include/linux/pfkeyv2.h index d5dd471..b16e474 100644 --- a/include/linux/pfkeyv2.h +++ b/include/linux/pfkeyv2.h @@ -296,6 +296,7 @@ #define SADB_X_EALG_CASTCBC 6 #define SADB_X_EALG_BLOWFISHCBC7 #define SADB_EALG_NULL 11 #define SADB_X_EALG_AESCBC 12 +#define SADB_X_EALG_CAMELLIACBC22 #define SADB_EALG_MAX 253 /* last EALG */ /* private allocations should use 249-255 (RFC2407) */ #define SADB_X_EALG_SERPENTCBC 252 /* draft-ietf-ipsec-ciph-aes-cbc-00 */ -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/6] [CRYPTO] added Kconfig entry for Camellia.
Hi, This patch adds the Kconfig entry for Camellia. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] --- crypto/Kconfig | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) 01b0c3898fdf1cb4da8cdf5577e58328ecb11e4e diff --git a/crypto/Kconfig b/crypto/Kconfig index cbae839..19858ee 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -424,6 +424,20 @@ config CRYPTO_CRC32C See Castagnoli93. This implementation uses lib/libcrc32c. Module will be crc32c. +config CRYPTO_CAMELLIA + tristate Camellia cipher algorithms + depends on CRYPTO + help + Camellia cipher algorithms module. + +Camellia is a symmetric key block cipher developed jointly +at NTT and Mitsubishi Electric Corporation. + +The Camellia specifies three key sizes: 128, 192 and 256 bits + +See also: +https://info.isl.ntt.co.jp/crypt/eng/camellia/index_s.html + config CRYPTO_TEST tristate Testing module depends on m -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 6/6] [CRYPTO] added the developer of Camellia cipher algorithm.
This patch adds the developer of Camellia cipher algorithm. Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED] --- Documentation/crypto/api-intro.txt |4 1 files changed, 4 insertions(+), 0 deletions(-) 80a5df8127311212e99bd64103771de19c5908dd diff --git a/Documentation/crypto/api-intro.txt b/Documentation/crypto/api-intro.txt index 5a03a28..e41a79a 100644 --- a/Documentation/crypto/api-intro.txt +++ b/Documentation/crypto/api-intro.txt @@ -193,6 +193,7 @@ Original developers of the crypto algori Kartikey Mahendra Bhatt (CAST6) Jon Oberheide (ARC4) Jouni Malinen (Michael MIC) + NTT(Nippon Telegraph and Telephone Corporation) (Camellia) SHA1 algorithm contributors: Jean-Francois Dive @@ -246,6 +247,9 @@ Tiger algorithm contributors: VIA PadLock contributors: Michal Ludvig +Camellia algorithm contributors: + NTT(Nippon Telegraph and Telephone Corporation) (Camellia) + Generic scatterwalk code by Adam J. Richter [EMAIL PROTECTED] Please send any credits updates or corrections to: -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/6] [CRYPTO] added the testing code of Camellia cipher algorithm.
This patch adds the code of Camellia code for testing module.
Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED]
---
crypto/tcrypt.c | 43 ++
crypto/tcrypt.h | 165 +++
2 files changed, 207 insertions(+), 1 deletions(-)
e86050d8fbd04b1ace9c121ce90799c8210925be
diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index b48d011..a9976a0 100644
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -71,7 +71,8 @@ static char *check[] = {
des, md5, des3_ede, rot13, sha1, sha256, blowfish,
twofish, serpent, sha384, sha512, md4, aes, cast6,
arc4, michael_mic, deflate, crc32c, tea, xtea,
- khazad, wp512, wp384, wp256, tnepres, xeta, NULL
+ khazad, wp512, wp384, wp256, tnepres, xeta, camellia,
+ NULL
};
static void hexdump(unsigned char *buf, unsigned int len)
@@ -960,6 +961,20 @@ static void do_test(void)
test_cipher(ecb(xeta), DECRYPT, xeta_dec_tv_template,
XETA_DEC_TEST_VECTORS);
+ //CAMELLIA
+ test_cipher (ecb(camellia), ENCRYPT,
+camellia_enc_tv_template,
+CAMELLIA_ENC_TEST_VECTORS);
+ test_cipher (ecb(camellia), DECRYPT,
+camellia_dec_tv_template,
+CAMELLIA_DEC_TEST_VECTORS);
+ test_cipher (cbc(camellia), ENCRYPT,
+camellia_cbc_enc_tv_template,
+CAMELLIA_CBC_ENC_TEST_VECTORS);
+ test_cipher (cbc(camellia), DECRYPT,
+camellia_cbc_dec_tv_template,
+CAMELLIA_CBC_DEC_TEST_VECTORS);
+
test_hash(sha384, sha384_tv_template, SHA384_TEST_VECTORS);
test_hash(sha512, sha512_tv_template, SHA512_TEST_VECTORS);
test_hash(wp512, wp512_tv_template, WP512_TEST_VECTORS);
@@ -1166,6 +1181,21 @@ static void do_test(void)
XETA_DEC_TEST_VECTORS);
break;
+ case 31:
+ test_cipher (ecb(camellia), ENCRYPT,
+camellia_enc_tv_template,
+CAMELLIA_ENC_TEST_VECTORS);
+ test_cipher (ecb(camellia), DECRYPT,
+camellia_dec_tv_template,
+CAMELLIA_DEC_TEST_VECTORS);
+ test_cipher (cbc(camellia), ENCRYPT,
+camellia_cbc_enc_tv_template,
+CAMELLIA_CBC_ENC_TEST_VECTORS);
+ test_cipher (cbc(camellia), DECRYPT,
+camellia_cbc_dec_tv_template,
+CAMELLIA_CBC_DEC_TEST_VECTORS);
+ break;
+
case 100:
test_hash(hmac(md5), hmac_md5_tv_template,
HMAC_MD5_TEST_VECTORS);
@@ -1245,6 +1275,17 @@ static void do_test(void)
des_speed_template);
break;
+ case 205:
+ test_cipher_speed(ecb(camellia), ENCRYPT, sec, NULL, 0,
+ camellia_speed_template);
+ test_cipher_speed(ecb(camellia), DECRYPT, sec, NULL, 0,
+ camellia_speed_template);
+ test_cipher_speed(cbc(camellia), ENCRYPT, sec, NULL, 0,
+ camellia_speed_template);
+ test_cipher_speed(cbc(camellia), DECRYPT, sec, NULL, 0,
+ camellia_speed_template);
+ break;
+
case 300:
/* fall through */
diff --git a/crypto/tcrypt.h b/crypto/tcrypt.h
index a40c441..3c7d46f 100644
--- a/crypto/tcrypt.h
+++ b/crypto/tcrypt.h
@@ -2744,6 +2744,150 @@ static struct cipher_testvec xeta_dec_tv
};
/*
+ * CAMELLIA test vectors.
+ */
+#define CAMELLIA_ENC_TEST_VECTORS 3
+#define CAMELLIA_DEC_TEST_VECTORS 3
+#define CAMELLIA_CBC_ENC_TEST_VECTORS 2
+#define CAMELLIA_CBC_DEC_TEST_VECTORS 2
+
+static struct cipher_testvec camellia_enc_tv_template[] = {
+ {
+ .key= { 0x01, 0x23, 0x45, 0x67, 0x89, 0xab, 0xcd, 0xef,
+ 0xfe, 0xdc, 0xba, 0x98, 0x76, 0x54, 0x32, 0x10 },
+ .klen = 16,
+ .input = { 0x01, 0x23, 0x45, 0x67, 0x89, 0xab, 0xcd, 0xef,
+ 0xfe, 0xdc, 0xba, 0x98, 0x76, 0x54, 0x32, 0x10 },
+ .ilen = 16,
+ .result = { 0x67, 0x67, 0x31, 0x38, 0x54, 0x96, 0x69, 0x73,
+ 0x08, 0x57, 0x06, 0x56, 0x48, 0xea, 0xbe, 0x43 },
+ .rlen = 16,
+ }, {
+ .key= { 0x01, 0x23, 0x45, 0x67, 0x89, 0xab, 0xcd, 0xef,
+ 0xfe, 0xdc, 0xba, 0x98, 0x76, 0x54, 0x32, 0x10,
+ 0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77 },
+ .klen = 24,
+ .input
[PATCH 5/6] [IPSEC] added the entry of Camellia cipher algorithm to ealg_list[].
This patch adds the entry of Camellia cipher algorithm to ealg_list[].
Signed-off-by: Noriaki TAKAMIYA [EMAIL PROTECTED]
---
net/xfrm/xfrm_algo.c | 17 +
1 files changed, 17 insertions(+), 0 deletions(-)
2253254f5a802c1cc8a5fc367fae911172f28846
diff --git a/net/xfrm/xfrm_algo.c b/net/xfrm/xfrm_algo.c
index 5a0dbeb..583292d 100644
--- a/net/xfrm/xfrm_algo.c
+++ b/net/xfrm/xfrm_algo.c
@@ -249,6 +249,23 @@ static struct xfrm_algo_desc ealg_list[]
}
},
{
+ .name = cbc(camellia),
+.compat = camellia,
+
+ .uinfo = {
+ .encr = {
+ .blockbits = 128,
+ .defkeybits = 128,
+ }
+ },
+ .desc = {
+ .sadb_alg_id = SADB_X_EALG_CAMELLIACBC,
+ .sadb_alg_ivlen = 8,
+ .sadb_alg_minbits = 128,
+ .sadb_alg_maxbits = 256
+ }
+},
+{
.name = cbc(twofish),
.compat = twofish,
--
Noriaki TAKAMIYA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [FYI]: Introduction of the support for RFC4312(The Camellia Cipher Algorithm)
Hi, Dag, Fri, 13 Oct 2006 10:07:03 +0200 [Subject: Re: [FYI]: Introduction of the support for RFC4312(The Camellia Cipher Algorithm)] Dag Arne Osvik [EMAIL PROTECTED] wrote... I'm cc'ing linux-crypto and netdev so you don't get more questions about this. The mails I sent included Japanese characters, so it wasn't available. Thank you for your cc'ing. Regards, -- Noriaki Takamiya - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[FYI]: Introduction of the support for RFC4312(The Camellia Cipher Algorithm)
Hi all, This is Takamiya, from NTT Software. NTT has released the code of the new cipher algorithm, which is specified in RFC4312(The Camellia Cipher Algorithm) Please see http://info.isl.ntt.co.jp/crypt/eng/camellia/source_s.html . The above patch is available for the version of 2.6.18. We started to prepare the patch against the cryptodev-2.6 tree, and will submit it in the few weeks. Best regards. P.S. The patches to use camellia algorithm from ipsec-tools is also available on the above URL, and it will be merged into the ipsec-tools, too. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[FYI]: Introduction of the support for RFC4312(The Camellia Cipher Algorithm)
Hi all, This is Takamiya, from NTT Software. NTT has released the code of the new cipher algorithm, which is specified in RFC4312(The Camellia Cipher Algorithm) Please see http://info.isl.ntt.co.jp/crypt/eng/camellia/source_s.html . The above patch is available for the version of 2.6.18. We started to prepare the patch against the cryptodev-2.6 tree, and will submit it in the few weeks. Best regards. P.S. The patches to use camellia algorithm from ipsec-tools is also available on the above URL, and it will be merged into the ipsec-tools, too. -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC] [IPV6] ADDRCONF: Lifetime handling fixes
Hi, This is Takamiya, from USAGI Project. Thu, 27 Jul 2006 11:28:02 +0100 [Subject: Re: [RFC] [IPV6] ADDRCONF: Lifetime handling fixes] wrote... Hugo Santos [EMAIL PROTECTED] wrote... + ifp = ipv6_get_ifaddr(pfx, dev, 1); + if (ifp == NULL) + return -ENOENT; + + if (!valid_lft || (prefered_lft valid_lft)) + return -EINVAL; ^^^ Unreleased ifp? This test should go before ipv6_get_ifaddr. That's right. Thanks. -- Noriaki Takamiya - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
