> So we wouldn't be spending 5 minutes repacking linux.git right after
> cloning it, just ~10s generating the commit graph, and the same would
> happen if you rm'd .git/objects/info/commit-graph and ran "git commit",
> which would kick of "gc --auto" in the background and do the same thing.
Or
>
> My preference is to avoid them in the name of simplicity. If you're
> using "make SANITIZE=leak test" to check for leaks, it will skip these
> cases. If you're using valgrind, I think these may be reported as
> "reachable". But that number already isn't useful for finding real
> leaks, because
On Tue, Oct 2, 2018 at 3:00 PM Josh Steadmon wrote:
>
> For services other than git-receive-pack, clients currently advertise
> that they support the version set in the protocol.version config,
> regardless of whether or not there is actually an implementation of that
> service for the given
On Tue, Oct 2, 2018 at 12:09 PM Martin Ågren wrote:
>
> On Tue, 2 Oct 2018 at 19:59, Stefan Beller wrote:
> > > > +
> > > > + string_list_clear(, 0);
> > > > }
> > >
> > > Nit: The blank line adds some asymmetr
On Tue, Oct 2, 2018 at 10:55 AM Phillip Wood wrote:
>
> From: Phillip Wood
>
> Free the hashmap items as well as the hashmap itself. This was found
> with asan.
>
> Signed-off-by: Phillip Wood
> ---
> diff.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/diff.c
On Tue, Oct 2, 2018 at 10:55 AM Phillip Wood wrote:
>
> From: Phillip Wood
>
> This is obvious in retrospect, it was found with asan.
Indeed. :/
Thanks,
Stefan
On Tue, Oct 2, 2018 at 10:55 AM Phillip Wood wrote:
>
> From: Phillip Wood
>
> Don't duplicate the indentation string if we're not going to use it.
> This was found with asan.
Makes sense,
Thanks,
Stefan
With compute_ws_delta growing bigger here (and having only one caller),
I wonder if we
On Tue, Oct 2, 2018 at 10:55 AM Phillip Wood wrote:
>
> From: Phillip Wood
>
> When adjusting the start of the string to take account of the change
> in indentation the code was not checking that the string being
> adjusted was in fact longer than the indentation change. This was
> detected by
; if (got_match[i]) {
> /* Carry the white space delta forward */
I would think this comment is obsolete as well with this patch?
With or without that nit addressed, this patch is
Reviewed-by: Stefan Beller
On Tue, Oct 2, 2018 at 8:40 AM Martin Ågren wrote:
>
> On Tue, 2 Oct 2018 at 17:01, Derrick Stolee via GitGitGadget
> wrote:
> > diff --git a/commit-graph.c b/commit-graph.c
> > index 2a24eb8b5a..7226bd6b58 100644
> > --- a/commit-graph.c
> > +++ b/commit-graph.c
> > @@ -698,6 +698,8 @@ void
when encountering a submodule with no
branch.
Step 3: when neither --default-to-master nor --no-default-to-master
has been passed, warn when encountering a submodule with no branch
and treat it as pinned.
Step 4: eliminate the warning.
This implements step 0 and 1.
Signed-off-by: Stefan Beller
---
On Mon, Oct 1, 2018 at 8:45 AM Antonio Ospite wrote:
>
> On Thu, 27 Sep 2018 11:00:52 -0700
> Stefan Beller wrote:
>
> > On Thu, Sep 27, 2018 at 7:44 AM Antonio Ospite wrote:
> [...]
> > > OK, so the plan for v6 is:
> > >
> > > - avoid th
On Sat, Sep 29, 2018 at 7:55 AM Ævar Arnfjörð Bjarmason
wrote:
>
> This --recursive (-r) option does nothing, and is purely here to
> appease people who have "grep -r ..." burned into their muscle memory.
>
> Requested-by: Christoph Berg
> Signed-off-by: Ævar Arnfjörð Bjarmason
> ---
>
> On
On Sat, Sep 29, 2018 at 9:43 AM Raymond Jennings wrote:
>
> I have a repo, but it appears to be specific to staging area state.
> It only segfaults when I have a certain file deleted.
>
> Where do you want me to upload it?
> On Sat, Sep 29, 2018 at 8:34 AM Duy Nguyen wrote:
> >
> > On Sat, Sep
On Fri, Sep 28, 2018 at 2:42 PM Junio C Hamano wrote:
>
> Stefan Beller writes:
>
> > The previous patch suggested the strbuf header to be the leading example
> > of how we would want our APIs to be documented. This may lead to some
> > scrutiny of that code
On Fri, Sep 28, 2018 at 12:26 PM Ævar Arnfjörð Bjarmason
wrote:
>
>
> On Thu, Sep 27 2018, Stefan Beller wrote:
>
> > Internally we have rolled out this as an experiment for
> > "submodules replacing the repo tool[1]". The repo tool is described as:
> >
&g
long lines
Signed-off-by: Stefan Beller
---
Maybe this on top of Junios guideline patch?
Thanks,
Stefan
strbuf.h | 148 ++-
1 file changed, 81 insertions(+), 67 deletions(-)
diff --git a/strbuf.h b/strbuf.h
index 60a35aef16..bf18fddb5b
On Thu, Sep 27, 2018 at 6:11 PM Jeff King wrote:
>
> On Thu, Sep 27, 2018 at 04:27:32PM -0700, Jonathan Nieder wrote:
>
> > > There are different opinions on how to document an API properly.
> > > Discussion turns out nobody disagrees with documenting new APIs on the
> > > function level in the
"checkout -f master" in the submodule as well)
clone: see checkout
reset --hard: see checkout
Change-Id: I69b361e5bd9d57226a0976fd36968cf9aeb52ae0
Signed-off-by: Jonathan Nieder
Signed-off-by: Stefan Beller
---
Documentation/gi
On Thu, Sep 27, 2018 at 12:24 PM Jonathan Tan wrote:
>
> If only hash literals are given on a "git fetch" command-line, tag
> following is not requested, and the fetch is done using protocol v2, a
> list of refs is not required from the remote. Therefore, optimize by
> invoking
On Thu, Sep 27, 2018 at 12:24 PM Jonathan Tan wrote:
>
> +test_expect_success 'when dynamically fetching missing object, do not list
> refs' '
> + cat trace &&
leftover debug cat?
There are different opinions on how to document an API properly.
Discussion turns out nobody disagrees with documenting new APIs on the
function level in the header file and high level concepts in
Documentation/technical, so let's state that in the guidelines.
Signed-off-by: Stefan Beller
3952e12824aa2106d560f21d 3 submodule-child-test
>
> The code in get_superproject_working_tree() expected exactly one entry to
> be returned; this patch makes it use the first entry if multiple entries
> are returned.
>
> Test t1500-rev-parse is extended to cover this case.
>
> Signed-off-by:
rchive".
>
> Signed-off-by: Josh Steadmon
This patch is
Reviewed-by: Stefan Beller
Thanks!
> ---
> builtin/archive.c | 23 ++-
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/builtin/archive.c b/builtin/archive.c
> index e74
On Wed, Sep 26, 2018 at 6:25 PM Josh Steadmon wrote:
>
> Move assertions outside of the check_tar function so that all top-level
> code is wrapped in a test_expect_* assertion.
Cool, I'll file this under modernizing the test infrastructure ;-)
> diff --git a/t/t5000-tar-tree.sh
On Wed, Sep 26, 2018 at 6:25 PM Josh Steadmon wrote:
>
> This is the second version of my series to add a new protocol v2 command
> for archiving, with support for HTTP(S).
>
> NEEDSWORK: a server built with this series is not backwards-compatible
> with clients that set GIT_PROTOCOL=version=2 or
On Thu, Sep 27, 2018 at 7:44 AM Antonio Ospite wrote:
>
> If you end up touching get_oid() please CC me.
noted. I am not sure I'll touch it anytime soon, though.
>
> Are you suggesting to look into super-prefix for any reason in
> particular?
No, I misread the intent of that part of your
On Wed, Sep 26, 2018 at 1:44 PM Ævar Arnfjörð Bjarmason
wrote:
> > And if we were going to generate something external, would it make more
> > sense to write in a structured format like doxygen? I am not a big fan
> > of it myself, but at least from there you can generate a more richly
> >
On Wed, Sep 26, 2018 at 2:28 PM Junio C Hamano wrote:
>
> +struct refname_hash_entry {
> + struct hashmap_entry ent; /* must be the first member */
$ git grep "struct hashmap_entry" reveals that we have another
convention that we follow but not document, which is to stress
the importance
> > (I am not seriously proposing unbalanced comments, but for
> > longer documenting comments we may want to consider,
> > omitting the asterisk?)
>
> If this is not a serious proposal, then I'll stop wasting
> everybody's time.
I proposed two things, one of which I was not serious about.
The
> I agree on both counts. I just like to read these in plain text
> while I am coding for Git (or reviewing patches coded for Git).
>
> The reason why I have mild preference to D/technical/ over in-header
> doc is only because I find even these asterisks at the left-side-end
> distracting; it is
On Wed, Sep 26, 2018 at 11:58 AM Jeff King wrote:
> Now I'll admit it seems like make-work to me because I would not plan to
> ever look at the formatted output myself. But I guess I don't understand
> the audience for this formatted output.
I have been watching from the side lines so far, as I
The `changed_submodule_names` are only used for fetching, so let's make it
part of the struct that is passed around for fetching submodules.
Signed-off-by: Stefan Beller
---
submodule.c | 42 +++---
1 file changed, 23 insertions(+), 19 deletions(-)
diff
order. That makes "append then sort" more
appropriate.
Signed-off-by: Stefan Beller
---
submodule.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/submodule.c b/submodule.c
index 0de9e2800ad..22c64bd8559 100644
--- a/submodule.c
+++ b/submodule.c
@@ -1256
Helped-by: Junio C Hamano
Signed-off-by: Stefan Beller
---
Documentation/technical/api-oid-array.txt | 5 +
sha1-array.c | 17 +
sha1-array.h | 3 +++
3 files changed, 25 insertions(+)
diff --git a/Documentation
The submodule subsystem is really bad at staying within 80 characters.
Fix it while we are here.
Signed-off-by: Stefan Beller
---
submodule.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/submodule.c b/submodule.c
index b53cb6e9c47..0de9e2800ad 100644
access to the util pointer for longer that
contains the commits that we need to fetch, which will be
useful in a later patch.
Signed-off-by: Stefan Beller
---
submodule.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/submodule.c b/submodule.c
index
s series aims to fix.
The first patches provide new basic functionality and do some refactoring;
the interesting part is in the two last patches.
This was discussed in
https://public-inbox.org/git/20180808221752.195419-1-sbel...@google.com/
and I think I addressed all feedback so far.
.
Signed-off-by: Stefan Beller
---
builtin/grep.c | 17 ++---
builtin/ls-files.c | 12 +++-
builtin/submodule--helper.c | 2 +-
repository.c| 27 ++-
repository.h| 11 +--
5 files changed, 37
s so far, not for FETCH_HEAD.
Make sure that fetching a superproject to its FETCH_HEAD, also respects
the existence checks for objects in the submodule recursion.
Signed-off-by: Stefan Beller
---
builtin/fetch.c | 5 -
t/t5526-fetch-submodules.sh | 2 +-
2 files changed, 5 insertio
ady.
Signed-off-by: Stefan Beller
---
submodule.c | 51 +++--
t/t5526-fetch-submodules.sh | 7 -
2 files changed, 44 insertions(+), 14 deletions(-)
diff --git a/submodule.c b/submodule.c
index dd478ed70bf..3f791f22771 100644
--- a/s
e_commits(), so we'll also run that code
in case the submodule recursion is set to "on".
Signed-off-by: Stefan Beller
---
builtin/fetch.c | 9 +-
submodule.c | 185 ++--
t/t5526-fetch-submodules.sh | 16
3 files changed,
On Sat, Sep 22, 2018 at 5:58 AM Ævar Arnfjörð Bjarmason
wrote:
>
>
> On Fri, Sep 21 2018, Stefan Beller wrote:
>
> > +/*
> > + * Apply want to each entry in array, retaining only the entries for
> > + * which the function returns true. Preserve the order of the ent
On Tue, Sep 25, 2018 at 7:30 AM Derrick Stolee wrote:
>
> On 9/25/2018 3:06 AM, Patrick Steinhardt wrote:
> > On Mon, Sep 24, 2018 at 11:32:23PM +0200, SZEDER Gábor wrote:
> >> On Mon, Sep 24, 2018 at 02:15:30PM -0700, Derrick Stolee via GitGitGadget
> >> wrote:
> >>> From: Derrick Stolee
> >>>
On Tue, Sep 25, 2018 at 9:55 AM Duy Nguyen wrote:
> > And with that said, I wonder if the "local" part should be feature agnostic,
> > or if we want to be "local" for worktrees, "local" for remotes, "local"
> > for submodules (i.e. our own refs vs submodule refs).
>
> You lost me here.
Yeah, me
On Tue, Sep 25, 2018 at 8:49 AM Duy Nguyen wrote:
>
> On Tue, Sep 25, 2018 at 4:48 AM Stefan Beller wrote:
> > > This patch also makes it possible to specify refs from one worktree in
> > > another one, e.g.
> > >
> > > git log worktrees/foo
On Tue, Sep 25, 2018 at 8:36 AM Duy Nguyen wrote:
>
> On Tue, Sep 25, 2018 at 4:35 AM Stefan Beller wrote:
> >
> > On Sat, Sep 22, 2018 at 11:05 AM Nguyễn Thái Ngọc Duy
> > wrote:
> > >
> > > When multiple worktrees are used, we need rules to d
On Sat, Sep 22, 2018 at 11:05 AM Nguyễn Thái Ngọc Duy wrote:
>
> One of the problems with multiple worktree is accessing per-worktree
> refs of one worktree from another worktree. This was sort of solved by
> multiple ref store, where the code can open the ref store of another
> worktree and has
On Sat, Sep 22, 2018 at 11:05 AM Nguyễn Thái Ngọc Duy wrote:
>
> When multiple worktrees are used, we need rules to determine if
> something belongs to one worktree or all of them. Instead of keeping
> adding rules when new stuff comes, have a generic rule:
>
> - Inside $GIT_DIR, which is
On Mon, Sep 24, 2018 at 2:25 PM Sam McKelvie wrote:
Thanks for writing a patch!
I wonder if we can shorten the subject and make it a bit more concise,
how about
submodule: Alllow staged changes for get_superproject_working_tree
or
rev-parse: allow staged submodule in
On Mon, Sep 24, 2018 at 3:06 AM Phillip Wood wrote:
>
> From: Phillip Wood
>
> This adds another mode for highlighting lines that have moved with an
> indentation change. Unlike the existing
> --color-moved-ws=allow-indentation-change setting this mode uses the
> visible change in the
On Mon, Sep 24, 2018 at 3:06 AM Phillip Wood wrote:
>
> From: Phillip Wood
>
> This will be used by the move detection code.
>
> Signed-off-by: Phillip Wood
> ---
> xdiff-interface.c | 5 +
> xdiff-interface.h | 5 +
> 2 files changed, 10 insertions(+)
>
> diff --git
> > +int print_config_from_gitmodules(const char *key)
>
> I am thinking about adding a "struct repository" argument to this
> function
Sounds like a good idea.
On Mon, Sep 24, 2018 at 3:20 AM Antonio Ospite wrote:
> > The third call, however, looks at the nested submodule at
> > 'submodule/sub', which doesn't contain a '.gitmodules' file. So this
> > function goes on with the second condition and calls
> > get_oid(GITMODULES_INDEX, ), which then
On Mon, Sep 24, 2018 at 10:59 AM Sam McKelvie wrote:
>
> I experienced this problem using git 2.17.1; however, from inspection of the
> next branch, function get_superproject_working_tree() in submodule.c has not
> changed in 2 years.
>
> I believe the problem is related to the fact that when a
On Mon, Sep 24, 2018 at 6:31 AM Derrick Stolee wrote:
>
> On 9/21/2018 7:58 PM, Stefan Beller wrote:
> > The old formatting style is a real hindrance of getting people up to speed
> > contributing as they use existing code as an example and follow that style.
> > So let's
Signed-off-by: Stefan Beller
---
t/t0030-stripspace.sh | 525 --
1 file changed, 254 insertions(+), 271 deletions(-)
diff --git a/t/t0030-stripspace.sh b/t/t0030-stripspace.sh
index 5ce47e8af51..c2281a39b58 100755
--- a/t/t0030-stripspace.sh
+++ b/t/t0030
Signed-off-by: Stefan Beller
---
t/t7004-tag.sh | 149 +++--
1 file changed, 56 insertions(+), 93 deletions(-)
diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index 0b01862c23a..03a96b7f79e 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -144,26
lines += ["\n"]
if state == "lookingforstart":
outlines += ["'\n"]
else:
print "what?"
exit(1)
with open(fnam
-by: Stefan Beller
---
t/t7001-mv.sh | 268 +-
1 file changed, 134 insertions(+), 134 deletions(-)
diff --git a/t/t7001-mv.sh b/t/t7001-mv.sh
index 36b50d0b4c1..2251d24735c 100755
--- a/t/t7001-mv.sh
+++ b/t/t7001-mv.sh
@@ -3,74 +3,74 @@
test_description
access to the util pointer for longer that
contains the commits that we need to fetch, which will be
useful in a later patch.
Signed-off-by: Stefan Beller
---
submodule.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/submodule.c b/submodule.c
index
ady.
Signed-off-by: Stefan Beller
---
submodule.c | 47 +++--
t/t5526-fetch-submodules.sh | 7 +-
2 files changed, 40 insertions(+), 14 deletions(-)
diff --git a/submodule.c b/submodule.c
index 209680ec076..8829e8d4eff 100644
--- a/s
e_commits(), so we'll also run that code
in case the submodule recursion is set to "on".
Signed-off-by: Stefan Beller
---
builtin/fetch.c | 9 +-
submodule.c | 182 ++--
t/t5526-fetch-submodules.sh | 16
3 files changed,
s so far, not for FETCH_HEAD.
Make sure that fetching a superproject to its FETCH_HEAD, also respects
the existence checks for objects in the submodule recursion.
Signed-off-by: Stefan Beller
---
builtin/fetch.c | 5 -
t/t5526-fetch-submodules.sh | 2 +-
2 files changed, 5 insertio
The `changed_submodule_names` are only used for fetching, so let's make it
part of the struct that is passed around for fetching submodules.
Signed-off-by: Stefan Beller
---
submodule.c | 42 +++---
1 file changed, 23 insertions(+), 19 deletions(-)
diff
order. That makes "append then sort" more
appropriate.
Signed-off-by: Stefan Beller
---
submodule.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/submodule.c b/submodule.c
index 67469a8f513..2f5c19d0aac 100644
--- a/submodule.c
+++ b/submodule.c
@@ -1257
Helped-by: Junio C Hamano
Signed-off-by: Stefan Beller
---
sha1-array.c | 17 +
sha1-array.h | 9 +
2 files changed, 26 insertions(+)
diff --git a/sha1-array.c b/sha1-array.c
index b94e0ec0f5e..d922e94e3fc 100644
--- a/sha1-array.c
+++ b/sha1-array.c
@@ -77,3 +77,20
The submodule subsystem is really bad at staying within 80 characters.
Fix it while we are here.
Signed-off-by: Stefan Beller
---
submodule.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/submodule.c b/submodule.c
index ed05339b588..67469a8f513 100644
addressed all feedback so far.
Stefan Beller (8):
sha1-array: provide oid_array_filter
submodule.c: fix indentation
submodule.c: sort changed_submodule_names before searching it
submodule: move global changed_submodule_names into fetch submodule
struct
submodule.c: do not copy aro
On Fri, Sep 21, 2018 at 3:18 PM Jeff King wrote:
> I agree that core.* is kind of a kitchen sink, but I'm not sure that's
> all that bad. Is "here is how Git finds refs in an alternate" any more
This touches both "refs" and "alternates", which are Git concepts
whereas ssh is not.
> or less
(item);
string_list_pop(, free_util);
}
Helped-by: Junio C Hamano
Signed-off-by: Stefan Beller
---
I will be resending this series shortly, but it will not contain this patch,
as I will have no need for these any longer.
For the record, this is the final state of this patch.
It may
On Fri, Sep 21, 2018 at 12:00 PM Marc Branchaud wrote:
>
> Also document this fact.
>
> Signed-off-by: Marc Branchaud
> ---
>
> I ran into this bug when I had both fetch.recurseSubmodules=on-demand and
> submodule.recurse=true, and submodule.recurse was set *after*
> fetch.recurseSubmodules in
On Thu, Sep 20, 2018 at 11:04 AM Taylor Blau wrote:
>
> Hi,
>
> This is a series to customize Git's behavior when listing references
> from an alternate repository. It is motivated by the following example:
>
> Consider an upstream repository, a fork of it, and a local copy of that
> fork.
On Wed, Sep 19, 2018 at 9:15 AM Elijah Newren wrote:
>
> Summary:
> merge_file_1() -> merge_mode_and_contents()
> merge_content() -> handle_content_merge()
>
> merge_file_1() is a very unhelpful name. Rename it to
> merge_mode_and_contents() to reflect what it does.
>
> merge_content()
On Mon, Sep 17, 2018 at 2:36 PM Stefan Beller wrote:
>
> Helped-by: Junio C Hamano
> Signed-off-by: Stefan Beller
> ---
> sha1-array.c | 17 +
> sha1-array.h | 9 +
> 2 files changed, 26 insertions(+)
>
> diff --git a/sha1-array.c b/sha1-
The `changed_submodule_names` are only used for fetching, so let's make it
part of the struct that is passed around for fetching submodules.
Signed-off-by: Stefan Beller
---
submodule.c | 42 +++---
1 file changed, 23 insertions(+), 19 deletions(-)
diff
access to the util pointer for longer that
contains the commits that we need to fetch, which will be
useful in a later patch.
Signed-off-by: Stefan Beller
---
submodule.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/submodule.c b/submodule.c
index
e_commits(), so we'll also run that code
in case the submodule recursion is set to "on".
Signed-off-by: Stefan Beller
---
builtin/fetch.c | 9 ++--
submodule.c | 87 -
t/t5526-fetch-submodules.sh | 16 +++
3 files changed,
submodules that are currently
not checked out.
Signed-off-by: Stefan Beller
---
submodule.c | 45 +++--
t/t5526-fetch-submodules.sh | 7 +-
2 files changed, 39 insertions(+), 13 deletions(-)
diff --git a/submodule.c b/submodule.c
index 0
s so far, not for FETCH_HEAD.
Make sure that fetching a superproject to its FETCH_HEAD, also respects
the existence checks for objects in the submodule recursion.
Signed-off-by: Stefan Beller
---
builtin/fetch.c | 5 -
t/t5526-fetch-submodules.sh | 2 +-
2 files changed, 5 insertio
Helped-by: Junio C Hamano
Signed-off-by: Stefan Beller
---
sha1-array.c | 17 +
sha1-array.h | 9 +
2 files changed, 26 insertions(+)
diff --git a/sha1-array.c b/sha1-array.c
index 265941fbf40..67db5eeec9a 100644
--- a/sha1-array.c
+++ b/sha1-array.c
@@ -77,3 +77,20
s series aims to fix.
The first patches provide new basic functionality and do some refactoring;
the interesting part is in the two last patches.
This was discussed in
https://public-inbox.org/git/20180808221752.195419-1-sbel...@google.com/
and I think I addressed all feedback so far.
Stefan
The submodule subsystem is really bad at staying within 80 characters.
Fix it while we are here.
Signed-off-by: Stefan Beller
---
submodule.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/submodule.c b/submodule.c
index a2b266fbfae..d29dfa3d1f5 100644
order. That makes "append then sort" more
appropriate.
Signed-off-by: Stefan Beller
---
submodule.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/submodule.c b/submodule.c
index d29dfa3d1f5..c6eff7699f3 100644
--- a/submodule.c
+++ b/submodule.c
@@ -1256
(item);
string_list_pop(, free_util);
}
Helped-by: Junio C Hamano
Signed-off-by: Stefan Beller
---
string-list.c | 14 ++
string-list.h | 15 +++
2 files changed, 29 insertions(+)
diff --git a/string-list.c b/string-list.c
index 771c4550980..04db2b537c0 100644
On Mon, Sep 17, 2018 at 10:51 AM Ævar Arnfjörð Bjarmason
wrote:
>
> Aside from that particular address bouncing [...] it would be nice if git
> {format-patch,send-email,check-contacts} & the .mailmap format would
> support and understand some way to map addresses to
> e.g. nore...@example.com,
On Wed, Sep 12, 2018 at 11:36 AM Junio C Hamano wrote:
>
> Stefan Beller writes:
>
> > This patch started as a refactoring to make 'get_next_submodule' more
> > readable, but upon doing so, I realized that git-fetch actually doesn't
> > need to be run in the worktree.
On Tue, Sep 11, 2018 at 10:36 PM Josh Steadmon wrote:
>
> Signed-off-by: Josh Steadmon
> ---
> builtin/archive.c | 8 +++-
> http-backend.c | 10 +-
> transport-helper.c | 5 +++--
> 3 files changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/builtin/archive.c
On Tue, Sep 11, 2018 at 10:36 PM Josh Steadmon wrote:
>
> This adds a new archive command for protocol v2. The command expects
> arguments in the form "argument X" which are passed unmodified to
> git-upload-archive--writer.
>
> This command works over the file://, Git, and SSH transports. HTTP
>
On Tue, Sep 11, 2018 at 10:35 PM Josh Steadmon wrote:
>
> Using packet_reader will simplify version detection and capability
> handling, which will make implementation of protocol v2 support in
> git-archive easier.
>
> Signed-off-by: Josh Steadmon
Reviewed-by: Stefan Beller
On Wed, Sep 12, 2018 at 11:18 AM Junio C Hamano wrote:
>
> Stefan Beller writes:
>
> > We can string_list_insert() to maintain sorted-ness of the
> > list as we find new items, or we can string_list_append() to
> > build an unsorted list and sort it at the end just
access to the util pointer for longer that
contains the commits that we need to fetch, which will be
useful in a later patch.
Signed-off-by: Stefan Beller
---
submodule.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/submodule.c b/submodule.c
index
t be found.
This doesn't support fetching to FETCH_HEAD yet, but only into a local
branch. To make fetching into FETCH_HEAD work, we need some refactoring
in builtin/fetch.c to adjust the calls to 'check_for_new_submodule_commits'
that is coming in the next patch.
Signed-off-by: Stefan Beller
--
order. That makes "append then sort" more
appropriate.
Signed-off-by: Stefan Beller
---
submodule.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/submodule.c b/submodule.c
index d29dfa3d1f5..c6eff7699f3 100644
--- a/submodule.c
+++ b/submodule.c
@@ -1256
out.
Signed-off-by: Stefan Beller
---
submodule.c | 43 ++---
t/t5526-fetch-submodules.sh | 7 +-
2 files changed, 37 insertions(+), 13 deletions(-)
diff --git a/submodule.c b/submodule.c
index 00a9a3c6b12..1e6781504f0 100644
doesn't return such a pointer.
You can use them in this pattern:
while (list.nr) {
struct string_list_item *item = string_list_last();
work_on(item);
string_list_pop();
}
Helped-by: Junio C Hamano
Signed-off-by: Stefan Beller
---
string-list.c | 14
I think I addressed all feedback so far.
Thanks,
Stefan
Stefan Beller (9):
string-list: add string_list_{pop, last} functions
sha1-array: provide oid_array_filter
submodule.c: fix indentation
submodule.c: sort changed_submodule_names before searching it
submodule: move global changed_submo
For Gerrit users that use submodules the invocation of fetch without a
branch is their main use case.
Signed-off-by: Stefan Beller
---
builtin/fetch.c | 5 -
t/t5526-fetch-submodules.sh | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/builtin/fetch.c b
The `changed_submodule_names` are only used for fetching, so let's make it
part of the struct that is passed around for fetching submodules.
Signed-off-by: Stefan Beller
---
submodule.c | 42 +++---
1 file changed, 23 insertions(+), 19 deletions(-)
diff
Helped-by: Junio C Hamano
Signed-off-by: Stefan Beller
---
sha1-array.c | 18 ++
sha1-array.h | 5 +
2 files changed, 23 insertions(+)
diff --git a/sha1-array.c b/sha1-array.c
index 265941fbf40..76323935dd7 100644
--- a/sha1-array.c
+++ b/sha1-array.c
@@ -77,3 +77,21
301 - 400 of 7892 matches
Mail list logo
