Re: [PATCH] i2c: mlxbf: I2C_MLXBF should depend on MELLANOX_PLATFORM

2020-10-10 Thread Wolfram Sang
On Mon, Oct 05, 2020 at 02:49:49PM +0200, Geert Uytterhoeven wrote: > The Mellanox BlueField I2C controller is only present on Mellanox > BlueField SoCs. Hence add a dependency on MELLANOX_PLATFORM, to prevent > asking the user about this driver when configuring a kernel without > Mellanox

Re: [PATCH v6 1/3] i2c: imx: Fix reset of I2SR_IAL flag

2020-10-10 Thread Wolfram Sang
On Fri, Oct 09, 2020 at 01:03:18PM +0200, Christian Eggers wrote: > According to the "VFxxx Controller Reference Manual" (and the comment > block starting at line 97), Vybrid requires writing a one for clearing > an interrupt flag. Syncing the method for clearing I2SR_IIF in > i2c_imx_isr(). > >

Re: [PATCH 1/3] i2c: owl: Clear NACK and BUS error bits

2020-10-10 Thread Wolfram Sang
On Fri, Oct 09, 2020 at 12:44:39AM +0300, Cristian Ciocaltea wrote: > When the NACK and BUS error bits are set by the hardware, the driver is > responsible for clearing them by writing "1" into the corresponding > status registers. > > Hence perform the necessary operations in

Re: [PATCH v6 3/3] i2c: imx: Don't generate STOP condition if arbitration has been lost

2020-10-10 Thread Wolfram Sang
On Fri, Oct 09, 2020 at 01:03:20PM +0200, Christian Eggers wrote: > If arbitration is lost, the master automatically changes to slave mode. > I2SR_IBB may or may not be reset by hardware. Raising a STOP condition > by resetting I2CR_MSTA has no effect and will not clear I2SR_IBB. > > So calling

[PULL REQUEST] i2c for v5.9

2020-10-10 Thread Wolfram Sang
): i2c: meson: fixup rate calculation with filter delay Wolfram Sang (1): Revert "i2c: imx: Fix reset of I2SR_IAL flag" drivers/i2c/busses/i2c-meson.c | 52 +++--- drivers/i2c/busses/i2c-owl.c | 6 + 2 files changed, 39 inserti

Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6

2020-10-08 Thread Wolfram Sang
atch/11133827 > > Reviewed-by: Akash Asthana Thanks! Acked-by: Wolfram Sang So, this patch can go in via whatever tree seems apropriate. Let me know if I should take this patch individually. signature.asc Description: PGP signature

Re: [PATCH v3] i2c: virtio: add a virtio i2c frontend driver

2020-10-08 Thread Wolfram Sang
Hi, some super high level questions: > different controllers according to their needs. A backend > example can be found in the device model of the open source > project ACRN. For more information, please refer to > https://projectacrn.org. Could you provide a link directly to the backend,

Re: [PATCH V5 1/3] soc: qcom: geni: Remove "iova" check

2020-10-08 Thread Wolfram Sang
On Thu, Oct 01, 2020 at 02:14:23PM +0530, Roja Rani Yarubandi wrote: > Remove "iova" check from geni_se_tx_dma_unprep and geni_se_rx_dma_unprep > fucntions as invalidating with dma_mapping_error() is enough. > > Signed-off-by: Roja Rani Yarubandi Applied to for-next, thanks! The other patches

Re: [PATCH v3] i2c: mv64xxx: Add bus error recovery

2020-10-08 Thread Wolfram Sang
oN tHU, aug 27, 2020 at 10:35:16AM +1200, Mark Tomlinson wrote: > This adds i2c bus recovery to the mv64xxx driver. > > Implement bus recovery to recover from SCL/SDA stuck low. > > This uses the generic recovery function, setting the clock/data lines as > GPIO pins, and sending 9 clocks to try

Re: Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6

2020-10-08 Thread Wolfram Sang
On Thu, Oct 08, 2020 at 10:46:05AM +, Caleb Connolly wrote: > On 2020-10-08 11:03, Wolfram Sang wrote: > > On Wed, Oct 07, 2020 at 05:49:35PM +, Caleb Connolly wrote: > >> The OnePlus 6/T has the same issues as the c630 causing a crash when DMA > >>

Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6

2020-10-08 Thread Wolfram Sang
On Wed, Oct 07, 2020 at 05:49:35PM +, Caleb Connolly wrote: > The OnePlus 6/T has the same issues as the c630 causing a crash when DMA > is used for i2c, so disable it. > > https://patchwork.kernel.org/patch/11133827/ > Signed-off-by: Caleb Connolly May I ask for a quick review here, so we

Re: [PATCH 2/3] i2c: meson: keep peripheral clock enabled

2020-10-08 Thread Wolfram Sang
On Wed, Oct 07, 2020 at 10:07:50AM +0200, Jerome Brunet wrote: > SCL rate appears to be different than what is expected. For example, > We get 164kHz on i2c3 of the vim3 when 400kHz is expected. This is > partially due to the peripheral clock being disabled when the clock is > set. > > Let's keep

Re: [PATCH 3/3] i2c: meson: fixup rate calculation with filter delay

2020-10-08 Thread Wolfram Sang
On Wed, Oct 07, 2020 at 10:07:51AM +0200, Jerome Brunet wrote: > From: Nicolas Belin > > Apparently, 15 cycles of the peripheral clock are used by the controller > for sampling and filtering. Because this was not known before, the rate > calculation is slightly off. > > Clean up and fix the

Re: [PATCH 1/3] i2c: meson: fix clock setting overwrite

2020-10-08 Thread Wolfram Sang
On Wed, Oct 07, 2020 at 10:07:49AM +0200, Jerome Brunet wrote: > When the slave address is written in do_start(), SLAVE_ADDR is written > completely. This may overwrite some setting related to the clock rate > or signal filtering. > > Fix this by writing only the bits related to slave address. To

Re: [PATCH v5 1/3] i2c: imx: Fix reset of I2SR_IAL flag

2020-10-08 Thread Wolfram Sang
On Wed, Oct 07, 2020 at 10:45:22AM +0200, Christian Eggers wrote: > According to the "VFxxx Controller Reference Manual" (and the comment > block starting at line 97), Vybrid requires writing a one for clearing > an interrupt flag. Syncing the method for clearing I2SR_IIF in > i2c_imx_isr(). > >

Re: [PATCH v9 00/32] Improvements for Tegra I2C driver

2020-10-05 Thread Wolfram Sang
Hi Dmitry, > Hello, Wolfram! Thank you! This series started with 10 small patches and > then was growing with every new review round because more ideas were > suggested and I needed to rebase/redo majority of the patches, hence it > was a bit difficult to split it up into a smaller parts that

Re: [PATCH v9 00/32] Improvements for Tegra I2C driver

2020-10-05 Thread Wolfram Sang
On Wed, Sep 30, 2020 at 01:18:43AM +0300, Dmitry Osipenko wrote: > Hello! > > This series performs refactoring of the Tegra I2C driver code and hardens > the atomic-transfer mode. Applied to for-next, thanks to everyone! Please send incremental patches from now on. Also, there is this unreviewed

Re: [PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties'

2020-10-05 Thread Wolfram Sang
constant source of review issues. > > Signed-off-by: Rob Herring I trust you, so for I2C: Acked-by: Wolfram Sang signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties'

2020-10-05 Thread Wolfram Sang
constant source of review issues. > > Signed-off-by: Rob Herring I trust you, so for I2C: Acked-by: Wolfram Sang signature.asc Description: PGP signature

Re: [sane-devel] Is any developer interested in getting a canon dr-2020u scanner?

2020-10-03 Thread Wolfram Sang
> So I probably should wait a little bit longer but if he is not interested > anymore I am going to send it to you. Sure, let's hope he will send the address. signature.asc Description: PGP signature

Re: [sane-devel] Is any developer interested in getting a canon dr-2020u scanner?

2020-10-02 Thread Wolfram Sang
Hi, > I am from Germany/Munich so I am preferably looking for some one from > Germany (would send it for free) or maybe otherwise from Europe (depends on > shipping costs/probably also for free). > > Is anyone interested? Well, since nobody else replied so far, I would have a try. I can check

[PULL REQUEST] i2c for 5.9

2020-10-02 Thread Wolfram Sang
Linus, some more driver fixes from I2C. Please pull. Thanks, Wolfram The following changes since commit ba4f184e126b751d1bffad5897f263108befc780: Linux 5.9-rc6 (2020-09-20 16:33:55 -0700) are available in the Git repository at:

Re: [PATCH 4/6] docs: i2c: index.rst: add slave-testunit-backend.rst

2020-10-02 Thread Wolfram Sang
Hi Mauro, > index 8a2ad3845191..9b8df313902c 100644 > --- a/Documentation/i2c/index.rst > +++ b/Documentation/i2c/index.rst > @@ -38,6 +38,7 @@ Debugging > > gpio-fault-injection > i2c-stub > + slave-testunit-backend Yeah, it is missing, but this is the wrong paragraph to add it. For

Re: [sane-devel] Rebase

2020-09-30 Thread Wolfram Sang
> AFAICS I am the only one to work on this branch, so I suspect that rebasing > will be OK. Yes. > Just really looking for perspectives for the SANE project. > I suspect different projects have views on this subject. IMHO only if they don't care about annoyed developers ;) signature.asc

Re: [sane-devel] Rebase

2020-09-30 Thread Wolfram Sang
Hi Ralph, > I have an issue branch that now has conflicts with master. > I have not had a lot of experience with rebasing, but I read somewhere that > rebasing is not recommended if you have pushed changes to origin because of > the dangers of someone else working on the branch. I am still new

Re: [PATCH v8 12/32] i2c: tegra: Use clk-bulk helpers

2020-09-29 Thread Wolfram Sang
> > Any comments here? I'll apply this series later this week if there are > > no objections coming up. > > > > Please hold on, I just spotted a serious problem in patch 23 and v9 > needs to be done. Ok, thanks for the heads up. An ack for this patch would still be nice :) signature.asc

Re: [PATCH v2 1/1] i2c: busses: Add support for atomic transfers in Actions Semi Owl driver

2020-09-29 Thread Wolfram Sang
> Sure, I can handle this. I assume this should be a separate patch, to > be applied before the current patch. Should I submit a patch series > instead? Yes, just do it. And please remove irrelevant parts of the mail when replying. Thanks! signature.asc Description: PGP signature

Re: [PATCH -next] i2c: efm32: Use devm_platform_get_and_ioremap_resource()

2020-09-29 Thread Wolfram Sang
On Fri, Sep 18, 2020 at 04:25:08PM +0800, Wang ShaoBo wrote: > Make use of devm_platform_get_and_ioremap_resource() provided by > driver core platform instead of duplicated analogue. dev_err() is > removed because it has been done in devm_ioremap_resource(). > > Signed-off-by: Wang ShaoBo

Re: [PATCH v8 12/32] i2c: tegra: Use clk-bulk helpers

2020-09-29 Thread Wolfram Sang
On Wed, Sep 23, 2020 at 01:51:35AM +0300, Dmitry Osipenko wrote: > Use clk-bulk helpers and factor out clocks initialization into separate > function in order to make code cleaner. > > The clocks initialization now performed after reset-control initialization > in order to avoid a noisy

Bug#950329: can be closed

2020-09-29 Thread Wolfram Sang
Upstream provided version 0.9 with Python3 + Qt5 support. Already available in Debian testing. Can be closed. signature.asc Description: PGP signature

Bug#971389: seascope: Dependency to 'python3-pyqt5.qtsvg' missing, does not start

2020-09-29 Thread Wolfram Sang
Package: seascope Version: 0.9+8a669e0e-2 Severity: grave Justification: renders package unusable Dear Maintainer, after upgrading to bullseye, starting seascope failed for me: No module named 'PyQt5.QtSvg' Error: failed to import supporting packages. Error: program aborted. After installing

Bug#971389: seascope: Dependency to 'python3-pyqt5.qtsvg' missing, does not start

2020-09-29 Thread Wolfram Sang
Package: seascope Version: 0.9+8a669e0e-2 Severity: grave Justification: renders package unusable Dear Maintainer, after upgrading to bullseye, starting seascope failed for me: No module named 'PyQt5.QtSvg' Error: failed to import supporting packages. Error: program aborted. After installing

Re: [sane-devel] Q: improving epson2 for Epson 12000XL

2020-09-28 Thread Wolfram Sang
Hi Olaf, > Actually, I've found a reference in my dead tree specs that all other > values with the one byte limit are supported. 0x00 through 0x39 are > below the glass plate, 0x41 through 0xfe are above. Units unknown but > based on your observation of 0x59 being 25 steps away from 0x40 and it

Re: [PATCH v8 0/6] Support running driver's probe for a device powered off

2020-09-27 Thread Wolfram Sang
> I think we might be overly complicating things. IMHO the series as is > with the "i2c_" prefix removed from the flags introduced would be > reusable as is for any other subsystem that needs it. Of course, for > now, the handling of the flag would remain implemented only in the I2C > subsystem.

Re: [PATCH v1] i2c: npcm7xx: Clear LAST bit after a failed transaction.

2020-09-27 Thread Wolfram Sang
On Sun, Sep 20, 2020 at 11:48:09PM +0300, Tali Perry wrote: > Due to a HW issue, in some scenarios the LAST bit might remain set. > This will cause an unexpected NACK after reading 16 bytes on the next > read. > > Example: if user tries to read from a missing device, get a NACK, > then if the

Re: [PATCH v4 4/4] dt-bindings: i2c: imx: Fix i.MX 7 compatible matching

2020-09-27 Thread Wolfram Sang
On Thu, Sep 17, 2020 at 09:13:21PM +0200, Krzysztof Kozlowski wrote: > The i.MX 7 DTSes use two compatibles so update the binding to fix > dtbs_check warnings like: > > arch/arm/boot/dts/imx7d-cl-som-imx7.dt.yaml: i2c@30a2: > compatible: ['fsl,imx7d-i2c', 'fsl,imx21-i2c'] is not valid

Re: [PATCH v4 3/4] dt-bindings: i2c: imx: Add properties and use unevaluatedProperties

2020-09-27 Thread Wolfram Sang
On Thu, Sep 17, 2020 at 09:13:20PM +0200, Krzysztof Kozlowski wrote: > Additional properties actually might appear (e.g. power-domains) so > describe all typical properties, reference generic i2c schema and use > unevaluatedProperties to fix dtbs_check warnings like: > >

Re: [PATCH v4 2/4] dt-bindings: i2c: imx-lpi2c: Fix i.MX 8QXP compatible matching

2020-09-27 Thread Wolfram Sang
On Thu, Sep 17, 2020 at 09:13:19PM +0200, Krzysztof Kozlowski wrote: > The i.MX 8QXP DTSes use two compatibles so update the binding to fix > dtbs_check warnings like: > > arch/arm64/boot/dts/freescale/imx8qxp-mek.dt.yaml: i2c@5a82: > compatible: ['fsl,imx8qxp-lpi2c',

Re: [PATCH v3] i2c: imx: Fix external abort on interrupt in exit paths

2020-09-27 Thread Wolfram Sang
On Sun, Sep 20, 2020 at 11:12:38PM +0200, Krzysztof Kozlowski wrote: > If interrupt comes late, during probe error path or device remove (could > be triggered with CONFIG_DEBUG_SHIRQ), the interrupt handler > i2c_imx_isr() will access registers with the clock being disabled. This > leads to

Re: [PATCH v4 1/4] dt-bindings: i2c: imx-lpi2c: Add properties and use unevaluatedProperties

2020-09-27 Thread Wolfram Sang
On Thu, Sep 17, 2020 at 09:13:18PM +0200, Krzysztof Kozlowski wrote: > Additional properties actually might appear (e.g. power-domains) so > describe all typical properties, reference generic i2c schema and use > unevaluatedProperties to fix dtbs_check warnings like: > >

Re: [PATCH 7/9] i2c: rk3x: Simplify with dev_err_probe()

2020-09-27 Thread Wolfram Sang
On Wed, Sep 02, 2020 at 05:06:41PM +0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Applied to for-next, thanks! signature.asc

Re: [PATCH v2] i2c: cpm: Fix i2c_ram structure

2020-09-27 Thread Wolfram Sang
On Wed, Sep 23, 2020 at 04:08:40PM +0200, nico.vi...@gmail.com wrote: > From: Nicolas VINCENT > > the i2c_ram structure is missing the sdmatmp field mentionned in > datasheet for MPC8272 at paragraph 36.5. With this field missing, the > hardware would write past the allocated memory done through

Re: [sane-devel] sane 1.0.31 backend version not supported lineart. Why?...

2020-09-24 Thread Wolfram Sang
> Sorry everyone! > I am ashamed of my inattention! No worries! :) signature.asc Description: PGP signature

Re: [sane-devel] sane 1.0.31 backend version not supported lineart. Why?...

2020-09-24 Thread Wolfram Sang
> I am a "simple" user who > has used the lineart setting on the scanner for many, many > years. Now I was faced with the fact that it was discontinued > by default and is missing in my work ... > You are a scanner and IT pros and it was great to revive

Re: [sane-devel] sane 1.0.31 backend version not supported lineart. Why?...

2020-09-24 Thread Wolfram Sang
On Thu, Sep 24, 2020 at 11:59:39AM +0200, Ulf Zibis wrote: > > Am 24.09.20 um 11:45 schrieb Wolfram Sang: > > > > !458 explains some more: "The LINEART support within the backend is > > implemented as a pure software filter. I think this should live in a > >

Re: [sane-devel] sane 1.0.31 backend version not supported lineart. Why?...

2020-09-24 Thread Wolfram Sang
> > Why is the lineart option not supported in the sane 1.0.31 backend version? > > Probably because of commit a12083c8c44b7296fa98ecb83e8932d0f6bdeb05. > > > https://gitlab.com/sane-project/backends/-/commit/a12083c8c44b7296fa98ecb83e8932d0f6bdeb05 > > @povilas> The commit message doesn't

Re: [PATCH v2] i2c: cpm: Fix i2c_ram structure

2020-09-23 Thread Wolfram Sang
On Wed, Sep 23, 2020 at 04:08:40PM +0200, nico.vi...@gmail.com wrote: > From: Nicolas VINCENT > > the i2c_ram structure is missing the sdmatmp field mentionned in > datasheet for MPC8272 at paragraph 36.5. With this field missing, the > hardware would write past the allocated memory done through

Re: [PATCH v8 00/32] Improvements for Tegra I2C driver

2020-09-23 Thread Wolfram Sang
> Ahh, I missed to add Andy's r-b to all patches. > > Hope it's okay if I'll add it here like this: > > Reviewed-by: Andy Shevchenko Yes, it is. So, I ideally we get an ack on patch 12 and are good to go, I'd think? Thanks again, everyone! signature.asc Description: PGP signature

Re: [PATCH v2 0/4] i2c-hid: Save power by reducing i2c xfers with block reads

2020-09-22 Thread Wolfram Sang
> Hans, Benjamin, could you please give this patchset some smoke-testing? It > looks good to me, but I'd like it to get some testing from your testing > machinery before merging. Please give me some more days. I am not fully convinced yet that this use of I2C_M_RECV_LEN is not broken on some

Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()

2020-09-21 Thread Wolfram Sang
On Fri, Sep 04, 2020 at 03:11:52PM +0200, Paul Cercueil wrote: > CONFIG_OF is selected by CONFIG_MACH_INGENIC, therefore we don't need to > handle the case where Device Tree is not supported. > > Signed-off-by: Paul Cercueil Applied to for-next, thanks! signature.asc Description: PGP

Re: [PATCH 2/3] i2c: jz4780: Add compatible string for JZ4770 SoC

2020-09-21 Thread Wolfram Sang
On Fri, Sep 04, 2020 at 03:11:51PM +0200, Paul Cercueil wrote: > The I2C controller in the JZ4770 SoC seems to work the exact same as in > the JZ4780 SoC. > > Signed-off-by: Paul Cercueil Applied to for-next, thanks! signature.asc Description: PGP signature

Re: [PATCH 1/3] dt-bindings: i2c: ingenic: Add compatible string for the JZ4770

2020-09-21 Thread Wolfram Sang
On Fri, Sep 04, 2020 at 03:11:50PM +0200, Paul Cercueil wrote: > The I2C controller in the JZ4770 SoC seems to work the exact same as in > the JZ4780 SoC. > > We could use "ingenic,jz4780-i2c" as a fallback string in the Device > Tree, but that would be awkward, since the JZ4780 is newer.

Re: [PATCH 3/3] i2c: jz4780: Remove of_match_ptr()

2020-09-21 Thread Wolfram Sang
> Indeed, because jz4780_i2c_of_matches isn't within a CONFIG_OF ifdef > as is sometimes done and is when you need of_match_ptr(). IMO, the > commit msg should have something like "The driver is only used with > CONFIG_OF enabled, so of_match_ptr() is not necessary. > jz4780_i2c_of_matches is

Re: [PATCH] i2c: amd_mp2: handle num is 0 input for i2c_amd_xfer

2020-09-21 Thread Wolfram Sang
On Fri, Sep 04, 2020 at 11:06:47AM -0700, t...@redhat.com wrote: > From: Tom Rix > > clang static analyzer reports this problem > > i2c-amd-mp2-plat.c:174:9: warning: Branch condition evaluates > to a garbage value > return err ? err : num; >^~~ > > err is not

Re: [PATCH] i2c: Use kobj_to_dev() API

2020-09-21 Thread Wolfram Sang
On Thu, Sep 17, 2020 at 11:08:44AM +0800, Wang Qing wrote: > Use kobj_to_dev() instead of container_of() Correct. But same patch was already sent earlier: http://patchwork.ozlabs.org/project/linux-i2c/patch/1600133898-35883-1-git-send-email-tiant...@hisilicon.com/ Still thanks! signature.asc

Re: [PATCH] i2c: Switch to using the new API kobj_to_dev()

2020-09-21 Thread Wolfram Sang
On Tue, Sep 15, 2020 at 09:38:18AM +0800, Tian Tao wrote: > Switch to using the new API kobj_to_dev(). > > Signed-off-by: Tian Tao Applied to for-next, thanks! signature.asc Description: PGP signature

Re: [PATCH v7 00/34] Improvements for Tegra I2C driver

2020-09-21 Thread Wolfram Sang
On Thu, Sep 17, 2020 at 02:44:18PM +0200, Thierry Reding wrote: > On Wed, Sep 09, 2020 at 05:49:02PM +0200, Wolfram Sang wrote: > > On Wed, Sep 09, 2020 at 06:36:50PM +0300, Dmitry Osipenko wrote: > > > 09.09.2020 12:11, Andy Shevchenko пишет: > > > > On Wed, Sep 9, 2

[PULL REQUEST] i2c for 5.9

2020-09-19 Thread Wolfram Sang
Linus, here is another bunch of fixes for I2C. Only Jean's i801 patch is a cleanup on top of Volker's i801 patch, but it will make dependency handling much easier if those two go together. Please pull. Thanks, Wolfram The following changes since commit

Re: [PATCH] i2c: mxs: use MXS_DMA_CTRL_WAIT4END instead of DMA_CTRL_ACK

2020-09-18 Thread Wolfram Sang
On Fri, Sep 11, 2020 at 05:01:39PM +0200, Matthias Schiffer wrote: > The driver-specific usage of the DMA_CTRL_ACK flag was replaced with a > custom flag in commit ceeeb99cd821 ("dmaengine: mxs: rename custom flag"), > but i2c-mxs was not updated to use the new flag, completely breaking I2C >

Re: [PATCH] i2c: mediatek: Fix generic definitions for bus frequencies

2020-09-18 Thread Wolfram Sang
> > - if (target_speed > I2C_MAX_FAST_MODE_PLUS_FREQ) > > - target_speed = I2C_MAX_FAST_MODE_PLUS_FREQ; > > + if (target_speed > I2C_MAX_HIGH_SPEED_MODE_FREQ) > > + target_speed = I2C_MAX_HIGH_SPEED_MODE_FREQ; > > Thanks for fixing this. Indeed, somehow I

Re: [sane-devel] Q: improving epson2 for Epson 12000XL

2020-09-18 Thread Wolfram Sang
Some more news on 'focus'. > b) It seems to me that set_focus is not working for this model because >e2_set_extended_scanning_parameters() says "/* XXX focus */" and no byte in >the buffer is filled with the focus value. Probably the location is > unknown? >And I'd need to snoop

Re: [PATCH v2 3/4] i2c: designware: Allow SMBus block reads up to 255 bytes in length

2020-09-17 Thread Wolfram Sang
On Wed, Sep 16, 2020 at 10:22:55PM -0700, Sultan Alsawaf wrote: > From: Sultan Alsawaf > > According to the SMBus 3.0 protocol specification, block transfer limits > were increased from 32 bytes to 255 bytes. Remove the obsolete 32-byte > limitation. Sadly, it is not that easy. We are trying to

[sane-devel] Q: improving epson2 for Epson 12000XL

2020-09-17 Thread Wolfram Sang
Hi all, thank you for SANE. We want to use it to scan a large collection of astronomical photoplates. SANE allows us to script things nicely. For that, I am currently working with an Epson 12000XL. And I have a few issues / questions regarding the epson2 driver: a) The scanner reports level

Re: [PATCH v4 1/1] i2c: algo-pca: Reapply i2c bus settings after reset

2020-09-14 Thread Wolfram Sang
> I'm happy to route it to stable@ if you think it's worth it but I don't > think there's a specific Fixes: reference that can be used. The current > behavior appears to have been that way since before git (looks like we > noticed in 2014 but it's taken me 6 years to nag people into sending >

Re: [PATCH v4 1/1] i2c: algo-pca: Reapply i2c bus settings after reset

2020-09-11 Thread Wolfram Sang
On Wed, Sep 09, 2020 at 08:39:50PM +, Chris Packham wrote: > > On 9/09/20 8:23 pm, Wolfram Sang wrote: > > On Wed, Sep 09, 2020 at 08:32:47AM +1200, Evan Nimmo wrote: > >> If something goes wrong (such as the SCL being stuck low) then we need > >> to

[PULL REQUEST] i2c for v5.9

2020-09-11 Thread Wolfram Sang
i2c: algo: pca: Reapply i2c bus settings after reset Tali Perry (1): i2c: npcm7xx: Fix timeout calculation Vadym Kochan (1): misc: eeprom: at24: register nvmem only after eeprom is ready to use Wolfram Sang (1): Merge tag 'at24-fixes-for-v5.9-rc5' of git://git.kernel.or

Re: [PATCH] i2c: stm32: do not display error when DMA is not requested

2020-09-10 Thread Wolfram Sang
> Indeed, that's a good point. I'll rework it then, to avoid the dependency > on dev_err_probe change. If that is ok, I propose to push a two patches serie > with both this fix (updated) followed by a rebased version of the > dev_err_probe patch from Krzysztof for dev_err_probe change. Perfect!

Re: [Intel-gfx] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index e32ef3f01fe8..b13b1cbcac29 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct > pci_device_id *id)

Re: [Nouveau] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index e32ef3f01fe8..b13b1cbcac29 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct > pci_device_id *id)

Re: [PATCH] i2c: stm32: do not display error when DMA is not requested

2020-09-10 Thread Wolfram Sang
On Thu, Sep 10, 2020 at 11:32:29AM +0200, Alain Volmat wrote: > DMA usage is optional for the I2C driver. check for the -ENODEV > error in order to avoid displaying an error when no DMA > has been requested. > > Signed-off-by: Alain Volmat > --- > This patch should be applied on top of the patch

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index e32ef3f01fe8..b13b1cbcac29 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct > pci_device_id *id)

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index e32ef3f01fe8..b13b1cbcac29 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct > pci_device_id *id)

Re: [dm-devel] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index e32ef3f01fe8..b13b1cbcac29 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct > pci_device_id *id)

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index e32ef3f01fe8..b13b1cbcac29 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct > pci_device_id *id)

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index e32ef3f01fe8..b13b1cbcac29 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct > pci_device_id *id)

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index e32ef3f01fe8..b13b1cbcac29 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct > pci_device_id *id)

Re: [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()

2020-09-10 Thread Wolfram Sang
On Wed, Sep 02, 2020 at 05:06:40PM +0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Thanks, but this patch was a bit earlier:

Re: [PATCH 3/9] i2c: bcm2835: Simplify with dev_err_probe()

2020-09-10 Thread Wolfram Sang
On Wed, Sep 02, 2020 at 05:06:37PM +0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Applied to for-next, thanks! signature.asc

Re: [PATCH 8/9] i2c: mux: gpmux: Simplify with dev_err_probe()

2020-09-10 Thread Wolfram Sang
On Wed, Sep 02, 2020 at 05:06:42PM +0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Applied to for-next, thanks! signature.asc

Re: [PATCH 9/9] i2c: mux: reg: Simplify with dev_err_probe()

2020-09-10 Thread Wolfram Sang
On Wed, Sep 02, 2020 at 05:06:43PM +0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Applied to for-next, thanks! signature.asc

Re: [PATCH v3 3/5] i2c: aspeed: Mask IRQ status to relevant bits

2020-09-10 Thread Wolfram Sang
On Thu, Sep 10, 2020 at 08:18:13AM +0200, Wolfram Sang wrote: > On Wed, Sep 09, 2020 at 03:30:57PM -0500, Eddie James wrote: > > Mask the IRQ status to only the bits that the driver checks. This > > prevents excessive driver warnings when operating in slave mode > > when ad

Re: [PATCH v3 3/5] i2c: aspeed: Mask IRQ status to relevant bits

2020-09-10 Thread Wolfram Sang
On Wed, Sep 09, 2020 at 03:30:57PM -0500, Eddie James wrote: > Mask the IRQ status to only the bits that the driver checks. This > prevents excessive driver warnings when operating in slave mode > when additional bits are set that the driver doesn't handle. > > Signed-off-by: Eddie James >

Re: [PATCH v3 2/5] input: misc: Add IBM Operation Panel driver

2020-09-10 Thread Wolfram Sang
; > Signed-off-by: Eddie James > Reviewed-by: Joel Stanley Reviewed-by: Wolfram Sang # I2C slave parts signature.asc Description: PGP signature

Re: [PATCH v7 00/34] Improvements for Tegra I2C driver

2020-09-09 Thread Wolfram Sang
On Wed, Sep 09, 2020 at 06:36:50PM +0300, Dmitry Osipenko wrote: > 09.09.2020 12:11, Andy Shevchenko пишет: > > On Wed, Sep 9, 2020 at 1:40 AM Dmitry Osipenko wrote: > >> > >> Hello! > >> > >> This series performs refactoring of the Tegra I2C driver code and hardens > >> the atomic-transfer mode.

Re: [PATCH v8 6/6] at24: Support probing while off

2020-09-09 Thread Wolfram Sang
> This currently conflicts with the fix I queued for at24 for v5.9. > Which tree is going to take this series? I recall we agreed on I2C. signature.asc Description: PGP signature

Re: [PATCH v3 1/2] i2c: smbus: add core function handling SMBus host-notify

2020-09-09 Thread Wolfram Sang
On Mon, Aug 03, 2020 at 07:17:55AM +0200, Alain Volmat wrote: > SMBus Host-Notify protocol, from the adapter point of view > consist of receiving a message from a client, including the > client address and some other data. > > It can be simply handled by creating a new slave device > and

Re: [PATCH v3 2/2] i2c: stm32f7: Add SMBus Host-Notify protocol support

2020-09-09 Thread Wolfram Sang
On Mon, Aug 03, 2020 at 07:17:56AM +0200, Alain Volmat wrote: > Rely on the core functions to implement the host-notify > protocol via the a I2C slave device. > > Signed-off-by: Alain Volmat Applied to for-next, thanks! signature.asc Description: PGP signature

Re: [PATCH] i2c: imx: Use dev_err_probe() to simplify error handling

2020-09-09 Thread Wolfram Sang
On Wed, Aug 12, 2020 at 11:45:54AM +0800, Anson Huang wrote: > dev_err_probe() can reduce code size, uniform error handling and record the > defer probe reason etc., use it to simplify the code. > > Signed-off-by: Anson Huang Applied to for-next, thanks! signature.asc Description: PGP

Re: [PATCH v2] i2c: i801: Register lis3lv02d I2C device on Dell Latitude 5480

2020-09-09 Thread Wolfram Sang
On Wed, Sep 02, 2020 at 12:51:37AM -0400, Jeffrey Lin wrote: > Value of /sys/devices/platform/lis3lv02d/position when > Horizontal: (36,-108,-1152) > Left elevated: (-432,-126,-1062) > Front elevated: (36,594,-936) > Upside down:(-126,-252,1098) > > Signed-off-by: Jeffrey

Re: [PATCH v4 1/1] i2c: algo-pca: Reapply i2c bus settings after reset

2020-09-09 Thread Wolfram Sang
in a lock up/high CPU usage. We need to re-apply any configuration that > had previously been set and re-enable the chip. > > Signed-off-by: Evan Nimmo > Reviewed-by: Chris Packham > Reviewed-by: Andy Shevchenko > Reviewed-by: Wolfram Sang Applied to for-current, thanks! For the

Re: [PATCH v3 1/1] i2c: algo-pca: Reapply i2c bus settings after reset

2020-09-08 Thread Wolfram Sang
Hi Evan, > changes in v2: > - changed lowercase "pca to uppercase "PCA". > - reworded and reformatted the multiline comment. > - moved the clock frequency KERN_INFO closer to the call that sets this. > - moved the i2c_bus_settings struct to the more generic i2c.h and removed > - the comments

Re: [PATCH v3] i2c: npcm7xx: Fix timeout calculation

2020-09-08 Thread Wolfram Sang
On Mon, Aug 31, 2020 at 12:31:21AM +0300, Tali Perry wrote: > timeout_usec value calculation was wrong, the calculated value > was in msec instead of usec. > > Signed-off-by: Tali Perry > Reviewed-by: Avi Fishman Applied to for-current, thanks! And thanks for the Fixes-tag, Joel.

Re: [PATCH] i2c: amd_mp2: handle num is 0 input for i2c_amd_xfer

2020-09-07 Thread Wolfram Sang
On Fri, Sep 04, 2020 at 11:06:47AM -0700, t...@redhat.com wrote: > From: Tom Rix > > clang static analyzer reports this problem > > i2c-amd-mp2-plat.c:174:9: warning: Branch condition evaluates > to a garbage value > return err ? err : num; >^~~ > > err is not

Re: Re: Re: [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery

2020-09-04 Thread Wolfram Sang
Hi Codrin, > The pinmux driver needs to have strict set to false, otherwise the > switching is not available, not at this time at least. Perhaps there is > room for improvement here, because the I2C bus is not using the pins > while we are doing GPIO recovery. Our driver doesn't use 'strict'.

Re: [PATCH 3/6] mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in v4.14

2020-09-04 Thread Wolfram Sang
The LTS granularity of patches is a nice idea! I will keep it in mind. > > Signed-off-by: Douglas Anderson In general, I like more coverage of async probing. It makes sense for SD/MMC, I think. Reviewed-by: Wolfram Sang > drivers/mmc/host/renesas_sdhi_internal_dmac

Re: [PATCH] mmc: renesas_sdhi: Drop local dma_parms

2020-09-04 Thread Wolfram Sang
gned-off-by: Robin Murphy Double-checked the mentioned commit above: Reviewed-by: Wolfram Sang No regression and same performance when checksumming a large file: Tested-by: Wolfram Sang Thanks for the patch! signature.asc Description: PGP signature

Re: [PATCH] i2c: algo-pca: Reapply i2c bus settings after reset

2020-09-01 Thread Wolfram Sang
> > +/** > > + * struct i2c_bus_settings - The configured i2c bus settings > > + * @mode: Configured i2c bus mode (PCA9665) > > + * @tlow: Configured SCL LOW period (PCA9665) > > + * @thi: Configured SCL HIGH period (PCA9665) > > + * @clock_freq: The configured clock frequency (PCA9564) > > + */

Re: [PATCH 2/5] input: misc: Add IBM Operation Panel driver

2020-09-01 Thread Wolfram Sang
> + switch (event) { > + case I2C_SLAVE_STOP: > + command_size = panel->idx; > + fallthrough; > + case I2C_SLAVE_WRITE_REQUESTED: > + panel->idx = 0; > + break; > + case I2C_SLAVE_WRITE_RECEIVED: > + if (panel->idx <

Re: [PATCH 4/5] ARM: dts: Aspeed: Tacoma: Add IBM Operation Panel I2C device

2020-09-01 Thread Wolfram Sang
> > + ibm-panel@62 { > > + compatible = "ibm,op-panel"; > > + reg = <0x4062>; /* I2C_OWN_SLAVE_ADDRESS */ > > Other users of SLAVE_ADDRESS have included and > written the reg as follows: > > reg = <(I2C_OWN_SLAVE_ADDRESS | 0x62)> > > Which obviously has

[PATCH] mmc: meson-gx: use wrapper to avoid accessing internal vars

2020-08-31 Thread Wolfram Sang
Signed-off-by: Wolfram Sang --- Only buildtested. Found while analyzing retune-handling in the core. drivers/mmc/host/meson-gx-mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index 08a3b1c05acb

<    2   3   4   5   6   7   8   9   10   11   >