[storm] branch master updated: STORM-3374 remove unnecessary stacktrace from log

2019-04-15 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git The following commit(s) were added to refs/heads/master by this push: new 0dafa83 STORM-3374 remove unnecessary stacktrace

[storm] branch 1.1.x-branch updated: [STORM-3233] Update zookeeper to version 3.4.14, branch 1.1.x

2019-04-05 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch 1.1.x-branch in repository https://gitbox.apache.org/repos/asf/storm.git The following commit(s) were added to refs/heads/1.1.x-branch by this push: new cb52d39 [STORM-3233] Update zookeeper

[storm] branch 1.x-branch updated: [STORM-3233] Updating zookeeper to version 3.4.14, 1.x branch

2019-04-05 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch 1.x-branch in repository https://gitbox.apache.org/repos/asf/storm.git The following commit(s) were added to refs/heads/1.x-branch by this push: new d42c204 [STORM-3233] Updating zookeeper

[storm] branch master updated: [STORM-3233] Update zookeeper version to 3.4.14

2019-04-05 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git The following commit(s) were added to refs/heads/master by this push: new 3482d41 [STORM-3233] Update zookeeper version

[storm] branch master updated: MINOR: Default Kafka poll timeout is 200ms, not 2s

2019-03-29 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git The following commit(s) were added to refs/heads/master by this push: new 52989cb MINOR: Default Kafka poll timeout

[storm] branch master updated: STORM-3363 Migrate Aether to maven-resolver as Aether is donated to ASF

2019-03-29 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git The following commit(s) were added to refs/heads/master by this push: new 9b36f63 STORM-3363 Migrate Aether to maven

[storm] branch master updated (ca3a17a -> 68d2f49)

2019-03-15 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/storm.git. from ca3a17a Merge branch 'minor-update-maven-repository-to-https' new 7191246 STORM-3353: Upgrade to Curator 4.2.0

[storm] 03/06: STORM-3355: Use supervisor.worker.shutdown.sleep.secs to set worker suicide delay to allow users to configure how long they're willing to wait for orderly shutdown

2019-03-15 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 60199bd7600a7d8b32cea59d5691c279e4032c0f Author: Stig Rohde Døssing AuthorDate: Tue Mar 12 08:50:08 2019 +0100 STORM

[storm] 05/06: Merge branch 'STORM-3312' of https://github.com/srdo/storm into asfgit-master

2019-03-15 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 65ce33cc6dfdad5261dd1609dc95965262d6c299 Merge: 18e24a3 b25c242 Author: Stig Rohde Døssing AuthorDate: Fri Mar 15 22:00:14

[storm] 01/06: STORM-3312: Upgrade Guava to latest version where possible

2019-03-15 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit b25c242813da80dd1c5ee1ef6aa33499a0c1c10b Author: Stig Rohde Døssing AuthorDate: Wed Jan 9 22:07:37 2019 +0100 STORM

[storm] 02/06: STORM-3353: Upgrade to Curator 4.2.0

2019-03-15 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 719124682e6a736fac5c4e089bed55f9d45e7b20 Author: Stig Rohde Døssing AuthorDate: Mon Mar 11 17:57:17 2019 +0100 STORM

[storm] 04/06: Merge branch 'STORM-3353' of https://github.com/srdo/storm into asfgit-master

2019-03-15 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 18e24a31745d9f6116e4c0dfca6e2d9d78a1625f Merge: ca3a17a 7191246 Author: Stig Rohde Døssing AuthorDate: Fri Mar 15 21:58:40

[storm] 06/06: Merge branch 'STORM-3355' of https://github.com/srdo/storm into asfgit-master

2019-03-15 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 68d2f49e2bfd984b9d015bc7f40ae600a0031ca1 Merge: 65ce33c 60199bd Author: Stig Rohde Døssing AuthorDate: Fri Mar 15 22:00:58

[storm] 04/07: Merge branch 'STORM-3321' of https://github.com/srdo/storm into asfgit-master

2019-03-06 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 57befa1a3dbfbbca93299223007559f00c1c6f55 Merge: b074136 da12d89 Author: Stig Rohde Døssing AuthorDate: Thu Mar 7 07:10:12

[storm] 02/07: STORM-3349: Upgrade Hadoop, Hive, HDFS, HBase to latest compatible versions

2019-03-06 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 41fe57a9a65f8b0007d327f01442ecb8d0982521 Author: Stig Rohde Døssing AuthorDate: Wed Feb 27 13:26:06 2019 +0100 STORM

[storm] branch master updated (b074136 -> e0feb6c)

2019-03-06 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/storm.git. from b074136 Merge branch 'STORM-3348-master' of https://github.com/OjhaVivek/storm into asfgit-master add da12d89

[storm] 05/07: Merge branch 'STORM-3347' of https://github.com/srdo/storm into asfgit-master

2019-03-06 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 002bc97d4acd497f9bfb0e64edd131f6b34e7ea8 Merge: 57befa1 da8c453 Author: Stig Rohde Døssing AuthorDate: Thu Mar 7 07:11:40

[storm] 06/07: Merge branch 'STORM-3349' of https://github.com/srdo/storm into asfgit-master

2019-03-06 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 0a4b4330e585e5a40845b1752b14f9beacb92268 Merge: 002bc97 41fe57a Author: Stig Rohde Døssing AuthorDate: Thu Mar 7 07:11:57

[storm] 01/07: STORM-3347: Don't use maven-exec-plugin in storm-starter

2019-03-06 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit da8c4539e7c697b2ca706a26a0a6092930dc7ae0 Author: Stig Rohde Døssing AuthorDate: Wed Feb 27 20:38:52 2019 +0100 STORM

[storm] 03/07: STORM-3350: Upgrade Jackson, ActiveMQ, commons-collections, commons-compress, Kafka and Maven plugins

2019-03-06 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 232933175b2a1d04eb7262881d2872daec75f5d8 Author: Stig Rohde Døssing AuthorDate: Tue Mar 5 12:24:48 2019 +0100 STORM

[storm] 07/07: Merge branch 'STORM-3350' of https://github.com/srdo/storm into asfgit-master

2019-03-06 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit e0feb6cf04107029d4b24420f265495cdfbdb098 Merge: 0a4b433 2329331 Author: Stig Rohde Døssing AuthorDate: Thu Mar 7 07:12:04

[storm] branch 1.x-branch updated: Issue fix - incorrect kafka spout lag error message for newer kafka spout version but null group id config

2019-03-05 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch 1.x-branch in repository https://gitbox.apache.org/repos/asf/storm.git The following commit(s) were added to refs/heads/1.x-branch by this push: new fda3229 Issue fix - incorrect kafka spout

[storm] branch master updated: STORM-3348 Incorrect message when group id is not provided as kafka spout config on storm ui

2019-03-05 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git The following commit(s) were added to refs/heads/master by this push: new d1bd668 STORM-3348 Incorrect message when group

[storm] branch master updated: STORM-3330: Fix integration test

2019-02-27 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git The following commit(s) were added to refs/heads/master by this push: new ab8de9a STORM-3330: Fix integration test ab8de9a

[storm] branch master updated (9fea42f -> e909b3d)

2019-02-21 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/storm.git. from 9fea42f Merge branch 'STORM-3327' of https://github.com/srdo/storm into asfgit-master new 435e57b STORM-3335

[storm] 02/03: Merge branch 'agresch_STORM-3335' of https://github.com/agresch/storm into asfgit-master

2019-02-21 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit e3029000620f9dd07463c58cc5b5ada3fa39f43f Merge: 9fea42f 435e57b Author: Stig Rohde Døssing AuthorDate: Thu Feb 21 10:39:56

[storm] 03/03: STORM-3330: More storm-webapp path cleanup

2019-02-21 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit e909b3d604367e7c47c3bbf3ec8e7f6b672ff778 Author: Stig Rohde Døssing AuthorDate: Thu Feb 21 11:29:57 2019 +0100 STORM

[storm] 01/03: STORM-3335 allow timing out when scheduling a topology

2019-02-21 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 435e57b09ec8d00d2e630f710f0f6db9f0746842 Author: Aaron Gresch AuthorDate: Fri Feb 8 15:53:53 2019 -0600 STORM-3335

[storm] branch 1.x-branch updated: STORM-3330: More storm-webapp path cleanup

2019-02-21 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch 1.x-branch in repository https://gitbox.apache.org/repos/asf/storm.git The following commit(s) were added to refs/heads/1.x-branch by this push: new f375b02 STORM-3330: More storm-webapp

[storm] branch 1.1.x-branch updated: STORM-3330: More storm-webapp path cleanup

2019-02-21 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch 1.1.x-branch in repository https://gitbox.apache.org/repos/asf/storm.git The following commit(s) were added to refs/heads/1.1.x-branch by this push: new 1fd9b25 STORM-3330: More storm-webapp

[storm] 01/02: Merge branch 'STORM-3330' of https://github.com/srdo/storm into asfgit-master

2019-02-16 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit d93bce040627e606214288fc16ade2fb488e6cf4 Merge: 6bbe435 9df5de6 Author: Stig Rohde Døssing AuthorDate: Sat Feb 16 12:51:08

[storm] 02/02: Merge branch 'STORM-3327' of https://github.com/srdo/storm into asfgit-master

2019-02-16 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 9fea42fe11f808550e604ec349b4b3366d20929b Merge: d93bce0 d3c784c Author: Stig Rohde Døssing AuthorDate: Sat Feb 16 12:51:29

[storm] branch master updated (6bbe435 -> 9fea42f)

2019-02-16 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/storm.git. from 6bbe435 Merge pull request #2951 from agresch/agresch_STORM-3328 add 9df5de6 STORM-3330: Migrate some of storm

[storm] branch master updated: STORM-3333 provide kafka classes for storm-kafka-monitor

2019-02-08 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git The following commit(s) were added to refs/heads/master by this push: new ecb142b STORM- provide kafka classes

[storm] 02/02: Merge branch 'STORM-3326' of https://github.com/srdo/storm into asfgit-master

2019-02-06 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 4b665dbbb8c3e45dbe5c8cdf8363efd1e88b369b Merge: 8000bd3 4f00d6a Author: Stig Rohde Døssing AuthorDate: Wed Feb 6 19:30:00

[storm] 01/02: Merge branch 'STORM-3325' of https://github.com/srdo/storm into asfgit-master

2019-02-06 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 8000bd30e710e8ad6a24d01680ee59e70d735391 Merge: 8f49e06 0abf0f6 Author: Stig Rohde Døssing AuthorDate: Wed Feb 6 19:29:35

[storm] 01/07: MINOR: Remove reference to deleted Subscription interface in storm-kafka-client docs

2019-01-30 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit c466f5f563cf675c3b3c08701e86e4a317741641 Author: Stig Rohde Døssing AuthorDate: Wed Jan 23 19:10:07 2019 +0100 MINOR

[storm] 05/07: Merge branch 'fix-kafka-example-docs' of https://github.com/srdo/storm into asfgit-master

2019-01-30 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 564bf83ecbe59d8b951867247edd2bf276b8495a Merge: 31c7e22 111aa8d Author: Stig Rohde Døssing AuthorDate: Wed Jan 30 12:38:54

[storm] 07/07: Merge branch 'minor-fix-assignment-docs' of https://github.com/srdo/storm into asfgit-master

2019-01-30 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 8f49e06998abb4dfc50f51d78b6784ebd04844fb Merge: 6175a04 c466f5f Author: Stig Rohde Døssing AuthorDate: Wed Jan 30 12:40:13

[storm] 03/07: Merge branch 'STORM-3310' of https://github.com/srdo/storm into asfgit-master

2019-01-30 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit f7883f82945113f4999dc2f23b299234b58142a4 Merge: df9fde4 9069e30 Author: Stig Rohde Døssing AuthorDate: Wed Jan 30 12:38:03

[storm] 02/07: Merge branch 'STORM-3309' of https://github.com/srdo/storm into asfgit-master

2019-01-30 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit df9fde4ae4fcea348c3823a1aa0a974ad18304be Merge: 604ecf7 0c82b8f Author: Stig Rohde Døssing AuthorDate: Wed Jan 30 12:37:48

[storm] 06/07: Merge branch 'master' of https://github.com/MichealShin/storm into asfgit-master

2019-01-30 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 6175a04b1345c49e0f065f5bc6af85ecf8a0f16d Merge: 564bf83 444e051 Author: Stig Rohde Døssing AuthorDate: Wed Jan 30 12:39:30

[storm] 04/07: Merge branch 'master' of https://github.com/esamson/storm into asfgit-master

2019-01-30 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/storm.git commit 31c7e22f809e4d5de27c06fbfd4ddf380e1059e1 Merge: f7883f8 b1a8a06 Author: Stig Rohde Døssing AuthorDate: Wed Jan 30 12:38:36

[storm] branch master updated (604ecf7 -> 8f49e06)

2019-01-30 Thread srdo
This is an automated email from the ASF dual-hosted git repository. srdo pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/storm.git. from 604ecf7 Merge branch 'master' of govind-menon's fork into master add 0c82b8f STORM-3309: Fix flaky tick tuple

[GitHub] storm issue #2941: STORM-3318: Complete information in Class NewKafkaSpoutOf...

2019-01-18 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2941 +1. Please squash, and we can merge once the waiting period is over. I'll probably wait to merge this until we are done with the current 2.0.0 RC vote. ---

[GitHub] storm pull request #2941: STORM-3318: Complete information in Class NewKafka...

2019-01-18 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2941#discussion_r249026503 --- Diff: external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/NewKafkaSpoutOffsetQuery.java --- @@ -64,27 +64,51 @@ public String

[GitHub] storm issue #2940: STORM-3318: Complete information in Class NewKafkaSpoutOf...

2019-01-18 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2940 @MichealShin You don't need to open a new PR. If you push your changes to the branch this PR is pointing at, the PR will get updated automatically. That said, I think Github gets weird about

[GitHub] storm pull request #2940: STORM-3318: Complete information in Class NewKafka...

2019-01-18 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2940#discussion_r248985594 --- Diff: external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/NewKafkaSpoutOffsetQuery.java --- @@ -75,8 +77,13 @@ public boolean equals

[GitHub] storm issue #2940: STORM-3318: Complete information in Class NewKafkaSpoutOf...

2019-01-18 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2940 Looks good. Please squash to one commit. ---

[GitHub] storm pull request #2939: STORM-3315: Upgrade to Kryo 4

2019-01-17 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2939 STORM-3315: Upgrade to Kryo 4 https://issues.apache.org/jira/browse/STORM-3315 Tested compatibility with Kryo 3.0.3 serialization by running the TVL topology for a couple of minutes with two

[GitHub] storm issue #2930: STORM-3274: Migrates storm CLI to using argparse making d...

2019-01-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2930 Thanks, looks great. The positional arguments don't seem to be sorted. I get ``` usage: storm [-h] [--config CONFIG] [-storm_config_opts -c] {jar,localconfvalue

[GitHub] storm issue #2930: STORM-3274: Migrates storm CLI to using argparse making d...

2019-01-12 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2930 The .pyc issue can be solved by adding `true` to the environment variables for the two `exec-maven-plugin` executions ---

[GitHub] storm issue #2930: STORM-3274: Migrates storm CLI to using argparse making d...

2019-01-12 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2930 Thanks. It looks great. A few final things: * When running `mvn clean install -DskipTests`, the tests for the script are still run. Can we skip the executions if `skipTests` is true

[GitHub] storm pull request #2937: MINOR: Remove unused parameter from storm-kafka-cl...

2019-01-11 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2937 MINOR: Remove unused parameter from storm-kafka-client-example docs The kafka_artifact_id parameter is not used anymore. You can merge this pull request into a Git repository by running: $ git

[GitHub] storm issue #1550: [STORM-1957] Support Storm JDBC batch insert

2019-01-10 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/1550 @bigbang4u2 We bulk closed old unmerged pull requests a while ago. This PR wasn't approved, and wasn't updated for a long time, so it was closed. If you want this feature to get merged, you would

[GitHub] storm pull request #2936: STORM-3312: Upgrade Guava to latest version where ...

2019-01-09 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2936 STORM-3312: Upgrade Guava to latest version where possible https://issues.apache.org/jira/browse/STORM-3312 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] storm issue #2935: Doc clarification on returning `null` from RecordTranslat...

2019-01-09 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2935 +1 ---

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245727413 --- Diff: bin/storm.py --- @@ -296,787 +239,1044 @@ def exec_storm_class(klass, jvmtype="-server", jvmopts=[], extrajars=[], args=[] elif

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245744213 --- Diff: bin/storm.py --- @@ -296,787 +239,1044 @@ def exec_storm_class(klass, jvmtype="-server", jvmopts=[], extrajars=[], args=[] elif

[GitHub] storm issue #2930: STORM-3274: Migrates storm CLI to using argparse making d...

2019-01-07 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2930 Nit: The existing help message prints the commands alphabetically. We might want to do the same with the new help message. Quick google suggests it is possible https://stackoverflow.com/questions

[GitHub] storm issue #2930: STORM-3274: Migrates storm CLI to using argparse making d...

2019-01-07 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2930 Can we make running `storm.py` with 0 arguments equivalent to running `storm.py -h`? Running just `storm.py` gives the following output, which isn't very nice: ``` PS E:\apache-storm-2.0.1

[GitHub] storm issue #2930: STORM-3274: Migrates storm CLI to using argparse making d...

2019-01-07 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2930 When I run the build, a storm.pyc file is generated in the storm/bin directory. This file ends up in the storm-dist distribution. I'm guessing this isn't intentional? ---

[GitHub] storm issue #2930: STORM-3274: Migrates storm CLI to using argparse making d...

2019-01-07 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2930 Would it make sense to run the tests for Python 3 as well as Python 2.7? ---

[GitHub] storm issue #2930: STORM-3274: Migrates storm CLI to using argparse making d...

2019-01-07 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2930 This is in reply to https://github.com/apache/storm/pull/2930#discussion_r245726485, for some reason Github won't let me put another comment there. Makes sense. I think we should at least note

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245725371 --- Diff: storm-client/pom.xml --- @@ -240,6 +240,29

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245722204 --- Diff: bin/storm.py --- @@ -296,787 +239,1044 @@ def exec_storm_class(klass, jvmtype="-server", jvmopts=[], extrajars=[], args=[] elif

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245714702 --- Diff: bin/storm.py --- @@ -132,13 +56,8 @@ def get_jars_full(adir): elif os.path.exists(adir): files = [adir] -ret

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245715647 --- Diff: bin/storm.py --- @@ -156,49 +95,92 @@ def get_classpath(extrajars, daemon=True, client=False): ret.extend(get_wildcard_dir(os.path.join

[GitHub] storm issue #2934: STORM-3310: Make JCQueueTest wait for consumer to read al...

2019-01-07 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2934 I'd recommend looking at the diff via https://github.com/apache/storm/pull/2934/files?w=1, since the indentation changes make it hard to tell what changed. ---

[GitHub] storm pull request #2934: STORM-3310: Make JCQueueTest wait for consumer to ...

2019-01-07 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2934 STORM-3310: Make JCQueueTest wait for consumer to read all queued ite… …ms before terminating https://issues.apache.org/jira/browse/STORM-3310 I've only seen the test fail once

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-07 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245602260 --- Diff: storm-client/pom.xml --- @@ -240,6 +240,29

[GitHub] storm issue #2933: STORM-3309: Fix flaky tick tuple test

2019-01-05 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2933 The test passed 100 iterations using `@RepeatedTest` ---

[GitHub] storm pull request #2933: STORM-3309: Fix flaky tick tuple test

2019-01-05 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2933 STORM-3309: Fix flaky tick tuple test https://issues.apache.org/jira/browse/STORM-3309 I've made the following changes: * When message timeout is disabled, the acker shouldn't time out

[GitHub] storm pull request #2930: STORM-3274: Migrates storm CLI to using argparse m...

2019-01-05 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2930#discussion_r245480567 --- Diff: storm-client/pom.xml --- @@ -240,6 +240,29

[GitHub] storm issue #2924: STORM-1289: Port integration-test.clj to Java

2019-01-05 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2924 Approved as part of https://github.com/apache/storm/pull/2927 ---

[7/7] storm git commit: Merge branch 'STORM-1307' of https://github.com/srdo/storm into asfgit-master

2019-01-05 Thread srdo
Merge branch 'STORM-1307' of https://github.com/srdo/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/7908fac0 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/7908fac0 Diff: http://git-wip

[2/7] storm git commit: STORM-1289: Port integration-test.clj to Java

2019-01-05 Thread srdo
STORM-1289: Port integration-test.clj to Java Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/d6a1e730 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/d6a1e730 Diff:

[4/7] storm git commit: STORM-1307: Port testing4j_test.clj to Java

2019-01-05 Thread srdo
STORM-1307: Port testing4j_test.clj to Java Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/02e0e75c Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/02e0e75c Diff:

[1/7] storm git commit: STORM-1289: Port integration-test.clj to Java

2019-01-05 Thread srdo
Repository: storm Updated Branches: refs/heads/master 7575a0027 -> 7908fac03 http://git-wip-us.apache.org/repos/asf/storm/blob/d6a1e730/storm-core/test/jvm/org/apache/storm/TopologyIntegrationTest.java -- diff --git

[3/7] storm git commit: STORM-1307: Port testing4j_test.clj to Java

2019-01-05 Thread srdo
http://git-wip-us.apache.org/repos/asf/storm/blob/02e0e75c/storm-core/test/jvm/org/apache/storm/integration/TopologyIntegrationTest.java -- diff --git

[6/7] storm git commit: Merge branch 'MINOR-jcqueue-overflow-limit-comment' of https://github.com/srdo/storm into asfgit-master

2019-01-05 Thread srdo
Merge branch 'MINOR-jcqueue-overflow-limit-comment' of https://github.com/srdo/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/2930f2f9 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree

[5/7] storm git commit: MINOR: Correct comment about overflow limiting in JCQueue. Setting overflow limit to 0 disables limiting, does not disable overflow

2019-01-05 Thread srdo
MINOR: Correct comment about overflow limiting in JCQueue. Setting overflow limit to 0 disables limiting, does not disable overflow Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/7d14d02e Tree:

[GitHub] storm issue #2932: STORM-3274: Adds mock to Travis pipeline so it can run Py...

2019-01-04 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2932 I think the build is failing because requirements.txt is being caught by the rat check. The change itself looks fine. I'm not sure it makes sense by itself though, maybe it should just

[GitHub] storm pull request #2929: MINOR: Correct comment about overflow limiting in ...

2018-12-21 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2929 MINOR: Correct comment about overflow limiting in JCQueue. Setting ov… …erflow limit to 0 disables limiting, does not disable overflow You can merge this pull request into a Git repository

[GitHub] storm pull request #2927: STORM-1307: Port testing4j_test.clj to Java

2018-12-18 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2927#discussion_r242739488 --- Diff: storm-core/test/jvm/org/apache/storm/integration/TopologyIntegrationTest.java --- @@ -0,0 +1,927 @@ +/* + * Copyright 2018 The Apache

[GitHub] storm pull request #2927: STORM-1307: Port testing4j_test.clj to Java

2018-12-18 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2927#discussion_r242699069 --- Diff: storm-core/test/jvm/org/apache/storm/integration/TopologyIntegrationTest.java --- @@ -0,0 +1,927 @@ +/* + * Copyright 2018 The Apache

[GitHub] storm pull request #2927: STORM-1307: Port testing4j_test.clj to Java

2018-12-18 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2927#discussion_r242698501 --- Diff: storm-core/test/jvm/org/apache/storm/integration/TopologyIntegrationTest.java --- @@ -0,0 +1,927 @@ +/* + * Copyright 2018 The Apache

[GitHub] storm issue #2908: STORM-3276: Updated Flux to deal with storm local correct...

2018-12-18 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2908 +1. I'm still wondering why we need to preserve command line options here https://github.com/apache/storm/pull/2908#discussion_r236358832 but I think it's fine either way. ---

[3/4] storm git commit: Merge branch 'STORM-3300' of https://github.com/srdo/storm into asfgit-master

2018-12-18 Thread srdo
Merge branch 'STORM-3300' of https://github.com/srdo/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/cecff46b Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/cecff46b Diff: http://git-wip

[4/4] storm git commit: Merge branch 'STORM-3270' of https://github.com/srdo/storm into asfgit-master

2018-12-18 Thread srdo
Merge branch 'STORM-3270' of https://github.com/srdo/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/a9c2f3ad Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/a9c2f3ad Diff: http://git-wip

[1/4] storm git commit: STORM-3300: Fix NPE in Acker that could occur if sending reset timeout tuples

2018-12-18 Thread srdo
Repository: storm Updated Branches: refs/heads/master e46a87a86 -> a9c2f3adb STORM-3300: Fix NPE in Acker that could occur if sending reset timeout tuples Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/df84dec0 Tree:

[2/4] storm git commit: STORM-3270: Build Storm with Java 11, excluding some incompatible modules

2018-12-18 Thread srdo
STORM-3270: Build Storm with Java 11, excluding some incompatible modules Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/ec634bd6 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/ec634bd6 Diff:

[GitHub] storm issue #2928: STORM-3270: Build Storm with Java 11, excluding some inco...

2018-12-14 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2928 The build failed because of a hiccup when downloading dependencies. See https://travis-ci.org/srdo/storm/builds/468124888 instead. ---

[GitHub] storm pull request #2928: STORM-3270: Build Storm with Java 11, excluding so...

2018-12-14 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2928 STORM-3270: Build Storm with Java 11, excluding some incompatible mod… …ules https://issues.apache.org/jira/browse/STORM-3270 All Hadoop-related modules are excluded from tests

[2/2] storm git commit: Merge branch 'STORM-2990' of https://github.com/srdo/storm into asfgit-master

2018-12-14 Thread srdo
Merge branch 'STORM-2990' of https://github.com/srdo/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/e46a87a8 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/e46a87a8 Diff: http://git-wip

[GitHub] storm issue #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trident spo...

2018-12-14 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2907 Thanks for the reviews, merged to master. ---

[1/2] storm git commit: STORM-2990, STORM-3279: Fix issue where Kafka Trident spout could ignore EARLIEST and LATEST, and make EARLIEST and LATEST only take effect on topology deploy

2018-12-14 Thread srdo
Repository: storm Updated Branches: refs/heads/master 43859e9e8 -> e46a87a86 STORM-2990, STORM-3279: Fix issue where Kafka Trident spout could ignore EARLIEST and LATEST, and make EARLIEST and LATEST only take effect on topology deploy Project:

[GitHub] storm pull request #2927: STORM-1307: Port testing4j_test.clj to Java

2018-12-12 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2927 STORM-1307: Port testing4j_test.clj to Java Follow up to https://github.com/apache/storm/pull/2924, please review that one first. You can merge this pull request into a Git repository by running

[1/2] storm git commit: STORM-3297 prevent supervisor restart when no nimbus leader exists

2018-12-12 Thread srdo
Repository: storm Updated Branches: refs/heads/master f5b3f93fc -> 43859e9e8 STORM-3297 prevent supervisor restart when no nimbus leader exists Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/afa173f6 Tree:

[2/2] storm git commit: Merge branch 'agresch_processWorkerMetrics' of https://github.com/agresch/storm into asfgit-master

2018-12-12 Thread srdo
Merge branch 'agresch_processWorkerMetrics' of https://github.com/agresch/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/43859e9e Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/43859e9e

<    1   2   3   4   5   6   7   8   9   10   >