[2/3] storm git commit: Merge branch 'STORM-3301-1.x' of https://github.com/srdo/storm into asfgit-1.x-branch

2018-12-11 Thread srdo
Merge branch 'STORM-3301-1.x' of https://github.com/srdo/storm into asfgit-1.x-branch Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/adf5a738 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/adf5a738 Diff: http://git

[1/3] storm git commit: STORM-3301: Fix case where KafkaSpout could emit tuples that were already committed

2018-12-11 Thread srdo
Repository: storm Updated Branches: refs/heads/1.x-branch e6828f25f -> 97ae1dc0b STORM-3301: Fix case where KafkaSpout could emit tuples that were already committed Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit:

[3/3] storm git commit: STORM-3289: Add note about KAFKA-7044 to storm-kafka-client compatibility documentation

2018-12-11 Thread srdo
STORM-3289: Add note about KAFKA-7044 to storm-kafka-client compatibility documentation Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/97ae1dc0 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/97ae1dc0 Diff:

[5/8] storm git commit: Merge branch 'STORM-3301' of https://github.com/srdo/storm into asfgit-master

2018-12-11 Thread srdo
Merge branch 'STORM-3301' of https://github.com/srdo/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/7340e849 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/7340e849 Diff: http://git-wip

[1/8] storm git commit: STORM-3289: Add note about KAFKA-7044 to storm-kafka-client compatibility documentation

2018-12-11 Thread srdo
Repository: storm Updated Branches: refs/heads/master 94cd157c0 -> f5b3f93fc STORM-3289: Add note about KAFKA-7044 to storm-kafka-client compatibility documentation Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit:

[3/8] storm git commit: STORM-3294: Upgrade jetty version to latest stable

2018-12-11 Thread srdo
STORM-3294: Upgrade jetty version to latest stable Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/b53f6a15 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/b53f6a15 Diff:

[8/8] storm git commit: Merge branch 'STORM-3289' of https://github.com/srdo/storm into asfgit-master

2018-12-11 Thread srdo
Merge branch 'STORM-3289' of https://github.com/srdo/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/f5b3f93f Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/f5b3f93f Diff: http://git-wip

[4/8] storm git commit: STORM-3301: Fix case where KafkaSpout could emit tuples that were already committed

2018-12-11 Thread srdo
STORM-3301: Fix case where KafkaSpout could emit tuples that were already committed Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/8bb01856 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/8bb01856 Diff:

[6/8] storm git commit: Merge branch 'STORM-3296' of https://github.com/srdo/storm into asfgit-master

2018-12-11 Thread srdo
Merge branch 'STORM-3296' of https://github.com/srdo/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/ce2e2b36 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/ce2e2b36 Diff: http://git-wip

[7/8] storm git commit: Merge branch 'upgrade-jetty-version' of https://github.com/kishorvpatil/incubator-storm into asfgit-master

2018-12-11 Thread srdo
Merge branch 'upgrade-jetty-version' of https://github.com/kishorvpatil/incubator-storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/5c7c0dfc Tree:

[2/8] storm git commit: STORM-3296: Upgrade curator-test to avoid CURATOR-409

2018-12-11 Thread srdo
STORM-3296: Upgrade curator-test to avoid CURATOR-409 Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/3c4646a1 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/3c4646a1 Diff:

[GitHub] storm issue #2920: STORM-3297 prevent supervisor restart when no nimbus lead...

2018-12-11 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2920 +1, please squash to one commit and I'll merge :) ---

[GitHub] storm pull request #2924: STORM-1289: Port integration-test.clj to Java

2018-12-09 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2924 STORM-1289: Port integration-test.clj to Java https://issues.apache.org/jira/browse/STORM-1289 I have also ported a few tests to JUnit 5 and changed the IntegrationTest and PerformanceTest

[GitHub] storm issue #2922: STORM-3301: Fix case where KafkaSpout could emit tuples t...

2018-12-08 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2922 The test failure is due to broken stubbing, I'll fix it soon ---

[GitHub] storm pull request #2923: STORM-3301: Fix case where KafkaSpout could emit t...

2018-12-08 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2923 STORM-3301: Fix case where KafkaSpout could emit tuples that were alr… …eady committed 1.x version of https://github.com/apache/storm/pull/2922 You can merge this pull request into a Git

[GitHub] storm pull request #2922: STORM-3301: Fix case where KafkaSpout could emit t...

2018-12-08 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2922 STORM-3301: Fix case where KafkaSpout could emit tuples that were alr… …eady committed https://issues.apache.org/jira/browse/STORM-3301 I removed an unnecessary contains check

[GitHub] storm pull request #2921: STORM-3300: Fix NPE in Acker that could occur if s...

2018-12-08 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2921 STORM-3300: Fix NPE in Acker that could occur if sending reset timeou… …t tuples The error occurs when `int task = curr.spoutTask;` is hit during processing of a reset timeout tuple

[GitHub] storm issue #2917: [STORM-3294] Upgrade jetty version to latest stable 9.4.1...

2018-12-05 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2917 Ok, just wanted to be sure that there wasn't an issue to document. +1 ---

[GitHub] storm issue #2917: [STORM-3294] Upgrade jetty version to latest stable 9.4.1...

2018-12-05 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2917 Looks good. Could you update the commit message to contain the issue number? Is this upgrade fixing a known issue? ---

[GitHub] storm pull request #2919: STORM-3296: Upgrade curator-test to avoid CURATOR-...

2018-12-05 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2919 STORM-3296: Upgrade curator-test to avoid CURATOR-409 https://issues.apache.org/jira/browse/STORM-3296 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] storm issue #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trident spo...

2018-11-29 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2907 Rebased to fix conflicts and squashed to one commit. ---

[GitHub] storm issue #2913: STORM-3290: Split configuration for storm-kafka-client Tr...

2018-11-29 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2913 Thanks for reviewing, merged to master. ---

[2/3] storm git commit: STORM-3290: Split configuration for storm-kafka-client Trident and non-Trident spout into two classes

2018-11-29 Thread srdo
STORM-3290: Split configuration for storm-kafka-client Trident and non-Trident spout into two classes Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/63de17ed Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/63de17ed

[1/3] storm git commit: STORM-3290: Split configuration for storm-kafka-client Trident and non-Trident spout into two classes

2018-11-29 Thread srdo
Repository: storm Updated Branches: refs/heads/master 52cb6b20a -> 6d871a73e http://git-wip-us.apache.org/repos/asf/storm/blob/63de17ed/external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitterTest.java

[GitHub] storm pull request #2908: STORM-3276: Updated Flux to deal with storm local ...

2018-11-28 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2908#discussion_r237005496 --- Diff: flux/flux-core/src/main/java/org/apache/storm/flux/Flux.java --- @@ -52,17 +52,22 @@ public class Flux { private static final Logger LOG

[GitHub] storm issue #2912: STORM-3289: Add note about KAFKA-7044 to storm-kafka-clie...

2018-11-27 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2912 Yes, I think those are the affected versions. I figured people would go look at the JIRA to see which versions are affected, but I'll list them here as well. ---

[GitHub] storm pull request #2908: STORM-3276: Updated Flux to deal with storm local ...

2018-11-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2908#discussion_r236360412 --- Diff: storm-server/src/main/java/org/apache/storm/LocalCluster.java --- @@ -323,6 +342,13 @@ private static boolean areAllWorkersWaiting

[GitHub] storm pull request #2908: STORM-3276: Updated Flux to deal with storm local ...

2018-11-26 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2908#discussion_r236358832 --- Diff: flux/flux-core/src/main/java/org/apache/storm/flux/Flux.java --- @@ -52,17 +52,22 @@ public class Flux { private static final Logger LOG

[GitHub] storm issue #2914: STORM-1311: Removing superfluous debugging

2018-11-24 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2914 Thanks @govind-menon, merged to master. ---

[4/4] storm git commit: Merge branch 'patch-2' of https://github.com/govind-menon/storm into asfgit-master

2018-11-24 Thread srdo
Merge branch 'patch-2' of https://github.com/govind-menon/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/52cb6b20 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/52cb6b20 Diff:

[1/4] storm git commit: STORM-3288: Fix issue with reources in jar files

2018-11-24 Thread srdo
Repository: storm Updated Branches: refs/heads/master 40f1b6104 -> 52cb6b20a STORM-3288: Fix issue with reources in jar files Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/5784eb1a Tree:

[3/4] storm git commit: Merge branch 'STORM-3288' of https://github.com/revans2/incubator-storm into asfgit-master

2018-11-24 Thread srdo
Merge branch 'STORM-3288' of https://github.com/revans2/incubator-storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/043b4eec Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/043b4eec Diff:

[2/4] storm git commit: STORM-1311: Removing superfluous debugging

2018-11-24 Thread srdo
STORM-1311: Removing superfluous debugging Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/c9291894 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/c9291894 Diff:

[GitHub] storm issue #2914: STORM-1311: Removing superfluous debugging

2018-11-21 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2914 +1 ---

[GitHub] storm pull request #2913: STORM-3290: Split configuration for storm-kafka-cl...

2018-11-20 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2913 STORM-3290: Split configuration for storm-kafka-client Trident and no… …n-Trident spout into two classes. https://issues.apache.org/jira/browse/STORM-3290 This moves configuration

[GitHub] storm pull request #2911: STORM-2720 : Add TIMESTAMP option for FirstPollOff...

2018-11-20 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2911#discussion_r234901127 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -137,7 +142,11 @@ public KafkaSpoutConfig

[1/2] storm git commit: add indent to log4j2 xml files

2018-11-19 Thread srdo
Repository: storm Updated Branches: refs/heads/master 29eb449ee -> 40f1b6104 add indent to log4j2 xml files Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/00cd667a Tree:

[2/2] storm git commit: Merge branch 'add-indent-log4j2-xml' of https://github.com/chiba3/storm into asfgit-master

2018-11-19 Thread srdo
Merge branch 'add-indent-log4j2-xml' of https://github.com/chiba3/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/40f1b610 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/40f1b610 Diff:

[GitHub] storm issue #2904: add indent to log4j2 xml files

2018-11-19 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2904 Thanks @chiba3, merged to master. ---

[GitHub] storm issue #2904: add indent to log4j2 xml files

2018-11-19 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2904 +1. I think this is akin to a documentation change (formatting only), so doesn't need an issue filed for it. ---

[GitHub] storm pull request #2911: Add TIMESTAMP option for FirstPollOffset

2018-11-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2911#discussion_r234541339 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java --- @@ -137,7 +142,11 @@ public KafkaSpoutConfig

[GitHub] storm pull request #2911: Add TIMESTAMP option for FirstPollOffset

2018-11-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2911#discussion_r234542042 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java --- @@ -225,7 +229,23 @@ private void

[GitHub] storm pull request #2911: Add TIMESTAMP option for FirstPollOffset

2018-11-19 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2911#discussion_r234541619 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java --- @@ -225,7 +229,23 @@ private void

[GitHub] storm issue #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trident spo...

2018-11-16 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2907 Added a check to `reEmitPartitionBatch`. Let me know if it looks reasonable, and I'll squash. ---

[GitHub] storm issue #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trident spo...

2018-11-16 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2907 Regarding looping offsets, I don't believe Kafka really does anything special to handle offset value overflow (quick google turned up http://mail-archives.apache.org/mod_mbox/kafka-users/201510.mbox

[GitHub] storm pull request #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trid...

2018-11-16 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2907#discussion_r234338505 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java --- @@ -170,15 +170,25 @@ public void

[GitHub] storm pull request #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trid...

2018-11-15 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2907#discussion_r233750714 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java --- @@ -218,26 +228,27 @@ private void

[GitHub] storm issue #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trident spo...

2018-11-14 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2907 Test failure looks unrelated. ---

[GitHub] storm pull request #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trid...

2018-11-14 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2907 STORM-2990, STORM-3279: Fix issue where Kafka Trident spout could ign… …ore EARLIEST and LATEST, and make EARLIEST and LATEST only take effect on topology deploy See https

[GitHub] storm pull request #2905: STORM-2891: Upgrade checkstyle plugin to 3.0.0

2018-11-11 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2905 STORM-2891: Upgrade checkstyle plugin to 3.0.0 See https://issues.apache.org/jira/browse/STORM-2891 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] storm pull request #2653: [WIP] Detach storm-kafka-client release from Storm...

2018-11-10 Thread srdo
Github user srdo closed the pull request at: https://github.com/apache/storm/pull/2653 ---

[GitHub] storm issue #2653: [WIP] Detach storm-kafka-client release from Storm proper

2018-11-10 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2653 Closing due to lack of interest. ---

storm-site git commit: Add XenonStack to powered-by

2018-10-31 Thread srdo
Repository: storm-site Updated Branches: refs/heads/asf-site 785208045 -> 7e3ca9649 Add XenonStack to powered-by Project: http://git-wip-us.apache.org/repos/asf/storm-site/repo Commit: http://git-wip-us.apache.org/repos/asf/storm-site/commit/7e3ca964 Tree:

[GitHub] storm issue #2896: Storm 3261

2018-10-26 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2896 @d2r You can test this by checking out https://github.com/apache/storm-site and following the guide for publishing the documentation ---

[GitHub] storm issue #2892: Added in better docs for local mode testing.

2018-10-22 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2892 +1 ---

[GitHub] storm pull request #2892: Added in better docs for local mode testing.

2018-10-22 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2892#discussion_r227063418 --- Diff: docs/Local-mode.md --- @@ -7,7 +7,9 @@ Local mode simulates a Storm cluster in process and is useful for developing and To run a topology

[GitHub] storm pull request #2890: STORM-3268: Improve integration test stability

2018-10-22 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2890#discussion_r227033367 --- Diff: integration-test/src/main/java/org/apache/storm/st/topology/TestableTopology.java --- @@ -17,14 +17,18 @@ package

[GitHub] storm issue #2880: STORM-3250: Closes Pull Requests unchanged in 2018

2018-10-22 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2880 +1, thanks for handling this. ---

[2/2] storm git commit: Merge branch 'STORM-3268' of https://github.com/srdo/storm into asfgit-master

2018-10-22 Thread srdo
Merge branch 'STORM-3268' of https://github.com/srdo/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/3d315b85 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/3d315b85 Diff: http://git-wip

[1/2] storm git commit: STORM-3268: Try to improve integration test stability

2018-10-22 Thread srdo
Repository: storm Updated Branches: refs/heads/master 80999f405 -> 3d315b854 STORM-3268: Try to improve integration test stability Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/5b066609 Tree:

[2/4] storm git commit: STORM-3267: Disable Java 10 build

2018-10-22 Thread srdo
STORM-3267: Disable Java 10 build Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/ef9d907d Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/ef9d907d Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/ef9d907d

[4/4] storm git commit: Merge branch 'STORM-3267' of https://github.com/srdo/storm into asfgit-master

2018-10-22 Thread srdo
Merge branch 'STORM-3267' of https://github.com/srdo/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/0ef21a85 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/0ef21a85 Diff: http://git-wip

[3/4] storm git commit: Merge branch 'storm-3250-close-old-prs' of https://github.com/d2r/storm into asfgit-master

2018-10-22 Thread srdo
Merge branch 'storm-3250-close-old-prs' of https://github.com/d2r/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/9f643ac9 Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/9f643ac9 Diff:

[1/4] storm git commit: Closes Pull Requests unchanged in 2018

2018-10-22 Thread srdo
Repository: storm Updated Branches: refs/heads/master ce984cd31 -> 0ef21a85f Closes Pull Requests unchanged in 2018 We are closing stale Pull Requests to make the list more manageable. Please re-open any Pull Request that has been closed in error. Closes #608 Closes #639 Closes #640 Closes

[GitHub] storm pull request #2890: STORM-3268: Improve integration test stability

2018-10-21 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2890 STORM-3268: Improve integration test stability https://issues.apache.org/jira/browse/STORM-3268 Basically the integration test can't handle logs rolling during the test. To fix this we added

[GitHub] storm pull request #2889: STORM-3267: Disable Java 10 build

2018-10-21 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2889 STORM-3267: Disable Java 10 build https://issues.apache.org/jira/browse/STORM-3267 We can add Java 11 at some later point, but for now we need to disable the Java 10 build. You can merge

[GitHub] storm issue #2877: STORM-3255: Uses dev-zookeeper in travis-ci

2018-10-12 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2877 Looks great, +1 ---

[GitHub] storm pull request #2877: STORM-3255: Uses dev-zookeeper in travis-ci

2018-10-12 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2877#discussion_r224891745 --- Diff: integration-test/run-it.sh --- @@ -91,6 +90,11 @@ function start_storm_process() { echo starting: storm $1 sudo su storm -c "e

[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles

2018-10-04 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2858 Thanks @d2r, merged to master. ---

[2/2] storm git commit: Merge branch 'storm-3242-examples-externals-maven-profiles' of https://github.com/d2r/storm into asfgit-master

2018-10-04 Thread srdo
Merge branch 'storm-3242-examples-externals-maven-profiles' of https://github.com/d2r/storm into asfgit-master Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/dad7410e Tree:

[1/2] storm git commit: STORM-3242: Adds "examples", "externals" profiles

2018-10-04 Thread srdo
Repository: storm Updated Branches: refs/heads/master 2bc519f08 -> dad7410e2 STORM-3242: Adds "examples", "externals" profiles The existing modules have been moved into like-named Maven profiles that are enabled by default. Updates travis-ci script to use new profiles

[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles

2018-10-04 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2858 +1, thanks for addressing my comment. Please squash to one commit containing the issue number. ---

[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles

2018-10-03 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2858 I'd be fine with just moving them to the new profile. It already contains the integration test, which also isn't in externals. ---

[GitHub] storm issue #2858: STORM-3242: Adds "examples" and "externals" profiles

2018-10-03 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2858 This looks good, but I'm wondering if Flux and the sql modules should be added to externals as well? They depend on storm-kafka-client, so the build won't work with externals disabled unless you happen

[GitHub] storm issue #2840: STORM-3147: Add metrics based on ClusterSummary

2018-09-18 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2840 I'm hoping @zd-project will help review this, since this is a rebase of his PR. I don't really have the context to know whether these added metrics are useful. ---

[GitHub] storm pull request #2840: STORM-3147: Add metrics based on ClusterSummary

2018-09-17 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2840 STORM-3147: Add metrics based on ClusterSummary Rebase and update of https://github.com/apache/storm/pull/2764. @zd-project Please take a look when you have a chance. You can merge this pull

[GitHub] storm issue #2836: STORM-3162: Cleanup heartbeats cache and make it thread s...

2018-09-17 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2836 Looks good, thanks. +1 ---

[GitHub] storm pull request #2836: STORM-3162: Cleanup heartbeats cache and make it t...

2018-09-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2836#discussion_r218177587 --- Diff: storm-server/pom.xml --- @@ -171,7 +171,7 @@ maven-checkstyle-plugin

[GitHub] storm issue #2805: STORM-3197: Make StormMetricsRegistry non-static

2018-09-17 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2805 Test failure looks unrelated, it's getting a permission error when writing to the local maven repo. ---

[GitHub] storm pull request #2805: STORM-3197: Make StormMetricsRegistry non-static

2018-09-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2805#discussion_r218150464 --- Diff: storm-server/src/main/java/org/apache/storm/LocalDRPC.java --- @@ -38,9 +39,9 @@ private final DRPC drpc; private final String

[GitHub] storm pull request #2805: STORM-3197: Make StormMetricsRegistry non-static

2018-09-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2805#discussion_r218148492 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Container.java --- @@ -219,11 +201,11 @@ public void kill() throws IOException

[GitHub] storm pull request #2836: STORM-3162: Cleanup heartbeats cache and make it t...

2018-09-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2836#discussion_r218142320 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/HeartbeatCache.java --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software

[GitHub] storm pull request #2836: STORM-3162: Cleanup heartbeats cache and make it t...

2018-09-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2836#discussion_r218121407 --- Diff: storm-server/pom.xml --- @@ -171,7 +171,7 @@ maven-checkstyle-plugin

[GitHub] storm pull request #2836: STORM-3162: Cleanup heartbeats cache and make it t...

2018-09-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2836#discussion_r217911368 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/HeartbeatCache.java --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software

[GitHub] storm pull request #2836: STORM-3162: Cleanup heartbeats cache and make it t...

2018-09-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2836#discussion_r217911059 --- Diff: storm-client/src/jvm/org/apache/storm/stats/ClientStatsUtil.java --- @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #2836: STORM-3162: Cleanup heartbeats cache and make it t...

2018-09-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2836#discussion_r218140315 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/HeartbeatCache.java --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software

[GitHub] storm pull request #2836: STORM-3162: Cleanup heartbeats cache and make it t...

2018-09-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2836#discussion_r218124022 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/HeartbeatCache.java --- @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software

[GitHub] storm pull request #2836: STORM-3162: Cleanup heartbeats cache and make it t...

2018-09-17 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2836#discussion_r218140867 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java --- @@ -4624,7 +4569,7 @@ public boolean isRemoteBlobExists(String blobKey

[GitHub] storm-site pull request #7: Add XenonStack to powered-by

2018-09-16 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm-site/pull/7 Add XenonStack to powered-by You can merge this pull request into a Git repository by running: $ git pull https://github.com/srdo/storm-site add-xenonstack Alternatively you can review

[GitHub] storm pull request #2837: Remove powered-by.md, it lives in the storm-site r...

2018-09-16 Thread srdo
GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2837 Remove powered-by.md, it lives in the storm-site repository now Copied off the mailing list post: We have a powered-by.md file in the Storm repository's /docs directory. There's also

[GitHub] storm issue #2829: STORM-3222: Fix KafkaSpout internals to use LinkedList in...

2018-09-16 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2829 Even if we change the spout to emit all the fetched records in one `nextTuple` call, the number and size of records returned in a fetch is limited by the `max.poll.records` KafkaConsumer setting (500

[GitHub] storm issue #2789: STORM-3173: flush metrics to ScheduledReporter on shutdow...

2018-09-16 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2789 @zd-project I'm happy to take a look at implementing https://github.com/apache/storm/pull/2764 once the non-static PR is merged. I don't think it makes sense to mix more stuff into the current PR

storm git commit: STORM-3222: Fix KafkaSpout internals to use LinkedList instead of ArrayList

2018-09-15 Thread srdo
Repository: storm Updated Branches: refs/heads/1.1.x-branch 242ad03c9 -> 264243c34 STORM-3222: Fix KafkaSpout internals to use LinkedList instead of ArrayList KafkaSpout internally maintains a waitingToEmit list per topic partition and keeps removing the first item to emit during each

[1/2] storm git commit: STORM-3222: Fix KafkaSpout internals to use LinkedList instead of ArrayList

2018-09-15 Thread srdo
Repository: storm Updated Branches: refs/heads/1.x-branch fe56cfc5a -> b230decc6 STORM-3222: Fix KafkaSpout internals to use LinkedList instead of ArrayList KafkaSpout internally maintains a waitingToEmit list per topic partition and keeps removing the first item to emit during each

[2/2] storm git commit: Merge branch 'STORM-3222-1.x' of https://github.com/arunmahadevan/storm into STORM-3222-1.x-merge

2018-09-15 Thread srdo
Merge branch 'STORM-3222-1.x' of https://github.com/arunmahadevan/storm into STORM-3222-1.x-merge Project: http://git-wip-us.apache.org/repos/asf/storm/repo Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/b230decc Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/b230decc

[GitHub] storm issue #2834: STORM-3226: Update error message to be more clear

2018-09-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2834 +1 ---

[GitHub] storm pull request #2834: STORM-3226: Update error message to be more clear

2018-09-15 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2834#discussion_r217882026 --- Diff: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -135,7 +135,7 @@ public Supervisor(Map conf, IContext

[GitHub] storm issue #2833: STORM-3225: Use MediaType for check

2018-09-15 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2833 +1 ---

[GitHub] storm pull request #2833: STORM-3225: Use MediaType for check

2018-09-15 Thread srdo
Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2833#discussion_r217882011 --- Diff: storm-webapp/src/main/java/org/apache/storm/daemon/ui/filters/AuthorizedUserFilter.java --- @@ -79,7 +80,7 @@ public static Response

[GitHub] storm issue #2829: STORM-3222: Fix KafkaSpout internals to use LinkedList in...

2018-09-13 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2829 @arunmahadevan I think the reason for only emitting one tuple at a time was to let Storm enforce the max.spout.pending limit. Maybe it would be better to accept some overflow in order to get the spout

<    1   2   3   4   5   6   7   8   9   10   >