Re: [PR] feat(c++,spark): support json payload file format [incubator-graphar]

2024-05-22 Thread via GitHub
acezen commented on code in PR #488: URL: https://github.com/apache/incubator-graphar/pull/488#discussion_r1609388219 ## testing@170/movies-directed.json: ## @@ -0,0 +1,8 @@ +{"name":"Lilly Wachowski","born":1967,"title":"The Matrix","tagline":"Welcome to the Real

[PR] [chore](regression) Modify character encoding to be consistent with Doris [doris]

2024-05-22 Thread via GitHub
zgxme opened a new pull request, #35193: URL: https://github.com/apache/doris/pull/35193 Modify character encoding to be consistent with Doris, otherwise the query results may not be as expected ## Proposed changes Issue Number: close #xxx ## Further comments

Re: [PR] [Feature][ui][backend] Cdc Action job submit. [paimon-webui]

2024-05-22 Thread via GitHub
SteNicholas closed pull request #235: [Feature][ui][backend] Cdc Action job submit. URL: https://github.com/apache/paimon-webui/pull/235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [ISSUE #274]: fix startup exception [rocketmq-mqtt]

2024-05-22 Thread via GitHub
YxAc commented on PR #276: URL: https://github.com/apache/rocketmq-mqtt/pull/276#issuecomment-2124007685 hi @yx9o , can you cherry pick #265 to fix the compilation error and keep consistency with the main branch, thx. -- This is an automated message from the Apache Git Service. To

Re: [PR] [chore](regression) Modify character encoding to be consistent with Doris [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35193: URL: https://github.com/apache/doris/pull/35193#issuecomment-2124007261 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

Re: [PR] [fix](Nereids): add project for joinreorder [doris]

2024-05-22 Thread via GitHub
morrySnow merged PR #34993: URL: https://github.com/apache/doris/pull/34993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Bug when deleting nested properties in Adapter

2024-05-22 Thread via GitHub
tenthe closed issue #2886: Bug when deleting nested properties in Adapter URL: https://github.com/apache/streampipes/issues/2886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] fix(#2886): Fix the deletion of nested properties in connect

2024-05-22 Thread via GitHub
tenthe merged PR #2889: URL: https://github.com/apache/streampipes/pull/2889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump com.google.apis:google-api-services-drive from v3-rev20240327-2.0.0 to v3-rev20240509-2.0.0 [camel]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #14218: URL: https://github.com/apache/camel/pull/14218#issuecomment-2124005817 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel

[PR] Bump com.google.apis:google-api-services-drive from v3-rev20240327-2.0.0 to v3-rev20240509-2.0.0 [camel]

2024-05-22 Thread via GitHub
dependabot[bot] opened a new pull request, #14218: URL: https://github.com/apache/camel/pull/14218 Bumps com.google.apis:google-api-services-drive from v3-rev20240327-2.0.0 to v3-rev20240509-2.0.0. [![Dependabot compatibility

Re: [PR] [MINOR] fix(docs): Update outdated config: rss.writer.send.check.timeout -> rss.client.send.check.timeout.ms [incubator-uniffle]

2024-05-22 Thread via GitHub
zuston commented on PR #1734: URL: https://github.com/apache/incubator-uniffle/pull/1734#issuecomment-2124005488 Thanks. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [ISSUE #166] fix concurrency for message property string [rocketmq-client-go]

2024-05-22 Thread via GitHub
absolute8511 opened a new pull request, #1141: URL: https://github.com/apache/rocketmq-client-go/pull/1141 ## What is the purpose of the change fix #166 ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate

Re: [PR] [MINOR] fix(docs): Update outdated config: rss.writer.send.check.timeout -> rss.client.send.check.timeout.ms [incubator-uniffle]

2024-05-22 Thread via GitHub
zuston merged PR #1734: URL: https://github.com/apache/incubator-uniffle/pull/1734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [CH] Make shuffle writer exit gracefully when tasks in executors are killed [incubator-gluten]

2024-05-22 Thread via GitHub
taiyang-li commented on issue #5823: URL: https://github.com/apache/incubator-gluten/issues/5823#issuecomment-2124003903 问题原因: 1. spark推测执行时,当前task由于"another attempt succeeded"而被driver kill ``` 2024/05/22 14:33:47.244 INFO [dispatcher-Executor] spark.executor.Executor:

Re: [I] unable to run Gluten compiled with AOOC derived from clang16 [incubator-gluten]

2024-05-22 Thread via GitHub
Manoj-red-hat commented on issue #5831: URL: https://github.com/apache/incubator-gluten/issues/5831#issuecomment-2124004389 > Intel Gluten team doesn't use clang and none of our customers required it. Not sure anyone in community has tried. > Ok i will do some more

Re: [PR] [fix](Nereids): add project for joinreorder [doris]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #34993: URL: https://github.com/apache/doris/pull/34993#issuecomment-2124004376 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Implement BoundPredicateVisitor trait for ManifestFilterVisitor [iceberg-rust]

2024-05-22 Thread via GitHub
sdd commented on code in PR #367: URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1609384502 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_> { reference: ,

Re: [PR] Bump com.google.api-client:google-api-client from 2.5.0 to 2.5.1 [camel]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #14217: URL: https://github.com/apache/camel/pull/14217#issuecomment-2124003217 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel

Re: [I] Row limit hardcoded at 100 000 in the UI [superset]

2024-05-22 Thread via GitHub
mujohiddin commented on issue #26779: URL: https://github.com/apache/superset/issues/26779#issuecomment-2124003074 Hello there. my project is last year september october version but i have row limit not working how to fix it. @mistercrunch @villebro @michael-s-molina @betodealmeida

[PR] Bump com.google.api-client:google-api-client from 2.5.0 to 2.5.1 [camel]

2024-05-22 Thread via GitHub
dependabot[bot] opened a new pull request, #14217: URL: https://github.com/apache/camel/pull/14217 Bumps [com.google.api-client:google-api-client](https://github.com/googleapis/google-api-java-client) from 2.5.0 to 2.5.1. Release notes Sourced from

[PR] Pipe: Fixed the bug that the newly added PipeSetTTLPlan is not handled correctly [iotdb]

2024-05-22 Thread via GitHub
Caideyipi opened a new pull request, #12571: URL: https://github.com/apache/iotdb/pull/12571 ## Description As the title said. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

Re: [PR] Bump opensearch-rest-client-version from 2.13.0 to 2.14.0 [camel]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #14216: URL: https://github.com/apache/camel/pull/14216#issuecomment-2124002319 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel

Re: [PR] Implement BoundPredicateVisitor trait for ManifestFilterVisitor [iceberg-rust]

2024-05-22 Thread via GitHub
sdd commented on code in PR #367: URL: https://github.com/apache/iceberg-rust/pull/367#discussion_r1609384502 ## crates/iceberg/src/expr/visitors/manifest_evaluator.rs: ## @@ -103,98 +106,245 @@ impl BoundPredicateVisitor for ManifestFilterVisitor<'_> { reference: ,

[PR] Bump opensearch-rest-client-version from 2.13.0 to 2.14.0 [camel]

2024-05-22 Thread via GitHub
dependabot[bot] opened a new pull request, #14216: URL: https://github.com/apache/camel/pull/14216 Bumps `opensearch-rest-client-version` from 2.13.0 to 2.14.0. Updates `org.opensearch.client:opensearch-rest-client` from 2.13.0 to 2.14.0 Release notes Sourced from

Re: [PR] [#1579][part-1] fix(spark): Adjust reassigned time to ensure that all previous data is cleared for stage retry [incubator-uniffle]

2024-05-22 Thread via GitHub
zuston commented on code in PR #1584: URL: https://github.com/apache/incubator-uniffle/pull/1584#discussion_r1609376374 ## client-spark/common/src/main/java/org/apache/spark/shuffle/handle/MutableShuffleHandleInfo.java: ## @@ -201,42 +201,40 @@ public void

Re: [I] Angular run time error of superset-embedded-sdk [superset]

2024-05-22 Thread via GitHub
arnold-keyvalue commented on issue #28546: URL: https://github.com/apache/superset/issues/28546#issuecomment-2124001942 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] unable to run Gluten compiled with AOOC derived from clang16 [incubator-gluten]

2024-05-22 Thread via GitHub
FelixYBW commented on issue #5831: URL: https://github.com/apache/incubator-gluten/issues/5831#issuecomment-2124000462 > > official we don't support clang , am I right ? Intel Gluten team doesn't use clang and none of our customers required it. Not sure anyone in community has

[PR] misc: add comment about remove unused code [airflow]

2024-05-22 Thread via GitHub
eladkal opened a new pull request, #39748: URL: https://github.com/apache/airflow/pull/39748 https://github.com/apache/airflow/pull/39212 is planned for 2.9.2 so adding a note when we need to remove the unused code. -- This is an automated message from the Apache Git Service. To respond

[PR] Bump redis.clients:jedis from 5.1.2 to 5.1.3 [camel]

2024-05-22 Thread via GitHub
dependabot[bot] opened a new pull request, #14215: URL: https://github.com/apache/camel/pull/14215 Bumps [redis.clients:jedis](https://github.com/redis/jedis) from 5.1.2 to 5.1.3. Release notes Sourced from https://github.com/redis/jedis/releases;>redis.clients:jedis's releases.

Re: [PR] Bump aws-java-sdk2-version from 2.25.56 to 2.25.57 [camel]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #14214: URL: https://github.com/apache/camel/pull/14214#issuecomment-2123998720 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel

Re: [PR] Bump redis.clients:jedis from 5.1.2 to 5.1.3 [camel]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #14215: URL: https://github.com/apache/camel/pull/14215#issuecomment-2123999535 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel

[PR] Bump aws-java-sdk2-version from 2.25.56 to 2.25.57 [camel]

2024-05-22 Thread via GitHub
dependabot[bot] opened a new pull request, #14214: URL: https://github.com/apache/camel/pull/14214 Bumps `aws-java-sdk2-version` from 2.25.56 to 2.25.57. Updates `software.amazon.awssdk:sqs` from 2.25.56 to 2.25.57 Updates `software.amazon.awssdk:kinesis` from 2.25.56 to 2.25.57

Re: [PR] Handle multiple Set-Cookie headers in replicator session plugin [couchdb]

2024-05-22 Thread via GitHub
rnewson commented on code in PR #5066: URL: https://github.com/apache/couchdb/pull/5066#discussion_r1609381337 ## src/couch_replicator/src/couch_replicator_auth_session.erl: ## @@ -386,23 +386,50 @@ http_response({error, Error}, #state{session_url = Url, user = User}) ->

[I] [Bug] Dont partial old field to null when the field value is null for sequence-group [paimon]

2024-05-22 Thread via GitHub
FangYongs opened a new issue, #3373: URL: https://github.com/apache/paimon/issues/3373 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/paimon/issues) and found nothing similar. ### Paimon version When the new field value is null

[PR] Enable branch protection for branch asf-site [couchdb-www]

2024-05-22 Thread via GitHub
big-r81 opened a new pull request, #69: URL: https://github.com/apache/couchdb-www/pull/69 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [YUNIKORN-2625] Refactor Clients to avoid hard-code checks [yunikorn-k8shim]

2024-05-22 Thread via GitHub
wilfred-s commented on code in PR #844: URL: https://github.com/apache/yunikorn-k8shim/pull/844#discussion_r1609379727 ## pkg/client/clients.go: ## @@ -27,13 +27,19 @@ import ( coreInformerV1 "k8s.io/client-go/informers/core/v1" schedulingInformerV1

[PR] Remove de-funfried-netbeans-plugins-externalcodeformatter from VSNetBeans [netbeans]

2024-05-22 Thread via GitHub
thurka opened a new pull request, #7392: URL: https://github.com/apache/netbeans/pull/7392 do not include de-funfried-netbeans-plugins-externalcodeformatter module in default VSNetBeans build Closes #7329 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [YUNIKORN-2625] Refactor Clients to avoid hard-code checks [yunikorn-k8shim]

2024-05-22 Thread via GitHub
wilfred-s commented on code in PR #844: URL: https://github.com/apache/yunikorn-k8shim/pull/844#discussion_r1609379727 ## pkg/client/clients.go: ## @@ -27,13 +27,19 @@ import ( coreInformerV1 "k8s.io/client-go/informers/core/v1" schedulingInformerV1

Re: [PR] fix: #473 Resolved the issue of using C++17's nested namespaces [incubator-graphar]

2024-05-22 Thread via GitHub
acezen commented on PR #489: URL: https://github.com/apache/incubator-graphar/pull/489#issuecomment-2123995398 Hi @ywh555hhh, thanks for the work, the CI indicate that the code format check is failed. Please follow the

Re: [PR] DRAFT: Parquet 3 metadata with decoupled column metadata [parquet-format]

2024-05-22 Thread via GitHub
ggershinsky commented on code in PR #242: URL: https://github.com/apache/parquet-format/pull/242#discussion_r1609323577 ## README.md: ## @@ -107,12 +113,97 @@ start locations. More details on what is contained in the metadata can be found in the Thrift definition.

Re: [I] [Bug] parseMessageMetadata error when broker entry metadata enable with high loading [pulsar]

2024-05-22 Thread via GitHub
eolivelli commented on issue #22601: URL: https://github.com/apache/pulsar/issues/22601#issuecomment-2123993443 This is a great finding -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [Feature] Complete the job result page [paimon-webui]

2024-05-22 Thread via GitHub
s7monk commented on code in PR #232: URL: https://github.com/apache/paimon-webui/pull/232#discussion_r1609378108 ## paimon-web-ui/package.json: ## @@ -18,6 +18,9 @@ "@antv/x6": "^2.15.3", "@antv/x6-plugin-dnd": "^2.1.1", "@antv/x6-vue-shape": "^2.1.1", +

Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-05-22 Thread via GitHub
weizhouapache commented on code in PR #8875: URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1609378387 ## engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java: ## @@ -1041,6 +1042,8 @@ public Pair, Integer> listByVmsNotInClusterUsingPool(long

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-05-22 Thread via GitHub
sdd commented on code in PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#discussion_r1609377510 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,438 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] DRAFT: Parquet 3 metadata with decoupled column metadata [parquet-format]

2024-05-22 Thread via GitHub
ggershinsky commented on code in PR #242: URL: https://github.com/apache/parquet-format/pull/242#discussion_r1609368695 ## src/main/thrift/parquet.thrift: ## @@ -1165,6 +1317,62 @@ struct FileMetaData { 9: optional binary footer_signing_key_metadata } +/** Metadata for a

Re: [I] [Bug] 查询结果每次返回的都不一样 [doris]

2024-05-22 Thread via GitHub
McClone commented on issue #35190: URL: https://github.com/apache/doris/issues/35190#issuecomment-2123991475 两个表都是聚合模型,也不是文档里里面说的主键模型 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [MINOR][TESTS] Replace JVM assert with JUnit Assert in tests [spark]

2024-05-22 Thread via GitHub
panbingkun commented on PR #46698: URL: https://github.com/apache/spark/pull/46698#issuecomment-2123992120 This PR reference: https://github.com/apache/spark/commit/1febd373ea806326d269a60048ee52543a76c918 https://github.com/apache/spark/pull/37772 -- This is an automated message

Re: [PR] HDDS-10435. Support S3 object tags for existing requests [ozone]

2024-05-22 Thread via GitHub
adoroszlai commented on PR #6607: URL: https://github.com/apache/ozone/pull/6607#issuecomment-2123990311 Thanks @ivandika3 for the patch, @guohao-rosicky, @kerneltime, @SaketaChalamchala, @vtutrinov for the review. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] DRAFT: Parquet 3 metadata with decoupled column metadata [parquet-format]

2024-05-22 Thread via GitHub
etseidl commented on code in PR #242: URL: https://github.com/apache/parquet-format/pull/242#discussion_r1609375135 ## src/main/thrift/parquet.thrift: ## @@ -1165,6 +1317,62 @@ struct FileMetaData { 9: optional binary footer_signing_key_metadata } +/** Metadata for a

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-05-22 Thread via GitHub
sdd commented on code in PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#discussion_r1609375064 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,438 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [I] Suggested PRs to merge for 1.3.1 [couchdb-fauxton]

2024-05-22 Thread via GitHub
big-r81 closed issue #1434: Suggested PRs to merge for 1.3.1 URL: https://github.com/apache/couchdb-fauxton/issues/1434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Update](clucene) update clucene 2.0 commit version [doris]

2024-05-22 Thread via GitHub
airborne12 commented on PR #35192: URL: https://github.com/apache/doris/pull/35192#issuecomment-2123989742 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [test](case) Remove sensitive information in k8s deploy test [doris]

2024-05-22 Thread via GitHub
yongjinhou commented on PR #35185: URL: https://github.com/apache/doris/pull/35185#issuecomment-2123989631 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] feat: add basic auth [incubator-horaedb-client-java]

2024-05-22 Thread via GitHub
jiacai2050 merged PR #78: URL: https://github.com/apache/incubator-horaedb-client-java/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDDS-10435. Support S3 object tags for existing requests [ozone]

2024-05-22 Thread via GitHub
adoroszlai merged PR #6607: URL: https://github.com/apache/ozone/pull/6607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Update](clucene) update clucene 2.0 commit version [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35192: URL: https://github.com/apache/doris/pull/35192#issuecomment-2123989373 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

Re: [PR] [#1675][FOLLOWUP] fix(test): Fix various flaky tests [incubator-uniffle]

2024-05-22 Thread via GitHub
jerqi commented on code in PR #1730: URL: https://github.com/apache/incubator-uniffle/pull/1730#discussion_r1609374250 ## pom.xml: ## @@ -921,6 +921,7 @@ ${project.build.directory}/tmp ${project.version} target/jacoco.exec +

[PR] [MINOR][TESTS] Replace JVM assert with JUnit Assert in tests [spark]

2024-05-22 Thread via GitHub
panbingkun opened a new pull request, #46698: URL: https://github.com/apache/spark/pull/46698 ### What changes were proposed in this pull request? The pr aims to replace `JVM assert` with `JUnit Assert` in tests. ### Why are the changes needed? assert() statements do not

[PR] [Update](clucene) update clucene 2.0 commit version [doris]

2024-05-22 Thread via GitHub
airborne12 opened a new pull request, #35192: URL: https://github.com/apache/doris/pull/35192 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at

Re: [PR] [BugFix](Replica) fix bug that replica remote data size set to data size [doris]

2024-05-22 Thread via GitHub
GoGoWen commented on PR #35097: URL: https://github.com/apache/doris/pull/35097#issuecomment-2123989128 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [#1675][FOLLOWUP] fix(test): Fix various flaky tests [incubator-uniffle]

2024-05-22 Thread via GitHub
jerqi commented on code in PR #1730: URL: https://github.com/apache/incubator-uniffle/pull/1730#discussion_r1609374250 ## pom.xml: ## @@ -921,6 +921,7 @@ ${project.build.directory}/tmp ${project.version} target/jacoco.exec +

Re: [PR] days_diff should match datetimev2 function sigature in higher priority [doris]

2024-05-22 Thread via GitHub
starocean999 commented on PR #35191: URL: https://github.com/apache/doris/pull/35191#issuecomment-2123988978 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [VL] Enable local sort-based shuffle [incubator-gluten]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #5811: URL: https://github.com/apache/incubator-gluten/pull/5811#issuecomment-2123988938 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] days_diff should match datetimev2 function sigature in higher priority [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35191: URL: https://github.com/apache/doris/pull/35191#issuecomment-2123988877 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

[PR] days_diff should match datetimev2 function sigature in higher priority [doris]

2024-05-22 Thread via GitHub
starocean999 opened a new pull request, #35191: URL: https://github.com/apache/doris/pull/35191 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at

Re: [PR] [feat](nereids)push Limit to local agg [doris]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #34853: URL: https://github.com/apache/doris/pull/34853#issuecomment-2123988524 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[I] [Bug] 查询结果每次返回的都不一样 [doris]

2024-05-22 Thread via GitHub
McClone opened a new issue, #35190: URL: https://github.com/apache/doris/issues/35190 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 2.0.8 ### What's

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-05-22 Thread via GitHub
sdd commented on code in PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#discussion_r1609372918 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,438 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [I] [Bug] Some lines in the line chart disappear progressively [echarts]

2024-05-22 Thread via GitHub
jgoncab-arte commented on issue #19958: URL: https://github.com/apache/echarts/issues/19958#issuecomment-2123987405 Yes, I could see the change with `showSymbol: false` but I wanted to use the tooltip and it doesn't work properly without the symbols (similar to this

Re: [PR] fix: #473 Resolved the issue of using C++17's nested namespaces [incubator-graphar]

2024-05-22 Thread via GitHub
ywh555hhh commented on PR #489: URL: https://github.com/apache/incubator-graphar/pull/489#issuecomment-2123987255 I seem to be ignoring some of the call logic for nested namespaces and I'll fix it myself -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] feat: Add equality delete writer [iceberg-rust]

2024-05-22 Thread via GitHub
sdd commented on code in PR #372: URL: https://github.com/apache/iceberg-rust/pull/372#discussion_r1609372170 ## crates/iceberg/src/writer/base_writer/equality_delete_writer.rs: ## @@ -0,0 +1,438 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

Re: [PR] [fix](multi-catalog)put java udf to custom lib [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #34990: URL: https://github.com/apache/doris/pull/34990#issuecomment-2123985149 ClickBench: Total hot run time: 30.89 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [I] property "type" must be provided when reading from the Broker [camel-k]

2024-05-22 Thread via GitHub
matzew commented on issue #5529: URL: https://github.com/apache/camel-k/issues/5529#issuecomment-2123984946 I think this is two pieces: * Why is `type` required? It is perfectly valid to have a Trigger w/out any attributes on the filter (this bug) * when I have it not correct, why

Re: [PR] [Bugfix] Fix mv column type is not changed when do schema change [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #34598: URL: https://github.com/apache/doris/pull/34598#issuecomment-2123984242 ClickBench: Total hot run time: 30.31 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] Bump ejs and nightwatch [couchdb-fauxton]

2024-05-22 Thread via GitHub
big-r81 merged PR #1437: URL: https://github.com/apache/couchdb-fauxton/pull/1437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [MNG-7902] Sort plugins in the validation report [maven]

2024-05-22 Thread via GitHub
gnodet commented on code in PR #1510: URL: https://github.com/apache/maven/pull/1510#discussion_r1609369940 ## maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java: ## @@ -23,17 +23,7 @@ import java.nio.file.Path; import

Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-05-22 Thread via GitHub
abh1sar commented on code in PR #8875: URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1609368832 ## engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java: ## @@ -1041,6 +1042,8 @@ public Pair, Integer> listByVmsNotInClusterUsingPool(long clu

Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-05-22 Thread via GitHub
abh1sar commented on code in PR #8875: URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1609368832 ## engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java: ## @@ -1041,6 +1042,8 @@ public Pair, Integer> listByVmsNotInClusterUsingPool(long clu

Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-05-22 Thread via GitHub
abh1sar commented on code in PR #8875: URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1609368832 ## engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java: ## @@ -1041,6 +1042,8 @@ public Pair, Integer> listByVmsNotInClusterUsingPool(long clu

Re: [PR] Concurrent table scans [iceberg-rust]

2024-05-22 Thread via GitHub
sdd commented on code in PR #373: URL: https://github.com/apache/iceberg-rust/pull/373#discussion_r1609368600 ## crates/iceberg/src/scan.rs: ## @@ -189,66 +195,20 @@ impl TableScan { self.case_sensitive, )?; -let mut partition_filter_cache =

Re: [PR] [GLUTEN-5771][VL] Add metrics for ColumnarArrowEvalPythonExec [incubator-gluten]

2024-05-22 Thread via GitHub
zhztheplayer commented on code in PR #5772: URL: https://github.com/apache/incubator-gluten/pull/5772#discussion_r1609368533 ## gluten-data/src/main/java/org/apache/gluten/vectorized/ArrowWritableColumnVector.java: ## @@ -345,6 +345,10 @@ public void retain() {

Re: [PR] Spark 3.5: Add validation to SparkConfParser [iceberg]

2024-05-22 Thread via GitHub
jerqi commented on code in PR #10315: URL: https://github.com/apache/iceberg/pull/10315#discussion_r1609368411 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java: ## @@ -264,7 +261,26 @@ public ThisT tableProperty(String name) { return

Re: [I] unable to run Gluten compiled with AOOC derived from clang16 [incubator-gluten]

2024-05-22 Thread via GitHub
FelixYBW commented on issue #5831: URL: https://github.com/apache/incubator-gluten/issues/5831#issuecomment-2123981110 I'm not sure. We never tried clang16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]

2024-05-22 Thread via GitHub
Gabriel39 commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2123980681 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](jdbc catalog) fix jdbc catalog doc for query tvf and create example [doris-website]

2024-05-22 Thread via GitHub
zy-kkk merged PR #677: URL: https://github.com/apache/doris-website/pull/677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Remove GH action trigger on pull requests [couchdb-fauxton]

2024-05-22 Thread via GitHub
big-r81 opened a new pull request, #1438: URL: https://github.com/apache/couchdb-fauxton/pull/1438 Currently, creating a pr will trigger to run the gh action twice. Remove trigger `pull_request` to run only once. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] TEZ-4566: NPE in TezChild while fetching attemptId when container is asked to shut down [tez]

2024-05-22 Thread via GitHub
ayushtkn merged PR #358: URL: https://github.com/apache/tez/pull/358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org

Re: [PR] Add contract first development section in rest-openapi doc [camel-quarkus]

2024-05-22 Thread via GitHub
jamesnetherton commented on code in PR #6115: URL: https://github.com/apache/camel-quarkus/pull/6115#discussion_r1609364243 ## extensions/rest-openapi/runtime/src/main/doc/usage.adoc: ## @@ -24,4 +24,55 @@ When using the `classpath` resource locator with native code, the path

Re: [PR] [feat](nereids)print physical plan in profile [doris]

2024-05-22 Thread via GitHub
englefly merged PR #35144: URL: https://github.com/apache/doris/pull/35144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Spark 3.5: Add validation to SparkConfParser [iceberg]

2024-05-22 Thread via GitHub
jerqi commented on code in PR #10315: URL: https://github.com/apache/iceberg/pull/10315#discussion_r1609365261 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java: ## @@ -233,19 +229,20 @@ public EnumConfParser defaultValue(String value) { }

Re: [PR] [fix](multi-catalog)put java udf to custom lib [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #34990: URL: https://github.com/apache/doris/pull/34990#issuecomment-2123977165 TPC-DS: Total hot run time: 182528 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [I] [Bug] Delayed message delivery receive duplicate messages when unload topic [pulsar]

2024-05-22 Thread via GitHub
SennoYuki commented on issue #20099: URL: https://github.com/apache/pulsar/issues/20099#issuecomment-2123977155 @dao-jun I tried but it did not solve the promblem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Spark 3.5: Add validation to SparkConfParser [iceberg]

2024-05-22 Thread via GitHub
jerqi commented on code in PR #10315: URL: https://github.com/apache/iceberg/pull/10315#discussion_r1609365261 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java: ## @@ -233,19 +229,20 @@ public EnumConfParser defaultValue(String value) { }

Re: [PR] [fix](Nereids) DatetimeV2 round floor was incorrectly implemented as round ceil [doris]

2024-05-22 Thread via GitHub
morrySnow commented on PR #35153: URL: https://github.com/apache/doris/pull/35153#issuecomment-2123976547 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Bugfix] Fix mv column type is not changed when do schema change [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #34598: URL: https://github.com/apache/doris/pull/34598#issuecomment-2123976355 TPC-DS: Total hot run time: 181436 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] KAFKA-15541: Add num-open-iterators metric [kafka]

2024-05-22 Thread via GitHub
mjsax commented on PR #15975: URL: https://github.com/apache/kafka/pull/15975#issuecomment-2123976338 Merged to `trunk` to make progress on the implementation of the KIP. About testing: I agree that we might not need to test every method which creates an iterator, but it would be

Re: [PR] [GLUTEN-5771][VL] Add metrics for ColumnarArrowEvalPythonExec [incubator-gluten]

2024-05-22 Thread via GitHub
yma11 commented on PR #5772: URL: https://github.com/apache/incubator-gluten/pull/5772#issuecomment-2123975179 @zhztheplayer Please help take a look again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [GLUTEN-5771][VL] Add metrics for ColumnarArrowEvalPythonExec [incubator-gluten]

2024-05-22 Thread via GitHub
yma11 commented on code in PR #5772: URL: https://github.com/apache/incubator-gluten/pull/5772#discussion_r1609363520 ## docs/developers/VeloxUDF.md: ## @@ -179,3 +179,48 @@ The output from spark-shell will be like +--++ ``` +# Pandas UDFs

Re: [PR] feat: make file scan task serializable [iceberg-rust]

2024-05-22 Thread via GitHub
ZENOTME commented on PR #377: URL: https://github.com/apache/iceberg-rust/pull/377#issuecomment-2123974633 > This seems reasonable, but perhaps we might want to consider having this as a separate method to the existing `plan_files` though so that anyone who is using the existing stream of

Re: [PR] GH-41730: [Java] Adding variadicBufferCounts to RecordBatch [arrow]

2024-05-22 Thread via GitHub
vibhatha commented on code in PR #41732: URL: https://github.com/apache/arrow/pull/41732#discussion_r1609359765 ## java/vector/src/main/java/org/apache/arrow/vector/VectorUnloader.java: ## @@ -80,19 +80,30 @@ public VectorUnloader( public ArrowRecordBatch getRecordBatch() {

<    1   2   3   4   5   6   7   8   9   10   >