Re: [PR] [regression-test](flink-connector) add flink connector data type case [doris]

2024-05-22 Thread via GitHub
924060929 commented on PR #35219: URL: https://github.com/apache/doris/pull/35219#issuecomment-2124450365 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [#1608][part-8] feat(spark3): add a limit to the number of retries when block access is denied [incubator-uniffle]

2024-05-22 Thread via GitHub
dingshun3016 closed pull request #1715: [#1608][part-8] feat(spark3): add a limit to the number of retries when block access is denied URL: https://github.com/apache/incubator-uniffle/pull/1715 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] add catalog as part of the table path in plan_to_sql [datafusion]

2024-05-22 Thread via GitHub
alamb commented on code in PR #10612: URL: https://github.com/apache/datafusion/pull/10612#discussion_r1609707420 ## datafusion/sql/src/unparser/plan.rs: ## @@ -502,3 +505,35 @@ impl From for DataFusionError { DataFusionError::External(Box::new(e)) } } +

[PR] [ISSUE #8177]optimising update topic from name serve [rocketmq]

2024-05-22 Thread via GitHub
weihubeats opened a new pull request, #8180: URL: https://github.com/apache/rocketmq/pull/8180 https://github.com/apache/rocketmq/issues/8177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
shwstppr commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2124448826 @weizhouapache unless I'm missing the point, even if we decide on wrapping nic.getInstanceId() in a try-catch for NPE it would still need changes in many more places -- This is an

Re: [I] [Bug] An error 'The query did not generate a result set' is reported when Hive Engine executeQuery INSERT OVERWRITE DIRECTORY [kyuubi]

2024-05-22 Thread via GitHub
pan3793 commented on issue #6406: URL: https://github.com/apache/kyuubi/issues/6406#issuecomment-2124447356 What's Hive runtime version? Any specific configurations? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [improve] [broker] apply topK machanism to ModularLoadManagerImpl. [pulsar]

2024-05-22 Thread via GitHub
codecov-commenter commented on PR #22753: URL: https://github.com/apache/pulsar/pull/22753#issuecomment-2124447255 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22753?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35204: URL: https://github.com/apache/doris/pull/35204#issuecomment-2124447965 ClickBench: Total hot run time: 30.3 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](index) should not use light index change for bloom filter index [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35214: URL: https://github.com/apache/doris/pull/35214#issuecomment-2124446751 TPC-DS: Total hot run time: 170468 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [SPARK-48340][PYTHON] Support TimestampNTZ infer schema miss prefer_timestamp_ntz [spark]

2024-05-22 Thread via GitHub
AngersZh commented on PR #4: URL: https://github.com/apache/spark/pull/4#issuecomment-2124445916 > If `spark.sql.timestampType` is set to `TIMESTAMP_NTZ`, and nested Row contains, `datetime` instance, then it infers as `TimestampNTZType` after this change. Before this change,

[PR] [improvement](decimal) add test case of casting decimal to string [doris]

2024-05-22 Thread via GitHub
jacktengg opened a new pull request, #35222: URL: https://github.com/apache/doris/pull/35222 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at

Re: [PR] [improvement](decimal) add test case of casting decimal to string [doris]

2024-05-22 Thread via GitHub
jacktengg commented on PR #35222: URL: https://github.com/apache/doris/pull/35222#issuecomment-2124445954 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improvement](decimal) add test case of casting decimal to string [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35222: URL: https://github.com/apache/doris/pull/35222#issuecomment-2124445780 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

Re: [PR] IGNITE-19103: Sql. Change implicit primary key column's type to UUID. [ignite-3]

2024-05-22 Thread via GitHub
lowka commented on code in PR #3786: URL: https://github.com/apache/ignite-3/pull/3786#discussion_r1609705200 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/IgniteMethod.java: ## @@ -98,17 +98,13 @@ public enum IgniteMethod {

Re: [PR] KAFKA-16223: Replace EasyMock/PowerMock with Mockito for KafkaConfigBackingStoreTest [kafka]

2024-05-22 Thread via GitHub
chia7712 commented on code in PR #15989: URL: https://github.com/apache/kafka/pull/15989#discussion_r1609683516 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaConfigBackingStoreMockitoTest.java: ## @@ -1184,6 +1185,140 @@ public void

Re: [PR] Use `IndexInput#prefetch` for terms dictionary lookups. [lucene]

2024-05-22 Thread via GitHub
mikemccand commented on code in PR #13359: URL: https://github.com/apache/lucene/pull/13359#discussion_r1609703874 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java: ## @@ -307,6 +309,30 @@ private boolean setEOF() { return true;

Re: [PR] GH-41307: [Java] Use org.apache:apache parent pom version 31 [arrow]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #41772: URL: https://github.com/apache/arrow/pull/41772#issuecomment-2124440882 Revision: a5c8d7d57699572aaefb87763de65eca6f0b20b9 Submitted crossbow builds: [ursacomputing/crossbow @

Re: [PR] [fix](Nereids) remove restrict for count(*) in window [doris]

2024-05-22 Thread via GitHub
morrySnow commented on PR #35220: URL: https://github.com/apache/doris/pull/35220#issuecomment-2124439808 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Extra parameter for UpdateImageStore [cloudstack]

2024-05-22 Thread via GitHub
blueorangutan commented on PR #8941: URL: https://github.com/apache/cloudstack/pull/8941#issuecomment-2124439443 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

[I] [Bug] Doris2.1.2 Sqlserver sysname 字段类型不支持 [doris]

2024-05-22 Thread via GitHub
shuxian6688 opened a new issue, #35221: URL: https://github.com/apache/doris/issues/35221 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version Doris 2.1.3

Re: [PR] [core] introduce deletedIndexFiles in IndexIncrement and allow multi … [paimon]

2024-05-22 Thread via GitHub
JingsongLi commented on code in PR #3368: URL: https://github.com/apache/paimon/pull/3368#discussion_r1609663405 ## paimon-core/src/main/java/org/apache/paimon/deletionvectors/DeletionVectorsIndexFile.java: ## @@ -48,18 +50,20 @@ public DeletionVectorsIndexFile(FileIO fileIO,

Re: [PR] Use `IndexInput#prefetch` for terms dictionary lookups. [lucene]

2024-05-22 Thread via GitHub
mikemccand commented on code in PR #13359: URL: https://github.com/apache/lucene/pull/13359#discussion_r1609702603 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java: ## @@ -307,6 +309,30 @@ private boolean setEOF() { return true;

Re: [PR] [fix](Nereids) remove restrict for count(*) in window [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35220: URL: https://github.com/apache/doris/pull/35220#issuecomment-2124438467 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

[PR] [fix](Nereids) remove restrict for count(*) in window [doris]

2024-05-22 Thread via GitHub
morrySnow opened a new pull request, #35220: URL: https://github.com/apache/doris/pull/35220 support count(*) used for window function CREATE TABLE `t1` ( `id` INT NULL, `dt` TEXT NULL ) DISTRIBUTED BY HASH(`id`) BUCKETS 10 PROPERTIES ( "replication_allocation" =

Re: [PR] Add support of the command JSON.DEBUG MEMORY [kvrocks]

2024-05-22 Thread via GitHub
sonarcloud[bot] commented on PR #2323: URL: https://github.com/apache/kvrocks/pull/2323#issuecomment-2124437999 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [#1608][part-8] feat(spark3): add a limit to the number of retries when block access is denied [incubator-uniffle]

2024-05-22 Thread via GitHub
dingshun3016 commented on PR #1715: URL: https://github.com/apache/incubator-uniffle/pull/1715#issuecomment-2124436961 > > > This looks strange that it replace the partial blockMaxRetryTimes abilities and introduces the extra config option to meet something, but this change is not

Re: [PR] Bump org.mockito:mockito-bom from 5.11.0 to 5.12.0 (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on PR #2575: URL: https://github.com/apache/logging-log4j2/pull/2575#issuecomment-2124435871 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [fix](fe) Fix drop frontend cause `bdbje` and `fe memory` inconsistent state [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35203: URL: https://github.com/apache/doris/pull/35203#issuecomment-2124435706 TPC-H: Total hot run time: 39799 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] Use `IndexInput#prefetch` for terms dictionary lookups. [lucene]

2024-05-22 Thread via GitHub
mikemccand commented on code in PR #13359: URL: https://github.com/apache/lucene/pull/13359#discussion_r1609700636 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java: ## @@ -307,6 +309,30 @@ private boolean setEOF() { return true;

Re: [PR] [MINOR] Fix missing xtable prefix to utilities-bundled.jar in docs [incubator-xtable]

2024-05-22 Thread via GitHub
daragu commented on PR #442: URL: https://github.com/apache/incubator-xtable/pull/442#issuecomment-2124435103 thanks @vinishjail97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] GlobalTransactionScanner 多例bean问题 [incubator-seata]

2024-05-22 Thread via GitHub
xingfudeshi commented on issue #6568: URL: https://github.com/apache/incubator-seata/issues/6568#issuecomment-2124434071 > In my opinion, this code is just to avoid duplicate proxies. @wangliang181230 , @slievrly , @xingfudeshi , please help to answer this question. You already

Re: [PR] Extra parameter for UpdateImageStore [cloudstack]

2024-05-22 Thread via GitHub
DaanHoogland commented on PR #8941: URL: https://github.com/apache/cloudstack/pull/8941#issuecomment-2124431658 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] GH-41307: [Java] Use org.apache:apache parent pom version 31 [arrow]

2024-05-22 Thread via GitHub
vibhatha commented on PR #41772: URL: https://github.com/apache/arrow/pull/41772#issuecomment-2124431639 @github-actions crossbow submit -g java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35204: URL: https://github.com/apache/doris/pull/35204#issuecomment-2124429589 TPC-DS: Total hot run time: 168264 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [regression-test](flink-connector) add flink connector data type case [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35219: URL: https://github.com/apache/doris/pull/35219#issuecomment-2124430254 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

[PR] [improve][cli]New tests for operations on namespaces in pulsar-client-tools [pulsar]

2024-05-22 Thread via GitHub
sandeep-mst opened a new pull request, #22761: URL: https://github.com/apache/pulsar/pull/22761 Fixes [21743](https://github.com/apache/pulsar/issues/21743) of apache/pulsar ### Motivation Pulsar client tools doesn't have tests for listing, deleting and creating

Re: [PR] [fix](index) should not use light index change for bloom filter index [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35214: URL: https://github.com/apache/doris/pull/35214#issuecomment-2124428680 TeamCity be ut coverage result: Function Coverage: 35.66% (9014/25279) Line Coverage: 27.30% (74511/272976) Region Coverage: 26.53% (38564/145375) Branch Coverage:

Re: [PR] [#1731] improvement(server): Bump gRPC from 1.63.0 to 1.64.0 [incubator-uniffle]

2024-05-22 Thread via GitHub
jerqi commented on PR #1732: URL: https://github.com/apache/incubator-uniffle/pull/1732#issuecomment-2124428011 > If you've already committed #1702 and #1704 to 0.9, then maybe you need to commit this as well. We don't commit them to branch 0.9. -- This is an automated message

[I] BP-67: Support skipping compaction at busy times [bookkeeper]

2024-05-22 Thread via GitHub
thetumbled opened a new issue, #4382: URL: https://github.com/apache/bookkeeper/issues/4382 BP This is the master ticket for tracking BP-67: This proposal describes changes to BookKeeper to support throttling for zookeeper read of rereplication. Proposal PR -

Re: [PR] [FLINK-20398][e2e] Migrate test_batch_sql.sh to Java e2e tests framework [flink]

2024-05-22 Thread via GitHub
affo commented on code in PR #24471: URL: https://github.com/apache/flink/pull/24471#discussion_r1609692387 ## flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software

Re: [PR] [feat](nereids)push Limit to local agg [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #34853: URL: https://github.com/apache/doris/pull/34853#issuecomment-2124422987 ClickBench: Total hot run time: 30.31 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] Cast timestamp issue [incubator-gluten]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #5843: URL: https://github.com/apache/incubator-gluten/pull/5843#issuecomment-2124422728 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [fix](move-memtable) clear load streams before shutdown SegmentFileWriterThreadPool [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35217: URL: https://github.com/apache/doris/pull/35217#issuecomment-2124422726 ClickBench: Total hot run time: 30.78 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [GLUTEN-5787][CH]Make shuffle writer exit gracefully when tasks in executors are killed [incubator-gluten]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #5839: URL: https://github.com/apache/incubator-gluten/pull/5839#issuecomment-2124421978 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] feat: Add eliminate group by constant optimizer rule [datafusion]

2024-05-22 Thread via GitHub
alamb merged PR #10591: URL: https://github.com/apache/datafusion/pull/10591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat: Add eliminate group by constant optimizer rule [datafusion]

2024-05-22 Thread via GitHub
alamb commented on PR #10591: URL: https://github.com/apache/datafusion/pull/10591#issuecomment-2124420659 Since this PR looks good and makes improvements I am going to merge it in. @korowa perhaps you can consider the feedback on

Re: [I] Azure CI pending [incubator-xtable]

2024-05-22 Thread via GitHub
daragu commented on issue #438: URL: https://github.com/apache/incubator-xtable/issues/438#issuecomment-2124420531 > @daragu There are some apache guidelines for using a azure CI pipeline, l will check more on this.  thanks @vinishjail97. But there is a limitation that forkers

[PR] bugfix values.yaml dns config [apisix-helm-chart]

2024-05-22 Thread via GitHub
hamishliu opened a new pull request, #757: URL: https://github.com/apache/apisix-helm-chart/pull/757 Fixed helm deployment package configuration error, the original dns configuration item does not take effect -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-20398][e2e] Migrate test_batch_sql.sh to Java e2e tests framework [flink]

2024-05-22 Thread via GitHub
affo commented on code in PR #24471: URL: https://github.com/apache/flink/pull/24471#discussion_r1609692387 ## flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software

Re: [PR] [#1698] fix(test): Increase tests running memory for better stability [incubator-uniffle]

2024-05-22 Thread via GitHub
jerqi commented on PR #1726: URL: https://github.com/apache/incubator-uniffle/pull/1726#issuecomment-2124416596 When you merge a pull request, you should say which branch is merged. like ``` merged to master & branch 0.9. ``` -- This is an automated message from the Apache Git

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1609690056 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,111 @@ = Markers -One of the primary purpose of a logging framework is to

Re: [PR] [#1698] fix(test): Increase tests running memory for better stability [incubator-uniffle]

2024-05-22 Thread via GitHub
jerqi commented on PR #1726: URL: https://github.com/apache/incubator-uniffle/pull/1726#issuecomment-2124415264 @zuston Have you committed this to branch 0.9? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] kie-issues#451: Implement autolayout on the new React-based DMN Editor for DMN files without Diagram information - Part 1 [incubator-kie-tools]

2024-05-22 Thread via GitHub
baldimir commented on PR #2341: URL: https://github.com/apache/incubator-kie-tools/pull/2341#issuecomment-2124414578 Hi, as discussed in the typeConstraint and allowedValues issue, I think the best would be to add clarifications in a hint (or the "i" icon). Similar approach should be

Re: [PR] rewrote Markers (logging-log4j2)

2024-05-22 Thread via GitHub
ppkarwasz commented on code in PR #2584: URL: https://github.com/apache/logging-log4j2/pull/2584#discussion_r1609689008 ## src/site/antora/modules/ROOT/pages/manual/markers.adoc: ## @@ -16,85 +16,115 @@ = Markers -One of the primary purpose of a logging framework is to

Re: [PR] HDDS-10890. [hsync] Increase default value for hdds.container.ratis.log.appender.queue.num-elements. [ozone]

2024-05-22 Thread via GitHub
ChenSammi commented on PR #6711: URL: https://github.com/apache/ozone/pull/6711#issuecomment-2124413231 The change looks good to me. It's quite interesting why it's 1 previously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[Github-comments] Re: [geany/geany-plugins] vimode: Handle folded lines correctly (PR #1338)

2024-05-22 Thread cresto sylvain via Github-comments
OK, it's works fine, thanks -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1338#issuecomment-2124413450 You are receiving this because you are subscribed to this thread. Message ID:

Re: [PR] [FLINK-20398][e2e] Migrate test_batch_sql.sh to Java e2e tests framework [flink]

2024-05-22 Thread via GitHub
affo commented on code in PR #24471: URL: https://github.com/apache/flink/pull/24471#discussion_r1609688204 ## flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/GeneratedRow.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software

Re: [I] [Bug] [tools] executing the ./tools/bin/upgrade-schema.sh returns Application run failed: snakeyaml was not found on the classpath [dolphinscheduler]

2024-05-22 Thread via GitHub
tinglink commented on issue #16051: URL: https://github.com/apache/dolphinscheduler/issues/16051#issuecomment-2124412146 null -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [bugfix](hive)fix testcase for viewfs for 2.1 [doris]

2024-05-22 Thread via GitHub
yiguolei merged PR #35178: URL: https://github.com/apache/doris/pull/35178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug] [tools] executing the ./tools/bin/upgrade-schema.sh returns Application run failed: snakeyaml was not found on the classpath [dolphinscheduler]

2024-05-22 Thread via GitHub
tinglink closed issue #16051: [Bug] [tools] executing the ./tools/bin/upgrade-schema.sh returns Application run failed: snakeyaml was not found on the classpath URL: https://github.com/apache/dolphinscheduler/issues/16051 -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-34673][test] Fix SessionRelatedITCase#testTouchSession failure on GitHub Actions [flink]

2024-05-22 Thread via GitHub
flinkbot commented on PR #24826: URL: https://github.com/apache/flink/pull/24826#issuecomment-2124410267 ## CI report: * bf66e54dc052585584f5ae40c2a11a995dacca0c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [feat](nereids)push Limit to local agg [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #34853: URL: https://github.com/apache/doris/pull/34853#issuecomment-2124410247 TPC-DS: Total hot run time: 171080 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] Optimize S3 storage writing for MSQ durable storage (druid)

2024-05-22 Thread via GitHub
Akshat-Jain commented on code in PR #16481: URL: https://github.com/apache/druid/pull/16481#discussion_r1609685088 ## extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java: ## @@ -103,22 +107,32 @@ public class

Re: [PR] [fix](move-memtable) clear load streams before shutdown SegmentFileWriterThreadPool [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35217: URL: https://github.com/apache/doris/pull/35217#issuecomment-2124410133 TPC-DS: Total hot run time: 170907 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

[PR] [WIP] dummy PR [spark]

2024-05-22 Thread via GitHub
stefankandic opened a new pull request, #46702: URL: https://github.com/apache/spark/pull/46702 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
pankajastro commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609684585 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -388,16 +407,17 @@ def _es_read(self, log_id: str, offset: int | str) -> ElasticSearchResponse

Re: [PR] [fix](memory) Allow flush memtable failed when process exceed memlimit [doris]

2024-05-22 Thread via GitHub
yiguolei merged PR #35150: URL: https://github.com/apache/doris/pull/35150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Enable spark rand function [incubator-gluten]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #5829: URL: https://github.com/apache/incubator-gluten/pull/5829#issuecomment-2124408092 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
pankajastro commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609681260 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -152,7 +153,8 @@ def __init__( offset_field: str = "offset", host: str =

Re: [I] SQL `max()`, `min()` fail for `VARCHAR` (`string`) columns (druid)

2024-05-22 Thread via GitHub
abhishekagarwal87 commented on issue #11659: URL: https://github.com/apache/druid/issues/11659#issuecomment-2124407399 @rfetishkevi Go ahead. You can look at existing min/max aggregators to aide you in figuring out the implementation. -- This is an automated message from the Apache Git

[PR] fix(dev): Update the image of initializeCommand in devcontainer.json [incubator-graphar]

2024-05-22 Thread via GitHub
acezen opened a new pull request, #492: URL: https://github.com/apache/incubator-graphar/pull/492 ### Reason for this PR #490 ### What changes are included in this PR? Update the image of initializeCommand in devcontainer.json ### Are these changes

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
pankajastro commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609681260 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -152,7 +153,8 @@ def __init__( offset_field: str = "offset", host: str =

Re: [PR] Docs: Update PR workflow documentation [datafusion]

2024-05-22 Thread via GitHub
alamb commented on PR #10532: URL: https://github.com/apache/datafusion/pull/10532#issuecomment-2124406990 I also added two links to github filters I use to find PRs waiting on review and PRs that are approved waiting on merge:

Re: [PR] Run tests for Providers also for Airflow 2.8 [airflow]

2024-05-22 Thread via GitHub
kacpermuda commented on PR #39606: URL: https://github.com/apache/airflow/pull/39606#issuecomment-2124404668 @potiuk do you think #39755 will be enough to fix the test you mentioned and make the io provider + OpenLineage work well with Airflow 2.8 ? -- This is an automated message from

Re: [PR] remove deprecations google cloud [airflow]

2024-05-22 Thread via GitHub
VladaZakharova commented on code in PR #39713: URL: https://github.com/apache/airflow/pull/39713#discussion_r1609679135 ## tests/system/providers/google/cloud/dataproc/example_dataproc_gke.py: ## @@ -55,7 +55,9 @@ "workload_identity_config": { "workload_pool":

Re: [PR] Make elastic search index_pattern more configurable [airflow]

2024-05-22 Thread via GitHub
pankajastro commented on code in PR #38423: URL: https://github.com/apache/airflow/pull/38423#discussion_r1609678726 ## airflow/providers/elasticsearch/log/es_task_handler.py: ## @@ -213,6 +216,21 @@ def format_url(host: str) -> str: return host +def

Re: [PR] [opt](thrift)update thrift to support pushing limit to local Agg [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35204: URL: https://github.com/apache/doris/pull/35204#issuecomment-2124404099 TPC-H: Total hot run time: 42085 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

[I] [Bug] [Mongo] The column type is , but a null value is being written into it [seatunnel]

2024-05-22 Thread via GitHub
Light-Towers opened a new issue, #6884: URL: https://github.com/apache/seatunnel/issues/6884 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues. ### What

Re: [I] fix(infra): Fix the invalid dev container image [incubator-graphar]

2024-05-22 Thread via GitHub
acezen commented on issue #490: URL: https://github.com/apache/incubator-graphar/issues/490#issuecomment-2124404230 > docker pull registry.cn-hongkong.aliyuncs.com/graphscope/graphar-dev:latest Error response from daemon: pull access denied for

Re: [I] fix(infra): Fix the invalid dev container image [incubator-graphar]

2024-05-22 Thread via GitHub
ywh555hhh commented on issue #490: URL: https://github.com/apache/incubator-graphar/issues/490#issuecomment-2124402857 docker pull registry.cn-hongkong.aliyuncs.com/graphscope/graphar-dev:latest Error response from daemon: pull access denied for

Re: [PR] [Fix](regression) fix show data regression case [doris]

2024-05-22 Thread via GitHub
airborne12 commented on PR #35218: URL: https://github.com/apache/doris/pull/35218#issuecomment-2124402453 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix](regression) fix show data regression case [doris]

2024-05-22 Thread via GitHub
doris-robot commented on PR #35218: URL: https://github.com/apache/doris/pull/35218#issuecomment-2124402142 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

Re: [PR] Bump org.wiremock:wiremock from 3.0.3 to 3.5.4 [camel]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #14221: URL: https://github.com/apache/camel/pull/14221#issuecomment-2124402180 :robot: The Apache Camel test robot will run the tests for you :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [Fix](regression) fix show data regression case [doris]

2024-05-22 Thread via GitHub
airborne12 opened a new pull request, #35218: URL: https://github.com/apache/doris/pull/35218 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at

Re: [PR] GH-41190: [C++] support for single threaded joins [arrow]

2024-05-22 Thread via GitHub
zanmato1984 commented on code in PR #41125: URL: https://github.com/apache/arrow/pull/41125#discussion_r1609676679 ## cpp/src/arrow/acero/asof_join_node.cc: ## @@ -1425,31 +1431,86 @@ class AsofJoinNode : public ExecNode { // The reason for this is that there are cases at

Re: [I] Azure CI pending [incubator-xtable]

2024-05-22 Thread via GitHub
vinishjail97 commented on issue #438: URL: https://github.com/apache/incubator-xtable/issues/438#issuecomment-2124401946 @daragu There are some apache guidelines for using a azure CI pipeline, l will check more on this. -- This is an automated message from the Apache Git Service. To

Re: [PR] Bump org.wiremock:wiremock from 3.0.3 to 3.5.4 [camel]

2024-05-22 Thread via GitHub
oscerd commented on PR #14221: URL: https://github.com/apache/camel/pull/14221#issuecomment-2124401461 /component-test bonita oaipmh openstack platform-http-vertx pubnub rest-openapi thymeleaf xchange -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [Fix](Nereids) fix hint tests with different be instances [doris]

2024-05-22 Thread via GitHub
LiBinfeng-01 commented on PR #35188: URL: https://github.com/apache/doris/pull/35188#issuecomment-2124400847 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-48379][INFRA] Cancel previous builds on a PR when new commit is pushed [spark]

2024-05-22 Thread via GitHub
yaooqinn commented on PR #46689: URL: https://github.com/apache/spark/pull/46689#issuecomment-2124399925 > @yaooqinn Do you know what would be the workaround? The only suitable way seems to increase the await time for a new job to be scheduled -- This is an automated

Re: [PR] [FLINK-34487][ci] Adds Python Wheels nightly GHA workflow [flink]

2024-05-22 Thread via GitHub
XComp commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1609654509 ## .github/workflows/nightly.yml: ## @@ -94,3 +94,65 @@ jobs: s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }} s3_access_key: ${{ secrets.IT_CASE_S3_ACCESS_KEY

Re: [PR] chore(export): Added ability to export chart YAML files with Unicode characters, fix #20331 [superset]

2024-05-22 Thread via GitHub
xyb commented on PR #28008: URL: https://github.com/apache/superset/pull/28008#issuecomment-2124398534 @john-bodley @dpgaspar I've added some tests, but I'm not familiar with superset and its testing framework, I'd greatly appreciate it if someone could take a look at it and provide some

Re: [PR] Bump com.google.code.gson:gson from 2.10.1 to 2.11.0 [camel]

2024-05-22 Thread via GitHub
oscerd merged PR #14219: URL: https://github.com/apache/camel/pull/14219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] server: add global setting consoleproxy.sslEnabled [cloudstack]

2024-05-22 Thread via GitHub
DaanHoogland commented on PR #8809: URL: https://github.com/apache/cloudstack/pull/8809#issuecomment-2124397181 @GutoVeronezi @hsato03 are all your concerns met here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [only for test] open UBSAN [doris]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #35177: URL: https://github.com/apache/doris/pull/35177#issuecomment-2124397073 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/9189320885;) output. shellcheck

[PR] [FLINK-34673][test] Fix SessionRelatedITCase#testTouchSession failure on GitHub Actions [flink]

2024-05-22 Thread via GitHub
juanvisoler opened a new pull request, #24826: URL: https://github.com/apache/flink/pull/24826 ## What is the purpose of the change Fixes flaky test `SessionRelatedITCase#testTouchSession` by giving the test some extra time to see the updated `lastAccessTime` after a `touch` when needed.

[PR] [openlineage] fix: OpenLineage in FileTransferOperator for Airflow 2.8 [airflow]

2024-05-22 Thread via GitHub
kacpermuda opened a new pull request, #39755: URL: https://github.com/apache/airflow/pull/39755 As discussed in #39606, there is an issue with OpenLineage in FileTransferOperator when running Airflow 2.8. Namespace property has been added in core Airflow

Re: [PR] [only for test] open UBSAN [doris]

2024-05-22 Thread via GitHub
Mryange commented on PR #35177: URL: https://github.com/apache/doris/pull/35177#issuecomment-2124395778 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] help request: Can proxy-rewite plugin support multiple path rewrite? [apisix]

2024-05-22 Thread via GitHub
github-actions[bot] commented on issue #9258: URL: https://github.com/apache/apisix/issues/9258#issuecomment-2124395131 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please

Re: [PR] CAMEL-20795 - camel-nats - NATS Credential file support [camel]

2024-05-22 Thread via GitHub
oscerd commented on PR #14223: URL: https://github.com/apache/camel/pull/14223#issuecomment-2124394441 > Maybe we dont need `usecredentialsfile` and if the credentials file is set then that means it will be in use Makes sense, I've added that because I thought about how we are doing

Re: [PR] Docs: Update PR workflow documentation [datafusion]

2024-05-22 Thread via GitHub
alamb commented on PR #10532: URL: https://github.com/apache/datafusion/pull/10532#issuecomment-2124394482 > I'm thinking should describe a draft status usage as well? @comphead -- in so far that we know how we use the draft status, that might be helpful. However, I am not sure it

<    5   6   7   8   9   10   11   12   13   14   >