Re: [bug report] INFO: task mdX_resync:42168 blocked for more than 122 seconds

2024-05-16 Thread Ming Lei
Cc raid and dm list. On Thu, May 16, 2024 at 06:24:18PM +0800, Changhui Zhong wrote: > Hello, > > when create lvm raid1, the command hang on for a long time. > please help check it and let me know if you need any info/testing for > it, thanks. > >

Re: Useless test in alloc_multiple_bios

2024-05-16 Thread Ming Lei
On Wed, May 15, 2024 at 08:15:20PM +0200, Mikulas Patocka wrote: > Hi > > I found this piece of code in alloc_multiple_bios: > int try = (gfp_flag & GFP_NOWAIT) ? 0 : 1; I guess the above check is supposed to be (gfp_flag == GFP_NOWAIT)? > > The problem is that GFP_NOWAIT includes

Re: [RFC PATCH 1/2] block: change rq_integrity_vec to respect the iterator

2024-05-16 Thread Ming Lei
On Wed, May 15, 2024 at 03:28:11PM +0200, Mikulas Patocka wrote: > If we allocate a bio that is larger than NVMe maximum request size, attach > integrity metadata to it and send it to the NVMe subsystem, the integrity > metadata will be corrupted. > > Splitting the bio works correctly. The

[OS-BUILD PATCHv3 1/2] configs: move CONFIG_BLK_SED_OPAL into redhat/configs/common/generic

2024-04-28 Thread Ming Lei (via Email Bridge)
From: Ming Lei configs: move CONFIG_BLK_SED_OPAL into redhat/configs/common/generic CONFIG_BLK_SED_OPAL is being enabled for rhel9, and need to be enabled for cs10 too. Signed-off-by: Ming Lei diff --git a/redhat/configs/fedora/generic/CONFIG_BLK_SED_OPAL b/redhat/configs/common/generic

[OS-BUILD PATCHv3 2/2] configs: move CONFIG_BLK_DEV_UBLK into rhel/configs/generic

2024-04-28 Thread Ming Lei (via Email Bridge)
From: Ming Lei configs: move CONFIG_BLK_DEV_UBLK into rhel/configs/generic CONFIG_BLK_DEV_UBLK has been enabled since fedora 38, and plan to enable it in rhel10. Signed-off-by: Ming Lei diff --git a/redhat/configs/fedora/generic/CONFIG_BLKDEV_UBLK_LEGACY_OPCODES b/redhat/configs/common

[OS-BUILD PATCHv3 0/2] configs: add CONFIG_BLK_SED_OPAL and CONFIG_BLK_DEV_UBLK

2024-04-28 Thread Ming Lei (via Email Bridge)
From: Ming Lei on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3071 We plan to support both two in cs10. Signed-off-by: Ming Lei --- redhat/configs/fedora/generic/CONFIG_BLKDEV_UBLK_LEGACY_OPCODES => redhat/configs/common/gene

Re: [OS-BUILD PATCHv2 0/2] configs: add CONFIG_BLK_SED_OPAL and CONFIG_BLK_DEV_UBLK

2024-04-28 Thread Ming Lei (via Email Bridge)
From: Ming Lei on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3071#note_1884330539 @ptalbert You are right, we need to move the configs from fedora to common, and now it is done in v2, can you unblock the ackes? -- ___ kernel

[OS-BUILD PATCHv2 2/2] configs: move CONFIG_BLK_DEV_UBLK into rhel/configs/generic

2024-04-28 Thread Ming Lei (via Email Bridge)
From: Ming Lei configs: move CONFIG_BLK_DEV_UBLK into rhel/configs/generic CONFIG_BLK_DEV_UBLK has been enabled since fedora 38, and plan to enable it in rhel10. Signed-off-by: Ming Lei diff --git a/redhat/configs/fedora/generic/CONFIG_BLKDEV_UBLK_LEGACY_OPCODES b/redhat/configs/common

[OS-BUILD PATCHv2 0/2] configs: add CONFIG_BLK_SED_OPAL and CONFIG_BLK_DEV_UBLK

2024-04-28 Thread Ming Lei (via Email Bridge)
From: Ming Lei on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3071 We plan to support both two in cs10. Signed-off-by: Ming Lei --- redhat/configs/fedora/generic/CONFIG_BLKDEV_UBLK_LEGACY_OPCODES => redhat/configs/common/gene

[OS-BUILD PATCHv2 1/2] configs: move CONFIG_BLK_SED_OPAL into redhat/configs/common/generic

2024-04-28 Thread Ming Lei (via Email Bridge)
From: Ming Lei configs: move CONFIG_BLK_SED_OPAL into redhat/configs/common/generic CONFIG_BLK_SED_OPAL is being enabled for rhel9, and need to be enabled for cs10 too. Signed-off-by: Ming Lei diff --git a/redhat/configs/fedora/generic/CONFIG_BLK_SED_OPAL b/redhat/configs/common/generic

Re: [PATCH] block: allow device to have both virt_boundary_mask and max segment size

2024-04-24 Thread Ming Lei
On Wed, Apr 24, 2024 at 12:26:26PM +0200, Geert Uytterhoeven wrote: > Hi Ming, > > On Sun, 7 Apr 2024, Ming Lei wrote: > > When one stacking device is over one device with virt_boundary_mask and > > another one with max segment size, the stacking device have both lim

Re: [PATCH for-6.10 2/2] dm: use queue_limits_set

2024-04-23 Thread Ming Lei
ctually updated before > the assignment. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Mike Snitzer Reviewed-by: Ming Lei Thanks, Ming

Re: [PATCH for-6.10 1/2] dm-crypt: stop constraining max_segment_size to PAGE_SIZE

2024-04-23 Thread Ming Lei
) because blk_validate_limits() was > made less strict with commit b561ea56a264 ("block: allow device to > have both virt_boundary_mask and max segment size"). > > Signed-off-by: Mike Snitzer Reviewed-by: Ming Lei Thanks, Ming

[OS-BUILD PATCH 2/2] configs: add CONFIG_BLK_DEV_UBLK

2024-04-18 Thread Ming Lei (via Email Bridge)
From: Ming Lei configs: add CONFIG_BLK_DEV_UBLK CONFIG_BLK_DEV_UBLK has been enabled since fedora 38, and plan to enable it in rhel10. Signed-off-by: Ming Lei diff --git a/redhat/configs/common/generic/CONFIG_BLK_DEV_UBLK b/redhat/configs/common/generic/CONFIG_BLK_DEV_UBLK new file mode

[OS-BUILD PATCH 0/2] configs: add CONFIG_BLK_SED_OPAL and CONFIG_BLK_DEV_UBLK

2024-04-18 Thread Ming Lei (via Email Bridge)
From: Ming Lei on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3071 We plan to support both two in cs10. Signed-off-by: Ming Lei --- redhat/configs/common/generic/CONFIG_BLK_DEV_UBLK | 1 + redhat/configs/common/generic/CONFIG_BLK_SED_OPAL | 1 + 2

[OS-BUILD PATCH 1/2] configs: enable CONFIG_BLK_SED_OPAL

2024-04-18 Thread Ming Lei (via Email Bridge)
From: Ming Lei configs: enable CONFIG_BLK_SED_OPAL CONFIG_BLK_SED_OPAL is being enabled for rhel9, and need to be enabled for cs10 too. Signed-off-by: Ming Lei diff --git a/redhat/configs/common/generic/CONFIG_BLK_SED_OPAL b/redhat/configs/common/generic/CONFIG_BLK_SED_OPAL new file mode

Re: [PATCH v2] dm: restore synchronous close of device mapper block device

2024-04-16 Thread Ming Lei
On Tue, Apr 16, 2024 at 11:28:42AM -0400, Mike Snitzer wrote: > From: Ming Lei > > 'dmsetup remove' and 'dmsetup remove_all' require synchronous bdev > release. Otherwise dm_lock_for_deletion() may return -EBUSY if the open > count is > 0, because the open count is dropp

[PATCH] dm: core: put device mapper block device synchronously

2024-04-15 Thread Ming Lei
use regression. Fix the issue by using __fput_sync(). Reported-by: Zhong Changhui Fixes: a28d893eb327 ("md: port block device access to file") Suggested-by: Christian Brauner Cc: Jan Kara Signed-off-by: Ming Lei --- drivers/md/dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

Re: [PATCH v2 04/34] md: port block device access to file

2024-04-15 Thread Ming Lei
On Mon, Apr 15, 2024 at 06:22:10PM +0200, Jan Kara wrote: > On Mon 15-04-24 23:11:50, Ming Lei wrote: > > On Mon, Apr 15, 2024 at 04:53:42PM +0200, Christian Brauner wrote: > > > On Mon, Apr 15, 2024 at 10:35:53PM +0800, Ming Lei wrote: > > > > On Mon, Apr 15, 2024

Re: [PATCH v2 04/34] md: port block device access to file

2024-04-15 Thread Ming Lei
On Mon, Apr 15, 2024 at 04:53:42PM +0200, Christian Brauner wrote: > On Mon, Apr 15, 2024 at 10:35:53PM +0800, Ming Lei wrote: > > On Mon, Apr 15, 2024 at 02:35:17PM +0200, Christian Brauner wrote: > > > On Mon, Apr 15, 2024 at 05:26:19PM +0800, Ming Lei wr

Re: [PATCH v2 04/34] md: port block device access to file

2024-04-15 Thread Ming Lei
On Mon, Apr 15, 2024 at 02:35:17PM +0200, Christian Brauner wrote: > On Mon, Apr 15, 2024 at 05:26:19PM +0800, Ming Lei wrote: > > Hello, > > > > On Tue, Jan 23, 2024 at 02:26:21PM +0100, Christian Brauner wrote: > > > Signed-off-by: Christian Brauner &g

Re: [PATCH v2 04/34] md: port block device access to file

2024-04-15 Thread Ming Lei
Hello, On Tue, Jan 23, 2024 at 02:26:21PM +0100, Christian Brauner wrote: > Signed-off-by: Christian Brauner > --- > drivers/md/dm.c | 23 +-- > drivers/md/md.c | 12 ++-- > drivers/md/md.h | 2 +- >

Re: [PATCH] block: allow device to have both virt_boundary_mask and max segment size

2024-04-09 Thread Ming Lei
On Tue, Apr 09, 2024 at 03:57:58PM +0200, Christoph Hellwig wrote: > On Mon, Apr 08, 2024 at 05:48:02PM +0800, Ming Lei wrote: > > The limit is from commit 09324d32d2a0 ("block: force an unlimited segment > > size on queues with a virt boundary") which claims to fix f6970f

Re: [PATCH] block: allow device to have both virt_boundary_mask and max segment size

2024-04-08 Thread Ming Lei
On Mon, Apr 08, 2024 at 10:47:39AM +0200, Christoph Hellwig wrote: > On Mon, Apr 08, 2024 at 03:36:50PM +0800, Ming Lei wrote: > > It isn't now we put the limit, and this way has been done for stacking > > device > > since beginning, it is actually added by commit d69

Re: [PATCH] block: allow device to have both virt_boundary_mask and max segment size

2024-04-08 Thread Ming Lei
On Mon, Apr 08, 2024 at 07:55:42AM +0200, Christoph Hellwig wrote: > On Sun, Apr 07, 2024 at 09:19:31PM +0800, Ming Lei wrote: > > When one stacking device is over one device with virt_boundary_mask and > > another one with max segment size, the stacking device have both limits &g

[PATCH] block: allow device to have both virt_boundary_mask and max segment size

2024-04-07 Thread Ming Lei
ph Hellwig Cc: Mike Snitzer Cc: dm-devel@lists.linux.dev Cc: Song Liu Cc: linux-r...@vger.kernel.org Signed-off-by: Ming Lei --- block/blk-settings.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/block/blk-settings.c b/block/blk-settings.c index cdbaef159c4b.

Re: block: fail unaligned bio from submit_bio_noacct()

2024-03-24 Thread Ming Lei
On Thu, Mar 21, 2024 at 08:39:06PM -0600, Keith Busch wrote: > On Fri, Mar 22, 2024 at 10:08:11AM +0800, Ming Lei wrote: > > On Thu, Mar 21, 2024 at 06:01:41PM +0100, Mikulas Patocka wrote: > > > I would change it to > > > > > > if (unlikely((

Re: Look for help: how to package Rust project

2024-03-22 Thread Ming Lei
On Thu, Mar 21, 2024 at 6:27 PM Fabio Valentini wrote: > > On Thu, Mar 21, 2024 at 9:25 AM Richard W.M. Jones wrote: > > > > On Thu, Mar 21, 2024 at 11:04:13AM +0800, Ming Lei wrote: > > > Hello Richard and Guys, > > > > > > I plan to packag

Re: [PATCH] dm-integrity: align the outgoing bio in integrity_recheck

2024-03-22 Thread Ming Lei
On Fri, Mar 22, 2024 at 01:32:30PM +0100, Mikulas Patocka wrote: > > > On Fri, 22 Mar 2024, Ming Lei wrote: > > > If logical block becomes mismatched by reconfiguration, the whole DM stack > > can't work: > > > > - at the beginning, DM is over NVMe(512 b

Re: [PATCH] dm-integrity: align the outgoing bio in integrity_recheck

2024-03-22 Thread Ming Lei
On Fri, Mar 22, 2024 at 11:30:33AM +0100, Mikulas Patocka wrote: > > > On Fri, 22 Mar 2024, Ming Lei wrote: > > > On Thu, Mar 21, 2024 at 05:48:45PM +0100, Mikulas Patocka wrote: > > > It may be possible to set up dm-integrity with smaller sector size than &g

Re: block: fail unaligned bio from submit_bio_noacct()

2024-03-21 Thread Ming Lei
On Thu, Mar 21, 2024 at 06:01:41PM +0100, Mikulas Patocka wrote: > > > On Thu, 21 Mar 2024, Mike Snitzer wrote: > > > On Thu, Mar 21 2024 at 9:16P -0400, > > Ming Lei wrote: > > > > > For any bio with data, its start sector and size have to be align

Re: [PATCH] dm-integrity: align the outgoing bio in integrity_recheck

2024-03-21 Thread Ming Lei
On Thu, Mar 21, 2024 at 05:48:45PM +0100, Mikulas Patocka wrote: > It may be possible to set up dm-integrity with smaller sector size than > the logical sector size of the underlying device. In this situation, > dm-integrity guarantees that the outgoing bios have the same alignment as > incoming

Look for help: how to package Rust project

2024-03-20 Thread Ming Lei
Hello Richard and Guys, I plan to package rublk to Fedora, and it is one Rust project. Can you provide a little guide about how to do that? such as, where can I find the guide doc? And is it github or crates which should be used as source for Fedora packaging? [1]

Re: [RFC Patch] dm: make sure to wait for all dispatched requests in __dm_suspend()

2024-03-19 Thread Ming Lei
On Tue, Mar 19, 2024 at 04:41:26PM +0100, Martin Wilck wrote: > Hello Ming, > > On Tue, 2024-03-19 at 21:04 +0800, Ming Lei wrote: > > Hello Martin, > > > > On Sat, Mar 16, 2024 at 12:10:35AM +0100, Martin Wilck wrote: > > > In a recent kernel dump analys

Re: [RFC Patch] dm: make sure to wait for all dispatched requests in __dm_suspend()

2024-03-19 Thread Ming Lei
Hello Martin, On Sat, Mar 16, 2024 at 12:10:35AM +0100, Martin Wilck wrote: > In a recent kernel dump analysis, we found that the kernel crashed because > dm_rq_target_io tio->ti was pointing to invalid memory in dm_end_request(), > in a situation where multipathd was doing map reloads because of

Re: [GIT PULL] Block updates for 6.9-rc1

2024-03-13 Thread Ming Lei
On Tue, Mar 12, 2024 at 02:10:13PM -0700, Christoph Hellwig wrote: > On Tue, Mar 12, 2024 at 11:22:53AM -0400, Mike Snitzer wrote: > > blk_validate_limits() is currently very pedantic. I discussed with Jens > > briefly and we're thinking it might make sense for blk_validate_limits() > > to be more

Re: LVM-on-LVM: error while submitting device barriers

2024-03-11 Thread Ming Lei
On Sun, Mar 10, 2024 at 02:11:11PM -0400, Patrick Plenefisch wrote: > On Sun, Mar 10, 2024 at 11:27 AM Mike Snitzer wrote: > > > > On Sun, Mar 10 2024 at 7:34P -0400, > > Ming Lei wrote: > > > > > On Sat, Mar 09, 2024 at 03:39:02PM -0500, Patrick Plenefisc

Re: LVM-on-LVM: error while submitting device barriers

2024-03-10 Thread Ming Lei
On Sun, Mar 10, 2024 at 11:27:22AM -0400, Mike Snitzer wrote: > On Sun, Mar 10 2024 at 7:34P -0400, > Ming Lei wrote: > > > On Sat, Mar 09, 2024 at 03:39:02PM -0500, Patrick Plenefisch wrote: > > > On Wed, Mar 6, 2024 at 11:00 AM Ming Lei wrote: > > > > &

Re: LVM-on-LVM: error while submitting device barriers

2024-03-10 Thread Ming Lei
On Sat, Mar 09, 2024 at 03:39:02PM -0500, Patrick Plenefisch wrote: > On Wed, Mar 6, 2024 at 11:00 AM Ming Lei wrote: > > > > On Tue, Mar 05, 2024 at 12:45:13PM -0500, Mike Snitzer wrote: > > > On Thu, Feb 29 2024 at 5:05P -0500, > > > Goffredo Baroncelli w

Re: LVM-on-LVM: error while submitting device barriers

2024-03-06 Thread Ming Lei
On Tue, Mar 05, 2024 at 12:45:13PM -0500, Mike Snitzer wrote: > On Thu, Feb 29 2024 at 5:05P -0500, > Goffredo Baroncelli wrote: > > > On 29/02/2024 21.22, Patrick Plenefisch wrote: > > > On Thu, Feb 29, 2024 at 2:56 PM Goffredo Baroncelli > > > wrote: > > > > > > > > > Your understanding is

Re: [PATCH 06/26] block: Introduce zone write plugging

2024-02-05 Thread Ming Lei
On Mon, Feb 05, 2024 at 11:41:04AM +0900, Damien Le Moal wrote: > On 2/5/24 11:19, Ming Lei wrote: > >>>> +static inline void blk_zone_wplug_add_bio(struct blk_zone_wplug *zwplug, > >>>> + struct bio *

Re: [PATCH 06/26] block: Introduce zone write plugging

2024-02-04 Thread Ming Lei
On Mon, Feb 05, 2024 at 11:41:04AM +0900, Damien Le Moal wrote: > On 2/5/24 11:19, Ming Lei wrote: > >>>> +static inline void blk_zone_wplug_add_bio(struct blk_zone_wplug *zwplug, > >>>> + struct bio *

Re: [PATCH 06/26] block: Introduce zone write plugging

2024-02-04 Thread Ming Lei
On Mon, Feb 05, 2024 at 08:57:00AM +0900, Damien Le Moal wrote: > On 2/4/24 12:56, Ming Lei wrote: > > On Fri, Feb 02, 2024 at 04:30:44PM +0900, Damien Le Moal wrote: > >> +/* > >> + * Zone write plug flags bits: > >> + * - BLK_ZONE_WPLUG_CONV: Indicate

Re: [PATCH 06/26] block: Introduce zone write plugging

2024-02-03 Thread Ming Lei
On Fri, Feb 02, 2024 at 04:30:44PM +0900, Damien Le Moal wrote: > Zone write plugging implements a per-zone "plug" for write operations to > tightly control the submission and execution order of writes to > sequential write required zones of a zoned block device. Per-zone > plugging of writes

Re: [PATCH v9 1/5] block: Fix where bio IO priority gets set

2024-01-31 Thread Ming Lei
> [snitzer: revised commit header] > Signed-off-by: Mike Snitzer Looks fine, Reviewed-by: Ming Lei Thanks, Ming

Re: [PATCH v3 0/4] brd discard patches

2024-01-22 Thread Ming Lei
On Mon, Jan 22, 2024 at 05:30:07PM +0100, Mikulas Patocka wrote: > Hi > > > On Fri, 19 Jan 2024, Ming Lei wrote: > > > Hi Mikulas, > > > > On Thu, Aug 10, 2023 at 12:07:07PM +0200, Mikulas Patocka wrote: > > > Hi > > > > > > Here I

Re: [PATCH v3 0/4] brd discard patches

2024-01-19 Thread Ming Lei
Hi Mikulas, On Thu, Aug 10, 2023 at 12:07:07PM +0200, Mikulas Patocka wrote: > Hi > > Here I'm submitting the ramdisk discard patches for the next merge window. > If you want to make some more changes, please let me now. brd discard is removed in f09a06a193d9 ("brd: remove discard support") in

qcow2-rs v0.1 and rublk-qcow2

2024-01-09 Thread Ming Lei
Hello, qcow2-rs[1] is one pure Rust library for reading/writing qcow2 image, it is based on rsd's[2] internal qcow2 implementation, but with lots of change, so far: - supports read/write on data file, backing file and compressed image - block device like interface, minimized read/write unit is

Re: Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5

2023-11-01 Thread Ming Lei
On Wed, Nov 01, 2023 at 11:15:02AM +0100, Hannes Reinecke wrote: > On 11/1/23 04:24, Ming Lei wrote: > > On Wed, Nov 01, 2023 at 03:14:22AM +0100, Marek Marczykowski-Górecki wrote: > > > On Wed, Nov 01, 2023 at 09:27:24AM +0800, Ming Lei wrote: > > > > On Tue,

Re: Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5

2023-10-31 Thread Ming Lei
On Wed, Nov 01, 2023 at 03:14:22AM +0100, Marek Marczykowski-Górecki wrote: > On Wed, Nov 01, 2023 at 09:27:24AM +0800, Ming Lei wrote: > > On Tue, Oct 31, 2023 at 11:42 PM Marek Marczykowski-Górecki > > wrote: > > > > > > On Tue, Oct 31, 2023 at 03:01:36PM +010

Re: Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5

2023-10-31 Thread Ming Lei
ust collect logs of the exact disks if you know what are behind dm-crypt, which can be figured out by `lsblk`, and it has to be collected after the hang is triggered. Thanks, Ming Lei

Re: [PATCH v2] dm: respect REQ_NOWAIT flag in bios issued to DM

2023-10-25 Thread Ming Lei
On Wed, Oct 25, 2023 at 03:34:40PM -0400, Mike Snitzer wrote: > From: Mikulas Patocka > > Update DM core's IO submission to allocate required memory using > GFP_NOWAIT if REQ_NOWAIT is set. Lone exception is in the error path > where DM's requeue support needs to allocate a clone bio in >

Re: [PATCH V3] io_uring: fix IO hang in io_wq_put_and_exit from do_exit()

2023-09-25 Thread Ming Lei
On Mon, Sep 25, 2023 at 05:17:10PM -0400, Stefan Hajnoczi wrote: > On Fri, Sep 15, 2023 at 03:04:05PM +0800, Jason Wang wrote: > > On Fri, Sep 8, 2023 at 11:25 PM Ming Lei wrote: > > > > > > On Fri, Sep 08, 2023 at 08:44:45AM -0600, Jens Axboe wrote: > > >

Re: [PATCH V3] io_uring: fix IO hang in io_wq_put_and_exit from do_exit()

2023-09-08 Thread Ming Lei
On Fri, Sep 08, 2023 at 08:44:45AM -0600, Jens Axboe wrote: > On 9/8/23 8:34 AM, Ming Lei wrote: > > On Fri, Sep 08, 2023 at 07:49:53AM -0600, Jens Axboe wrote: > >> On 9/8/23 3:30 AM, Ming Lei wrote: > >>> diff --git a/io_uring/io_uring.c b/io_uring/io_ur

Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()

2023-08-09 Thread Ming Lei
On Thu, Aug 10, 2023 at 09:18:27AM +0800, Baoquan He wrote: > On 08/10/23 at 08:09am, Ming Lei wrote: > > On Wed, Aug 09, 2023 at 03:44:01PM +0200, Christoph Hellwig wrote: > > > I'm starting to sound like a broken record, but we can't just do random > > > is_kdump

Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()

2023-08-09 Thread Ming Lei
On Thu, Aug 10, 2023 at 09:18:27AM +0800, Baoquan He wrote: > On 08/10/23 at 08:09am, Ming Lei wrote: > > On Wed, Aug 09, 2023 at 03:44:01PM +0200, Christoph Hellwig wrote: > > > I'm starting to sound like a broken record, but we can't just do random > > > is_kdump

Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()

2023-08-09 Thread Ming Lei
On Wed, Aug 09, 2023 at 03:44:01PM +0200, Christoph Hellwig wrote: > I'm starting to sound like a broken record, but we can't just do random > is_kdump checks, and it's not going to get better by resending it again and > again. If kdump kernels limit the number of possible CPUs, it needs to >

Re: [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues()

2023-08-09 Thread Ming Lei
On Wed, Aug 09, 2023 at 03:44:01PM +0200, Christoph Hellwig wrote: > I'm starting to sound like a broken record, but we can't just do random > is_kdump checks, and it's not going to get better by resending it again and > again. If kdump kernels limit the number of possible CPUs, it needs to >

[PATCH V3 04/14] virtio-blk: limit max allowed submit queues

2023-08-08 Thread Ming Lei
resource utilization, and reduce risk of kernel failure. Cc: Michael S. Tsirkin Cc: Jason Wang Cc: virtualization@lists.linux-foundation.org Signed-off-by: Ming Lei --- drivers/block/virtio_blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/block/virtio_blk.c b

Re: [PATCH 2/2] nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues

2023-07-10 Thread Ming Lei
Hi Baoquan, On Tue, Jul 11, 2023 at 11:35:50AM +0800, Baoquan He wrote: > On 07/10/23 at 05:14pm, Ming Lei wrote: > > On Mon, Jul 10, 2023 at 08:41:09AM +0200, Christoph Hellwig wrote: > > > On Sat, Jul 08, 2023 at 10:02:59AM +0800, Ming Lei wrote: > > > > Take b

Re: [PATCH 2/2] nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues

2023-07-10 Thread Ming Lei
Hi Baoquan, On Tue, Jul 11, 2023 at 11:35:50AM +0800, Baoquan He wrote: > On 07/10/23 at 05:14pm, Ming Lei wrote: > > On Mon, Jul 10, 2023 at 08:41:09AM +0200, Christoph Hellwig wrote: > > > On Sat, Jul 08, 2023 at 10:02:59AM +0800, Ming Lei wrote: > > > > Take b

Re: [PATCH 2/2] nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues

2023-07-10 Thread Ming Lei
On Mon, Jul 10, 2023 at 10:51:43AM -0600, Keith Busch wrote: > On Mon, Jul 10, 2023 at 05:14:15PM +0800, Ming Lei wrote: > > On Mon, Jul 10, 2023 at 08:41:09AM +0200, Christoph Hellwig wrote: > > > On Sat, Jul 08, 2023 at 10:02:59AM +0800, Ming Lei wrote: > > >

Re: [PATCH 2/2] nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues

2023-07-10 Thread Ming Lei
On Mon, Jul 10, 2023 at 10:51:43AM -0600, Keith Busch wrote: > On Mon, Jul 10, 2023 at 05:14:15PM +0800, Ming Lei wrote: > > On Mon, Jul 10, 2023 at 08:41:09AM +0200, Christoph Hellwig wrote: > > > On Sat, Jul 08, 2023 at 10:02:59AM +0800, Ming Lei wrote: > > >

Re: [PATCH 2/2] nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues

2023-07-10 Thread Ming Lei
On Mon, Jul 10, 2023 at 08:41:09AM +0200, Christoph Hellwig wrote: > On Sat, Jul 08, 2023 at 10:02:59AM +0800, Ming Lei wrote: > > Take blk-mq's knowledge into account for calculating io queues. > > > > Fix wrong queue mapping in case of kdump kernel. > > >

Re: [PATCH 2/2] nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues

2023-07-10 Thread Ming Lei
On Mon, Jul 10, 2023 at 08:41:09AM +0200, Christoph Hellwig wrote: > On Sat, Jul 08, 2023 at 10:02:59AM +0800, Ming Lei wrote: > > Take blk-mq's knowledge into account for calculating io queues. > > > > Fix wrong queue mapping in case of kdump kernel. > > >

Re: [dm-devel] [PATCH v13 3/9] block: add emulation for copy

2023-06-29 Thread Ming Lei
Hi Nitesh, On Wed, Jun 28, 2023 at 12:06:17AM +0530, Nitesh Shetty wrote: > For the devices which does not support copy, copy emulation is added. > It is required for in-kernel users like fabrics, where file descriptor is I can understand copy command does help for FS GC and fabrics storages,

Re: [f2fs-dev] [PATCH v3 01/10] kobject: introduce kobject_del_and_put()

2023-03-22 Thread Ming Lei
On Thu, Mar 23, 2023 at 12:58:30AM +0800, Yangtao Li wrote: > There are plenty of using kobject_del() and kobject_put() together > in the kernel tree. This patch wraps these two calls in a single helper. > > Signed-off-by: Yangtao Li > --- > v3: > -convert to inline helper > v2: > -add

Re: [PATCH v3 01/10] kobject: introduce kobject_del_and_put()

2023-03-22 Thread Ming Lei
On Thu, Mar 23, 2023 at 12:58:30AM +0800, Yangtao Li wrote: > There are plenty of using kobject_del() and kobject_put() together > in the kernel tree. This patch wraps these two calls in a single helper. > > Signed-off-by: Yangtao Li > --- > v3: > -convert to inline helper > v2: > -add

Re: [dm-devel] [PATCH v3] blk-mq: enforce op-specific segment limits in blk_insert_cloned_request

2023-03-01 Thread Ming Lei
_op and enforcing the appropriate segment > limit - max_discard_segments for REQ_OP_DISCARDs and max_segments for > everything else. > > Signed-off-by: Uday Shankar Reviewed-by: Ming Lei Thanks, Ming -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] A hang bug of dm on s390x

2023-02-15 Thread Ming Lei
On Wed, Feb 15, 2023 at 07:23:40PM +0800, Pingfan Liu wrote: > Hi guys, > > I encountered a hang issue on a s390x system. The tested kernel is > not preemptible and booting with "nr_cpus=1" > > The test steps: > umount /home > lvremove /dev/rhel_s390x-kvm-011/home > ##

Re: How/Where to put git_archieve.tar.gz for packaging?

2023-02-07 Thread Ming Lei
Hello Richard, Can we update rawhide(ubdsrv) with upstream commit 58401cf5614ec3ab2a69166e7f9b596f862de105? https://github.com/ming1/ubdsrv/commit/58401cf5614ec3ab2a69166e7f9b596f862de105 Thanks, Ming ___ devel mailing list --

Re: [OS-BUILD PATCH 0/0] General cleanups

2023-01-27 Thread Ming Lei (via Email Bridge)
From: Ming Lei on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2256#note_1255035996 ACK for change in "all: cleanup and de-dupe CDROM_PKTCDVD options.". ___ kernel mailing list -- kernel@lists.fedoraproject.org To u

Re: How/Where to put git_archieve.tar.gz for packaging?

2022-12-09 Thread Ming Lei
Hi Richard, On Fri, Dec 09, 2022 at 08:22:41AM +, Richard W.M. Jones wrote: > On Fri, Dec 09, 2022 at 04:12:18PM +0800, Ming Lei wrote: > > Hello Richard and Guys, > > > > I am trying to figure out one PR for ubdsrv to sync with upstream. > > > > I foun

Re: How/Where to put git_archieve.tar.gz for packaging?

2022-12-09 Thread Ming Lei
Hi Richard, On Fri, Dec 09, 2022 at 08:22:41AM +, Richard W.M. Jones wrote: > On Fri, Dec 09, 2022 at 04:12:18PM +0800, Ming Lei wrote: > > Hello Richard and Guys, > > > > I am trying to figure out one PR for ubdsrv to sync with upstream. > > > > I foun

How/Where to put git_archieve.tar.gz for packaging?

2022-12-09 Thread Ming Lei
Hello Richard and Guys, I am trying to figure out one PR for ubdsrv to sync with upstream. I found the following change in history update: commit 2ab1e571717a13edddc572269608e918e449a3b8 (origin/main) Author: Richard W.M. Jones Date: Thu Nov 3 11:33:42 2022 +

Re: [dm-devel] [RFC for-6.2/block V2] block: Change the granularity of io ticks from ms to ns

2022-12-07 Thread Ming Lei
On Wed, Dec 07, 2022 at 10:32:04PM +, Gulam Mohamed wrote: > As per the review comment from Jens Axboe, I am re-sending this patch > against "for-6.2/block". > > > Use ktime to change the granularity of IO accounting in block layer from > milli-seconds to nano-seconds to get the proper

Re: [dm-devel] [PATCH v5 02/10] block: Add copy offload support infrastructure

2022-12-07 Thread Ming Lei
On Wed, Dec 07, 2022 at 11:24:00AM +0530, Nitesh Shetty wrote: > On Tue, Nov 29, 2022 at 05:14:28PM +0530, Nitesh Shetty wrote: > > On Thu, Nov 24, 2022 at 08:03:56AM +0800, Ming Lei wrote: > > > On Wed, Nov 23, 2022 at 03:37:12PM +0530, Nitesh Shetty wrote: > > > >

Re: [dm-devel] [RFC] block: Change the granularity of io ticks from ms to ns

2022-12-06 Thread Ming Lei
On Wed, Dec 07, 2022 at 10:19:08AM +0800, Yu Kuai wrote: > Hi, > > 在 2022/12/07 2:15, Gulam Mohamed 写道: > > Use ktime to change the granularity of IO accounting in block layer from > > milli-seconds to nano-seconds to get the proper latency values for the > > devices whose latency is in

Re: [dm-devel] [PATCH v5 02/10] block: Add copy offload support infrastructure

2022-11-23 Thread Ming Lei
On Wed, Nov 23, 2022 at 03:37:12PM +0530, Nitesh Shetty wrote: > On Wed, Nov 23, 2022 at 04:04:18PM +0800, Ming Lei wrote: > > On Wed, Nov 23, 2022 at 11:28:19AM +0530, Nitesh Shetty wrote: > > > Introduce blkdev_issue_copy which supports source and destination bdevs, > > &

Re: [dm-devel] [PATCH v5 02/10] block: Add copy offload support infrastructure

2022-11-23 Thread Ming Lei
On Wed, Nov 23, 2022 at 11:28:19AM +0530, Nitesh Shetty wrote: > Introduce blkdev_issue_copy which supports source and destination bdevs, > and an array of (source, destination and copy length) tuples. > Introduce REQ_COPY copy offload operation flag. Create a read-write > bio pair with a token as

Re: [PATCH V3 1/1] blk-mq: avoid double ->queue_rq() because of early timeout

2022-10-30 Thread Ming Lei
On Wed, Oct 26, 2022 at 01:19:57PM +0800, Ming Lei wrote: > From: David Jeffery > > David Jeffery found one double ->queue_rq() issue, so far it can > be triggered in VM use case because of long vmexit latency or preempt > latency of vCPU pthread or long page fault in vCPU p

[dm-devel] [PATCH] blk-mq: don't add non-pt request with ->end_io to batch

2022-10-27 Thread Ming Lei
nitzer Reported-by: Changhui Zhong Signed-off-by: Ming Lei --- include/linux/blk-mq.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h index ba18e9bdb799..d6119c5d1069 100644 --- a/include/linux/blk-mq.h +++ b/include/linux/

[PATCH V3 1/1] blk-mq: avoid double ->queue_rq() because of early timeout

2022-10-25 Thread Ming Lei
for solving this issue. Cc: Stefan Hajnoczi Cc: Keith Busch Cc: virtualization@lists.linux-foundation.org Cc: Bart Van Assche Signed-off-by: David Jeffery Signed-off-by: Ming Lei --- V3: - add callback for handle expired only, suggested by Keith Busch V2: - follow Jens's suggestion to

Re: [PATCH V2 1/1] blk-mq: avoid double ->queue_rq() because of early timeout

2022-10-25 Thread Ming Lei
On Tue, Oct 25, 2022 at 09:11:37PM -0600, Keith Busch wrote: > On Wed, Oct 26, 2022 at 09:55:21AM +0800, Ming Lei wrote: > > @@ -1564,8 +1571,13 @@ static bool blk_mq_check_expired(struct request *rq, > > void *priv) > > * it was completed and reallocated as a new re

[PATCH V2 1/1] blk-mq: avoid double ->queue_rq() because of early timeout

2022-10-25 Thread Ming Lei
for solving this issue. Cc: Stefan Hajnoczi Cc: Keith Busch Cc: virtualization@lists.linux-foundation.org Cc: Bart Van Assche Signed-off-by: David Jeffery Signed-off-by: Ming Lei --- V2: - follow Jens's suggestion to run sync rcu only if there is timeout - rename 'now' as 'start_time

Re: [PATCH] blk-mq: avoid double ->queue_rq() because of early timeout

2022-10-25 Thread Ming Lei
On Tue, Oct 25, 2022 at 12:11:39PM -0600, Jens Axboe wrote: > On 10/24/22 6:55 PM, Ming Lei wrote: > > @@ -1593,10 +1598,18 @@ static void blk_mq_timeout_work(struct work_struct > > *work) > > if (!percpu_ref_tryget(>q_usage_counter)

[PATCH] blk-mq: avoid double ->queue_rq() because of early timeout

2022-10-24 Thread Ming Lei
for solving this issue. Cc: Bart Van Assche Cc: David Jeffery Cc: Stefan Hajnoczi Cc: Keith Busch Cc: virtualization@lists.linux-foundation.org Signed-off-by: Ming Lei --- block/blk-mq.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/bloc

Re: [Bug] double ->queue_rq() because of timeout in ->queue_rq()

2022-10-24 Thread Ming Lei
On Mon, Oct 24, 2022 at 11:30:39AM -0400, Stefan Hajnoczi wrote: > On Fri, Oct 21, 2022 at 10:23:57AM +0800, Ming Lei wrote: > > On Thu, Oct 20, 2022 at 04:01:11PM -0400, Stefan Hajnoczi wrote: > > > On Thu, Oct 20, 2022 at 05:10:13PM +0800, Ming Lei wrote: > > > &

Re: [Bug] double ->queue_rq() because of timeout in ->queue_rq()

2022-10-21 Thread Ming Lei
On Fri, Oct 21, 2022 at 02:33:21PM -0400, David Jeffery wrote: > On Fri, Oct 21, 2022 at 11:22 AM Ming Lei wrote: > > > > On Fri, Oct 21, 2022 at 08:32:31AM -0600, Keith Busch wrote: > > > > > > I agree with your idea that this is a lower level driver responsibi

Re: [Bug] double ->queue_rq() because of timeout in ->queue_rq()

2022-10-21 Thread Ming Lei
On Fri, Oct 21, 2022 at 08:32:31AM -0600, Keith Busch wrote: > On Thu, Oct 20, 2022 at 05:10:13PM +0800, Ming Lei wrote: > > @@ -1593,10 +1598,17 @@ static void blk_mq_timeout_work(struct work_struct > > *work) > > if (!percpu_ref_tryget(>q_usage_counter)

Re: [Bug] double ->queue_rq() because of timeout in ->queue_rq()

2022-10-20 Thread Ming Lei
On Thu, Oct 20, 2022 at 04:01:11PM -0400, Stefan Hajnoczi wrote: > On Thu, Oct 20, 2022 at 05:10:13PM +0800, Ming Lei wrote: > > Hi, > > > > David Jeffery found one double ->queue_rq() issue, so far it can > > be triggered in the following two cases: > >

Re: [Bug] double ->queue_rq() because of timeout in ->queue_rq()

2022-10-20 Thread Ming Lei
On Thu, Oct 20, 2022 at 01:26:48PM -0700, Bart Van Assche wrote: > On 10/20/22 02:10, Ming Lei wrote: > > [ ... ] > > Hi Ming, > > Fixing this in the block layer seems fine to me. A few comments: > > > + /* Before walking tags, we must ensure any submit started

[Bug] double ->queue_rq() because of timeout in ->queue_rq()

2022-10-20 Thread Ming Lei
Hi, David Jeffery found one double ->queue_rq() issue, so far it can be triggered in the following two cases: 1) scsi driver in guest kernel - the story could be long vmexit latency or long preempt latency of vCPU pthread, then IO req is timed out before queuing the request to hardware but

Re: ublk-qcow2: ublk-qcow2 is available

2022-10-12 Thread Ming Lei
On Wed, Oct 12, 2022 at 10:15:28AM -0400, Stefan Hajnoczi wrote: > On Thu, 6 Oct 2022 at 06:14, Richard W.M. Jones wrote: > > > > On Tue, Oct 04, 2022 at 09:53:32AM -0400, Stefan Hajnoczi wrote: > > > qemu-nbd doesn't use io_uring to handle the backend IO, > > > > Would this be fixed by your (not

Re: ublk-qcow2: ublk-qcow2 is available

2022-10-07 Thread Ming Lei
On Fri, Oct 07, 2022 at 07:21:51PM +0800, Yongji Xie wrote: > On Fri, Oct 7, 2022 at 6:51 PM Ming Lei wrote: > > > > On Fri, Oct 07, 2022 at 06:04:29PM +0800, Yongji Xie wrote: > > > On Thu, Oct 6, 2022 at 7:24 PM Ming Lei wrote: > > > > > > > >

Re: ublk-qcow2: ublk-qcow2 is available

2022-10-07 Thread Ming Lei
On Thu, Oct 06, 2022 at 02:29:55PM -0400, Stefan Hajnoczi wrote: > On Thu, Oct 06, 2022 at 11:09:48PM +0800, Ming Lei wrote: > > On Thu, Oct 06, 2022 at 09:59:40AM -0400, Stefan Hajnoczi wrote: > > > On Thu, Oct 06, 2022 at 06:26:15PM +0800, Ming Lei wrote: > > > >

Re: ublk-qcow2: ublk-qcow2 is available

2022-10-07 Thread Ming Lei
On Fri, Oct 07, 2022 at 06:04:29PM +0800, Yongji Xie wrote: > On Thu, Oct 6, 2022 at 7:24 PM Ming Lei wrote: > > > > On Wed, Oct 05, 2022 at 08:21:45AM -0400, Stefan Hajnoczi wrote: > > > On Wed, 5 Oct 2022 at 00:19, Ming Lei wrote: > > > > > > &g

Re: ublk-qcow2: ublk-qcow2 is available

2022-10-06 Thread Ming Lei
On Thu, Oct 06, 2022 at 09:59:40AM -0400, Stefan Hajnoczi wrote: > On Thu, Oct 06, 2022 at 06:26:15PM +0800, Ming Lei wrote: > > On Wed, Oct 05, 2022 at 11:11:32AM -0400, Stefan Hajnoczi wrote: > > > On Tue, Oct 04, 2022 at 01:57:50AM +0200, Denis V. Lunev wrote: > > >

Re: ublk-qcow2: ublk-qcow2 is available

2022-10-06 Thread Ming Lei
On Wed, Oct 05, 2022 at 08:21:45AM -0400, Stefan Hajnoczi wrote: > On Wed, 5 Oct 2022 at 00:19, Ming Lei wrote: > > > > On Tue, Oct 04, 2022 at 09:53:32AM -0400, Stefan Hajnoczi wrote: > > > On Tue, 4 Oct 2022 at 05:44, Ming Lei wrote: > > > > > > &g

Re: ublk-qcow2: ublk-qcow2 is available

2022-10-06 Thread Ming Lei
On Wed, Oct 05, 2022 at 11:11:32AM -0400, Stefan Hajnoczi wrote: > On Tue, Oct 04, 2022 at 01:57:50AM +0200, Denis V. Lunev wrote: > > On 10/3/22 21:53, Stefan Hajnoczi wrote: > > > On Fri, Sep 30, 2022 at 05:24:11PM +0800, Ming Lei wrote: > > > > ublk-qcow2 is ava

  1   2   3   4   5   6   7   8   9   10   >