To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62467 Issue #:|62467 Summary:|don't fork 'date' a lot ... Component:|tools Version:|680m156 Platform:|All URL:| OS/Version:|All Status:|NEW Status whiteboard:| Keywords:| Resolution:| Issue type:|PATCH Priority:|P3 Subcomponent:|code Assigned to:|mh Reported by:|mmeeks
------- Additional comments from [EMAIL PROTECTED] Thu Feb 23 04:03:25 -0800 2006 ------- So - everyone that includes settings.mk [~every makefile.mk] forks 'date' - which calculates a date - that (as far as we can tell) is never used. The obvious patch removes it: --- solenv/inc/settings.mk 10 Feb 2006 12:08:47 -0000 1.185.36.1 +++ solenv/inc/settings.mk 23 Feb 2006 12:30:59 -0000 @@ -932,15 +932,6 @@ LIB:=$(LB);$(SLB);$(ILIB) CPUNAME=CPUNAME_HAS_TO_BE_SET_IN_ENVIRONMENT .ENDIF -.IF "$(GUI)"=="UNX" || "$(USE_SHELL)"!="4nt" -DATESTRING:=$(shell date +%d%m%Y) -.ELSE # "$(GUI)"=="UNX" || "$(USE_SHELL)"!="4nt" -#can't override 4nt internal date to use date.exe :-( -DATESTRING:=$(shell +echo [EMAIL PROTECTED]@LEN[%_DAY%]==1,0%_DAY%,[EMAIL PROTECTED]@LEN[%_MONTH%]==1,0%_MONTH%,%_MONTH%]%_YEAR%) -.ENDIF # "$(GUI)"=="UNX" || "$(USE_SHELL)"!="4nt" -SCPDEFS+=-DSCP_DATESTRING=$(DATESTRING) - - .IF "$(USE_STLP_DEBUG)" != "" SCPCDEFS+=-D_STLP_DEBUG .ENDIF should accelerate the win32 build where forking is substantially slower, though Unix too presumably. Of course, it's possible Sun uses this SCPDEF somewhere in it's own scp2 ? either way it should be localised to near where that is necessary, surely ? --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
