[Alsa-devel] useless code in alsa-lib

2002-01-31 Thread Kyle Centers
Hi. I was reading through some code, and a came across what looks like an unnecessary if statement. In alsa-lib/src/pcm/pcm_params.c. The 7th line in the _snd_pcm_hw_param_set_min function reads: if(val > 0) A quick look at val's definition, in the function header, reveals that it's an un

Re: [Alsa-devel] Suggestion for the alsa-lib API

2002-01-28 Thread Kyle Centers
state that NONBLOCK and ASYNC are flags, and not mode numbers. Sorry bout that :-) Kyle C. > On Mon, 28 Jan 2002, Kyle Centers wrote: > > > Hi. > > > > I've been playing around with the asound library for a while now, and > > there's someting tha

[Alsa-devel] Suggestion for the alsa-lib API

2002-01-27 Thread Kyle Centers
Hi. I've been playing around with the asound library for a while now, and there's someting that really gets under my skin. The snd_pcm_open function, requires an open mode parameter, which, according to the documentation, defaults to blocking mode, but can be set to SND_PCM_NONBLOCK, or SND_P

[Alsa-devel] ugly code in snd_eku10k1_probe

2001-12-06 Thread Kyle Centers
Hi Still nit-picking, but the following code is just ugly, and I cannot see any reason for writing it this way. From card_emu10k1.c (and a few other files in card/, as a quick look shows), the snd_emu10k1_probe(...), starting at line 97: for ( ; dev < SNDRV_CARDS; dev++) { if (!snd_ena

[Alsa-devel] stupid question

2001-12-05 Thread Kyle Centers
I hate to be nit picky, but I have been trying to figure something out, and am at a complete loss. In alsa-drivers, the file card-emu10k1.c, line 79 or there about reads: static struct pci_device_id snd_emu10k1_ids[] __devinitdata = { After an hour of searching, I finally discovered that __dev

Re: [Alsa-devel] bug in alsa-lib

2001-12-02 Thread Kyle Centers
-Original Message- From: Jaroslav Kysela <[EMAIL PROTECTED]> Date: Sat, 1 Dec 2001 19:33:55 +0100 (CET) To: Kyle Centers <[EMAIL PROTECTED]> Subject: Re: [Alsa-devel] bug in alsa-lib > On Sun, 2 Dec 2001, Kyle Centers wrote: > > > Hi! > > > > I

[Alsa-devel] bug in alsa-lib

2001-12-01 Thread Kyle Centers
ad the asound library. Now, the error is gone (the first one. I havent' gotten to the second, although I suspect it is similar). Anyone know how to fix ths properly? Kyle Centers. -- ___ Sign-up for your own FREE Personalized E-mail at Mail.