[Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-02-29 Thread Russell King
This is the first shot at this - I've tested it on ARM, covering both ISA ALSA devices on a PCI machine, and driver model devices on a non- PCI, non-ISA machine. However, it needs more testing. Can people on alsa-devel please test these patches. This patch adds support for the generic device/dri

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-01 Thread Takashi Iwai
Hi, At Sun, 29 Feb 2004 22:38:20 +, Russell King wrote: > > This is the first shot at this - I've tested it on ARM, covering both > ISA ALSA devices on a PCI machine, and driver model devices on a non- > PCI, non-ISA machine. However, it needs more testing. Can people > on alsa-devel please

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-01 Thread Jaroslav Kysela
On Mon, 1 Mar 2004, Takashi Iwai wrote: > i also think that we can split pre-allocate stuffs and initialization > stuffs to simplify. that is, we provide the initializer > snd_pcm_lib_set_dma_type(pcm, SND_DMA_PCI, ...); > or somethine like that. and call a single function, > snd_pcm_lib_p

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-01 Thread Russell King
On Mon, Mar 01, 2004 at 04:41:00PM +0100, Takashi Iwai wrote: > At Sun, 29 Feb 2004 22:38:20 +, > Russell King wrote: > > > > This is the first shot at this - I've tested it on ARM, covering both > > ISA ALSA devices on a PCI machine, and driver model devices on a non- > > PCI, non-ISA machine

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-01 Thread Takashi Iwai
At Mon, 1 Mar 2004 17:45:17 +, Russell King wrote: > > On Mon, Mar 01, 2004 at 04:41:00PM +0100, Takashi Iwai wrote: > > At Sun, 29 Feb 2004 22:38:20 +, > > Russell King wrote: > > > > > > This is the first shot at this - I've tested it on ARM, covering both > > > ISA ALSA devices on a PC

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-01 Thread Russell King
On Mon, Mar 01, 2004 at 06:51:56PM +0100, Takashi Iwai wrote: > a small concern about GFP_KERNEL is that i experienced the stall when > the kernel tried to allocate large continuous pages with GFP_KERNEL, > e.g. modprobe stops infinitely in the module init phase (and you > cannot even interrupt tha

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-01 Thread Takashi Iwai
At Mon, 1 Mar 2004 18:22:24 +, Russell King wrote: > > On Mon, Mar 01, 2004 at 06:51:56PM +0100, Takashi Iwai wrote: > > a small concern about GFP_KERNEL is that i experienced the stall when > > the kernel tried to allocate large continuous pages with GFP_KERNEL, > > e.g. modprobe stops infini

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-01 Thread Takashi Iwai
At Mon, 01 Mar 2004 19:34:57 +0100, I wrote: > > at the initialization. when __get_free_pages() for 256MB with > GFP_KERNEL is called, it goes to sleep and never gets back. additional note: 256MB might be wrong but anyway it was a large number. the driver tries to allocate as large buffers as p

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-02 Thread Takashi Iwai
At Mon, 01 Mar 2004 18:51:56 +0100, I wrote: > > At Mon, 1 Mar 2004 17:45:17 +, > Russell King wrote: > > > > On Mon, Mar 01, 2004 at 04:41:00PM +0100, Takashi Iwai wrote: > > > At Sun, 29 Feb 2004 22:38:20 +, > > > Russell King wrote: > > > > > > > > This is the first shot at this - I'v

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-02 Thread Russell King
On Tue, Mar 02, 2004 at 03:09:15PM +0100, Takashi Iwai wrote: > At Mon, 01 Mar 2004 18:51:56 +0100, > I wrote: > > ah, yes, then it's fine. thanks. > > i was too fast to confirm that -- it turned out that this doesn't > help. > > since dma_alloc_coherent() is just a wrapper to pci_alloc_consiste

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-02 Thread Takashi Iwai
At Tue, 2 Mar 2004 14:26:32 +, Russell King wrote: > > I, therefore, suggest that you're not looking at a 2.6.3 kernel. This > was changed from pci_alloc_consistent to dma_alloc_coherent on 22 Dec, > and was modified to take the GFP flags on 13 Jan. > > dma_alloc_coherent() is therefore not

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-02 Thread Russell King
On Tue, Mar 02, 2004 at 03:38:28PM +0100, Takashi Iwai wrote: > BTW, there are some typos in your patches, and missing replacement of > PCI -> DEV dma type. the attached patch should fix. Thanks for finding these - as you can guess, the code didn't get built for x86 when I tested it, neither was

Re: [Alsa-devel] [PATCH] 1/3 Implement generic device DMA mapping support

2004-03-02 Thread Takashi Iwai
At Mon, 01 Mar 2004 19:34:57 +0100, I wrote: > > At Mon, 1 Mar 2004 18:22:24 +, > Russell King wrote: > > > > On Mon, Mar 01, 2004 at 06:51:56PM +0100, Takashi Iwai wrote: > > > a small concern about GFP_KERNEL is that i experienced the stall when > > > the kernel tried to allocate large cont