Re: [Alsa-devel] ugly code in snd_eku10k1_probe

2001-12-11 Thread Jaroslav Kysela
On Tue, 11 Dec 2001, Takashi Iwai wrote: > At Fri, 07 Dec 2001 11:09:54 +0800, > Kyle Centers wrote: > > > > Hi > > > > Still nit-picking, but the following code is just ugly, and I cannot see any >reason for writing it this way. From card_emu10k1.c (and a few other files in card/, >as a quick

Re: [Alsa-devel] ugly code in snd_eku10k1_probe

2001-12-11 Thread Takashi Iwai
At Fri, 07 Dec 2001 11:09:54 +0800, Kyle Centers wrote: > > Hi > > Still nit-picking, but the following code is just ugly, and I cannot see any reason >for writing it this way. From card_emu10k1.c (and a few other files in card/, as a >quick look shows), the snd_emu10k1_probe(...), starting at

[Alsa-devel] ugly code in snd_eku10k1_probe

2001-12-06 Thread Kyle Centers
Hi Still nit-picking, but the following code is just ugly, and I cannot see any reason for writing it this way. From card_emu10k1.c (and a few other files in card/, as a quick look shows), the snd_emu10k1_probe(...), starting at line 97: for ( ; dev < SNDRV_CARDS; dev++) { if (!snd_ena