Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-10 Thread Harsh Gupta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/ --- (Updated Feb. 10, 2013, 1:44 p.m.) Review request for Amarok. Changes

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-10 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/#review27117 --- The ChangeLog entry from v3 seems to be absent in v4... -

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-10 Thread Harsh Gupta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/ --- (Updated Feb. 10, 2013, 7:16 p.m.) Review request for Amarok. Changes

Re: Review Request 108716: FIX Randomize playlist with Ctrl+H

2013-02-10 Thread Harsh Gupta
On Feb. 10, 2013, 4:40 p.m., Matěj Laitl wrote: The ChangeLog entry from v3 seems to be absent in v4... Oops ! I will fix it. - Harsh --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 107473: Changes in processing playlist files

2013-02-10 Thread Bart Cerneels
On Feb. 9, 2013, 12:55 a.m., Matěj Laitl wrote: src/core-impl/playlists/types/file/PlaylistFile.h, lines 71-73 http://git.reviewboard.kde.org/r/107473/diff/5/?file=112906#file112906line71 What is the difference between save() and savePlaylist()? Also, if we don't allow