Re: Review Request 109470: A patch which allows us to distinguish between cached lyrics and lyrics newly downloaded from the internet.

2013-03-28 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109470/#review30013 --- Is there a wish request or any other motivation to implement th

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-03-28 Thread Harsh Gupta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review30021 --- src/EngineController.cpp

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-03-28 Thread Harsh Gupta
> On March 29, 2013, 12:03 a.m., Harsh Gupta wrote: > > src/EngineController.cpp, line 793 > > > > > > How am I suppose to stage changes in a line ( line 791 ) in which a > > variable is first renamed and then ge

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-03-28 Thread Matěj Laitl
> On March 28, 2013, 6:33 p.m., Harsh Gupta wrote: > > src/EngineController.cpp, line 793 > > > > > > How am I suppose to stage changes in a line ( line 791 ) in which a > > variable is first renamed and then get

Looking for a GSoC mentor

2013-03-28 Thread vedant agarwala
Hello, I want to do the project Improving and modularizing tag guessing for this year's Google Summer of Code. For this I need a mentor who can guide me. I have thought about how the project can be implemente

Re: Review Request 109585: FIX UI doesn't say I have to run Moodbar generator manually. (BR 289483)

2013-03-28 Thread Harsh Gupta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109585/ --- (Updated March 29, 2013, 1:01 a.m.) Review request for Amarok and Myriam S

Re: Review Request 109752: JJ 316128: Handle Data CDs in Amarok

2013-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109752/#review30035 --- This review has been submitted with commit 6dd3e1e190118dd079c

Re: Review Request 109752: JJ 316128: Handle Data CDs in Amarok

2013-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109752/ --- (Updated March 28, 2013, 8:05 p.m.) Status -- This change has been ma

Review Request 109781: JJ 312407 - don't transcode from mp3 to mp3

2013-03-28 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109781/ --- Review request for Amarok. Description --- /***This patch is stil

Re: Review Request 109695: JJ#241066: Added a prepareToQuit() signal to amarokWindowScript

2013-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109695/#review30040 --- This review has been submitted with commit b0c79900429e8987c01

Re: Review Request 109695: JJ#241066: Added a prepareToQuit() signal to amarokWindowScript

2013-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109695/ --- (Updated March 28, 2013, 8:48 p.m.) Status -- This change has been ma

Re: Review Request 107473: Changes in processing playlist files

2013-03-28 Thread Tatjana Gornak
> On March 28, 2013, 12:16 a.m., Matěj Laitl wrote: > > Hmmm, I'm apparently able to update the diff, please disregard the attached > > file. > > > > Please have a look a differences between v11 and v12, most of them are > > style fixes or cleanups, but it also boasts fixes for a couple of sub

Re: Review Request 107473: Changes in processing playlist files

2013-03-28 Thread Matěj Laitl
> On March 28, 2013, 12:16 a.m., Matěj Laitl wrote: > > Hmmm, I'm apparently able to update the diff, please disregard the attached > > file. > > > > Please have a look a differences between v11 and v12, most of them are > > style fixes or cleanups, but it also boasts fixes for a couple of sub