Re: GSoC application review - reimplementing personal metadata importers

2013-04-25 Thread Konrad Zemek
On 25.04.2013 12:34, Matěj Laitl wrote: Oh, nice! Do mention it. I may be stating the obvious, but I felt it needs to be said: Please note that "ideal" code for a typical FLOSS project may be very different from "ideal" code for a programming contest. In Amarok, we try to keep code as simple (t

Re: My GSoC Proposal: MTP Collection rewrite with emphasis on Android device support

2013-04-25 Thread Philipp Schmidt
Am Donnerstag, 25. April 2013, 17:53:16 schrieb Matěj Laitl: > Hi all, > this is a first draft of my GSoC project proposal. I'd be more than happy to > see your comments, remarks, whether something is unclear or maybe where I'm > too verbose. Hi, as the Maintainer of KIO-MTP I have some thoughts.

Re: Review Request 110187: Don't communicate with mysql by env vars and autogenerated files

2013-04-25 Thread Patrick von Reth
> On April 25, 2013, 3:43 p.m., Edward Hades Toroshchin wrote: > > Thanks for the fix. However, this is the approach, we've used originally, > > and it didn't prove very reliable. I think we even went back and forth more > > than once. > > > > So you should really have a look in the history of

My GSoC Proposal: MTP Collection rewrite with emphasis on Android device support

2013-04-25 Thread Matěj Laitl
Hi all, this is a first draft of my GSoC project proposal. I'd be more than happy to see your comments, remarks, whether something is unclear or maybe where I'm too verbose. P.S. to students waiting for review of a patch or GSoC proposal: I've been (pleasurably) busy with real life lately, but

Re: Review Request 110187: Don't communicate with mysql by env vars and autogenerated files

2013-04-25 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110187/#review31576 --- Thanks for the fix. However, this is the approach, we've used o

Review Request 110187: Don't communicate with mysql by env vars and autogenerated files

2013-04-25 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110187/ --- Review request for Amarok. Description --- Don't communicate with mys

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

2013-04-25 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110139/#review31543 --- Nice cleanups, I agree with Edward's comments plus I have one m

Re: GSoC application review - reimplementing personal metadata importers

2013-04-25 Thread Matěj Laitl
On 24. 4. 2013 Konrad Zemek wrote: > First, I added that my application has been discussed over on this > mailing list. I know that several projects highly favor students that > have engaged with the community about their project. Exactly. > Second, I mentioned > that I'm a titled finalist of

Re: Outdated MediaDeviceFramework

2013-04-25 Thread Matěj Laitl
On 25. 4. 2013 Tatjana Gornak wrote: > While working on my gsoc proposal I did some research on Collections > and I am not sure that I understand why MediaDeviceFramework is > outdated (it states in few places, but without mentioning any > particular reason). Maybe there is some additional info som

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

2013-04-25 Thread Konrad Zemek
> On April 25, 2013, 9:27 a.m., Edward Hades Toroshchin wrote: > > Looks good, except for the enums in "switch". I would personally list all > > the missing enum values explicitly. > > > > Thanks! That's actually quite a good point. I'll modify it to list enums explicitly. :-) - Konrad ---

Re: GSoC draft application

2013-04-25 Thread vedant agarwala
Yes Myriam you are right. Sorry for the impatience. I missed the fact that you people must be very busy and in a different time-zone. Thank-you for correcting first timers like me. Sincerely, Vedant. On Thu, Apr 25, 2013 at 2:47 PM, Myriam Schweingruber wrote: > On Thu, Apr 25, 2013 at 6:05 AM,

Re: Can Phonon create "fingerprint" of audio files?

2013-04-25 Thread vedant agarwala
Myriam, I know the function of CUE sheets and what it means to support this feature. Even though I felt it was a long shot, I was hoping phonon supports splitting of the audio file. I wanted to know whether this is possible or not because I want to implement a "drag-and-drop" feature. That is, when

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

2013-04-25 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110139/#review31541 --- Looks good, except for the enums in "switch". I would personall

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

2013-04-25 Thread Matěj Laitl
> On April 24, 2013, 12:47 p.m., Myriam Schweingruber wrote: > > Which exact bugs does that fix? are those reported on http://bugs.kde.org? > > Then please add the "BUG: " handler and "FIXED-IN: 2.8" handler > > to it as well :) > > Konrad Zemek wrote: > None of these bugs are reported in

Re: GSoC draft application

2013-04-25 Thread Myriam Schweingruber
On Thu, Apr 25, 2013 at 6:05 AM, vedant agarwala wrote: > Hello, > Below is the email I sent to amarok-devel but there was no reply. It must've > slipped through. Could you please have a look at my application before I can > submit it. How about having a tiny bit of patience? You only submitted t

Fwd: Can Phonon create "fingerprint" of audio files?

2013-04-25 Thread Myriam Schweingruber
FYI *sigh* -- Forwarded message -- From: Myriam Schweingruber Date: Thu, Apr 25, 2013 at 11:09 AM Subject: Re: Can Phonon create "fingerprint" of audio files? To: "For discussion of multimedia (sound/video) issues under KDE" On Thu, Apr 25, 2013 at 7:17 AM, vedant agarwala wr