Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

> On May 28, 2013, 9:09 p.m., Konrad Zemek wrote: > > src/playlist/PlaylistController.cpp, line 213 > > > > > > I have no idea how did those changes end in my review. I guess I'm not > > yet skilled enough with

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110658/ --- (Updated May 28, 2013, 9:01 p.m.) Review request for Amarok. Description

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110658/#review33325 --- src/playlist/PlaylistController.cpp

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

> On May 28, 2013, 6:43 p.m., Edward Hades Toroshchin wrote: > > src/playlist/PlaylistActions.cpp, line 355 > > > > > > Why not QVector? > > Matěj Laitl wrote: > Well, PlaylistController::moveRows() accepts Q

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

> On May 28, 2013, 6:43 p.m., Edward Hades Toroshchin wrote: > > src/playlist/PlaylistActions.cpp, line 355 > > > > > > Why not QVector? Well, PlaylistController::moveRows() accepts QLists, so you'd have to conve

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110658/#review33315 --- Ship it! Thanks for the patch! Tested it on my box: compiles

Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.

> On May 27, 2013, 3:52 p.m., Matěj Laitl wrote: > > src/playlist/PlaylistController.cpp, line 450 > > > > > > 1. Nice way to checking every item is there just once! ;) > > > > 2. I think that fromItems =