Re: Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

2013-07-02 Thread Anmol Ahuja
> On July 2, 2013, 3:03 p.m., Mark Kretschmann wrote: > > src/scriptengine/AmarokCollectionScript.cpp, line 39 > > > > > > Use the KDE_DEPRECATED macro I was intending the deprecation notification to be more for t

Re: Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

2013-07-02 Thread Anmol Ahuja
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111343/ --- (Updated July 2, 2013, 5:53 p.m.) Review request for Amarok and Mark Krets

Week 2 report. Reimplementing importers.

2013-07-02 Thread Konrad Zemek
Hey everyone, For the past week I had scheduled "implementing the initial test suite for importers", and I'm happy to report that everything went smoothly. Here's a shortlog of commits for the past week (from the most recent): * Implement FastForwardImporter tests: TestFastForwardImporter. *

Re: Review Request 110920: Fight warnings.

2013-07-02 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110920/#review35438 --- Ship it! If it compiles with the const, it cannot hurt, ship i

Re: Review Request 110036: WIP - Simple equalizer scripting

2013-07-02 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110036/#review35437 --- test, ignore - Mark Kretschmann On April 18, 2013, 8:03 a.m.

Re: Review Request 110082: fixes Bug 275821 - JJ: Proper tooltips for Saved Playlists; remove Playlist::description() method

2013-07-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110082/#review35435 --- This review has been submitted with commit 6ef8e597851e8e5638c

Re: Review Request 110934: Adds a Offline Mode to Amarok i.e. fixes Bug 229111

2013-07-02 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110934/ --- (Updated July 2, 2013, 10:29 a.m.) Status -- This change has been dis

Re: Review Request 111038: Fixes the scrolling problem in dynamic playlists i.e. Bug 284214

2013-07-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111038/#review35429 --- This review has been submitted with commit 9dbdb8bde9836f2e17d

Re: Review Request 111038: Fixes the scrolling problem in dynamic playlists i.e. Bug 284214

2013-07-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111038/ --- (Updated July 2, 2013, 10:15 a.m.) Status -- This change has been mar

Re: Review Request 111343: Week 2: Revamping Amarok's Scripting Interface

2013-07-02 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111343/#review35427 --- src/ScriptManager.h