D10819: Fix for Amarok::saveLocation() not setting separator before subdirectory.

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY Simple patch. Fixes Amarok using wrong local data dirs. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL htt

D10819: Fix for Amarok::saveLocation() not setting separator before subdirectory.

markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D10819 To: malteveerman, #amarok, markey Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis,

D10819: Fix for Amarok::saveLocation() not setting separator before subdirectory.

markey added a comment. Hey Malte, please fix your real name for the next patch. KDE commit hook rejects this: remote: Audit failure - Commit 9ecce24b6dfe11a2c67a395d5826f6a7f4296749 - Non-full name: maldela REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.k

D10819: Fix for Amarok::saveLocation() not setting separator before subdirectory.

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10819 To: malteveerman, #amarok, markey Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber

D10831: Ported some services to Qt5/KF5

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This patch ports the ampache, magnatune and opmldirectory services. I've laid some groundwork for the other services

D10831: Ported some services to Qt5/KF5

malteveerman added a comment. I've created this revision against the wrong branch. How do I fix that? REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10831 To: malteveerman, #amarok Cc: #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktim

D10831: Ported some services to Qt5/KF5

asturmlechner added a comment. In D10831#213580 , @malteveerman wrote: > I've created this revision against the wrong branch. How do I fix that? If this is one commit, you switch to `kf5` branch and cherry-pick this commit. Alternatively

D10831: Ported some services to Qt5/KF5

asturmlechner added a comment. > gpodder service using mygpo-qt, which is still in a qt4 world Even though it may not be available on every distro out there yet (for lack of consumers), `libmygpo-qt-1.0.9` supports Qt5 already. At least clementine also makes use of it, but only in their

D10831: Ported some services to Qt5/KF5

malteveerman updated this revision to Diff 28020. malteveerman edited the summary of this revision. malteveerman added a comment. Fixed branch and commit author REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10831?vs=28016&id=28020 BRANCH kf5 REVISION DE

D10831: Ported some services to Qt5/KF5

malteveerman added a comment. In D10831#213608 , @asturmlechner wrote: > > gpodder service using mygpo-qt, which is still in a qt4 world > > Even though it may not be available on every distro out there yet (for lack of consumers), `libmygpo

D10831: Ported some services to Qt5/KF5

asturmlechner added a comment. libmygpo-qt provides a pkgconfig file `libmygpo-qt5.pc` you can check for using `pkg_check_modules` REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10831 To: malteveerman, #amarok Cc: asturmlechner, #amarok, paul, yaohanchen, malteveerm

Re: D10831: Ported some services to Qt5/KF5

Hi, On 2018-02-25 14:05, Andreas Sturmlechner wrote: > Even though it may not be available on every distro out there yet (for lack > of consumers), `libmygpo-qt-1.0.9` supports Qt5 already. At least clementine > also makes use of it, but only in their qt5 branch. Qt5 is supported and I think

D10831: Ported some services to Qt5/KF5

malteveerman updated this revision to Diff 28042. malteveerman added a comment. - cleaned up CMakeLists.txt a bit - Reactivated gpodder service. Build support depends on this pr, though: https://github.com/gpodder/libmygpo-qt/pull/12 REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE htt

D10831: Ported some services to Qt5/KF5

malteveerman edited the summary of this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10831 To: malteveerman, #amarok Cc: asturmlechner, #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, schweingruber

D10831: Ported some services to Qt5/KF5

malteveerman updated this revision to Diff 28043. malteveerman added a comment. - cleaned up CMakeLists.txt a bit - Reactivated gpodder service. Build support depends on this pr, though: https://github.com/gpodder/libmygpo-qt/pull/12 REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE htt