Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-22 Thread Andy Coder
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100607/#review1595 --- Ship it! The actual objects that turned up/JSON that got produc

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-22 Thread Stefan Derkits
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100607/ --- (Updated Feb. 22, 2011, 5:06 p.m.) Review request for Amarok. Changes --

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-22 Thread Stefan Derkits
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100607/ --- (Updated Feb. 22, 2011, 4:30 p.m.) Review request for Amarok. Changes --

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-22 Thread Stefan Derkits
> On Feb. 8, 2011, 2:36 a.m., Andy Coder wrote: > > This seems reasonable enough to me. Especially since JsonQt was used > > because it was already hanging around in the source tree, and availability > > of friendly JSON libraries in package repos wasn't what it is today. > > However, if the

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-22 Thread Stefan Derkits
> On Feb. 8, 2011, 2:36 a.m., Andy Coder wrote: > > This seems reasonable enough to me. Especially since JsonQt was used > > because it was already hanging around in the source tree, and availability > > of friendly JSON libraries in package repos wasn't what it is today. > > However, if the

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-21 Thread Andy Coder
> On Feb. 8, 2011, 2:36 a.m., Andy Coder wrote: > > This seems reasonable enough to me. Especially since JsonQt was used > > because it was already hanging around in the source tree, and availability > > of friendly JSON libraries in package repos wasn't what it is today. > > However, if the

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-20 Thread Stefan Derkits
> On Feb. 8, 2011, 2:36 a.m., Andy Coder wrote: > > This seems reasonable enough to me. Especially since JsonQt was used > > because it was already hanging around in the source tree, and availability > > of friendly JSON libraries in package repos wasn't what it is today. > > However, if the

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-20 Thread Stefan Derkits
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100607/ --- (Updated Feb. 20, 2011, 10:51 p.m.) Review request for Amarok. Changes -

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-08 Thread Patrick von Reth
On Windows we have to package every dependency including 3party lib our salve. And AFAIK we already build/package QJson :) On 8 February 2011 17:50, Stefan Derkits wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100607/ > > On February 8

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-08 Thread Leo Franchi
> On Feb. 8, 2011, 2:36 a.m., Andy Coder wrote: > > This seems reasonable enough to me. Especially since JsonQt was used > > because it was already hanging around in the source tree, and availability > > of friendly JSON libraries in package repos wasn't what it is today. > > However, if the

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-08 Thread Stefan Derkits
> On Feb. 8, 2011, 2:36 a.m., Andy Coder wrote: > > This seems reasonable enough to me. Especially since JsonQt was used > > because it was already hanging around in the source tree, and availability > > of friendly JSON libraries in package repos wasn't what it is today. > > However, if the

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-08 Thread Andy Coder
> On Feb. 8, 2011, 2:36 a.m., Andy Coder wrote: > > This seems reasonable enough to me. Especially since JsonQt was used > > because it was already hanging around in the source tree, and availability > > of friendly JSON libraries in package repos wasn't what it is today. > > However, if the

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-08 Thread Stefan Derkits
> On Feb. 8, 2011, 2:36 a.m., Andy Coder wrote: > > This seems reasonable enough to me. Especially since JsonQt was used > > because it was already hanging around in the source tree, and availability > > of friendly JSON libraries in package repos wasn't what it is today. > > However, if the

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-07 Thread Andy Coder
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100607/#review1304 --- This seems reasonable enough to me. Especially since JsonQt was

Review Request: Port PlaydarCollection to QJson instead of JsonQt

2011-02-07 Thread Stefan Derkits
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100607/ --- Review request for Amarok. Summary --- What I did: -) added cmake/mod