Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-06-10 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated June 10, 2013, 11:55 a.m.) Status -- This change has been ma

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-30 Thread Matěj Laitl
> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukCollection.cpp, lines > > 40-41 > > > > > > Okay, personal preferences aside, I'm sure that consistency with

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-30 Thread Edward Hades Toroshchin
> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukCollection.cpp, lines > > 40-41 > > > > > > Okay, personal preferences aside, I'm sure that consistency with

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-30 Thread Matěj Laitl
> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukCollection.cpp, lines > > 40-41 > > > > > > Okay, personal preferences aside, I'm sure that consistency with

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-30 Thread Edward Hades Toroshchin
> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp, line 428 > > > > > > QScopedPointer please > > Matěj Laitl wrote: > Dropped? Why? Dropp

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-30 Thread Matěj Laitl
> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukCollection.cpp, lines > > 40-41 > > > > > > Okay, personal preferences aside, I'm sure that consistency with

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-30 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated May 30, 2013, 7:12 p.m.) Review request for Amarok and Vishesh Ha

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-30 Thread Edward Hades Toroshchin
> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > Very good work, Edward! I especially like how elegantly is the nepomuk > > query constructed and nicely separated classes that participate on that. > > > > Sorry for being a bit of bitchy with code style, but please have in mind > > that by

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-30 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated May 30, 2013, 6:44 p.m.) Review request for Amarok and Vishesh Ha

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-30 Thread Edward Hades Toroshchin
> On May 30, 2013, 2:09 p.m., Matěj Laitl wrote: > > src/core-impl/collections/nepomukcollection/NepomukCollection.cpp, lines > > 40-41 > > > > > > Okay, personal preferences aside, I'm sure that consistency with

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-21 Thread Edward Hades Toroshchin
> On May 20, 2013, 8:14 a.m., Mark Kretschmann wrote: > > Got this crash on application exit: > > > > Thread 1 (Thread 0x7f7df7f257c0 (LWP 17722)): > > [KCrash Handler] > > #6 0x7f7d782e6d16 in ?? () from /usr/lib/libnepomukcore.so.4abi1 > > #7 0x7f7d782faced in Nepomuk2::Resource::det

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-20 Thread Edward Hades Toroshchin
> On May 20, 2013, 8:14 a.m., Mark Kretschmann wrote: > > Got this crash on application exit: > > > > Thread 1 (Thread 0x7f7df7f257c0 (LWP 17722)): > > [KCrash Handler] > > #6 0x7f7d782e6d16 in ?? () from /usr/lib/libnepomukcore.so.4abi1 > > #7 0x7f7d782faced in Nepomuk2::Resource::det

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-20 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated May 20, 2013, 10:57 a.m.) Review request for Amarok and Vishesh H

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-20 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/#review32796 --- Got this crash on application exit: Thread 1 (Thread 0x7f7df7f

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-18 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated May 18, 2013, 8:06 p.m.) Review request for Amarok and Vishesh Ha

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-18 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated May 18, 2013, 5:01 p.m.) Review request for Amarok and Vishesh Ha

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-18 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated May 18, 2013, 4:29 p.m.) Review request for Amarok and Vishesh Ha

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-05-18 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated May 18, 2013, 1:36 p.m.) Review request for Amarok and Vishesh Ha

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-02-11 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated Feb. 11, 2013, 9 p.m.) Review request for Amarok and Vishesh Hand

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-02-04 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/#review26604 --- So, I understand parts of it, and other parts I still need to l

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-02-03 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated Feb. 3, 2013, 7:45 p.m.) Review request for Amarok and Vishesh Ha

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-02-02 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated Feb. 2, 2013, 10:26 p.m.) Review request for Amarok and Vishesh H

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-02-02 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated Feb. 2, 2013, 10:24 p.m.) Review request for Amarok and Vishesh H

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-02-02 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated Feb. 2, 2013, 7:17 p.m.) Review request for Amarok and Vishesh Ha

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-02-02 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated Feb. 2, 2013, 4:25 p.m.) Review request for Amarok and Vishesh Ha

Re: Review Request 108717: nepomuk: implement custom QueryMaker

2013-02-02 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108717/ --- (Updated Feb. 2, 2013, 3:46 p.m.) Review request for Amarok and Vishesh Ha