Re: Review Request 111804: Fix a crash on startup

2013-08-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/#review36909 --- This review has been submitted with commit 02be4ec8e8fe5c4ebd2

Re: Review Request 111804: Fix a crash on startup

2013-08-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/ --- (Updated Aug. 1, 2013, 12:11 p.m.) Status -- This change has been mar

Re: Review Request 111804: Fix a crash on startup

2013-08-01 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/#review36908 --- Ship it! but fix the whitespace error first. - Edward Hades T

Re: Review Request 111804: Fix a crash on startup

2013-07-31 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/#review36868 --- Ship it! Ship It! - Konrad Zemek On July 31, 2013, 11:59 a.

Re: Review Request 111804: Fix a crash on startup

2013-07-31 Thread Fabian Kosmale
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/ --- (Updated July 31, 2013, 11:59 a.m.) Review request for Amarok. Changes -

Re: Review Request 111804: Fix a crash on startup

2013-07-31 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/#review36867 --- src/playlist/PlaylistSortWidget.cpp

Re: Review Request 111804: Fix a crash on startup

2013-07-31 Thread Fabian Kosmale
> On July 30, 2013, 10:04 p.m., Edward Hades Toroshchin wrote: > > src/playlist/PlaylistSortWidget.cpp, line 73 > > > > > > If the sort token has neither "asc" nor "des" suffix, it won't be added > > to the sort a

Re: Review Request 111804: Fix a crash on startup

2013-07-31 Thread Fabian Kosmale
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/ --- (Updated July 31, 2013, 9:47 a.m.) Review request for Amarok. Changes --

Re: Review Request 111804: Fix a crash on startup

2013-07-30 Thread Konrad Zemek
> On July 31, 2013, 1:14 a.m., Konrad Zemek wrote: > > src/playlist/PlaylistSortWidget.cpp, line 73 > > > > > > There will still be a crash if the sort level is saved as, say, > > "adwawd_asc". The solution would

Re: Review Request 111804: Fix a crash on startup

2013-07-30 Thread Konrad Zemek
> On July 30, 2013, 10:04 p.m., Edward Hades Toroshchin wrote: > > src/playlist/PlaylistSortWidget.cpp, line 73 > > > > > > If the sort token has neither "asc" nor "des" suffix, it won't be added > > to the sort a

Re: Review Request 111804: Fix a crash on startup

2013-07-30 Thread Edward Hades Toroshchin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/#review36847 --- Thank you very much for the patch. I understand the problem, h

Review Request 111804: Fix a crash on startup

2013-07-30 Thread Fabian Kosmale
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111804/ --- Review request for Amarok. Description --- Without this patch, Amarok