Re: amavisd-new regression suite

2016-03-14 Thread Benning, Markus
On 2016-03-14 04:06, C.J. Collier wrote: I'm doing a quick review of the amavisd source here: http://anonscm.debian.org/cgit/amavisd-new/pkg-amavisd-new.git/tree/amavisd First of all, is there an online repository upstream of this one that I should be using instead? The only thing I could find

Re: amavisd-new regression suite

2016-03-14 Thread C.J. Collier
Thank you Markus, I was just minutes ago looking on the CPAN for amavis-related modules and came across your name. I'd never seen a collectd plugin before :-) I saw your unofficial repository on github as well when I was looking for online repos but moved on when I saw that it is unofficial. I

Re: Use X-Amavis-Alert header to influence Spam Assassin Scoring

2016-03-14 Thread Josh Hamell
On 3/8/2016 3:00 AM, amavis-users-requ...@amavis.org wrote: > On 7 Mar 2016, at 12:13, Josh Hamell wrote: >> > >> > Amavis headers are injected in immediately before delivery, and >> > therefore aren't available for SA to analyze. > This is my understanding, amavis headers aren't there until afte

Re: Use X-Amavis-Alert header to influence Spam Assassin Scoring

2016-03-14 Thread C.J. Collier
I think that re-factoring amavis into smaller chunks so that spamassassin can «use» those modules will reduce the duplicated code, if not the duplicated effort. What is the benefit of having all of the 71 packages in the same file? This will make it difficult to write and exercise unit tests. If