Re: [PATCH 1/7] amdkfd: Tidy up kfd_generate_gpu_id() uint64_t bitshift unpack

2016-09-10 Thread Oded Gabbay
On Sat, Sep 10, 2016 at 4:31 AM, Edward O'Callaghan wrote: > Dereference the one time and unpack the lower and upper 32bit > portions with the proper kernel helper macros. > > Signed-off-by: Edward O'Callaghan > Reviewed-by: Oded Gabbay > --- > drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 8

Re: [PATCH 3/7] amdkfd: Add some missing memset zero'ing in queue init func

2016-09-10 Thread Oded Gabbay
On Sat, Sep 10, 2016 at 4:31 AM, Edward O'Callaghan wrote: > Signed-off-by: Edward O'Callaghan > Reviewed-by: Oded Gabbay > --- > drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c > b/drivers/

Re: [PATCH 4/7] drm/amdkfd: Make kfd_lookup_process_by_pasid() well defined

2016-09-10 Thread Oded Gabbay
On Sat, Sep 10, 2016 at 4:31 AM, Edward O'Callaghan wrote: > Ensure we return a NULL on the fail branch so that the call > site may BUG_ON() it. > > Signed-off-by: Edward O'Callaghan > --- > drivers/gpu/drm/amd/amdkfd/kfd_process.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

Re: [PATCH 5/7] drm/amdkfd: Remove duplicate pqm_uninit()

2016-09-10 Thread Oded Gabbay
On Sat, Sep 10, 2016 at 4:31 AM, Edward O'Callaghan wrote: > pqm_uninit() will be called in kfd_process_notifier_release(), which > is when the process exits. Calling it in kfd_unbind_process_from_device() > is duplicate and in fact incorrect, because pqm should not be > uninitalized as long as th

Re: [PATCH 4/7] drm/amdkfd: Make kfd_lookup_process_by_pasid() well defined

2016-09-10 Thread Edward O'Callaghan
On 09/11/2016 01:55 AM, Oded Gabbay wrote: > On Sat, Sep 10, 2016 at 4:31 AM, Edward O'Callaghan > wrote: >> Ensure we return a NULL on the fail branch so that the call >> site may BUG_ON() it. >> >> Signed-off-by: Edward O'Callaghan >> --- >> drivers/gpu/drm/amd/amdkfd/kfd_process.c | 5 +++--

Re: [PATCH 6/6] drm: Add DRM_MODE_PAGE_FLIP_TARGET_ABSOLUTE/RELATIVE flags v2

2016-09-10 Thread Pekka Paalanen
On Tue, 16 Aug 2016 10:46:13 +0900 Michel Dänzer wrote: > On 16/08/16 10:32 AM, Mario Kleiner wrote: > > Cc'ing Daniel Stone and Pekka Paalanen, because this relates to wayland. > > > > Wrt. having a new pageflip parameter struct, i wonder if it wouldn't > > make sense to then already prepare so

Re: [PATCH v3] drm: modify drm_global_item_ref to avoid two times of writing ref->object

2016-09-10 Thread Chris Wilson
On Thu, Sep 08, 2016 at 09:43:52AM +0200, Christian König wrote: > Am 08.09.2016 um 09:35 schrieb Chris Wilson: > >On Thu, Sep 08, 2016 at 03:22:48PM +0800, Huang Rui wrote: > >>On Thu, Sep 08, 2016 at 02:36:06PM +0800, Chris Wilson wrote: > >>>On Wed, Sep 07, 2016 at 10:07:57PM -0400, Huang Rui wr

Re: [PATCH v3] drm: modify drm_global_item_ref to avoid two times of writing ref->object

2016-09-10 Thread Chris Wilson
On Wed, Sep 07, 2016 at 10:07:57PM -0400, Huang Rui wrote: > In previous drm_global_item_ref, there are two times of writing > ref->object if item->refcount is 0. So this patch does a minor update > to put alloc and init ref firstly, and then to modify the item of glob > array. Use "else" to avoid

Re: [PATCH v3] drm: modify drm_global_item_ref to avoid two times of writing ref->object

2016-09-10 Thread Chris Wilson
On Thu, Sep 08, 2016 at 03:22:48PM +0800, Huang Rui wrote: > On Thu, Sep 08, 2016 at 02:36:06PM +0800, Chris Wilson wrote: > > On Wed, Sep 07, 2016 at 10:07:57PM -0400, Huang Rui wrote: > > > In previous drm_global_item_ref, there are two times of writing > > > ref->object if item->refcount is 0. S

Re: [PATCH 1/2] drm/ttm: remove unused placement flags

2016-09-10 Thread Emil Velikov
On 9 September 2016 at 15:30, Christian König wrote: > Am 09.09.2016 um 15:54 schrieb Emil Velikov: >> >> On 9 September 2016 at 12:24, Christian König >> wrote: >>> >>> Hi Hawking, >>> Removing the flag will make ttm_mem_type_from_place skip counting the corresponding placement and thu

Re: [PATCH 1/2] drm/ttm: remove unused placement flags

2016-09-10 Thread Emil Velikov
On 9 September 2016 at 12:24, Christian König wrote: > Hi Hawking, > >> Removing the flag will make ttm_mem_type_from_place skip counting the >> corresponding placement and thus have impact on mem region create and bo >> movement. > > And that is exactly the reason why I want to remove the unused