Re: [PATCH 1/8] drm/amdgpu: move dpm related definitions to amdgpu_dpm.h

2016-10-13 Thread Christian König
Am 12.10.2016 um 23:12 schrieb Alex Deucher: No intended functional change. Reviewed-by: Christian König Signed-off-by: Alex Deucher For the newer versions and where still missing in this series the patches are Reviewed-by: Christian König . Christian. --- drivers/gpu/drm/amd/amdgpu/a

Re: [PATCH] drm/amd/amdgpu: Allow broadcast on debugfs read (v2)

2016-10-13 Thread Michel Dänzer
On 13/10/16 12:39 AM, StDenis, Tom wrote: > It comes from amdgpu_query_gpu_info_init() > > > for (i = 0; i < (int)dev->info.num_shader_engines; i++) { > unsigned instance = (i << AMDGPU_INFO_MMR_SE_INDEX_SHIFT) | > (*AMDGPU_INFO_MMR_SH_I

[PATCH xf86-video-ati] Restore location of radeon_set_pixmap_bo call in drmmode_create_bo_pixmap

2016-10-13 Thread Michel Dänzer
From: Michel Dänzer radeon_set_pixmap_bo sets the tiling flags, so it needs to be called before radeon_get_pixmap_tiling_flags. Fixes a regression with EXA and TearFree. Fixes: 8523a733b6a5 ("Propagate failure from radeon_set_pixmap_bo") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=980

RE: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

2016-10-13 Thread Zhu, Rex
Hi all, The attached patches were also for this issue. Disable dpm when rmmod amdgpu. Please help to review. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Zhu, Rex Sent: Wednesday, October 12, 2016 9:45 PM To: Alex Deucher

[PATCH] drm/amd/powerplay: notify smu no display by default.

2016-10-13 Thread Rex Zhu
Change-Id: Id6c2046bedd99f17c23b37e2fbf38975482dbfb8 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c

RE: drm/amd/powerplay: expose max engine and memory clock info for powerplay enabled case

2016-10-13 Thread Quan, Evan
Hi Alex, Thanks for your information. I updated the patch using the amdgpu_dpm_get_sclk/mclk APIs which make the patch much simpler. Regards, Evan From: Deucher, Alexander Sent: Thursday, October 13, 2016 6:04 AM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Zhang, Jerry ; Huan, Alvin ; Qu

[PATCH xf86-video-amdgpu] Enable HW cursor support with PRIME slave output & Xorg > 1.18.99.901

2016-10-13 Thread Michel Dänzer
From: Michel Dänzer Supported since Xorg 1.18.99.2, but buggy until 1.18.99.901. Signed-off-by: Michel Dänzer --- src/drmmode_display.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index fb41975..f291f6d 100644 --- a/src

RE: [PATCH xf86-video-ati] Restore location of radeon_set_pixmap_bo call in drmmode_create_bo_pixmap

2016-10-13 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Thursday, October 13, 2016 3:35 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH xf86-video-ati] Restore location of radeon_set_pixmap_bo > call in drmmode_create

RE: [PATCH xf86-video-amdgpu] Enable HW cursor support with PRIME slave output & Xorg > 1.18.99.901

2016-10-13 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Thursday, October 13, 2016 5:47 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH xf86-video-amdgpu] Enable HW cursor support with PRIME > slave output & Xorg > 1.

[PATCH 2/2] drm/amdgpu/powerplay: implement thermal sensor for CZ/ST

2016-10-13 Thread Alex Deucher
Add missing functionality. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c index b48d00f..4b14f2

[PATCH 1/2] drm/amdgpu/dpm: implement thermal sensor for CZ/ST

2016-10-13 Thread Alex Deucher
Previous code was just a copy/paste from KV. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/cz_dpm.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/cz_dpm.c b/drivers/gpu/drm/amd/amdgpu/cz_dpm.c index f80a083..3c082e14 100644 -

Re: More debugfs entries

2016-10-13 Thread Alex Deucher
On Tue, Oct 11, 2016 at 3:18 PM, Tom St Denis wrote: > Resending the MMIO upgrades for completeness. Christian offered > an ACK but I'd like to see a RB or NAK. > > This also adds a debugfs entry used to read wave data on CZ/VI > platforms (tested on my Carrizo). > > The patch #3 already has a us

Re: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

2016-10-13 Thread Alex Deucher
On Thu, Oct 13, 2016 at 3:45 AM, Zhu, Rex wrote: > Hi all, > > The attached patches were also for this issue. > Disable dpm when rmmod amdgpu. > > Please help to review. Patch 1: +r = adev->ip_blocks[AMD_IP_BLOCK_TYPE_SMC].funcs->hw_fini((void *)adev); +if (r) +DRM_DEBUG("hw_fini

[PATCH] drm/amd/amdgpu: Fix debugfs wave reader

2016-10-13 Thread Tom St Denis
On non VI/CZ platforms it would not free the grbm index lock. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device

Fix lock imbalance in debugfs wave reader

2016-10-13 Thread Tom St Denis
I introduced a lock imbalance in the debugfs wave reader. This patch fixes that. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/radeon/si_dpm: Limit clocks on HD86xx part

2016-10-13 Thread Tom St Denis
Limit clocks on a specific HD86xx part to avoid crashes (while awaiting an appropriate PP fix). Signed-off-by: Tom St Denis --- drivers/gpu/drm/radeon/si_dpm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c index 89bdf2

mm: fix cache mode tracking in vm_insert_mixed() breaks AMDGPU [was: Re: Latest testing with drm-next-4.9-wip and latest LLVM/mesa stack - Regression in PowerPlay/DPM on CIK?]

2016-10-13 Thread Shawn Starr
Hello AMD folks, I have discovered a problem in Linus master that affects AMDGPU, nobody would notice this in drm-next-4.9-wip since its not in this repo. git bisect start # good: [c8d2bc9bc39ebea8437fd974fdbc21847bb897a3] Linux 4.8 git bisect good c8d2bc9bc39ebea8437fd974fdbc21847bb897a3 # bad

RE: [PATCH] drm/radeon/si_dpm: Limit clocks on HD86xx part

2016-10-13 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Thursday, October 13, 2016 12:42 PM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH] drm/radeon/si_dpm: Limit clocks on HD86xx part > > Limit clo

[PATCH] drm/amdgpu: fix amdgpu_need_full_reset

2016-10-13 Thread Alex Deucher
IP types are not an index. Each asic may have number and type of IPs. Properly check the the type rather than using the type id as an index. Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 20 ++-- 1 file changed, 14 inser

[PATCH] drm/amdgpu: enable virtual dce on SI

2016-10-13 Thread Alex Deucher
Add the proper IP module when requested. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/si.c | 140 ++-- 1 file changed, 136 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c index dc9511c

[PATCH] drm/amdgpu: fix amdgpu_need_full_reset (v2)

2016-10-13 Thread Alex Deucher
IP types are not an index. Each asic may have number and type of IPs. Properly check the the type rather than using the type id as an index. v2: fix all the IPs to not use IP type as an idx as well. Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/amdgpu/amdgpu_d

[PATCH] drm/amdgpu/virtual_dce: move define into source file

2016-10-13 Thread Alex Deucher
It's not used outside the file. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 3 +++ drivers/gpu/drm/amd/amdgpu/dce_virtual.h | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/d

Re: [PATCH] drm/radeon/si_dpm: Limit clocks on HD86xx part

2016-10-13 Thread StDenis, Tom
Hi Alex, No problem I'll submit that tomorrow morning. Cheers, Tom From: Deucher, Alexander Sent: Thursday, October 13, 2016 15:19 To: 'Tom St Denis'; amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: RE: [PATCH] drm/radeon/si_dpm: Limit clocks on HD86x

Re: drm/amd/powerplay: expose max engine and memory clock info for powerplay enabled case

2016-10-13 Thread Alex Deucher
On Thu, Oct 13, 2016 at 4:24 AM, Quan, Evan wrote: > Hi Alex, > > > > Thanks for your information. > > I updated the patch using the amdgpu_dpm_get_sclk/mclk APIs which make the > patch much simpler. > > We can use amdgpu_dpm_get_sclk() and amdgpu_dpm_get_mclk() for both powerplay and non-powerpl

[PATCH] drm/amdgpu/si_dpm: Limit clocks on HD86xx part

2016-10-13 Thread Tom St Denis
From: Tom St Denis Limit clocks on a specific HD86xx part to avoid crashes (while awaiting an appropriate PP fix). Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/si_dpm.c b/drivers/gpu/dr

Re: [PATCH] drm/amdgpu/si_dpm: Limit clocks on HD86xx part

2016-10-13 Thread Alex Deucher
On Thu, Oct 13, 2016 at 5:54 PM, Tom St Denis wrote: > From: Tom St Denis > > Limit clocks on a specific HD86xx part to avoid > crashes (while awaiting an appropriate PP fix). > > Signed-off-by: Tom St Denis Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/si_dpm.c | 6 ++ >

Re: [PATCH] drm/amd/powerplay: notify smu no display by default.

2016-10-13 Thread Alex Deucher
On Thu, Oct 13, 2016 at 3:39 AM, Rex Zhu wrote: > Change-Id: Id6c2046bedd99f17c23b37e2fbf38975482dbfb8 > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/g

[PATCH] drm/amdgpu/gfx8: use cached raster config values in csb setup

2016-10-13 Thread Alex Deucher
Simplify the code and properly set the csb for harvest values. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 30 ++ 1 file changed, 2 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/am

Re: [PATCH] drm/amd/amdgpu: Fix debugfs wave reader

2016-10-13 Thread Alex Deucher
On Thu, Oct 13, 2016 at 12:16 PM, Tom St Denis wrote: > On non VI/CZ platforms it would not free > the grbm index lock. > > Signed-off-by: Tom St Denis > --- Reviewed-by: Alex Deucher > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

Re: [PATCH 4/4] drm/amdgpu: used cached gca values for vi_read_register

2016-10-13 Thread Alex Deucher
On Tue, Oct 11, 2016 at 7:48 PM, Andy Furniss wrote: > The boot vce/uvd issue is fixed in 4.9-wip now, so I can boot latest but - > > The segfault on startx is still there. Fixed in v2. Alex > > I still can't shutdown/reboot > as in https://bugs.freedesktop.org/show_bug.cgi?id=98200 > which is

Re: mm: fix cache mode tracking in vm_insert_mixed() breaks AMDGPU [was: Re: Latest testing with drm-next-4.9-wip and latest LLVM/mesa stack - Regression in PowerPlay/DPM on CIK?]

2016-10-13 Thread Michel Dänzer
[ Adding Dan Williams and dri-devel ] On 14/10/16 03:28 AM, Shawn Starr wrote: > Hello AMD folks, > > I have discovered a problem in Linus master that affects AMDGPU, nobody would > notice this in drm-next-4.9-wip since its not in this repo. [...] > 87744ab3832b83ba71b931f86f9cfdb000d07da5 is

Re: [PATCH] drm/amdgpu: fix amdgpu_need_full_reset (v2)

2016-10-13 Thread zhoucm1
On 2016年10月14日 05:22, Alex Deucher wrote: IP types are not an index. Each asic may have number and type of IPs. Properly check the the type rather than using the type id as an index. v2: fix all the IPs to not use IP type as an idx as well. Signed-off-by: Alex Deucher Cc: sta...@vger.kerne