[PATCH] drm/amdgpu:put CSA unmap after sched_entity_fini

2017-01-12 Thread Monk Liu
otherwise CSA may unmapped before gpu_scheduler scheduling jobs and trigger VM fault on CSA address Change-Id: Ib2e25ededf89bca44c764477dd2f9127024ca78c Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8 2 files

[PATCH libdrm] amdgpu: Provide more specific error message if non-privileged user runs amdgpu_test

2017-01-12 Thread Alex Xie
Before this change, the error message is: "WARNING - Suite initialization failed..." People might think this is a driver problem. Tested with non-privileged user. Now the error message is like: ... Error:Permission denied. Hint:Try to run this test program as root. WARNING - Suite initialization f

Re: More specific libdrm error message

2017-01-12 Thread Emil Velikov
On 12 January 2017 at 01:29, Edward O'Callaghan wrote: > Hi Xie, > > Perhaps you want to use `fprintf(stderr, "...")` over `printf("..")` and > lose the space before the start parenthesis. Also, line wrap > your commit message. > > Side note, use git send-email so that the patch is inline and not

RE: [PATCH] Revert "drm/amdgpu: Only update the CUR_SIZE register when necessary"

2017-01-12 Thread Deucher, Alexander
> -Original Message- > From: Michel Dänzer [mailto:mic...@daenzer.net] > Sent: Thursday, January 12, 2017 3:31 AM > To: Deucher, Alexander > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] Revert "drm/amdgpu: Only update the CUR_SIZE > register when necessary" > > On 12/01/17 02:3

Re: [PATCH 2/3] drm/amdgpu:implement META-DATA write routines

2017-01-12 Thread Christian König
Am 12.01.2017 um 08:41 schrieb Monk Liu: Change-Id: I66007a7f7e4e27fb129121f36143dce3cfb43738 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 31 ++ drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 61 +++ 2 files changed, 92 inserti

Re: [PATCH] drm/amdgpu: use the num_rings variable for checking vce rings

2017-01-12 Thread Christian König
Am 11.01.2017 um 22:13 schrieb Alex Deucher: Difference families may have different numbers of rings. Use the variable rather than a hardcoded number. Signed-off-by: Alex Deucher Reviewed-by: Christian König . --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 ++-- 1 file changed, 2 inserti

Re: 答复: [V3 04/11] drm/amdgpu/virt: use kiq to access registers

2017-01-12 Thread Christian König
I would go a step further and put the BUG_ON(in_interrupt()) into amdgpu_virt_kiq_rreg(). And BTW the problem is even worse, you also can't lock a mutex inside an atomic section and we could have plenty of that as well in the driver code. Regards, Christian. Am 12.01.2017 um 04:21 schrieb Li

Re: [PATCH v2 1/2] drm/amd/amdgpu: lock reservation object while creating shadow bo

2017-01-12 Thread Christian König
Am 11.01.2017 um 17:14 schrieb Nicolai Hähnle: From: Nicolai Hähnle ttm_bo_init checks that the reservation object is locked. This is the caller's responsibility when resv != NULL. Otherwise, the inline reservation object of the newly allocated buffer is used and must explicitly be locked. Uni

Re: [PATCH] Revert "drm/amdgpu: Only update the CUR_SIZE register when necessary"

2017-01-12 Thread Michel Dänzer
On 12/01/17 02:35 AM, Deucher, Alexander wrote: >> -Original Message- >> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf >> Of Michel Dänzer >> Sent: Wednesday, January 11, 2017 4:36 AM >> To: amd-gfx@lists.freedesktop.org >> Cc: Harald Judt; Johannes Hirte >> Subject