答复: [PATCH] drm/amdgpu: Refine the handshake between guest and server by mailbox

2017-01-24 Thread Liu, Monk
please ignore those patches and we will give a formal patch serial later when confirm good working BR Monk ?件人: amd-gfx 代表 Felix Kuehling ?送??: 2017年1月25日 3:04:48 收件人: amd-gfx@lists.freedesktop.org 主?: Re: [PATCH] drm/amdgpu: Refine the handshake between gues

[PATCH] drm/radeon: drop pitcairn dpm quirks

2017-01-24 Thread Alex Deucher
No longer necessary with the new 58 mc ucode. bug: https://bugs.freedesktop.org/show_bug.cgi?id=76490 Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/si_dpm.c | 47 + 1 file changed, 1 insertion(+), 46 deletions(-) diff --git a/drivers/gpu/drm/rad

[PATCH] drm/amdgpu: drop pitcairn dpm quirks

2017-01-24 Thread Alex Deucher
No longer necessary with the new 58 mc ucode. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 47 + 1 file changed, 1 insertion(+), 46 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si_dpm.c b/drivers/gpu/drm/amd/amdgpu/si_dpm.c i

[PATCH 1/2] drm/amdgpu: remove unused header si_reg.h

2017-01-24 Thread Alex Deucher
All of these are available elsewhere. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/include/asic_reg/si/si_reg.h | 105 --- 1 file changed, 105 deletions(-) delete mode 100644 drivers/gpu/drm/amd/include/asic_reg/si/si_reg.h diff --git a/drivers/gpu/drm/amd/include/as

RE: [PATCH libdrm 3/3] amdgpu: A new option to run tests on render node

2017-01-24 Thread Xie, AlexBin
Hi Emil, Point 1 will be left for future patch. Current error message is following. Error: Permission denied. Hint:Try to run this test program as root. I am thinking change it. Error message will be: Error: Permission denied. Hint:Try to run this test program as root or in TTY. Thanks, Alex Bi

[PATCH libdrm 3/3] amdgpu: A new option to run tests on render node

2017-01-24 Thread Alex Xie
Tested: 1. As root, tests passed on primary. 2. As root, tests passed on render node. BO export/import test was skipped 3. As non-privileged user, tests failed on primary as expected. 4. As non-privileged user, tests passed on render node. BO export/import test was skipped Signed-off-by: Ale

[PATCH libdrm 2/3] amdgpu: A new option to choose which device to run most tests

2017-01-24 Thread Alex Xie
This can be used to test multiple GPUs v2: Use PCI bus ID and optional PCI device ID to choose device Add an option to display information of AMDGPU devices Tested: ./amdgpu_test -p ./amdgpu_test ./amdgpu_test -b 1 #fail as expected ./amdgpu_test -b 6 #pass ./amdgpu_test -b -d

[PATCH libdrm 1/3] amdgpu: verify the tested device

2017-01-24 Thread Alex Xie
Verify the vender ID and driver name. Open all AMDGPU devices. Provide an option to open render node. Tested as root: PASS Tested as non-privileged user: All tests failed as expected v2: Return value in the ene of function amdgpu_open_devices. Check the return value of amdgpu_open_devices.

Re: [PATCH 6/6] drm/ttm: revert "add optional LRU removal callback v2"

2017-01-24 Thread Sinclair Yeh
Pathces 1, 2, 5, 6: Reviewed-by: Sinclair Yeh On Fri, Jan 13, 2017 at 10:51:11AM +0100, Christian König wrote: > From: Christian König > > Without the custom LRU management the callback is not used any more. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/ttm/ttm_bo.c| 12

Re: [PATCH] drm/amdgpu: Refine the handshake between guest and server by mailbox

2017-01-24 Thread Felix Kuehling
On 17-01-24 10:05 AM, Xue, Ken wrote: >> From: Christian König [mailto:deathsim...@vodafone.de] >> Sent: Tuesday, January 24, 2017 10:09 PM >> To: Xue, Ken; amd-gfx mailing list >> Cc: dl.SRDC_SW_GPUVirtualization >> Subject: Re: [PATCH] drm/amdgpu: Refine the handshake between guest and >> server

Re: [PATCH 5/6] drm/ttm: revert "implement LRU add callbacks v2"

2017-01-24 Thread Sinclair Yeh
Minor typo On Fri, Jan 13, 2017 at 10:51:10AM +0100, Christian König wrote: > From: Christian König > > The additional housekeeping had to much CPU overhead, ^ > let's use the BO priorities instead. > > Signed-off-by: Christian König > --- > drivers/gpu/dr

RE: [PATCH] drm/amdgpu: Refine the handshake between guest and server by mailbox

2017-01-24 Thread Xue, Ken
> From: Christian König [mailto:deathsim...@vodafone.de] > Sent: Tuesday, January 24, 2017 10:09 PM > To: Xue, Ken; amd-gfx mailing list > Cc: dl.SRDC_SW_GPUVirtualization > Subject: Re: [PATCH] drm/amdgpu: Refine the handshake between guest and > server by mailbox > > Am 24.01.2017 um 13:55 schri

Re: [PATCH 1/2] drm/amdgpu: fix 64bit shift for KV/KB

2017-01-24 Thread Felix Kuehling
Series reviewed by me as well: Reviewed-by: Felix Kuehling On 17-01-24 10:48 AM, Deucher, Alexander wrote: >> -Original Message- >> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf >> Of Christian König >> Sent: Tuesday, January 24, 2017 9:10 AM >> To: amd-gfx@list

RE: [PATCH 1/2] drm/amdgpu: fix 64bit shift for KV/KB

2017-01-24 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Tuesday, January 24, 2017 9:10 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 1/2] drm/amdgpu: fix 64bit shift for KV/KB > > From: Christian König > > Fixe

RE: [PATCH] drm/amd/powerplay: fix regresstion issue can't set manual dpm mode.

2017-01-24 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Tuesday, January 24, 2017 4:51 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH] drm/amd/powerplay: fix regresstion issue can't set manual > dpm mode. >

Re: [PATCH 2/2] drm/amdgpu: fix 64bit shift for CZ

2017-01-24 Thread StDenis, Tom
Works on my CZ system: Ack-by: Tom St Denis From: amd-gfx on behalf of Christian König Sent: Tuesday, January 24, 2017 09:09 To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/2] drm/amdgpu: fix 64bit shift for CZ From: Christian König Fixes "access stol

[PATCH 08/11] drm/amd/display: refactor dc_update_surfaces_for_stream

2017-01-24 Thread Harry Wentland
From: Tony Cheng - reuse existing helper functions - helper function to make it more obvious which cases we can do optimize programming Change-Id: I5dbc2a9f896528a23364f76a4390c0847f260fd0 Signed-off-by: Tony Cheng Reviewed-by: Yongqiang Sun Acked-by: Harry Wentland --- drivers/gpu/drm/amd/

RE: [radeon-alex:drm-next-4.11-wip 131/131] drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:380:48: error: expected ')' before ';' token

2017-01-24 Thread Deucher, Alexander
> -Original Message- > From: Nils Holland [mailto:nholl...@tisys.org] > Sent: Monday, January 23, 2017 7:31 PM > To: kbuild test robot > Cc: kbuild-...@01.org; amd-gfx@lists.freedesktop.org; Deucher, Alexander; > Daenzer, Michel; Koenig, Christian > Subject: Re: [radeon-alex:drm-next-4.11-w

[PATCH 00/11] DC Patches Jan 24, 2017

2017-01-24 Thread Harry Wentland
* Mostly bug fixes here this time Dmytro Laktyushkin (1): drm/amd/display: prevent setting cursor position with no surface Harry Wentland (2): drm/amd/display: Don't reserve pipe for underlay on ASIC without underlay drm/amd/display: Remove power gating debug flags Hersen Wu (1): drm

[PATCH 10/11] drm/amd/display: Check we got a stream in update_info_frame

2017-01-24 Thread Harry Wentland
From: Hersen Wu Change-Id: I649fd0d9a986a2a7474dafd262fa1b5282666ada Signed-off-by: Hersen Wu Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/display/d

[PATCH 04/11] drm/amd/display: Proper de-allocation of OPP

2017-01-24 Thread Harry Wentland
From: Joshua Aberback - refactor opp_destroy functions to dce common file - fixes memory leak, dce specific variations didn't free regamma_params - remove unused dce110_regamma structure Change-Id: I30b8540c0367001e69b9571819f93866a1d59cb2 Signed-off-by: Joshua Aberback Reviewed-by: Jun Lei

[PATCH 02/11] drm/amd/display: Remove power gating debug flags

2017-01-24 Thread Harry Wentland
They're not used anywhere Change-Id: I607045a32ec1af4bb802a90b26301e328ef7f306 --- drivers/gpu/drm/amd/display/dc/dc.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index e0143f9f0421..332ecf8b1157 100644 --- a/driv

[PATCH 09/11] drm/amd/display: clean up redundant logic

2017-01-24 Thread Harry Wentland
From: Tony Cheng Change-Id: Ie995e5bd63451c1891d3b76fe08f22a2c9b62eea Signed-off-by: Tony Cheng Reviewed-by: Yongqiang Sun Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_surface.c | 23 --- drivers/gpu/drm/amd/display/dc/dc.h | 1 - 2 fil

[PATCH 03/11] drm/amd/display: check surface size is at least as large as stream

2017-01-24 Thread Harry Wentland
From: Leon Elazar Change-Id: Ifd9624e886da98bf1da27cad550faf202c679323 Signed-off-by: Leon Elazar Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 4 ++-- drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 4 ++-- 2 files ch

[PATCH 06/11] drm/amd/display: prevent setting cursor position with no surface

2017-01-24 Thread Harry Wentland
From: Dmytro Laktyushkin Change-Id: I98ac559661295af4c2d4d151c4dd6029e27349c1 Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH 01/11] drm/amd/display: Don't reserve pipe for underlay on ASIC without underlay

2017-01-24 Thread Harry Wentland
Change-Id: I961ed1bf9cb255cddf05b24c9915c830df492f89 Signed-off-by: Harry Wentland Acked-by: Jordan Lazare Reviewed-by: Tony Cheng --- drivers/gpu/drm/amd/display/dc/core/dc.c| 2 +- drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 4 ++-- drivers/gpu/drm/amd/display/dc

[PATCH 11/11] drm/amd/display: Fixed 4K black issue by refactor update surface.

2017-01-24 Thread Harry Wentland
From: Yongqiang Sun Change-Id: Ibff4c15aeddf0a013a9c2edca9b82219818cfccb Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git

[PATCH 07/11] drm/amd/display: improve debug-ability

2017-01-24 Thread Harry Wentland
From: Tony Cheng - make failure status obvious Change-Id: If8106b3ac98433817b1fdd414c0776f983b616a9 Signed-off-by: Tony Cheng Reviewed-by: Yongqiang Sun Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/inc/core_status.h | 26 1 file changed, 13 insertions(

[PATCH 05/11] drm/amd/display: Change update surface condition, fix surface transition corruption.

2017-01-24 Thread Harry Wentland
From: Yongqiang Sun Change-Id: I637bab884686aa244d9d896dbc4facd10bafe66b Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/a

[PATCH 2/2] drm/amdgpu: fix 64bit shift for CZ

2017-01-24 Thread Christian König
From: Christian König Fixes "access stolen VRAM directly on CZ", otherwise that won't work as expected with more than 4GB RAM. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 1/2] drm/amdgpu: fix 64bit shift for KV/KB

2017-01-24 Thread Christian König
From: Christian König Fixes "access stolen VRAM directly on KV/KB" otherwise that won't work as expected with more than 4GB RAM. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdg

Re: [PATCH] drm/amdgpu: Refine the handshake between guest and server by mailbox

2017-01-24 Thread Christian König
Am 24.01.2017 um 13:55 schrieb Xue, Ken: Add check for bit RCV_MSG_VALID of MAILBOX_CONTROL before reading message and after ACK server. Change-Id: I717a77fd90dfbdfce4dc56e978338ffc5db24fca Signed-off-by: Ken Xue --- drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 20 1 file cha

[PATCH] drm/amdgpu: Refine the handshake between guest and server by mailbox

2017-01-24 Thread Xue, Ken
Add check for bit RCV_MSG_VALID of MAILBOX_CONTROL before reading message and after ACK server. Change-Id: I717a77fd90dfbdfce4dc56e978338ffc5db24fca Signed-off-by: Ken Xue --- drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/

Re: amdgpu: fix performance drop

2017-01-24 Thread Christian König
Hi Sinclair, you probably have missed this set of patches I've send to the dri-devel mailing list a while ago. It basically replaces some work for TTM I've did back in April last year and you reviewed with a different implementation. The original callback design turned out to have to much o

[PATCH] drm/amd/powerplay: fix regresstion issue can't set manual dpm mode.

2017-01-24 Thread Rex Zhu
Change-Id: I0816a51efe696edfc2a37b17eaacb94660511038 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c index 6c661b

RE: [virtual display] code review

2017-01-24 Thread Tao, Yintian
Hi Christian Thanks for your guidance. I will follow it next time. Best Regards Yintian Tao -Original Message- From: Koenig, Christian Sent: Tuesday, January 24, 2017 5:31 PM To: Tao, Yintian ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: [virtual display] code

[virtual display] code review

2017-01-24 Thread Tao, Yintian
Hi Christian Please help to review this patch. The whole story is as follows: For pass-through case, amdgpu module driver may be included into one image with specified BDF parameter, which will cause the failure of virtual display creation when the slot where GPU is put into is modified. Th

Re: [virtual display] code review

2017-01-24 Thread Christian König
For public mailing lists please use text format only, not HTML mail. Apart from that the patch looks good to me and is Reviewed-by: Christian König . Regards, Christian. Am 24.01.2017 um 10:19 schrieb Tao, Yintian: Hi Christian Please help to review this patch. The whole story is as follo

Re: [PATCH] drm/amdgpu: Fix error in amdgpu_bo_create_restricted()

2017-01-24 Thread Nils Holland
On Tue, Jan 24, 2017 at 09:53:24AM +0100, Christian König wrote: > Am 24.01.2017 um 08:43 schrieb Nils Holland: > > On Tue, Jan 24, 2017 at 10:35:16AM +0900, Michel Dänzer wrote: > >> On 24/01/17 09:55 AM, Nils Holland wrote: > >>> So I decided to fix this with the following follow-up patch. I hope

Re: [PATCH] drm/amdgpu: Fix error in amdgpu_bo_create_restricted()

2017-01-24 Thread Christian König
Am 24.01.2017 um 08:43 schrieb Nils Holland: On Tue, Jan 24, 2017 at 10:35:16AM +0900, Michel Dänzer wrote: On 24/01/17 09:55 AM, Nils Holland wrote: So I decided to fix this with the following follow-up patch. I hope this is the right approach (vs. reverting the commit and instead using a fixe