Because in the first place we have no reason to use delay work,
We use delay work in staging branch is because Xiangliang's TDR/RESET feature
is separated into two steps: part A and part B,
Part B must begin after part A, so Xiangliang use delay work to schedule part B,
(and this design has a neg
> > +uint32_t amdgpu_mm_rreg_nokiq(struct amdgpu_device *adev, uint32_t
> > reg,
> > + bool always_indirect)
> > +{
> > + uint32_t ret;
> > +
> > + if ((reg * 4) < adev->rmmio_size && !always_indirect)
> > + ret = readl(((void __iomem *)adev->rmmio) + (reg * 4));
> >
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Deucher, Alexander
> Sent: Wednesday, February 08, 2017 12:11 AM
> To: Liu, Monk ; amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: RE: [PATCH 15/20] drm/amdgpu:use work instead of de
Just follow the same routine as in gfx7/gfx8. I suppose this could be fixed
with another patch.
Regards,
Flora
-Original Message-
From: Zhang, Hawking
Sent: Wednesday, February 08, 2017 11:47 AM
To: Cui, Flora ; amd-gfx@lists.freedesktop.org
Cc: Cui, Flora
Subject: RE: [PATCH 2/7] drm
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Flora Cui [mailto:flora@amd.com]
Sent: Tuesday, February 07, 2017 16:14
To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org
Cc: Cui, Flora
Subject: [PATCH 4/7] drm/amdgpu: refine si_read_register
Change-Id: Id317bc
Why you need to re-program this bit?
Regards,
Hawking
-Original Message-
From: Flora Cui [mailto:flora@amd.com]
Sent: Tuesday, February 07, 2017 16:14
To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org
Cc: Cui, Flora
Subject: [PATCH 7/7] drm/amd/gfx6: update gb_addr_config
Change-
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Flora Cui [mailto:flora@amd.com]
Sent: Tuesday, February 07, 2017 16:14
To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org
Cc: Cui, Flora
Subject: [PATCH 6/7] drm/amdgpu: update HAINAN_GB_ADDR_CONFIG_GOLDEN
Chang
On 02/08/2017 12:24 PM, Pixel Ding wrote:
> CPU is not efficient to do this job. There's a failure caused by this
> is that handshaking gets timeout of SRIOV virtual function.
Can you fixup the commit message a little but otherwise,
Reviewed-by: Edward O'Callaghan
>
> Signed-off-by: Pixel Ding
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Flora Cui [mailto:flora@amd.com]
Sent: Tuesday, February 07, 2017 16:14
To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org
Cc: Cui, Flora
Subject: [PATCH 5/7] drm/amdgpu: update VERDE_GB_ADDR_CONFIG_GOLDEN
Change-
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Flora Cui [mailto:flora@amd.com]
Sent: Tuesday, February 07, 2017 16:14
To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org
Cc: Cui, Flora
Subject: [PATCH 3/7] drm/amdgpu/gfx6: clean up spi configuration
Change-Id:
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: Flora Cui [mailto:flora@amd.com]
Sent: Tuesday, February 07, 2017 16:14
To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org
Cc: Cui, Flora
Subject: [PATCH 1/7] drm/amdgpu/gfx6: clean up rb configuration
Change-Id:
- for (k = 0; k < adev->gfx.config.max_cu_per_sh; k ++) {
+ for (k = 0; k < 16; k++) {
[Hawking]: I think it's better to use config varable here rather than hard
code. With that fixed the patch is Reviewed-by: Hawking Zhang
Regards,
Hawking
-Orig
CPU is not efficient to do this job. There's a failure caused by this
is that handshaking gets timeout of SRIOV virtual function.
Signed-off-by: Pixel Ding
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdg
On 07/02/17 08:30 PM, Tom St Denis wrote:
> On 07/02/17 06:02 AM, Emil Velikov wrote:
>> On 6 February 2017 at 22:39, StDenis, Tom wrote:
>>>
>>> Apparently I missed the bottom of your reply (all of the clients I
>>> have outlook/gmail do top post only ...)
>> Both Outlook and Gmail can do inline
On 07/02/17 10:16 PM, Dan Carpenter wrote:
> If "rdev->bios" is NULL then we don't need to free it.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/gpu/drm/radeon/radeon_bios.c
> b/drivers/gpu/drm/radeon/radeon_bios.c
> index 00cfb5d2875f..04c0ed41374f 100644
> --- a/drivers/gpu/drm/r
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Michel Dänzer
> Sent: Tuesday, February 07, 2017 4:48 AM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH xf86-video-ati 2/2] Don't destroy current FB if
> drmModeAddFB fails
>
> From: M
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 18/20] drm/amdgpu:alloc mqd backup
>
> Change-Id: I84f821faa657a5d942
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 15/20] drm/amdgpu:use work instead of delay-work
>
> Change-Id: I41b6
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 19/20] drm/amdgpu:use nop to clear ring buffer
>
> this is for a fine
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 20/20] drm/amdgpu:fix kiq_resume routine
>
> use is_load_stage to fix
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 17/20] drm/amdgpu:new field is_load_stage introduced
>
> use it to se
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 16/20] drm/amdgpu:RUNTIME flag should clr later
>
> this flag will ge
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 14/20] drm/amdgpu:use nokiq version mm access
>
> Change-Id: I383d7ce
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 12/20] drm/amdgpu:impl mm_r/weg_nokiq
>
> some registers are pf&vf co
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 11/20] drm/amdgpu:add lock_reset for SRIOV
>
> this lock is used for
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 09/20] drm/amdgpu:implement SRIOV gpu_reset
>
> Signed-off-by: Monk L
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Xue, Ken
> Subject: [PATCH 13/20] Refine handshake between guest and host by
> mailbox
>
> From:
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 10/20] drm/amdgpu:change kiq lock name
>
> Change-Id: Ib11de11fb0a9e8
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 08/20] drm/amdgpu:divide KCQ mqd init to sw and hw
>
> sw part only i
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 07/20] drm/amdgpu:minor cleanup
>
> Change-Id: Ia5ada3e9990261ca70b03
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 06/20] drm/amdgpu:no need use sriov judge
>
> Change-Id: I9717e200be8
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 05/20] drm/amdgpu:bo_free_kernel will set ptr to NULL if
> freed
>
>
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 04/20] drm/amdgpu:imple mqd soft ini/fini
>
> Change-Id: I650a78c8d27
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 03/20] drm/damdgpu:add new mqd member in ring
>
> Change-Id: If4dc6bb
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 01/20] drm/amdgpu:fix powerplay logic
>
> 1,like pp_hw_init, we shoul
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Tuesday, February 07, 2017 1:11 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH 02/20] drm/amdgpu:cg & pg are not applied on VF
>
> Change-Id: I93a4e
On Tue, Feb 7, 2017 at 4:48 AM, Zhu, Rex wrote:
>
> Not set max fan speed in high performance level because of the fan noise.
Reviewed-by: Alex Deucher
>
> Best Regards
> Rex
>
> From: amd-gfx on behalf of Zhu, Rex
>
> Sent: Monday, February 6, 2017 10:09 PM
>
If "rdev->bios" is NULL then we don't need to free it.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/radeon/radeon_bios.c
b/drivers/gpu/drm/radeon/radeon_bios.c
index 00cfb5d2875f..04c0ed41374f 100644
--- a/drivers/gpu/drm/radeon/radeon_bios.c
+++ b/drivers/gpu/drm/radeon/radeon_bio
The amdgpu_vm_bo_rmv() function frees "bo_va" so we shouldn't free it
a second time.
Fixes: 4e4bbe7343a6 ("drm/amdgpu:add new file for SRIOV")
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 3fd951c71d1b..dcfb7d
Hello Xiangliang Yu,
The patch bc992ba5a3c1: "drm/amdgpu/virt: use kiq to access registers
(v2)" from Jan 12, 2017, leads to the following static checker
warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:122 amdgpu_virt_kiq_rreg()
error: uninitialized symbol 'f'.
drivers/gpu/drm/
Zhu, Rex wrote:
Not set max fan speed in high performance level because of the fan noise.
Thanks, I tested the patch and all seems OK again.
Best Regards
Rex
From: amd-gfx on behalf of Zhu, Rex
Sent: Monday, February 6, 2017 10:09 PM
To: Andy Furniss; Ale
On 7 February 2017 at 11:30, Tom St Denis wrote:
> On 07/02/17 06:02 AM, Emil Velikov wrote:
>>
>> On 6 February 2017 at 22:39, StDenis, Tom wrote:
>>>
>>>
>>> Apparently I missed the bottom of your reply (all of the clients I have
>>> outlook/gmail do top post only ...)
>>
>> Both Outlook and Gm
On 07/02/17 06:02 AM, Emil Velikov wrote:
On 6 February 2017 at 22:39, StDenis, Tom wrote:
Apparently I missed the bottom of your reply (all of the clients I have
outlook/gmail do top post only ...)
Both Outlook and Gmail can do inline replies and plain text. There
might be some magic requir
this patch is dropped, we can call gart_vram_pin even the bo is already pinned,
the internal of pin function will check that, thanks
发件人: Christian König
发送时间: 2017年2月7日 19:12:04
收件人: Liu, Monk; amd-gfx@lists.freedesktop.org
主题: Re: [PATCH 07/21] drm/amdgpu:fix g
no, we already make it work, and suspend is totally nonsense for SRIOV,
because when guest side need a GPU reset, hypervisor will do VF flr, so after
vf flr amdgpu_suspen() is redundant at all.
those 20 patches serial is verified on KVM/XEN platform, it can recover back
from guest hang.
___
Because gpu_srio_reset (will send patch for this routine later) doesn't call
amdgpu_suspend()
That's most likely not a good idea.
Suspend and resume should always be paired, otherwise you run into
exactly those problems and the GART is most likely only the tip of the
iceberg here.
For examp
Yeah, the src_data is unfortunately not completed (you simply can't have
all the bits of a 40bit address+flags in a 32bit dw).
But it's the best we can do, so the patch is Reviewed-by: Christian
König as well.
Regards,
Christian.
Am 07.02.2017 um 08:03 schrieb Zhang, Jerry:
If that info is
I think you mean loading KMS multiple times by “reuse”.
No, as far as I know the fb emulation can be initialized multiple times
without driver reload.
I can’t see a case that fb_probe is invoked out of loading KMS, is there?
I'm not so deeply into this, but I knew that you can certainly unbind
On 6 February 2017 at 22:39, StDenis, Tom wrote:
>
> Apparently I missed the bottom of your reply (all of the clients I have
> outlook/gmail do top post only ...)
Both Outlook and Gmail can do inline replies and plain text. There
might be some magic required for the former though :-\
I would kind
Not set max fan speed in high performance level because of the fan noise.
Best Regards
Rex
From: amd-gfx on behalf of Zhu, Rex
Sent: Monday, February 6, 2017 10:09 PM
To: Andy Furniss; Alex Deucher
Cc: amd-gfx list
Subject: RE: [PATCH 4/4] drm/amdgpu: extend pr
From: Michel Dänzer
Signed-off-by: Michel Dänzer
---
src/drmmode_display.c | 4 +++-
src/radeon_dri2.c | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/drmmode_display.c b/src/drmmode_display.c
index 314d63989..b64be462d 100644
--- a/src/drmmode_display.c
+++ b/s
From: Michel Dänzer
It would probably result in a black screen.
Signed-off-by: Michel Dänzer
---
src/drmmode_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/drmmode_display.c b/src/drmmode_display.c
index b64be462d..c39b32558 100644
--- a/src/drmmode_display
Change-Id: Iab06288ba350c44caa06fb11c2e4ee9c90cd05a6
Signed-off-by: Flora Cui
---
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 101 ++
1 file changed, 42 insertions(+), 59 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx
Change-Id: Ieb6f58ab238a2dcf59cc369c0ba4975d4a244c8d
Signed-off-by: Flora Cui
---
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 100 +-
1 file changed, 38 insertions(+), 62 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx
Change-Id: I3b866a719e99af2eed461fd618348ba6a28e1f81
Signed-off-by: Flora Cui
---
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
index 765c5e3..782190d 100644
--- a/drivers
Change-Id: Id317bc2a7c5ddcde777b2a7458da26dbb5f0e4b9
Signed-off-by: Flora Cui
---
drivers/gpu/drm/amd/amdgpu/si.c | 90 +
1 file changed, 73 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
index
Change-Id: I0cb6344cd69fb5e27222122203e535c55cf459dd
Signed-off-by: Flora Cui
---
drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c
index fc24108..76
Change-Id: I7198e0e2d91c37b80e7056ae57eb701a37775587
Signed-off-by: Flora Cui
---
drivers/gpu/drm/amd/amdgpu/si_enums.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/si_enums.h
b/drivers/gpu/drm/amd/amdgpu/si_enums.h
index 331033f..dc9e0e6 100644
If that info is enough for vf.
Reviewed-by: Junwei Zhang
Regards,
Jerry (Junwei Zhang)
Linux Base Graphics
SRDC Software Development
_
> -Original Message-
> From: Pixel Ding [mailto:pixel.d...@amd.com]
> Sent: Tuesday, February 07, 2017 14:07
> To:
Hi Christian,
> + fpriv->prt_va = amdgpu_vm_bo_add(adev, &fpriv->vm, NULL);
Maybe we cannot add NULL bo to a vm, as it will cause NULL dereference inside
amdgpu_vm_bo_add()
by list_add_tail(&bo_va->bo_list, &bo->va);
Regards,
Jerry (Junwei Zhang)
Linux Base Graphics
SRDC Software Developmen
Change-Id: I19755cf40519a64ce48cf6ecddbec21bda84e827
Signed-off-by: Flora Cui
---
drivers/gpu/drm/amd/amdgpu/si_enums.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/si_enums.h
b/drivers/gpu/drm/amd/amdgpu/si_enums.h
index fde2086..331033f 100644
61 matches
Mail list logo
