Re: [PATCH 1/2 v2] drm/amdgpu: fix vm size and block size for Vega10 VMPT

2017-03-31 Thread Zhang, Jerry (Junwei)
On 03/31/2017 12:05 PM, Deucher, Alexander wrote: -Original Message- From: Junwei Zhang [mailto:jerry.zh...@amd.com] Sent: Thursday, March 30, 2017 10:52 PM To: Deucher, Alexander; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; Zhang, Jerry Subject: [PATCH 1/2 v2] drm/amdgpu: fix vm

[PATCH] drm/amdgpu: fix vm size and block size for VMPT (v3)

2017-03-31 Thread Junwei Zhang
From: "Zhang, Jerry" v2: set both of them in gmc v3: move vm size and block size in vm manager Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 22 -- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.

[PATCH] drm/amdgpu: Read vram width from integrated system info table

2017-03-31 Thread Harry Wentland
On KB, KV, CZ we should read the vram width from integrated system table, if we can. The NOOFCHAN in MC_SHARED_CHMAP is not accurate. With this change we can enable two 4k displays on CZ again. This use case was broken sometime in January when we started looking at vram_width for bandwidth calcula

RE: Regression caused by "drm/amdgpu: get display info from DC when DC enabled."

2017-03-31 Thread Lazare, Jordan
Hi Andy, Thanks for bisecting the issue. I've attached a patch which should fix the issue, if you'd like to give it a try. Thanks, Jordan -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Deucher, Alexander Sent: Wednesday, March 29, 2017 11:

Re: [PATCH] drm/amdgpu: use a 64bit interval tree for VM management

2017-03-31 Thread Felix Kuehling
On 17-03-31 03:15 AM, Christian König wrote: > Am 30.03.2017 um 16:55 schrieb Felix Kuehling: >> This only makes a difference for 32-bit systems. The idea is to have a >> fixed virtual address space size with 4-level page tables and to >> minimize differences between 32 and 64-bit systems. > Thanks

[PATCH] drm/amdgpu/gfx8: fix resume of KIQ and KCQs

2017-03-31 Thread Alex Deucher
No need to reset the wptr and clear the rings. The UNMAP_QUEUES packet writes the current MQD state back the MQD on suspend, so there is no need to reset it as well. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 26 +- 1 file changed, 13 inserti

Re: [PATCH] drm/amdgpu/powerplay: fix locking typo

2017-03-31 Thread Harry Wentland
Reviewed-by: Harry Wentland On 2017-03-31 11:01 AM, Christian König wrote: Am 31.03.2017 um 16:54 schrieb Alex Deucher: Fixes: 2a5071056e6a601e ("drm/amd/powerplay: add global PowerPlay mutex.") Reported-by: Julia Lawall Signed-off-by: Alex Deucher Reviewed-by: Christian König --- dri

[bug report] drm/amdgpu/gfx6: clean up cu configuration

2017-03-31 Thread Dan Carpenter
Hello Flora Cui, The patch 375d6f7057a9: "drm/amdgpu/gfx6: clean up cu configuration" from Feb 7, 2017, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c:3737 gfx_v6_0_get_cu_info() warn: potential off by one cu_info->bitmap[4] drivers/gpu/drm/a

Re: [PATCH] drm/amdgpu/powerplay: fix locking typo

2017-03-31 Thread Christian König
Am 31.03.2017 um 16:54 schrieb Alex Deucher: Fixes: 2a5071056e6a601e ("drm/amd/powerplay: add global PowerPlay mutex.") Reported-by: Julia Lawall Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 2 +- 1 file changed, 1 insertio

[PATCH] drm/amdgpu/powerplay: fix locking typo

2017-03-31 Thread Alex Deucher
Fixes: 2a5071056e6a601e ("drm/amd/powerplay: add global PowerPlay mutex.") Reported-by: Julia Lawall Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/

[PATCH 6/6] drm/amdgpu: handle CPU access for split VRAM buffers

2017-03-31 Thread Christian König
From: Christian König This avoids merging them together on page fault. Signed-off-by: Christian König Acked-by: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 16 2 files changed, 13 insertions(+), 7 deleti

[PATCH 5/6] drm/amdgpu: use TTM_PL_FLAG_CONTIGUOUS

2017-03-31 Thread Christian König
From: Christian König Implement AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS using TTM_PL_FLAG_CONTIGUOUS instead of a placement limit. That allows us to better handle CPU accessible placements. Signed-off-by: Christian König Acked-by: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 11

[PATCH 4/6] drm/amdgpu: drop alpha support

2017-03-31 Thread Christian König
From: Christian König We will probably never see this combination. Signed-off-by: Christian König Reviewed-by: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 25 - 1 file changed, 25 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/dri

[PATCH 3/6] drm/ttm: add TTM_PL_FLAG_CONTIGUOUS v2

2017-03-31 Thread Christian König
From: Christian König This allows drivers to specify if they need a contiguous allocation or not. v2: use space instead of tab Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c| 4 +++- include/drm/ttm/ttm_placement.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) d

[PATCH 2/6] drm/ttm: add io_mem_pfn callback

2017-03-31 Thread Christian König
From: Christian König This allows the driver to handle io_mem mappings on their own. Signed-off-by: Christian König Reviewed-by: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 + drivers/gpu/drm/ast/ast_ttm.c | 1 + drivers/gpu/drm/bochs/bochs_mm.c| 1 + dr

[PATCH 1/6] drm/ttm: cleanup and optimize ttm_bo_mem_compat v2

2017-03-31 Thread Christian König
From: Christian König No need to implement the same logic twice. Also check if the busy placements are identical to the already scanned placements before checking them. v2: improve check even more as suggested by Michel. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 45 +++

Re: [PATCH 4/6] drm/amdgpu: drop alpha support

2017-03-31 Thread Michel Dänzer
On 31/03/17 04:09 PM, Christian König wrote: > Am 31.03.2017 um 03:07 schrieb Michel Dänzer: >> On 30/03/17 10:09 PM, Alex Deucher wrote: >>> On Thu, Mar 30, 2017 at 2:39 AM, Michel Dänzer >>> wrote: On 29/03/17 09:55 PM, Christian König wrote: > From: Christian König > > We will

Re: [PATCH] drm/amdgpu: use a 64bit interval tree for VM management

2017-03-31 Thread Christian König
Am 30.03.2017 um 16:55 schrieb Felix Kuehling: This only makes a difference for 32-bit systems. The idea is to have a fixed virtual address space size with 4-level page tables and to minimize differences between 32 and 64-bit systems. Thanks going to use that as commit message. Reviewed-by: Fe

Re: [PATCH 4/6] drm/amdgpu: drop alpha support

2017-03-31 Thread Christian König
Am 31.03.2017 um 03:07 schrieb Michel Dänzer: On 30/03/17 10:09 PM, Alex Deucher wrote: On Thu, Mar 30, 2017 at 2:39 AM, Michel Dänzer wrote: On 29/03/17 09:55 PM, Christian König wrote: From: Christian König We will probably never see this combination. Signed-off-by: Christian König ---

Re: [PATCH 1/5] drm/amdgpu/gfx8: KIQ is also disabled when MEC is disabled

2017-03-31 Thread Christian König
Am 30.03.2017 um 20:34 schrieb Alex Deucher: Set the ready flag to reflect this. Signed-off-by: Alex Deucher Patches #1 and #3-#5 are Reviewed-by: Christian König Patch #2 is Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 1 + 1 file changed, 1 insertion(+) d