Re: [PATCH] drm/amd/powerplay: fix copy error in powerplay.

>>s/diable/disable/ >>Also, why not make "Failed" lower-case at the same time? Of course. thanks. Best Regards Rex From: amd-gfx on behalf of William Lewis Sent: Thursday, June 8, 2017

[PATCH i-g-t] igt/kms_properties.c: fix test case for setting immutable properties

Test doesn't check if the property is immutable, and fails. Added conditions to detect if the property is immutable. Signed-off-by: Bhawanpreet Lakha --- tests/kms_properties.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] drm/amdgpu: add parameter to allocate high priority contexts v11

I had forgotten to squash some fixups to the original patch. This should be the correct one. Regards, Andres On 2017-06-08 06:20 PM, Andres Rodriguez wrote: Add a new context creation parameter to express a global context priority. The priority ranking in descending order is as follows: *

[PATCH] drm/amdgpu: add parameter to allocate high priority contexts v11

Add a new context creation parameter to express a global context priority. The priority ranking in descending order is as follows: * AMDGPU_CTX_PRIORITY_HIGH_HW * AMDGPU_CTX_PRIORITY_HIGH_SW * AMDGPU_CTX_PRIORITY_NORMAL * AMDGPU_CTX_PRIORITY_LOW_SW * AMDGPU_CTX_PRIORITY_LOW_HW The driver

[PATCH 7/8] drm/amdgpu: add plumbing for ctx priority changes

Introduce amdgpu_ctx_priority_get/put(). This a refcounted mechanism to change a context's priority. A context's priority will be set to the highest priority for which a request exists. If no active requests exist, the context will default to the priority requested at context allocation time.

[PATCH 8/8] drm/amdgpu: add interface for editing a foreign process's priority

The AMDGPU_SCHED_OP_PROCESS_PRIORITY_GET/PUT ioctls are used to set the priority of a different process in the current system. When all requests are dropped, the foreign process's contexts will be restored to the priority specified at context creation time. An fd is used to identify the remote

[PATCH] allow DRM_MASTER to change client's priorities

Hey Everyone, This series is the first spin-off from my RFC "Exclusive gpu access for SteamVR usecases". It also includes an updated version of my priority patchset. Some notable changes to the old priority patches: * Patch 1: DRM_MASTER is now allowed to allocate high priority contexts *

[PATCH 6/8] drm/amd/sched: allow clients to edit an entity's rq

This is useful for changing an entity's priority at runtime. Signed-off-by: Andres Rodriguez --- drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 26 +++--- drivers/gpu/drm/amd/scheduler/gpu_scheduler.h | 6 +- 2 files changed, 28 insertions(+), 4

[PATCH 5/8] drm/amdgpu: move priority decay logic into amd_sched_priority_ctr

So that it can be re-used. A priority counter can be used to track priority requests. If no active requests exists, the counter will default to ()->default_priority. The re-factored version is now allowed to decay below NORMAL. This allows us to create requests that lower the priority. This

[PATCH 4/8] drm/amdgpu: make amdgpu_to_sched_priority detect invalid parameters

Returning invalid priorities as _NORMAL is a backwards compatibility quirk of amdgpu_ctx_ioctl(). Move this detail one layer up where it belongs. Signed-off-by: Andres Rodriguez --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 8 +---

[PATCH 3/8] drm/amdgpu: implement ring set_priority for gfx_v8 compute v9

Programming CP_HQD_QUEUE_PRIORITY enables a queue to take priority over other queues on the same pipe. Multiple queues on a pipe are timesliced so this gives us full precedence over other queues. Programming CP_HQD_PIPE_PRIORITY changes the SPI_ARB_PRIORITY of the wave as follows: 0x2:

[PATCH 1/8] drm/amdgpu: add parameter to allocate high priority contexts v11

Add a new context creation parameter to express a global context priority. The priority ranking in descending order is as follows: * AMDGPU_CTX_PRIORITY_HIGH_HW * AMDGPU_CTX_PRIORITY_HIGH_SW * AMDGPU_CTX_PRIORITY_NORMAL * AMDGPU_CTX_PRIORITY_LOW_SW * AMDGPU_CTX_PRIORITY_LOW_HW The driver

[PATCH 2/8] drm/amdgpu: add framework for HW specific priority settings v8

Add an initial framework for changing the HW priorities of rings. The framework allows requesting priority changes for the lifetime of an amdgpu_job. After the job completes the priority will decay to the next lowest priority for which a request is still valid. A new ring function set_priority()

RE: [PATCH i-g-t] tests: Increase value of I915_MAX_PIPES to 6

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of sunpeng...@amd.com > Sent: Thursday, June 08, 2017 3:11 PM > To: intel-...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; > Wentland, Harry > Cc: Li, Sun peng > Subject: [PATCH i-g-t]

[PATCH i-g-t] tests: Increase value of I915_MAX_PIPES to 6

From: "Leo (Sunpeng) Li" Increasing max pipe count to 6 to support AMD GPU's. Since some tests' behavior depends on this value, small changes are made to remove this dependency: * kms_ccs: Early abort if wanted_pipe is out-of-bounds. * kms_concurrent: Check if pipe is

RE: [PATCH 1/3] drm/amdgpu: remove duplicate function prototypes

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Alex Xie > Sent: Thursday, June 08, 2017 3:05 PM > To: amd-gfx@lists.freedesktop.org > Cc: Xie, AlexBin > Subject: [PATCH 1/3] drm/amdgpu: remove duplicate function prototypes > > There are

[PATCH 3/3] drm/amdgpu: move comment to the right place

Signed-off-by: Alex Xie --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index f3e7885..a7d6804 100644 ---

[PATCH 1/3] drm/amdgpu: remove duplicate function prototypes

There are two identical function prototypes in same headere file Signed-off-by: Alex Xie --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index

[PATCH 2/3] drm/amdgpu: fix a typo in comment

Signed-off-by: Alex Xie --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index b17635c..7a70a2d 100644 ---

[pull] radeon and amdgpu drm-next-4.13

Hi Dave, New radeon and amdgpu features for 4.13: - Lots of Vega10 bug fixes - Preliminary Raven support - KIQ support for compute rings - MEC queue management rework from Andres - Audio support for DCE6 - SR-IOV improvements - Improved module parameters for controlling radeon vs amdgpu support

Re: [PATCH] drm/amdgpu/gfx: create a common bitmask function (v2)

#define GENMASK (h, l) \ (((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h I think we can use GENMASK though it is slightly overkill and slower (Three more

Re: [PATCH] drm/amd/powerplay: fix copy error in powerplay.

On 06/08/2017 02:50 AM, Rex Zhu wrote: > should disable led dpm feature when stop dpm. > > Change-Id: I9d78459ff2467d2eba0b26d9696138f7eba484a0 > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 +++--- > 1 file changed, 3 insertions(+),

Re: [PATCH] drm/amdgpu/gfx: create a common bitmask function (v2)

Which macro do you want to use to replace this function? I thought about using GENMASK() here, but that's not a must have. On the other hand we should probably consider using GENMASK() for our register headers. The parameters of the marco matches how our internal register database works, so

Re: [PATCH] drm/amdgpu/gfx: create a common bitmask function (v2)

Hi Christian, Which macro do you want to use to replace this function? The function is small so that we use a "static inline". I agree that large function should not use "static inline". Thanks for point that out. Alex Bin Xie On 2017-06-08 03:20 AM, Christian König wrote: Actually we

[PATCH umr] Tidy up memory reads.

Was masking too many bits on AI+ plus started addition of APU offsets/etc. Also added more sensible debug output to match the register names better. Also discovered that reading sys ram when IOMMU is enabled doesn't work right now so you'll either have to diable IOMMU or restrict this to

Re: [PATCH] drm/amd/powerplay: fix copy error in powerplay.

On Thu, Jun 8, 2017 at 3:50 AM, Rex Zhu wrote: > should disable led dpm feature when stop dpm. > > Change-Id: I9d78459ff2467d2eba0b26d9696138f7eba484a0 > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 +++--- > 1 file

[PATCH] drm/amd/powerplay: fix copy error in powerplay.

should disable led dpm feature when stop dpm. Change-Id: I9d78459ff2467d2eba0b26d9696138f7eba484a0 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 1/2] drm/amdgpu: call pci_[un]register_driver() directly

Am 07.06.2017 um 23:42 schrieb Alex Deucher: Rather than calling the deprecated drm_pci_init() and drm_pci_exit() which just wrapped the pci functions anyway. Signed-off-by: Alex Deucher Reviewed-by: Christian König for both. ---

Re: [PATCH 1/6] drm/amdgpu/gfx8: whitespace change

Am 07.06.2017 um 21:34 schrieb Alex Deucher: Make it consistent. Signed-off-by: Alex Deucher Reviewed-by: Christian König for this one. Acked-by: Christian König for the rest in this series. Regards,

Re: [PATCH] drm/amdgpu/gfx: create a common bitmask function (v2)

Actually we should only use static inline if we have to, see "15) The inline disease" in the coding style document, but for this case it actually looks valid to me as well. But wasn't there a macro for this in the Linux kernel headers we should use? Regards, Christian. Am 07.06.2017 um 00:36