Re: Regression: Re: [PATCH 2/3] drm/amdgpu: fix amdgpu_ttm_bind

Actually, I read that wrong. It does GART bind userptr BOs. But it also unpins and repins them accidentally in the process, since ttm_bo_move_ttm calls backend_unbind and backend_bind callbacks. And ends up corrupting some kernel page state, because we had to move the pinning of user pages out of

Re: Regression: Re: [PATCH 2/3] drm/amdgpu: fix amdgpu_ttm_bind

It also seems to break GART binding of userptr BOs. Since backend_bind doesn't do GART binding for userptr BOs, they now don't get GART bound at all. There is something else still broken in our IPC test for system memory also, but I'll have to rewrite that anyway to work for large BOs with a

Re: [PATCH] drm/amd/display: Remove drm_modeset_lock in MST code

On Fri, Sep 1, 2017 at 8:50 PM, Harry Wentland wrote: > This is no longer needed in 4.13 > > Signed-off-by: Harry Wentland > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 12 +--- > 1 file changed, 1 insertion(+), 11

RE: [PATCH] drm/amdgpu: fix placement flags in amdgpu_ttm_bind

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Felix Kuehling > Sent: Friday, September 01, 2017 3:18 PM > To: Christian König; amd-gfx@lists.freedesktop.org > Cc: Russell, Kent > Subject: Re: [PATCH] drm/amdgpu: fix placement flags in

Re: [PATCH] drm/amdgpu: fix placement flags in amdgpu_ttm_bind

Thanks for the fix. I still don't quite understand how this works. We still call ttm_bo_move_ttm for a pinned BO. Maybe the function name is misleading. As I understand it, this doesn't move the memory physically. It just changes the GART address mapping? All that's needed is maintaining the flags

Re: [PATCH 4/4] drm/amd/powerplay: set uvd/vce/nb/mclk level as UMD P-state required

Hi Alex, 》BTW, can you review my stable p-state fix for CZ? 》https://patchwork.freedesktop.org/patch/174102 Patch is Reviewed-by: Rex Zhu Best Regards Rex From: Deucher, Alexander Sent: Friday, September 1, 2017 11:03:10 PM To: Zhu, Rex;

Re: [PATCH] drm/ttm: Fix trace include path (v2)

On 01/09/17 01:48 PM, Thierry Reding wrote: On Fri, Sep 01, 2017 at 12:14:23PM -0400, Tom St Denis wrote: Signed-off-by: Tom St Denis (v2): Drop Makefile change too. --- drivers/gpu/drm/ttm/Makefile| 2 +- drivers/gpu/drm/ttm/ttm_trace.h | 2 +- 2 files changed, 2

Re: [PATCH] drm/ttm: Fix trace include path (v2)

On Fri, Sep 01, 2017 at 12:14:23PM -0400, Tom St Denis wrote: > Signed-off-by: Tom St Denis > > (v2): Drop Makefile change too. > --- > drivers/gpu/drm/ttm/Makefile| 2 +- > drivers/gpu/drm/ttm/ttm_trace.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH] drm/ttm: Fix trace include path (v2)

Am 01.09.2017 um 18:15 schrieb Deucher, Alexander: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Friday, September 01, 2017 12:14 PM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom; dri-de...@lists.freedesktop.org

RE: [PATCH] drm/ttm: Fix trace include path (v2)

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Friday, September 01, 2017 12:14 PM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom; dri-de...@lists.freedesktop.org > Subject: [PATCH] drm/ttm: Fix trace include

[PATCH] drm/ttm: Fix trace include path (v2)

Signed-off-by: Tom St Denis (v2): Drop Makefile change too. --- drivers/gpu/drm/ttm/Makefile| 2 +- drivers/gpu/drm/ttm/ttm_trace.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/Makefile b/drivers/gpu/drm/ttm/Makefile index

Re: [PATCH 2/2] drm/ttm: Fix trace include path

On 01/09/17 12:12 PM, Deucher, Alexander wrote: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Tom St Denis Sent: Friday, September 01, 2017 12:11 PM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom; dri-de...@lists.freedesktop.org Subject:

RE: [PATCH 2/2] drm/ttm: Fix trace include path

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Friday, September 01, 2017 12:11 PM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom; dri-de...@lists.freedesktop.org > Subject: [PATCH 2/2] drm/ttm: Fix trace

RE: [PATCH] drm/amd/display: Update TODO list

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Harry Wentland > Sent: Friday, September 01, 2017 12:05 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander; daniel.vet...@ffwll.ch; Wentland, Harry; > Grodzovsky, Andrey >

[PATCH 2/2] drm/ttm: Fix trace include path

Signed-off-by: Tom St Denis --- drivers/gpu/drm/ttm/ttm_trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_trace.h b/drivers/gpu/drm/ttm/ttm_trace.h index 23279b9b8e64..715ce68b7b33 100644 --- a/drivers/gpu/drm/ttm/ttm_trace.h

[PATCH 1/2] drm/amd/amdgpu: Fix TRACE include path

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h index b1f97417241d..cef1a26deb2d 100644 ---

[PATCH] drm/amd/display: Update TODO list

Change-Id: I15eb763e959f5f6d4ae5e59a9d09a37d1e3c667d Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/TODO | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/TODO b/drivers/gpu/drm/amd/display/TODO

Re: [PATCH 00/13] mmu_notifier kill invalidate_page callback

taskboxtes...@gmail.com liked your message with Boxer for Android. On Sep 1, 2017 10:48 AM, Jeff Cook wrote: On Wed, Aug 30, 2017, at 10:57 AM, Adam Borowski wrote: > On Tue, Aug 29, 2017 at 08:56:15PM -0400, Jerome Glisse wrote: > > I will wait for people to test and for

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

On Thu, Jul 6, 2017 at 3:17 AM, Dave Airlie wrote: > From: Dave Airlie > > This adds kernel semaphore support to the command submission > interface in what should be a backwards compatible manner, > it adds a new command submission API. > > Signed-off-by:

[PATCH 1/1] drm/amdgpu/uvd3: Initial port of UVD from radeon for SI.

--- drivers/gpu/drm/amd/amdgpu/Makefile| 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c| 14 + drivers/gpu/drm/amd/amdgpu/si.c| 256 ++- drivers/gpu/drm/amd/amdgpu/si_ih.c | 6 + drivers/gpu/drm/amd/amdgpu/sid.h

[PATCH 0/1] [rfc] Port UVD from radeon for SI

Here is my attempt at porting UVD from radeon to amdgpu for SI devices. First, this in no way works. I started with UVD for CIK and have worked backwards to arrive at this place. I've gone back over most things from radeon and most of it looks correct as far as I can see. It currently loads the

RE: [PATCH 4/4] drm/amd/powerplay: set uvd/vce/nb/mclk level as UMD P-state required

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Rex Zhu > Sent: Friday, September 01, 2017 5:51 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: [PATCH 4/4] drm/amd/powerplay: set uvd/vce/nb/mclk level as > UMD P-state

RE: [PATCH] drm/amdgpu: fix moved list handling in the VM

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Friday, September 01, 2017 9:05 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: fix moved list handling in the VM > > From: Christian König

RE: [PATCH] drm/amdgpu: fix placement flags in amdgpu_ttm_bind

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Friday, September 01, 2017 3:24 AM > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix; Russell, Kent > Subject: [PATCH] drm/amdgpu: fix placement flags in

RE: [PATCH 1/4] drm/amd/amdgpu: Simplify gmc_v9_0_vm_fault_interrupt_state()

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Friday, September 01, 2017 9:57 AM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH 1/4] drm/amd/amdgpu: Simplify >

RE: [PATCH] drm/amd/amdgpu: Support full range of GFX ring names

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Friday, September 01, 2017 9:17 AM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH] drm/amd/amdgpu: Support full range of GFX ring names > >

[PATCH 2/6] drm/amdgpu: Use correct path to trace include

From: Thierry Reding The header comment in include/trace/define_trace.h specifies that the TRACE_INCLUDE_PATH needs to be relative to the define_trace.h header rather than the trace file including it. Most instances get that wrong and work around it by adding the $(src)

[PATCH 5/6] drm/radeon: Use correct path to trace include

From: Thierry Reding The header comment in include/trace/define_trace.h specifies that the TRACE_INCLUDE_PATH needs to be relative to the define_trace.h header rather than the trace file including it. Most instances get that wrong and work around it by adding the $(src)

Re: [PATCH 1/4] drm/amd/amdgpu: Simplify gmc_v9_0_vm_fault_interrupt_state()

Am 01.09.2017 um 15:57 schrieb Tom St Denis: Signed-off-by: Tom St Denis Reviewed-by: Christian König for the entire series. --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 51 --- 1 file changed, 17

Re: [PATCH] drm/amd/amdgpu: Support full range of GFX ring names

Am 01.09.2017 um 15:17 schrieb Tom St Denis: Right now there's only one but the rest of the code is being setup to support more so might as well fix this up too. Signed-off-by: Tom St Denis Reviewed-by: Christian König ---

RE: [PATCH] drm/amdgpu: declare the new firmware files needed by polaris asics

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Evan Quan > Sent: Friday, September 01, 2017 3:19 AM > To: amd-gfx@lists.freedesktop.org > Cc: Cui, Flora; Quan, Evan > Subject: [PATCH] drm/amdgpu: declare the new firmware files needed by >

[PATCH 3/4] drm/amd/amdgpu: Tidy up gmc_v9_0_hw_init()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index d7cfee807287..0766dad1fafe 100644 ---

[PATCH 2/4] drm/amd/amdgpu: Tidy up gmc_v9_0_gart_enable()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index 1cb7aa2af683..d7cfee807287 100644 ---

[PATCH 4/4] drm/amd/amdgpu: Cleanup gmc_v9_0_suspend()

Even though fini returns 0 always it could theoretically fail in the future. Might as well return it instead of 0. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 1/4] drm/amd/amdgpu: Simplify gmc_v9_0_vm_fault_interrupt_state()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 51 --- 1 file changed, 17 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c index

[PATCH] drm/amd/amdgpu: Support full range of GFX ring names

Right now there's only one but the rest of the code is being setup to support more so might as well fix this up too. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH] drm/amdgpu: fix moved list handling in the VM

From: Christian König Only move BOs to the moved/relocated list when they aren't already on a list. This prevents accidential removal from the evicted list. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9

Re: [PATCH] drm/amdgpu: declare the new firmware files needed by polaris asics

patch is Reviewed-by: Flora Cui On Fri, Sep 01, 2017 at 03:18:33PM +0800, Evan Quan wrote: > Change-Id: If0f280979d85c118dc05ebfa37207b8544abfa45 > Signed-off-by: Evan Quan > --- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 15 +++ > 1 file

Re: [PATCH 6/6 v3] ASoC: AMD: Add machine driver for cz rt5650

On 8/31/2017 5:08 PM, Mark Brown wrote: > On Fri, Aug 18, 2017 at 02:10:30PM -0400, Alex Deucher wrote: > >> +++ b/sound/soc/amd/Kconfig >> @@ -2,3 +2,10 @@ config SND_SOC_AMD_ACP >> tristate "AMD Audio Coprocessor support" >> help >> This option enables ACP DMA support on AMD

[PATCH 4/4] drm/amd/powerplay: set uvd/vce/nb/mclk level as UMD P-state required

Change-Id: I6e5cb169fcc22525d26cdc3f82ca011249f912ef Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c

[PATCH 3/4] drm/amd/powerplay: add UMD P-state in powerplay.

This feature is for UMD to run benchmark in a power state that is as steady as possible. kmd need to fix the power state as stable as possible. now, kmd support four level: profile_standard,peak,min_sclk,min_mclk move common related code to amd_powerplay.c Signed-off-by: Rex Zhu

[PATCH 2/4] drm/amd/powerplay: delete eventmgr related files.

Change-Id: I914c034242eb1ddaafa974afccc2d570007bd2bf --- drivers/gpu/drm/amd/powerplay/eventmgr/Makefile| 11 - .../drm/amd/powerplay/eventmgr/eventactionchains.c | 291 -- .../drm/amd/powerplay/eventmgr/eventactionchains.h | 62 ---

[PATCH 1/4] drm/amd/powerplay: delete eventmgr layer in poweprlay

Change-Id: Ia34e09dd288d73bc7a64bf47646cd6898d01db7a Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h| 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 10 +- drivers/gpu/drm/amd/amdgpu/amdgpu_powerplay.c | 2 +-

[PATCH] drm/amdgpu: fix placement flags in amdgpu_ttm_bind

From: Christian König Otherwise we lose the NO_EVICT flag and can try to evict pinned BOs. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/amdgpu: declare the new firmware files needed by polaris asics

Change-Id: If0f280979d85c118dc05ebfa37207b8544abfa45 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index

Re: Regression: Re: [PATCH 2/3] drm/amdgpu: fix amdgpu_ttm_bind

Yeah, the bug is really obvious after you pointed it out. We just need to keep the placement flags. Going to send a fix to the list in a minute, Christian. Am 01.09.2017 um 00:50 schrieb Felix Kuehling: I believe this patch breaks pinned GTT BOs. It trips KFD tests that apply a lot of memory