Re: [PATCH] drm/amdgpu: fix amdgpu_vm_handle_moved as well

2017-09-12 Thread Christian König
+if (bo_va->base.bo->tbo.resv != vm->root.base.bo->tbo.resv) { When we expand mapping fence, we will sync all moved update and clear here, instead of moved update in amdgpu_vm_bo_update in previous patch. Yeah, turned out this patch actually didn't worked as expected because the bo

Re: [PATCH] drm/amdgpu: fix amdgpu_vm_handle_moved as well v2

2017-09-12 Thread zhoucm1
Reviewed-by: Chunming Zhou , but one commit inline... On 2017年09月11日 22:55, Christian König wrote: From: Christian König There is no guarantee that the last BO_VA actually needed an update. Additional to that all command submissions must wait for moved BOs to be cleared, not just the first o

[PATCH 1/5] drm/amdgpu: fix cgs alignment handling

2017-09-12 Thread Christian König
From: Christian König This always allocated on PAGE_SIZE alignment. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c

[PATCH 5/5] drm/amdgpu: simplify pinning into visible VRAM

2017-09-12 Thread Christian König
From: Christian König Just set the CPU access required flag when we pin it. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/g

[PATCH 4/5] drm/amdgpu: cleanup amdgpu_bo_pin_restricted

2017-09-12 Thread Christian König
From: Christian König Nobody is using the min/max interface any more. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 39 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 3 --- 2 files changed, 6 insertions(+), 36 deletions(-) diff

[PATCH 2/5] drm/amd: remove min/max addr handling from cgs

2017-09-12 Thread Christian König
From: Christian König Nobody is actually using this and it causes a bunch of unused and buggy code. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 48 ++- drivers/gpu/drm/amd/include/cgs_common.h | 7 ++-- drivers/gpu/drm/amd/po

[PATCH 3/5] drm/amdgpu: fix and cleanup amdgpu_bo_create

2017-09-12 Thread Christian König
From: Christian König Fix USWC handling by cleaning up the function and removing quite a bit of unused code. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 83 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 8 --- 2 files changed,

RE: [PATCH] iommu/amd: flush IOTLB for specific domains only (v3)

2017-09-12 Thread Nath, Arindam
Hi Daniel, >-Original Message- >From: Daniel Drake [mailto:dr...@endlessm.com] >Sent: Tuesday, September 12, 2017 12:20 PM >To: Nath, Arindam >Cc: Joerg Roedel ; Lendacky, Thomas >; io...@lists.linux-foundation.org; amd- >g...@lists.freedesktop.org; Deucher, Alexander >; Bridgman, John >;

[PATCH 0/5] ***[WIP] introduce syncfile as fence reuturn ***

2017-09-12 Thread Chunming Zhou
*** BLURB HERE *** Chunming Zhou (5): drm/amdgpu: introduce sync file for CS returning fence drm/amdgpu: add syncfile chunk support drm/amdgpu: add syncfile support to wait ioctl drm/amdgpu: add syncfile fence support to wait_any/all ioctl drm/amdgpu: expand mapping ioctl to return fence

[PATCH 1/5] drm/amdgpu: introduce sync file for CS returning fence

2017-09-12 Thread Chunming Zhou
Change-Id: If32e17d8fbdf1e158a34eca3de8687a8fc30f797 Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 11 +++ include/uapi/drm/amdgpu_drm.h | 2 ++ 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/

[PATCH 3/5] drm/amdgpu: add syncfile support to wait ioctl

2017-09-12 Thread Chunming Zhou
Change-Id: I79155cef5ee798899cd51a88825512cbf0d8ad82 Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 10 +- include/uapi/drm/amdgpu_drm.h | 2 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/dr

[PATCH 5/5] drm/amdgpu: expand mapping ioctl to return fence to UMD by using syncfile

2017-09-12 Thread Chunming Zhou
Change-Id: I88e56d34ec5e90fe8001e73d52e893a38938361e Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 24 +++- include/uapi/drm/amdgpu_drm.h | 4 +++- 2 files changed, 22 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgp

[PATCH 2/5] drm/amdgpu: add syncfile chunk support

2017-09-12 Thread Chunming Zhou
Change-Id: I9a9e8d474c2f31e71bdf9841a518fa48b3e5c33b Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 63 +- include/uapi/drm/amdgpu_drm.h | 3 ++ 2 files changed, 42 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/am

[PATCH 4/5] drm/amdgpu: add syncfile fence support to wait_any/all ioctl

2017-09-12 Thread Chunming Zhou
Change-Id: Ibe77f213560846ec12901e366129d9368750b7ba Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 ++ include/uapi/drm/amdgpu_drm.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdg

Re: [PATCH 0/5] ***[WIP] introduce syncfile as fence reuturn ***

2017-09-12 Thread Christian König
NAK for the CS part (but I think that was just as prove of concept anyway). Dave's sync object implementation is already done for this, the problem is that isn't merged yet into amd-staging-4.12 (but should be in 4-13). The VM part looks similar to what I had in mind, but we should base this

[PATCH] drm/amdgpu: improve PRT syncing

2017-09-12 Thread Christian König
From: Christian König Just clean that up a bit more. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drive

write to GRBM_GFX_INDEX without lock

2017-09-12 Thread Tom St Denis
In the file smu7_powertune.c we have int smu7_enable_didt_config(struct pp_hwmgr *hwmgr) { int result; uint32_t num_se = 0; uint32_t count, value, value2; struct cgs_system_info sys_info = {0}; sys_info.size = sizeof(struct cgs_system_info); sys_in

Re: [PATCH] drm/amd/display: Don't leak dc_stream_state.

2017-09-12 Thread Harry Wentland
On 2017-09-08 11:41 AM, Darren Salt wrote: > Noticed while playing “Valley”, which was causing some 8MB of leakage per > second. kmemleak listed many entries looking like this: > > unreferenced object 0x8802c2951800 (size 1024): > comm "Xorg", pid 2982, jiffies 4297410155 (age 392.78

[PATCH 4/6] drm/amd/powerplay: Remove unneeded return from pp_smu7_thermal_fini()

2017-09-12 Thread Tom St Denis
Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c index 064166b48d1f..6867363f561d 100644 --- a/drivers/gpu/

[PATCH 3/6] drm/amd/powerplay: Make use of PP_CAP in smu7_thermal.c

2017-09-12 Thread Tom St Denis
Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c index 0c822ef7d907..0

[PATCH 2/6] drm/amd/powerplay: Tidy up smu7_fan_ctrl_get_fan_speed_rpm()

2017-09-12 Thread Tom St Denis
Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c index a491f1201fda..0c822ef7d907 100644

[PATCH 1/6] drm/amd/powerplay: Tidy up smu7_fan_ctrl_get_fan_speed_info()

2017-09-12 Thread Tom St Denis
Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c index baddb569a8b8..a491f1201fda 1

[PATCH 5/6] drm/amd/powerplay: Make use of PP_CAP in smu7_powertune.c

2017-09-12 Thread Tom St Denis
Signed-off-by: Tom St Denis --- .../gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c | 42 ++ 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c index 1dc31a

[PATCH 6/6] drm/amd/powerplay: Tidy up smu7_enable_didt()

2017-09-12 Thread Tom St Denis
Signed-off-by: Tom St Denis --- .../gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c | 29 ++ 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c index 9b4189c

[PATCH 2/2] drm/amd/display: Disable pre-Vega ASICs be default

2017-09-12 Thread Harry Wentland
Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ drivers/gpu/drm/amd/display/Kconfig| 8 2 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 34671790ce80

[PATCH 1/2] drm/amd/display: Clean Kconfig formatting

2017-09-12 Thread Harry Wentland
Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/Kconfig | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display/Kconfig index 62ea9f600374..e91b6e57cf03 100644 --- a/dr

RE: [PATCH 3/5] drm/amdgpu: fix and cleanup amdgpu_bo_create

2017-09-12 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Tuesday, September 12, 2017 5:09 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 3/5] drm/amdgpu: fix and cleanup amdgpu_bo_create > > From: Christian König

RE: [PATCH 4/5] drm/amdgpu: cleanup amdgpu_bo_pin_restricted

2017-09-12 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Tuesday, September 12, 2017 5:09 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 4/5] drm/amdgpu: cleanup amdgpu_bo_pin_restricted > > From: Christian König

RE: write to GRBM_GFX_INDEX without lock

2017-09-12 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Tuesday, September 12, 2017 10:18 AM > To: amd-gfx mailing list > Subject: write to GRBM_GFX_INDEX without lock > > In the file smu7_powertune.c we have > > int smu7_ena

[PATCH v2] drm/amd/display: Don't leak dc_stream_state.

2017-09-12 Thread Darren Salt
Noticed while playing “Valley”, which was causing some 8MB of leakage per second. kmemleak listed many entries looking like this: unreferenced object 0x8802c2951800 (size 1024): comm "Xorg", pid 2982, jiffies 4297410155 (age 392.787s) hex dump (first 32 bytes): 00 50 f9

RE: [PATCH 2/6] drm/amd/powerplay: Tidy up smu7_fan_ctrl_get_fan_speed_rpm()

2017-09-12 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Tuesday, September 12, 2017 10:47 AM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH 2/6] drm/amd/powerplay: Tidy up > smu7_fan_ctrl_get_fan_speed

RE: [PATCH 6/6] drm/amd/powerplay: Tidy up smu7_enable_didt()

2017-09-12 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Tuesday, September 12, 2017 10:47 AM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH 6/6] drm/amd/powerplay: Tidy up smu7_enable_didt() > > Signe

RE: [PATCH 1/2] drm/amd/display: Clean Kconfig formatting

2017-09-12 Thread Deucher, Alexander
> -Original Message- > From: Harry Wentland [mailto:harry.wentl...@amd.com] > Sent: Tuesday, September 12, 2017 10:58 AM > To: amd-gfx@lists.freedesktop.org > Cc: airl...@gmail.com; Deucher, Alexander; dan...@ffwll.ch; Wentland, > Harry > Subject: [PATCH 1/2] drm/amd/display: Clean Kconfig

RE: [PATCH 2/2] drm/amd/display: Disable pre-Vega ASICs be default

2017-09-12 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Harry Wentland > Sent: Tuesday, September 12, 2017 10:58 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander; Wentland, Harry; airl...@gmail.com; > dan...@ffwll.ch > Subject: [PATC

[PATCH] drm/amd/powerplay: lock grbm_gfx index when changing instance

2017-09-12 Thread Tom St Denis
Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c index 8c264c195e1a..0f75af33e581 100644 --- a/dri

RE: [PATCH] drm/amd/powerplay: lock grbm_gfx index when changing instance

2017-09-12 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Tuesday, September 12, 2017 12:35 PM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH] drm/amd/powerplay: lock grbm_gfx index when changing > insta

[PATCH libdrm] amdgpu: print error messages when amdgpu_device_initialize is failing

2017-09-12 Thread Marek Olšák
From: Marek Olšák --- amdgpu/amdgpu_device.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c index 9a238d9..2b31c45 100644 --- a/amdgpu/amdgpu_device.c +++ b/amdgpu/amdgpu_device.c @@ -184,42 +184,47 @@ int

Re: [PATCH libdrm] amdgpu: print error messages when amdgpu_device_initialize is failing

2017-09-12 Thread Alex Deucher
On Tue, Sep 12, 2017 at 1:39 PM, Marek Olšák wrote: > From: Marek Olšák > Reviewed-by: Alex Deucher > --- > amdgpu/amdgpu_device.c | 19 --- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c > index 9a238d9..2b3

Re: [PATCH 1/5] drm/amdgpu: fix cgs alignment handling

2017-09-12 Thread Alex Deucher
On Tue, Sep 12, 2017 at 5:08 AM, Christian König wrote: > From: Christian König > > This always allocated on PAGE_SIZE alignment. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH 3/5] drm/amdgpu: fix and cleanup amdgpu_bo_create

2017-09-12 Thread Christian König
Am 12.09.2017 um 17:55 schrieb Deucher, Alexander: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Tuesday, September 12, 2017 5:09 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 3/5] drm/amdgpu: fix and cleanup amdg

Re: [PATCH 3/5] drm/amdgpu: fix and cleanup amdgpu_bo_create

2017-09-12 Thread Alex Deucher
On Tue, Sep 12, 2017 at 2:35 PM, Christian König wrote: > Am 12.09.2017 um 17:55 schrieb Deucher, Alexander: >>> >>> -Original Message- >>> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf >>> Of Christian König >>> Sent: Tuesday, September 12, 2017 5:09 AM >>> To: am

Re: [PATCH 0/8] Retry page fault handling for Vega10

2017-09-12 Thread Felix Kuehling
On 2017-09-12 01:48 AM, Oded Gabbay wrote: > +John, > > If Alex is fine with it then I'm fine with it as well, as long as this > is a temporary solution until some point where you have some > convergence between your internal code and the upstream one. Agreed. I want to converge those branches as

Re: [PATCH v2] drm/amd/display: Don't leak dc_stream_state.

2017-09-12 Thread Harry Wentland
On 2017-09-12 12:10 PM, Darren Salt wrote: > Noticed while playing “Valley”, which was causing some 8MB of leakage per > second. kmemleak listed many entries looking like this: > > unreferenced object 0x8802c2951800 (size 1024): > comm "Xorg", pid 2982, jiffies 4297410155 (age 392.78

[PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

2017-09-12 Thread Marek Olšák
From: Marek Olšák for being able to convert an amdgpu fence into one of the handles. Mesa will use this. Signed-off-by: Marek Olšák --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 61 + drivers/gpu/drm/amd/amdgpu/am

[PATCH 2/3] drm/syncobj: add a new helper drm_syncobj_get_fd

2017-09-12 Thread Marek Olšák
From: Marek Olšák Signed-off-by: Marek Olšák --- drivers/gpu/drm/drm_syncobj.c | 33 +++-- include/drm/drm_syncobj.h | 1 + 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 0bb17

[PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

2017-09-12 Thread Marek Olšák
From: Marek Olšák For amdgpu. drm_syncobj_create is renamed to drm_syncobj_create_as_handle, and new helpers drm_syncobj_create and drm_syncobj_get_handle are added. Signed-off-by: Marek Olšák --- drivers/gpu/drm/drm_syncobj.c | 49 +++ include/drm/drm_

[PATCH libdrm 1/4] amdgpu: add sync_file import and export functions

2017-09-12 Thread Marek Olšák
From: Marek Olšák --- amdgpu/amdgpu.h| 30 ++ amdgpu/amdgpu_cs.c | 20 2 files changed, 50 insertions(+) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index 238b1aa..b44b9b6 100644 --- a/amdgpu/amdgpu.h +++ b/amdgpu/amdgpu.h @@ -1383,6 +1383

[PATCH libdrm 2/4] drm: add drmSyncobjWait wrapper

2017-09-12 Thread Marek Olšák
From: Marek Olšák --- include/drm/drm.h | 24 xf86drm.c | 22 ++ xf86drm.h | 3 +++ 3 files changed, 49 insertions(+) diff --git a/include/drm/drm.h b/include/drm/drm.h index bf3674a..4da1667 100644 --- a/include/drm/drm.h +++ b/incl

[PATCH libdrm 4/4] amdgpu: add amdgpu_cs_fence_to_handle

2017-09-12 Thread Marek Olšák
From: Marek Olšák --- amdgpu/amdgpu.h | 14 ++ amdgpu/amdgpu_cs.c | 22 ++ include/drm/amdgpu_drm.h | 21 + 3 files changed, 57 insertions(+) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index 979acfc..23cde10 100644 --- a/amd

[PATCH libdrm 3/4] amdgpu: add amdgpu_cs_syncobj_wait

2017-09-12 Thread Marek Olšák
From: Marek Olšák --- amdgpu/amdgpu.h| 20 amdgpu/amdgpu_cs.c | 12 2 files changed, 32 insertions(+) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index b44b9b6..979acfc 100644 --- a/amdgpu/amdgpu.h +++ b/amdgpu/amdgpu.h @@ -1354,6 +1354,26 @@ int amdgpu_

[PATCH v2] drm/amd/display: Disable pre-Vega ASICs by default

2017-09-12 Thread Harry Wentland
v2: Clarify help text for pre-vega config Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ drivers/gpu/drm/amd/display/Kconfig| 9 + 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/a

[PATCH 4/8] drm/amdkfd: Separate doorbell allocation from PASID

2017-09-12 Thread Felix Kuehling
PASID management is moving into KGD. Limiting the PASID range to the number of doorbell pages is no longer practical. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 7 - drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c | 50 +-- drivers/gp

[PATCH 5/8] drm/amdkfd: Use PASID manager from KGD

2017-09-12 Thread Felix Kuehling
Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdkfd/kfd_module.c | 6 --- drivers/gpu/drm/amd/amdkfd/kfd_pasid.c | 90 ++--- 2 files changed, 38 insertions(+), 58 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_module.c b/drivers/gpu/drm/amd/amdkf

[PATCH 1/8] drm/amdgpu: Fix error handling in amdgpu_vm_init

2017-09-12 Thread Felix Kuehling
Make sure vm->root.bo is not left reserved if amdgpu_bo_kmap fails. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index

[PATCH 6/8] drm/amdgpu: Add prescreening stage in IH processing

2017-09-12 Thread Felix Kuehling
To filter out high-frequency interrupts that can be safely ignored. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 6 ++ drivers/gpu/drm/amd/amdgpu/cik_ih.c | 14 ++ drivers/gpu/drm/amd/amdgpu/cz_i

[PATCH 3/8] drm/radeon: Add PASID manager for KFD

2017-09-12 Thread Felix Kuehling
Signed-off-by: Felix Kuehling --- drivers/gpu/drm/radeon/radeon_kfd.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c index f6578c9..a2ac8ac 100644 --- a/drivers/gpu/drm/radeon/radeon_k

[PATCH 8/8] drm/amdgpu: Track pending retry faults in IH and VM (v2)

2017-09-12 Thread Felix Kuehling
IH tracks pending retry faults in a hash table for fast lookup in interrupt context. Each VM has a short FIFO of pending VM faults for processing in a bottom half. The IH prescreening stage adds retry faults and filters out repeated retry interrupts to minimize the impact of interrupt storms. It'

[PATCH 0/8] Retry page fault handling for Vega10

2017-09-12 Thread Felix Kuehling
Rebased on adeucher/amd-staging-4.13 and tested on Vega10 (graphics) and Kaveri (KFD). Meaningful graphics tests with retry faults enabled will only be possible after PASID support is added to amdgpu_cs. The chash table was moved to drivers/gpu/drm/amd/lib for now but is ready to move to lib if ne

[PATCH 2/8] drm/amdgpu: Add PASID management

2017-09-12 Thread Felix Kuehling
Allows assigning a PASID to a VM for identifying VMs involved in page faults. The global PASID manager is also exported in the KFD interface so that AMDGPU and KFD can share the PASID space. PASIDs of different sizes can be requested. On APUs, the PASID size is deterined by the capabilities of the

[PATCH 7/8] drm/amd: Closed hash table with low overhead

2017-09-12 Thread Felix Kuehling
This adds a statically sized closed hash table implementation with low memory and CPU overhead. The API is inspired by kfifo. Storing, retrieving and deleting data does not involve any dynamic memory management, which makes it ideal for use in interrupt context. Static memory usage per entry compr

Re: [PATCH v2] drm/amd/display: Disable pre-Vega ASICs by default

2017-09-12 Thread Ernst Sjöstrand
Add Fiji to the help text? Regards //Ernst 2017-09-12 22:46 GMT+02:00 Harry Wentland : > v2: Clarify help text for pre-vega config > > Signed-off-by: Harry Wentland > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ > drivers/gpu/drm/amd/display/Kconfig| 9 + > 2 files c

Re: [PATCH v2] drm/amd/display: Disable pre-Vega ASICs by default

2017-09-12 Thread Alex Deucher
On Tue, Sep 12, 2017 at 8:30 PM, Ernst Sjöstrand wrote: > Add Fiji to the help text? Maybe just say DCE8, 10, 11. Alex > > Regards > //Ernst > > 2017-09-12 22:46 GMT+02:00 Harry Wentland : >> v2: Clarify help text for pre-vega config >> >> Signed-off-by: Harry Wentland >> --- >> drivers/gpu/d

Re: [PATCH 0/5] ***[WIP] introduce syncfile as fence reuturn ***

2017-09-12 Thread zhoucm1
On 2017年09月12日 19:00, Christian König wrote: NAK for the CS part (but I think that was just as prove of concept anyway). Dave's sync object implementation is already done for this, the problem is that isn't merged yet into amd-staging-4.12 (but should be in 4-13). Yeah, I already realized i

Re: [PATCH] drm/amdgpu: improve PRT syncing

2017-09-12 Thread zhoucm1
Could you stop the clean for syncing? and wait we turn back performance first? Since you merge too kinds of fence to vm->last_update, we will be difficult to optimize which fence can remove. Regards, David Zhou On 2017年09月12日 20:06, Christian König wrote: From: Christian König Just clea

[PATCH xf86-video-amdgpu] Clarify when TearFree is automatically enabled.

2017-09-12 Thread Darren Salt
--- man/amdgpu.man | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/amdgpu.man b/man/amdgpu.man index c38defe..0d9dd93 100644 --- a/man/amdgpu.man +++ b/man/amdgpu.man @@ -80,8 +80,8 @@ separate scanout buffers need to be allocated for each CRTC with TearFree on. If th

Re: [PATCH 4/5] drm/amdgpu: cleanup amdgpu_bo_pin_restricted

2017-09-12 Thread zhoucm1
On 2017年09月12日 23:59, Deucher, Alexander wrote: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Tuesday, September 12, 2017 5:09 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 4/5] drm/amdgpu: cleanup amdgpu_bo_pin

[pull] amdgpu and ttm drm-next-4.14

2017-09-12 Thread Alex Deucher
Hi Dave, A few fixes for 4.14. Nothing too major. The following changes since commit 7c0059dd832cc686bf0febefdcf8295cdd93007f: Merge branch 'linux-4.14' of git://github.com/skeggsb/linux into drm-next (2017-08-23 05:32:26 +1000) are available in the git repository at: git://people.freede

Re: [PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

2017-09-12 Thread zhoucm1
Hi Marek, You're doing same things with me, see my "introduce syncfile as fence reuturn" patch set, which makes things more simple, we just need to directly return syncfile fd to UMD when CS, then the fence UMD get will be always syncfile fd, UMD don't need to construct ip_type/ip_instance/ct

Re: [PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

2017-09-12 Thread Christian König
Hi guys, Mareks IOCTL proposal looks really good to me. Please note that we already have sync_obj support for the CS IOCTL in the 4.13 branch and this work is based on top of that. UMD don't need to construct ip_type/ip_instance/ctx_id/ring Well the UMD does want to construct ip_type/ip_inst