From: Shirish S
Adding affected planes without checking if modeset is requested from the user
space causes performance regression in video p/b scenarios when full screen p/b
is not composited.
Hence add a check before adding a plane as affected.
bug: https://bugs.freedesktop.org/show_bug.cgi
Patches 1,2,6,24-26,28 are
Reviewed-by: Andrey Grodzovsky
On 2017-10-26 02:34 PM, Harry Wentland wrote:
* Remove annoyning Freesync warning
* Fix Freesync and amd-stg which was broken in last set of patches
* Fix issue with plugging in displays during S3
* Bunch of generic fixes found
On 2017-10-26 02:34 PM, Harry Wentland wrote:
From: "Leo (Sunpeng) Li"
Abandon new_crtcs array and use for_each_new iterator to acquire new
crtcs.
Signed-off-by: Leo (Sunpeng) Li
Reviewed-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 36 +-
On 2017-10-26 02:35 PM, Harry Wentland wrote:
We need to avoid calling reset after detection.
Could you explain why please ?
This is much simpler
if we call ->reset on the connector right after creation but before
detection. To stay consistent call ->reset on every other object
as well afte
Am 26.10.2017 19:26, schrieb Alex Deucher:
On Thu, Oct 26, 2017 at 10:10 AM, Dieter Nützel
wrote:
Hello Alex & Rex,
any progress?
The 'screen blank' (monitor standby mode) is really annoying.
Does this patch help?
https://cgit.freedesktop.org/~agd5f/linux/commit/?h=amd-staging-drm-next&id=dd
The test will Reserve a VMID, submit a command and
unreserve the VMID.
Change-Id: I2e5320b2c3044d1375bc5b18d936d3c0637f5daa
Signed-off-by: Andrey Grodzovsky
---
tests/amdgpu/Makefile.am | 3 +-
tests/amdgpu/amdgpu_test.c | 7 +++
tests/amdgpu/amdgpu_test.h | 15 +
tests/amdgpu/vm_test
Change-Id: I7eafb85c1ca96d6d255f0183bed0ce4129746fe0
Signed-off-by: Andrey Grodzovsky
---
amdgpu/Makefile.sources | 1 +
amdgpu/amdgpu.h | 20 +++
amdgpu/amdgpu_vm.c | 52 +
3 files changed, 73 insertions(+)
create mod
> -Original Message-
> From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com]
> Sent: Thursday, October 26, 2017 2:39 PM
> To: Deucher, Alexander; 'Christian König'; amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH 5/8] drm/amdgpu: don't use ttm_bo_move_ttm in
> amdgpu_ttm_bind
On 2017-10-26 04:08 PM, Harry Wentland wrote:
v2: Also don't print for ERESTARTSYS or EAGAIN
Signed-off-by: Harry Wentland
Reviewed-by: Andrey Grodzovsky
Thanks,
Andrey
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
v2: Also don't print for ERESTARTSYS or EAGAIN
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdg
On 2017-10-26 03:42 PM, Harry Wentland wrote:
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/
On 2017-10-26 02:56 PM, Andrey Grodzovsky wrote:
>
>
> On 2017-10-26 02:43 PM, Christian König wrote:
>> Am 26.10.2017 um 19:56 schrieb Deucher, Alexander:
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
Of Christian König
Sent
Signed-off-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index cf15701f208d..5593ff05d2a6 100644
On 2017-10-26 02:43 PM, Christian König wrote:
Am 26.10.2017 um 19:56 schrieb Deucher, Alexander:
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
Of Christian König
Sent: Thursday, October 26, 2017 12:06 PM
To: amd-gfx@lists.freedesktop.org
Sub
On 2017-10-26 02:11 PM, Christian König wrote:
> But now reading the patch there is something else which I stumbled over:
>> - WARN_ON(atomic_read(&p->mm->mm_count) <= 0);
>> + /*
>> + * This cast should be safe here because we grabbed a
>> + * reference to the mm in kfd_process_notif
Am 26.10.2017 um 19:56 schrieb Deucher, Alexander:
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
Of Christian König
Sent: Thursday, October 26, 2017 12:06 PM
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH 4/8] drm/amdgpu: don't wait interrupt
Am 26.10.2017 um 19:55 schrieb Deucher, Alexander:
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
Of Christian König
Sent: Thursday, October 26, 2017 12:06 PM
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH 2/8] drm/amdgpu: always bind pinned B
Am 26.10.2017 um 20:11 schrieb Deucher, Alexander:
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
Of Christian König
Sent: Thursday, October 26, 2017 12:06 PM
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH 5/8] drm/amdgpu: don't use ttm_bo_mov
We'll need it in amdgpu_dm_mst_types.c as well.
Signed-off-by: Harry Wentland
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 -
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 12
2 files changed, 12 inse
We need to avoid calling reset after detection. This is much simpler
if we call ->reset on the connector right after creation but before
detection. To stay consistent call ->reset on every other object
as well after creation.
Signed-off-by: Harry Wentland
Reviewed-by: Roman Li
Acked-by: Harry We
From: Andrew Jiang
Signed-off-by: Andrew Jiang
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_timing_generator.c
b/drivers/gpu/
We're an atomic driver and shouldn't access legacy properties. Doing so
will only scare users with stack traces.
Instead save the prop in the state and access it directly. Much simpler.
Signed-off-by: Harry Wentland
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/disp
Signed-off-by: Harry Wentland
Reviewed-by: Mikita Lipski
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/d
With our recent change to save Freesync properties as part
of the atomic state we removed the call to enable freesync
when the property is being set. Apparently that is still
needed.
Signed-off-by: Harry Wentland
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/
From: Tony Cheng
Signed-off-by: Tony Cheng
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
b/drivers/gpu/drm/amd/display/dc/dc.h
index e39371797eeb
No need for multiple labels as kfree will always do a NULL check
before freeing the memory.
Signed-off-by: Harry Wentland
Reviewed-by: Bhawanpreet Lakha
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 24 +++
1 file
From: Charlene Liu
Signed-off-by: Charlene Liu
Reviewed-by: Krunoslav Kovac
Acked-by: Harry Wentland
---
.../drm/amd/display/dc/dce/dce_stream_encoder.c| 25 +++---
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_stream
From: Yue Hin Lau
fix memory leak
Signed-off-by: Yue Hin Lau
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resour
From: Hersen Wu
Signed-off-by: Hersen Wu
Reviewed-by: Tony Cheng
Reviewed-by: Wenjing Liu
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 32 +--
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/d
From: Anthony Koo
Need to move HDR Metadata from Surface to Stream since there is only one
infoframe possible per stream.
Also cleaning up some duplicate definitions.
Signed-off-by: Anthony Koo
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/core/dc.c
From: Dmytro Laktyushkin
Recout split rounding code was wrong
Signed-off-by: Dmytro Laktyushkin
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/a
From: Dmytro Laktyushkin
Previous recout calculation fix changed recout size rounding
and affected the offset when it should not have
Signed-off-by: Dmytro Laktyushkin
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 ++--
1 file chan
From: Yongqiang Sun
Add disable ttu interface to dcn10, when remove
mpc, disable ttu as well.
Signed-off-by: Yongqiang Sun
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 9 +
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_
From: Eric Yang
For DP active dongles, the dpcd dongle caps are read but not
used to validate mode timing. This addresses this.
In particular, this change fixes light up on the HDMI 4k TV
connected through DP active dongle. Since the 4k TV defaults
to YCbCr420, which the dongle don't support.
T
From: Yongqiang Sun
Since front end is programmed before back end programming,
no need to reset front end in back end programming.
Signed-off-by: Yongqiang Sun
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 3 +-
.../drm/amd/display
From: Yue Hin Lau
moving hubbub functions to new file
Signed-off-by: Yue Hin Lau
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/dcn10/Makefile | 3 +-
.../gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c| 494 +
.../gpu/drm/amd/d
From: Roman Li
Clean fake sink flag on resume if real sink connected.
Fixing S3 topology change problem like this:
1) x desktop with 1 or > displays
2) unplug display
3) suspend
4) replug same display
5) resume
without this change replugged display doesn't light up
Signed-off-by: Roman Li
Revie
* Remove annoyning Freesync warning
* Fix Freesync and amd-stg which was broken in last set of patches
* Fix issue with plugging in displays during S3
* Bunch of generic fixes found during Raven bringup
* Whole bunch of Raven fixes and work
Andrew Jiang (3):
drm/amd/display: Reject PPLib cl
From: "Leo (Sunpeng) Li"
Abandon new_crtcs array and use for_each_new iterator to acquire new
crtcs.
Signed-off-by: Leo (Sunpeng) Li
Reviewed-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 36 +--
1 file changed, 14 insertions(+), 22 deletions(-
From: Yongqiang Sun
front end is initialized during init_hw, but not
power gated. There are some left over valuse and will
cause some diags test failed. Power gated all front
end pipes will make sure every test has same starting
point.
Signed-off-by: Yongqiang Sun
Reviewed-by: Tony Cheng
Acked
From: SivapiriyanKumarasamy
Signed-off-by: SivapiriyanKumarasamy
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 4 +-
drivers/gpu/drm/amd/display/dc/dc.h| 7 ++
drivers/gpu/drm/amd/display/dc/dc_types.h | 5
From: Yue Hin Lau
instantiating new structure hubbub in resource.c
Signed-off-by: Yue Hin Lau
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
.../gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c| 88 ++-
.../gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.h| 162 ++
From: Tony Cheng
Signed-off-by: Tony Cheng
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
b/drivers/gpu/drm/amd/display/dc/dc.h
index 32d71ef20c67
From: Tony Cheng
Signed-off-by: Tony Cheng
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/dc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h
b/drivers/gpu/drm/amd/display/dc/dc.h
index 9ca838b3c4d7
From: Andrew Jiang
We should be sticking with the default clock values if the values
obtained from PPLib are bogus.
Signed-off-by: Andrew Jiang
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c | 68
1 file changed,
From: Andrew Jiang
Get rid of the constant we copied over before and just directly use the
constants from the file.
Signed-off-by: Andrew Jiang
Reviewed-by: Tony Cheng
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +++---
1 file changed, 3 insertions(+), 3 de
Atomic drivers should not use legacy properties but atomic properties
don't support the immutable flag. Remove the immutable flag for now.
This will be followed by a bunch of DC patches to start treating
freesync_capable as an atomic property on a connector_state.
Eventually we'll want to remove
From: "Leo (Sunpeng) Li"
For better readability.
Signed-off-by: Leo (Sunpeng) Li
Reviewed-by: Bhawanpreet Lakha
Acked-by: Harry Wentland
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/d
Am 26.10.2017 um 18:47 schrieb Felix Kuehling:
On 2017-10-26 03:33 AM, Christian König wrote:
Am 21.10.2017 um 02:23 schrieb Felix Kuehling:
The kfd_process doesn't own a reference to the mm_struct, so it can
disappear without warning even while the kfd_process still exists.
In fact, the delaye
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Thursday, October 26, 2017 12:06 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH 5/8] drm/amdgpu: don't use ttm_bo_move_ttm in
> amdgpu_ttm_bind
>
> From: Chr
Reviewed-by: Andrey Grodzovsky
On 2017-10-26 12:06 PM, Christian König wrote:
From: Christian König
Just set the bit so that DC does the hardware programming.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
1 file changed, 2 insertions(+)
dif
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Thursday, October 26, 2017 12:06 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH 8/8] drm/amdgpu: allow framebuffer in GART memory as
> well
>
> From: Christi
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Thursday, October 26, 2017 12:06 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH 7/8] drm/amdgpu: fix indentation in amdgpu_display.h
>
> From: Christian Köni
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Thursday, October 26, 2017 12:06 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH 6/8] drm/amd/display: enable GPU VM support
>
> From: Christian König
>
> J
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Thursday, October 26, 2017 12:06 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH 2/8] drm/amdgpu: always bind pinned BOs
>
> From: Christian König
>
> We al
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Thursday, October 26, 2017 12:06 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH 3/8] drm/amdgpu: fix pin domain compatibility check
>
> From: Christian König
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Thursday, October 26, 2017 12:06 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH 4/8] drm/amdgpu: don't wait interruptible while binding
> GART space
>
> From
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Thursday, October 26, 2017 12:06 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH 1/8] drm/amdgpu: use the actual placement for pin
> accounting
>
> From: Chri
On Thu, Oct 26, 2017 at 10:10 AM, Dieter Nützel wrote:
> Hello Alex & Rex,
>
> any progress?
> The 'screen blank' (monitor standby mode) is really annoying.
Does this patch help?
https://cgit.freedesktop.org/~agd5f/linux/commit/?h=amd-staging-drm-next&id=ddabbf65aae36e21b4c79354940f80eae6c36104
If a pull request would be a set of patches, that would be lots of
patches. The freedesktop.org repository has an amd-staging branch that
seems to be the closest to my WIP branch. The difference is 84 patches.
Regards,
Felix
On 2017-10-26 03:48 AM, Oded Gabbay wrote:
> I have no problem.
> Do
On 2017-10-26 03:33 AM, Christian König wrote:
> Am 21.10.2017 um 02:23 schrieb Felix Kuehling:
>> The kfd_process doesn't own a reference to the mm_struct, so it can
>> disappear without warning even while the kfd_process still exists.
>> In fact, the delayed kfd_process teardown is triggered by a
From: Christian König
Just unbind and rebind to force updates of the GART space.
This prevents forcing the BO to be idle.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/dr
From: Christian König
We need to test if any domain fits, not all of them.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
b/drivers/gpu/drm/amd/amdgpu/
From: Christian König
Just set the bit so that DC does the hardware programming.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/d
From: Christian König
On CZ and newer APUs we can pin the fb into GART as well as VRAM.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 13 -
drivers/gpu/drm/amd/amdgpu/amdgpu_display.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
From: Christian König
That was somehow completely of.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu_display
From: Christian König
Display can't seem to handle this correctly.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
i
From: Christian König
We always need to bind pinned BOs, not just when the caller requested the
address.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/a
From: Christian König
This allows us to specify multiple possible placements again.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
b/drivers/gpu/drm/amd/amdgpu/amdgp
Am 26.10.2017 um 17:09 schrieb Michel Dänzer:
From: Michel Dänzer
It's dead code.
Signed-off-by: Michel Dänzer
Just wanted to do the same thing while working on GART scanout on CZ.
Patch is Reviewed-by: Christian König .
Christian.
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
Am 26.10.2017 um 16:46 schrieb Michel Dänzer:
From: Michel Dänzer
Hardcoding the maximum numbers could result in spurious error messages
from the IRQ state callbacks, e.g. on Polaris 11/12:
[drm:dce_v11_0_set_pageflip_irq_state [amdgpu]] *ERROR* invalid pageflip crtc 5
[drm:amdgpu_irq_disable_
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Michel Dänzer
> Sent: Thursday, October 26, 2017 10:46 AM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH 3/3] amdgpu: Remove
> AMDGPU_{HPD,CRTC_IRQ,PAGEFLIP_IRQ}_LAST
>
> From: Michel
Am 26.10.2017 um 13:08 schrieb Liu, Monk:
"Clear operation on the page table " is some kind of SDMA activity right? What
if ASIC RESET from amd_gpu_recover() interrupted this activity in fly ???
I can't see any difference between the handling of existing VMs and new
created ones.
Either we ha
Unnecessary, we know that the scheduler is already awake because it is
processing this function.
[ml] WHAT ??? this wake_up operate on job_scheduled, like the one at the bottom of sched_main(), It is
used to wake up the thread waiting in "sched_entity_fini" on this
"sched->job_scheduled", I do
From: Michel Dänzer
It's dead code.
Signed-off-by: Michel Dänzer
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 21 ++---
1 file changed, 6 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amd
From: Michel Dänzer
Corresponding to the previous non-DC change.
Signed-off-by: Michel Dänzer
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 9 ++---
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/d
From: Michel Dänzer
Hardcoding the maximum numbers could result in spurious error messages
from the IRQ state callbacks, e.g. on Polaris 11/12:
[drm:dce_v11_0_set_pageflip_irq_state [amdgpu]] *ERROR* invalid pageflip crtc 5
[drm:amdgpu_irq_disable_all [amdgpu]] *ERROR* error disabling interrupt
From: Michel Dänzer
Not used anymore.
Signed-off-by: Michel Dänzer
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
index 2b1f96ce2a04..4069a3b2f55f 100644
---
Hello Alex & Rex,
any progress?
The 'screen blank' (monitor standby mode) is really annoying.
Thanks,
Dieter
Am 23.10.2017 03:03, schrieb Dieter Nützel:
Am 22.10.2017 23:48, schrieb Dieter Nützel:
Am 21.10.2017 23:22, schrieb Alex Deucher:
Hi Dave,
Last batch of new stuff for DC. Highlights
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Evan Quan
> Sent: Thursday, October 26, 2017 5:36 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Quan, Evan
> Subject: [PATCH] drm/amd/powerplay: describe the PCIE link speed in right
> GT/s
>
The simple way I can think of to remove the @skip param for run_job is that we
introduce a new member "skip" in sched_job, and remove fake_signal() function,
So we always set "skip" in sched_job before run_job(), and in run_job() we skip
the real ib_schedule if found job->skip == true,
That way
"Clear operation on the page table " is some kind of SDMA activity right? What
if ASIC RESET from amd_gpu_recover() interrupted this activity in fly ???
BR Monk
-Original Message-
From: Koenig, Christian
Sent: 2017年10月26日 18:54
To: Liu, Monk ; amd-gfx@lists.freedesktop.org
Subject: Re:
I have reverted
[PATCH 2/2] drm/amd/display: cleanup addReq and fix fb_location
and applied
[PATCH] drm/amd/display: fix high part address in dm_plane_helper_prepare_fb()
onto amd-drm-staging kernel.
Regards,
Shirish S
-Original Message-
From: Michel Dänzer [mailto:mic...@daenzer.net
> + dma_fence_set_error(&s_fence->finished, -ECANCELED);
> +
> + /* fake signaling the scheduled fence */
> + atomic_inc(&sched->hw_rq_count);
> + amd_sched_fence_scheduled(s_fence);
> + wake_up(&sched->job_scheduled);
Unnecessary, we know that the scheduler is already awake be
if we don't block device open while gpu doing recover, the vm init (SDMA
working on page table creating) would be ruined by ASIC RESET
That is not a problem at all. SDMA just does some clear operation on the
page tables and those are either recovered from the shadow or run after
the reset.
Re
Am 26.10.2017 um 12:30 schrieb Monk Liu:
jobs are skipped under two cases
1)when the entity behind this job marked guilty, the job
poped from this entity's queue will be dropped in sched_main loop.
2)in job_recovery(), skip the scheduling job if its karma detected
above limit, and also skipped a
1,no sriov check since gpu recover is unified
2,need CPU_ACCESS_REQUIRED flag for VRAM if SRIOV
because otherwise after following PIN the first allocated
VRAM bo is wasted due to some TTM mgr reason.
Change-Id: I4d029f2da8bb463942c7861d3e52f309bdba9576
Signed-off-by: Monk Liu
---
drivers/gpu/drm
Change-Id: Ibdb0ea9e3769d572fbbc13bbf1ef73f1af2ab7be
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index 4a9f749..c155ce4 100644
--- a/dr
1,new imple names amdgpu_gpu_recover which gives more hint
on what it does compared with gpu_reset
2,gpu_recover unify bare-metal and SR-IOV, only the asic reset
part is implemented differently
3,gpu_recover will increase hang job karma and mark its entity/context
as guilty if exceeds limit
V2:
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c
b/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c
index f8522a0..a43cffb 100644
--- a/drivers/gpu/drm/amd/amdgpu/mxgpu
for SR-IOV when doing gpu reset this routine shouldn't do
resource allocating otherwise memory leak
Change-Id: I25da3a5b475196c75c7e639adc40751754625968
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
jobs are skipped under two cases
1)when the entity behind this job marked guilty, the job
poped from this entity's queue will be dropped in sched_main loop.
2)in job_recovery(), skip the scheduling job if its karma detected
above limit, and also skipped as well for other jobs sharing the
same fenc
since now gpu reset is unified with gpu_recover
for both bare-metal and SR-IOV:
1)rename in_sriov_reset to in_gpu_reset
2)move lock_reset from adev->virt to adev
Change-Id: I9f4dbab9a4c916fbc156f669824d15ddcd0f2322
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++-
v2 series:
fixed some logic error in "imple job skip feature"
merge two patches into "implement new GPU recover(v3)"
Monk Liu (7):
amd/scheduler:imple job skip feature(v2)
drm/amdgpu:implement new GPU recover(v3)
drm/amdgpu:cleanup in_sriov_reset and lock_reset
drm/amdgpu:cleanup ucode_i
Change-Id: Icfd2c50ce168d8ccf3cc329eb906a56bab0a8c1d
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/amdgpu/ci_dpm.c| 6 +++---
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 6 +++---
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 +++---
3 files changed, 9 inserti
When amdgpu_gpu_recover() routine is in the fly, we shouldn't let UMD open our
device, otherwise the VM init would be ruined by gpu_recover().
e.g. VM init need to create page table, but keep In mind that gpu_recover()
calls ASIC RESET,
if we don't block device open while gpu doing recover, th
I spit the patch due to convenience for reviewing
Thought so, but this way we can't see the delta for reviewing.
Splitting up in multiple patches makes only sense if you can limit the
patch to one component or functionality change at a time.
Christian.
Am 26.10.2017 um 10:13 schrieb Liu, Mon
Yeah I know I can squash them,
I spit the patch due to convenience for reviewing
-Original Message-
From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com]
Sent: 2017年10月26日 15:13
To: Liu, Monk ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/9] drm/amdgpu:replace deprecate
Christian
Looks something is misunderstanding in this patch:
> - if (job->vram_lost_counter != atomic_read(&adev->vram_lost_counter)) {
> +
> + if (skip || job->vram_lost_counter !=
> atomic_read(&adev->vram_lost_counter)) {
> + /* skip ib schedule if looks needed, and set err
I have no problem.
Do you think you could send me a pull request ?
In any case, we probably should add more people to the project's git
access list.
Oded
On Thu, Oct 26, 2017 at 6:37 AM, Tom Stellard wrote:
> On 10/24/2017 10:24 AM, Oded Gabbay wrote:
>> Hi Tom,
>> I have commit access.
>
> Wha
1 - 100 of 109 matches
Mail list logo
