[bug report] drm/amdgpu/display: Add core dc support for DCN

2017-11-04 Thread Dan Carpenter
Hello Harry Wentland, The patch 70ccab604049: "drm/amdgpu/display: Add core dc support for DCN" from May 8, 2017, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:1696 dcn10_translate_regamma_to_hw_format() warn:

[bug report] drm/amd/display: Merge amdgpu_dm_types and amdgpu_dm

2017-11-04 Thread Dan Carpenter
Hello Harry Wentland, The patch e7b07ceef2a6: "drm/amd/display: Merge amdgpu_dm_types and amdgpu_dm" from Aug 10, 2017, leads to the following static checker warning: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:3895 amdgpu_dm_commit_planes() error: double unlock '

Re: [PATCH] drm/amd/display: indent an if statement

2017-11-04 Thread Christian König
Am 04.11.2017 um 10:16 schrieb walter harms: Am 04.11.2017 07:12, schrieb Dan Carpenter: The if statement wasn't indented so it makes static analysis tools and probably very recent GCC versions complain. Signed-off-by: Dan Carpenter --- I went over 80 characters because other lines do already

Re: [PATCH] drm/amd/display: indent an if statement

2017-11-04 Thread walter harms
Am 04.11.2017 07:12, schrieb Dan Carpenter: > The if statement wasn't indented so it makes static analysis tools and > probably very recent GCC versions complain. > > Signed-off-by: Dan Carpenter > --- > I went over 80 characters because other lines do already and it seemed > like the cleanest

Re: [PATCH 1/1] drm/amd/powerplay: initialize a variable before using it

2017-11-04 Thread Nicolas Iooss
On Sun, Sep 3, 2017 at 2:00 PM, Nicolas Iooss wrote: > > Function vega10_apply_state_adjust_rules() only initializes > stable_pstate_sclk_dpm_percentage when > data->registry_data.stable_pstate_sclk_dpm_percentage is not between 1 > and 100. The variable is then used to compute stable_pstate_sclk,

Re: [PATCH umr] Skip ahead if PDE entry is actually a PTE entry.

2017-11-04 Thread Christian König
Close, but not perfect. Reading an address seem to work, but the --vm-decode output is a bit confusing: [VERBOSE]: PDE0=0x0003fefff001, VA=0x, PBA==0x0003fefff000, V=1, S=0, C=0, P=0 [VERBOSE]:    \-> PDE1=0x0003feffe001, VA=0x4000, PBA==0x0003feffe000, V=1, S=0, C=

[PATCH libdrm 1/2] amdpgu: fix coding style in amdgpu_vamgr.c

2017-11-04 Thread Christian König
No functional change. Signed-off-by: Christian König --- amdgpu/amdgpu_vamgr.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/amdgpu/amdgpu_vamgr.c b/amdgpu/amdgpu_vamgr.c index 2b1388ed..8516b594 100644 --- a/amdgpu/amdgpu_vamgr.c +++ b/amdgpu/

[PATCH libdrm 2/2] amdgpu: sanitize 64bit VA manager

2017-11-04 Thread Christian König
Adding the extra reservation of the 32bit space to the 64bit manager is complete nonsense and just a waste of memory and CPU cycles. Signed-off-by: Christian König --- amdgpu/amdgpu_device.c | 24 ++-- amdgpu/amdgpu_internal.h | 7 --- amdgpu/amdgpu_vamgr.c| 4 ++-

[PATCH umr] Skip ahead if PDE entry is actually a PTE entry. (v2)

2017-11-04 Thread Tom St Denis
Signed-off-by: Tom St Denis (v2) Don't print out PDE entries with PTE bit set --- src/lib/read_vram.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/lib/read_vram.c b/src/lib/read_vram.c index 0df48dadec12..51823d71021e 100644 --- a/src/lib/read_vram.c +++ b/src/l