[PATCH] drm/amd/pp: Use forward declaration in ppatomfwctrl.h

2018-04-03 Thread Rex Zhu
Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/ppatomfwctrl.c | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/ppatomfwctrl.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomfwctrl.c b/drivers/gpu/drm/amd/powerplay/hwmgr

Re: Tonga Kernel Modesetting Issue

2018-04-03 Thread Ian Bashford
Thanks Alex - I’ll try the latest kernels first and see where that gets me. I’ll move on to trying to track down a commit if that fails... It’s a dell 27” monitor connected via DVI dual - nothing else along the path so a fairly straightforward setup. Ian On Mon, 2 Apr 2018 at 20:21, Alex Deuche

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Michel Dänzer
On 2018-04-01 07:45 PM, Ilia Mirkin wrote: > On Sun, Apr 1, 2018 at 1:39 PM, Christian König > wrote: >> Am 30.03.2018 um 22:45 schrieb Takashi Iwai: >>> >>> amdgpu driver lacks of modeset module option other drm drivers provide >>> for enforcing or disabling the driver load. Interestingly, the >

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Christian König
Am 03.04.2018 um 10:36 schrieb Michel Dänzer: On 2018-04-01 07:45 PM, Ilia Mirkin wrote: On Sun, Apr 1, 2018 at 1:39 PM, Christian König wrote: Am 30.03.2018 um 22:45 schrieb Takashi Iwai: amdgpu driver lacks of modeset module option other drm drivers provide for enforcing or disabling the dr

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Takashi Iwai
On Tue, 03 Apr 2018 10:57:56 +0200, Christian K6nig wrote: > > Am 03.04.2018 um 10:36 schrieb Michel Dänzer: > > On 2018-04-01 07:45 PM, Ilia Mirkin wrote: > >> On Sun, Apr 1, 2018 at 1:39 PM, Christian König > >> wrote: > >>> Am 30.03.2018 um 22:45 schrieb Takashi Iwai: > amdgpu driver lack

[PATCH 0/8] The vega10 sriov still need those patches

2018-04-03 Thread Emily Deng
For vega10 sriov, still need to use one package for invalidate tlb flush Emily Deng (8): Revert "Revert "drm/amdgpu: add emit_reg_write_reg_wait ring callback"" Revert "Revert "drm/amdgpu/sdma4: add emit_reg_write_reg_wait ring callback"" Revert "Revert "drm/amdgpu/uvd7: add emit_reg

[PATCH 1/8] Revert "Revert "drm/amdgpu: add emit_reg_write_reg_wait ring callback""

2018-04-03 Thread Emily Deng
This reverts commit cd1f3f010b9ab5f06612cf775b32bdba599f59d7. The vega10 sriov still need these patches --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 20 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 7 +++ 3 files changed,

[PATCH 2/8] Revert "Revert "drm/amdgpu/sdma4: add emit_reg_write_reg_wait ring callback""

2018-04-03 Thread Emily Deng
This reverts commit eede70ab868f9a3803ad304a5ab61adfa76e669b. The vega10 sriov still need these patches. --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c index 2c6

[PATCH 3/8] Revert "Revert "drm/amdgpu/uvd7: add emit_reg_write_reg_wait ring callback""

2018-04-03 Thread Emily Deng
This reverts commit 162499bed04e4c51dd0fcbfa1515f9b044f8925e. The vega10 sriov still need these patches. --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c index eddc57f..280c0

[PATCH 5/8] Revert "Revert "drm/amdgpu/vcn1: add emit_reg_write_reg_wait ring callback""

2018-04-03 Thread Emily Deng
This reverts commit bb85e01404ab39c01786d64312a602d5540a9944. The vega10 sriov still need these patches. --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c index 8c13267..d9a15

[PATCH 4/8] Revert "Revert "drm/amdgpu/vce4: add emit_reg_write_reg_wait ring callback""

2018-04-03 Thread Emily Deng
This reverts commit afb1f304302f797ff686b6250e34b2244c4a17a4. The vega10 sriov still need these patches. --- drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v4_0.c index 73fd48d..8fd1b

Re: [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-03 Thread Daniel Vetter
On Thu, Mar 29, 2018 at 01:34:24PM +0200, Christian König wrote: > Am 29.03.2018 um 08:57 schrieb Daniel Vetter: > > On Sun, Mar 25, 2018 at 12:59:56PM +0200, Christian König wrote: > > > Add a peer2peer flag noting that the importer can deal with device > > > resources which are not backed by page

[PATCH 6/8] Revert "Revert "drm/amdgpu/gmc9: use amdgpu_ring_emit_reg_write_reg_wait in gpu tlb flush""

2018-04-03 Thread Emily Deng
This reverts commit c41ed7ebba8eb6df266783f54a4d3d643252ea75. The vega10 sriov still need these patches. --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_

[PATCH 7/8] Revert "Revert "drm/amdgpu/sdma4:fix sdma engine hang""

2018-04-03 Thread Emily Deng
This reverts commit 5044a9e3253d089cf195fc3d52da5b5234f950ec. The vega10 sriov still need these patches. --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_

[PATCH 8/8] drm/amdgpu/gfx9: add emit_reg_write_reg_wait ring callback

2018-04-03 Thread Emily Deng
This adds support for writing and reading back in a single oneshot packet. This is needed to send a tlb invalidation and wait for ack in a single operation. Signed-off-by: Emily Deng Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 15 +++ 1 file changed, 15

Re: [PATCH] drm/amdgpu:Added support for MV packet

2018-04-03 Thread Christian König
Am 02.04.2018 um 22:27 schrieb James Zhu: On 2018-03-31 01:51 PM, Christian König wrote: Am 29.03.2018 um 23:02 schrieb James Zhu: Motion vector packet needs support in physic mode. Signed-off-by: James Zhu ---   drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 24   1 file

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Michel Dänzer
On 2018-04-03 11:02 AM, Takashi Iwai wrote: > On Tue, 03 Apr 2018 10:57:56 +0200, > Christian K6nig wrote: >> >> Am 03.04.2018 um 10:36 schrieb Michel Dänzer: >>> On 2018-04-01 07:45 PM, Ilia Mirkin wrote: On Sun, Apr 1, 2018 at 1:39 PM, Christian König wrote: > Am 30.03.2018 um 22:4

Re: regression on raven (gmc9)

2018-04-03 Thread Christian König
Hi Emily, the root cause of the hang was found and as far as I know the plan is to fix this with new RLC firmware. Please see the internal thread with the hardware guys. Thanks, Christian. Am 03.04.2018 um 03:54 schrieb Deng, Emily: Hi Alex and Christian, Those patches are important fo

[PATCH 2/2] drm/amdgpu: add new bo flag that indicates BOs don't need fallback

2018-04-03 Thread Chunming Zhou
user cases: 1. KFD wraps amdgpu_bo_create, they have no fallback case which is different with amdgpu_gem_object_create. since upstream branch has no amdgpu_amdkfd_gpuvm.c, which need KFD guys add this flag to __alloc_memory_of_gpu: + flags |= AMDGPU_GEM_CREATE_NO_FALLBACK; 2. UMD can specify

[PATCH 1/2] drm/amdgpu: Don't change preferred domian when fallback GTT v6

2018-04-03 Thread Chunming Zhou
v2: add sanity checking v3: make code open v4: also handle visible to invisible fallback v5: Since two fallback cases, re-use goto retry v6: avoid bo is unref when retry, and only user BO can fallback Change-Id: I2cf672ad36b8b4cc1a6b2e704f786bf6a155d9ce Signed-off-by: Chunming Zhou Reviewed-by: C

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Daniel Vetter
On Sun, Apr 01, 2018 at 10:12:10PM +0200, Christian König wrote: > Am 01.04.2018 um 20:21 schrieb Takashi Iwai: > > On Sun, 01 Apr 2018 19:58:11 +0200, > > Christian K6nig wrote: > > > Am 01.04.2018 um 19:45 schrieb Ilia Mirkin: > > > > On Sun, Apr 1, 2018 at 1:39 PM, Christian König > > > > wrote

Re: [PATCH] drm/amd/display: fix spelling mistake: "Usupported" -> "Unsupported"

2018-04-03 Thread Jani Nikula
On Fri, 30 Mar 2018, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in DRM_ERROR error message text Thanks for the patch. Please do consider limiting the distribution in the future, though. There's no need to include lkml or even dri-devel for trivial patches like

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Takashi Iwai
On Tue, 03 Apr 2018 11:18:34 +0200, Michel D4nzer wrote: > > On 2018-04-03 11:02 AM, Takashi Iwai wrote: > > On Tue, 03 Apr 2018 10:57:56 +0200, > > Christian K6nig wrote: > >> > >> Am 03.04.2018 um 10:36 schrieb Michel Dänzer: > >>> On 2018-04-01 07:45 PM, Ilia Mirkin wrote: > On Sun, Apr 1,

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Jani Nikula
On Tue, 03 Apr 2018, Michel Dänzer wrote: > On 2018-04-03 11:02 AM, Takashi Iwai wrote: >> Agreed with the naming mess. But OTOH, it's already a thing that is >> too popular to kill. You can add a more suitable option name, but you >> cannot drop these existing ones easily. It's already in a gr

RE: regression on raven (gmc9)

2018-04-03 Thread Deng, Emily
Hi Christian, I know this, but seems it will take long time to do this, and this issue has blocked vega10 sriov for long time. But we want the staging to be stable on vega10 sriov as soon as possible. Best Wishes, Emily Deng > -Original Message- > From: Koenig, Christian > Sent: T

Re: [PATCH] drm/amd/display: fix spelling mistake: "Usupported" -> "Unsupported"

2018-04-03 Thread Dan Carpenter
On Tue, Apr 03, 2018 at 11:41:05AM +0200, Julia Lawall wrote: > > > On Tue, 3 Apr 2018, Jani Nikula wrote: > > > On Fri, 30 Mar 2018, Colin King wrote: > > > From: Colin Ian King > > > > > > Trivial fix to spelling mistake in DRM_ERROR error message text > > > > Thanks for the patch. > > > > P

Re: [PATCH] drm/amd/display: fix spelling mistake: "Usupported" -> "Unsupported"

2018-04-03 Thread Jani Nikula
On Tue, 03 Apr 2018, Julia Lawall wrote: > On Tue, 3 Apr 2018, Jani Nikula wrote: >> Please do consider limiting the distribution in the future, >> though. There's no need to include lkml or even dri-devel for trivial >> patches like this. > > It's complex to have to remember the preferences for e

Re: [PATCH 8/8] drm/amdgpu/gfx9: add emit_reg_write_reg_wait ring callback

2018-04-03 Thread Huang Rui
On Tue, Apr 03, 2018 at 05:08:02PM +0800, Emily Deng wrote: > This adds support for writing and reading back in a single > oneshot packet. This is needed to send a tlb invalidation > and wait for ack in a single operation. > > Signed-off-by: Emily Deng > Signed-off-by: Alex Deucher > --- > dri

Re: [PATCH 1/6] drm/amdgpu: add asic need_full_reset callback

2018-04-03 Thread Christian König
Am 02.04.2018 um 11:24 schrieb Huang Rui: On Thu, Mar 29, 2018 at 03:01:48PM -0500, Alex Deucher wrote: Allow us to determine at the soc level whether the asic requires full reset or if soft reset will work. Signed-off-by: Alex Deucher Series are Reviewed-by: Huang Rui Reviewed-by: Christi

Re: [PATCH 8/8] drm/amdgpu/gfx9: add emit_reg_write_reg_wait ring callback

2018-04-03 Thread Christian König
Am 03.04.2018 um 12:55 schrieb Huang Rui: On Tue, Apr 03, 2018 at 05:08:02PM +0800, Emily Deng wrote: This adds support for writing and reading back in a single oneshot packet. This is needed to send a tlb invalidation and wait for ack in a single operation. Signed-off-by: Emily Deng Signed-o

Re: [PATCH 2/2] drm/amdgpu: Fix PCIe lane width calculation

2018-04-03 Thread Christian König
Acked-by: Christian König for the series as well. But I think you should get Rex or somebody else who can confirm that this is correct to take a look as well. Christian. Am 03.04.2018 um 04:46 schrieb zhoucm1: Acked-by: Chunming Zhou for series. On 2018年04月03日 01:32, Alex Deucher wrote:

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Christian König
Am 03.04.2018 um 11:29 schrieb Daniel Vetter: On Sun, Apr 01, 2018 at 10:12:10PM +0200, Christian König wrote: Am 01.04.2018 um 20:21 schrieb Takashi Iwai: [SNIP] Well exactly that's the point, nothing. The problem is that the option name is confusing to the end user because the expectation is

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Michel Dänzer
On 2018-04-03 11:44 AM, Takashi Iwai wrote: > On Tue, 03 Apr 2018 11:18:34 +0200, > Michel D4nzer wrote: >> >> On 2018-04-03 11:02 AM, Takashi Iwai wrote: >>> On Tue, 03 Apr 2018 10:57:56 +0200, >>> Christian K6nig wrote: Am 03.04.2018 um 10:36 schrieb Michel Dänzer: > On 2018-04-01 0

Re: [PATCH 0/8] The vega10 sriov still need those patches

2018-04-03 Thread Michel Dänzer
On 2018-04-03 11:07 AM, Emily Deng wrote: > For vega10 sriov, still need to use one package for invalidate tlb > flush > > Emily Deng (8): > Revert "Revert "drm/amdgpu: add emit_reg_write_reg_wait ring > callback"" > Revert "Revert "drm/amdgpu/sdma4: add emit_reg_write_reg_wait ring >

Re: [PATCH] drm/amdgpu/si: implement get/set pcie_lanes asic callback

2018-04-03 Thread Christian König
Am 30.03.2018 um 20:37 schrieb Alex Deucher: Required for dpm setup on some asics. Fixes a NULL dereference on asics that require it. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=102553 Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org Acked-by: Christian König --- drivers/gpu/

Re: [PATCH] drm/amd/display: fix spelling mistake: "Usupported" -> "Unsupported"

2018-04-03 Thread Julia Lawall
On Tue, 3 Apr 2018, Jani Nikula wrote: > On Fri, 30 Mar 2018, Colin King wrote: > > From: Colin Ian King > > > > Trivial fix to spelling mistake in DRM_ERROR error message text > > Thanks for the patch. > > Please do consider limiting the distribution in the future, > though. There's no need t

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Ilia Mirkin
On Tue, Apr 3, 2018 at 5:29 AM, Daniel Vetter wrote: > On Sun, Apr 01, 2018 at 10:12:10PM +0200, Christian König wrote: >> Am 01.04.2018 um 20:21 schrieb Takashi Iwai: >> > On Sun, 01 Apr 2018 19:58:11 +0200, >> > Christian K6nig wrote: >> > > Am 01.04.2018 um 19:45 schrieb Ilia Mirkin: >> > > > O

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Michel Dänzer
On 2018-04-03 03:26 PM, Ilia Mirkin wrote: > On Tue, Apr 3, 2018 at 5:29 AM, Daniel Vetter wrote: >> On Sun, Apr 01, 2018 at 10:12:10PM +0200, Christian König wrote: >>> Am 01.04.2018 um 20:21 schrieb Takashi Iwai: On Sun, 01 Apr 2018 19:58:11 +0200, Christian K6nig wrote: > Am 01.04

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Ilia Mirkin
On Tue, Apr 3, 2018 at 9:32 AM, Michel Dänzer wrote: > On 2018-04-03 03:26 PM, Ilia Mirkin wrote: >> On Tue, Apr 3, 2018 at 5:29 AM, Daniel Vetter wrote: >>> On Sun, Apr 01, 2018 at 10:12:10PM +0200, Christian König wrote: Am 01.04.2018 um 20:21 schrieb Takashi Iwai: > On Sun, 01 Apr 201

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Michel Dänzer
On 2018-04-03 03:39 PM, Ilia Mirkin wrote: > On Tue, Apr 3, 2018 at 9:32 AM, Michel Dänzer wrote: >> On 2018-04-03 03:26 PM, Ilia Mirkin wrote: >>> On Tue, Apr 3, 2018 at 5:29 AM, Daniel Vetter wrote: On Sun, Apr 01, 2018 at 10:12:10PM +0200, Christian König wrote: > Am 01.04.2018 um 20:

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Ville Syrjälä
On Tue, Apr 03, 2018 at 03:47:57PM +0200, Michel Dänzer wrote: > On 2018-04-03 03:39 PM, Ilia Mirkin wrote: > > On Tue, Apr 3, 2018 at 9:32 AM, Michel Dänzer wrote: > >> On 2018-04-03 03:26 PM, Ilia Mirkin wrote: > >>> On Tue, Apr 3, 2018 at 5:29 AM, Daniel Vetter wrote: > On Sun, Apr 01, 20

[PATCH v2] drm/amdgpu:Added support for MV packet

2018-04-03 Thread James Zhu
Motion vector packet needs support in physic mode. Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c index a33804b..

Re: [PATCH] drm/amdgpu:Added support for MV packet

2018-04-03 Thread James Zhu
Hi Christian, Thanks for correction. Since MV dump is not normal encoding, its size is HxW/8. So the 2nd buffer size if  1/12 of the 1st one. Thanks and Best Regards! James Zhu On 2018-04-03 05:11 AM, Christian König wrote: Am 02.04.2018 um 22:27 schrieb James Zhu: On 2018-03-31 01:51

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Daniel Vetter
On Tue, Apr 03, 2018 at 05:06:03PM +0300, Ville Syrjälä wrote: > On Tue, Apr 03, 2018 at 03:47:57PM +0200, Michel Dänzer wrote: > > On 2018-04-03 03:39 PM, Ilia Mirkin wrote: > > > On Tue, Apr 3, 2018 at 9:32 AM, Michel Dänzer wrote: > > >> On 2018-04-03 03:26 PM, Ilia Mirkin wrote: > > >>> On Tue

Re: [PATCH 0/8] The vega10 sriov still need those patches

2018-04-03 Thread Alex Deucher
On Tue, Apr 3, 2018 at 9:06 AM, Michel Dänzer wrote: > On 2018-04-03 11:07 AM, Emily Deng wrote: >> For vega10 sriov, still need to use one package for invalidate tlb >> flush >> >> Emily Deng (8): >> Revert "Revert "drm/amdgpu: add emit_reg_write_reg_wait ring >> callback"" >> Revert "Rev

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Michel Dänzer
On 2018-04-03 04:06 PM, Ville Syrjälä wrote: > On Tue, Apr 03, 2018 at 03:47:57PM +0200, Michel Dänzer wrote: >> On 2018-04-03 03:39 PM, Ilia Mirkin wrote: >>> On Tue, Apr 3, 2018 at 9:32 AM, Michel Dänzer wrote: On 2018-04-03 03:26 PM, Ilia Mirkin wrote: > On Tue, Apr 3, 2018 at 5:29 AM,

Re: [PATCH] drm/amd/pp: Use forward declaration in ppatomfwctrl.h

2018-04-03 Thread Alex Deucher
On Tue, Apr 3, 2018 at 2:51 AM, Rex Zhu wrote: > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/hwmgr/ppatomfwctrl.c | 2 +- > drivers/gpu/drm/amd/powerplay/hwmgr/ppatomfwctrl.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a

Re: [PATCH 1/6] drm/amdgpu: add asic need_full_reset callback

2018-04-03 Thread Alex Deucher
On Tue, Apr 3, 2018 at 6:53 AM, Christian König wrote: > Am 02.04.2018 um 11:24 schrieb Huang Rui: >> >> On Thu, Mar 29, 2018 at 03:01:48PM -0500, Alex Deucher wrote: >>> >>> Allow us to determine at the soc level whether the >>> asic requires full reset or if soft reset will work. >>> >>> Signed-

Re: [PATCH 2/2] drm/amdgpu: add new bo flag that indicates BOs don't need fallback

2018-04-03 Thread Felix Kuehling
The series is Acked-by: Felix Kuehling Thanks,   Felix On 2018-04-03 05:24 AM, Chunming Zhou wrote: > user cases: > 1. KFD wraps amdgpu_bo_create, they have no fallback case which is different > with amdgpu_gem_object_create. > since upstream branch has no amdgpu_amdkfd_gpuvm.c, which need KFD

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Ville Syrjälä
On Tue, Apr 03, 2018 at 05:02:35PM +0200, Daniel Vetter wrote: > On Tue, Apr 03, 2018 at 05:06:03PM +0300, Ville Syrjälä wrote: > > On Tue, Apr 03, 2018 at 03:47:57PM +0200, Michel Dänzer wrote: > > > On 2018-04-03 03:39 PM, Ilia Mirkin wrote: > > > > On Tue, Apr 3, 2018 at 9:32 AM, Michel Dänzer

Re: [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-03 Thread Jerome Glisse
On Tue, Apr 03, 2018 at 11:09:09AM +0200, Daniel Vetter wrote: > On Thu, Mar 29, 2018 at 01:34:24PM +0200, Christian König wrote: > > Am 29.03.2018 um 08:57 schrieb Daniel Vetter: > > > On Sun, Mar 25, 2018 at 12:59:56PM +0200, Christian König wrote: > > > > Add a peer2peer flag noting that the imp

Re: amdgpu hangs on boot or shutdown on AMD Raven Ridge CPU (Engineer Sample)

2018-04-03 Thread Daniel Drake
On Thu, Mar 22, 2018 at 3:09 AM, Daniel Drake wrote: > On Tue, Feb 20, 2018 at 10:18 PM, Alex Deucher wrote: >>> It seems that we are not alone seeing amdgpu-induced stability >>> problems on multiple Raven Ridge platforms. >>> https://www.phoronix.com/scan.php?page=news_item&px=AMD-Raven-Ridge-M

Re: [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-03 Thread Daniel Vetter
On Tue, Apr 03, 2018 at 01:06:45PM -0400, Jerome Glisse wrote: > On Tue, Apr 03, 2018 at 11:09:09AM +0200, Daniel Vetter wrote: > > On Thu, Mar 29, 2018 at 01:34:24PM +0200, Christian König wrote: > > > Am 29.03.2018 um 08:57 schrieb Daniel Vetter: > > > > On Sun, Mar 25, 2018 at 12:59:56PM +0200,

[PATCH] tests/amdgpu: add vce motion vector tests support

2018-04-03 Thread James Zhu
Signed-off-by: James Zhu --- tests/amdgpu/Makefile.am| 1 + tests/amdgpu/amdgpu_test.c | 11 + tests/amdgpu/amdgpu_test.h | 20 ++ tests/amdgpu/vce_ib.h | 21 +- tests/amdgpu/vce_mv_tests.c | 537 5 files changed, 588 insertions(+), 2

Re: [PATCH] tests/amdgpu: add vce motion vector tests support

2018-04-03 Thread Leo Liu
On 04/03/2018 03:02 PM, James Zhu wrote: Signed-off-by: James Zhu --- tests/amdgpu/Makefile.am| 1 + tests/amdgpu/amdgpu_test.c | 11 + tests/amdgpu/amdgpu_test.h | 20 ++ tests/amdgpu/vce_ib.h | 21 +- tests/amdgpu/vce_mv_tests.c | 537 ++

Re: [PATCH] tests/amdgpu: add vce motion vector tests support

2018-04-03 Thread James Zhu
On 2018-04-03 03:14 PM, Leo Liu wrote: On 04/03/2018 03:02 PM, James Zhu wrote: Signed-off-by: James Zhu ---   tests/amdgpu/Makefile.am    |   1 +   tests/amdgpu/amdgpu_test.c  |  11 +   tests/amdgpu/amdgpu_test.h  |  20 ++   tests/amdgpu/vce_ib.h   |  21 +-   tests/amdgpu/vce_mv_tests.

[PATCH] drm/amdgpu: optionally do a writeback but don't invalidate TC for IB fences

2018-04-03 Thread Marek Olšák
From: Marek Olšák There is a new IB flag that enables this new behavior. Full invalidation is unnecessary for RELEASE_MEM and doesn't make sense when draw calls from two adjacent gfx IBs run in parallel. This will be the new default for Mesa. Signed-off-by: Marek Olšák --- drivers/gpu/drm/amd/

Re: [PATCH] drm/amdgpu: optionally do a writeback but don't invalidate TC for IB fences

2018-04-03 Thread Alex Deucher
On Tue, Apr 3, 2018 at 4:09 PM, Marek Olšák wrote: > From: Marek Olšák > > There is a new IB flag that enables this new behavior. > Full invalidation is unnecessary for RELEASE_MEM and doesn't make sense > when draw calls from two adjacent gfx IBs run in parallel. This will be > the new default f

Re: [PATCH] tests/amdgpu: add vce motion vector tests support

2018-04-03 Thread Leo Liu
On 04/03/2018 03:48 PM, James Zhu wrote: On 2018-04-03 03:14 PM, Leo Liu wrote: On 04/03/2018 03:02 PM, James Zhu wrote: Signed-off-by: James Zhu ---   tests/amdgpu/Makefile.am    |   1 +   tests/amdgpu/amdgpu_test.c  |  11 +   tests/amdgpu/amdgpu_test.h  |  20 ++   tests/amdgpu/vce_ib.h

[PATCH] drm/amdgpu: optionally do a writeback but don't invalidate TC for IB fences

2018-04-03 Thread Marek Olšák
From: Marek Olšák There is a new IB flag that enables this new behavior. Full invalidation is unnecessary for RELEASE_MEM and doesn't make sense when draw calls from two adjacent gfx IBs run in parallel. This will be the new default for Mesa. v2: bump the version Signed-off-by: Marek Olšák ---

Re: [PATCH] tests/amdgpu: add vce motion vector tests support

2018-04-03 Thread James Zhu
On 2018-04-03 04:21 PM, Leo Liu wrote: On 04/03/2018 03:48 PM, James Zhu wrote: On 2018-04-03 03:14 PM, Leo Liu wrote: On 04/03/2018 03:02 PM, James Zhu wrote: Signed-off-by: James Zhu ---   tests/amdgpu/Makefile.am    |   1 +   tests/amdgpu/amdgpu_test.c  |  11 +   tests/amdgpu/amdgp

[PATCH 02/32] drm/amd/display: Don't register backlight on connector_destroy

2018-04-03 Thread Harry Wentland
Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/

[PATCH 04/32] drm/amd/display: Set ignore_msa_timing_param

2018-04-03 Thread Harry Wentland
Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c inde

[PATCH 05/32] drm/amd/display: Non-HDMI DP active dongle should not support YUV pixel format

2018-04-03 Thread Harry Wentland
From: Hersen Wu Signed-off-by: Hersen Wu Reviewed-by: Tony Cheng Reviewed-by: Harry Wentland Reviewed-by: Wesley Chalmers --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/

[PATCH 06/32] drm/amd/display: Fix potential access beyond end of array in CM

2018-04-03 Thread Harry Wentland
Signed-off-by: Harry Wentland CC: Dan Carpenter Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_cm_common.c b

[PATCH 08/32] drm/amd/display: Add vmax/min_sel prints to dcn10_log_hw_state

2018-04-03 Thread Harry Wentland
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 6 -- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 6 ++ drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.h | 2 ++ 3 files cha

[PATCH 07/32] drm/amd/display: Add Dynamic debug prints

2018-04-03 Thread Harry Wentland
From: Bhawanpreet Lakha Created Macros for DC_LOG_XXX to pr_debug() & DRM_DEBUG_KMS. Signed-off-by: Bhawanpreet Lakha Reviewed-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 -- drivers/gpu/drm/amd/display/dc/core/dc_debug.c | 20 +++ drivers/gpu/drm/am

[PATCH 09/32] drm/amd/display: Implement dm_get_timestamp

2018-04-03 Thread Harry Wentland
We use this to ensure we wait at least 500ms in between eDP disable/enable. Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_services.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH 00/32] DC Patches Apr 3, 2018

2018-04-03 Thread Harry Wentland
* Don't register backlight device if eDP or LVDS are disconnected * Fix corruption on VT switch with FBC enabled * decouple logging from DC logger * Rework freesync module to fit better with atomic model Anthony Koo (13): drm/amd/display: Program v_total_min/max after v_total_cntl drm/amd/

[PATCH 14/32] drm/amd/display: remove unused enum

2018-04-03 Thread Harry Wentland
From: Jun Lei Signed-off-by: Jun Lei Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc_types.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc_types.h b/drivers/gpu/drm/amd/display/dc/dc_types.h index 90f40eecc2bc.

[PATCH 18/32] drm/amd/display: Update scaler v_active data if interlaced

2018-04-03 Thread Harry Wentland
From: Dmytro Laktyushkin Signed-off-by: Dmytro Laktyushkin Reviewed-by: Nikola Cornij Reviewed-by: Wesley Chalmers Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc

[PATCH 03/32] drm/amd/display: Program v_total_min/max after v_total_cntl

2018-04-03 Thread Harry Wentland
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Harry Wentland --- .../drm/amd/display/dc/dce110/dce110_timing_generator.c | 16 .../drm/amd/display/dc/dce120/dce120_timing_generator.c | 12 ++-- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c| 12

[PATCH 16/32] drm/amd/display: Fill calcs date from stream src/dst if available

2018-04-03 Thread Harry Wentland
From: Jun Lei We would otherwise fallback to the timing, which would always give us identity. Signed-off-by: Jun Lei Reviewed-by: Wesley Chalmers Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 13 + 1 file changed, 13 insertions(+) diff --git a/d

[PATCH 01/32] drm/amd/display: Only register backlight device if embedded panel connected

2018-04-03 Thread Harry Wentland
Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 58 +-- 1 file changed, 33 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm

[PATCH 20/32] drm/amd/display: csc updates require FULL update

2018-04-03 Thread Harry Wentland
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 12 ++-- drivers/gpu/drm/amd/display/dc/dc.h | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/disp

[PATCH 15/32] drm/amd/display: fix link bw calculation for 422 and 420 encoding

2018-04-03 Thread Harry Wentland
From: Eric Yang Link bw required is reduced when we have chroma subsampling. Signed-off-by: Eric Yang Reviewed-by: Charlene Liu Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 53 ++-- 1 file changed, 32 insertions(+), 21 deletions(-) diff

[PATCH 29/32] drm/amd/display: move color_transfer_func to color mod

2018-04-03 Thread Harry Wentland
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/d

[PATCH 10/32] drm/amd/display: add delay between panel pwr off to on.

2018-04-03 Thread Harry Wentland
From: Charlene Liu As per eDP 1.4 spec, there must be at least 500ms delay between eDP power off and on. This change added time stamp when edp power off, which can be used to calculate duration time when edp power on. If duration less than 500ms, add a wait. Signed-off-by: Charlene Liu Reviewed

[PATCH 26/32] drm/amd/display: Do not use os types

2018-04-03 Thread Harry Wentland
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c | 158 ++--- drivers/gpu/drm/amd/display/include/fixed31_32.h | 40 +++--- 2 files changed, 98 insert

[PATCH 32/32] drm/amd/display: Fix dim display on DCE11

2018-04-03 Thread Harry Wentland
From: "Leo (Sunpeng) Li" Before programming the input gamma, check that we're not using the identity correction. Signed-off-by: Leo (Sunpeng) Li Reviewed-by: Anthony Koo Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 +++- 1 file changed, 3 inser

[PATCH 22/32] drm/amd/display: dal 3.1.41

2018-04-03 Thread Harry Wentland
From: Yongqiang Sun Signed-off-by: Yongqiang Sun Reviewed-by: Yongqiang Sun Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 7d1

[PATCH 31/32] drm/amd/display: Have DC manage its own allocation of gamma

2018-04-03 Thread Harry Wentland
From: Anthony Koo Creating plane will also allocate gamma and input TF Creating stream will also allocate outputTF Fix issue with gamma not applied OS may call SetGamma before surface committed, so need to store in target and apply later. Signed-off-by: Anthony Koo Reviewed-by: Aric Cyr Acked

[PATCH 21/32] drm/amd/display: Fix FBC text console corruption

2018-04-03 Thread Harry Wentland
From: Roman Li Signed-off-by: Roman Li Reviewed-by: Charlene Liu Acked-by: Harry Wentland --- .../drm/amd/display/dc/dce110/dce110_compressor.c | 67 +- 1 file changed, 54 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_compressor

[PATCH 17/32] drm/amd/display: Change disable backlight ramp change threshold from 0 to maximum value.

2018-04-03 Thread Harry Wentland
From: Yongqiang Sun Instead of user set brightness with range of percentage, HLK test set brightness level with range of normal, this will result in HLK test case set brightness from 0 to 255, DC set brightness with ramp is 0, and disabled ramp change which will fail the HLK test. Fix: In case of

[PATCH 25/32] drm/amd/display: Remove unused fields

2018-04-03 Thread Harry Wentland
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index

[PATCH 13/32] drm/amd/display: Refactor stream encoder for HW review

2018-04-03 Thread Harry Wentland
From: Eric Bernstein Move DCN1 implementation of stream encoder to new file (instead of common dce_stream_encoder.c). Cleanup code related to different implementation due to register definition differences. Signed-off-by: Eric Bernstein Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- dr

[PATCH 23/32] drm/amd/display: Updated HDR Static Metadata to directly take info packet raw

2018-04-03 Thread Harry Wentland
From: Anthony Koo Updated HDR Static Metadata to directly take info packet raw Updating Infopacket does not require Passive Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 3 - drivers/gpu/drm/amd/display/

[PATCH 30/32] drm/amd/display: Fix structure initialization of hdmi_info_packet

2018-04-03 Thread Harry Wentland
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c

[PATCH 19/32] drm/amd/display: Make DCN stream encoder shareable

2018-04-03 Thread Harry Wentland
From: Eric Bernstein Signed-off-by: Eric Bernstein Reviewed-by: Charlene Liu Acked-by: Harry Wentland --- .../drm/amd/display/dc/dce/dce_stream_encoder.c| 39 +- .../amd/display/dc/dcn10/dcn10_stream_encoder.c| 62 +- .../amd/display/dc/dcn10/dcn10_stream_encoder.h| 646

[PATCH 11/32] drm/amd/display: Set all update flags when we have full update

2018-04-03 Thread Harry Wentland
From: Eric Yang To prevent future optimization related bugs, just set all update flags when we have a full update, since we know we want to reprogram everything in that case. Signed-off-by: Eric Yang Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.

[PATCH 28/32] drm/amd/display: Refactor color module

2018-04-03 Thread Harry Wentland
From: Anthony Koo Remove some unnecessary TF definitions from update structures Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc_stream.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[PATCH 24/32] drm/amd/display: Get rid of unused input_tf

2018-04-03 Thread Harry Wentland
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - drivers/gpu/drm/amd/display/dc/core/dc.c | 3 --- drivers/gpu/drm/amd/display/dc/core/dc_debug.c| 4 -

[PATCH 27/32] drm/amd/display: csc_transform to dc_csc_transform

2018-04-03 Thread Harry Wentland
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 4 ++-- drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 5 + drivers/gpu/drm/amd/display/dc/dc_stream.h

RE: [PATCH 0/8] The vega10 sriov still need those patches

2018-04-03 Thread Deng, Emily
Thanks all, I will change the patches as you sugestion, and send to you review again. > -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Tuesday, April 03, 2018 11:07 PM > To: Michel Dänzer > Cc: Deng, Emily ; amd-gfx list g...@lists.freedesktop.org> > Sub

[PATCH v2 2/7] drm/amdgpu/gfx9: add emit_reg_write_reg_wait ring callback (v2)

2018-04-03 Thread Emily Deng
From: Alex Deucher This adds support for writing and reading back in a single oneshot packet. This is needed to send a tlb invalidation and wait for ack in a single operation. v2: squash the gfx ring stall fix Reviewed-by: Huang Rui Reviewed-by: Christian König Signed-off-by: Alex Deucher S

[PATCH v2 3/7] drm/amdgpu/sdma4: add emit_reg_write_reg_wait ring callback (v2)

2018-04-03 Thread Emily Deng
From: Alex Deucher This adds support for writing and reading back in a single oneshot packet. This is needed to send a tlb invalidation and wait for ack in a single operation. v2: squash sdma hang fix into this patch Reviewed-by: Huang Rui Reviewed-by: Christian König Signed-off-by: Alex Deu

[PATCH v2 1/7] drm/amdgpu: add emit_reg_write_reg_wait ring callback

2018-04-03 Thread Emily Deng
From: Alex Deucher This callback writes a value to a register and then reads back another register and waits for a value in a single operation. Provide a helper function using two operations for engines that don't support this opertion. Reviewed-by: Huang Rui Reviewed-by: Christian König Sign

[PATCH v2 4/7] drm/amdgpu/uvd7: add emit_reg_write_reg_wait ring callback

2018-04-03 Thread Emily Deng
From: Alex Deucher This adds support for writing and reading back using the helper since the engines doesn't have a oneshot packet. Reviewed-by: Huang Rui Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 5/7] drm/amdgpu/vce4: add emit_reg_write_reg_wait ring callback

2018-04-03 Thread Emily Deng
From: Alex Deucher This adds support for writing and reading back using the helper since the engines doesn't have a oneshot packet. Reviewed-by: Huang Rui Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 1 + 1 file changed, 1 insertion(+)

[PATCH v2 6/7] drm/amdgpu/vcn1: add emit_reg_write_reg_wait ring callback

2018-04-03 Thread Emily Deng
From: Alex Deucher This adds support for writing and reading back using the helper since the engines doesn't have a oneshot packet. Reviewed-by: Huang Rui Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 1 + 1 file changed, 1 insertion(+)

  1   2   >