[PATCH v2] drm/amdgpu: add checking for sos version

2018-05-28 Thread Huang Rui
The sos ucode version will be changed to align with the value of mmMP0_SMN_C2PMSG_58. Then we add a checking for this. Meanwhile, we have to be compatibility backwards. So it adds serveral recent legacy versions as the white list for the version checking. Signed-off-by: Huang Rui Acked-by: Alex D

Re: [PATCH] drm/amd/display: Implement dm_pp_get_clock_levels_by_type_with_latency

2018-05-28 Thread Harry Wentland
On 2018-05-27 09:46 PM, Quan, Evan wrote: >> +   /* translate 10kHz to kHz */ >> +   clk_level_info->data[i].clocks_in_khz = >> pp_clks->data[i].clocks_in_khz; >> +   clk_level_info->data[i].latency_in_us = >> pp_clks->data[i].clocks_in_khz; > > This seems a t

[PATCH v2] drm/amd/display: Fix BUG_ON during CRTC atomic check update

2018-05-28 Thread sunpeng.li
From: "Leo (Sunpeng) Li" For cases where the CRTC is inactive (DPMS off), where a modeset is not required, yet the CRTC is still in the atomic state, we should not attempt to update anything on it. Previously, we were relying on the modereset_required() helper to check the above condition. Howev

Re: [PATCH] drm/amd/display: Fix BUG_ON during CRTC atomic check update

2018-05-28 Thread Leo Li
On 2018-05-28 11:20 AM, Michel Dänzer wrote: On 2018-05-28 05:06 PM, sunpeng...@amd.com wrote: From: "Leo (Sunpeng) Li" For cases where the CRTC is inactive (DPMS off), where a modeset is not required, yet the CRTC is still in the atomic state, we should not attempt to update anything on it.

[PATCH] drm/amd/pp: Add cases for getting phys and disp clks for SMU10

2018-05-28 Thread mikita.lipski
From: Mikita Lipski Add case options to retrieve either physical or display clocks with voltage from SMU controller that are needed by display driver. Signed-off-by: Mikita Lipski --- drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/dr

Re: [PATCH] drm/amd/display: Fix BUG_ON during CRTC atomic check update

2018-05-28 Thread Michel Dänzer
On 2018-05-28 05:06 PM, sunpeng...@amd.com wrote: > From: "Leo (Sunpeng) Li" > > For cases where the CRTC is inactive (DPMS off), where a modeset is not > required, yet the CRTC is still in the atomic state, we should not > attempt to update anything on it. > > Previously, we were relying on the

[PATCH] drm/amd/display: Fix BUG_ON during CRTC atomic check update

2018-05-28 Thread sunpeng.li
From: "Leo (Sunpeng) Li" For cases where the CRTC is inactive (DPMS off), where a modeset is not required, yet the CRTC is still in the atomic state, we should not attempt to update anything on it. Previously, we were relying on the modereset_required() helper to check the above condition. Howev

Re: DC regression in 4.17 broke suspend to RAM

2018-05-28 Thread Michel Dänzer
On 2018-05-28 03:44 PM, Leo Li wrote: > On 2018-05-28 05:15 AM, Michel Dänzer wrote: >> >> Hi Leo, >> >> >> commit e277adc5a06c "drm/amd/display: Hookup color management functions" >> broke suspend to RAM on my development system with a Tonga and a Turks >> (using the radeon driver). It sometimes,

Re: DC regression in 4.17 broke suspend to RAM

2018-05-28 Thread Leo Li
On 2018-05-28 05:15 AM, Michel Dänzer wrote: Hi Leo, commit e277adc5a06c "drm/amd/display: Hookup color management functions" broke suspend to RAM on my development system with a Tonga and a Turks (using the radeon driver). It sometimes, but not always happens when trying to suspend from the

[git pull] amdkfd next 4.18

2018-05-28 Thread Oded Gabbay
Hi Dave, Final amdkfd pull request for 4.18: - Build amdkfd's related files inside amdgpu only if amdkfd is built - Fix compile warning - Print info message in case ASIC is not supported by amdkfd Thanks, Oded The following changes since commit dd41fb8547c2422f3a3a75e7226525e8bba9381c: Merge

Re: [PATCH 2/8] drm/amdgpu: fix 32-bit build warning

2018-05-28 Thread Oded Gabbay
On Fri, May 25, 2018 at 6:50 PM, Arnd Bergmann wrote: > Casting a pointer to a 64-bit type causes a warning on 32-bit targets: > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c:473:24: error: cast from > pointer to integer of different size [-Werror=pointer-to-int-cast] > lower_32_b

Re: [PATCH] drm/amdgpu: Use dev_info() to report amdkfd is not supported for this ASIC

2018-05-28 Thread Oded Gabbay
On Fri, May 25, 2018 at 12:07 AM, Tom Stellard wrote: > This is an important message, so it should be visible to users without > having to enable extra debugging. > > Signed-off-by: Tom Stellard > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

DC regression in 4.17 broke suspend to RAM

2018-05-28 Thread Michel Dänzer
Hi Leo, commit e277adc5a06c "drm/amd/display: Hookup color management functions" broke suspend to RAM on my development system with a Tonga and a Turks (using the radeon driver). It sometimes, but not always happens when trying to suspend from the GNOME login screen in Wayland mode (I first noti

Re: [PATCH] drm/amdgpu: fix NULL pointer dereference when run App with DRI_PRIME=1

2018-05-28 Thread Zhang, Jerry (Junwei)
On 05/25/2018 07:23 PM, Christian König wrote: Am 25.05.2018 um 11:51 schrieb Zhang, Jerry (Junwei): On 05/25/2018 05:35 PM, Christian König wrote: Am 25.05.2018 um 10:23 schrieb Zhang, Jerry (Junwei): On 05/25/2018 03:54 PM, Christian König wrote: Am 25.05.2018 um 09:20 schrieb Zhang, Jerry

Re: drm/amdgpu: Add helper function to get buffer domain

2018-05-28 Thread Christian König
Reviewed-by: Christian König for both as well. Christian. Am 26.05.2018 um 15:23 schrieb Deucher, Alexander: Both patches are: Reviewed-by: Alex Deucher *From:* Sharma, Deepak *Sent:* Friday, May 25, 2018 8:19:26 PM *