Re: [PATCH] drm/amd: Remove errors from sphinx documentation

2018-07-02 Thread Michel Dänzer
Hi Darren, thanks for working on this. On 2018-06-30 12:10 AM, Powell, Darren wrote: > > Subject: [PATCH 1/2] drm/amd: Remove errors from sphinx documentation > > Eliminating the warnings produced by sphinx when processing the sphinx > comments in > amdgpu_device.c The commit log should m

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Christian König
Am 27.06.2018 um 09:44 schrieb Michal Hocko: This is the v2 of RFC based on the feedback I've received so far. The code even compiles as a bonus ;) I haven't runtime tested it yet, mostly because I have no idea how. Any further feedback is highly appreciated of course. That sounds like it shou

Re: [PATCH] drm/amdgpu: Add AMDGPU_GPU_PAGES_IN_CPU_PAGE define

2018-07-02 Thread Christian König
Am 25.06.2018 um 16:41 schrieb Alex Deucher: On Mon, Jun 25, 2018 at 9:33 AM, Zhou, David(ChunMing) wrote: current amdgpu driver indeed always set GPU PAGE SIZE is 4096. In fact, our gpu supports bigger page size like 64KB, just we don't use it. I remeber previous amdsoc(old android kernel driv

Re: [PATCH v2] drm/amdgpu: Reserve shared fence slot in amdgpu_vm_update_directories

2018-07-02 Thread Christian König
Am 25.06.2018 um 11:07 schrieb Michel Dänzer: From: Michel Dänzer Without this, there could not be enough slots, which could trigger the BUG_ON in reservation_object_add_shared_fence. v2: * Jump to the error label instead of returning directly (Jerry Zhang) Well good catch, but NAK that is n

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 11:14:58, Christian König wrote: > Am 27.06.2018 um 09:44 schrieb Michal Hocko: > > This is the v2 of RFC based on the feedback I've received so far. The > > code even compiles as a bonus ;) I haven't runtime tested it yet, mostly > > because I have no idea how. > > > > Any further

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Christian König
Am 02.07.2018 um 13:54 schrieb Michal Hocko: On Mon 02-07-18 11:14:58, Christian König wrote: Am 27.06.2018 um 09:44 schrieb Michal Hocko: This is the v2 of RFC based on the feedback I've received so far. The code even compiles as a bonus ;) I haven't runtime tested it yet, mostly because I hav

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 14:13:42, Christian König wrote: > Am 02.07.2018 um 13:54 schrieb Michal Hocko: > > On Mon 02-07-18 11:14:58, Christian König wrote: > > > Am 27.06.2018 um 09:44 schrieb Michal Hocko: > > > > This is the v2 of RFC based on the feedback I've received so far. The > > > > code even com

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Christian König
Am 02.07.2018 um 14:20 schrieb Michal Hocko: On Mon 02-07-18 14:13:42, Christian König wrote: Am 02.07.2018 um 13:54 schrieb Michal Hocko: On Mon 02-07-18 11:14:58, Christian König wrote: Am 27.06.2018 um 09:44 schrieb Michal Hocko: This is the v2 of RFC based on the feedback I've received so

Re: [PATCH 1/2] drm/amdgpu/sdma: simplify sdma instance setup

2018-07-02 Thread Christian König
Am 25.06.2018 um 19:42 schrieb Alex Deucher: Set the me instance in early init and use that rather than calculating the instance based on the ring pointer. Signed-off-by: Alex Deucher Reviewed-by: Christian König for the series. --- drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 12 ++-

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 14:24:29, Christian König wrote: > Am 02.07.2018 um 14:20 schrieb Michal Hocko: > > On Mon 02-07-18 14:13:42, Christian König wrote: > > > Am 02.07.2018 um 13:54 schrieb Michal Hocko: > > > > On Mon 02-07-18 11:14:58, Christian König wrote: > > > > > Am 27.06.2018 um 09:44 schrieb M

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Christian König
Am 02.07.2018 um 14:35 schrieb Michal Hocko: On Mon 02-07-18 14:24:29, Christian König wrote: Am 02.07.2018 um 14:20 schrieb Michal Hocko: On Mon 02-07-18 14:13:42, Christian König wrote: Am 02.07.2018 um 13:54 schrieb Michal Hocko: On Mon 02-07-18 11:14:58, Christian König wrote: Am 27.06.2

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-02 Thread Michal Hocko
On Mon 02-07-18 14:39:50, Christian König wrote: [...] > Not wanting to block something as important as this, so feel free to add an > Acked-by: Christian König to the patch. Thanks a lot! > Let's rather face the next topic: Any idea how to runtime test this? This is a good question indeed. One

Regression: no display with Vega 56 AMD GPU bisected to commit bfdec2340478

2018-07-02 Thread Jeremy Cline
Hi folks, A Fedora user, Mikhail (CCed), reported[0] a regression with their Vega 56 AMD GPU introduced by bfdec2340478 ("drm/amd/display: Implement dm_pp_get_clock_levels_by_type_with_latency"). The symptom is that nothing is displayed and looking at the logs (attached to the Bugzilla), I see gno

BUG: *ERROR* No EDID read

2018-07-02 Thread Daniel Andersson
I get: [drm:dc_link_detect [amdgpu]] *ERROR* No EDID read. on boot. This started happening on 4.17 and is still an issue on 4.18-rc2. I have a Vega64 connected on Display Port to a monitor(1440p). The monitor doesn't have any additional ports so I can't test HDMI. xrandr: Screen 0: minimum 320 x

Re: BUG: *ERROR* No EDID read

2018-07-02 Thread Alex Deucher
On Mon, Jul 2, 2018 at 3:21 PM, Daniel Andersson wrote: > I get: > [drm:dc_link_detect [amdgpu]] *ERROR* No EDID read. > on boot. This started happening on 4.17 and is still an issue on 4.18-rc2. > > I have a Vega64 connected on Display Port to a monitor(1440p). The monitor > doesn't have any addi

[PATCH 2/2] drm/amdgpu: switch firmware path for SI parts

2018-07-02 Thread Alex Deucher
Use separate firmware path for amdgpu to avoid conflicts with radeon on SI parts. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 56 +-- drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 14 - drivers/gpu/drm/amd/amdgpu/si_dpm.c | 22 +

[PATCH 1/2] drm/amdgpu: switch firmware path for CIK parts

2018-07-02 Thread Alex Deucher
Use separate firmware path for amdgpu to avoid conflicts with radeon on CIK parts. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 8 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 10 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 10 ++--- drivers/gpu/drm/amd/amdgpu

Re: [PATCH 1/2] drm/amdgpu: switch firmware path for CIK parts

2018-07-02 Thread Dave Airlie
On 3 July 2018 at 05:36, Alex Deucher wrote: > Use separate firmware path for amdgpu to avoid conflicts > with radeon on CIK parts. > Won't that cause a chicken and egg problem, new kernel with old firmware package will suddenly start failing, or do we not really care since in theory we don't sup

Re: [PATCH 1/2] drm/amdgpu: switch firmware path for CIK parts

2018-07-02 Thread Alex Deucher
On Mon, Jul 2, 2018 at 4:12 PM, Dave Airlie wrote: > On 3 July 2018 at 05:36, Alex Deucher wrote: >> Use separate firmware path for amdgpu to avoid conflicts >> with radeon on CIK parts. >> > > Won't that cause a chicken and egg problem, new kernel with old > firmware package will > suddenly star

Re: [PATCH] drm/amdgpu/acp: Fix slab-out-of-bounds in mfd_add_device in acp_hw_init

2018-07-02 Thread Daniel Kurtz
Hi Alex, On Sun, Apr 15, 2018 at 9:48 PM Agrawal, Akshu wrote: > > > > On 4/13/2018 9:45 PM, Daniel Kurtz wrote: > > Commit 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for > > stoney/cz") added support for the "BT_I2S" ACP i2s channel. As part of > > this change, one additional acp

RE: [PATCH 1/2] drm/amdgpu: switch firmware path for CIK parts

2018-07-02 Thread Zhou, David(ChunMing)
Yes, agree, radeon driver uses radeon path, amdgpu uses amdgpu path, which makes sense to me. The series is Reviewed-by: Chunming Zhou Regards, David Zhou -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Tuesday, July 03,

Re: [PATCH v2] drm/amdgpu: Reserve shared fence slot in amdgpu_vm_update_directories

2018-07-02 Thread Zhang, Jerry (Junwei)
On 07/02/2018 05:23 PM, Christian König wrote: Am 25.06.2018 um 11:07 schrieb Michel Dänzer: From: Michel Dänzer Without this, there could not be enough slots, which could trigger the BUG_ON in reservation_object_add_shared_fence. v2: * Jump to the error label instead of returning directly (J

Re: [PATCH 1/2] drm/amdgpu: switch firmware path for CIK parts

2018-07-02 Thread Zhang, Jerry (Junwei)
On 07/03/2018 03:36 AM, Alex Deucher wrote: Use separate firmware path for amdgpu to avoid conflicts with radeon on CIK parts. Does that means firmware will be separated from radeon driver regardless of whether they are same? In another word, amdgpu/CIK-fw is likely to be identical to radeon/C

答复: [PATCH 1/2] drm/amdgpu: switch firmware path for CIK parts

2018-07-02 Thread Qu, Jim
The patch sounds reasonable. My concern is : should the patches need to coordinate with the change of installation script (or maybe the FW .deb package)which install relative FW to amdgpu patch? Thanks JimQu 发件人: amd-gfx 代表 Zhang, Jerry (Junwei) 发送时间

Re: [PATCH v2] drm/amdgpu: Reserve shared fence slot in amdgpu_vm_update_directories

2018-07-02 Thread Christian König
Am 03.07.2018 um 03:59 schrieb Zhang, Jerry (Junwei): On 07/02/2018 05:23 PM, Christian König wrote: Am 25.06.2018 um 11:07 schrieb Michel Dänzer: From: Michel Dänzer Without this, there could not be enough slots, which could trigger the BUG_ON in reservation_object_add_shared_fence. v2: * J