[PATCH libdrm] amdgpu: When couldn't find bo, need to return error.

2018-08-31 Thread Emily Deng
The startx will have segmant fault if return success. SWDEV-163962 Change-Id: I56b189fa26efdcd1d96e5100af3f3e0b1208b0c3 Signed-off-by: Emily Deng --- amdgpu/amdgpu_bo.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c index

Re: [PATCH 2/2] drm/amdgpu: improve VM state machine documentation

2018-08-31 Thread Felix Kuehling
Thanks for this. A few comments and a question inline. On 2018-08-31 09:27 AM, Christian König wrote: > Since we have a lot of FAQ on the VM state machine try to improve the > documentation by adding functions for each state move. > > Signed-off-by: Christian König > --- >

[PATCH 1/1] drm/amdgpu: Clean up KFD init and fini

2018-08-31 Thread Felix Kuehling
Only initialize KFD once by moving amdgpu_amdkfd_init from amdgpu_pci_probe to amdgpu_init. This fixes kernel oopses and hangs when booting multi-GPU systems. Also removed some vestiges of KFD being its own module. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c |

Re: [PATCH] drm/amd/powerplay: added vega20 overdrive support V3

2018-08-31 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Evan Quan Sent: Friday, August 31, 2018 3:50:30 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Quan, Evan; Zhu, Rex Subject: [PATCH] drm/amd/powerplay: added vega20 overdrive support V3 Added

Re: [PATCH] drm/amdgpu: Use drm_dev_unplug in PCI .remove

2018-08-31 Thread Christian König
Am 31.08.2018 um 18:13 schrieb Andrey Grodzovsky: This at least allows to fail any subsequent IOCTLs with -ENODEV after the device is gone. Still this operation is not supported yet in graphic mode and will lead at least to page faults and other issues. Signed-off-by: Andrey Grodzovsky Well

[PATCH] drm/amdgpu: Use drm_dev_unplug in PCI .remove

2018-08-31 Thread Andrey Grodzovsky
This at least allows to fail any subsequent IOCTLs with -ENODEV after the device is gone. Still this operation is not supported yet in graphic mode and will lead at least to page faults and other issues. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 ++-- 1

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

2018-08-31 Thread Thomas Hellstrom
On 08/31/2018 05:27 PM, Emil Velikov wrote: On 31 August 2018 at 15:38, Michel Dänzer wrote: [ Adding the amd-gfx list ] On 2018-08-31 3:05 p.m., Thomas Hellstrom wrote: On 08/31/2018 02:30 PM, Emil Velikov wrote: On 31 August 2018 at 12:54, Thomas Hellstrom wrote: To determine whether a

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

2018-08-31 Thread Christian König
Am 31.08.2018 um 17:27 schrieb Emil Velikov: On 31 August 2018 at 15:38, Michel Dänzer wrote: [ Adding the amd-gfx list ] On 2018-08-31 3:05 p.m., Thomas Hellstrom wrote: On 08/31/2018 02:30 PM, Emil Velikov wrote: On 31 August 2018 at 12:54, Thomas Hellstrom wrote: To determine whether a

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

2018-08-31 Thread Emil Velikov
On 31 August 2018 at 15:38, Michel Dänzer wrote: > > [ Adding the amd-gfx list ] > > On 2018-08-31 3:05 p.m., Thomas Hellstrom wrote: >> On 08/31/2018 02:30 PM, Emil Velikov wrote: >>> On 31 August 2018 at 12:54, Thomas Hellstrom >>> wrote: To determine whether a device node is a drm device

Re: [PATCH 3/3] drm/amdgpu: fix idle state and bulk_moveavle flag

2018-08-31 Thread Michel Dänzer
On 2018-08-31 3:10 p.m., Christian König wrote: > Add BOs to the idle state again and correctly clear the flag when > new BOs are added. > > Signed-off-by: Christian König Typo in the shortlog: bulk_moveavle -> bulk_moveable The series is Tested-by: Michel Dänzer Thanks Christian! --

Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-08-31 Thread Christian König
Am 31.08.2018 um 17:15 schrieb Michel Dänzer: On 2018-08-31 3:10 p.m., Christian König wrote: Staring at the function for six hours, just to essentially move one line of code. That sucks, but the commit log should describe what the problem was and how this patch solves it. Signed-off-by:

Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-08-31 Thread Michel Dänzer
On 2018-08-31 3:10 p.m., Christian König wrote: > Staring at the function for six hours, just to essentially move one line > of code. That sucks, but the commit log should describe what the problem was and how this patch solves it. > Signed-off-by: Christian König > --- >

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

2018-08-31 Thread Thomas Hellstrom
On 08/31/2018 04:49 PM, Michel Dänzer wrote: On 2018-08-31 4:46 p.m., Thomas Hellstrom wrote: On 08/31/2018 04:38 PM, Michel Dänzer wrote: [ Adding the amd-gfx list ] On 2018-08-31 3:05 p.m., Thomas Hellstrom wrote: On 08/31/2018 02:30 PM, Emil Velikov wrote: On 31 August 2018 at 12:54,

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

2018-08-31 Thread Michel Dänzer
On 2018-08-31 4:46 p.m., Thomas Hellstrom wrote: > On 08/31/2018 04:38 PM, Michel Dänzer wrote: >> [ Adding the amd-gfx list ] >> >> On 2018-08-31 3:05 p.m., Thomas Hellstrom wrote: >>> On 08/31/2018 02:30 PM, Emil Velikov wrote: On 31 August 2018 at 12:54, Thomas Hellstrom wrote: >

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

2018-08-31 Thread Thomas Hellstrom
On 08/31/2018 04:38 PM, Michel Dänzer wrote: [ Adding the amd-gfx list ] On 2018-08-31 3:05 p.m., Thomas Hellstrom wrote: On 08/31/2018 02:30 PM, Emil Velikov wrote: On 31 August 2018 at 12:54, Thomas Hellstrom wrote: To determine whether a device node is a drm device node or not, the code

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

2018-08-31 Thread Michel Dänzer
[ Adding the amd-gfx list ] On 2018-08-31 3:05 p.m., Thomas Hellstrom wrote: > On 08/31/2018 02:30 PM, Emil Velikov wrote: >> On 31 August 2018 at 12:54, Thomas Hellstrom >> wrote: >>> To determine whether a device node is a drm device node or not, the code >>> currently compares the node's

[PATCH 1/2] drm/amdgpu: move size calculations to the front of the file again

2018-08-31 Thread Christian König
amdgpu_vm_bo_* functions should come much later. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 90 +- 1 file changed, 45 insertions(+), 45 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 2/2] drm/amdgpu: improve VM state machine documentation

2018-08-31 Thread Christian König
Since we have a lot of FAQ on the VM state machine try to improve the documentation by adding functions for each state move. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 107 - 1 file changed, 79 insertions(+), 28 deletions(-) diff

[PATCH 2/3] drm/amdgpu: fix "use bulk moves for efficient VM LRU handling" v2

2018-08-31 Thread Christian König
First step to fix the LRU corruption, we accidentially tried to move things on the LRU after dropping the lock. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 3/3] drm/amdgpu: fix idle state and bulk_moveavle flag

2018-08-31 Thread Christian König
Add BOs to the idle state again and correctly clear the flag when new BOs are added. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper

2018-08-31 Thread Christian König
Staring at the function for six hours, just to essentially move one line of code. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index

[PATCH xf86-video-amdgpu] Do not push the CM_GAMMA_LUT property values in drmmode_crtc_cm_init

2018-08-31 Thread Michel Dänzer
From: Michel Dänzer The crtc->gamma_lut values aren't initialized yet at this point, and the property values are pushed again from drmmode_setup_colormap anyway. Fixes intermittent flicker due to random gamma LUT values during server startup. Signed-off-by: Michel Dänzer ---

Re: [PATCH v2 00/12] remove_conflicting_framebuffers() cleanup

2018-08-31 Thread Chris Wilson
Quoting Daniel Vetter (2018-08-31 10:04:39) > On Thu, Aug 30, 2018 at 11:00:01PM +0200, Michał Mirosław wrote: > > This series cleans up duplicated code for replacing firmware FB > > driver with proper DRI driver and adds handover support to > > Tegra driver. > > > > This is a sligtly updated

Re: [PATCH v2 00/12] remove_conflicting_framebuffers() cleanup

2018-08-31 Thread Daniel Vetter
On Thu, Aug 30, 2018 at 11:00:01PM +0200, Michał Mirosław wrote: > This series cleans up duplicated code for replacing firmware FB > driver with proper DRI driver and adds handover support to > Tegra driver. > > This is a sligtly updated version of a series sent on 24 Nov 2017. > > v2: > -

Re: [PATCH v2 02/12] fbdev: allow apertures == NULL in remove_conflicting_framebuffers()

2018-08-31 Thread Daniel Vetter
On Fri, Aug 31, 2018 at 10:56:56AM +0200, Daniel Vetter wrote: > On Thu, Aug 30, 2018 at 11:00:05PM +0200, Michał Mirosław wrote: > > Interpret (otherwise-invalid) NULL apertures argument to mean all-memory > > range. This will allow to remove several duplicates of this code from > > drivers in

Re: [PATCH (repost) 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-31 Thread Hans Verkuil
On 08/24/2018 04:59 PM, Alex Deucher wrote: > On Fri, Aug 24, 2018 at 3:20 AM Hans Verkuil wrote: >> >> On 08/23/2018 08:38 PM, Harry Wentland wrote: >>> On 2018-08-17 10:11 AM, Hans Verkuil wrote: From: Hans Verkuil Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu.

Re: [PATCH 1/4] drm/amdgpu/gmc9: rework stolen vga memory handling

2018-08-31 Thread Christian König
Am 30.08.2018 um 16:53 schrieb Alex Deucher: No functional change, just rework it in order to adjust the behavior on a per asic level. The problem is that on vega10, something corrupts the lower 8 MB of vram on the second resume from S3. Is that tested with engineering samples or production

[PATCH] drm/amd/powerplay: added vega20 overdrive support V3

2018-08-31 Thread Evan Quan
Added vega20 overdrive support based on existing OD sysfs APIs. However, the OD logics are simplified on vega20. So, the behavior will be a little different and works only on some limited levels. V2: fix typo fix commit description revise error logs add support for clock OD V3: