[PATCH 2/3] drm/amdgpu: separate per VM BOs from normal in the moved state

2018-09-01 Thread Christian König
Allows us to avoid taking the spinlock in more places. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 67 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 7 +++- 2 files changed, 38 insertions(+), 36 deletions(-) diff --git

[PATCH 1/3] drm/amdgpu: move size calculations to the front of the file again

2018-09-01 Thread Christian König
amdgpu_vm_bo_* functions should come much later. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 90 +- 1 file changed, 45 insertions(+), 45 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 3/3] drm/amdgpu: improve VM state machine documentation

2018-09-01 Thread Christian König
Since we have a lot of FAQ on the VM state machine try to improve the documentation by adding functions for each state move. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 139 + 1 file changed, 108 insertions(+), 31 deletions(-)

Re: [PATCH 2/2] drm/amdgpu: improve VM state machine documentation

2018-09-01 Thread Christian König
Am 01.09.2018 um 18:45 schrieb Kuehling, Felix: @@ -1746,9 +1805,9 @@ int amdgpu_vm_bo_update(struct amdgpu_device *adev, uint32_t mem_type = bo->tbo.mem.mem_type; if (!(bo->preferred_domains & amdgpu_mem_type_to_domain(mem_type))) -

Re: [PATCH 2/2] drm/amdgpu: improve VM state machine documentation

2018-09-01 Thread Kuehling, Felix
>>> @@ -1746,9 +1805,9 @@ int amdgpu_vm_bo_update(struct amdgpu_device *adev, >>> uint32_t mem_type = bo->tbo.mem.mem_type; >>> >>> if (!(bo->preferred_domains & >>> amdgpu_mem_type_to_domain(mem_type))) >>> -list_add_tail(_va->base.vm_status,

Re: [PATCH 1/1] drm/amdgpu: Clean up KFD init and fini

2018-09-01 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Felix Kuehling Sent: Friday, August 31, 2018 5:34:42 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix Subject: [PATCH 1/1] drm/amdgpu: Clean up KFD init and fini Only initialize KFD once by moving

RE: [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.

2018-09-01 Thread Deng, Emily
Ok, then just ignore this patch. But seems didn't saw the patch on branch amd-staging-hybrid-master20180315. Best wishes Emily Deng >-Original Message- >From: Christian König >Sent: Saturday, September 1, 2018 4:17 PM >To: Deng, Emily ; amd-gfx@lists.freedesktop.org >Subject: Re:

Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.

2018-09-01 Thread Christian König
Am 01.09.2018 um 06:24 schrieb Emily Deng: The startx will have segmant fault if return success. SWDEV-163962 Change-Id: I56b189fa26efdcd1d96e5100af3f3e0b1208b0c3 Signed-off-by: Emily Deng Jerry already send a much better patch for this. --- amdgpu/amdgpu_bo.c | 4 +++- 1 file changed,

Re: [PATCH 2/2] drm/amdgpu: improve VM state machine documentation

2018-09-01 Thread Christian König
Am 01.09.2018 um 01:51 schrieb Felix Kuehling: Thanks for this. A few comments and a question inline. On 2018-08-31 09:27 AM, Christian König wrote: Since we have a lot of FAQ on the VM state machine try to improve the documentation by adding functions for each state move. Signed-off-by: