Re: [PATCH libdrm] Add basic CONTRIBUTING file

2018-09-03 Thread Dave Airlie
On Mon, 3 Sep 2018 at 18:47, Daniel Vetter wrote: > > I picked up a bunch of the pieces from wayland's version: > > https://gitlab.freedesktop.org/wayland/wayland/blob/master/CONTRIBUTING.md > > The weston one is fairly similar. Then I rather massively trimmed it > down since in reality libdrm is

Re: [PATCH 5/5] [RFC]drm: add syncobj timeline support v3

2018-09-03 Thread zhoucm1
On 2018年09月03日 19:19, Christian König wrote: Am 03.09.2018 um 12:07 schrieb Chunming Zhou: 在 2018/9/3 16:50, Christian König 写道: Am 03.09.2018 um 06:13 schrieb Chunming Zhou: 在 2018/8/30 19:32, Christian König 写道: [SNIP] + +struct drm_syncobj_wait_pt { +    struct drm_syncobj_stub_fe

Re: [PATCH] drm/amdgpu: enable AGP aperture for GMC9 v2

2018-09-03 Thread Zhang, Jerry (Junwei)
On 09/03/2018 08:22 PM, Christian König wrote: Enable the old AGP aperture to avoid GART mappings. v2: don't enable it for SRIOV Signed-off-by: Christian König Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 10 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c

Re: [PATCH libdrm] amdgpu: fix typo in function comment

2018-09-03 Thread Zhang, Jerry (Junwei)
On 09/03/2018 06:59 PM, Qiang Yu wrote: Signed-off-by: Qiang Yu Reviewed-by: Junwei Zhang --- amdgpu/amdgpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index dc51659..e6ec7a8 100644 --- a/amdgpu/amdgpu.h +++ b/amdgpu/amdgpu.h @@

[RFC] drm/amdgpu: Add macros and documentation for format modifiers.

2018-09-03 Thread Bas Nieuwenhuizen
This is an initial proposal for format modifiers for AMD hardware. It uses 48 bits including a chip generation, leaving 8 bits for a format version number. On gfx6-gfx8 we have all the fields influencing sample locations in memory. Tile split bytes are optional for single sample buffers as no ha

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

2018-09-03 Thread Thomas Hellstrom
On 09/03/2018 06:33 PM, Daniel Vetter wrote: On Mon, Sep 03, 2018 at 11:16:29AM +0200, Thomas Hellstrom wrote: On 08/31/2018 05:30 PM, Thomas Hellstrom wrote: On 08/31/2018 05:27 PM, Emil Velikov wrote: On 31 August 2018 at 15:38, Michel Dänzer wrote: [ Adding the amd-gfx list ] On 2018-08-

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

2018-09-03 Thread Daniel Vetter
On Mon, Sep 03, 2018 at 11:16:29AM +0200, Thomas Hellstrom wrote: > On 08/31/2018 05:30 PM, Thomas Hellstrom wrote: > > On 08/31/2018 05:27 PM, Emil Velikov wrote: > > > On 31 August 2018 at 15:38, Michel Dänzer wrote: > > > > [ Adding the amd-gfx list ] > > > > > > > > On 2018-08-31 3:05 p.m., T

Re: [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup

2018-09-03 Thread Daniel Vetter
On Mon, Sep 03, 2018 at 01:31:34PM +0200, Bartlomiej Zolnierkiewicz wrote: > On Monday, September 03, 2018 09:43:15 AM Daniel Vetter wrote: > > On Sat, Sep 01, 2018 at 04:08:41PM +0200, Michał Mirosław wrote: > > > This series cleans up duplicated code for replacing firmware FB > > > driver with pr

Re: [PATCH v3 04/13] fbdev: add remove_conflicting_pci_framebuffers()

2018-09-03 Thread Daniel Vetter
On Sat, Sep 01, 2018 at 04:08:45PM +0200, Michał Mirosław wrote: > Almost all PCI drivers using remove_conflicting_framebuffers() wrap it > with the same code. > > --- This cuts away the sob. Just fyi. -Daniel > v2: add kerneldoc for DRM helper > v3: propagate remove_conflicting_framebuffers() r

[PATCH] drm/amdgpu: enable AGP aperture for GMC9 v2

2018-09-03 Thread Christian König
Enable the old AGP aperture to avoid GART mappings. v2: don't enable it for SRIOV Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 10 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c| 2 ++ drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 10 +- 3 files chan

Re: [PATCH] gpu: drm: drm_mm: Fix a sleep-in-atomic-context bug in show_leaks()

2018-09-03 Thread Christian König
Am 03.09.2018 um 09:52 schrieb Daniel Vetter: On Sat, Sep 01, 2018 at 01:32:54PM +0100, Chris Wilson wrote: Quoting Jia-Ju Bai (2018-09-01 13:20:41) The driver may sleep with holding a spinlock. The function call paths (from bottom to top) in Linux-4.16 are: [FUNC] kmalloc(GFP_KERNEL) drivers

Re: [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup

2018-09-03 Thread Bartlomiej Zolnierkiewicz
On Monday, September 03, 2018 09:43:15 AM Daniel Vetter wrote: > On Sat, Sep 01, 2018 at 04:08:41PM +0200, Michał Mirosław wrote: > > This series cleans up duplicated code for replacing firmware FB > > driver with proper DRI driver and adds handover support to > > Tegra driver. > > > > This is a s

Re: [PATCH 5/5] [RFC]drm: add syncobj timeline support v3

2018-09-03 Thread Christian König
Am 03.09.2018 um 12:07 schrieb Chunming Zhou: 在 2018/9/3 16:50, Christian König 写道: Am 03.09.2018 um 06:13 schrieb Chunming Zhou: 在 2018/8/30 19:32, Christian König 写道: [SNIP] + +struct drm_syncobj_wait_pt { +    struct drm_syncobj_stub_fence base; +    u64    value; +    struct rb_node

[PATCH libdrm] amdgpu: fix typo in function comment

2018-09-03 Thread Qiang Yu
Signed-off-by: Qiang Yu --- amdgpu/amdgpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index dc51659..e6ec7a8 100644 --- a/amdgpu/amdgpu.h +++ b/amdgpu/amdgpu.h @@ -731,7 +731,7 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle); void am

Re: [PATCH libdrm] amdgpu: amdgpu_bo_inc_ref don't return dummy int

2018-09-03 Thread Yu, Qiang
Sorry for not check this patch carefully, indeed a typo, will revert it. Regards, Qiang From: Christian König Sent: Monday, September 3, 2018 6:40:33 PM To: Michel Dänzer; Yu, Qiang Cc: Zhang, Jerry; Koenig, Christian; amd-gfx@lists.freedesktop.org; Deng,

Re: [PATCH libdrm] amdgpu: amdgpu_bo_inc_ref don't return dummy int

2018-09-03 Thread Christian König
Am 03.09.2018 um 12:13 schrieb Michel Dänzer: On 2018-09-03 12:06 p.m., Qiang Yu wrote: Signed-off-by: Qiang Yu --- amdgpu/amdgpu-symbol-check | 2 +- amdgpu/amdgpu.h| 5 + amdgpu/amdgpu_bo.c | 3 +-- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/am

Re: [PATCH libdrm] amdgpu: amdgpu_bo_inc_ref don't return dummy int

2018-09-03 Thread Michel Dänzer
On 2018-09-03 12:06 p.m., Qiang Yu wrote: > Signed-off-by: Qiang Yu > --- > amdgpu/amdgpu-symbol-check | 2 +- > amdgpu/amdgpu.h| 5 + > amdgpu/amdgpu_bo.c | 3 +-- > 3 files changed, 3 insertions(+), 7 deletions(-) > > diff --git a/amdgpu/amdgpu-symbol-check b/amdgpu/amd

Re: [PATCH 5/5] [RFC]drm: add syncobj timeline support v3

2018-09-03 Thread Chunming Zhou
在 2018/9/3 16:50, Christian König 写道: Am 03.09.2018 um 06:13 schrieb Chunming Zhou: 在 2018/8/30 19:32, Christian König 写道: [SNIP] + +struct drm_syncobj_wait_pt { +    struct drm_syncobj_stub_fence base; +    u64    value; +    struct rb_node   node; +}; +struct drm_syncobj_signal_pt { + 

[PATCH libdrm] amdgpu: amdgpu_bo_inc_ref don't return dummy int

2018-09-03 Thread Qiang Yu
Signed-off-by: Qiang Yu --- amdgpu/amdgpu-symbol-check | 2 +- amdgpu/amdgpu.h| 5 + amdgpu/amdgpu_bo.c | 3 +-- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/amdgpu/amdgpu-symbol-check b/amdgpu/amdgpu-symbol-check index 487610e..58646e8 100755 --- a/amdgp

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function.

2018-09-03 Thread Yu, Qiang
>> amdgpu_bo_free >> +amdgpu_bo_inc_ref >> amdgpu_bo_import >> amdgpu_bo_list_create >> amdgpu_bo_list_destroy > > Thanks for remembering to add the symbol here, but amdgpu_bo_inc_ref > goes after amdgpu_bo_import in lexical order. :) Oh, haven't notice this is in alphabetic order. >> >> +int

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function.

2018-09-03 Thread Michel Dänzer
On 2018-09-03 8:55 a.m., Qiang Yu wrote: > For Pro OGL be able to work with upstream libdrm. > > Signed-off-by: Qiang Yu > Reviewed-by: Christian König > --- > amdgpu/amdgpu-symbol-check | 1 + > amdgpu/amdgpu.h| 15 ++- > amdgpu/amdgpu_bo.c | 6 ++ > 3 fil

Re: [PATCH libdrm] libdrm: Allow dynamic drm majors on linux

2018-09-03 Thread Thomas Hellstrom
On 08/31/2018 05:30 PM, Thomas Hellstrom wrote: On 08/31/2018 05:27 PM, Emil Velikov wrote: On 31 August 2018 at 15:38, Michel Dänzer wrote: [ Adding the amd-gfx list ] On 2018-08-31 3:05 p.m., Thomas Hellstrom wrote: On 08/31/2018 02:30 PM, Emil Velikov wrote: On 31 August 2018 at 12:54, T

Re: [PATCH] drm/amdgpu: improve VM state machine documentation v2

2018-09-03 Thread Zhang, Jerry (Junwei)
On 09/03/2018 05:08 PM, Christian König wrote: Since we have a lot of FAQ on the VM state machine try to improve the documentation by adding functions for each state move. v2: fix typo in amdgpu_vm_bo_invalidated, use amdgpu_vm_bo_relocated in one more place as well. Signed-off-by: Christi

Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.

2018-09-03 Thread Zhang, Jerry (Junwei)
On 09/03/2018 04:44 PM, Christian König wrote: Am 03.09.2018 um 09:16 schrieb Zhang, Jerry (Junwei): On 09/03/2018 03:11 PM, Christian König wrote: About master branch, needs someone's help with correct permission. I've already took care of that on the weekend. Thank you again. BTW, how to a

[PATCH] drm/amdgpu: improve VM state machine documentation v2

2018-09-03 Thread Christian König
Since we have a lot of FAQ on the VM state machine try to improve the documentation by adding functions for each state move. v2: fix typo in amdgpu_vm_bo_invalidated, use amdgpu_vm_bo_relocated in one more place as well. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_v

Re: [PATCH] drm/amdgpu: fix amdgpu_mn_unlock() in the CS error path

2018-09-03 Thread Zhang, Jerry (Junwei)
On 09/03/2018 04:53 PM, Christian König wrote: Avoid unlocking a lock we never locked. Signed-off-by: Christian König Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function.

2018-09-03 Thread Yu, Qiang
Thanks. Regards, Qiang From: Christian König Sent: Monday, September 3, 2018 4:57:39 PM To: Yu, Qiang; Zhang, Jerry; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian; Deng, Hui Subject: Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function. Done

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function.

2018-09-03 Thread Christian König
Done. Christian. Am 03.09.2018 um 10:03 schrieb Yu, Qiang: Thanks Jerry. Hi Christian, This is an old patch back to 2016 reviewed in hybrid list. If you are OK with it, would you please submit it to upstream? Thanks, Qiang From: amd-gfx on behalf o

[PATCH] drm/amdgpu: fix amdgpu_mn_unlock() in the CS error path

2018-09-03 Thread Christian König
Avoid unlocking a lock we never locked. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 349dcc37ee64..04a2733b5ccc

Re: [PATCH 5/5] [RFC]drm: add syncobj timeline support v3

2018-09-03 Thread Christian König
Am 03.09.2018 um 06:13 schrieb Chunming Zhou: 在 2018/8/30 19:32, Christian König 写道: [SNIP] + +struct drm_syncobj_wait_pt { +    struct drm_syncobj_stub_fence base; +    u64    value; +    struct rb_node   node; +}; +struct drm_syncobj_signal_pt { +    struct drm_syncobj_stub_fence base; + 

[PATCH libdrm] Add basic CONTRIBUTING file

2018-09-03 Thread Daniel Vetter
I picked up a bunch of the pieces from wayland's version: https://gitlab.freedesktop.org/wayland/wayland/blob/master/CONTRIBUTING.md The weston one is fairly similar. Then I rather massively trimmed it down since in reality libdrm is a bit a dumping ground with very few real rules. The commit rig

Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.

2018-09-03 Thread Christian König
Am 03.09.2018 um 09:16 schrieb Zhang, Jerry (Junwei): On 09/03/2018 03:11 PM, Christian König wrote: About master branch, needs someone's help with correct permission. I've already took care of that on the weekend. Thank you again. BTW, how to apply that permission? Previously that was done

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function.

2018-09-03 Thread Yu, Qiang
Thanks Jerry. Hi Christian, This is an old patch back to 2016 reviewed in hybrid list. If you are OK with it, would you please submit it to upstream? Thanks, Qiang From: amd-gfx on behalf of Zhang, Jerry (Junwei) Sent: Monday, September 3, 2018 3:18:

Re: [PATCH] gpu: drm: drm_mm: Fix a sleep-in-atomic-context bug in show_leaks()

2018-09-03 Thread Daniel Vetter
On Sat, Sep 01, 2018 at 01:32:54PM +0100, Chris Wilson wrote: > Quoting Jia-Ju Bai (2018-09-01 13:20:41) > > The driver may sleep with holding a spinlock. > > > > The function call paths (from bottom to top) in Linux-4.16 are: > > > > [FUNC] kmalloc(GFP_KERNEL) > > drivers/gpu/drm/drm_mm.c, 130:

Re: [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup

2018-09-03 Thread Daniel Vetter
On Sat, Sep 01, 2018 at 04:08:41PM +0200, Michał Mirosław wrote: > This series cleans up duplicated code for replacing firmware FB > driver with proper DRI driver and adds handover support to > Tegra driver. > > This is a sligtly updated version of a series sent on 24 Nov 2017. > > --- > v2: > -

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function.

2018-09-03 Thread Zhang, Jerry (Junwei)
On 09/03/2018 02:55 PM, Qiang Yu wrote: For Pro OGL be able to work with upstream libdrm. Signed-off-by: Qiang Yu Reviewed-by: Christian König I'm fine with that, not sure if mesa is going to use that as well. Reviewed-by: Junwei Zhang Regards, Jerry --- amdgpu/amdgpu-symbol-check |

Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.

2018-09-03 Thread Zhang, Jerry (Junwei)
On 09/03/2018 03:11 PM, Christian König wrote: About master branch, needs someone's help with correct permission. I've already took care of that on the weekend. Thank you again. BTW, how to apply that permission? Regards, Jerry Regards, Christian. Am 03.09.2018 um 03:42 schrieb Zhang, Jer

build on CentOS 7.3 hostos: too few arguments to function ‘notify_change’

2018-09-03 Thread Acewind
After download code from https://github.com/GPUOpen-LibrariesAndSDKs/MxGPU-Virtualization, I try to compile MxGPU-Virtualization-master source on my CentOS 7.3 host, but got an error. Do I need to change the kernel of hostos? [root@myhost drv]# uname -r 3.10.0-514.el7.x86_64 [root@myhost drv]#

Re: [PATCH libdrm] amdgpu: When couldn't find bo, need to return error.

2018-09-03 Thread Christian König
About master branch, needs someone's help with correct permission. I've already took care of that on the weekend. Regards, Christian. Am 03.09.2018 um 03:42 schrieb Zhang, Jerry (Junwei): On 09/01/2018 04:58 PM, Deng, Emily wrote: Ok, then just ignore this patch. But seems didn't saw the patch